[00:02:26] (03CR) 10Jdlrobson: "Done." [core] - 10https://gerrit.wikimedia.org/r/1007735 (https://phabricator.wikimedia.org/T358813) (owner: 10Jdlrobson) [00:03:39] (03Merged) 10jenkins-bot: Mark addStyleTag as public [core] - 10https://gerrit.wikimedia.org/r/1007940 (https://phabricator.wikimedia.org/T358391) (owner: 10Jdlrobson) [00:03:58] (03CR) 10Eric Gardner: build: Re-organize Codex design tokens (031 comment) [design/codex] - 10https://gerrit.wikimedia.org/r/1007474 (https://phabricator.wikimedia.org/T358031) (owner: 10Eric Gardner) [00:06:45] (03PS3) 10Krinkle: PoolCounter: Adopt PSR logger in PoolCounter objects [core] - 10https://gerrit.wikimedia.org/r/1007957 (https://phabricator.wikimedia.org/T358901) [00:07:38] (03CR) 10Jdlrobson: [C: 03+1] Output skin related styles after SkinModule feature styles [core] - 10https://gerrit.wikimedia.org/r/1007343 (https://phabricator.wikimedia.org/T354975) (owner: 10Jdrewniak) [00:11:26] 10MediaWiki-Core-Skin-Architecture, 06MediaWiki-Platform-Team, 10MediaWiki-ResourceLoader, 10Desktop Improvements (Vector 2022), and 4 others: [carryover] ResourceLoaderSkinModule should load core styles before skin styles - https://phabricator.wikimedia.org/T354975#9592705 (10Jdlrobson) a:05Jdrewniak→0... [00:16:27] (03CR) 10CI reject: [V: 04-1] TempUserConfig: Deduplicate code generating match conditions [core] - 10https://gerrit.wikimedia.org/r/1007985 (owner: 10Bartosz Dziewoński) [00:17:54] 06Front-end-Standards-Group, 06Tech-Docs-Team, 07Documentation, 07Epic, and 3 others: Replace jsduck with JSDoc3 across all Wikimedia code bases - https://phabricator.wikimedia.org/T138401#9592723 (10apaskulin) [00:17:59] 10JSDoc WMF theme, 13Patch-For-Review: Migrate @cfg tags - https://phabricator.wikimedia.org/T357169#9592724 (10apaskulin) [00:24:59] (03CR) 10CI reject: [V: 04-1] PoolCounter: Adopt PSR logger in PoolCounter objects [core] - 10https://gerrit.wikimedia.org/r/1007957 (https://phabricator.wikimedia.org/T358901) (owner: 10Krinkle) [00:30:18] (03PS3) 10Jdlrobson: docs: Migrate @cfg tags to JSDoc [core] - 10https://gerrit.wikimedia.org/r/1007974 (https://phabricator.wikimedia.org/T357169) (owner: 10Alex Paskulin) [00:31:21] (03CR) 10Jdlrobson: [C: 03+2] docs: Migrate @cfg tags to JSDoc (031 comment) [core] - 10https://gerrit.wikimedia.org/r/1007974 (https://phabricator.wikimedia.org/T357169) (owner: 10Alex Paskulin) [00:35:36] (03PS4) 10Krinkle: PoolCounter: Adopt PSR logger in PoolCounter objects [core] - 10https://gerrit.wikimedia.org/r/1007957 (https://phabricator.wikimedia.org/T358901) [00:38:06] (03Abandoned) 10HMonroy: Reload page when discarding changes after showing/preview changes [core] - 10https://gerrit.wikimedia.org/r/1006095 (https://phabricator.wikimedia.org/T354494) (owner: 10HMonroy) [00:38:28] (03CR) 10Krinkle: PoolCounter: Adopt PSR logger in PoolCounter objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/1007957 (https://phabricator.wikimedia.org/T358901) (owner: 10Krinkle) [00:38:42] (03PS1) 10TrainBranchBot: Branch commit for wmf/branch_cut_pretest [core] (wmf/branch_cut_pretest) - 10https://gerrit.wikimedia.org/r/1007681 [00:38:44] (03CR) 10TrainBranchBot: [C: 03+2] Branch commit for wmf/branch_cut_pretest [core] (wmf/branch_cut_pretest) - 10https://gerrit.wikimedia.org/r/1007681 (owner: 10TrainBranchBot) [00:40:22] 04(no projects): Excessive space after p tags is causing new spacing issues - https://phabricator.wikimedia.org/T358921#9592775 (10Jack_who_built_the_house) As for paragraphs inside `blockquote`, in [resources/skins.vector.styles/typography.less$164](https://phabricator.wikimedia.org/source/Vector/browse/master... [00:41:19] (03PS5) 10Krinkle: PoolCounter: Adopt PSR logger in PoolCounter objects [core] - 10https://gerrit.wikimedia.org/r/1007957 (https://phabricator.wikimedia.org/T358901) [00:41:53] (03PS4) 10Eric Gardner: build: Re-organize Codex design tokens [design/codex] - 10https://gerrit.wikimedia.org/r/1007474 (https://phabricator.wikimedia.org/T358031) [00:42:27] (03CR) 10Eric Gardner: build: Re-organize Codex design tokens (031 comment) [design/codex] - 10https://gerrit.wikimedia.org/r/1007474 (https://phabricator.wikimedia.org/T358031) (owner: 10Eric Gardner) [00:44:20] (03PS2) 10Scardenasmolinar: Skip bot accounts [extensions/AutoModerator] - 10https://gerrit.wikimedia.org/r/1007751 (https://phabricator.wikimedia.org/T352440) [00:50:11] (03CR) 10CI reject: [V: 04-1] docs: Migrate @cfg tags to JSDoc [core] - 10https://gerrit.wikimedia.org/r/1007974 (https://phabricator.wikimedia.org/T357169) (owner: 10Alex Paskulin) [00:51:10] 07Accessibility, 10MediaWiki-Parser, 101.42.0-wmf.20; 2024-02-27, 07Epic, and 5 others: .mw-editsection links should not be part of the element - https://phabricator.wikimedia.org/T13555#9592779 (10Jack_who_built_the_house) DT's subscribe button is now inside `span.mw-headline` which is inside `h2`. D... [00:56:21] (03PS5) 10Eric Gardner: build: Re-organize Codex design tokens [design/codex] - 10https://gerrit.wikimedia.org/r/1007474 (https://phabricator.wikimedia.org/T358031) [00:59:23] 10MediaWiki-Parser, 101.42.0-wmf.21; 2024-03-05, 10Radar: Revert PoolWorkArticleViewCurrent tangling from ParserCache - https://phabricator.wikimedia.org/T352837#9592782 (10Krinkle) 05Open→03Resolved [01:00:02] (03PS1) 10Krinkle: parser: Remove LoggerSpi override from ParserOutputAccessTest [core] - 10https://gerrit.wikimedia.org/r/1007987 (https://phabricator.wikimedia.org/T358901) [01:00:39] (03Merged) 10jenkins-bot: Branch commit for wmf/branch_cut_pretest [core] (wmf/branch_cut_pretest) - 10https://gerrit.wikimedia.org/r/1007681 (owner: 10TrainBranchBot) [01:04:57] (03PS3) 10Arlolra: Use a class instead of an assoc array for cache entry [wikipeg] - 10https://gerrit.wikimedia.org/r/997981 [01:05:52] (03PS4) 10Arlolra: Use a class instead of an assoc array for cache entry [wikipeg] - 10https://gerrit.wikimedia.org/r/997981 [01:30:36] 07Accessibility, 10MediaWiki-Parser, 101.42.0-wmf.20; 2024-02-27, 07Epic, and 5 others: .mw-editsection links should not be part of the element - https://phabricator.wikimedia.org/T13555#9592812 (10Pols12) >>! In T13555#9592779, @Jack_who_built_the_house wrote: > DT's subscribe button is now inside `s... [01:39:23] 10MediaWiki-File-management, 06Commons, 10WMF-JobQueue: Increase timeout on AssembleUploadChunksJob - https://phabricator.wikimedia.org/T358308#9592818 (10Bawolff) Reading config files, it seems like the timeout should already be about 7 minutes (change-propagation DEFAULT_REQUEST_TIMEOUT = 7 minutes. job ru... [01:44:03] 03Google Season of Docs 2024: Reducing Duplication and Enhancing Accessibility of MediaWiki - https://phabricator.wikimedia.org/T358821#9592820 (10apaskulin) a:03NidhiParab Hi @NidhiParab, Thanks for your interest in Season of Docs! I really like the detail you put into your timeline. A few requests: - Can you... [01:48:52] 10MediaWiki-File-management, 06Commons, 10WMF-JobQueue: Increase timeout on AssembleUploadChunksJob - https://phabricator.wikimedia.org/T358308#9592824 (10Bawolff) Oh, i see that deployment-charts/charts/mediawiki/values.yaml has an upstream_timeout set to 180.0 seconds. I believe mw-jobrunners will inherit... [01:51:09] 06Discovery-Search, 10Wikifunctions: [wmf.20] Bad request for Special:RunJobs page - https://phabricator.wikimedia.org/T358938 (10Etonkovidova) [01:52:07] 10Codex, 06Design-System-Team, 10Desktop Improvements (Vector 2022), 101.42.0-wmf.20; 2024-02-27, 07Verified: Codex icons in Vector and Minerva are displaying incorrectly - https://phabricator.wikimedia.org/T358160#9592841 (10Edtadros) === Test Result - Prod **Status:** ✅ PASS **Environment:** enwiki **... [01:54:12] 10Codex, 06Design-System-Team, 10Desktop Improvements (Vector 2022), 101.42.0-wmf.20; 2024-02-27, 07Verified: Codex icons in Vector and Minerva are displaying incorrectly - https://phabricator.wikimedia.org/T358160#9592844 (10Edtadros) [01:59:12] 10MediaWiki-File-management, 06Commons, 10WMF-JobQueue: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes - https://phabricator.wikimedia.org/T358308#9592851 (10Bawolff) [02:00:36] 10FY2023-24-WE 2.1 Typography and palette customizations, 10MinervaNeue, 101.42.0-wmf.20; 2024-02-27, 13Patch-For-Review, 07Verified: Implement the new night mode color palette in Minerva - https://phabricator.wikimedia.org/T356825#9592848 (10Edtadros) Not testable in production. [02:01:11] 10MediaWiki-File-management, 06Commons, 10WMF-JobQueue: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes - https://phabricator.wikimedia.org/T358308#9592854 (10Bawolff) [02:01:29] 10MinervaNeue: Community discussion about hacks.less - https://phabricator.wikimedia.org/T358078#9592855 (10Jdlrobson) Hey @Izno if we were to flesh out https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaMessages/+/1007990 (which has examples for hatnote and navbox templates) I think this would help... [02:09:06] 10MobileFrontend, 10FY2023-24-WE 2.1 Typography and palette customizations, 101.42.0-wmf.20; 2024-02-27, 07Verified: Update MobileFrontend codebase to use CSS variables - https://phabricator.wikimedia.org/T356427#9592857 (10Edtadros) === Test Result - Prod **Status:** ✅ PASS **Environment:** enwiki **OS:*... [02:09:13] 10MediaWiki-File-management, 06Commons, 10WMF-JobQueue: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes - https://phabricator.wikimedia.org/T358308#9592860 (10Bawolff) [02:10:19] 10MobileFrontend, 10FY2023-24-WE 2.1 Typography and palette customizations, 101.42.0-wmf.20; 2024-02-27, 07Verified: Update MobileFrontend codebase to use CSS variables - https://phabricator.wikimedia.org/T356427#9592861 (10Edtadros) [02:13:28] 06Abstract Wikipedia team, 10WikiLambda Front-end, 101.42.0-wmf.21; 2024-03-05: Special:RunFunction - improvements needed for messages to users - https://phabricator.wikimedia.org/T346852#9592865 (10Etonkovidova) Checked in `wikifuctions beta` - works as expected; the message "This function has no approved... [02:13:47] 10Desktop Improvements (Vector 2022), 10Vector (legacy skin), 10Needs Prioritization (Tech), 07Technical-Debt: Vector-2022.js should no longer load legacy Vector site and user scripts/styles - https://phabricator.wikimedia.org/T301212#9592862 (10Jdlrobson) [02:13:51] 10Desktop Improvements (Vector 2022), 10Vector (legacy skin), 10Needs Prioritization (Tech), 07Technical-Debt: Vector-2022.js should no longer load legacy Vector site and user scripts/styles - https://phabricator.wikimedia.org/T301212#9592869 (10Jdlrobson) [02:23:26] 06Wikipedia-Android-App-Backlog: Add Saved Messages translations for id, es, fr, zh into the codebase - https://phabricator.wikimedia.org/T358816#9592877 (10JTannerWMF) [03:27:22] 07VerySmallGLAM: SMALL GLAM SLAM Pilot 1: Define requirements - https://phabricator.wikimedia.org/T356198#9592898 (10Peachey88) [03:41:26] 10Automoderator, 10Kanban, 13Patch-For-Review: Automoderator should not revert bot edits - https://phabricator.wikimedia.org/T352440#9592901 (10Scardenasmolinar) Should we create a new spike about changing hooks or should this be addressed in this ticket? [04:08:03] 10Automoderator, 10Kanban, 13Patch-For-Review: Automoderator should not revert bot edits - https://phabricator.wikimedia.org/T352440#9592902 (10jsn.sherman) Let's do that in another task. I think the solution in the patch is reasonable for the current hook. [04:22:19] (03CR) 10Scardenasmolinar: "Thank you for working on this! I just have a tiny nit, otherwise this is good to merge." [extensions/AutoModerator] - 10https://gerrit.wikimedia.org/r/1007345 (https://phabricator.wikimedia.org/T352678) (owner: 10Jsn.sherman) [04:32:05] 06Movement-Insights, 10Movement-Metrics: Consolidate and update movement metrics process documentation - https://phabricator.wikimedia.org/T358730#9592903 (10nshahquinn-wmf) I've revised and overhauled the main documentation, and moved it to the Meta page (now named [meta:Movement Insights/Monthly metrics proc... [05:01:37] 10ChangeProp, 10WMF-JobQueue: change-propogation service retries jobs that set RunnableJob::allowsRetries() false after a timeout - https://phabricator.wikimedia.org/T358939 (10Bawolff) [05:04:38] (03PS1) 10Brian Wolff: Add comment warning about how allowRetries() ignored during timeout [core] - 10https://gerrit.wikimedia.org/r/1007994 (https://phabricator.wikimedia.org/T358939) [05:07:22] (03PS2) 10Brian Wolff: Add comment warning about how allowRetries() ignored during timeout [core] - 10https://gerrit.wikimedia.org/r/1007994 (https://phabricator.wikimedia.org/T358939) [05:10:49] 06MediaWiki-Engineering, 06Data-Engineering, 10WMF-JobQueue, 06serviceops, and 3 others: Could not enqueue jobs: "Unable to deliver all events: 503: Service Unavailable" - https://phabricator.wikimedia.org/T249745#9592919 (10aaron) I couple things I wonder about: * Though the bottleneck seems to be EventGa... [05:32:44] (03PS2) 10Bartosz Dziewoński: TempUserConfig: Deduplicate code generating match conditions [core] - 10https://gerrit.wikimedia.org/r/1007985 [05:32:45] (03PS1) 10Bartosz Dziewoński: ChangesListSpecialPage: Refactor user experience conditions [core] - 10https://gerrit.wikimedia.org/r/1007995 (https://phabricator.wikimedia.org/T358932) [05:38:16] 10Project-requests: Request creation of wikiauthbot-ng VPS project - https://phabricator.wikimedia.org/T358427#9592924 (100xDeadbeef) Per https://github.com/wikimedia/operations-puppet/blob/ee02ed8031f246dd4f309bb7e83eeb9a8f285f51/modules/profile/manifests/toolforge/redis_sentinel.pp#L79-L80 and https://redis.io... [05:40:58] 10Phabricator, 10GerritBot: GerritBot comments for 7-digit Gerrit changes conflict with Diffusion commit hashes - https://phabricator.wikimedia.org/T358940 (10matmarex) [05:49:37] (03CR) 10Bartosz Dziewoński: "Failure is a false positive, I'm refactoring some code in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1007985 in a way that will avo" [core] - 10https://gerrit.wikimedia.org/r/968264 (owner: 10Bartosz Dziewoński) [05:49:50] (03PS4) 10Bartosz Dziewoński: Annotate SQL expression builder methods with @phan-side-effect-free [core] - 10https://gerrit.wikimedia.org/r/968264 [06:00:17] 10MediaWiki-File-management, 10WMF-JobQueue, 13Patch-For-Review: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes - https://phabricator.wikimedia.org/T358308#9592941 (10Peachey88) [06:07:11] 10Desktop Improvements (Vector 2022): Excessive space after p tags is causing new spacing issues - https://phabricator.wikimedia.org/T358921#9592942 (10Bugreporter) [06:33:38] 07Accessibility, 10MediaWiki-Parser, 101.42.0-wmf.20; 2024-02-27, 07Epic, and 5 others: .mw-editsection links should not be part of the element - https://phabricator.wikimedia.org/T13555#9592945 (10Jack_who_built_the_house) @Pols12 Yeah, I know. I have only "Enable topic subscriptions" enabled. My poi... [06:39:38] 10MediaWiki-File-management, 06Commons: Systematic HTTP 503 timeouts by uploading big (<100MB) TIFF images via API action=upload, without stash, without async - https://phabricator.wikimedia.org/T59717#9592946 (10Bawolff) 05Open→03Declined This bug is too old and too lacking in details to be actionable. Po... [06:42:13] 10MediaWiki-File-management, 06Commons: Warning needed if dimensions of reupload differ - https://phabricator.wikimedia.org/T14490#9592948 (10Bawolff) 05Open→03Declined I agree with Luke. If the commons community wants this, please reopen with a link to discussion. It may also be possible to implement th... [06:56:37] 10mwbot-rs: Allow more people to make mwbot-rs releases - https://phabricator.wikimedia.org/T358941 (10Legoktm) [07:05:40] 10ISA, 06Wiki-Mentor-Africa: prominence toggle should not be added as contribution - https://phabricator.wikimedia.org/T358942 (10Eugene233) [07:12:23] 10WMFI: Python/pillow does not handle TIFF-images correctly - https://phabricator.wikimedia.org/T358943 (10Ipr1) [07:13:56] 10WMFI: Python/pillow does not handle TIFF-images correctly - https://phabricator.wikimedia.org/T358943#9592986 (10Ipr1) See also other related bug reports resulting from pillow: https://phabricator.wikimedia.org/T354147 https://phabricator.wikimedia.org/T352942 [07:17:39] 10WMFI: Python/pillow does not handle TIFF-images correctly - https://phabricator.wikimedia.org/T358943#9592989 (10Ipr1) ` import imagehash import io import os import tempfile from PIL import Image def openimage(name): f = open(name, "rb") return Image.open(f) def getimagehash(img, hashlen=8): phas... [07:20:41] 10WMFI: Python/pillow does not handle TIFF-images correctly - https://phabricator.wikimedia.org/T358943#9592990 (10Ipr1) There is alternative library called PyLibTiff which uses the libtiff library. This might give better results (testing). [07:28:12] 10ISA, 06Wiki-Mentor-Africa, 13Patch-For-Review: prominence toggle should not be added as contribution - https://phabricator.wikimedia.org/T358942#9592993 (10Eugene233) 05Open→03Resolved [07:29:20] (03CR) 10Brian Wolff: [C: 03+2] specials: Handle false from MediaHandler::parseParamString [core] - 10https://gerrit.wikimedia.org/r/1006175 (owner: 10Umherirrender) [07:31:39] 10mwbot-rs: Allow more people to make mwbot-rs releases - https://phabricator.wikimedia.org/T358941#9592995 (10Legoktm) I've taken this opportunity to write up some documentation at https://www.mediawiki.org/wiki/Mwbot-rs/Releasing and created a [[https://crates.io/teams/github:mwbot-rs:cratesio|mwbot-rs org/tea... [07:35:39] 10mwbot-rs: Allow more people to make mwbot-rs releases - https://phabricator.wikimedia.org/T358941#9592996 (10mirror-kt) If you would give me that access, I would be happy to help. GitHub: https://github.com/mirror-kt Needless to say, if I have made a mistake in a release, please feel free to let me know. I th... [07:43:43] 10mwbot-rs: Allow more people to make mwbot-rs releases - https://phabricator.wikimedia.org/T358941#9592998 (10XtexChooser) If I could be helpful, [[https://github.com/xtexChooser]] [07:49:52] (03CR) 10Brian Wolff: [C: 03+2] "So after this change: move does 1 SHA1 calc, delete does 0, undelete does 1. These seem to be from LocalFile::maybeUpgradeRow() [in a defe" [core] - 10https://gerrit.wikimedia.org/r/1005568 (https://phabricator.wikimedia.org/T348294) (owner: 10Aaron Schulz) [07:50:07] (03Merged) 10jenkins-bot: specials: Handle false from MediaHandler::parseParamString [core] - 10https://gerrit.wikimedia.org/r/1006175 (owner: 10Umherirrender) [07:57:03] 10MediaWiki-extensions-PageExchange: Change word "Link" to domain name in Page Exchange URL display - https://phabricator.wikimedia.org/T358694#9593000 (10Jatinder190124) Hi @Yaron_Koren Greetings of the day As per my knowledge and the bug fixed yesterday should I start creating my proposal for the GSOC24 ?... [08:03:10] 10ISA, 06Wiki-Mentor-Africa: Return positive feedback to user on prominence change - https://phabricator.wikimedia.org/T358944 (10Eugene233) [08:10:45] (03Merged) 10jenkins-bot: filebackend: add FileStatePredicates helper class for file operations [core] - 10https://gerrit.wikimedia.org/r/1005568 (https://phabricator.wikimedia.org/T348294) (owner: 10Aaron Schulz) [08:21:42] 10ISA, 06Wiki-Mentor-Africa, 13Patch-For-Review: Return positive feedback to user on prominence change - https://phabricator.wikimedia.org/T358944#9593019 (10Eugene233) 05Open→03Resolved [08:28:18] (03PS1) 10Brian Wolff: Make verifyPartialFile reuse SHA1 hash if we already know [core] - 10https://gerrit.wikimedia.org/r/1007998 (https://phabricator.wikimedia.org/T200820) [08:30:26] (03CR) 10Brian Wolff: "I probably should have done this in befd8fcd9385186, so partially this is a follow-up. In most cases the SHA1 has not been populated yet b" [core] - 10https://gerrit.wikimedia.org/r/1007998 (https://phabricator.wikimedia.org/T200820) (owner: 10Brian Wolff) [08:34:42] (03PS1) 10Brian Wolff: Fix typo in log message [core] - 10https://gerrit.wikimedia.org/r/1007999 [08:38:31] 10MediaWiki-File-management, 06Commons, 13Patch-For-Review, 07Schema-change: Allow Mediawiki to store file size greater than 32 bits - https://phabricator.wikimedia.org/T191805#9593026 (10Bawolff) [08:39:47] 10MediaWiki-File-management, 06Commons, 06MW-Interfaces-Team, 13Patch-For-Review, 07Performance Issue: FSFileBackend spends a lot of time generating uneeded sha1 hashes that are expensive for large files - https://phabricator.wikimedia.org/T348294#9593024 (10Bawolff) 05Open→03Resolved When i was test... [08:46:22] (03CR) 10CI reject: [V: 04-1] Make verifyPartialFile reuse SHA1 hash if we already know [core] - 10https://gerrit.wikimedia.org/r/1007998 (https://phabricator.wikimedia.org/T200820) (owner: 10Brian Wolff) [08:49:52] 10MediaWiki-Uploading, 10SRE-swift-storage, 101.42.0-wmf.20; 2024-02-27, 13Patch-For-Review, 15User-revi: FAILED: stashfailed: Could not read file "mwstore://local-swift-eqiad/local-temp/a/ac/15xi9btm14os.u9p1dr.1208681.webm.0". - https://phabricator.wikimedia.org/T200820#9593027 (10Bawolff) On discord,... [08:56:04] (03CR) 10Matěj Suchánek: [C: 04-1] "Looks like this needs to be re-done from scratch, with temporary accounts in mind" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/818999 (https://phabricator.wikimedia.org/T314272) (owner: 10Matěj Suchánek) [08:56:59] (03PS2) 10Brian Wolff: Make verifyPartialFile reuse SHA1 hash if we already know [core] - 10https://gerrit.wikimedia.org/r/1007998 (https://phabricator.wikimedia.org/T200820) [09:40:09] 06MediaWiki-Engineering, 06Data-Engineering, 10WMF-JobQueue, 06serviceops, and 3 others: Could not enqueue jobs: "Unable to deliver all events: 503: Service Unavailable" - https://phabricator.wikimedia.org/T249745#9593045 (10Joe) >>! In T249745#9592919, @aaron wrote: > I couple things I wonder about: > * T... [09:41:46] 10MediaWiki-extensions-Gadgets, 07JavaScript: MediaWiki JS linter complains about backslash in correct code - https://phabricator.wikimedia.org/T358946 (10Msz2001) [09:48:20] 10JSDoc WMF theme: JSDoc textSelection methods being marked as private - https://phabricator.wikimedia.org/T358290#9593071 (10Tacsipacsi) This means that the documentation is somewhat machine-readable (although there is no machine-readable connection between the command being `scrollToCaretPosition` and the opti... [09:50:22] 10MediaWiki-Patrolling, 06Commons, 101.42.0-wmf.20; 2024-02-27, 07Regression: Show patrol link regardless of whether preview is shown (Was: Edits can't be patrolled on Commons by users who have the user preference "Do not show page content below diffs" enab... - https://phabricator.wikimedia.org/T357693#9593073 [09:53:13] 06MediaWiki-Platform-Team, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Gadgets, 07JavaScript: MediaWiki JS linter complains about backslash in correct code - https://phabricator.wikimedia.org/T358946#9593076 (10Msz2001) [10:03:40] 10MobileFrontend, 06Commons: Mobile image upload don't rotate images from exif data - https://phabricator.wikimedia.org/T343752#9593091 (10TheDJ) [10:03:46] 10UploadWizard, 13Patch-For-Review: EXIF orientation ignored on Commons upload despite correct preview of photo - https://phabricator.wikimedia.org/T338086#9593093 (10TheDJ) [10:06:59] 10MediaWiki-File-management: rebuildImages.php --missing doesn't add found images to wiki - https://phabricator.wikimedia.org/T22906#9593096 (10TheDJ) 05Open→03Invalid This is correct, it finds them, it does not import what it has found. [10:17:29] 06MediaWiki-Platform-Team, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Gadgets, 07JavaScript: MediaWiki JS linter complains about backslash in correct code - https://phabricator.wikimedia.org/T358946#9593101 (10TheDJ) which linter, the editor one, or the one that parses the page when you submit to s... [10:19:54] 06MediaWiki-Platform-Team, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Gadgets, 07JavaScript: MediaWiki JS linter complains about backslash in correct code - https://phabricator.wikimedia.org/T358946#9593103 (10SD0001) This is about the Peast validator used by ResourceLoader at serve-time. [10:20:33] 06MediaWiki-Platform-Team, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Gadgets, 07JavaScript: MediaWiki JS linter complains about backslash in correct code - https://phabricator.wikimedia.org/T358946#9593104 (10Msz2001) The one that's used by the ResourceLoader to ensure users won't get syntacticall... [10:20:46] 10MediaWiki-Uploading, 06Commons, 05MW-1.39-notes, 05MW-1.40-notes, 05MW-1.41-notes: License picker on Special:Upload defaults to last section header - https://phabricator.wikimedia.org/T334992#9593105 (10TheDJ) 05Open→03Resolved a:03TheDJ [10:23:08] 06MediaWiki-Platform-Team, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Gadgets, 07JavaScript: Peast complains about backslash that is part of a regex in valid JS code - https://phabricator.wikimedia.org/T358946#9593107 (10TheDJ) [10:49:40] 10MediaWiki-File-management, 06Commons, 13Patch-For-Review: Move the file hash value from the action=info page to the file description page - https://phabricator.wikimedia.org/T342554#9593120 (10TheDJ) 05Open→03Resolved a:03TheDJ I don't see why? This is not a value that most people should ever need. t... [10:49:57] 10MediaWiki-File-management, 06Commons, 13Patch-For-Review: Move the file hash value from the action=info page to the file description page - https://phabricator.wikimedia.org/T342554#9593123 (10TheDJ) 05Resolved→03Open a:05TheDJ→03None [10:53:39] 10JSDoc WMF theme: JSDoc textSelection methods being marked as private - https://phabricator.wikimedia.org/T358290#9593125 (10Nardog) Do the functions even need to be documented? They're anonymous functions inside a public method after all. (But also: do they need to be initialized from scratch on every call?) [10:55:52] (03CR) 10Tacsipacsi: docs: Migrate @cfg tags to JSDoc (032 comments) [core] - 10https://gerrit.wikimedia.org/r/1007974 (https://phabricator.wikimedia.org/T357169) (owner: 10Alex Paskulin) [11:11:29] (03CR) 10Tacsipacsi: Document mediawiki.router (032 comments) [core] - 10https://gerrit.wikimedia.org/r/1007735 (https://phabricator.wikimedia.org/T358813) (owner: 10Jdlrobson) [11:12:26] 06Moderator-Tools-Team, 06Web-Team-Backlog, 07Spike: [Design Spike 4 hours] Reconsider design for expand all button - https://phabricator.wikimedia.org/T358733#9593130 (10Nardog) > Would a site-wide preference similar to how we do night mode / font size be more appropriate for this and save the user from hav... [11:13:21] 04(no projects): Be sure banner is compatible with all language sites - https://phabricator.wikimedia.org/T358947 (10Jidanni) [11:14:13] 04(no projects): Mobile: Be sure banner is compatible with all language sites - https://phabricator.wikimedia.org/T358947#9593142 (10Jidanni) [11:16:52] 04(no projects): Mobile: Be sure banner is compatible with all language sites - https://phabricator.wikimedia.org/T358947#9593156 (10Jidanni) [11:17:33] 04(no projects): Mobile: Be sure banner size is compatible with all language sites - https://phabricator.wikimedia.org/T358947#9593157 (10Jidanni) [11:20:22] (03CR) 10Tacsipacsi: "As far as I see, it was only updated to 0.4.0 (May 2023). Commits since that, in particular a3be87f4856e2d20d9917989858102184f4ba83e and 3" [core] - 10https://gerrit.wikimedia.org/r/1007735 (https://phabricator.wikimedia.org/T358813) (owner: 10Jdlrobson) [11:24:31] 10MediaWiki-Maintenance-system, 07PHP 8.1 support: PHP Deprecated: Implicit conversion from float to int loses precision in maintenance/updateCollation.php on line 458 - https://phabricator.wikimedia.org/T358949 (10Nikerabbit) [11:28:50] 10MediaWiki-extensions-InlineComments: Add "inlinecomments-view" permission - https://phabricator.wikimedia.org/T355950#9593171 (10Solaris22) Hi @Yaron_Koren , I was working on this microtask. I have created another branch and made changes to the code, and when I push the code, it is giving me this error. Can yo... [12:07:37] 13Patch-For-Review, 10Quota-requests: Request increased memory quota for wd-shex-infer Toolforge tool - https://phabricator.wikimedia.org/T357209#9593189 (10LucasWerkmeister) It’s mostly working for me, but I’d still like to be able to set `requests.memory` higher than at the moment (which is blocked on T35788... [12:27:30] (03CR) 10Tacsipacsi: Hooks: further limit where CodeMirror RL modules are loaded (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/1007746 (https://phabricator.wikimedia.org/T357794) (owner: 10MusikAnimal) [12:30:08] (03CR) 10Tacsipacsi: CodeMirror 6: show wikitext highlighting on protected pages (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/989260 (https://phabricator.wikimedia.org/T301615) (owner: 10MusikAnimal) [12:52:24] (03PS1) 10Physikerwelt: Refactor CreateProfilePages maintenance script [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/1008004 [17:00:43] 06MediaWiki-Platform-Team, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Gadgets, 07JavaScript: Peast complains about backslash that is part of a regex in valid JS code - https://phabricator.wikimedia.org/T358946#9593364 (10matmarex) I reproduced locally, it's caused by the mck89/peast upgrade from T3... [17:01:54] 10MediaWiki-extensions-CentralAuth, 10MediaWiki-extensions-OATHAuth, 07affects-Miraheze: Argument 1 passed to MediaWiki\Extension\OATHAuth\Auth\SecondaryAuthenticationProvider::getProviderForModule() must be an instance of MediaWiki\Extension\OATHAuth\IModule... - https://phabricator.wikimedia.org/T298347#9593367 [17:02:18] 06MediaWiki-Platform-Team, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Gadgets, 07JavaScript: Peast complains about backslash that is part of a regex in valid JS code - https://phabricator.wikimedia.org/T358946#9593369 (10Msz2001) [17:04:32] (03PS10) 10Majavah: Use removeKey()/removeAll() where applicable [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/985620 (https://phabricator.wikimedia.org/T242031) [17:04:34] (03PS3) 10Majavah: Fix changing from TOTP to WebAuthn [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/986440 [17:05:30] (03PS1) 10Majavah: OATHUser: Remove clearAllKeys() [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/1008033 [17:06:38] (03PS2) 10Majavah: OATHUser: Remove clearAllKeys() [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/1008033 [17:06:43] 06MediaWiki-Platform-Team, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Gadgets, 07JavaScript: Peast complains about backslash that is part of a regex in valid JS code - https://phabricator.wikimedia.org/T358946#9593372 (10matmarex) I applied a temporary workaround in the gadget: https://pl.wikipedia... [17:31:25] 06MediaWiki-Platform-Team, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Gadgets, 07JavaScript: Peast complains about backslash that is part of a regex in valid JS code - https://phabricator.wikimedia.org/T358946#9593376 (10matmarex) Minimal test case: `Peast\Peast::ES2016( '/=\n/' )->parse();` [17:37:52] (03PS7) 10Krinkle: Fix duplicate patrol logs for patrol conflicts [core] - 10https://gerrit.wikimedia.org/r/800013 (https://phabricator.wikimedia.org/T196182) (owner: 10A2093064) [17:41:17] (03PS8) 10Krinkle: RecentChange: Avoid duplicate patrol log entry after patrol conflict [core] - 10https://gerrit.wikimedia.org/r/800013 (https://phabricator.wikimedia.org/T196182) (owner: 10A2093064) [17:41:38] (03CR) 10Krinkle: [C: 03+2] RecentChange: Avoid duplicate patrol log entry after patrol conflict (031 comment) [core] - 10https://gerrit.wikimedia.org/r/800013 (https://phabricator.wikimedia.org/T196182) (owner: 10A2093064) [17:47:28] 10MediaWiki-Codesniffer, 10Parsoid: PhpStorm complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing - https://phabricator.wikimedia.org/T358956 (10Reedy) [17:49:42] (03CR) 10Krinkle: [C: 04-1] "CC Daimona for input on whether this really needs a centralised singleton for the process cache." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/1005972 (owner: 10D3r1ck01) [17:49:53] 07Regression: Night mode applies to script-generated tags in mobile when on-wiki night mode is disabled - https://phabricator.wikimedia.org/T358957 (10Dragoniez) [17:51:16] 10MediaWiki-Core-Tests, 10MediaWiki-Parser, 07Test-Coverage: Can we make parser tests show as PHP test coverage? - https://phabricator.wikimedia.org/T315768#9593405 (10Reedy) [17:51:37] 07Regression: Night mode applies to script-generated tags in mobile when on-wiki night mode is disabled - https://phabricator.wikimedia.org/T358957#9593406 (10Dragoniez) [17:51:44] (03CR) 10Krinkle: [C: 03+2] Use interwiki to link to Creative Commons [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/991921 (https://phabricator.wikimedia.org/T343131) (owner: 10Lucas Werkmeister) [17:55:06] (03CR) 10Lucas Werkmeister: [C: 04-2] "no, please wait" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/991921 (https://phabricator.wikimedia.org/T343131) (owner: 10Lucas Werkmeister) [17:57:17] (03CR) 10Lucas Werkmeister: [C: 04-2] "1. Given how long this has been up, I should at the very least regenerate it based on latest master. (My plan was that, once we agreed thi" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/991921 (https://phabricator.wikimedia.org/T343131) (owner: 10Lucas Werkmeister) [17:58:19] 10MediaWiki-Codesniffer, 10Parsoid: PhpStorm complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing - https://phabricator.wikimedia.org/T358956#9593411 (10Reedy) [18:00:17] 10MediaWiki-Codesniffer, 10Parsoid: PhpStorm complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing - https://phabricator.wikimedia.org/T358956#9593414 (10Reedy) [18:03:25] (03Merged) 10jenkins-bot: RecentChange: Avoid duplicate patrol log entry after patrol conflict [core] - 10https://gerrit.wikimedia.org/r/800013 (https://phabricator.wikimedia.org/T196182) (owner: 10A2093064) [18:05:15] (03CR) 10Fomafix: skin.json: Remove "@args": "See SkinVector::__construct for more detail." (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/1007712 (owner: 10Fomafix) [18:10:07] 10MediaWiki-Codesniffer, 10Parsoid: PhpStorm complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing - https://phabricator.wikimedia.org/T358956#9593417 (10Reedy) `vendor/phpcsstandards/phpcsextra/Universal/Sniffs/Constants/LowercaseClassResolutionKeywordSniff.php`does exist on disk.... [18:10:44] (03CR) 10CI reject: [V: 04-1] Use interwiki to link to Creative Commons [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/991921 (https://phabricator.wikimedia.org/T343131) (owner: 10Lucas Werkmeister) [18:11:28] (03CR) 10Daimona Eaytoy: Drop AutoPromoteGroupsHandler::factory(), prep for ObjectCacheFactory (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/1005972 (owner: 10D3r1ck01) [18:16:11] 10MediaWiki-Codesniffer, 10Parsoid: PhpStorm complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing - https://phabricator.wikimedia.org/T358956#9593418 (10Reedy) Seems fine on my MW checkout/clone... with the same version of #mediawiki-codesniffer... [18:16:27] 10MediaWiki-Page-rename, 10MediaWiki-Watchlist: Page moves that cause category changes don't result in changelist items - https://phabricator.wikimedia.org/T267337#9593419 (10Bdijkstra) Okay indeed it mostly works now, although it might have been different a few years ago. One case that's still problematic (i.... [18:17:09] 10MediaWiki-Page-rename, 10MediaWiki-Watchlist, 06Growth-Team: Page moves that cause category changes don't result in changelist items - https://phabricator.wikimedia.org/T267337#9593420 (10Bdijkstra) 05Invalid→03Open [18:17:25] (03PS4) 10TheDJ: MediaSearch filters can wrap on narrow screens. [extensions/MediaSearch] - 10https://gerrit.wikimedia.org/r/1008005 (https://phabricator.wikimedia.org/T334198) [18:18:27] (03CR) 10Krinkle: Make Key objects aware of their database IDs (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/964987 (https://phabricator.wikimedia.org/T242031) (owner: 10Majavah) [18:20:04] (03CR) 10Krinkle: [C: 03+2] Introduce MultiGadgetRepo to facilitate repo migration [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/981622 (https://phabricator.wikimedia.org/T140323) (owner: 10SD0001) [18:20:20] (03CR) 10Krinkle: Introduce MultiGadgetRepo to facilitate repo migration [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/981622 (https://phabricator.wikimedia.org/T140323) (owner: 10SD0001) [18:21:50] (03PS9) 10Krinkle: Introduce MultiGadgetRepo to facilitate repo migration [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/981622 (https://phabricator.wikimedia.org/T140323) (owner: 10SD0001) [18:22:05] (03PS10) 10Krinkle: Introduce MultiGadgetRepo to facilitate repo migration [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/981622 (https://phabricator.wikimedia.org/T140323) (owner: 10SD0001) [18:22:18] (03CR) 10Krinkle: [C: 03+2] Introduce MultiGadgetRepo to facilitate repo migration [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/981622 (https://phabricator.wikimedia.org/T140323) (owner: 10SD0001) [18:24:26] 10MediaWiki-Codesniffer, 10Parsoid: PhpStorm complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing - https://phabricator.wikimedia.org/T358956#9593422 (10Daimona) I can reproduce this. One thing for sure -- it's a consequence of how PHPStorm runs phpcs (because it works if you run... [18:24:52] (03PS1) 10Umherirrender: Combine the expressions in GlobalBlockLookup::getRangeCondition [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/1008035 [18:28:05] 10MediaWiki-Codesniffer, 07Upstream: PhpStorm complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing - https://phabricator.wikimedia.org/T358956#9593423 (10Reedy) > Still a problem in 2022.3.3. The workaround still works. However, with one note: still need to provide a path to the l... [18:31:25] (03PS1) 10Nikerabbit: Bump support to 1.40, inject dependecies, add types [extensions/FileSystemImageServer] - 10https://gerrit.wikimedia.org/r/1008036 [18:32:47] (03PS2) 10Tacsipacsi: Add `uselang` to API requests on Special:Translate [extensions/Translate] - 10https://gerrit.wikimedia.org/r/1008032 [18:33:25] 10MediaWiki-Change-tagging, 06Tech Ambassadors & Translators, 10Wikimedia-Site-requests, 13Patch-For-Review, 07User-notice: Move "Changetags" right only for bots and administrators by default in Wikimedia production - https://phabricator.wikimedia.org/T355639#9593426 (10IKhitron) I request to cancel the... [18:34:15] 10MediaWiki-Codesniffer, 07Upstream: PhpStorm complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing - https://phabricator.wikimedia.org/T358956#9593427 (10Daimona) I was able to fix this by adding the following to PHPCS's "Installed standard paths": `/path/to/vendor/phpcsstandards/... [18:36:32] (03CR) 10Tacsipacsi: "This is probably something I’ll need in half a year, so no hurries. 🙂 But I do think that it’s a nice-to-have not only because of my use c" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/1008032 (owner: 10Tacsipacsi) [18:37:52] 10MediaWiki-Core-Preferences: Adding international date format and use it as the default setting - https://phabricator.wikimedia.org/T326430#9593429 (10Sauer202) Any new info? Can I contribute with code somewhere? [18:37:54] 10MediaWiki-Change-tagging, 06Tech Ambassadors & Translators, 10Wikimedia-Site-requests, 13Patch-For-Review, 07User-notice: Move "Changetags" right only for bots and administrators by default in Wikimedia production - https://phabricator.wikimedia.org/T355639#9593428 (10Iniquity) [18:38:32] 10MediaWiki-File-management, 06Commons: Encountered HTTP 429s while trying to load thumbnails of an image with many revisions - https://phabricator.wikimedia.org/T324594#9593430 (10TheDJ) [18:38:40] 10Thumbor: [Tracking] Thumbnail 429 rate limiting on failed requests of complex or broken media files - https://phabricator.wikimedia.org/T353950#9593432 (10TheDJ) [18:38:52] 10MediaWiki-File-management, 06Commons: Encountered HTTP 429s while trying to load thumbnails of an image with many revisions - https://phabricator.wikimedia.org/T324594#9593433 (10TheDJ) [18:42:03] 10MediaWiki-Codesniffer, 07Upstream: PhpStorm complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing - https://phabricator.wikimedia.org/T358956#9593437 (10Reedy) Thanks! The UI for "Installed standard paths" is... crappy, considering it looks like it can only be a single field, an... [21:00:37] (03PS7) 10Alistair3149: Set report-to directive in CSP when report-uri is set [core] - 10https://gerrit.wikimedia.org/r/1008045 (https://phabricator.wikimedia.org/T249513) [21:02:42] 10Wikibase (3rd party installations), 06Wikibase Suite Team: Wikibase: Quick-statements behind reverse proxy - https://phabricator.wikimedia.org/T315916#9593582 (10DD063520) Hi @lojo_wmde, thank you for your answer! About the 302 code. We do not configure anything actively in nginx. In fact I think it is the... [21:03:00] (03CR) 10Umherirrender: Replace makeList() with IDatabase::expr and ExpressionGroups (036 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/1004319 (https://phabricator.wikimedia.org/T350966) (owner: 10MPGuy2824) [21:03:59] 102024: GSOC 2024 Project Proposal: - https://phabricator.wikimedia.org/T358899#9593594 (10Maryann-Onyinye) Hi @Yug Gentle reminder on my previous message. Please understand that if these steps are not taken your projects most likely not be listed for GSOC 2024. Kindly treat as urgent. Regards [21:07:28] (03PS8) 10Alistair3149: Set the equivalent frame-ancestors in CSP when X-Frame-Options is set [core] - 10https://gerrit.wikimedia.org/r/1007458 (https://phabricator.wikimedia.org/T327588) [21:08:08] (03PS1) 10Krinkle: build: Update karma-qunit to 4.2.0 and remove old `__karma__` hack [core] - 10https://gerrit.wikimedia.org/r/1008049 [21:08:10] (03PS1) 10Krinkle: mediawiki.base: Simplify RLQ test without network request [core] - 10https://gerrit.wikimedia.org/r/1008050 [21:08:12] (03PS1) 10Krinkle: resourceloader: Update mw.loader tests to always use full URL [core] - 10https://gerrit.wikimedia.org/r/1008051 [21:08:14] (03PS1) 10Krinkle: build: Remove Karma proxy [core] - 10https://gerrit.wikimedia.org/r/1008052 [21:08:20] (03PS8) 10Alistair3149: Set report-to directive in CSP when report-uri is set [core] - 10https://gerrit.wikimedia.org/r/1008045 (https://phabricator.wikimedia.org/T249513) [21:10:19] (03CR) 10Ladsgroup: [C: 03+2] "Thank you Daniel for easing my review :P" [core] - 10https://gerrit.wikimedia.org/r/982755 (owner: 10Giuseppe Lavagetto) [21:11:01] (03CR) 10Ladsgroup: [C: 03+2] Add getCacheKey static method to UploadFromUrl [core] - 10https://gerrit.wikimedia.org/r/982756 (owner: 10Giuseppe Lavagetto) [21:12:57] (03PS9) 10Alistair3149: Set the equivalent frame-ancestors in CSP when X-Frame-Options is set [core] - 10https://gerrit.wikimedia.org/r/1007458 (https://phabricator.wikimedia.org/T327588) [21:13:28] 10MediaWiki-Codesniffer, 10LibUp: LibUp has to allow the dealerdirect/phpcodesniffer-composer-installer plugin on codesniffer update - https://phabricator.wikimedia.org/T358911#9593596 (10Reedy) >>! In T358911#9592530, @Daimona wrote: > According to [[https://stackoverflow.com/questions/70580831/is-it-possible... [21:19:26] (03PS9) 10Alistair3149: Set report-to directive in CSP when report-uri is set [core] - 10https://gerrit.wikimedia.org/r/1008045 (https://phabricator.wikimedia.org/T249513) [21:20:35] (03PS10) 10Alistair3149: Set the equivalent frame-ancestors in CSP when X-Frame-Options is set [core] - 10https://gerrit.wikimedia.org/r/1007458 (https://phabricator.wikimedia.org/T327588) [21:21:11] 10MediaWiki-General, 07ContentSecurityPolicy, 13Patch-For-Review, 07Security: Consider adding more CSP directives to MediaWIki core - https://phabricator.wikimedia.org/T327588#9593598 (10Bawolff) object-src is probably not too useful in modern browsers now that is just a glorified iframe. It proba... [21:22:29] (03CR) 10Brian Wolff: "I'm not sure there is an actual benefit to setting it in CSP. CSP is newer and overrides X-Frame-Options, however X-Frame-Options is not d" [core] - 10https://gerrit.wikimedia.org/r/1007458 (https://phabricator.wikimedia.org/T327588) (owner: 10Alistair3149) [21:22:46] (03CR) 10Ladsgroup: [C: 03+1] "One nitpick and otherwise looks good." [core] - 10https://gerrit.wikimedia.org/r/982757 (https://phabricator.wikimedia.org/T295007) (owner: 10Giuseppe Lavagetto) [21:25:14] (03PS11) 10Alistair3149: Set the equivalent frame-ancestors in CSP when X-Frame-Options is set [core] - 10https://gerrit.wikimedia.org/r/1007458 (https://phabricator.wikimedia.org/T327588) [21:30:41] (03CR) 10Physikerwelt: [C: 03+2] Simplify SPARQL map operation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/1008026 (owner: 10Physikerwelt) [21:30:45] (03CR) 10DannyS712: LanguagesHelperTest: Remove unused parameter from method getTitle (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008042 (owner: 10Fomafix) [21:32:00] (03PS1) 10Daimona Eaytoy: build: Update codesniffer to 3.9.0, phpcsextra to 1.2.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008053 [21:32:13] 10MediaWiki-extensions-PdfHandler, 06All-and-every-Wikisource, 06Commons: PDF file with good resolution appears as 0 x 0 pixel and page preview is not being shown - https://phabricator.wikimedia.org/T315171#9593606 (10TheDJ) [21:32:45] 10MediaWiki-extensions-PdfHandler: PDF file has 0x0 image size in Commons after uploading a new version while the page number is correct - https://phabricator.wikimedia.org/T299521#9593603 (10TheDJ) [21:33:28] (03Merged) 10jenkins-bot: Refactor PublishStashedFileJob to make the code reusable [core] - 10https://gerrit.wikimedia.org/r/982755 (owner: 10Giuseppe Lavagetto) [21:33:37] (03Merged) 10jenkins-bot: Add getCacheKey static method to UploadFromUrl [core] - 10https://gerrit.wikimedia.org/r/982756 (owner: 10Giuseppe Lavagetto) [21:34:06] (03PS10) 10Alistair3149: Set report-to directive in CSP when report-uri is set [core] - 10https://gerrit.wikimedia.org/r/1008045 (https://phabricator.wikimedia.org/T249513) [21:34:16] (03CR) 10CI reject: [V: 04-1] build: Remove Karma proxy [core] - 10https://gerrit.wikimedia.org/r/1008052 (owner: 10Krinkle) [21:37:00] (03CR) 10Umherirrender: Make verifyPartialFile reuse SHA1 hash if we already know (031 comment) [core] - 10https://gerrit.wikimedia.org/r/1007998 (https://phabricator.wikimedia.org/T200820) (owner: 10Brian Wolff) [21:40:50] 10MediaWiki-extensions-PdfHandler: PDF file has 0x0 image size in Commons after uploading a new version while the page number is correct - https://phabricator.wikimedia.org/T299521#9593621 (10TheDJ) I've stepped through the logic a bit with some of the reported files, and pretty much the only reason this can hap... [21:41:05] (03CR) 10Alistair3149: "In the current patch, there isn't an actual benefit over X-Frame-Options since the frame-ancestors directive can only set to none and self" [core] - 10https://gerrit.wikimedia.org/r/1007458 (https://phabricator.wikimedia.org/T327588) (owner: 10Alistair3149) [21:41:22] 10MediaWiki-File-management: importImages.php fails trying to import some PDFs saying the local file on disk doesn't exist - https://phabricator.wikimedia.org/T358964 (10Reedy) [21:41:36] 10MediaWiki-File-management: importImages.php fails trying to import some PDFs saying the local file on disk doesn't exist - https://phabricator.wikimedia.org/T358964#9593635 (10Reedy) [21:43:47] (03PS11) 10Alistair3149: Set report-to directive in CSP when report-uri is set [core] - 10https://gerrit.wikimedia.org/r/1008045 (https://phabricator.wikimedia.org/T249513) [21:45:41] 10Server-side-upload-request: Server-side upload request of CA MUTCD for mxn - https://phabricator.wikimedia.org/T356156#9593636 (10Reedy) [21:46:02] 10Server-side-upload-request: Server-side upload request for V.B.Speranza - https://phabricator.wikimedia.org/T352821#9593638 (10Reedy) [21:46:09] 10Server-side-upload-request: Server-side upload request for cypp0847 - https://phabricator.wikimedia.org/T352740#9593639 (10Reedy) [21:48:54] 10MediaWiki-File-management, 06Commons: Make importImages.php output some timestamps - https://phabricator.wikimedia.org/T358959#9593643 (10Reedy) [21:48:58] (03PS12) 10Alistair3149: Set report-to directive in CSP when report-uri is set [core] - 10https://gerrit.wikimedia.org/r/1008045 (https://phabricator.wikimedia.org/T249513) [21:49:51] (03PS1) 10Daimona Eaytoy: Replace `DoubleNotOperatorSniff` with `Universal.CodeAnalysis.NoDoubleNegative` [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008054 [21:50:07] 10Server-side-upload-request: Server-side upload request of CA MUTCD for mxn - https://phabricator.wikimedia.org/T356156#9593644 (10mxn) Description: > Revision 8 the 2014 edition of the _California Manual on Uniform Traffic Control Devices_, the legal standard for all traffic control devices in the U.S. state... [21:50:24] (03PS2) 10Daimona Eaytoy: Replace DoubleNotOperatorSniff with Universal.CodeAnalysis.NoDoubleNegative [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008054 [21:50:42] (03PS3) 10Fomafix: LanguagesHelperTest: Remove unused parameter from method getTitle [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008042 [21:50:44] (03CR) 10Fomafix: LanguagesHelperTest: Remove unused parameter from method getTitle (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008042 (owner: 10Fomafix) [21:52:34] (03Merged) 10jenkins-bot: Simplify SPARQL map operation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/1008026 (owner: 10Physikerwelt) [21:55:29] 10MediaWiki-General, 07ContentSecurityPolicy, 13Patch-For-Review, 07Security: Consider adding more CSP directives to MediaWIki core - https://phabricator.wikimedia.org/T327588#9593645 (10alistair3149) [21:55:44] (03PS2) 10Fomafix: Inject service LanguageConverterFactory in LanguagesHelper [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008043 [21:55:53] (03PS2) 10Fomafix: LanguagesHelperTest: Use @dataProvider to configure test cases [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008047 [21:56:12] 10MediaWiki-Maintenance-system, 05MW-1.39-release, 05MW-1.40-release, 05MW-1.41-release, 07PHP 8.1 support: PHP Deprecated: Implicit conversion from float to int loses precision in maintenance/updateCollation.php on line 458 - https://phabricator.wikimedia.org/T358949#9593647 (10Reedy) `lang=php for (... [21:58:57] (03PS1) 10Daimona Eaytoy: Add Universal.PHP.LowercasePHPTag [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008055 [21:59:59] 10MediaWiki-Maintenance-system, 05MW-1.39-release, 05MW-1.40-release, 05MW-1.41-release, 07PHP 8.1 support: PHP Deprecated: Implicit conversion from float to int loses precision in maintenance/updateCollation.php on line 458 - https://phabricator.wikimedia.org/T358949#9593649 (10Reedy) p:05Triage→03L... [22:05:12] 04(no projects): A bug in PDF book notes - https://phabricator.wikimedia.org/T358965 (10Ori0749) [22:09:47] (03PS1) 10Reedy: updateCollation: Explicitly cast $scale to int [core] - 10https://gerrit.wikimedia.org/r/1008056 (https://phabricator.wikimedia.org/T358949) [22:14:38] 10Server-side-upload-request: Server-side upload request of CA MUTCD for mxn - https://phabricator.wikimedia.org/T356156#9593666 (10Reedy) Wikitext is generally prefered ;) ` =={{int:filedesc}}== {{Information |Description = Revision 8 the 2014 edition of the California Manual on Uniform Traffic Control Devices... [22:18:51] 10Server-side-upload-request: Server-side upload request of CA MUTCD for mxn - https://phabricator.wikimedia.org/T356156#9593667 (10Reedy) 05Stalled→03Resolved a:03Reedy Done, but it seems it won't thumbnail (possibly related to how it was concatenated)... [22:27:17] (03CR) 10DannyS712: [C: 03+2] LanguagesHelperTest: Remove unused parameter from method getTitle [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008042 (owner: 10Fomafix) [22:28:02] 10MediaWiki-Codesniffer: Enable sniff to disallow mixing different boolean operators in the same expression without parentheses - https://phabricator.wikimedia.org/T358966 (10Daimona) [22:28:14] (03PS1) 10Daimona Eaytoy: Add Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008057 (https://phabricator.wikimedia.org/T358966) [22:29:05] (03CR) 10DannyS712: Inject service LanguageConverterFactory in LanguagesHelper (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008043 (owner: 10Fomafix) [22:29:21] (03CR) 10CI reject: [V: 04-1] Add Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008057 (https://phabricator.wikimedia.org/T358966) (owner: 10Daimona Eaytoy) [22:29:47] (03PS2) 10Daimona Eaytoy: Add Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008057 (https://phabricator.wikimedia.org/T358966) [22:30:21] (03CR) 10DannyS712: [C: 03+2] Add Universal.PHP.LowercasePHPTag [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008055 (owner: 10Daimona Eaytoy) [22:30:29] (03PS2) 10Krinkle: build: Remove Karma proxy [core] - 10https://gerrit.wikimedia.org/r/1008052 [22:32:26] (03PS3) 10Krinkle: build: Remove Karma proxy [core] - 10https://gerrit.wikimedia.org/r/1008052 [22:34:24] 10Server-side-upload-request: Server-side upload request of CA MUTCD for mxn - https://phabricator.wikimedia.org/T356156#9593684 (10mxn) It’s working fine for me, just took a little while. Thanks for your help! [22:40:19] 10Server-side-upload-request: Server-side upload request for Nikola_Smolenski - https://phabricator.wikimedia.org/T296183#9593688 (10Peachey88) [22:40:21] 10Server-side-upload-request, 10video2commons: Server side upload for Yann - https://phabricator.wikimedia.org/T353222#9593687 (10Peachey88) [22:40:25] 10Server-side-upload-request: Please upload large video files to Wikimedia Commons - https://phabricator.wikimedia.org/T287000#9593690 (10Peachey88) [22:41:34] 10MediaWiki-File-management: importImages.php fails trying to import some PDFs saying the local file on disk doesn't exist - https://phabricator.wikimedia.org/T358964#9593692 (10Peachey88) [22:50:15] 10WMF-General-or-Unknown: Some Mon Wiktionary needs to be fixed - https://phabricator.wikimedia.org/T356406#9593696 (10Pppery) 05Open→03Invalid Closing as invalid as this is an on-wiki content problem of the sort not generally tracked on Phabricator. [22:51:06] (03Merged) 10jenkins-bot: LanguagesHelperTest: Remove unused parameter from method getTitle [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008042 (owner: 10Fomafix) [22:51:31] (03CR) 10Umherirrender: updateCollation: Explicitly cast $scale to int (031 comment) [core] - 10https://gerrit.wikimedia.org/r/1008056 (https://phabricator.wikimedia.org/T358949) (owner: 10Reedy) [22:51:41] 10WMF-General-or-Unknown: Template style not applied on nsowiki pages without purging cache - https://phabricator.wikimedia.org/T342573#9593699 (10Pppery) 05Open→03Invalid Whatever cache failed to get purged here has almost certainly long since expired. [22:52:47] (03CR) 10Reedy: updateCollation: Explicitly cast $scale to int (031 comment) [core] - 10https://gerrit.wikimedia.org/r/1008056 (https://phabricator.wikimedia.org/T358949) (owner: 10Reedy) [22:53:48] (03PS2) 10Reedy: updateCollation: Explicitly cast $scale to int [core] - 10https://gerrit.wikimedia.org/r/1008056 (https://phabricator.wikimedia.org/T358949) [22:54:40] 10MinervaNeue: Community discussion about hacks.less - https://phabricator.wikimedia.org/T358078#9593706 (10Izno) >>! In T358078#9570180, @Jdlrobson wrote: > In general, I'd like to get to a place where community members can cherry pick the things they want. I'll share more on this when I have time to collect my... [23:00:42] (03CR) 10Umherirrender: [C: 03+2] build: Update codesniffer to 3.9.0, phpcsextra to 1.2.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008053 (owner: 10Daimona Eaytoy) [23:01:24] (03Merged) 10jenkins-bot: build: Update codesniffer to 3.9.0, phpcsextra to 1.2.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008053 (owner: 10Daimona Eaytoy) [23:08:41] (03PS3) 10Reedy: updateCollation: Explicitly cast $scale to int [core] - 10https://gerrit.wikimedia.org/r/1008056 (https://phabricator.wikimedia.org/T358949) [23:10:39] (03PS1) 10Reedy: updateCollation: Minor cleanup [core] - 10https://gerrit.wikimedia.org/r/1008059 [23:13:03] 10MediaWiki-File-management: Make importImages.php output some timestamps - https://phabricator.wikimedia.org/T358959#9593716 (10Peachey88) [23:15:22] (03CR) 10Reedy: [C: 03+2] Replace DoubleNotOperatorSniff with Universal.CodeAnalysis.NoDoubleNegative [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008054 (owner: 10Daimona Eaytoy) [23:15:56] (03CR) 10Reedy: [C: 03+2] Add Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008057 (https://phabricator.wikimedia.org/T358966) (owner: 10Daimona Eaytoy) [23:16:11] (03Merged) 10jenkins-bot: Replace DoubleNotOperatorSniff with Universal.CodeAnalysis.NoDoubleNegative [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008054 (owner: 10Daimona Eaytoy) [23:16:13] (03Merged) 10jenkins-bot: Add Universal.PHP.LowercasePHPTag [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008055 (owner: 10Daimona Eaytoy) [23:16:35] (03Merged) 10jenkins-bot: Add Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/1008057 (https://phabricator.wikimedia.org/T358966) (owner: 10Daimona Eaytoy) [23:17:21] (03CR) 10Reedy: [C: 03+2] build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1008038 (owner: 10Daimona Eaytoy) [23:18:53] (03PS2) 10Physikerwelt: Extend ProfilePage script to for load jobs [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/1008027 [23:21:25] (03CR) 10Physikerwelt: [C: 03+2] Extend ProfilePage script to for load jobs [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/1008027 (owner: 10Physikerwelt) [23:21:41] (03Merged) 10jenkins-bot: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1008038 (owner: 10Daimona Eaytoy) [23:23:33] (03CR) 10Umherirrender: [C: 03+2] updateCollation: Explicitly cast $scale to int (031 comment) [core] - 10https://gerrit.wikimedia.org/r/1008056 (https://phabricator.wikimedia.org/T358949) (owner: 10Reedy) [23:37:27] (03CR) 10Daimona Eaytoy: "recheck" [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1007635 (https://phabricator.wikimedia.org/T357716) (owner: 10Daimona Eaytoy) [23:42:59] (03CR) 10Daimona Eaytoy: "I think the aliasing here would allow people to use these class names even with PHPUnit 9, no? I agree that this is ancient and should be " [core] - 10https://gerrit.wikimedia.org/r/1004268 (owner: 10Reedy) [23:43:23] (03Merged) 10jenkins-bot: Extend ProfilePage script to for load jobs [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/1008027 (owner: 10Physikerwelt) [23:43:42] (03PS3) 10Daimona Eaytoy: Streamline ICampaignsPage instantiation [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1007689 [23:45:08] 10mwbot-rs: Allow more people to make mwbot-rs releases - https://phabricator.wikimedia.org/T358941#9593748 (10Legoktm) Great! You both should have invites to join the mwbot-rs organization [23:45:33] (03Merged) 10jenkins-bot: updateCollation: Explicitly cast $scale to int [core] - 10https://gerrit.wikimedia.org/r/1008056 (https://phabricator.wikimedia.org/T358949) (owner: 10Reedy) [23:46:06] (03PS1) 10Reedy: updateCollation: Explicitly cast $scale to int [core] (REL1_41) - 10https://gerrit.wikimedia.org/r/1008010 (https://phabricator.wikimedia.org/T358949) [23:46:13] (03CR) 10Reedy: [C: 03+2] updateCollation: Explicitly cast $scale to int [core] (REL1_41) - 10https://gerrit.wikimedia.org/r/1008010 (https://phabricator.wikimedia.org/T358949) (owner: 10Reedy) [23:46:20] (03PS1) 10Reedy: updateCollation: Explicitly cast $scale to int [core] (REL1_40) - 10https://gerrit.wikimedia.org/r/1008011 (https://phabricator.wikimedia.org/T358949) [23:46:25] (03CR) 10Reedy: [C: 03+2] updateCollation: Explicitly cast $scale to int [core] (REL1_40) - 10https://gerrit.wikimedia.org/r/1008011 (https://phabricator.wikimedia.org/T358949) (owner: 10Reedy) [23:46:32] (03PS1) 10Reedy: updateCollation: Explicitly cast $scale to int [core] (REL1_39) - 10https://gerrit.wikimedia.org/r/1008012 (https://phabricator.wikimedia.org/T358949) [23:46:38] (03CR) 10Reedy: [C: 03+2] updateCollation: Explicitly cast $scale to int [core] (REL1_39) - 10https://gerrit.wikimedia.org/r/1008012 (https://phabricator.wikimedia.org/T358949) (owner: 10Reedy) [23:46:57] (03PS3) 10Reedy: TestsAutoLoader: Remove old PHPUnit class aliasing [core] - 10https://gerrit.wikimedia.org/r/1004268 [23:50:27] (03PS4) 10Reedy: TestsAutoLoader: Remove old PHPUnit class aliasing [core] - 10https://gerrit.wikimedia.org/r/1004268 [23:51:04] (03CR) 10CI reject: [V: 04-1] Streamline ICampaignsPage instantiation [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1007689 (owner: 10Daimona Eaytoy) [23:56:58] 10MediaWiki-Maintenance-system, 05MW-1.39-release, 05MW-1.40-release, 05MW-1.41-release, and 2 others: PHP Deprecated: Implicit conversion from float to int loses precision in maintenance/updateCollation.php on line 458 - https://phabricator.wikimedia.org/T358949#9593753 (10Reedy) 05Open→03Resolved a:... [23:57:30] (03Merged) 10jenkins-bot: updateCollation: Explicitly cast $scale to int [core] (REL1_41) - 10https://gerrit.wikimedia.org/r/1008010 (https://phabricator.wikimedia.org/T358949) (owner: 10Reedy) [23:57:36] (03Merged) 10jenkins-bot: updateCollation: Explicitly cast $scale to int [core] (REL1_39) - 10https://gerrit.wikimedia.org/r/1008012 (https://phabricator.wikimedia.org/T358949) (owner: 10Reedy)