[00:00:33] (03Merged) 10jenkins-bot: updateCollation: Explicitly cast $scale to int [core] (REL1_40) - 10https://gerrit.wikimedia.org/r/1008011 (https://phabricator.wikimedia.org/T358949) (owner: 10Reedy) [00:01:12] (03PS1) 10SLF bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/1008061 [00:02:15] (03CR) 10Aaron Schulz: upload: switch AssembleUploadChunksJob to GenericParameterJob (031 comment) [core] - 10https://gerrit.wikimedia.org/r/983275 (owner: 10Aaron Schulz) [00:02:54] (03PS3) 10Aaron Schulz: upload: switch AssembleUploadChunksJob to GenericParameterJob [core] - 10https://gerrit.wikimedia.org/r/983275 [00:15:51] 10MinervaNeue: Community discussion about hacks.less - https://phabricator.wikimedia.org/T358078#9593761 (10Snaevar) Icelandic Wikipedia here. We mostly use English Wikipedia styles, with a handful of styles from spanish wikipedia. Not sure where this hacks.less file is used, but I only see only one change for... [00:20:30] (03CR) 10Aaron Schulz: rdbms: make QueryBuilderFromRawSql always set QUERY_CHANGE_* flags (031 comment) [core] - 10https://gerrit.wikimedia.org/r/995371 (https://phabricator.wikimedia.org/T350330) (owner: 10Aaron Schulz) [00:25:13] (03PS1) 10Physikerwelt: Add overwrite option for PageLinks [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/1008062 [00:25:58] (03CR) 10Physikerwelt: [C: 03+2] Add overwrite option for PageLinks [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/1008062 (owner: 10Physikerwelt) [00:38:33] (03PS1) 10TrainBranchBot: Branch commit for wmf/branch_cut_pretest [core] (wmf/branch_cut_pretest) - 10https://gerrit.wikimedia.org/r/1008066 [00:38:39] (03CR) 10TrainBranchBot: [C: 03+2] Branch commit for wmf/branch_cut_pretest [core] (wmf/branch_cut_pretest) - 10https://gerrit.wikimedia.org/r/1008066 (owner: 10TrainBranchBot) [00:48:09] (03Merged) 10jenkins-bot: Add overwrite option for PageLinks [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/1008062 (owner: 10Physikerwelt) [01:00:25] (03Merged) 10jenkins-bot: Branch commit for wmf/branch_cut_pretest [core] (wmf/branch_cut_pretest) - 10https://gerrit.wikimedia.org/r/1008066 (owner: 10TrainBranchBot) [01:14:24] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9593766 (10Yaron_Koren) No - I would say the "admin-links-row" part is unnecessary, if it's in that attribute. Also, a single quote, i.e. apostrophe, will still break the HTML, like i... [01:20:27] 10MediaWiki-extensions-InlineComments: Add "inlinecomments-view" permission - https://phabricator.wikimedia.org/T355950#9593767 (10Yaron_Koren) I'm glad you got "git push" working, maybe! But there are two big problems with this patch: first, it's for the wrong repository - you should create a patch in the Inlin... [01:22:37] 10MediaWiki-extensions-PageExchange: Change word "Link" to domain name in Page Exchange URL display - https://phabricator.wikimedia.org/T358694#9593768 (10Yaron_Koren) Thank you for the fix! Yes, feel free to create your proposal already. Brian and I have not yet decided (or even discussed, actually) who we wou... [01:22:48] 10MediaWiki-extensions-PageExchange: Change word "Link" to domain name in Page Exchange URL display - https://phabricator.wikimedia.org/T358694#9593769 (10Yaron_Koren) 05Open→03Resolved [01:23:42] (03PS1) 10Daimona Eaytoy: [DNM] Test CI [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1008063 [01:24:12] (03PS1) 10Physikerwelt: Add overwrite option for SetProfile [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/1008064 [01:25:57] (03CR) 10Physikerwelt: [C: 03+2] Add overwrite option for SetProfile [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/1008064 (owner: 10Physikerwelt) [01:27:37] (03PS2) 10Daimona Eaytoy: [DNM] Test CI [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1008063 [01:30:44] (03CR) 10CI reject: [V: 04-1] [DNM] Test CI [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1008063 (owner: 10Daimona Eaytoy) [01:35:47] (03PS3) 10Daimona Eaytoy: [DNM] Test CI [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1008063 [01:42:57] (03CR) 10CI reject: [V: 04-1] [DNM] Test CI [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1008063 (owner: 10Daimona Eaytoy) [01:47:17] (03Merged) 10jenkins-bot: Add overwrite option for SetProfile [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/1008064 (owner: 10Physikerwelt) [01:51:22] 10PageTriage: Article is marked as reviewed despite no log entries since move from draftspace - https://phabricator.wikimedia.org/T358969 (10A_smart_kitten) [02:05:46] (03PS4) 10Daimona Eaytoy: [DNM] Test CI [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1008063 [02:08:44] (03CR) 10CI reject: [V: 04-1] [DNM] Test CI [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1008063 (owner: 10Daimona Eaytoy) [02:16:43] 10Wikimedia-maintenance-script-run, 10Bad data: Fix remaining page records with page_latest == 0 in database. - https://phabricator.wikimedia.org/T261797#9593797 (10Frostly) [02:20:21] 10MinervaNeue: Community discussion about hacks.less - https://phabricator.wikimedia.org/T358078#9593798 (10Izno) [02:22:13] 10PageTriage: Article is marked as reviewed despite no log entries since move from draftspace - https://phabricator.wikimedia.org/T358969#9593801 (10Soda) Noting that this article appears to have been "patrolled" as opposed to "reviewed" [[https://quarry.wmcloud.org/query/80858|see this query]] [02:23:10] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9593802 (10Rockingpenny4) What if we were to escape the special characters using htmlspecialchars? [02:28:51] 10MinervaNeue: Community discussion about hacks.less - https://phabricator.wikimedia.org/T358078#9593803 (10Izno) [02:29:21] 10MinervaNeue: Community discussion about hacks.less - https://phabricator.wikimedia.org/T358078#9593804 (10Izno) > Not sure where this hacks.less file is used, I've added a description that explains what it is. My long comment excerpts the code in it, but I've also linked it in the description. > one change fo... [02:54:37] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9593805 (10Yaron_Koren) Whatever works is good. :) [02:57:38] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9593807 (10Yaron_Koren) I should note that another option is to use MediaWiki's built-in Html class - which is probably the most "correct" approach, though of course not the only one. [03:12:58] 06Research, 13Patch-For-Review: Maintain wikiworkshop.org website - https://phabricator.wikimedia.org/T349774#9593808 (10CodeReviewBot) dani opened https://gitlab.wikimedia.org/repos/sre/miscweb/wikiworkshop/-/merge_requests/10 Set up static site generator [03:28:50] 10PageTriage: Article is marked as reviewed despite no log entries since move from draftspace - https://phabricator.wikimedia.org/T358969#9593810 (10A_smart_kitten) [04:24:50] 04(no projects): Port Femiwiki Team's extensions to Gerrit - https://phabricator.wikimedia.org/T358970 (10Lens0021) [04:25:40] 10MediaWiki-extensions-CodeMirror, 06Community-Tech: CodeMirror issues with MediaWiki UI set to yue on Chrome on Windows - https://phabricator.wikimedia.org/T358971 (10H78c67c) [04:32:55] 04(no projects): Port Femiwiki Team's extensions to Gerrit - https://phabricator.wikimedia.org/T358970#9593833 (10Lens0021) [04:35:52] 04(no projects): Port Femiwiki Team's extensions to Gerrit - https://phabricator.wikimedia.org/T358970#9593834 (10Lens0021) Related requests https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests#c-Lens0021-20240303043200 [04:46:06] 10MinT, 10Language-2024-January-March: Enable MADLAD-400 in MinT test instance for Wikipedia languages not supported by other services - https://phabricator.wikimedia.org/T354666#9593836 (10H78c67c) Please do not consider yue (Cantonese) support at this time. Like NLLB/FLORES-200 this dataset again suffers fro... [04:52:38] 10MinT, 10Language-2024-January-March: Enable MADLAD-400 in MinT test instance for Wikipedia languages not supported by other services - https://phabricator.wikimedia.org/T354666#9593838 (10H78c67c) I tested it out on https://translate.wmcloud.org/ and unfortunately it seems like it can't handle anything longe... [05:20:24] 10MediaWiki-User-Interface, 07JavaScript, 10Radar: "wikipage.content" JS hook: $content should be consistent on live previews - https://phabricator.wikimedia.org/T349298#9593842 (10Od1n) I have just encountered an issue in a gadget because of this discrepancy: https://fr.wikipedia.org/w/index.php?title=Media... [05:39:14] 14MediaWiki-jQuery-Tablesorter--archived, 07JavaScript: LivePreview: Re-run wikipage content handlers (jquery.makeCollapsible, jquery.tablesorter, ..) after preview content is loaded - https://phabricator.wikimedia.org/T35399#9593845 (10Od1n) You may want to have a look at T349298. [05:40:05] (03Abandoned) 10SD0001: Add logging for notifications sent via API module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/958058 (https://phabricator.wikimedia.org/T58362) (owner: 10SD0001) [05:41:37] 10MediaWiki-User-Interface, 07JavaScript, 10Radar: "wikipage.content" JS hook: $content should be consistent on live previews - https://phabricator.wikimedia.org/T349298#9593849 (10Od1n) This issue dates back to T35399. Problem located at: https://gerrit.wikimedia.org/g/mediawiki/core/+/4313b73df6162fb86575... [06:18:17] (03PS2) 10Tchanders: Group temporary users with IP users in ApiQueryWatchlist filters [core] - 10https://gerrit.wikimedia.org/r/1007970 (https://phabricator.wikimedia.org/T358693) [06:26:15] (03PS3) 10Tchanders: Group temporary users with IP users in ApiQueryWatchlist filters [core] - 10https://gerrit.wikimedia.org/r/1007970 (https://phabricator.wikimedia.org/T358693) [06:33:54] (03CR) 10Tchanders: [C: 03+2] Update GlobalBlockingLinkBuilder service for global account blocks [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/1007731 (https://phabricator.wikimedia.org/T358725) (owner: 10Dreamy Jazz) [06:40:59] (03CR) 10CI reject: [V: 04-1] Update GlobalBlockingLinkBuilder service for global account blocks [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/1007731 (https://phabricator.wikimedia.org/T358725) (owner: 10Dreamy Jazz) [07:05:07] 10MediaWiki-extensions-InlineComments: Add user mentions to InlineComments - https://phabricator.wikimedia.org/T355942#9593861 (10Sairamnst) @Yaron_Koren How can I contribute to this? I have previous experience working in React and Django and am learning Rails and have good knowledge of Javascript.. [07:07:54] (03CR) 10Nikerabbit: [C: 03+2] updateCollation: Minor cleanup [core] - 10https://gerrit.wikimedia.org/r/1008059 (owner: 10Reedy) [07:09:44] 06Structured-Data-Backlog, 10Kanban: Retrieve list of users for cross-wiki uploads research - https://phabricator.wikimedia.org/T358622#9593862 (10cchen) [07:28:47] (03Merged) 10jenkins-bot: updateCollation: Minor cleanup [core] - 10https://gerrit.wikimedia.org/r/1008059 (owner: 10Reedy) [07:46:19] (03PS3) 10Fomafix: Inject service LanguageConverterFactory in LanguagesHelper [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008043 [07:46:22] (03CR) 10Fomafix: Inject service LanguageConverterFactory in LanguagesHelper (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008043 (owner: 10Fomafix) [07:50:59] (03PS3) 10Fomafix: LanguagesHelperTest: Use @dataProvider to configure test cases [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008047 [07:54:34] (03CR) 10Fomafix: LanguagesHelperTest: Remove unused parameter from method getTitle (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008042 (owner: 10Fomafix) [07:58:59] (03PS1) 10Fomafix: Remove wrong parameter $this->once() [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008087 [08:09:51] 06Wikipedia-Android-App-Backlog: Convert Tabs to use database, not shared preference. - https://phabricator.wikimedia.org/T353656#9593876 (10YvesKalume) Is Room database the best approach for storing Tab data (Tab as an entity) ? Are there alternatives or best approach ? [09:27:08] 10MediaWiki-Patrolling, 101.42.0-wmf.21; 2024-03-05: Duplicate patrol logs of the same revision - https://phabricator.wikimedia.org/T196182#9593889 (10matej_suchanek) 05Open→03Resolved a:03Xiplus [10:12:45] 10GlobalBlocking, 10WMF-deployed Build Failure: GlobalBlocking CI is broken - https://phabricator.wikimedia.org/T358974 (10Dreamy_Jazz) [10:18:21] 10GlobalBlocking, 10WMF-deployed Build Failure: GlobalBlocking CI is broken - https://phabricator.wikimedia.org/T358974#9593905 (10Dreamy_Jazz) [10:20:37] 10GlobalBlocking, 06Trust and Safety Product Team, 13Patch-For-Review, 10Sprint Piano (Feb 19th - 1st March), 10WMF-deployed Build Failure: GlobalBlocking CI is broken - https://phabricator.wikimedia.org/T358974#9593909 (10Dreamy_Jazz) [10:20:56] 10GlobalBlocking, 06Trust and Safety Product Team, 13Patch-For-Review, 10Sprint Piano (Feb 19th - 1st March), 10WMF-deployed Build Failure: GlobalBlocking CI is broken - https://phabricator.wikimedia.org/T358974#9593912 (10Dreamy_Jazz) [10:21:39] 10GlobalBlocking, 06Trust and Safety Product Team, 13Patch-For-Review, 10Sprint Piano (Feb 19th - 1st March), 10WMF-deployed Build Failure: GlobalBlocking CI is broken - https://phabricator.wikimedia.org/T358974#9593910 (10Dreamy_Jazz) a:03Dreamy_Jazz [10:23:10] 10MediaWiki-extensions-WikibaseRepository, 07I18n: ‎wbremovequalifiers-update comment is not autoformatted - https://phabricator.wikimedia.org/T358975 (10matej_suchanek) [10:23:47] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10wmde-wikidata-tech, 07I18n: ‎wbremovequalifiers-update comment is not autoformatted - https://phabricator.wikimedia.org/T358975#9593925 (10matej_suchanek) [10:23:55] (03PS2) 10Dreamy Jazz: Use local CentralIdLookup in GlobalBlockLookupTest [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/1008090 (https://phabricator.wikimedia.org/T358974) [10:26:59] (03PS9) 10Dreamy Jazz: Maintenance: Add script to globally (un)block IPs [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/743591 (https://phabricator.wikimedia.org/T289373) (owner: 10Tks4Fish) [10:27:13] (03PS4) 10Dreamy Jazz: Update GlobalBlockingLinkBuilder service for global account blocks [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/1007731 (https://phabricator.wikimedia.org/T358725) [10:27:41] (03PS34) 10Dreamy Jazz: Update GlobalBlockLookup for global account blocks [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/1005621 (https://phabricator.wikimedia.org/T358155) [10:29:53] (03PS4) 10Krinkle: Minor improvents and consistency tweaks [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/1005853 (https://phabricator.wikimedia.org/T350947) [10:30:19] (03PS5) 10Krinkle: Minor improvents and consistency tweaks [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/1005853 (https://phabricator.wikimedia.org/T350947) [10:30:52] (03CR) 10Krinkle: Minor improvents and consistency tweaks (031 comment) [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/1005853 (https://phabricator.wikimedia.org/T350947) (owner: 10Krinkle) [10:32:11] (03PS1) 10Majavah: Use a factory to construct GlobalRenameUserStatus objects [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008091 [10:33:37] (03CR) 10CI reject: [V: 04-1] Maintenance: Add script to globally (un)block IPs [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/743591 (https://phabricator.wikimedia.org/T289373) (owner: 10Tks4Fish) [10:37:33] (03CR) 10CI reject: [V: 04-1] Minor improvents and consistency tweaks [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/1005853 (https://phabricator.wikimedia.org/T350947) (owner: 10Krinkle) [10:41:35] (03CR) 10Majavah: [C: 03+2] "I'm surprised this works this easily - CentralAuth has code that will try to always override the lookup provider to be the centralauth one" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/1008090 (https://phabricator.wikimedia.org/T358974) (owner: 10Dreamy Jazz) [10:45:03] (03PS1) 10Majavah: Split block hooks to new BlockHookHandler [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008092 [10:45:05] (03PS1) 10Majavah: Inject UserNameUtils to BlockHookHandler [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008093 [10:49:37] (03Merged) 10jenkins-bot: Use local CentralIdLookup in GlobalBlockLookupTest [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/1008090 (https://phabricator.wikimedia.org/T358974) (owner: 10Dreamy Jazz) [10:49:42] (03Merged) 10jenkins-bot: Update GlobalBlockingLinkBuilder service for global account blocks [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/1007731 (https://phabricator.wikimedia.org/T358725) (owner: 10Dreamy Jazz) [10:51:22] (03CR) 10CI reject: [V: 04-1] Split block hooks to new BlockHookHandler [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008092 (owner: 10Majavah) [10:52:09] (03CR) 10CI reject: [V: 04-1] Inject UserNameUtils to BlockHookHandler [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008093 (owner: 10Majavah) [10:58:14] 10GlobalBlocking, 06Trust and Safety Product Team, 13Patch-For-Review, 10Sprint Piano (Feb 19th - 1st March), 10WMF-deployed Build Failure: GlobalBlocking CI is broken - https://phabricator.wikimedia.org/T358974#9593941 (10Dreamy_Jazz) 05Open→03Resolved [10:58:24] (03PS2) 10Majavah: Split block hooks to new BlockHookHandler [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008092 [10:58:26] (03PS2) 10Majavah: Inject UserNameUtils to BlockHookHandler [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008093 [10:58:28] (03PS1) 10Majavah: Simplify CentralAuthHooksUsingDatabaseTest [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008094 [10:59:17] (03PS1) 10Punith.nyk: Refactor generateFileList function to replace moment.js with native nodejs functions [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008095 [10:59:49] (03CR) 10Dreamy Jazz: "Thanks for the quick review! It is good that there is a quick way around it (otherwise I would have not been able to look at this until Mo" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/1008090 (https://phabricator.wikimedia.org/T358974) (owner: 10Dreamy Jazz) [11:00:29] (03CR) 10Punith.nyk: "recheck" [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008095 (owner: 10Punith.nyk) [11:01:58] (03CR) 10Punith.nyk: "bwang@wikimedia.org" [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008095 (owner: 10Punith.nyk) [11:06:58] (03CR) 10Dreamy Jazz: [C: 03+2] Simplify CentralAuthHooksUsingDatabaseTest [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008094 (owner: 10Majavah) [11:15:39] 10PageTriage: Article is marked as reviewed despite no log entries since move from draftspace - https://phabricator.wikimedia.org/T358969#9593950 (10Novem_Linguae) Good find, Soda. I think that makes this a duplicate of {T337356} then. Merging. [11:16:39] (03CR) 10Dreamy Jazz: Split block hooks to new BlockHookHandler (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008092 (owner: 10Majavah) [11:18:31] (03CR) 10Dreamy Jazz: [C: 03+2] Inject UserNameUtils to BlockHookHandler [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008093 (owner: 10Majavah) [11:22:14] (03PS3) 10Majavah: Split block hooks to new BlockHookHandler [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008092 [11:22:16] (03PS3) 10Majavah: Inject UserNameUtils to BlockHookHandler [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008093 [11:22:18] (03PS2) 10Majavah: Simplify CentralAuthHooksUsingDatabaseTest [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008094 [11:22:32] (03CR) 10Dreamy Jazz: Split block hooks to new BlockHookHandler (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008092 (owner: 10Majavah) [11:22:40] (03CR) 10Majavah: Split block hooks to new BlockHookHandler (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008092 (owner: 10Majavah) [11:24:44] (03CR) 10Dreamy Jazz: [C: 03+2] Simplify CentralAuthHooksUsingDatabaseTest [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008094 (owner: 10Majavah) [11:25:28] 10MediaWiki-extensions-Other: Port Femiwiki Team's extensions to Gerrit - https://phabricator.wikimedia.org/T358970#9593955 (10Bugreporter) [11:26:19] (03PS12) 10Matěj Suchánek: Add new variable for last edit time [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/860964 (https://phabricator.wikimedia.org/T269769) [11:28:39] 10PageTriage: Article is marked as reviewed despite no log entries since move from draftspace - https://phabricator.wikimedia.org/T358969#9593957 (10Novem_Linguae) Actually, just kidding. {T337356} is about the resulting redirect, not the article. Hmm. I did some localhost testing just now and was not able to r... [11:29:06] (03PS1) 10Punith.nyk: Replace deepmerge npm library with native Array.concat for merging arrays in Stats.readi18nFiles function. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008096 [11:29:31] (03CR) 10Punith.nyk: "recheck" [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008096 (owner: 10Punith.nyk) [11:38:17] (03CR) 10Dreamy Jazz: [C: 03+2] Split block hooks to new BlockHookHandler [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008092 (owner: 10Majavah) [11:46:42] (03Abandoned) 10TheDJ: Add resource attribute to video elements [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/977278 (https://phabricator.wikimedia.org/T305210) (owner: 10TheDJ) [11:46:58] (03Merged) 10jenkins-bot: Split block hooks to new BlockHookHandler [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008092 (owner: 10Majavah) [11:47:00] (03Merged) 10jenkins-bot: Inject UserNameUtils to BlockHookHandler [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008093 (owner: 10Majavah) [11:47:02] (03Merged) 10jenkins-bot: Simplify CentralAuthHooksUsingDatabaseTest [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008094 (owner: 10Majavah) [11:47:41] (03CR) 10Fomafix: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008087 (owner: 10Fomafix) [11:47:57] (03Abandoned) 10TheDJ: Improve render performance of CodeMirror [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/574855 (https://phabricator.wikimedia.org/T197502) (owner: 10TheDJ) [12:00:35] 10InternetArchiveBot: Need to have an access on DB IA - https://phabricator.wikimedia.org/T358978 (10Pmartin) [12:27:50] 06MediaWiki-Platform-Team, 10MediaWiki-extensions-CentralAuth, 10GlobalBlocking, 06Trust and Safety Product Team: Show global block information on Special:CentralAuth/ - https://phabricator.wikimedia.org/T358979 (10taavi) [12:35:53] 10MobileFrontend, 10Parsoid, 10Parsoid-Read-Views: Images displayed twice in mobile view with Parsoid read views enabled - https://phabricator.wikimedia.org/T358980 (10taavi) [12:40:27] 10MobileFrontend, 10DiscussionTools, 10Parsoid, 10Parsoid-Read-Views: Talk page discussion parsing is broken on mobile views with Parsoid read views enabled - https://phabricator.wikimedia.org/T358981 (10taavi) [12:43:11] (03PS2) 10Majavah: Use a factory to construct GlobalRenameUserStatus objects [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008091 [12:44:11] (03PS1) 10Punith.nyk: Refactor: Replace 'del' npm library with native Node.js file system functions in copyTranslationFiles function [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008097 [12:45:15] (03CR) 10Punith.nyk: "recheck" [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008097 (owner: 10Punith.nyk) [12:45:52] (03PS1) 10Majavah: Use GlobalRenameUserStatus factory [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/1008098 [12:46:24] (03CR) 10Majavah: Use a factory to construct GlobalRenameUserStatus objects (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/1008091 (owner: 10Majavah) [12:47:22] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594035 (10Rockingpenny4) @Yaron_Koren where can i find more information regarding the built-in classes , should I refer to this https://www.mediawiki.org/wiki/Manual:Html.php? [12:51:31] (03PS2) 10Punith.nyk: Refactor: Replace 'del' npm library with native Node.js file system functions [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008097 [13:04:38] (03PS2) 10Fomafix: Remove wrong parameter $this->once() [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008087 [13:05:04] (03CR) 10Fomafix: LanguagesHelperTest: Remove unused parameter from method getTitle (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008042 (owner: 10Fomafix) [13:05:55] (03CR) 10Fomafix: Inject service LanguageConverterFactory in LanguagesHelper (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008043 (owner: 10Fomafix) [13:06:09] (03PS4) 10Fomafix: Inject service LanguageConverterFactory in LanguagesHelper [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008043 [13:07:38] (03PS4) 10Fomafix: LanguagesHelperTest: Use @dataProvider to configure test cases [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008047 [13:11:15] 10MediaWiki-extensions-InlineComments: Add "inlinecomments-view" permission - https://phabricator.wikimedia.org/T355950#9594044 (10Solaris22) Hey @Yaron_Koren can you provide me with more context about the inlinecomments-view permission.We want to enable certain user groups to view comments while restricting acc... [13:17:20] 10MediaWiki-extensions-OATHAuth: Parser function for checking if OATHAuth is enabled - https://phabricator.wikimedia.org/T326912#9594051 (10taavi) 05Open→03Declined This would require splitting the parser cache per-user, let's not do that. For requiring 2-factor authentication for some users there are surely... [13:39:37] 04(no projects): I cant upload a new version of the picture - https://phabricator.wikimedia.org/T358982 (10Wilfredor) [13:48:04] 10MediaWiki-extensions-InlineComments: Add user mentions to InlineComments - https://phabricator.wikimedia.org/T355942#9594079 (10Yaron_Koren) @Sairamnst - just to clarify, this is not a microtask, it's a major task! But if you want to work on this now, feel free. You can find everything about InlineComments, in... [13:49:05] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594080 (10Yaron_Koren) Sure, that looks like a good resource. It could also help to look at the file itself. [13:49:56] (03PS1) 10Pcoombe: Move logos back to stop them being covered by search on mobile [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008099 (https://phabricator.wikimedia.org/T358839) [13:51:06] 10MediaWiki-extensions-InlineComments: Add "inlinecomments-view" permission - https://phabricator.wikimedia.org/T355950#9594083 (10Yaron_Koren) Sure, it needs to look something like that - there would probably need to be an "if" check in at least one place in the code. [13:52:35] (03PS1) 10Fomafix: Move Hooks::setMinervaSkinOptions to new class MinervaSkinOptions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008100 [13:54:57] (03PS5) 10Daimona Eaytoy: [DNM] Test CI [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1008063 [13:58:05] (03CR) 10CI reject: [V: 04-1] Move Hooks::setMinervaSkinOptions to new class MinervaSkinOptions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008100 (owner: 10Fomafix) [14:02:29] (03CR) 10CI reject: [V: 04-1] [DNM] Test CI [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1008063 (owner: 10Daimona Eaytoy) [14:07:08] (03PS1) 10Alex Mashin: Enable tag emulation mode for all connectors [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/1008101 [14:09:14] (03CR) 10CI reject: [V: 04-1] Enable tag emulation mode for all connectors [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/1008101 (owner: 10Alex Mashin) [14:12:22] (03PS2) 10Alex Mashin: Enable tag emulation mode for all connectors [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/1008101 [14:14:57] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594086 (10Rockingpenny4) ` $text = Html::rawElement( 'p', ['class' => $this->name], "\n" ); ` On going through the documentation, maybe the rawElement() method could be used as... [14:17:39] 06Wikipedia-Android-App-Backlog: Convert Tabs to use database, not shared preference. - https://phabricator.wikimedia.org/T353656#9594087 (10Dbrant) >>! In T353656#9593876, @YvesKalume wrote: > Is Room database the best approach for storing Tab data (Tab as an entity) ? Are there alternatives or best approach ?... [14:17:54] 06MediaWiki-Engineering, 06Data-Engineering, 10WMF-JobQueue, 06serviceops, and 3 others: Could not enqueue jobs: "Unable to deliver all events: 503: Service Unavailable" - https://phabricator.wikimedia.org/T249745#9594088 (10Ottomata) > I still wonder why profile::kafka::mirror::properties doesn't blackli... [14:18:01] (03PS2) 10Fomafix: Move Hooks::setMinervaSkinOptions to new class MinervaSkinOptions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008100 [14:21:19] (03PS3) 10Fomafix: Move Hooks::setMinervaSkinOptions to new class MinervaSkinOptions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008100 [14:21:21] 10Wikimedia-Portals: Wikibooks logo is missing (not loaded) on the Wikibooks portal (https://www.wikibooks.org/) - https://phabricator.wikimedia.org/T358568#9594091 (10Pcoombe) [14:22:32] 10Wikimedia-Portals: Wikibooks-logo-tiles_1.5x.png on www.wikibooks.org is a 404 - https://phabricator.wikimedia.org/T317484#9594093 (10Pcoombe) [14:24:37] 10MediaWiki-extensions-DrawioEditor: Activating DrawIO Editor break a fresh install - https://phabricator.wikimedia.org/T351286#9594096 (10EU0873) Yes. No clue what causes this. After upgrading and installing the matching drawioEditor version, the visual editor won't load any more. install drawio editor tag 2.01... [14:26:07] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594097 (10Yaron_Koren) Using rawElement() does seem like a reasonable approach. [14:28:38] (03PS1) 10Pcoombe: Correct file name for 1.5x Wikibooks logo [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008102 (https://phabricator.wikimedia.org/T317484) [14:29:04] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594100 (10Rockingpenny4) Great, should I go ahead and push the changes? [14:33:01] (03PS6) 10Daimona Eaytoy: [DNM] Test CI [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1008063 [14:57:57] 10MediaWiki-Installer, 06MediaWiki-Platform-Team, 10MediaWiki-extensions-CentralAuth, 10Continuous-Integration-Config, 07ci-test-error: Admin account created by the installer isn't made global by CentralAuth (at least in CI) - https://phabricator.wikimedia.org/T358985 (10Daimona) [15:00:41] 10MediaWiki-Uploading: I cant upload a new version of the picture - https://phabricator.wikimedia.org/T358982#9594146 (10Reedy) [15:01:46] 10MediaWiki-Uploading, 10UploadWizard: I cant upload a new version of the picture - https://phabricator.wikimedia.org/T358982#9594148 (10Sannita) [15:02:35] 10MediaWiki-Uploading: I can't upload a new version of a file that is larger than 100 MB because of file limit in Special:Upload - https://phabricator.wikimedia.org/T358982#9594150 (10Sannita) [15:09:19] (03CR) 10Reedy: [C: 03+1] "Thanks!" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/1008013 (owner: 10Nikerabbit) [15:21:08] (03PS2) 10Bodhisattwa: mediawiki.language: Update bangla characters per request [core] - 10https://gerrit.wikimedia.org/r/1008015 (https://phabricator.wikimedia.org/T358972) [15:22:16] 10MediaWiki-User-login-and-signup: @ (at-sign) needs to be totally invalid for usernames - https://phabricator.wikimedia.org/T14581#9594169 (10Bugreporter) [15:22:19] 10MediaWiki-extensions-CentralAuth, 10WMF-General-or-Unknown: Rename global users with invalid characters on their usernames - https://phabricator.wikimedia.org/T160296#9594170 (10Bugreporter) [15:22:46] 10MediaWiki-extensions-CentralAuth, 10WMF-General-or-Unknown: Rename global users with invalid characters on their usernames - https://phabricator.wikimedia.org/T160296#9594168 (10Bugreporter) >>! In T160296#7400626, @Zabe wrote: > There are 40941 global users with an @ in their username. > > ` > MariaDB [cen... [15:26:34] 10FY2023-24-Research-January-March: Exploratory work on language-agnostic model for link recommendation for add-a-link - https://phabricator.wikimedia.org/T354659#9594174 (10AKhatun_WMF) Update 26/2/2024 - 3/3/2024: - Trained a combined model with all data and with stratified split - Hyperparameter tuning in pro... [15:37:28] (03PS1) 10Rockingpenny4: Uses rawElement for class names [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/1008105 [15:37:38] (03PS4) 10TheDJ: [DNM] Set a CSP header to sandbox uploaded files [core] - 10https://gerrit.wikimedia.org/r/547930 (https://phabricator.wikimedia.org/T239069) (owner: 10Brian Wolff) [15:38:02] (03CR) 10Yaron Koren: "Did you try this? Does it work - including for row names that contain a space?" [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/1008105 (owner: 10Rockingpenny4) [15:38:18] (03CR) 10Yaron Koren: "Also, it would be better to modify the original patch, rather than making new patches on top of it." [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/1008105 (owner: 10Rockingpenny4) [15:43:03] 04(no projects): Greater-than sign breaks wiki subheadings - https://phabricator.wikimedia.org/T358987 (10Taylor) [15:45:54] 06Future-Audiences: [citation-needed] Implement a Cron Job for log extraction - https://phabricator.wikimedia.org/T358698#9594196 (10EliasRut) This is now active with a daily schedule: {F42368494} The logs are exported to a shared Google Drive folder. The deletion of old logs is prepared (command: export-and-d... [15:46:54] 06Future-Audiences: [citation-needed] Experiment with side panel view - https://phabricator.wikimedia.org/T358988 (10EliasRut) [15:47:33] 06Future-Audiences: [citation-needed] Experiment: Tweak instructions for better result qualities - https://phabricator.wikimedia.org/T358989 (10EliasRut) [15:48:09] 06Future-Audiences: [citation-needed] Find solution to context window based errors - https://phabricator.wikimedia.org/T358990 (10EliasRut) [15:48:47] 06Future-Audiences: [citation-needed] Experiment: Use extracts instead of TOCs and full text sections - https://phabricator.wikimedia.org/T358991 (10EliasRut) [15:49:47] 06Future-Audiences: [citation-needed] Instroduce numeric, objective quality measurements - https://phabricator.wikimedia.org/T358992 (10EliasRut) [15:50:31] 06Future-Audiences: [citation-needed] Improve latency - https://phabricator.wikimedia.org/T358993 (10EliasRut) [15:52:47] (03CR) 10CI reject: [V: 04-1] [DNM] Set a CSP header to sandbox uploaded files [core] - 10https://gerrit.wikimedia.org/r/547930 (https://phabricator.wikimedia.org/T239069) (owner: 10Brian Wolff) [15:52:55] 06Future-Audiences: [citation-needed] Links lead to section, not start of page - https://phabricator.wikimedia.org/T358994 (10EliasRut) [15:53:46] 06Future-Audiences: [citation-needed] Include page start in list of TOCs - https://phabricator.wikimedia.org/T358995 (10EliasRut) [15:54:16] 06Future-Audiences: [citation-needed] Create test set for Citation Needed - https://phabricator.wikimedia.org/T357485#9594278 (10EliasRut) [16:00:04] (03Abandoned) 10Umherirrender: schema: Add templatetrackinglinks table [core] - 10https://gerrit.wikimedia.org/r/970863 (https://phabricator.wikimedia.org/T268526) (owner: 10Umherirrender) [16:00:09] (03Abandoned) 10Umherirrender: LinksUpdate: Add support for templatetrackinglinks table [core] - 10https://gerrit.wikimedia.org/r/970864 (https://phabricator.wikimedia.org/T268526) (owner: 10Umherirrender) [16:00:14] (03Abandoned) 10Umherirrender: parser: Use ParserOutput::addTemplateTracking on parser functions [core] - 10https://gerrit.wikimedia.org/r/970865 (https://phabricator.wikimedia.org/T268526) (owner: 10Umherirrender) [16:01:07] (03Abandoned) 10Umherirrender: parser: Set cache expiry for protectionlevel/protectionexpiry functions [core] - 10https://gerrit.wikimedia.org/r/975359 (owner: 10Umherirrender) [16:01:26] (03PS4) 10Umherirrender: Sort model data by model name in SqlModelLookup [extensions/ORES] - 10https://gerrit.wikimedia.org/r/991932 [16:01:50] (03PS3) 10Umherirrender: Convert MalformedTitleException to ErrorPageError [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/992537 (https://phabricator.wikimedia.org/T353469) [16:02:25] (03CR) 10Umherirrender: "recheck" [extensions/WikimediaCampaignEvents] - 10https://gerrit.wikimedia.org/r/1005853 (https://phabricator.wikimedia.org/T350947) (owner: 10Krinkle) [16:05:04] (03PS5) 10TheDJ: [DNM] Set a CSP header to sandbox uploaded files [core] - 10https://gerrit.wikimedia.org/r/547930 (https://phabricator.wikimedia.org/T239069) (owner: 10Brian Wolff) [16:05:18] 10Phabricator: Rename my Phabricator account to GTrang - https://phabricator.wikimedia.org/T358996 (10GeoffreyT2000) [16:06:04] 10MediaWiki-Core-Tests, 10MediaWiki-Parser, 06Content-Transform-Team-WIP, 101.42.0-wmf.20; 2024-02-27, 10WMF-deployed Build Failure: "PHP Deprecated: Use of MediaWiki\Parser\ParserOutput::setTOCHTML was deprecated in MediaWiki 1.40" in PHPUnit tests - https://phabricator.wikimedia.org/T355952#9594295 (10... [16:06:10] 10MediaWiki-Page-derived-data, 10MediaWiki-Parser, 07Epic, 07Schema-change: Use a dedicated mechanism to track page dependencies - https://phabricator.wikimedia.org/T268526#9594283 (10Umherirrender) [16:08:46] (03CR) 10TheDJ: [DNM] Set a CSP header to sandbox uploaded files (033 comments) [core] - 10https://gerrit.wikimedia.org/r/547930 (https://phabricator.wikimedia.org/T239069) (owner: 10Brian Wolff) [16:16:03] (03PS2) 10Rockingpenny4: ALRow: Add row search class [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/1007973 (https://phabricator.wikimedia.org/T327263) [16:16:37] (03PS5) 10TheDJ: MediaSearch filters can wrap on narrow screens. [extensions/MediaSearch] - 10https://gerrit.wikimedia.org/r/1008005 (https://phabricator.wikimedia.org/T334198) [16:21:39] 10Desktop Improvements (Vector 2022): Excessive space after p tags is causing new spacing issues - https://phabricator.wikimedia.org/T358921#9594301 (10Jonesey95) Additional vertical spacing problems, this time excessive padding around blockquote tags, has been reported at https://en.wikipedia.org/w/index.php?ti... [16:22:11] 10LibUp: libup web view should mark mediawiki/core as wmf deployed and bundled with tarball - https://phabricator.wikimedia.org/T358997 (10Umherirrender) [16:22:17] 10LibUp: libup web view should mark library bundled in mediawiki/vendor as wmf deployed - https://phabricator.wikimedia.org/T358998 (10Umherirrender) [16:24:19] (03CR) 10CI reject: [V: 04-1] [DNM] Set a CSP header to sandbox uploaded files [core] - 10https://gerrit.wikimedia.org/r/547930 (https://phabricator.wikimedia.org/T239069) (owner: 10Brian Wolff) [16:26:04] 10LibUp: libup web view should mark library bundled in mediawiki/vendor as wmf deployed - https://phabricator.wikimedia.org/T358998#9594331 (10Umherirrender) This feature request would covers mostly composer packages. This could also or additional use `foreign-resources.yaml` from core and the extensions as a so... [16:26:28] 10Wikimedia-CentralNotice-Administration: Mobile: Be sure banner size is compatible with all language sites - https://phabricator.wikimedia.org/T358947#9594329 (10Pcoombe) Not a fundraising banner [16:28:20] 10Wikimedia-CentralNotice-Administration: International Women's day 2023 banner displaying even with account banner preferences set to not display - https://phabricator.wikimedia.org/T331678#9594333 (10Pcoombe) 05Open→03Resolved Reading the parent task I believe this has been fixed [16:28:24] 10MediaWiki-extensions-CentralNotice, 03Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07User-notice-archive: CentralNotice banners being shown too many times - https://phabricator.wikimedia.org/T331671#9594335 (10Pcoombe) [16:35:32] 10Local-Wiki-Template-And-Gadget-Issues, 10Wikimedia-CentralNotice-Administration: Mobile: Be sure banner size is compatible with all language sites - https://phabricator.wikimedia.org/T358947#9594339 (10Pcoombe) Note that the series of links overlapping the header are coming from https://vi.wikipedia.org/wik... [16:35:54] (03Abandoned) 10Punith.nyk: logo is covered by search bar on mobile [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008104 (https://phabricator.wikimedia.org/T358839) (owner: 10Punith.nyk) [16:41:37] (03CR) 10Daimona Eaytoy: "recheck" [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1007689 (owner: 10Daimona Eaytoy) [16:43:47] 10MediaWiki-Parser: Greater-than sign breaks wiki subheadings - https://phabricator.wikimedia.org/T358987#9594352 (10Bugreporter) [16:44:00] 10MediaWiki-Parser: Greater-than sign breaks wiki subheadings - https://phabricator.wikimedia.org/T358987#9594354 (10Bugreporter) Not happened in Parsoid. [16:44:36] 10MediaWiki-Parser: Greater-than sign breaks wiki subheadings - https://phabricator.wikimedia.org/T358987#9594356 (10Bugreporter) [16:45:22] 06Content-Transform-Team, 10DiscussionTools, 13Patch-For-Review: Having <> in headings leads to errors - https://phabricator.wikimedia.org/T358810#9594358 (10Bugreporter) [16:45:24] (03PS4) 10Daimona Eaytoy: Rework MWEventLookupFromPage to be the main event-by-page lookup [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1007613 (https://phabricator.wikimedia.org/T357716) [16:45:30] (03PS6) 10Daimona Eaytoy: Make translated event pages use the same registration as the source page [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1007635 (https://phabricator.wikimedia.org/T357716) [16:48:53] (03CR) 10CI reject: [V: 04-1] Make translated event pages use the same registration as the source page [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1007635 (https://phabricator.wikimedia.org/T357716) (owner: 10Daimona Eaytoy) [16:55:59] (03PS7) 10Daimona Eaytoy: Make translated event pages use the same registration as the source page [extensions/CampaignEvents] - 10https://gerrit.wikimedia.org/r/1007635 (https://phabricator.wikimedia.org/T357716) [16:57:31] 10MediaWiki-Maintenance-system, 10AbuseFilter, 07Technical-Debt: purgeRedundantText: Potential data loss - https://phabricator.wikimedia.org/T213478#9594377 (10Daimona) [16:57:42] 10AbuseFilter, 13Patch-Needs-Improvement: 'Examine' should show details of the edit at the time the edit was made - https://phabricator.wikimedia.org/T102944#9594378 (10Daimona) [16:58:30] 10AbuseFilter, 10Wikimedia-Site-requests, 13Patch-Needs-Improvement: AbuseFilter permissions spread all over InitialiseSettings and abusefilter.php: they should be in one place - https://phabricator.wikimedia.org/T145931#9594380 (10Daimona) [16:58:33] 10AbuseFilter, 13Patch-Needs-Improvement: "Soft" actions shouldn't be logged if the edit isn't saved - https://phabricator.wikimedia.org/T206548#9594381 (10Daimona) [16:58:45] 10AbuseFilter, 10ContentTranslation: ContentTranslation probably saves changes repeatedly and this is affected by AbuseFilter - https://phabricator.wikimedia.org/T155897#9594382 (10Daimona) [16:59:10] 10AbuseFilter, 06Data-Persistence (work done), 06Stewards-and-global-tools, 13Patch-Needs-Improvement: Addition of last hit date to Special:AbuseFilter table - https://phabricator.wikimedia.org/T93564#9594384 (10Daimona) [17:02:26] 10AbuseFilter: Extend abuse filter search to include warning and disallow message names - https://phabricator.wikimedia.org/T217227#9594399 (10Daimona) [17:02:42] 10AbuseFilter: Syntax check should be consistent with actual parsing - https://phabricator.wikimedia.org/T214643#9594401 (10Daimona) [17:02:49] 10AbuseFilter: Special:AbuseLog issues when filtering vs not filtering results - https://phabricator.wikimedia.org/T213982#9594402 (10Daimona) [17:02:56] 10AbuseFilter: Convert Special:AbuseLog to more standard delete and suppress system - https://phabricator.wikimedia.org/T115530#9594403 (10Daimona) [17:03:20] 10AbuseFilter: Create a front end for making unit tests for filters - https://phabricator.wikimedia.org/T208842#9594404 (10Daimona) [17:03:22] 10AbuseFilter: New test tool: examine syntax against the past hits of a filter - https://phabricator.wikimedia.org/T36180#9594405 (10Daimona) [17:03:24] 10AbuseFilter: AbuseFilter not blocking edits that trigger the Filter - https://phabricator.wikimedia.org/T242696#9594406 (10Daimona) [17:03:29] 10AbuseFilter: The filter ID in the URL is redundant when viewing an old version of a filter - https://phabricator.wikimedia.org/T238431#9594407 (10Daimona) [17:03:45] 10AbuseFilter: Avoid using VariableHolder objects to process and undo the 'degroup' action - https://phabricator.wikimedia.org/T265224#9594421 (10Daimona) [17:03:53] (03PS2) 10Punith.nyk: Refactor generateFileList function to replace moment.js with native nodejs functions [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008095 [17:04:01] 10AbuseFilter, 07Wikimedia-Performance-recommendation: Verify AbuseFilter code that claims to share and re-use ParserOutput from core - https://phabricator.wikimedia.org/T264104#9594422 (10Daimona) [17:04:09] 10AbuseFilter: non-commutativity of short-circuiting operations due to truthy/falsy values - https://phabricator.wikimedia.org/T237336#9594423 (10Daimona) [17:04:17] 10MediaWiki-libs-BagOStuff, 10AbuseFilter, 10Radar: Global filters cache key not being invalidated - https://phabricator.wikimedia.org/T253213#9594424 (10Daimona) [17:04:25] 10AbuseFilter: "&" is not commutative when an operand is undefined - https://phabricator.wikimedia.org/T236127#9594426 (10Daimona) [17:04:33] 10AbuseFilter: Range block duration should not be hardcoded - https://phabricator.wikimedia.org/T233764#9594427 (10Daimona) [17:04:41] 10AbuseFilter: Allow AbuseFilter to force the user to solve a captcha - https://phabricator.wikimedia.org/T20110#9594428 (10Daimona) [17:04:49] 10MediaWiki-Change-tagging, 10AbuseFilter, 10Tracking: Abusefilter's block with a "Mobile edit" tag - https://phabricator.wikimedia.org/T228959#9594429 (10Daimona) [17:04:57] 07Design, 10AbuseFilter, 13Patch-Needs-Improvement: Throttle groups field descriptions unreadable if too long - https://phabricator.wikimedia.org/T218992#9594430 (10Daimona) [17:05:09] 10phan-taint-check-plugin: make phan-taint-check handle array_map - https://phabricator.wikimedia.org/T204911#9594431 (10Daimona) [17:06:09] (03PS1) 10Solaris122: added inlinecomments-view permission [extensions/InlineComments] - 10https://gerrit.wikimedia.org/r/1008107 [17:07:29] 10MediaWiki-Documentation, 10MediaWiki-General, 10phan, 13Patch-For-Review, and 2 others: Formalize exception handling and annotations in MediaWiki and enforce it in CI - https://phabricator.wikimedia.org/T321683#9594447 (10Daimona) [17:07:59] 10MediaWiki-General, 13Patch-For-Review, 15User-Daimona: Stop using MWException in Wikimedia deployed code - https://phabricator.wikimedia.org/T328220#9594449 (10Daimona) [17:08:22] 06Content-Transform-Team, 10DiscussionTools, 13Patch-For-Review: Having <> in headings leads to errors - https://phabricator.wikimedia.org/T358810#9594451 (10Taylor) Shot: https://commons.wikimedia.org/w/index.php?title=File:Bug-in-subheadings-ASCII-62.png Link: https://eo.wikipedia.org/w/index.php?title=Vik... [17:08:45] 10MediaWiki-General, 13Patch-For-Review, 15User-Daimona: Stop using MWException in Wikimedia deployed code - https://phabricator.wikimedia.org/T328220#9594452 (10Daimona) [17:09:02] 10MediaWiki-HTMLForm, 07I18n, 07Technical-Debt, 15User-Daimona: HTMLForm: Remove $messagePrefix and related code - https://phabricator.wikimedia.org/T337945#9594453 (10Daimona) [17:09:41] 10MediaWiki-Internationalization, 10phan, 10Continuous-Integration-Config, 07I18n, and 2 others: Ensure constructed i18n messages document all possible used strings in comments in PHP - https://phabricator.wikimedia.org/T338091#9594454 (10Daimona) [17:18:08] 10MediaWiki-Core-Tests, 10MediaWiki-Parser, 06Content-Transform-Team-WIP, 07Essential-Work , and 2 others: Migrate Parser and extension tests away from deprecated PHPUnit TestSuite subclassing - https://phabricator.wikimedia.org/T345481#9594471 (10Daimona) [17:18:35] 10MediaWiki-Core-Tests, 101.42.0-wmf.21; 2024-03-05, 07Developer Productivity, 13Patch-For-Review, 15User-Daimona: Speed up MediaWiki PHPUnit build by running integration tests in parallel - https://phabricator.wikimedia.org/T50217#9594473 (10Daimona) [17:18:44] (03CR) 10Rockingpenny4: "I tried to test it locally by creating an instance of a row with name containing spaces but I wasn't able to explicitly access the class a" [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/1008105 (owner: 10Rockingpenny4) [17:19:31] 10MediaWiki-Codesniffer, 13Patch-For-Review, 07Upstream, 15User-Daimona: Detect incorrectly indented multiline function calls - https://phabricator.wikimedia.org/T340909#9594475 (10Daimona) [17:19:47] 10MediaWiki-Codesniffer, 13Patch-For-Review, 15User-Daimona: Detect incorrectly indented array elements - https://phabricator.wikimedia.org/T319352#9594476 (10Daimona) [17:20:51] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594477 (10Rockingpenny4) @Yaron_Koren I have updated the original patch and while testing it locally, I created an instance of a row with name containing spaces but I wasn't able to... [17:21:06] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594478 (10Rockingpenny4) @Yaron_Koren I have updated the original patch and while testing it locally, I created an instance of a row with name containing spaces but I wasn't able to... [17:22:33] 10MediaWiki-Codesniffer, 13Patch-For-Review, 15User-Daimona: Enable the Universal.WhiteSpace.DisallowInlineTabs sniff - https://phabricator.wikimedia.org/T349430#9594479 (10Daimona) [17:24:48] (03CR) 10Yaron Koren: "Wouldn't "view source" work for that?" [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/1008105 (owner: 10Rockingpenny4) [17:39:00] 10MediaWiki-extensions-InlineComments: Add user mentions to InlineComments - https://phabricator.wikimedia.org/T355942#9594482 (10Sairamnst) Thank you so much! I will start working on this... Can you suggest some microtasks that I can work on too? I would like to contribute any way I can? [17:47:34] 10MediaWiki-extensions-InlineComments: Add "inlinecomments-view" permission - https://phabricator.wikimedia.org/T355950#9594483 (10Solaris22) Hello @Yaron_Koren can you please check this patch once and provide any insights or changes required. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/InlineComments... [17:54:52] (03CR) 10Yaron Koren: "This looks like generally the right approach! But I think it can be simplified - loading the modules conditionally seems too complex. Also" [extensions/InlineComments] - 10https://gerrit.wikimedia.org/r/1008107 (owner: 10Solaris122) [18:01:41] 10MediaWiki-extensions-InlineComments: Add user mentions to InlineComments - https://phabricator.wikimedia.org/T355942#9594489 (10Yaron_Koren) Just to clarify - is this for the Google Summer of Code, or unrelated? [18:11:49] (03PS4) 10Punith.nyk: Refactor: Replace 'del' npm library with native Node.js file system functions in copyTranslationFiles function [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008097 [18:29:46] 10MediaWiki-extensions-InlineComments: Add user mentions to InlineComments - https://phabricator.wikimedia.org/T355942#9594493 (10Sairamnst) It is for GSOC. [18:33:53] 10MediaWiki-extensions-InlineComments: Add user mentions to InlineComments - https://phabricator.wikimedia.org/T355942#9594495 (10Sairamnst) This is my first time participating for Google Summer of Code so I am a bit unaware of the process... Where should I start at? [18:42:17] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594497 (10Rockingpenny4) @Yaron_Koren I tested row names with spaces and special characters and it breaks with apostrophes so either we can specify to replace apostrophes with someth... [18:48:27] (03PS1) 10Fomafix: Inject services in Hooks [skins/Vector] - 10https://gerrit.wikimedia.org/r/1008108 [18:49:43] 10MediaWiki-Internationalization, 10phan, 10Continuous-Integration-Config, 07I18n, and 2 others: Ensure constructed i18n messages document all possible used strings in comments in PHP - https://phabricator.wikimedia.org/T338091#9594498 (10Daimona) [18:50:55] (03PS1) 10Punith.nyk: Replace 'preq' with 'fetch' in the code base [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008109 [18:51:24] (03PS1) 10Fomafix: Hooks: Use private instead of public for internal functions [skins/Vector] - 10https://gerrit.wikimedia.org/r/1008110 [18:53:20] 10MediaWiki-General, 07ContentSecurityPolicy, 13Patch-For-Review, 07Security: Consider adding more CSP directives to MediaWIki core - https://phabricator.wikimedia.org/T327588#9594499 (10alistair3149) >>! In T327588#9593598, @Bawolff wrote: > object-src is probably not too useful in modern browsers now tha... [18:55:16] (03CR) 10Tacsipacsi: "Thanks for the patch! Two things in addition to the inline comments:" [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008088 (owner: 10Punith.nyk) [19:00:44] (03CR) 10CI reject: [V: 04-1] Inject services in Hooks [skins/Vector] - 10https://gerrit.wikimedia.org/r/1008108 (owner: 10Fomafix) [19:02:02] (03CR) 10Tacsipacsi: "This does the same thing, but with 31 lines more. Is it really worth reinventing the wheel? If yes, please explain in the commit message w" [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008097 (owner: 10Punith.nyk) [19:05:50] (03CR) 10Punith.nyk: "Hey, these are the micro-tasks that are mentioned in the: https://phabricator.wikimedia.org/T358885.I wish to participate in the upcoming " [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008097 (owner: 10Punith.nyk) [19:08:07] (03CR) 10Punith.nyk: Refactor: Replace 'del' npm library with native Node.js file system functions in copyTranslationFiles function (031 comment) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008097 (owner: 10Punith.nyk) [19:10:51] (03PS5) 10Punith.nyk: Refactor: Replace 'del' npm library with native Node.js file system functions in grupfile.js directory [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008097 [19:15:07] 10MobileFrontend, 10Parsoid, 10Parsoid-Read-Views: Images displayed twice in mobile view on main page with Parsoid read views enabled - https://phabricator.wikimedia.org/T358980#9594526 (10Jdlrobson) [19:18:59] 10MobileFrontend, 10Parsoid, 10Parsoid-Read-Views: Images displayed twice in mobile view on main page with Parsoid read views enabled - https://phabricator.wikimedia.org/T358980#9594529 (10taavi) @Jdlrobson, this does not seem to be specific to the main page: {F42370765} [19:23:53] (03PS2) 10Fomafix: Inject services in Hooks [skins/Vector] - 10https://gerrit.wikimedia.org/r/1008108 [19:24:57] (03PS2) 10Punith.nyk: Refactor: Replace underscore library with native array functions site-stats.js [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008088 [19:25:02] 10MobileFrontend, 10Parsoid, 10Parsoid-Read-Views: Images displayed twice in mobile view on main page with Parsoid read views enabled - https://phabricator.wikimedia.org/T358980#9594534 (10ssastry) This and all the other mobile web tasks filed by you and Jon are all blocked on {T269499}. [19:25:39] (03CR) 10Tacsipacsi: "Thanks for the patch, it indeed improves readability! Unfortunately much of the diff is just you deviating from the [coding conventions](h" [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008089 (owner: 10Punith.nyk) [19:25:44] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594536 (10Yaron_Koren) Actually, it looks like apostrophes are being handled fine - they're getting HTML-escaped, which I think is valid behavior. (That is, I think JS and CSS select... [19:30:23] 10MobileFrontend, 06Web-Team-Backlog, 07Epic, 10Tracking: [Epic] Make MobileFrontend compatible with Parsoid HTML - https://phabricator.wikimedia.org/T269499#9594537 (10Jdlrobson) @ssastry looks like this ticket got swept out of backlog in a grooming session. It needs prioritizing. [19:33:17] 10MediaWiki-extensions-InlineComments: Add user mentions to InlineComments - https://phabricator.wikimedia.org/T355942#9594540 (10Yaron_Koren) I see - please go to the main task (T356436) and pick one of the micro tasks that are remaining and no one is working on. I think there are two right now - I may add more. [19:35:46] 10MobileFrontend, 10DiscussionTools, 10Parsoid, 10Parsoid-Read-Views: Talk page discussion parsing is broken on mobile views with Parsoid read views enabled - https://phabricator.wikimedia.org/T358981#9594544 (10matmarex) This doesn't seem specific to DiscussionTools. I see several problems on mobile when... [19:37:53] (03PS1) 10Kosta Harlan: TempUserCreator: Use separate rate limit for temp account creations [core] - 10https://gerrit.wikimedia.org/r/1008111 (https://phabricator.wikimedia.org/T357777) [19:38:09] (03CR) 10Tacsipacsi: Replace deepmerge npm library with native Array.concat for merging arrays in Stats.readi18nFiles function. (032 comments) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008096 (owner: 10Punith.nyk) [19:38:55] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594549 (10Rockingpenny4) Okay then, are there any more changes to be made? If not, I will look into the InlineComments codebase and resolve some of the bigger issues. [19:41:16] 10MobileFrontend, 10DiscussionTools, 10Parsoid, 10Parsoid-Read-Views: Talk page discussion parsing is broken on mobile views with Parsoid read views enabled - https://phabricator.wikimedia.org/T358981#9594552 (10ssastry) Yes, this is all blocked on {T269499} -- I think focus should be on that task and this... [19:42:24] 10MobileFrontend, 10DiscussionTools, 10Parsoid, 10Parsoid-Read-Views: Talk page discussion parsing is broken on mobile views with Parsoid read views enabled - https://phabricator.wikimedia.org/T358981#9594556 (10ssastry) There is also {T310544} in case there is any work to be done that is specific to Disc... [19:42:52] (03PS3) 10Punith.nyk: Refactor: Replace underscore library with native array functions site-stats.js [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008088 [19:43:28] (03CR) 10Punith.nyk: Refactor: Replace underscore library with native array functions site-stats.js (034 comments) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008088 (owner: 10Punith.nyk) [19:43:33] (03PS3) 10Bartosz Dziewoński: HandleSectionLinks: Fix handling headings with raw `>` in attributes [core] - 10https://gerrit.wikimedia.org/r/1007962 (https://phabricator.wikimedia.org/T358810) [19:43:50] (03PS2) 10Kosta Harlan: TempUserCreator: Use separate rate limit for temp account creations [core] - 10https://gerrit.wikimedia.org/r/1008111 (https://phabricator.wikimedia.org/T357777) [19:44:14] (03PS3) 10Fomafix: Inject services in Hooks [skins/Vector] - 10https://gerrit.wikimedia.org/r/1008108 [19:44:45] 10Desktop Improvements (Vector 2022): Excessive space after p tags is causing new spacing issues - https://phabricator.wikimedia.org/T358921#9594559 (10Jack_who_built_the_house) >>! In T358921#9594301, @Jonesey95 wrote: > Additional vertical spacing problems, this time excessive padding around blockquote tags, h... [19:45:11] (03CR) 10Dreamy Jazz: Update GlobalBlockLookup for global account blocks (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/1005621 (https://phabricator.wikimedia.org/T358155) (owner: 10Dreamy Jazz) [19:47:07] 10Temporary accounts, 13Patch-For-Review, 10Sprint Piano (Feb 19th - 1st March): Implement more restrictive rate limit for temporary account creation - https://phabricator.wikimedia.org/T357777#9594565 (10kostajh) [19:47:09] 10Temporary accounts, 07Epic: Temporary accounts - MVP - https://phabricator.wikimedia.org/T324492#9594566 (10kostajh) [19:47:11] 10Temporary accounts: Decide what the rate limit should be for temporary account creations - https://phabricator.wikimedia.org/T342880#9594563 (10kostajh) 05Open→03Stalled Marking as stalled on {T357771} [19:47:37] 10Temporary accounts, 07Epic: [Epic] Mitigate abilities to abuse temporary account creation - https://phabricator.wikimedia.org/T357776#9594569 (10kostajh) a:03kostajh [19:48:31] 10Temporary accounts: Require logged-out users to complete a CAPTCHA on temporary account creations in certain circumstances - https://phabricator.wikimedia.org/T357778#9594570 (10kostajh) [19:54:02] (03PS2) 10Punith.nyk: Replace deepmerge npm library with native Array.concat for merging arrays in Stats.readi18nFiles function. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008096 [19:56:17] (03CR) 10Punith.nyk: Replace deepmerge npm library with native Array.concat for merging arrays in Stats.readi18nFiles function. (032 comments) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008096 (owner: 10Punith.nyk) [19:59:32] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594573 (10Yaron_Koren) Are spaces handled correctly? That was the big reason to use an attribute and not a class. Also, does the HTML in general look correct? [19:59:50] (03CR) 10Tacsipacsi: Replace 'preq' with 'fetch' in the code base (031 comment) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008109 (owner: 10Punith.nyk) [20:03:02] (03PS6) 10Punith.nyk: Refactor: Replace 'del' npm library with native Node.js file system functions in copyTranslationFiles function [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008097 [20:06:03] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594574 (10Rockingpenny4) I have attached screenshots above when spaces are included, it replaces spaces with underscore in class names and the website and the source HTML renders fin... [20:09:25] (03PS2) 10Punith.nyk: Replace 'preq' with 'fetch' in the code base [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008109 [20:09:37] (03CR) 10Punith.nyk: Replace 'preq' with 'fetch' in the code base (031 comment) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008109 (owner: 10Punith.nyk) [20:11:43] (03CR) 10Punith.nyk: "Hey, these are the micro-tasks that are mentioned in the: https://phabricator.wikimedia.org/T358885.I wish to participate in the upcoming " [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008097 (owner: 10Punith.nyk) [20:16:52] (03CR) 10Bartosz Dziewoński: [C: 03+2] "I'm surprised that wgScriptPath can be a full URL, I've definitely written code before assuming that it's just a path." [core] - 10https://gerrit.wikimedia.org/r/1008051 (owner: 10Krinkle) [20:16:58] (03CR) 10Bartosz Dziewoński: [C: 04-1] mediawiki.base: Simplify RLQ test without network request (031 comment) [core] - 10https://gerrit.wikimedia.org/r/1008050 (owner: 10Krinkle) [20:38:05] (03CR) 10Tacsipacsi: "Thanks for fixing some of the whitespace issues! There are still a few left, though; I’ve added inline comments about them." [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008088 (owner: 10Punith.nyk) [20:51:23] (03CR) 10Tacsipacsi: Replace 'preq' with 'fetch' in the code base (031 comment) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008109 (owner: 10Punith.nyk) [20:51:34] (03CR) 10Tacsipacsi: Replace deepmerge npm library with native Array.concat for merging arrays in Stats.readi18nFiles function. (032 comments) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008096 (owner: 10Punith.nyk) [20:55:19] (03CR) 10Tacsipacsi: Replace deepmerge npm library with native Array.concat for merging arrays in Stats.readi18nFiles function. (031 comment) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008096 (owner: 10Punith.nyk) [20:56:53] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594580 (10Yaron_Koren) Oh, great. Yes, a source of the HTML would be good - especially for a row that contains items. [21:07:07] (03CR) 10Tacsipacsi: "Then please add the task number in the `Bug:` footer – that’s also a kind of explanation. The task description didn’t really convince me e" [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/1008097 (owner: 10Punith.nyk) [21:11:47] 10Wikimedia-Site-requests: Change Wikimania wiki logo - https://phabricator.wikimedia.org/T358379#9594584 (10Msz2001) [21:20:40] 10MediaWiki-Core-Preferences, 07Technical-Debt, 15User-Daimona: Clean up handling of timezones in preferences code and friends - https://phabricator.wikimedia.org/T322352#9594587 (10Daimona) [21:20:45] 10Wikimedia-Site-requests: Change Wikimania wiki logo - https://phabricator.wikimedia.org/T358379#9594588 (10Janbery) [21:32:49] 06Campaign-Tools, 10CampaignEvents, 05Campaign-Registration: Improve formatting of offset timezones in the interface - https://phabricator.wikimedia.org/T325300#9594589 (10Daimona) Also worth looking into `MWTimestamp::getTimezoneMessage`, or `DateTime::format( 'T' )` directly. It can convert geographical ti... [21:56:27] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594592 (10Rockingpenny4) I changed the approach a bit as in the earlier approach, rawElement self opened and closed the p tag and another p tag was manually appended resulting in two... [22:15:16] 06Wikipedia-Android-App-Backlog: Rollback and possibly other autogenerated summaries potentially missing from mobile apps - https://phabricator.wikimedia.org/T359006 (10stjn) [22:15:37] 06Wikipedia-Android-App-Backlog: Rollback and other autogenerated summaries potentially missing from mobile apps - https://phabricator.wikimedia.org/T359006#9594605 (10stjn) [22:24:23] (03PS2) 10Saint Johann: Fix notification z-index in Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008017 (https://phabricator.wikimedia.org/T356513) [22:25:26] (03CR) 10Saint Johann: "Since you ported the wikibugs gadget to mobile, I think this should be on your priority list since currently mobile users do not see any e" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/1008017 (https://phabricator.wikimedia.org/T356513) (owner: 10Saint Johann) [22:36:16] (03PS3) 10Bartosz Dziewoński: TempUserConfig: Deduplicate code generating match conditions [core] - 10https://gerrit.wikimedia.org/r/1007985 [22:36:21] (03CR) 10Bartosz Dziewoński: TempUserConfig: Deduplicate code generating match conditions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/1007985 (owner: 10Bartosz Dziewoński) [22:36:39] (03PS5) 10Bartosz Dziewoński: Annotate SQL expression builder methods with @phan-side-effect-free [core] - 10https://gerrit.wikimedia.org/r/968264 [22:39:23] (03PS2) 10Bartosz Dziewoński: ChangesListSpecialPage: Refactor user experience conditions [core] - 10https://gerrit.wikimedia.org/r/1007995 (https://phabricator.wikimedia.org/T358932) [22:46:00] (03CR) 10Tim Starling: [C: 04-1] "> generateCacheRule() has no backwards compatibility requirements. We can change its parameters." [wikipeg] - 10https://gerrit.wikimedia.org/r/997981 (owner: 10Arlolra) [22:56:16] 10ContentTranslation: Deny overwriting of articles with ContentTranslate - https://phabricator.wikimedia.org/T359007 (10Snaevar) [23:06:48] (03PS1) 10MarkAHershberger: Conditionally add the toc based on a parser function. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/1008113 [23:09:09] (03CR) 10CI reject: [V: 04-1] Conditionally add the toc based on a parser function. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/1008113 (owner: 10MarkAHershberger) [23:21:41] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594627 (10Yaron_Koren) That sounds good - please update the patch! [23:37:53] 03Google Season of Docs 2024: Complete migration of MediaWiki documentation - Project Statement of Interest - https://phabricator.wikimedia.org/T359008 (10Ibom99) [23:44:57] (03CR) 10Tim Starling: [C: 04-1] "Looks good except for inline comments." [core] - 10https://gerrit.wikimedia.org/r/976936 (https://phabricator.wikimedia.org/T354216) (owner: 10Daniel Kinzler) [23:59:05] 10MediaWiki-extensions-AdminLinks, 13Patch-For-Review: Add class to row's paragraph - https://phabricator.wikimedia.org/T327263#9594664 (10Rockingpenny4) @Yaron_Koren https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AdminLinks/+/1007973