[15:07:51] I trust: RhinosF1!.*@miraheze/RhinosF1 (2admin), [15:07:51] @trusted [15:07:59] aha, nice! [15:08:08] thanks RhinosF1 ! [15:08:21] @trust ejegg!.*@wikimedia/ejegg admin [15:08:55] so @ logon and @ logoff (sans spaces) are the commands ? [15:09:04] Yeah [15:09:33] Successfully added ejegg!.*@wikimedia/ejegg [15:09:33] @trustadd ejegg!.*@wikimedia/ejegg admin [15:09:41] Should be set for you know [15:09:43] Now [15:09:51] @logoff [15:10:03] yep, that worked. Thanks! [15:10:18] Probably should set the link to https://wm-bot.wmcloud.org/browser/index.php?start=06%2F15%2F2021&end=06%2F15%2F2021&display=%23wikimedia-fundraising [15:10:42] So if I want to add additional trusted users, the !.*@ syntax is followed by the cloak [15:10:51] Yeah [15:10:55] got it [15:11:13] ah yeah, or even use a URL shortener [15:12:18] I can probably get someone to copy it over ejegg [15:13:33] oh, i should probably get ops in this channel :P [15:14:07] (03CR) 10Ejegg: [C: 03+2] "They look so cozy in their new home - and maybe someday little JS will move out and get a file of his own." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699833 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [15:14:28] (03Merged) 10jenkins-bot: Move relevant functions to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699832 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [15:15:13] thanks again RhinosF1 [15:15:26] ejegg: you'll have to ask GCs for copying ChanServ stuff but I'll get wm-bot synced [15:16:09] https://etherpad.wikimedia.org/p/Libera-channel-queue is for getting channel permissions [15:18:18] nice [15:18:49] i think there's an op on my team that can elevate me directly [15:24:22] (03PS4) 10Ejegg: Make select and inputs same height on Firefox [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/616122 (https://phabricator.wikimedia.org/T187451) (owner: 10Pcoombe) [15:24:30] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/616122 (https://phabricator.wikimedia.org/T187451) (owner: 10Pcoombe) [15:26:51] (03CR) 10Ejegg: [C: 03+2] "This is a good first step. I'll add the stuff we need for 3DS in a later commit." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/698625 (https://phabricator.wikimedia.org/T282595) (owner: 10Cstone) [15:28:12] (03Merged) 10jenkins-bot: Create getPaymentDetails call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/698625 (https://phabricator.wikimedia.org/T282595) (owner: 10Cstone) [15:32:14] (03PS3) 10Ejegg: Move cache helper functions to core [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/699279 (https://phabricator.wikimedia.org/T283627) [15:32:16] (03PS4) 10Ejegg: Cache Adyen payment method lookup [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/699307 (https://phabricator.wikimedia.org/T283627) [15:34:36] (03Merged) 10jenkins-bot: Move existing contribution form js over [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699833 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [15:47:47] (03CR) 10Ejegg: "Maybe we shouldn't log at error level when we just reject for fraud filtering?" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/696630 (https://phabricator.wikimedia.org/T281528) (owner: 10Jgleeson) [15:49:27] (03Merged) 10jenkins-bot: Make select and inputs same height on Firefox [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/616122 (https://phabricator.wikimedia.org/T187451) (owner: 10Pcoombe) [16:22:43] fr-tech do these SmashPig paymentMethod caching patches look good? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/699279 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/699307 [16:23:11] heyyy ejegg :) [16:23:20] hi AndyRussG [16:24:23] 10fundraising-tech-ops: certbot failing to connect/renew on frdev1001 and possibly others - https://phabricator.wikimedia.org/T284924 (10Jgreen) 05Resolved→03Open Certbot is still failing to run /etc/letsencrypt/renewal-hooks scripts when it attempts renewal on frmx* which are using standalone mode. Permissi... [16:24:25] 10fundraising-tech-ops: deploy Let's Encrypt certificates for additional fundraising services - https://phabricator.wikimedia.org/T280034 (10Jgreen) [16:24:29] I had started looking at them but some urgent craziness came up this weekend... I can dig in later today, though also fine if others want to, also, of course :) [16:24:35] ejegg: ^ [16:28:56] k [16:36:25] ejegg: wondering if the cachehelper would be better placed in the Helpers dir [16:37:13] could be [16:37:48] let's see, where's the queue helper? [16:38:21] I guess we call it QueueWrapper and we put it in DataStores [16:38:38] is that a utility class with only static methods? [16:38:43] i forget [16:39:03] yep, QueueWrapper::push( string $queueName, $message ) [16:39:25] ah I hadn't thought of that one as a helper [16:39:55] I guess since we already had the Cache namespace for HashCache and HashCacheItem it felt natural to reuse for a Cache-specific helper class [16:40:08] and the 'Helpers' folder feels a bit unspecific [16:46:15] maybe [16:50:17] I've seen the generic helpers dir over the years in MVC framework project structures so likely inspired from that. They typically handle hiding the details of setting up and interacting with the Types. [16:50:57] Symfony has a Utils folder I think [16:51:28] Well, I'm open to changing it - anyone else on fr-tech have an opinion on whether the CacheHelper should go in the Cache or the Helpers namespace? [16:53:02] it might be an outdated approach now though! [16:54:39] It does seem odd to have a Helpers dir and then a file with a Helper name in another place I feel [16:55:02] I could rename it to CacheWrapper :) [16:55:07] but then we don't have an obvious place to put the CurrencyRoundingHelper if we deleted the Helpers dir? [16:55:11] ha [16:55:30] Wrapper means something else to me [16:56:17] https://en.wikipedia.org/wiki/Adapter_pattern [16:56:19] PaymentData\ReferenceData has some Currency-related classes, but those are more just lookup tables [16:57:20] https://en.wikipedia.org/wiki/Helper_class [17:32:18] that article doesn't say which namespace to put them in :) [17:37:35] ah no, I shared those to help add context around why I see the wrapper name differently to helper [17:40:06] ok lemme review them a bit more [18:43:37] (03CR) 10Jgleeson: [C: 03+1] "Works well for me and code looks good. Just a question on usage of a file named CacheHelper outside the Helpers NS and a minor point on ma" (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/699279 (https://phabricator.wikimedia.org/T283627) (owner: 10Ejegg) [19:22:27] jgleeson for your error logging patch maybe let's add a TODO comment for now to lower the logging level to info or warning when it's a normal card decline or a fraud filter rejection, so as not to spam up the error logs? [19:22:54] We'll need more error code normalization at the SmashPig level to tell those apart better [19:23:09] ejegg: I agree it should be lowered [19:23:20] I think I changed it to error because I wasn't see it at first in the logs [19:23:22] and forgot [19:23:26] @_@ [19:23:29] so good spot [19:29:01] lemme update that real quick [19:29:42] I'm reviewing your other patch but moving at a Snail's pace [19:43:12] guh, how is the xsane scanner UI still so unusable? [19:43:19] (03PS4) 10Jgleeson: Adyen Checkout: add error logging on failure flow [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/696630 (https://phabricator.wikimedia.org/T281528) [19:43:25] preview window hasn't worked for me for years [19:50:05] ejegg: could be your scanner's not old enough [19:50:34] it's got a mini-usb plug [19:50:45] (not micro, nor the square usb-b) [19:51:11] i guess that should date it within a few yrs [19:56:56] +1 parallel port [19:58:37] 10fundraising-tech-ops: certbot failing to connect/renew on frdev1001 and possibly others - https://phabricator.wikimedia.org/T284924 (10Jgreen) 05Open→03Resolved After a whole lot of code spelunking and documentation searching I gave up on renewal-hooks, concluding that they do not appear to meet our needs.... [19:58:39] 10fundraising-tech-ops: deploy Let's Encrypt certificates for additional fundraising services - https://phabricator.wikimedia.org/T280034 (10Jgreen) [20:07:32] Watching the France vs Germany game isn't helping my review efforts [20:11:31] is it that time of year again? [20:11:51] yep! the Euros are here [20:52:30] (03CR) 10Jgleeson: [C: 03+2] "This works well for me. Tested with the new api method call from DI => Smashpig. Nice!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/699307 (https://phabricator.wikimedia.org/T283627) (owner: 10Ejegg) [21:12:32] (03CR) 10Eileen: "ejegg ironically this is all leading up to me adding some more js .... in a file of it's own" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699833 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [21:13:49] 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, 10Fundraising Sprint Interstitial ads halfway down the coaster hill, and 5 others: Creating New Fidelity File Civi Import - https://phabricator.wikimedia.org/T275445 (10Ei... [21:13:58] 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, 10Fundraising Sprint Interstitial ads halfway down the coaster hill, and 5 others: Creating New Fidelity File Civi Import - https://phabricator.wikimedia.org/T275445 (10Ei... [21:16:27] (03Abandoned) 10Eileen: Remove enforcement of source, assume USD [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699087 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [21:58:25] (03PS2) 10Jgleeson: WIP Adyen Checkout: Applepay [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699402 (https://phabricator.wikimedia.org/T282596) [22:00:56] (03CR) 10jerkins-bot: [V: 04-1] WIP Adyen Checkout: Applepay [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699402 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [22:21:54] (03CR) 10Ejegg: [C: 03+2] "Clean move" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699834 (owner: 10Eileen) [22:24:52] (03CR) 10Ejegg: [C: 03+2] "Clean move!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699835 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [22:26:36] (03CR) 10Ejegg: [C: 03+2] "Looks good" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699836 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [22:32:09] (03PS1) 10Eileen: Extract code & reverse condition [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699974 (https://phabricator.wikimedia.org/T284196) [22:32:11] (03PS1) 10Eileen: Add js to populate source rather than making people do it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699975 (https://phabricator.wikimedia.org/T284196) [22:32:19] (03Merged) 10jenkins-bot: Extract method to interact with contribution form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699834 (owner: 10Eileen) [22:34:59] (03Merged) 10jenkins-bot: Consolidate more relevant functionality onto the class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699835 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [22:36:03] (03Merged) 10jenkins-bot: Further function renaming on class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699836 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [22:36:09] (03PS1) 10Eileen: Remove source validation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699976 (https://phabricator.wikimedia.org/T284196) [22:37:20] (03PS2) 10Ejegg: A couple more monolog fixes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/697454 (owner: 10Eileen) [22:37:35] ejegg: thanks for all the review! [22:38:06] (03CR) 10Ejegg: [C: 03+2] "Phew, replacing the logging system is a big responsibility and needs a LOT of edge case consideration, huh?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/697454 (owner: 10Eileen) [22:38:33] yw eileen! Thanks for all the fixes and dedrupalization [22:39:18] ejegg: yeah - I'm steeling myself to try again on the wmf exception one - I couldn't get through all the namespace issues last time - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/699078 [22:39:35] I might try moving all the exceptions that are [22:39:46] omg the logging I completely spaced at looking at that again thanks for looking at it ejegg [22:39:49] 'sharing' files with other classes into their own files first [22:40:25] oh jeez, yeah, that would be an unequivocal good thing [22:41:07] hmm, ok, thinking about this stdout not bubbling up [22:41:14] ok - I might do that & see if it makes the next lift easier because I didn't make my way out of the maze [22:41:23] I guess as long as we always run stuff via p-c we're fine [22:41:30] so it's config not code that stops it bubbling up [22:41:50] I think it's also ok to not bubble up if you are just manually running? [22:42:30] We kinda want SOME log of anything that happens in the system [22:42:47] but I guess the logging tables qualify [22:43:11] yeah if anything is changed they would catch it [22:46:33] (03PS3) 10Jgleeson: WIP Adyen Checkout: Applepay [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699402 (https://phabricator.wikimedia.org/T282596) [22:48:06] (03Merged) 10jenkins-bot: A couple more monolog fixes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/697454 (owner: 10Eileen) [22:48:49] (03CR) 10jerkins-bot: [V: 04-1] WIP Adyen Checkout: Applepay [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699402 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [22:51:47] ok, looks like that patch has pretty good safeguards against losing important logs [22:54:17] cool [22:54:30] ejegg: on the source - ie USD -5.00 [22:54:40] I made it so it gets populated by JS [22:54:57] but I'm torn between ripping out hte validation [22:55:03] or just fixing the regex [22:55:26] I guess it's a good precaution to keep it - it's just ugle [23:04:27] (03PS1) 10Eileen: Alternate - fix regex [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699977 (https://phabricator.wikimedia.org/T284196) [23:05:14] well both options are up for review [23:56:48] (03PS1) 10Eileen: Move exceptions ointo Civi\WMFException namespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699978 (https://phabricator.wikimedia.org/T283104)