[00:06:38] (03CR) 10jerkins-bot: [V: 04-1] Move exceptions ointo Civi\WMFException namespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699978 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [00:19:49] (03CR) 10Ejegg: WIP Adyen Checkout: Applepay (033 comments) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699402 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [00:31:11] (03PS1) 10Eileen: Move exceptions ointo Civi\WMFException namespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699979 (https://phabricator.wikimedia.org/T283104) [00:31:26] (03Abandoned) 10Eileen: Move exceptions ointo Civi\WMFException namespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699978 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [00:32:09] (03PS1) 10Eileen: Move exceptions onto Civi\WMFException namespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699980 (https://phabricator.wikimedia.org/T283104) [00:32:17] (03Abandoned) 10Eileen: Move exceptions ointo Civi\WMFException namespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699979 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [00:33:21] (03PS2) 10Eileen: Move exceptions onto Civi\WMFException namespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699980 (https://phabricator.wikimedia.org/T283104) [00:47:55] ejegg: I think I'm gonna do a series of them like https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/699980/2 to get the exceptions moved - can you check the approach before I do the rest [00:48:19] ok eileen, just one sec [02:19:34] (03PS1) 10Eileen: Update contactlayout editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699984 (https://phabricator.wikimedia.org/T283559) [02:28:52] (03PS2) 10Eileen: Update contactlayout editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699984 (https://phabricator.wikimedia.org/T283559) [02:34:44] (03PS3) 10Eileen: Update contactlayout editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699984 (https://phabricator.wikimedia.org/T283559) [02:43:52] (03PS1) 10Eileen: Update deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699985 (https://phabricator.wikimedia.org/T283559) [03:27:40] oh nice, new civi has little lab icons for beta extensions [03:31:05] :-) [03:31:07] cute huh [03:32:58] ok, just got civi back into shape to be able to test that monolog cli one [03:33:23] cool - can you just confirm that exception approach before I do more? [03:33:53] eileen: the only thought I had with the wmfExtension patch is that the subclasses might want a brief comment each now that they're removed from their filesystem context [03:34:22] err, that is the wmfexception patch [03:34:46] as in their original module - yeah - I could add that - Im not too sure where the original modules will wind up though [03:35:38] ie I'm kinda assuming what things we group together will change in extensionisation process [03:36:16] ccccccjelcgbecjinhruuijlbuttilugcltellrifktr [03:38:47] yah, and I guess we all have IDEs that can search for usage easily [03:50:54] (03PS2) 10Ejegg: Add monolog std out cli logger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/697456 (https://phabricator.wikimedia.org/T282628) (owner: 10Eileen) [03:51:32] (03CR) 10Ejegg: [C: 03+2] "This works nicely, and there seem to be good safeguards against losing messages in non-CLI mode." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/697456 (https://phabricator.wikimedia.org/T282628) (owner: 10Eileen) [04:01:30] (03Merged) 10jenkins-bot: Add monolog std out cli logger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/697456 (https://phabricator.wikimedia.org/T282628) (owner: 10Eileen) [04:01:46] ejegg: so I could go a level deeper with some of those ie Civi/WMFException/Import/ [04:02:03] or maybe it's better just to figure it can change again later if we think we should [04:02:20] yep, that's actually what I was about to suggest, but wanted to check how many there would be [04:02:30] i.e. no need to do it for just a few subclasses [04:02:57] so.. all those constants should basically be subclasses [04:03:49] maybe it will make sense to have those namespaces when we break up the WmfExtension class like that? [04:03:59] as in - we wouldn't actually need the constants in the end - ? they;d be implicit in the subclsses? [04:04:10] yep yep eileen [04:05:00] if we look at the 3 I did - 2 are import & the other is a random [04:05:08] yeah [04:05:49] in the end I don't know if we will wind up with a lot of stuff in wmf_civicrm or lots of wmf extensions [04:06:46] so looking at that whole list of constants there are a few file-import ones, a few general contrib import ones, a couple db ones, and a bunch more randos [04:07:08] DATA_INCONSISTENT vs INVALID_MESSAGE [04:07:13] hmm [04:07:18] so where is your gut at - a flat folder or sub folders? [04:07:38] I guess it's easy enough to start with a flat folder and rename / reorganize later on [04:07:44] (if we later break into more extensions we would move the exceptions to the extension) [04:08:10] ok - I'll go with that - I'll just do more of the same like the existing one [04:08:24] k, I'll go ahead and +2 it [04:08:30] cool [04:11:58] (03CR) 10Ejegg: [C: 03+2] "This gets the ball rolling! As discussed in IRC, these exception classes look like they might need a bit of context but we can do an organ" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699980 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [04:12:11] shoot, it got late here! [04:12:17] ok, see you tomorrow [04:21:47] (03Merged) 10jenkins-bot: Move exceptions onto Civi\WMFException namespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699980 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [04:21:49] (03CR) 10Ejegg: Move cache helper functions to core (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/699279 (https://phabricator.wikimedia.org/T283627) (owner: 10Ejegg) [04:23:08] oh weird, where are those txns missing gateway_txn_id coming from? [04:23:31] (03PS1) 10Eileen: Extract 2 more exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699986 (https://phabricator.wikimedia.org/T283104) [04:23:41] looks like 1-2 per day since the 10th [04:24:01] all with source_type 'direct' [04:24:20] oh, they have contact_id [04:24:44] might not need to keep you from logging off it's 1-2 per day [04:24:58] ehh, yah, and very small amts of $$$ [04:25:05] k, gnight for real [04:33:02] (03CR) 10jerkins-bot: [V: 04-1] Extract 2 more exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699986 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [04:57:40] (03PS2) 10Eileen: Extract 2 more exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699986 (https://phabricator.wikimedia.org/T283104) [05:07:11] (03CR) 10jerkins-bot: [V: 04-1] Extract 2 more exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699986 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [05:50:01] (03PS3) 10Eileen: Extract 2 more exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699986 (https://phabricator.wikimedia.org/T283104) [05:53:54] (03PS1) 10Eileen: Last of the double-bunked exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699988 (https://phabricator.wikimedia.org/T283104) [06:03:57] (03CR) 10jerkins-bot: [V: 04-1] Last of the double-bunked exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699988 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [06:11:37] (03PS2) 10Eileen: Last of the double-bunked exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699988 (https://phabricator.wikimedia.org/T283104) [06:13:07] (03PS1) 10Eileen: Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) [06:22:43] (03CR) 10jerkins-bot: [V: 04-1] Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [07:18:30] (03PS2) 10Eileen: Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) [07:22:01] (03CR) 10jerkins-bot: [V: 04-1] Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [07:23:50] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [07:43:36] (03PS3) 10Eileen: Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) [07:49:30] (03PS4) 10Eileen: Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) [08:02:35] (03CR) 10jerkins-bot: [V: 04-1] Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [08:14:33] (03PS5) 10Eileen: Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) [08:24:40] (03CR) 10jerkins-bot: [V: 04-1] Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [10:17:51] 10Fundraising-Backlog, 10Wikimedia-Fundraising, 10FR-LATAM, 10MW-1.36-notes (1.36.0-wmf.33; 2021-03-02): Fundraising in Latin American Spanish - https://phabricator.wikimedia.org/T199680 (10Pcoombe) 05Open→03Resolved Think we can close this, as we successfully ran campaigns with Latin American Spanish!... [13:17:05] (03CR) 10Jgleeson: [C: 03+2] Move cache helper functions to core [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/699279 (https://phabricator.wikimedia.org/T283627) (owner: 10Ejegg) [13:17:53] (03Merged) 10jenkins-bot: Move cache helper functions to core [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/699279 (https://phabricator.wikimedia.org/T283627) (owner: 10Ejegg) [13:17:56] (03Merged) 10jenkins-bot: Cache Adyen payment method lookup [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/699307 (https://phabricator.wikimedia.org/T283627) (owner: 10Ejegg) [13:19:47] (03CR) 10Jgleeson: "ok ok ok let's proceed as is!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/699279 (https://phabricator.wikimedia.org/T283627) (owner: 10Ejegg) [14:53:42] thanks jgleeson [15:19:12] np [15:21:39] (03PS1) 10Ejegg: Adyen: Add more details to DetailsResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700080 (https://phabricator.wikimedia.org/T282730) [15:45:53] cstone ^^^ fleshes out the details response some more, and does some normalization [18:34:24] (03PS1) 10Ejegg: Adyen Checkout: tweak to error logging [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700094 [18:36:04] (03CR) 10Ejegg: [C: 03+2] "Thanks jgleeson! I made a lil followon patch to distinguish between the two failure reasons: Idbe1369b9963aa9b6f6f15b571fc1477c58bbb06" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/696630 (https://phabricator.wikimedia.org/T281528) (owner: 10Jgleeson) [18:38:21] (03Merged) 10jenkins-bot: Adyen Checkout: add error logging on failure flow [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/696630 (https://phabricator.wikimedia.org/T281528) (owner: 10Jgleeson) [19:05:00] (03PS12) 10Ejegg: Adyen Checkout: Swap out dropin for web components [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/693481 (https://phabricator.wikimedia.org/T284605) (owner: 10Jgleeson) [19:06:03] (03CR) 10Ejegg: [C: 03+2] "This was easy enough to rebase the 3D Secure patch on top of - let's try it! Thanks for showing the way, jgleeson." [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/693481 (https://phabricator.wikimedia.org/T284605) (owner: 10Jgleeson) [19:06:15] (03PS5) 10Ejegg: Adyen Checkout: make adyen js method-agnostic [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699061 (https://phabricator.wikimedia.org/T284605) (owner: 10Jgleeson) [19:06:59] (03CR) 10Ejegg: [C: 03+2] "Nice JS cleanup. ESLint seems to have some beef with the JSDoc but we can fix that in a follow on patch." [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699061 (https://phabricator.wikimedia.org/T284605) (owner: 10Jgleeson) [19:16:45] thanks for the review ejegg! [19:22:48] (03Merged) 10jenkins-bot: Adyen Checkout: Swap out dropin for web components [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/693481 (https://phabricator.wikimedia.org/T284605) (owner: 10Jgleeson) [19:22:56] (03Merged) 10jenkins-bot: Adyen Checkout: make adyen js method-agnostic [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699061 (https://phabricator.wikimedia.org/T284605) (owner: 10Jgleeson) [19:26:37] (03PS1) 10Ejegg: Adyen Checkout: Fix up JSDoc [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700097 [19:31:24] (03PS2) 10Ejegg: Move 3D Secure staging logic to base class [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/698073 (https://phabricator.wikimedia.org/T282730) [19:31:26] (03PS6) 10Ejegg: Adyen Checkout: first step of 3D Secure (Redirect) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/695817 (https://phabricator.wikimedia.org/T282730) [19:32:43] fr-tech I just merged a couple of jgleeson's patches to DonationInterface. There are two small follow-up patches I'd like to merge before continuing. Can anyone review when they have a minute? [19:32:47] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/700097 [19:33:00] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/700094 [19:33:17] (03CR) 10jerkins-bot: [V: 04-1] Adyen Checkout: first step of 3D Secure (Redirect) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/695817 (https://phabricator.wikimedia.org/T282730) (owner: 10Ejegg) [19:34:02] nice to get those merged ejegg i can look [19:34:10] thanks cstone! [19:34:42] The iDEAL JS should be easy enough to rewrite as component, i hope? [19:34:59] yep yep [19:35:43] (03PS7) 10Ejegg: Adyen Checkout: first step of 3D Secure (Redirect) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/695817 (https://phabricator.wikimedia.org/T282730) [19:36:23] (03CR) 10Cstone: [C: 03+2] Adyen Checkout: Fix up JSDoc [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700097 (owner: 10Ejegg) [19:36:57] (03CR) 10Cstone: [C: 03+2] Adyen Checkout: tweak to error logging [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700094 (owner: 10Ejegg) [19:37:02] thanks! [19:38:25] (03Merged) 10jenkins-bot: Adyen Checkout: Fix up JSDoc [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700097 (owner: 10Ejegg) [19:39:29] (03Merged) 10jenkins-bot: Adyen Checkout: tweak to error logging [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700094 (owner: 10Ejegg) [19:49:32] (03PS3) 10Ejegg: Move 3D Secure staging logic to base class [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/698073 (https://phabricator.wikimedia.org/T282730) [19:49:34] (03PS8) 10Ejegg: Adyen Checkout: first step of 3D Secure (Redirect) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/695817 (https://phabricator.wikimedia.org/T282730) [19:51:54] cstone for the second step of 3d secure we're going to need this from SmashPig: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/700080 [19:52:10] oh yeah i saw that lemme give it a look again [19:52:40] it's a lot of copy-paste from createPaymentResult, which is meh [19:53:07] just not sure if there should be another layer of inheritance there, or if we should start using traits [19:53:36] anyway, there's a TODO: DRY and I think it's enough for this phase [20:18:09] hmm hmm, now writing the DonationInterface code to use it and there's a need for an interface (or inheritance) [20:18:45] cstone maybe let's hold off merging that extra bit in SmashPig till we play with it a bit more up on the DonationInterface side? [20:19:28] Okie ejegg [20:27:34] ahh, found an error too [20:27:38] too much copy paste [20:56:46] (03PS2) 10Ejegg: Adyen: Add more details to DetailsResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700080 (https://phabricator.wikimedia.org/T282730) [20:56:48] (03PS1) 10Ejegg: Guard against unset PSP Reference [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700100 (https://phabricator.wikimedia.org/T282730) [20:56:50] (03PS1) 10Ejegg: Adyen Checkout: Fix borked RiskScorer [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700101 (https://phabricator.wikimedia.org/T282641) [20:57:45] cstone there are two smaller SmashPig fixes that I think can be merged quickly: https://gerrit.wikimedia.org/r/700100 & https://gerrit.wikimedia.org/r/700101 [20:58:56] * ejegg is suddenly disappointed upon realizing the sri lanka leopard safari is 5 AM not 5 PM local time [21:00:25] oh hey, but there's a samurai town virtual walk [21:00:31] oh yeah that's now [21:08:50] ooh thanks for the reminder just got back from grocery store [21:09:03] Kamakura city [21:10:51] eileen and cstone you may want to mute in the zoom [21:11:07] oh you just did eileen [21:11:10] I thought I was [21:11:17] ahhh i thoguht i was too [21:11:42] this one tricked us by leaving mic on by default [21:11:46] Jack would have liked this - he got his shodan over the weekend [21:12:24] good thing I muted before I started washing dishes [21:14:07] (03PS6) 10Eileen: Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) [21:17:10] (03PS7) 10Eileen: Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) [21:24:55] (03PS8) 10Eileen: Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) [21:33:20] (03PS9) 10Ejegg: Adyen Checkout: first step of 3D Secure (Redirect) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/695817 (https://phabricator.wikimedia.org/T282730) [21:33:22] (03PS1) 10Ejegg: Adyen Checkout: Fix SessionVelocity warning [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700103 [21:33:24] (03PS1) 10Ejegg: Adyen Checkout: guard against unset avs/cvv score [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700104 [21:33:26] (03PS1) 10Ejegg: Adyen Checkout: handle return from redirect [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700105 (https://phabricator.wikimedia.org/T282730) [21:34:49] should i mention the first time I did that and did drink it cause my friend told me "take it into your mouth" [21:35:26] haha [21:35:33] (03CR) 10jerkins-bot: [V: 04-1] Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [21:45:42] (03PS4) 10Ejegg: Move 3D Secure staging logic to base class [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/698073 (https://phabricator.wikimedia.org/T282730) [21:45:51] (03PS9) 10Eileen: Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) [21:46:15] (03CR) 10Ejegg: "Thanks for the suggestion AndyRussG. Name changed in PS4!" (031 comment) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/698073 (https://phabricator.wikimedia.org/T282730) (owner: 10Ejegg) [21:48:57] oh heh, I guess the class should probably be declared abstract too [21:51:25] (03PS5) 10Ejegg: Move 3D Secure staging logic to base class [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/698073 (https://phabricator.wikimedia.org/T282730) [21:55:15] (03PS2) 10Ejegg: Adyen Checkout: Fix SessionVelocity warning [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700103 [21:55:17] (03PS2) 10Ejegg: Adyen Checkout: guard against unset avs/cvv score [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700104 [21:55:19] (03PS10) 10Ejegg: Adyen Checkout: first step of 3D Secure (Redirect) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/695817 (https://phabricator.wikimedia.org/T282730) [21:55:21] (03PS2) 10Ejegg: Adyen Checkout: handle return from redirect [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700105 (https://phabricator.wikimedia.org/T282730) [22:32:07] ejegg: I finally got that wmf-exception patch to pass! [22:32:23] woohoo! [22:36:53] ejegg: the problem is it will be a nightmare to review - [22:38:25] i'm on baby duty in a few minutes, but i'll try to get to it tomorrow! [23:02:54] (03PS1) 10Eileen: Update triggers sql [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700112 (https://phabricator.wikimedia.org/T283561) [23:05:18] cstone: any chance you can check ^^ - it should be not too tricky but a bit glaze-overy [23:40:11] Eileen I can just got back from seaweed duty [23:40:18] Lake is being helpful tonight at least [23:40:19] lol [23:40:43] yeah - hopefully that one is easy - I just wanted to get some 'noise' out so I can check the bits I care about [23:41:05] this is the triggers one that wasn't behaving before? [23:45:56] cstone: yeah so I'm still not totally there on the generation - it all seems to be there - but I want it in a consistent order too & this https://github.com/civicrm/civicrm-core/pull/20472 will get rid of some cruft as well [23:46:19] it's alpha sorted now - until it isn't [23:46:24] ahhh hah [23:46:32] (which is an improvement) [23:48:26] i see some changes in civicrm_note_after_delete is that one of the obvious tables [23:51:22] cstone: hmm - is there more change in there than the utf8 stuff? [23:51:52] civicrm_note_after_delete has some fields added [23:52:16] yeah - it does - that is legit some fields were added to it [23:52:22] okie cool [23:52:43] - my goal was to get the sql close enough that when we do an update things like that are all that is in the changes [23:52:56] yeah nice [23:55:04] monolog and civicrm_contact_name_pair_family are dropped but not recreated is that just cause there arent any? [23:59:55] no - it's because I didn't commit that bit in this one