[00:00:13] the triggers don't exist yet so it makes no difference [00:00:27] okie cool looks good then [00:01:11] (03CR) 10Cstone: [C: 03+2] Update triggers sql [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700112 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [00:01:26] yay - now I have to make sense of the rest of the diff :-) [00:01:36] good luck! [00:10:34] (03Merged) 10jenkins-bot: Update triggers sql [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700112 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [02:17:23] (03PS1) 10Eileen: Fix trigger alpha sorting to key sort [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/700114 (https://phabricator.wikimedia.org/T283561) [02:17:42] OK - I found the sorting issue - I added asort not ksort ^^ [02:19:20] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Lego Trampoline, 10Patch-For-Review: Fix trigger sql issues - https://phabricator.wikimedia.org/T283561 (10Eileenmcnaughton) I need this merged https://gerrit.wikimedia.org/r/c/wikimedia... [02:29:10] if anyone is about (not gonna ping you this late) I'd love to get that asort to ksort merged - it just sorts the output trigger sql & I didn't spot when I added asort that it was not sorting by keys because it superficially 'looked in order' [04:01:04] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Lego Trampoline: More durable fix for 5.39 breakage - https://phabricator.wikimedia.org/T285072 (10Eileenmcnaughton) [13:45:12] (03CR) 10Cstone: [C: 03+2] Fix trigger alpha sorting to key sort [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/700114 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [13:55:00] (03Merged) 10jenkins-bot: Fix trigger alpha sorting to key sort [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/700114 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [14:10:26] g'day [14:12:39] gonna be a hot one today. the winds have died down so no good sea breeze to cool it off. [15:03:31] (03CR) 10Jgleeson: [C: 03+2] Guard against unset PSP Reference [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700100 (https://phabricator.wikimedia.org/T282730) (owner: 10Ejegg) [15:04:20] (03Merged) 10jenkins-bot: Guard against unset PSP Reference [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700100 (https://phabricator.wikimedia.org/T282730) (owner: 10Ejegg) [15:45:48] (03PS4) 10Ejegg: Extract 2 more exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699986 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [15:45:55] (03CR) 10Ejegg: [C: 03+2] Extract 2 more exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699986 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [15:48:28] (03PS3) 10Ejegg: Last of the double-bunked exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699988 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [15:48:32] (03CR) 10Ejegg: [C: 03+2] Last of the double-bunked exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699988 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [15:57:04] (03Merged) 10jenkins-bot: Extract 2 more exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699986 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [15:58:22] (03Merged) 10jenkins-bot: Last of the double-bunked exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699988 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [16:15:39] (03CR) 10Ejegg: "truly Herculean task! I'm finding a whole bunch of missing 'use' statements. I can update this patch as I find them unless you wanna do it" (036 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [16:41:30] (03PS10) 10Ejegg: Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [16:43:06] (03CR) 10Ejegg: [C: 03+1] "In the interest of not letting this patch get stale, I've just made the fixes as I went along. If you agree with the PS9/PS10 diff, want t" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [16:45:56] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Quality-and-Test-Engineering-Team (QTE), 10Browser-Tests, and 3 others: The first Selenium test for CentralNotice - https://phabricator.wikimedia.org/T262684 (10zeljkofilipin) [17:30:02] 10Fundraising-Backlog, 10fundraising sprint Lego Trampoline, 10FR-AutoTY-Email, 10FR-Email: Formatting issue with Civi recurring expiry/fail email? - https://phabricator.wikimedia.org/T282582 (10Ejegg) Still investigating - looks like these are sent via a different process than we use for the automatic tha... [17:30:41] Can I make a request that future sprint names don't include the word "lego" in them? I keep getting pinged :p [17:31:04] oh dang, we didn't think of that! sorry legoktm [17:31:26] maybe we can replace one of the chars with a unicode-alike [17:32:45] that would be nice :) [17:32:48] oh my. that's a bummer. [17:33:05] yeah. updating the sprint name would be good as it will stay in tags for some time. [17:37:47] XenoRyet: can you edit the sprint name? https://phabricator.wikimedia.org/project/edit/5381/ gives me a 'No Edit Forms' error [17:38:18] maybe to Legø Trampoline ? [17:41:00] I should be able to, let me try. [17:44:11] Weird, I can edit almost anything else about the sprint, but I get the no edit forms thing too for renaming. [17:44:53] I'll see what I can do about getting access, but we might need to wait for dstrine to get back. [17:45:19] 10Fundraising-Backlog, 10fundraising sprint Lego Trampoline, 10FR-AutoTY-Email, 10FR-Email: Formatting issue with Civi recurring expiry/fail email? - https://phabricator.wikimedia.org/T282582 (10MBeat33) Thank you @Ejegg this is really great info. One other quirk we're seeing is a mismatch in the language... [17:45:24] or maybe reach out to aklapper directly? [17:45:40] I can fix it for y'all. what change do you want? [17:46:11] 10Fundraising-Backlog, 10fundraising sprint Lego Trampoline, 10FR-AutoTY-Email, 10FR-Email: Formatting issue with Civi recurring expiry/fail email? - https://phabricator.wikimedia.org/T282582 (10Ejegg) Huh, that is interesting. Can you post some contact IDs in this task? [17:47:02] 10Fundraising-Backlog, 10fundraising sprint Lego Trampoline, 10FR-AutoTY-Email, 10FR-Email: Formatting issue with Civi recurring expiry/fail email? - https://phabricator.wikimedia.org/T282582 (10MBeat33) Sure thing, they're cid=47502739 [17:47:16] bd808: can you change a sprint name ( proj 5381 ) to 'fundraising sprint Legø Trampoline' (note funky o) ? [17:47:31] We're trying to stop annoying legoktm :) [17:47:40] {{done}} [17:47:45] thanks! [17:47:55] <3 [17:54:09] Cool, I've also put in the request for the relevant permissions so I can do it next time too. [18:14:29] what happened to the sprint? [18:30:33] jgleeson: then name was setting off the alerts for l.egoktm. no need to distract them constantly for all time. :) [18:37:38] ahhh [18:37:39] :) [19:09:47] wow the fumes from gloss paint are pretty strong [21:36:31] (03PS11) 10Eileen: Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) [21:38:34] (03CR) 10Eileen: [C: 03+2] "yeah - it went stale once let's get it merged" (034 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [21:43:06] woohoo eileen [21:49:11] (03Merged) 10jenkins-bot: Move WMFException to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699989 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [21:52:54] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Quality-and-Test-Engineering-Team (QTE), 10Browser-Tests, and 2 others: Create Selenium test for verifying the Close button is visible at all times - https://phabricator.wikimedia.org/T285115 (10jbolorinos-ctr) [22:12:03] hi eileen ! I'm trying to investigate https://phabricator.wikimedia.org/T282582 but when I try to run the render on the command line I get a auth failed error [22:12:08] is there a way to bypass that? [22:12:18] My command line is drush cvapi FailureEmail.render version=4 contactID=47502739 contributionRecurID=735494 [22:12:26] oh, I probabaly need the user id [22:12:47] yep, that was it [22:12:51] sorry to bother! [22:13:01] Was I a good rubber duck? [22:13:17] and... yep, msg_subject is english while the text is french [22:20:59] so there IS a fr.subject.txt [22:21:08] I guess we pull those into the db though, right? [22:29:14] oh hmm, i don't have them locally [22:29:24] what's the script to pull them in from those txt files? [22:30:30] eileen: were you just calling api4 updatefromfile on each of those languages individually to get them populated in production? [22:31:15] ejegg: yep - pretty much - I think there is something in the wmf_civicrm.install [22:31:24] is this a regression or just something we hadn't spotted [22:31:46] eileen not sure [22:32:33] looks like there might be something fundementally screwy with the process of mime encode pieces then send via pear_mailer which core does for emails [22:33:03] since a number of ppl with various different mail clients have reported seeing the full unencoded mime text [22:33:25] i.e. the content-encoding header, the txt email, the separator, then the html email [22:33:38] all mashed together in their email reading window [22:33:59] but then this one donor also saw a mismatched subject + body text language [22:36:40] eileen: oh, so the only fr variant we have the msg_templates populated for in prod is fr_CA [22:36:55] shouldn't we have chosen fr_FR first? [22:37:21] hmm - I don't think we have within-language fallback [22:37:28] but - why don't we have fr_FR? [22:38:00] is it committed? - there is actually a UI action to review & make live it it's committed but not in the db [22:38:07] (can hangout now if you want) [22:39:02] i have to head out in a sec, unfortunately [22:39:11] yes, there is a translation committed [22:39:39] oh, i see the wmf_civicrm_insert_failure_message_translation only picks the first language matching, so that's why no fr_FR [22:39:53] i'm still stumped as to why it found the body text in french then [22:40:00] ok, shoot, gotta go. [22:42:20] ejegg|away: so there is an api of sorts to bring from disk - but I would just api update the subject if it's just that one missing - [22:46:16] hmm - ejegg|away api action = Message::updatefromfile [22:57:30] ejegg|away: the issue was the field name in the civicrm_strings table was 'subject' not msg_subject - I've fixed that now. A bigger issue is most of the translations are not in the db - which is a communication breakdown as I thought mbeattie was going to move them to the db via the qa button - but that seems to have been a communication breakdown [23:00:40] ^ eileen I think that request may have been made to someone else? I can ping Camille as she might be in the loop [23:00:53] mbeattie: hmm so the thing is [23:01:08] when we added the translations I showed you how to make them live [23:01:21] but I don't think you ever took on that I was thinking you would [23:01:29] but we can just do them & assume they are right [23:04:18] but that qa functionality I'm having trouble hitting now [23:07:18] gosh, I must have lost that request in a stack, sorry. I will add this to the next Wednesday checkin [23:08:14] mbeattie: yeah obviously a misfire on the communication - I'm gonna have to check if the functionality broke though in the meantime [23:13:38] thank you