[03:01:38] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10Eileenmcnaughton) @MDemosWMF I took a look at the files & the code. I started with the sample csv... [03:30:30] (03PS1) 10Eileen: Name parse fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700721 (https://phabricator.wikimedia.org/T285269) [03:59:21] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: CiviCRM - monthly update to 5.39rc - https://phabricator.wikimedia.org/T283559 (10Eileenmcnaughton) 05Open→03Resolved [04:11:05] I just disabled the japanese name flip because it was spinning it's wheels - will put details on the ticket [04:11:05] !log process-control config revision is 4ab72c1033 [04:11:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:22:44] 10Fundraising-Backlog, 10fundraising-tech-ops: User needs Terminal access to Fredge - https://phabricator.wikimedia.org/T283871 (10RKumar_WMF) Hi, Yes, I have received it. Please let me know the next steps. Thank you Rakhi [04:26:55] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Just in time roller coaster building, and 4 others: Japanese donor name clean up pass - https://phabricator.wikimedia.org/T281493 (10Eileenmcnaughton) I just paused the name flip job. I wen... [04:39:38] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Just in time roller coaster building, and 4 others: Japanese donor name clean up pass - https://phabricator.wikimedia.org/T281493 (10Eileenmcnaughton) I think [I've figured out a url](https... [05:22:47] (03PS1) 10Eileen: Fix Japanese name flip to skip Harrison Tylers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700747 [06:17:41] (03Abandoned) 10Eileen: Move WMFException to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699078 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [12:06:05] 10fundraising-tech-ops: Fundraising access request for JESSICA JAMES-HILL - https://phabricator.wikimedia.org/T284712 (10RLewis) @Dwisehaupt hi Dallas, just bumping this as Jessica is due to take part in Civi training today and it would be useful for her to have access to Civi for this training. Let me know if i... [13:51:12] 10Fundraising-Backlog, 10fr-donorservices: Australian country score/fraud setting - https://phabricator.wikimedia.org/T283187 (10MBeat33) Rakhi asked about a fraud edge case today and we found the getScoreCountryMap filter is also applying -25 to New Zealand transactions. Ingenico 102228076.1 is an example. [14:41:55] (03PS2) 10Ejegg: Add engage permission [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699838 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [14:42:13] (03CR) 10Ejegg: [C: 03+2] "This looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699838 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [14:45:18] fr-tech is anyone available to CR some of these patches? https://gerrit.wikimedia.org/r/q/owner:ejegg%2540ejegg.com+is:open+-age:8d [14:45:33] thanks for the CR on the risk scorer AndyRussG ! [14:52:01] (03PS2) 10Ejegg: Commit some more of the 'noise' trigger changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700714 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [14:52:40] (03CR) 10Ejegg: [C: 03+2] "Looks good. I notice one non-noise change (another contact ID exempted from the rollups) but it seems fine." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700714 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [14:53:37] ejegg: yeee [14:53:40] I'll try and take a peek later today ejegg. I've got a contracter here today doing some work upstairs so a little bit distracted working downstairs. Currently scratching my head trying to work out why the AWS load balancer ssl termination isn't working. [14:54:34] ejegg: there was some discussion yesterday about whether you wanted us to hold off on review on some of those on the chain, but I guess that's not the case now? [14:55:00] hmm, I can probably get a certbot cert on a subdomain of ejegg.com without too much trouble [14:55:10] (03Merged) 10jenkins-bot: Add engage permission [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699838 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [14:55:34] AndyRussG: I think those are all ready, but I can take another peek. Did some of them in particular look doubtful? [14:56:40] ejegg: I was just remembering you saying to hold off on review on I think the smashpig one last week but maybe you had since fixed it [15:05:50] (03Merged) 10jenkins-bot: Commit some more of the 'noise' trigger changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700714 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [15:09:01] 10Fundraising-Backlog: Access to delete contributions from civi - Engage - https://phabricator.wikimedia.org/T285319 (10MDemosWMF) [15:09:16] cstone the smashpig one it working for the purpose at hand [15:09:27] ahhh right [15:09:36] ejegg: the cert on the frontend isn't too much trouble but I think it's the forwarding to a http endpoint unencrypted which is tricky [15:09:57] jgleeson do you have nginx doing the ssl termination? [15:10:10] you should be able to point its upstream to an http endpoint [15:10:35] so to use aamazons free ssl you have to use their stack. you don't get the actual cert files [15:10:39] cstone ok, now I remember - it was the PaymentDetailResponse maybe needing to implement another interface [15:11:05] 10Fundraising-Backlog: Modification to Fredge Report - https://phabricator.wikimedia.org/T285321 (10EMartin) [15:11:08] so in this case I'm using the AWS load balancer, which is listening on 443 and then forwarding to 80 [15:11:41] jgleeson: ok, so to tunnel in and listen on 80 I guess you'd have to tunnel in as the root user on the AWS box [15:11:51] yep that's the thinking [15:12:07] so is the issue that there's already a built-in web server listening there? [15:13:18] I actually installed apache on friday to confirm the box is accessible, which it is here http://3.230.160.72/ [15:13:58] ok, so that's a positive sign. But then to forward port 80 to a dev machine you have to shut down apache, right? [15:14:01] so https://jackgleeson.co.uk/ is now => AWS load balancer listening on 443 which is currently timing out trying to forward over to 80 [15:14:12] yep re:apache shutdown [15:14:21] when I get to that part [15:15:16] huh, I get two different IP addresses back when I nslookup jackgleeson.co.uk [15:15:31] and neither of them are 3.230.160.72 [15:16:17] that domain is meant to be going to the load balanacer [15:16:38] balancer* [15:16:57] that part is configured I think [15:17:46] cstone / AndyRussG / jgleeson how would you feel about making the CreatePaymentResponse inherit from the PaymentDetailsResponse? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/700080/2/PaymentProviders/PaymentDetailResponse.php [15:18:54] with the new properties added in that patch, the PaymentDetailsResponse has all the features of the CreatePaymentResponse except for the redirect URL and data [15:19:45] jgleeson oh, so it's supposed to forward to a different machine that THEN forwards to a dev box? [15:20:00] that's so you don't have to give out root credentials on your main VPS ? [15:20:57] I guess technically the load balancer is a different machine, but that needs to be in the middle for use SSL termination [15:21:30] that's basically the nginx reverse proxy that we'd have in our usual config [15:21:33] you can't do ssl right on 3.230.160.72 ? [15:21:51] no sadly. aws free certs don't give you the cert files [15:22:06] it's all stitched into their stack [15:22:18] you can't install the actual cert on a standalone vps [15:22:27] ugh [15:22:28] ok [15:22:34] brb gotta run an errand [15:32:54] cstone: I'll put up a follow-on patch to make the one inherit from the other [15:33:08] but the patch as written is reviewable now just to be able to push ahead [15:33:39] ok cool sorry was having to move my desk around [15:39:28] (03PS1) 10Ejegg: Create response inherits from Details response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700942 [15:40:10] (03CR) 10jerkins-bot: [V: 04-1] Create response inherits from Details response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700942 (owner: 10Ejegg) [15:46:39] (03PS2) 10Ejegg: Create response inherits from Details response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700942 [15:50:53] (03PS1) 10Ejegg: Use response inheritance [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700944 [15:54:14] (03CR) 10jerkins-bot: [V: 04-1] Use response inheritance [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700944 (owner: 10Ejegg) [16:19:31] ejegg: hmm wrt inheriting that class, I'll have a look :) [16:20:49] (03PS2) 10Ejegg: Use response inheritance [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700944 [16:21:21] ok, ^^^ is just illustrating how the SmashPig patch helps clear up the usage in a calling class [16:21:22] 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, 10Fundraising Sprint Interstitial ads halfway down the coaster hill, 10Fundraising Sprint Ketchup Flume Ride, and 4 others: Convert large donation module to an extension - https://phabricator.wikimedia.org/T270667 (10... [16:21:49] 10Fundraising Sprint Humongous bacteria petting zoo, 10Fundraising Sprint Interstitial ads halfway down the coaster hill, 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, and 3 others: Convert wmf_campaigns to an extension - https://phabricator.wikimedia.org/T270676 (10DStrine) [16:22:46] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Modification to Fredge Report - https://phabricator.wikimedia.org/T285321 (10DStrine) [16:23:00] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Access to delete contributions from civi - Engage - https://phabricator.wikimedia.org/T285319 (10DStrine) [16:26:46] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Target-Smart: Data Pull: New FY2122 Donors - https://phabricator.wikimedia.org/T284784 (10DStrine) [16:34:35] ok cool ejegg makes sense to me and working locally when testing [16:38:17] (03CR) 10Cstone: [C: 03+2] "Nice the ideal part will need a couple more things here too." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700080 (https://phabricator.wikimedia.org/T282730) (owner: 10Ejegg) [16:38:53] (03Merged) 10jenkins-bot: Adyen: Add more details to DetailsResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700080 (https://phabricator.wikimedia.org/T282730) (owner: 10Ejegg) [16:42:21] cstone oh, what kind of additional stuff do you expect in the iDEAL details response? [16:42:37] amount and the psp reference [16:43:45] ok, the pspReference should be the gatewayTxnId from the base PaymentProviderResponse [16:44:16] I knew we had one was just confirming cause it sends back ours and the psp [16:44:26] so maybe invoice _id [16:44:39] i always forget our name for it, the one thats the adyen id like 8F8df9d [16:45:58] ah yeah, I think they call that the merchant reference [16:46:22] oh wait no, that IS the pspReference that has letters and numbers [16:46:37] the merchant reference is aka invoice ID, with the ct_id + . + sequence number [16:47:51] and we don't currently have merchant reference on there [16:48:12] but I guess it should go in the base PaymentProviderResponse [16:48:37] would the amount well its an array with amount and currency go there too or is that more of a details thing [16:49:28] 10fundraising-tech-ops: Fundraising access request for JESSICA JAMES-HILL - https://phabricator.wikimedia.org/T284712 (10Dwisehaupt) @RLewis I can get started but we still need her information on the collab page (https://collab.wikimedia.org/wiki/Fundraising#Contact_List) and the approval from @jrobell. Once th... [16:50:00] cstone I guess maybe the base too? [16:50:54] hmm, though maybe with we should actually move the things that are specific to a single payment UP to PaymentDetailsReponse [16:51:14] so e.g. the PaymentMethodResponse has a more basic base class [16:52:40] I guess it's good confirmation to read back the amount from the processor after we make an ideal call [16:53:08] but we DO already have in session the amount that we requested when we sent them for redirect [16:53:38] ah okay I guess I don't know what actually happens on the ideal redirect I thought they could change the amount there [16:56:53] would we even need to pull the merchant reference back from adyen since we have that too or would it be another check if something goes wrong [16:57:14] so I think we put the merchant reference in the return URL [16:57:49] and we'll have it in the $requestValues for processDonorReturn [16:58:03] that should maybe be enough to check that we're processing the same one we have in session [16:58:12] in case of e.g. donor opening multiple windows [17:06:19] ah man [17:06:52] England play Croatia at 8pm right when retro starts [17:42:51] (03PS1) 10Ejegg: Adyen-specific donate API action [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700966 [17:49:30] 10Fundraising-Backlog: turn on monthly convert for japan for the pretest on the 29th at 5pm pacific - https://phabricator.wikimedia.org/T285338 (10DStrine) [17:49:51] 10Fundraising-Backlog: turn on monthly convert for japan for the pretest on the 29th at 5pm pacific - https://phabricator.wikimedia.org/T285338 (10DStrine) [18:13:59] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/700970 [18:15:15] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/700970 (owner: 10Ejegg) [18:28:11] 10fundraising-tech-ops: Fundraising access request for JESSICA JAMES-HILL - https://phabricator.wikimedia.org/T284712 (10Dwisehaupt) Fixed up the previous comment since I accidentally mentioned Jessica instead of Lisa. [18:39:14] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10MDemosWMF) Hi @Eileenmcnaughton - thanks for going through everything and catching these discrepanc... [18:44:06] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/700970 (owner: 10Ejegg) [18:48:31] 10Fundraising-Backlog: Deactivating Engage User in Civi - https://phabricator.wikimedia.org/T285344 (10MDemosWMF) [18:56:28] 10Fundraising-Backlog, 10fundraising-tech-ops: Deactivating Engage User in Civi - https://phabricator.wikimedia.org/T285344 (10DStrine) [19:02:34] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/700973 [19:03:17] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/700973 (owner: 10Ejegg) [19:06:36] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-AutoTY-Email, 10FR-Email: Japanese Thank You Email Edit - https://phabricator.wikimedia.org/T283600 (10DStrine) 05Open→03Resolved [19:07:20] 10Fundraising Sprint Interstitial ads halfway down the coaster hill, 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10fundraising sprint Just in time roller coaster building, and 2 others: Enable SSL for CiviCRM DB connections - https://phabricator.wikimedia.org/T280080 (10DStrine) 05Open... [19:07:50] 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Adyen: swap out dropin for web components - https://phabricator.wikimedia.org/T284605 (10DStrine) 05Open→03Resolved [19:08:12] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: Civi::log()->info not sending output to stdout - https://phabricator.wikimedia.org/T282628 (10DStrine) 05Open→03Resolved [19:09:15] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Just in time roller coaster building, and 2 others: Delete TY email copies from contributions more than 1 year old. - https://phabricator.wikimedia.org/T280587 (10DStrine) 05Open→03Resol... [19:12:06] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/700973 (owner: 10Ejegg) [19:18:23] 10fundraising-tech-ops: Fundraising access request for JESSICA JAMES-HILL - https://phabricator.wikimedia.org/T284712 (10RLewis) @Dwisehaupt thank you, Amy and Jessica are on the case with approval and collab details. [19:36:27] (03PS2) 10Eileen: Extract code & reverse condition [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699974 (https://phabricator.wikimedia.org/T284196) [19:37:54] 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: sprint goal: get all standard previous adyen functionality into adyen branch and full test transaction with apple pay - https://phabricator.wikimedia.org/T284603 (10DStrine) [19:42:16] 10Fundraising Sprint M 2021, 10Fundraising-Backlog: turn on monthly convert for japan for the pretest on the 29th at 5pm pacific - https://phabricator.wikimedia.org/T285338 (10DStrine) [19:42:19] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Modification to Fredge Report - https://phabricator.wikimedia.org/T285321 (10DStrine) [19:42:21] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Access to delete contributions from civi - Engage - https://phabricator.wikimedia.org/T285319 (10DStrine) [19:42:24] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Fidelity import issue - same last name couples - https://phabricator.wikimedia.org/T285269 (10DStrine) [19:42:26] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Target-Smart: Data Pull: New FY2122 Donors - https://phabricator.wikimedia.org/T284784 (10DStrine) [19:42:29] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-Japan: Deploy new Japanese translations to paymentswiki - https://phabricator.wikimedia.org/T284680 (10DStrine) [19:42:31] 10Fundraising Sprint M 2021, 10Fundraising-Backlog: Pre-production key due to expire - https://phabricator.wikimedia.org/T284518 (10DStrine) [19:42:34] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Adyen Checkout: normalize API error codes - https://phabricator.wikimedia.org/T283307 (10DStrine) [19:42:36] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Adyen Checkout: handle authorization decline reasons - https://phabricator.wikimedia.org/T283117 (10DStrine) [19:42:40] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Make errors in drop-in card fields look like other errors - https://phabricator.wikimedia.org/T281550 (10DStrine) [19:42:46] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Adyen Checkout: create new recurring iDEAL donations - https://phabricator.wikimedia.org/T284606 (10DStrine) [19:42:50] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: sprint goal: get all standard previous adyen functionality into adyen branch and full test transaction with apple pay - https://phabricator.wikimedia.org/T284603 (10DStrine) [19:42:54] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: document testing procedures for UI/UX testing and payments testing. - https://phabricator.wikimedia.org/T284467 (10DStrine) [19:43:00] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, and 3 others: Adyen Checkout: get available payment methods - https://phabricator.wikimedia.org/T283627 (10DStrine) [19:43:06] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-Adyen, and 2 others: Adyen Checkout: handle new recurring card donations - https://phabricator.wikimedia.org/T283106 (10DStrine) [19:43:12] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, and 3 others: Handle 3DSecure for Adyen Checkout - https://phabricator.wikimedia.org/T282730 (10DStrine) [19:43:18] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-Adyen, and 2 others: Handle fraud filters for Adyen Checkout - https://phabricator.wikimedia.org/T282641 (10DStrine) [19:43:28] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, and 4 others: Handle iDEAL submission in Adyen Drop-In web - https://phabricator.wikimedia.org/T282595 (10DStrine) [19:43:32] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Just in time roller coaster building, and 3 others: Adyen: try to capture an old-style recurring with rest API - https://phabricator.wikimedia.org/T282302 (10DStrine) [19:43:36] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Source field not accepting negative amounts - https://phabricator.wikimedia.org/T284196 (10DStrine) [19:43:40] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-AutoTY-Email, 10fr-donorservices: Endowment Auto Thank You Email needs small copy change - https://phabricator.wikimedia.org/T284184 (10DStrine) [19:43:44] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-AutoTY-Email, and 2 others: Monthly convert email translation suggestion (Japanese translation) - https://phabricator.wikimedia.org/T283748 (10DStrine) [19:43:48] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Fix trigger sql issues - https://phabricator.wikimedia.org/T283561 (10DStrine) [19:43:52] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10DStrine) [19:43:56] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: New Payment Method added: Money Order - https://phabricator.wikimedia.org/T283023 (10DStrine) [19:44:00] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Just in time roller coaster building, and 3 others: Time boxed adyen related code organizaiton/planning - https://phabricator.wikimedia.org/T282608 (10DStrine) [19:44:06] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, and 4 others: Handle Apple Pay submission in Adyen Components - https://phabricator.wikimedia.org/T282596 (10DStrine) [19:44:10] 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-AutoTY-Email, 10FR-Email: Formatting issue with Civi recurring expiry/fail email? - https://phabricator.wikimedia.org/T282582 (10DStrine) [19:44:14] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Just in time roller coaster building, and 2 others: Update contact email address on the ES error screen - https://phabricator.wikimedia.org/T282497 (10DStrine) [19:44:18] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Automatic date added when Benefactor Page Listing fields are updated - https://phabricator.wikimedia.org/T282448 (10DStrine) [19:44:22] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 5 others: Japanese donor name clean up pass - https://phabricator.wikimedia.org/T281493 (10DStrine) [19:44:26] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Civi stock TY email template missing gift date - https://phabricator.wikimedia.org/T281313 (10DStrine) [19:44:30] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Benefactor Page Listing Custom field - https://phabricator.wikimedia.org/T281268 (10DStrine) [19:44:34] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 9 others: Update Fundraising tech CI image to use upstream buildkit, no symlink for civi... - https://phabricator.wikimedia.org/T277500 [19:44:38] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-Docker: Docker dev setup: Set up IPN listeners - https://phabricator.wikimedia.org/T268687 (10DStrine) [19:44:42] 10Fundraising Sprint Interstitial ads halfway down the coaster hill, 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint M 2021, 10Fundraising-Backlog, and 2 others: deprecate and or move wikitech documentation to Mediawiki - https://phabricator.wikimedia.org/T281304 (10DStrine) [19:44:46] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Corrugated super slide, 10Fundraising Sprint Downed power line jump rope, and 21 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10DStrine) [20:44:23] 10Fundraising-Backlog, 10fundraising-tech-ops: Deactivating Engage User in Civi - https://phabricator.wikimedia.org/T285344 (10Dwisehaupt) [20:44:49] 10Fundraising-Backlog, 10fundraising-tech-ops: Deactivating Engage User in Civi - https://phabricator.wikimedia.org/T285344 (10Dwisehaupt) a:03Dwisehaupt [20:48:32] 10fundraising-tech-ops: Fundraising access request for JESSICA JAMES-HILL - https://phabricator.wikimedia.org/T284712 (10AParker) Approval received. Pasted below. Should I also forward that email to someone? And who? Amy Parker 4:19 PM (28 minutes ago) to Lisa, Caitlin, Leticia Hi Lisa,... [20:51:03] 10fundraising-tech-ops: Fundraising access request for JESSICA JAMES-HILL - https://phabricator.wikimedia.org/T284712 (10Dwisehaupt) @AParker Thanks. No need to send along a copy, the one here is fine. I see collab has been update to, so I'll get this rolling. [21:00:45] (03PS2) 10Eileen: Add js to populate source rather than making people do it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699975 (https://phabricator.wikimedia.org/T284196) [21:00:53] (03PS2) 10Eileen: Remove source validation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699976 (https://phabricator.wikimedia.org/T284196) [21:01:08] (03PS2) 10Eileen: Alternate - fix regex [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699977 (https://phabricator.wikimedia.org/T284196) [21:02:15] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/700988 [21:02:42] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/700988 (owner: 10Eileen) [21:05:05] !log updated payments-wiki from 7be0534b91 to 42cfbe832d [21:05:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:05:53] !log civicrm revision changed from 629bd3b7b7 to c745d4f075, config revision is 4ab72c1033 [21:05:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:07:11] eileen is the SQL creating the new field used in those triggers actually checked in? [21:07:22] I'm getting some undefined columns running locally [21:07:34] oh hmm, one of those may be a new core field [21:07:39] coupon_code [21:07:49] ejegg is that a new core field? [21:08:16] looking [21:08:47] which table? [21:09:46] huh, I guess it's civicrm_event_carts [21:10:33] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Access to delete contributions from civi - Engage - https://phabricator.wikimedia.org/T285319 (10Eileenmcnaughton) a:03Eileenmcnaughton [21:11:09] trying it on a fresh buildkit install [21:12:18] oh odd - I wasn't aware of it having changed [21:15:10] hmm, same issue [21:15:28] wait, checking to see if that's actually rebuilt with 5.39 [21:16:17] yeah, it's 5.39 as well [21:16:28] maybe removed in core and not on our prod? [21:17:02] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Access to delete contributions from civi - Engage - https://phabricator.wikimedia.org/T285319 (10Eileenmcnaughton) I've added the 'Engage Management' role to this user [21:17:38] yah, I only see coupon_code mentioned in that one trigger file [21:18:17] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog: turn on monthly convert for japan for the pretest on the 29th at 5pm pacific - https://phabricator.wikimedia.org/T285338 (10DStrine) p:05Triage→03Medium [21:18:42] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Modification to Fredge Report - https://phabricator.wikimedia.org/T285321 (10DStrine) p:05Triage→03Medium [21:18:57] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Fidelity import issue - same last name couples - https://phabricator.wikimedia.org/T285269 (10DStrine) p:05Triage→03Medium [21:19:05] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Target-Smart: Data Pull: New FY2122 Donors - https://phabricator.wikimedia.org/T284784 (10DStrine) p:05Triage→03High [21:19:09] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-Japan: Deploy new Japanese translations to paymentswiki - https://phabricator.wikimedia.org/T284680 (10DStrine) p:05Triage→03High [21:19:11] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog: Pre-production key due to expire - https://phabricator.wikimedia.org/T284518 (10DStrine) p:05Triage→03Medium [21:19:25] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Adyen Checkout: normalize API error codes - https://phabricator.wikimedia.org/T283307 (10DStrine) p:05Triage→03High [21:19:32] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Adyen Checkout: handle authorization decline reasons - https://phabricator.wikimedia.org/T283117 (10DStrine) p:05Triage→03High [21:19:41] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Make errors in drop-in card fields look like other errors - https://phabricator.wikimedia.org/T281550 (10DStrine) p:05Triage→03High [21:20:01] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-AutoTY-Email, and 2 others: Monthly convert email translation suggestion (Japanese translation) - https://phabricator.wikimedia.org/T283748 (10DStrine) p:05Medium→03High [21:20:05] ejegg: it must have been removed a long time ago [21:20:05] 10fundraising-tech-ops: Fundraising access request for JESSICA JAMES-HILL - https://phabricator.wikimedia.org/T284712 (10Dwisehaupt) [21:20:43] should we remove it on prod to keep things in sync? [21:20:54] would be nice to be able to test the triggers locally [21:21:03] I would say just but we need to remove it from the trigger first I guess [21:21:25] There is a plan to actually move all of that code to an extension [21:22:25] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Performance-Team (Radar), 10Platform Team Workboards (Clinic Duty Team): High frequency warning logged in production: Cookies set on {url} with Cache-Control "{cache-control}" - https://phabricator.wikimedia.org/T285210 (10BPirkle) p:05Triage... [21:26:43] ejegg: by the way - I just allocated that new engage permission to engage on live so we can do the next patch now [21:29:36] ok, cool [21:40:18] (03PS1) 10Eileen: Move mailingdataPorvider to right level [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700992 [21:44:09] (03PS4) 10Ejegg: Update contactlayout editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699984 (https://phabricator.wikimedia.org/T283559) (owner: 10Eileen) [21:45:13] (03CR) 10Ejegg: [C: 03+2] "Looks good after a system.flush and cc all. The new layout name display/edit button at the top right of the actual contact display seems t" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699984 (https://phabricator.wikimedia.org/T283559) (owner: 10Eileen) [21:46:13] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog: make acoustic mail data searchable through search kit - https://phabricator.wikimedia.org/T285359 (10DStrine) [21:50:16] (03PS2) 10Ejegg: Update deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699985 (https://phabricator.wikimedia.org/T283559) (owner: 10Eileen) [21:50:26] (03CR) 10Ejegg: [C: 03+2] Update deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699985 (https://phabricator.wikimedia.org/T283559) (owner: 10Eileen) [21:52:03] (03PS3) 10Ejegg: Extract code & reverse condition [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699974 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [21:52:10] (03CR) 10Ejegg: [C: 03+2] Extract code & reverse condition [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699974 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [21:53:13] (03PS2) 10Eileen: Move mailingdataPorvider to right level [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700992 [21:59:43] (03Merged) 10jenkins-bot: Update contactlayout editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699984 (https://phabricator.wikimedia.org/T283559) (owner: 10Eileen) [22:03:46] (03Merged) 10jenkins-bot: Update deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699985 (https://phabricator.wikimedia.org/T283559) (owner: 10Eileen) [22:11:26] (03Merged) 10jenkins-bot: Extract code & reverse condition [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699974 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [22:19:49] (03PS3) 10Eileen: Move mailingdataPorvider to right level [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700992 (https://phabricator.wikimedia.org/T285359) [22:20:26] (03PS4) 10Eileen: Move mailingdataProvider to right level [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700992 (https://phabricator.wikimedia.org/T285359) [22:29:06] 10fundraising-tech-ops: Add rmurthy to fr-analytics group in frack - https://phabricator.wikimedia.org/T284792 (10Dwisehaupt) The ssh config file was missing a host block for fran* as that isn't in the default config we push out. Added that in and connections work as expected. [22:30:56] 10fundraising-tech-ops: Add rmurthy to fr-analytics group in frack - https://phabricator.wikimedia.org/T284792 (10Dwisehaupt) 05Open→03Resolved [22:33:41] cstone: are you able to look at https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/700747 [22:41:01] 10Fundraising-Backlog, 10fundraising-tech-ops: User needs Terminal access to Fredge - https://phabricator.wikimedia.org/T283871 (10Dwisehaupt) Wonderful. The next steps are outlined in https://collab.wikimedia.org/wiki/Fundraising_ssh_access, specifically the yubikey and ssh portions. Please follow those instr... [22:46:55] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10Eileenmcnaughton) @MDemosWMF so regarding 1 - the diffe... [22:50:33] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Modification to Fredge Report - https://phabricator.wikimedia.org/T285321 (10Eileenmcnaughton) @EMartin which is the report you are using - I thought at first it was https://civicrm.wikimedia.org/civicrm/report/... [22:55:22] 10fundraising-tech-ops: Fundraising access request for JESSICA JAMES-HILL - https://phabricator.wikimedia.org/T284712 (10Dwisehaupt) a:03Dwisehaupt [22:56:22] 10Fundraising-Backlog, 10fundraising-tech-ops: User needs Terminal access to Fredge - https://phabricator.wikimedia.org/T283871 (10Dwisehaupt) [22:56:39] 10Fundraising-Backlog, 10fundraising-tech-ops: User needs Terminal access to Fredge - https://phabricator.wikimedia.org/T283871 (10Dwisehaupt) a:03Dwisehaupt [22:57:50] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog: make acoustic mail data searchable through search kit - https://phabricator.wikimedia.org/T285359 (10EYener) I'm trying to test this under the [[ https://civicrm.frdev.wikimedia.org/civicrm/admin/search#/edit/383 | Mailing Datas test ]] searchkit... [23:12:44] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Modification to Fredge Report - https://phabricator.wikimedia.org/T285321 (10EMartin) Hi Eileen, I'm using https://civicrm.wikimedia.org/civicrm/report/wmffraud/fredge?reset=1 [23:13:19] (03CR) 10AndyRussG: [C: 03+2] "Yaaaaaaaayyyyy thanks!! :) :)" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/698073 (https://phabricator.wikimedia.org/T282730) (owner: 10Ejegg) [23:15:38] (03Merged) 10jenkins-bot: Move 3D Secure staging logic to base class [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/698073 (https://phabricator.wikimedia.org/T282730) (owner: 10Ejegg) [23:18:53] (03CR) 10AndyRussG: [C: 03+2] "Yeeiiiii :D" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700103 (owner: 10Ejegg) [23:21:47] (03Merged) 10jenkins-bot: Adyen Checkout: Fix SessionVelocity warning [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700103 (owner: 10Ejegg) [23:22:06] (03CR) 10AndyRussG: [C: 03+2] "Noice!!!!!!!!! ;)" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700104 (owner: 10Ejegg) [23:24:27] (03Merged) 10jenkins-bot: Adyen Checkout: guard against unset avs/cvv score [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700104 (owner: 10Ejegg) [23:26:49] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Modification to Fredge Report - https://phabricator.wikimedia.org/T285321 (10Eileenmcnaughton) @EMartin We don't actually store the email for attempted payments - we can include it for successful ones - I'm not... [23:37:53] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10Eileenmcnaughton) @MDemosWMF so on 5 we could add a rul... [23:38:37] (03PS1) 10Ejegg: GatewayType extends LogPrefixProvider [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700998 [23:38:39] (03PS1) 10Ejegg: 3D secure staging cleanup [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700999 [23:40:21] (03PS1) 10Ejegg: Merge branch 'master' into adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701000 [23:41:24] (03CR) 10jerkins-bot: [V: 04-1] 3D secure staging cleanup [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700999 (owner: 10Ejegg) [23:43:01] (03CR) 10jerkins-bot: [V: 04-1] Merge branch 'master' into adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701000 (owner: 10Ejegg) [23:43:14] hrm, "Return type hint of bool cannot be used [23:43:15] " [23:43:16] ? [23:43:40] something still assuming php 7.0 compat? [23:46:52] (03PS2) 10Ejegg: 3D secure staging cleanup [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700999 [23:47:41] (03PS2) 10Ejegg: Merge branch 'master' into adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701000