[00:15:42] eileen: im awake from my nap hah I can look now [00:15:56] :-) [00:23:06] (03PS1) 10Eileen: Add support for Fee Amount to engage import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701002 (https://phabricator.wikimedia.org/T283104) [00:23:23] cstone: that ^^ is pretty small & it would be good to push it out too [00:23:56] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Fidelity import issue - same last name couples - https://phabricator.wikimedia.org/T285269 (10Eileenmcnaughton) a:03Eileenmcnaughton [00:25:08] (03PS2) 10Eileen: Name parse fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700721 (https://phabricator.wikimedia.org/T285269) [00:25:33] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Fidelity import issue - same last name couples - https://phabricator.wikimedia.org/T285269 (10Eileenmcnaughton) This is the patch - not sure why it's not linked https://gerrit.wikimedia.org/r/c/wikimedia/fundrai... [00:27:08] (03CR) 10Cstone: [C: 03+2] "Yep its skipping Steve Trevors and flipping others as normal." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700747 (owner: 10Eileen) [00:36:45] (03Merged) 10jenkins-bot: Fix Japanese name flip to skip Harrison Tylers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700747 (owner: 10Eileen) [00:38:07] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701004 [00:38:16] (03CR) 10Cstone: [C: 03+2] "Fee imported!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701002 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [00:38:25] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701004 (owner: 10Eileen) [00:45:12] (03PS1) 10Cstone: Update recurring text for Japanese thank you email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701005 (https://phabricator.wikimedia.org/T283748) [00:46:07] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-AutoTY-Email, and 3 others: Monthly convert email translation suggestion (Japanese translation) - https://phabricator.wikimedia.org/T283748 (10Cstone) a:03Cstone [00:46:45] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Adyen Checkout: create new recurring iDEAL donations - https://phabricator.wikimedia.org/T284606 (10Cstone) a:03Cstone [00:48:19] (03Merged) 10jenkins-bot: Add support for Fee Amount to engage import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701002 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [00:50:58] !log civicrm revision changed from c745d4f075 to 03bead707d, config revision is 4ab72c1033 [00:51:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:56:34] cstone: so I'll re-enable the japanese name flip - you probably don't need to look at the patch since I'm just uncommenting the schedule again [00:56:57] Okie sounds good [01:04:19] !log process-control config revision is 6a88618c3e [01:04:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:12:11] cstone: also - I'm getting annoyed with the red about loading google fonts - it's just one font 'poppins' [01:13:18] (03PS1) 10Eileen: Get rid of Mary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701007 [01:13:39] if we merge ^^ it goes away & I doubt anyone will notice.... [01:14:32] Rip mary [01:14:50] I've pulled it onto staging & it seems fine with that gone [01:15:19] okie [01:15:25] fwiw - that theme is the drupal theme & it's not really maintained now [01:15:43] (03CR) 10Cstone: [C: 03+2] "Farewell" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701007 (owner: 10Eileen) [01:17:57] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog: make acoustic mail data searchable through search kit - https://phabricator.wikimedia.org/T285359 (10Eileenmcnaughton) OK - I see the error ` Error: Call to a member function getEntityFields() on null in Civi\Api4\Query\Api4SelectQuery->autoJoi... [01:23:18] cstone: so the other thing is - we should start replacing watchdog with Civi::log() - probably it would be Civi::log('wmf')->info() - but we need to add a cli logger for 'wmf' I think [01:24:50] (03PS1) 10Eileen: Switch from watchdog to civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701008 [01:25:28] I guess if we do ^^ then we can make sure it's logging out how we want before we make any other changes (since that is at the start of every donation queue process) [01:26:15] (03Merged) 10jenkins-bot: Get rid of Mary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701007 (owner: 10Eileen) [01:26:57] Makes sense only thing I noticed from the smashpig job was extra [ ] s at the end which I think you said were cause it could spit out more data? [01:28:39] not quite sure I follow that [01:29:01] you mean the output has an extra line? [01:29:27] lemme confirm [01:31:01] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701009 [01:31:16] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701009 (owner: 10Eileen) [01:35:26] hmm eileen how would i properly add that new monolog setting locally [01:35:32] turn the extension off and on? [01:35:51] cstone: so I guess we haven't added on to the config mgd file & we would need to [01:37:50] oh nevermind user error [01:37:58] (03PS1) 10Eileen: Add wmf cli monolgo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 [01:38:01] cstone: [01:38:12] I think ^^ would add a cli logger to the 'wmf' channel [01:38:35] hah okay thanks [01:38:47] I didn't tinker with 'weight' or 'final' - just left it in a 'both on' state which I think is closest to what we have now [01:39:37] so the [] I mean the watchdog said DB transaction while civi log says civicrm.wmf.INFO: Beginning DB transaction [] [01:40:47] adding that empty [] onto the end [01:40:59] oh yeah - we can possibly ignore that - we could make it do a better job or parsing it if we want [01:41:23] (03CR) 10jerkins-bot: [V: 04-1] Add wmf cli monolgo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 (owner: 10Eileen) [01:41:31] the idea is that instead of Civi::log()->info('starting processing contribution 1) [01:41:51] it would be Civi::log()->info('starting processing contribution {id}', ['id' => 1)) [01:42:01] but there is also a parser I thought I added [01:42:11] okay yeah I thought it was something like that [01:42:26] yeah $psrProcessor = new PsrLogMessageProcessor(); [01:42:32] is supposed to do that bit [01:42:44] maybe the empty array is still a feature tho [01:42:53] okie so expected to be [] when its just info text like this one then? [01:43:28] well try [01:43:28] $psrProcessor = new PsrLogMessageProcessor(NULL, TRUE); [01:43:48] oh I don't know actually [01:46:11] (03PS2) 10Eileen: Add wmf cli monolgo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 [01:47:45] I'm guessing that as long as the [] is not too annoying / losing us data it's ok [01:49:52] (03CR) 10jerkins-bot: [V: 04-1] Add wmf cli monolgo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 (owner: 10Eileen) [01:49:54] yeah it's fine just wanted to confirm before we put it everywhere [01:51:34] I'm not sure what's wrong with that mgd file - I guess I'll have to debug to figure it out [01:51:51] yeah no worries on that part I was able to see it in the log files [01:52:18] (03CR) 10Cstone: [C: 03+2] "Looks good locally" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701008 (owner: 10Eileen) [01:53:41] im going to head out have a good rest of your day eileen [01:54:00] (03PS3) 10Eileen: Add wmf cli monolgo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 [01:54:01] cool - see ya [01:57:24] (03CR) 10jerkins-bot: [V: 04-1] Add wmf cli monolgo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 (owner: 10Eileen) [02:01:56] (03Merged) 10jenkins-bot: Switch from watchdog to civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701008 (owner: 10Eileen) [02:24:34] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10Eileenmcnaughton) @MDemosWMF I just deployed #3 - 'supp... [03:03:07] (03PS4) 10Eileen: Add wmf cli monolgo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 [03:06:23] (03CR) 10jerkins-bot: [V: 04-1] Add wmf cli monolgo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 (owner: 10Eileen) [03:08:05] (03PS5) 10Eileen: Add wmf cli monolgo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 [05:07:22] (03PS1) 10Eileen: Fix sorting for drop triggers [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/701014 (https://phabricator.wikimedia.org/T283561) [05:08:04] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Fix trigger sql issues - https://phabricator.wikimedia.org/T283561 (10Eileenmcnaughton) Ok - I overdid the sorting last time.... https://gerrit.wikimedia.... [07:38:09] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices, 10Epic, 10FR-Email: Creating exceptions for when to send the recurring expiry/fail email - https://phabricator.wikimedia.org/T276959 (10CDenes_WMF) @DStrine do we need to create a separate phab task for getting the new copy/translations shared... [08:29:08] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices, 10Epic, 10FR-Email: Creating exceptions for when to send the recurring expiry/fail email - https://phabricator.wikimedia.org/T276959 (10Eileenmcnaughton) @CDenes_WMF I think we are going to talk about it tomorrow . The translations are up ther... [08:31:25] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices, 10Epic, 10FR-Email: Creating exceptions for when to send the recurring expiry/fail email - https://phabricator.wikimedia.org/T276959 (10CDenes_WMF) Great, thank you very much for the update Eileen :) I'll leave it to you and Michael then, on w... [08:32:34] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices, 10Epic, 10FR-Email: Creating exceptions for when to send the recurring expiry/fail email - https://phabricator.wikimedia.org/T276959 (10Eileenmcnaughton) @CDenes_WMF actually DO create a new phab - because some of the languages - eg. Russian -... [08:39:45] 10Fundraising-Backlog: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10CDenes_WMF) [08:40:33] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices, 10Epic, 10FR-Email: Creating exceptions for when to send the recurring expiry/fail email - https://phabricator.wikimedia.org/T276959 (10CDenes_WMF) Created https://phabricator.wikimedia.org/T285375 [08:40:45] 10Fundraising-Backlog: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10CDenes_WMF) [10:31:23] 10Fundraising-Backlog: Edit to Thank You Email footer in 13 languages - https://phabricator.wikimedia.org/T285383 (10CDenes_WMF) [13:03:40] 10Fundraising-Backlog, 10fundraising-tech-ops: User needs Terminal access to Fredge - https://phabricator.wikimedia.org/T283871 (10RKumar_WMF) Hi, Apologies but I am not sure how to set it up as what I have seen with my colleague (Michael), it's very different. I am sharing the picture of the one I received.... [13:33:32] 10Fundraising-Backlog, 10Analytics, 10Analytics-Kanban, 10Event-Platform, and 2 others: CentralNoticeBannerHistory and CentralNoticeImpression Event Platform Migration - https://phabricator.wikimedia.org/T271168 (10Ottomata) [13:34:03] (03PS2) 10Ottomata: Finalize migration to Event Plaform for EL schemas [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/699787 (https://phabricator.wikimedia.org/T271168) [13:38:05] (03CR) 10jerkins-bot: [V: 04-1] Finalize migration to Event Plaform for EL schemas [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/699787 (https://phabricator.wikimedia.org/T271168) (owner: 10Ottomata) [13:41:33] AndyRussG: o/ [13:41:36] no idea why https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/699787 is failing [13:41:37] can you tell? [14:20:25] huh, RuntimeException: Config accessed before it is set [14:21:04] how would that possibly relate to the Schemas change? [14:22:52] that seems totally bizarre ottomata. I wonder if other CN patches are passing [14:23:33] (03CR) 10Ejegg: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/688951 (owner: 10Thiemo Kreuz (WMDE)) [14:24:02] yeah ejegg didn't understand it either [14:24:02] ottomata: ejegg: hiiiiii [14:25:08] ottomata: also thanks so so much to you and Analytcs for digging into this stuff, immensely appreciated!!! :) :) :) [14:25:20] ottomata: ejegg: have you checked the extension.json schema verison? [14:26:51] K hmmm looking at the logs that doesn't seem likely.... [14:27:09] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Access to delete contributions from civi - Engage - https://phabricator.wikimedia.org/T285319 (10MDemosWMF) The user tested it and it's working, thanks! [14:27:19] maybe something to do with updates to core that CN now has troubles with? [14:27:34] ottomata: I can commit to digging in properly this evening btw [14:27:47] (03CR) 10jerkins-bot: [V: 04-1] Add unit test for CentralNotice::sanitizeSearchTerms [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/688951 (owner: 10Thiemo Kreuz (WMDE)) [14:28:03] aha, that other patch fails too [14:28:15] so yep, probs something new in core [14:28:30] AndyRussG: thank you [14:30:43] ottomata: thank u! also looks like ejegg has something ^ [14:30:46] ejegg: thanks!!!! :) [14:44:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations: Trickle of damaged recurring donation messages with contact_id but without gateway_txn_id - https://phabricator.wikimedia.org/T285396 (10Ejegg) [14:47:14] * ejegg (bernie meme) fr-tech I am once again asking for your CR on these patches: https://gerrit.wikimedia.org/r/q/owner:ejegg%2540ejegg.com+is:open+-age:9d [14:50:08] (03PS2) 10Ejegg: Try removing the pre-create stuff [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/664381 (owner: 10Eileen) [14:50:20] (03CR) 10Ejegg: [C: 03+2] "Moar normalcy!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/664381 (owner: 10Eileen) [14:51:48] (03PS5) 10Ejegg: Move mailingdataProvider to right level [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700992 (https://phabricator.wikimedia.org/T285359) (owner: 10Eileen) [14:51:57] (03CR) 10Ejegg: [C: 03+2] "Moar correct!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700992 (https://phabricator.wikimedia.org/T285359) (owner: 10Eileen) [15:01:46] (03Merged) 10jenkins-bot: Try removing the pre-create stuff [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/664381 (owner: 10Eileen) [15:05:41] (03Merged) 10jenkins-bot: Move mailingdataProvider to right level [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700992 (https://phabricator.wikimedia.org/T285359) (owner: 10Eileen) [15:07:25] (03CR) 10Ejegg: [C: 03+2] Fix sorting for drop triggers [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/701014 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [15:09:42] (03PS6) 10Ejegg: Add wmf cli monolgo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 (owner: 10Eileen) [15:09:56] (03PS7) 10Ejegg: Add wmf cli monolog [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 (owner: 10Eileen) [15:10:06] (03CR) 10Ejegg: [C: 03+2] Add wmf cli monolog (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 (owner: 10Eileen) [15:18:37] (03Merged) 10jenkins-bot: Fix sorting for drop triggers [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/701014 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [15:19:38] (03CR) 10Ejegg: [C: 04-1] "If someone writes a non-USD currency and amount, let's not clobber it if they change the USD amount as the USD amount is unlikely to be th" (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699975 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [15:20:28] (03Merged) 10jenkins-bot: Add wmf cli monolog [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701010 (owner: 10Eileen) [15:32:08] ejegg: I had to google bernie meme [15:32:36] at first I thought it was a reference to sesame street [15:32:41] (03CR) 10Ejegg: [C: 04-1] "This makes the NameParseTest fail (note the NameParseTest is not in the right dir to be automatically executed)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700721 (https://phabricator.wikimedia.org/T285269) (owner: 10Eileen) [15:33:06] heh jgleeson that was all over reddit for like the first half of 2020 [15:33:12] at least US reddit [15:33:23] I'm running into problems ssh tunneling with applepay so I'll break from that now and pick up some of your review [15:33:32] thanks jgleeson! [15:34:10] if you want to do a video chat either for the CR or for the tunnel troubleshooting I'm happy to do that! [15:34:37] sure we can do both [15:34:50] I can share the world of pain that is an AWS setup [15:34:57] :P [15:35:21] https://meet.google.com/nsc-symi-ici ? [15:35:27] (standup link) [15:35:39] coming [16:03:51] (03CR) 10Jgleeson: [C: 03+2] "walk through this on a call and it worked as expected. nice!" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/695817 (https://phabricator.wikimedia.org/T282730) (owner: 10Ejegg) [16:07:09] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: document testing procedures for UI/UX testing and payments testing. - https://phabricator.wikimedia.org/T284467 (10XenoRyet) Initial synch up meeting done. Plans made for going forward, and recurring futur... [16:07:21] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: document testing procedures for UI/UX testing and payments testing. - https://phabricator.wikimedia.org/T284467 (10XenoRyet) 05Open→03Resolved [16:12:36] (03CR) 10Cstone: [C: 03+2] "this does work for iDEAL, I like breaking the do payment into pieces too" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700105 (https://phabricator.wikimedia.org/T282730) (owner: 10Ejegg) [16:18:22] (03Merged) 10jenkins-bot: Adyen Checkout: first step of 3D Secure (Redirect) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/695817 (https://phabricator.wikimedia.org/T282730) (owner: 10Ejegg) [16:18:24] (03Merged) 10jenkins-bot: Adyen Checkout: handle return from redirect [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700105 (https://phabricator.wikimedia.org/T282730) (owner: 10Ejegg) [18:10:35] (03CR) 10AndyRussG: [C: 03+2] "Yaaay" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701005 (https://phabricator.wikimedia.org/T283748) (owner: 10Cstone) [18:18:31] 10Fundraising-Backlog, 10fundraising-tech-ops: User needs Terminal access to Fredge - https://phabricator.wikimedia.org/T283871 (10Dwisehaupt) That looks like a USB-C nano yubikey. There are different types of yubikeys so it is ok it if looks different than what Michael has. It should just plug into any USB-C... [18:27:21] (03Merged) 10jenkins-bot: Update recurring text for Japanese thank you email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701005 (https://phabricator.wikimedia.org/T283748) (owner: 10Cstone) [18:55:57] (03CR) 10Jgleeson: [C: 03+2] Use response inheritance [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700944 (owner: 10Ejegg) [18:57:16] jgleeson: Thanks! We'll need this one too for ^^^ to work: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/700942 [19:02:53] (03CR) 10Jgleeson: Use response inheritance [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700944 (owner: 10Ejegg) [19:03:14] ah sorry ejegg I didn't realise. lemme undo that +2 for now and then I can try them both tomorrow and then +2 together [19:03:18] sorry for the mixup [19:03:48] ah shoot, I missed the depends-on header [19:06:03] hmm just looked at the other smashpig patch and there's not much there to require lots of review time so I guess we could +2 now but then also continue talking about what we do with the abstract PaymentProviderResponse if we feel that does too much [19:07:25] also the smashpig patch is going into master [19:08:45] I'll hold off for now as I'm logging off but dig in more tomorrow. In my head I'm thinking maybe we want to consider refactoring the abstract to be more like your new PaymentDetails class and then add another level to add the currently properties in the abstract that aren't universal across all response types [19:09:04] current* [19:09:08] bye for now [19:11:41] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: New Payment Method added: Money Order - https://phabricator.wikimedia.org/T283023 (10MDemosWMF) I tried to hand enter a money order contribution and it looks like... [19:17:54] 10Fundraising-Backlog, 10fr-donorservices: Ingenico status 190s question - https://phabricator.wikimedia.org/T283524 (10DStrine) update: fr-tech still might not have much to do here but we're available to be in communications/emails about this. we could devote an hour of looking in the logs but we might not ha... [19:50:32] 10Fundraising-Backlog, 10fr-donorservices: Ingenico status 190s question - https://phabricator.wikimedia.org/T283524 (10MBeat33) Thank you! Knowing the donors will see the TY page should reduce Zendesk traffic about this. [19:52:36] (03PS1) 10Eileen: Submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701175 [19:52:59] (03CR) 10Eileen: [C: 03+2] Submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701175 (owner: 10Eileen) [20:02:37] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Modification to Fredge Report - https://phabricator.wikimedia.org/T285321 (10EMartin) @Eileenmcnaughton we'll take that. It would be good to see emails for successful ones. Thanks [20:05:48] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701176 [20:06:02] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701176 (owner: 10Eileen) [20:09:47] (03PS3) 10Eileen: Add js to populate source rather than making people do it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699975 (https://phabricator.wikimedia.org/T284196) [20:10:52] (03CR) 10Eileen: "> Patch Set 2: Code-Review-1" (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699975 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [20:11:18] (03CR) 10Eileen: "Aha - you found it!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700721 (https://phabricator.wikimedia.org/T285269) (owner: 10Eileen) [20:30:04] ah, fr-tech, looks like that mw update didn't make it onto production payments yet? [20:30:07] will do that now [20:32:01] oh weird, didn't even get merged [20:33:07] hmm, 'recheck' didn't get zuul to pick it up [20:38:08] !log civicrm revision changed from 53d103f672 to bd906975f0, config revision is 6a88618c3e [20:38:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:38:49] (03CR) 10Ejegg: [C: 03+2] "Thanks! This feels like the right behavior - I imagine when people are independently entering original + USD amounts then correcting the U" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699975 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [20:49:37] (03Merged) 10jenkins-bot: Add js to populate source rather than making people do it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699975 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [20:50:47] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/701178 [20:51:40] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/701178 [20:55:51] !log updated payments-wiki from 42cfbe832d to d9892207c1 [20:55:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:56:29] (03CR) 10jerkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/701178 (owner: 10Hashar) [21:01:31] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/701178 (owner: 10Hashar) [21:39:51] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10MDemosWMF) @Eileenmcnaughton gotcha for #1 it should be... [21:51:39] PROBLEM - check_puppetrun on payments2002 is CRITICAL: CRITICAL: Puppet has 12 failures. Last run 3 minutes ago with 12 failures. Failed resources (up to 3 shown): File[/etc/vim/vimrc.local],File[/usr/local/bin/package_update_check],File[/usr/local/bin/yubikey_otp_filter],File[/bin/nopeshell] [21:56:39] RECOVERY - check_puppetrun on payments2002 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [22:00:31] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Remove field coupon_code from event cart table - https://phabricator.wikimedia.org/T285441 (10Eileenmcnaughton) [22:00:51] (03PS1) 10Eileen: Improve output triggers when logged to file [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/701180 (https://phabricator.wikimedia.org/T283561) [23:00:50] 10Fundraising-Backlog, 10fr-donorservices: Ingenico status 190s question - https://phabricator.wikimedia.org/T283524 (10EMartin) Hi, I am making a note here re: Ingenico's findings on this matter. It appears JCB is rejecting Japanese descriptors, when it went through in English, they do not reject it: Every... [23:07:30] PROBLEM - check_puppetrun on pay-lvs1002 is CRITICAL: CRITICAL: Puppet has 9 failures. Last run 3 minutes ago with 9 failures. Failed resources (up to 3 shown): File[/etc/vim/vimrc.local],File[/usr/local/bin/package_update_check],File[/usr/local/bin/yubikey_otp_filter],File[/bin/nopeshell] [23:12:31] PROBLEM - check_puppetrun on pay-lvs1002 is CRITICAL: CRITICAL: Puppet has 9 failures. Last run 8 minutes ago with 9 failures. Failed resources (up to 3 shown): File[/etc/vim/vimrc.local],File[/usr/local/bin/package_update_check],File[/usr/local/bin/yubikey_otp_filter],File[/bin/nopeshell] [23:17:32] RECOVERY - check_puppetrun on pay-lvs1002 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [23:35:50] (03PS3) 10Eileen: Remove source validation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699976 (https://phabricator.wikimedia.org/T284196) [23:36:06] (03PS3) 10Eileen: Alternate - fix regex [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699977 (https://phabricator.wikimedia.org/T284196)