[00:00:37] I'm gonna turn off the japanese name flip now - there are 269 contacts left -most of which do not have Japanese as their language - although it is possible they should [00:03:56] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 5 others: Japanese donor name clean up pass - https://phabricator.wikimedia.org/T281493 (10Eileenmcnaughton) I'm turning off the job now - this url shows the remain... [00:10:50] !log process-control config revision is 821e5889f7 [00:10:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:12:07] ejegg: I logged a spin off task for that event cart coupon_code. My plan is to get the committed triggers in sync now & then deploy https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/701180 & re-do them in the improved format & from then on it should be clear each upgrade [00:14:54] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701214 [00:15:21] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701214 (owner: 10Eileen) [00:17:31] (03PS1) 10Ejegg: PHPUnit fixes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/701215 [00:20:12] (03CR) 10jerkins-bot: [V: 04-1] PHPUnit fixes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/701215 (owner: 10Ejegg) [00:25:16] (03PS2) 10Ejegg: PHPUnit fixes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/701215 [00:25:46] !log civicrm revision changed from bd906975f0 to 6d3dd6e5a5, config revision is 821e5889f7 [00:25:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:33:09] fr-tech is anyone around to do a quick code review on PHPUnit fixes? https://gerrit.wikimedia.org/r/701215 [00:33:41] ejegg: sure! [00:36:21] (03CR) 10AndyRussG: [C: 03+2] "lgtm!!! :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/701215 (owner: 10Ejegg) [00:36:26] Thanks! [00:36:34] ejegg thank u :) [00:53:16] (03Merged) 10jenkins-bot: PHPUnit fixes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/701215 (owner: 10Ejegg) [01:09:06] (03PS3) 10Eileen: Name parse fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700721 (https://phabricator.wikimedia.org/T285269) [01:09:08] (03PS1) 10Eileen: Move test file to within phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701217 [01:19:40] (03CR) 10jerkins-bot: [V: 04-1] Move test file to within phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701217 (owner: 10Eileen) [01:28:43] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: document testing procedures for UI/UX testing and payments testing. - https://phabricator.wikimedia.org/T284467 (10DStrine) 05Resolved→03Open [01:29:18] (03PS2) 10Eileen: Move test file to within phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701217 [01:29:48] (03PS4) 10Eileen: Name parse fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700721 (https://phabricator.wikimedia.org/T285269) [01:39:23] (03CR) 10jerkins-bot: [V: 04-1] Move test file to within phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701217 (owner: 10Eileen) [01:40:48] (03CR) 10jerkins-bot: [V: 04-1] Name parse fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700721 (https://phabricator.wikimedia.org/T285269) (owner: 10Eileen) [02:11:42] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: document testing procedures for UI/UX testing and payments testing. - https://phabricator.wikimedia.org/T284467 (10XenoRyet) @DStrine The mentioned people have met, and I understand the level of testing th... [02:13:59] (03PS3) 10Cstone: WIP: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [02:15:01] (03PS4) 10Cstone: WIP: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [02:16:57] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 8 others: Some of our CI tests are not running - https://phabricator.wikimedia.org/T285446 (10Eileenmcnaughton) [02:17:29] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [02:18:52] (03PS3) 10Eileen: Move test file to within phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701217 [02:19:42] (03PS4) 10Eileen: Move test file to within phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701217 [02:21:49] (03PS1) 10Eileen: Move archive thank you test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701221 (https://phabricator.wikimedia.org/T285446) [02:24:23] (03PS5) 10Eileen: Name parse fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700721 (https://phabricator.wikimedia.org/T285269) [02:25:49] (03PS6) 10Eileen: Name parse fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700721 (https://phabricator.wikimedia.org/T285269) [02:26:09] (03CR) 10Ejegg: [C: 03+2] Move test file to within phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701217 (owner: 10Eileen) [02:26:43] thanks ejegg I found I couldn't move one of them & I think it's because those ci changes never got merged [02:29:03] ah, was that it? [02:30:02] well - the ArchiveThankYou test fails & it looks like it's because logging is enabled locally but not on the CI box [02:30:36] & I thought we had CI on the same upstream buildkit - but it seems not yet because the patch got stalled [02:32:09] (03CR) 10jerkins-bot: [V: 04-1] Move archive thank you test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701221 (https://phabricator.wikimedia.org/T285446) (owner: 10Eileen) [02:32:46] (03PS7) 10Eileen: Name parse fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700721 (https://phabricator.wikimedia.org/T285269) [02:33:30] anyway - the NameParse test is running now & we've proved we can see it fail so time to make it pass - I think I can see the difference between the 2 scenarios - so [02:34:06] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Access to delete contributions from civi - Engage - https://phabricator.wikimedia.org/T285319 (10Eileenmcnaughton) 05Open→03Resolved thanks for confirming! [02:35:56] (03Merged) 10jenkins-bot: Move test file to within phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701217 (owner: 10Eileen) [02:44:33] (03CR) 10Ejegg: [C: 03+2] "OK, this looks good locally. I've gotta say these API actions are a real snap to test out - tossing a bunch of random inputs at 'em via co" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700721 (https://phabricator.wikimedia.org/T285269) (owner: 10Eileen) [02:44:54] k, gonna hang it up for the night. see ya eileen! [02:45:10] night ejegg - thanks for doing that last merge [02:54:30] (03Merged) 10jenkins-bot: Name parse fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700721 (https://phabricator.wikimedia.org/T285269) (owner: 10Eileen) [03:26:34] !log civicrm revision is 6d3dd6e5a5, config revision is 1e8e9ac7b9 [03:26:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:29:24] 10fundraising-tech-ops, 10Patch-For-Review: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (10Dwisehaupt) civicrm and civi_read db users have been set to require ssl after the completion of steps in T280080. Tested and working in production. [03:44:23] (03PS1) 10Eileen: Wip on fix db ssl > > This is in theory what we need to do but I haven't tested [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701224 [03:51:16] (03PS2) 10Eileen: Wip on fix db ssl [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701224 (https://phabricator.wikimedia.org/T280080) [03:57:51] !log civicrm revision is 6d3dd6e5a5, config revision is 735af27f0d [03:57:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:58:23] 10Fundraising Sprint Interstitial ads halfway down the coaster hill, 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10fundraising sprint Just in time roller coaster building, and 2 others: Enable SSL for CiviCRM DB connections - https://phabricator.wikimedia.org/T280080 (10Eileenmcnaughton... [07:07:53] (03PS1) 10Eileen: Add handling for extension tables without id [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/701330 (https://phabricator.wikimedia.org/T285359) [07:13:02] (03PS3) 10Eileen: Remove instance of db_switcher [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701224 (https://phabricator.wikimedia.org/T280080) [07:30:06] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-AutoTY-Email, and 2 others: Monthly convert email translation suggestion (Japanese translation) - https://phabricator.wikimedia.org/T283748 (10Eileenmcnaughton) The above patch went out in today's de... [07:32:58] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701334 [07:34:19] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701334 (owner: 10Eileen) [07:35:29] !log civicrm revision changed from 6d3dd6e5a5 to 9d1203fb28, config revision is 735af27f0d [07:35:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [07:36:06] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Fidelity import issue - same last name couples - https://phabricator.wikimedia.org/T285269 (10Eileenmcnaughton) @MDemosWMF we should be picking up more of these correctly now [09:09:32] (03CR) 10AndyRussG: "Thanks so much for this @Ottomata!!!!! The test failure seems to be due to T285449/T277728. Seems easy to fix. Once that's done, I can reb" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/699787 (https://phabricator.wikimedia.org/T271168) (owner: 10Ottomata) [10:45:56] 10Fundraising-Backlog, 10fundraising-tech-ops: User needs Terminal access to Fredge - https://phabricator.wikimedia.org/T283871 (10RKumar_WMF) Hi, Thank you for your email. I am afraid I do not see any USB-c port in my laptop. I am attaching a picture of all the ports for reference. [image: WhatsApp Image 20... [13:54:11] (03CR) 10Ottomata: "Thank you!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/699787 (https://phabricator.wikimedia.org/T271168) (owner: 10Ottomata) [15:01:23] 10Fundraising-Backlog, 10fr-donorservices: Ingenico status 190s question - https://phabricator.wikimedia.org/T283524 (10Ejegg) So in ja.json, we have now changed the description line for both one-time and monthly donations to 'donate@wikimedia.org'. Hopefully this will fix the problem for the Japan campaign.... [15:34:22] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-production-error: TypeError: Cannot read property 'key' of undefined - https://phabricator.wikimedia.org/T285482 (10DStrine) [15:35:14] 10Fundraising-Backlog, 10FR-AutoTY-Email: Edit to Thank You Email footer in 13 languages - https://phabricator.wikimedia.org/T285383 (10DStrine) [15:49:09] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10User-DannyS712, 10ci-test-error: Master tests failing for CentralNotice, "RuntimeException: Config accessed before it is set" - https://phabricator.wikimedia.org/T285449 (10AndyRussG) [15:54:21] 10Fundraising-Backlog: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10MBeat33) I checked in with @CDenes_WMF and we are doing a final coded proofing round. "We will hand off corrections to be implemented by fr-tech after all languages are proofed and... [15:59:55] (03PS1) 10AndyRussG: Remove non-injected accesss to ResourceLoaderModule::getConfig [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701404 (https://phabricator.wikimedia.org/T285449) [16:05:45] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Fidelity import issue - same last name couples - https://phabricator.wikimedia.org/T285269 (10MDemosWMF) @Eileenmcnaughton Awesome - I will keep an eye on it when I do the import next week. [16:23:12] 10Fundraising-Backlog, 10fundraising-tech-ops: User needs Terminal access to Fredge - https://phabricator.wikimedia.org/T283871 (10Dwisehaupt) I have updated the ITS request for the key to see if they can work on the return of the USB-C key and sourcing of one that will work. Hopefully they will have an update... [16:33:37] 10Fundraising-Backlog: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10CDenes_WMF) Hi @Eileenmcnaughton we're seeing that what's in production (atleast for PT) is still the old version of these emails. Can you please let us know when these new versions... [16:35:41] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices, 10Epic, 10FR-Email: Creating exceptions for when to send the recurring expiry/fail email - https://phabricator.wikimedia.org/T276959 (10CDenes_WMF) Hi @Eileenmcnaughton we're seeing that what's in production (atleast for PT) is still the old v... [16:39:03] 10Fundraising-Backlog, 10fundraising-tech-ops: Deactivating Engage User in Civi - https://phabricator.wikimedia.org/T285344 (10Dwisehaupt) [16:40:14] 10Fundraising-Backlog, 10fundraising-tech-ops: Deactivating Engage User in Civi - https://phabricator.wikimedia.org/T285344 (10Dwisehaupt) 05Open→03Resolved SSL client certificate has been revoked and change pushed out. CiviCRM account has been moved to blocked. [17:05:50] (03CR) 10Ejegg: [C: 03+2] "Yep, this looks like the new way to do it. Thanks for the fix, AndyRussG!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701404 (https://phabricator.wikimedia.org/T285449) (owner: 10AndyRussG) [17:10:53] (03Merged) 10jenkins-bot: Remove non-injected accesss to ResourceLoaderModule::getConfig [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701404 (https://phabricator.wikimedia.org/T285449) (owner: 10AndyRussG) [17:12:36] PROBLEM - check_puppetrun on civi2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/etc/vim/vimrc.local] [17:14:20] ejegg thanks!!! [17:17:36] RECOVERY - check_puppetrun on civi2001 is OK: OK: Puppet is currently enabled, last run 54 seconds ago with 0 failures [17:26:14] ty for the fix [17:38:17] (03CR) 10Krinkle: "I think this needs to be reverted. It is now bypassing the injected Config object, which is the opposite of what the error intended to enc" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701404 (https://phabricator.wikimedia.org/T285449) (owner: 10AndyRussG) [17:50:35] (03PS5) 10Cstone: WIP: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [17:53:36] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [17:54:58] (03PS6) 10Cstone: WIP: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [17:55:07] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: document testing procedures for UI/UX testing and payments testing. - https://phabricator.wikimedia.org/T284467 (10DStrine) 05Open→03Resolved [17:57:40] PROBLEM - check_puppetrun on frdata2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/etc/vim/vimrc.local] [17:57:48] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [18:02:20] PROBLEM - Host frdb2002 is DOWN: PING CRITICAL - Packet loss = 100% [18:02:40] RECOVERY - check_puppetrun on frdata2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [18:06:32] RECOVERY - Host frdb2002 is UP: PING OK - Packet loss = 0%, RTA = 30.25 ms [19:08:56] (03CR) 10DannyS712: "This change is ready for review." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701234 (https://phabricator.wikimedia.org/T255507) (owner: 10DannyS712) [19:26:55] (03CR) 10Jgleeson: [C: 03+2] "As discussed this looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700942 (owner: 10Ejegg) [19:27:20] (03CR) 10Jgleeson: [C: 03+2] "As discussed this is good to go!" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700944 (owner: 10Ejegg) [19:27:35] (03Merged) 10jenkins-bot: Create response inherits from Details response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/700942 (owner: 10Ejegg) [19:55:01] 10Fundraising-Backlog, 10fr-donorservices: Ingenico status 190s question - https://phabricator.wikimedia.org/T283524 (10MBeat33) Thank you @Ejegg I checked with Evelyn and we think it would be good to clear the others out as well. The status 190s we saw in 2018 did include other currencies and card types. If I... [20:03:08] 10Fundraising-Backlog, 10fr-donorservices: Ingenico status 190s question - https://phabricator.wikimedia.org/T283524 (10DStrine) 05Open→03Resolved [20:15:06] 10Fundraising-Backlog, 10fr-donorservices: Ingenico status 190s question - https://phabricator.wikimedia.org/T283524 (10DStrine) @MBeat33 yeah another task for that part would be good [20:39:16] thanks for the CS jgleeson ! [20:49:35] 10Fundraising-Backlog: Languages that need soft descriptor to be donate@wikimedia.org - https://phabricator.wikimedia.org/T285499 (10Cstone) [20:55:06] err, CR [21:18:33] Counter Strike ejegg ??!?!?! :) [21:18:52] heh, computer science? [21:20:32] culinary specialist [22:09:52] (03PS7) 10Cstone: WIP: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [22:12:40] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [22:14:45] (03PS8) 10Cstone: WIP: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [22:28:11] (03PS9) 10Cstone: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [22:30:26] (03CR) 10jerkins-bot: [V: 04-1] Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [22:31:22] (03PS10) 10Cstone: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [22:33:46] (03CR) 10jerkins-bot: [V: 04-1] Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [22:46:38] oops cstone I realize that result.formData being set to [] comes out truthy [23:01:31] cstone oh darn, we are going to need to somehow make ->requiresApproval false when the payment is iDEAL and the status is Authorized [23:02:14] because with the patch in its current state we're calling approvePayment (unnecessarily) [23:03:54] err, weird, the gateway_txn_id that comes back from the capture / approve call is actually different from the original one [23:04:16] but the adyen docs don't SAY they need a capture step for iDEAL [23:10:09] ok, so the approve response has a pspReference that doesn't show up in their console [23:10:30] while the details response has a pspReference that we CAN find [23:11:08] so I'm pretty sure we don't want to go into that elseif block on line 120 of the adyen checkout adapter [23:13:21] I guess we could have the details call take the payment method too? and then the status mapper has to take that into account