[01:54:17] (03CR) 10Ejegg: [C: 04-1] "Thanks for this work! There are a few things we'll need to tweak for everything to work just right, though some of those tweaks might be o" (037 comments) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [01:55:27] thanks for all that ejegg! I realize now that I'm back from food that I completely forgot to fix the queue stuff too [01:56:28] yw! yeah, there are a couple of things that we'll need to think about the best way forward on [01:57:06] I'll take a look at it again with fresh eyes tomorrow [02:01:14] (03CR) 10Ejegg: "This works! Just a couple suggestions on a function name and where to stage the payment_method" (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/698821 (https://phabricator.wikimedia.org/T282595) (owner: 10Cstone) [02:07:56] (03PS3) 10Ejegg: 3D secure staging cleanup [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700999 [02:08:50] (03PS3) 10Ejegg: Merge branch 'master' into adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701000 [02:23:17] (03CR) 10Ejegg: "Interesting - I can't seem to hit a breakpoint on that new return, though with or without this patch I see this in the debug output for a " [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/701330 (https://phabricator.wikimedia.org/T285359) (owner: 10Eileen) [02:28:52] (03CR) 10Ejegg: [C: 03+2] "OK, once I added the join and select conditions from that pull request I was able to hit that breakpoint. Does seem to make this case work" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/701330 (https://phabricator.wikimedia.org/T285359) (owner: 10Eileen) [02:30:07] (03PS2) 10Ejegg: Commit meaninful trigger changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700715 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [02:30:31] (03CR) 10Ejegg: [C: 03+2] "As discussed, we'll get rid of the now-deleted stray fields later" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700715 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [02:39:31] (03Merged) 10jenkins-bot: Add handling for extension tables without id [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/701330 (https://phabricator.wikimedia.org/T285359) (owner: 10Eileen) [02:40:36] (03Merged) 10jenkins-bot: Commit meaninful trigger changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/700715 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [12:24:21] (03PS4) 10Thiemo Kreuz (WMDE): Add unit test for CentralNotice::sanitizeSearchTerms [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/688951 [14:24:52] (03PS1) 10AndyRussG: Revert "Remove non-injected accesss to ResourceLoaderModule::getConfig" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701419 [14:26:13] (03CR) 10AndyRussG: "> Patch Set 1:" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701404 (https://phabricator.wikimedia.org/T285449) (owner: 10AndyRussG) [14:29:07] (03CR) 10jerkins-bot: [V: 04-1] Revert "Remove non-injected accesss to ResourceLoaderModule::getConfig" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701419 (owner: 10AndyRussG) [14:36:53] 10Fundraising-Backlog: Standardize remaining descriptors with non-Latin characters - https://phabricator.wikimedia.org/T285559 (10MBeat33) [15:50:28] AndyRussG: oh shoot, problem with the CN fix? [15:51:07] ahh, i see [15:51:39] so we need to fix the tests to be able to revert it? [15:51:44] 10Fundraising-Backlog: Languages that need soft descriptor to be donate@wikimedia.org - https://phabricator.wikimedia.org/T285499 (10DStrine) [15:51:46] 10Fundraising-Backlog: Standardize remaining descriptors with non-Latin characters - https://phabricator.wikimedia.org/T285559 (10DStrine) [15:52:05] (03CR) 10AndyRussG: [C: 03+2] "Cooool thx for this!!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/685069 (owner: 10Ejegg) [15:53:13] (03Merged) 10jenkins-bot: Document alternate provider config dir [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/685069 (owner: 10Ejegg) [15:53:53] (03CR) 10AndyRussG: [C: 03+2] "Yaaaay thanks for these details!! :)" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700999 (owner: 10Ejegg) [15:54:47] (03PS4) 10AndyRussG: 3D secure staging cleanup [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700999 (owner: 10Ejegg) [15:55:04] (03CR) 10AndyRussG: [C: 03+2] 3D secure staging cleanup [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700999 (owner: 10Ejegg) [15:57:16] thanks for all the CR! [16:00:48] (03CR) 10AndyRussG: [C: 03+2] "Wohoooo!!!" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701000 (owner: 10Ejegg) [16:00:55] that staging cleanup sorta depends on the gatewayType extends LogPrefixProvider patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/700998 [16:15:49] (03Merged) 10jenkins-bot: 3D secure staging cleanup [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700999 (owner: 10Ejegg) [16:38:54] (03PS1) 10AndyRussG: Merge branch 'master' into adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/701587 [16:41:11] fr-tech I tried to update the previous merge-to-master Gerrit change but Gerrit made it a new change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/701587 [16:41:57] ahhh ooops nope [16:42:06] ^ sorry that's a mistake one sec [16:42:17] (03Abandoned) 10AndyRussG: Merge branch 'master' into adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/701587 (owner: 10AndyRussG) [16:42:30] oh? looked OK to me [16:46:32] ejegg: Gerrit had it on the master branch [16:49:01] (03PS4) 10AndyRussG: Merge branch 'master' into adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701000 (owner: 10Ejegg) [16:53:48] ejegg: fr-tech: now it did go on top of the previous merge Gerrit change, on the adyen branch, but the diff looks suspect [16:53:50] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/701000/3..4 [16:54:02] (^ diff between previous and new patchset) [16:54:47] oh I guess some of that (for example removing adyen.api.php) could be because it's no longer a child of some of the new unmerged stuff [16:54:56] yah [16:55:24] ejegg: fr-tech: if it looks fine I guess you or someone else can +2 now and it should merge? [16:55:43] will do [16:56:31] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701000 (owner: 10Ejegg) [16:59:14] (03Merged) 10jenkins-bot: Merge branch 'master' into adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701000 (owner: 10Ejegg) [17:00:28] (03PS3) 10Ejegg: Adyen-specific donate API action [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700966 [17:00:30] (03PS2) 10Ejegg: GatewayType extends LogPrefixProvider [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700998 [17:00:51] ok, there are the remaining two patches rebased atop the merge ^^ [17:01:38] ejegg: cool beans, thanks!! :) [17:11:59] ejegg: fr-tech: you mentioned going over some of the other patches on a video call? or did you mean IRC? If anyone wants to work on a call, about 3 hours from now, so around 1pm Pacific, would work great for me [17:12:20] sure, let's put an impromptu tech talk on the schedule [17:12:27] sooner also possible if that's best for others, too [17:12:43] :) cool thx! [17:15:17] dwisehaupt: we don't have any PHP older than 7.3 in the cluster at this point, right? [17:15:27] we should not. [17:15:32] k, thanks [17:15:36] i'll double check for sure. [17:17:45] yeah. we are all 7.3 at this point. [17:17:57] thanks! [17:24:45] (03PS1) 10Ejegg: Update min PHP version + composer libs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/701596 [17:25:00] fr-tech ^^^ would be good to have to remove spurious IDE warnings [17:25:26] PHPStorm goes by the composer.json php version requirement when it warns of incompatible language features [17:34:02] (03PS2) 10Ejegg: Improve output triggers when logged to file [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/701180 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [17:40:33] (03CR) 10Ejegg: [C: 03+2] "Nicely sorted and readable! I notice the wmf_donor trigger drop statements were still at the bottom with the create statements, but I assu" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/701180 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [17:53:40] (03Merged) 10jenkins-bot: Improve output triggers when logged to file [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/701180 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [18:07:16] (03PS5) 10Cstone: Adding in ideal methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/698821 (https://phabricator.wikimedia.org/T282595) [18:13:03] (03CR) 10Ejegg: [C: 04-1] Add iDEAL. (031 comment) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [18:13:33] (just adding an extra comment on that DI patch, the SP one looks +2able after a smoke test!) [18:13:43] Thanks ejegg! [18:15:53] (03CR) 10Ejegg: [C: 03+2] "Cool, this works on my machine!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/698821 (https://phabricator.wikimedia.org/T282595) (owner: 10Cstone) [18:16:33] (03Merged) 10jenkins-bot: Adding in ideal methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/698821 (https://phabricator.wikimedia.org/T282595) (owner: 10Cstone) [18:16:44] (03PS2) 10Ejegg: Update min PHP version + composer libs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/701596 [18:17:45] so let's see, once we make sure those adyen create calls can support recurring, I'd say we're ready to tag a new version of SmashPig, no? [18:18:20] I'd like it if we can include that min PHP version bump too ^^ [18:18:37] so we can start throwing more type hints around [18:28:25] (03PS1) 10Ejegg: Fall back to hardcoded exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 [18:28:43] cstone ^^^ should get around the CAD import woes [18:31:04] oooh wait, that might be giving the inverse of the rates we need [18:32:03] yah yah, i need to invert that [18:32:46] (03PS2) 10Ejegg: Fall back to hardcoded exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 [18:33:19] heh, we might not have noticed that with CAD but for COP it would be a pretty big difference [18:36:18] (03PS1) 10Ejegg: Move ExchangeRatesException to own file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701605 [18:37:19] (03PS4) 10Ejegg: Alternate - fix regex [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699977 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [18:37:39] (03CR) 10Ejegg: [C: 03+2] "I like keeping the validation around to make sure we get good original_ fields!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699977 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [18:42:10] (03CR) 10Jgleeson: [C: 03+2] "Looks good to me. nice tidy up also!" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700966 (owner: 10Ejegg) [18:43:08] fr-tech I won't be able to make the recently scheduled adyen talk as it's 9pm for me. Could someone record it? thanks much [18:43:11] (03CR) 10jerkins-bot: [V: 04-1] Fall back to hardcoded exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 (owner: 10Ejegg) [18:44:31] (03Merged) 10jenkins-bot: Adyen-specific donate API action [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/700966 (owner: 10Ejegg) [18:47:54] (03CR) 10jerkins-bot: [V: 04-1] Move ExchangeRatesException to own file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701605 (owner: 10Ejegg) [18:48:16] (03Merged) 10jenkins-bot: Alternate - fix regex [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699977 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [18:48:21] dang, what triggered those test failures? [18:48:43] recently merged civi changes? [18:49:43] sure thing jgleeson ! [18:49:46] and thanksk for the CR [18:49:49] sksksk [18:51:06] (03CR) 10Ejegg: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 (owner: 10Ejegg) [18:52:35] so strange that https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/699977 passed gate+submit just minutes ago and the exchange rates thing wouldn't pass now [18:54:07] ejegg: https://phabricator.wikimedia.org/F34527392 [18:54:46] oho, nice, that's one less thing for us to worry about then! [18:55:00] we hope! [19:07:12] (03PS2) 10Ejegg: Move exchange rates classes to own files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701605 [19:08:28] fr-tech it looks like we can piggyback on the iOS team apple developer account [19:08:55] hopefully it'll be easy enough for those folks to add a sandbox env for us and we can get crackin [19:09:14] this now means we need to start on the smashpig side of applepay [19:09:49] so I'll start sniffing around that Monday or if other folks wanna take a round at and maybe pair on that work that would be great also! [19:10:03] have a good weekend fr-tech [19:10:19] so it looks like maybe the step where they ping us is 'Verify a merchant domain' here https://help.apple.com/developer-account/#/dev1731126fb [19:10:46] I was just about to close the laptop [19:11:03] sorry, no need to figure that out right now! [19:11:12] ejegg: yep. Adyen folks did say apple will ping us [19:11:23] i just srtarted typeing before your signoff [19:11:28] typing even [19:11:32] so if it's just a case of having an endpoint they can hit we might be good? [19:11:53] and we might not need any of the other stuff that's complicating things [19:12:02] yah i think maybe it's just serving that static file once to prove we own the domain [19:12:09] and then we can just point it wherever [19:12:13] although it does sound like a pointless step if it is just to ping an endpoint that we don't do anything with [19:12:44] oh I thought that zip file was just for live [19:12:52] do we need that for testing also? [19:13:01] * ejegg dunno [19:13:38] looks like we only need that for going live https://docs.adyen.com/payment-methods/apple-pay/web-component?tab=adyen-certificate-config_1#going-live [19:14:07] I'm also kinda confused how to point to the sandbox environment [19:14:14] s/confused/unsure [19:14:16] / [19:15:52] the api creds I can see in the payment request example all look adyen specific https://docs.adyen.com/payment-methods/apple-pay/web-component?tab=adyen-certificate-config_1#make-a-payment [19:16:30] I wonder if adyens docs are not 100% accurate for the adyen-cert use-case [19:16:40] (03PS1) 10Ejegg: Namespace for ExchangeRatesException [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701606 [19:16:50] either way, it looks like we can now add a sandbox environment [19:16:55] which is progress! [19:16:57] cool! [19:17:14] (03CR) 10jerkins-bot: [V: 04-1] Move exchange rates classes to own files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701605 (owner: 10Ejegg) [19:18:16] grr, what IS that? [19:18:36] is there an actual error there? [19:20:12] 10Fundraising-Backlog, 10Fr-CiviCRM-dedupe-FY2017/18, 10fr-donorservices: Civi: add bulk option for 'not a duplicate' in Find and Merge Duplicate Contacts - https://phabricator.wikimedia.org/T191118 (10MBeat33) 05Open→03Resolved a:03MBeat33 I checked with @SHust and she confirmed that this request is... [19:20:22] ejegg: I'm seeing a bunch of test errors [19:20:25] 20:17:06 1) BitpayFileTest::testImport [19:20:26] 20:17:06 Undefined index: id [19:20:38] and like 12 failures [19:20:53] right, but how the heck do they have to do with adding a fallback to hardcoded currency rates? [19:21:13] lessee if another patch failse [19:21:17] *fails [19:21:38] are tests passing for you locally? [19:21:51] heh, no, but for other reasons [19:22:04] (03PS3) 10Ejegg: Fall back to invoice ID to find refund parent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/674470 (https://phabricator.wikimedia.org/T277244) [19:22:20] lessee if that audit fix rebase fails the same way ^^^ [19:22:21] @_@ [19:22:32] i'm heading out [19:22:37] catch you next week o/ [19:22:40] have a good weekend! [19:29:29] (03CR) 10jerkins-bot: [V: 04-1] Namespace for ExchangeRatesException [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701606 (owner: 10Ejegg) [19:44:21] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog: turn on monthly convert for japan for the pretest on the 29th at 5pm pacific - https://phabricator.wikimedia.org/T285338 (10TSkaff) Hello! Per office hours & discussion w. Haley, let's turn on monthly convert on payments wiki for Japan on **Monda... [19:45:51] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog: turn on monthly convert for japan for the pretest on the 29th at 5pm pacific - https://phabricator.wikimedia.org/T285338 (10TSkaff) >>! In T285338#7178225, @TSkaff wrote: > Hello! Per office hours & discussion w. Haley, let's turn on monthly conv... [19:59:22] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Target-Smart: Data Pull: New FY2122 Donors - https://phabricator.wikimedia.org/T284784 (10LeanneS) @DStrine @Eileenmcnaughton I've just added the amended files to the same spot on the server - Fundraising... [20:01:03] fr-tech ejegg: running 5-10 min late here ahhh [20:15:32] sorry, me too! [20:20:35] (03PS3) 10Ejegg: Fall back to hardcoded exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 [20:20:37] (03PS3) 10Ejegg: Move exchange rates classes to own files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701605 [20:20:39] (03PS2) 10Ejegg: Namespace for ExchangeRatesException [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701606 [20:31:39] (03CR) 10jerkins-bot: [V: 04-1] Namespace for ExchangeRatesException [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701606 (owner: 10Ejegg) [20:32:08] (03CR) 10jerkins-bot: [V: 04-1] Fall back to hardcoded exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 (owner: 10Ejegg) [20:32:43] (03CR) 10jerkins-bot: [V: 04-1] Move exchange rates classes to own files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701605 (owner: 10Ejegg) [21:18:32] (03PS1) 10Cstone: Correctly normalize direct debit status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/701613 [21:22:33] PROBLEM - check_puppetrun on frmx1001 is CRITICAL: CRITICAL: Puppet has 6 failures. Last run 4 minutes ago with 6 failures. Failed resources (up to 3 shown): File[/etc/vim/vimrc.local],File[/usr/local/bin/package_update_check],File[/usr/local/bin/yubikey_otp_filter],File[/bin/nopeshell] [21:23:38] these hosts are being weird. they alert about puppet runs if i don't do a clean one after the reboot. [21:27:33] RECOVERY - check_puppetrun on frmx1001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [22:03:09] PROBLEM - Host frdb1002 is DOWN: PING CRITICAL - Packet loss = 100% [22:03:57] ^^^ frdb1002 is me. [22:33:39] RECOVERY - Host frdb1002 is UP: PING WARNING - Packet loss = 71%, RTA = 0.33 ms