[00:58:10] (03PS3) 10AndyRussG: Update CNChoiceDataResourceLoaderModuleTest [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701673 (https://phabricator.wikimedia.org/T285449) [01:03:12] (03PS12) 10AndyRussG: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [01:03:57] (03PS3) 10AndyRussG: Revert "Remove non-injected accesss to ResourceLoaderModule::getConfig" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701419 (https://phabricator.wikimedia.org/T285449) [01:04:05] (03PS4) 10AndyRussG: Finalize migration to Event Plaform for EL schemas [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/699787 (https://phabricator.wikimedia.org/T271168) (owner: 10Ottomata) [01:05:33] (03CR) 10jerkins-bot: [V: 04-1] Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [01:05:45] (03CR) 10AndyRussG: "Hi! Thanks so much for this!!! PS 11 and 12 are just rebases. (Made a small mistake resolving conflicts in PS 11, hence PS 12.)" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [01:51:05] (03PS13) 10AndyRussG: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [01:53:40] (03CR) 10jerkins-bot: [V: 04-1] Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [01:54:45] (03CR) 10AndyRussG: "(Same for PS 13...)" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [03:14:34] (03CR) 10AndyRussG: "Cool! I was able to get the bank selection and go all the way through to the mock rtbt page and then to the thank-you page!! :) :)" (031 comment) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [03:47:51] (03CR) 10AndyRussG: "Cool, seems fine, thanks for this!!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/701596 (owner: 10Ejegg) [03:57:13] (03Abandoned) 10Eileen: Remove source validation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/699976 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [07:03:55] (03CR) 10DannyS712: "Suggest combining this and the subsequent revert of the original patch into the same commit, to make it clearer that we are reverting the " [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701673 (https://phabricator.wikimedia.org/T285449) (owner: 10AndyRussG) [13:52:51] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: [FR Analytics]: Enable template processing - https://phabricator.wikimedia.org/T279292 (10Jgreen) 05Open→03Resolved @EYener As far as I know this task is done, but please reopen if templates are not working as expected. [14:38:44] hi fr-tech [14:38:49] hi jgleeson ! [14:39:13] howdy ejegg [14:40:08] ejegg: fr-tech jgleeson hi! [14:47:30] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 9 others: Some of our CI tests are not running - https://phabricator.wikimedia.org/T285446 (10jgleeson) @Eileenmcnaughton I spoke... [15:07:33] 10Fundraising-Backlog: Set up Adyen Apple pay test environment - https://phabricator.wikimedia.org/T285683 (10jgleeson) [15:09:01] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10FR-Adyen: Set up Adyen Apple pay test environment - https://phabricator.wikimedia.org/T285683 (10jgleeson) [15:09:26] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10FR-Adyen: Set up Adyen Apple pay test environment - https://phabricator.wikimedia.org/T285683 (10jgleeson) a:03jgleeson [15:59:01] (03PS4) 10Jgleeson: WIP Adyen Checkout: Applepay [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699402 (https://phabricator.wikimedia.org/T282596) [16:02:45] (03CR) 10jerkins-bot: [V: 04-1] WIP Adyen Checkout: Applepay [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699402 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [16:40:05] 10fundraising-tech-ops: Fundraising access request for JESSICA JAMES-HILL - https://phabricator.wikimedia.org/T284712 (10Dwisehaupt) [16:40:31] 10fundraising-tech-ops: Fundraising access request for JESSICA JAMES-HILL - https://phabricator.wikimedia.org/T284712 (10Dwisehaupt) 05Open→03Resolved [19:14:59] (03CR) 10AndyRussG: "> Patch Set 3:" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701673 (https://phabricator.wikimedia.org/T285449) (owner: 10AndyRussG) [19:16:56] (03PS4) 10AndyRussG: Revert "Remove non-injected accesss to ResourceLoaderModule::getConfig" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701419 (https://phabricator.wikimedia.org/T285449) [19:17:34] (03PS5) 10AndyRussG: Finalize migration to Event Plaform for EL schemas [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/699787 (https://phabricator.wikimedia.org/T271168) (owner: 10Ottomata) [19:20:37] (03CR) 10Clarakosi: [C: 03+2] Use WikiPage::doUserEditContent() instead of ::doEditContent() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701234 (https://phabricator.wikimedia.org/T255507) (owner: 10DannyS712) [19:24:56] (03Merged) 10jenkins-bot: Use WikiPage::doUserEditContent() instead of ::doEditContent() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701234 (https://phabricator.wikimedia.org/T255507) (owner: 10DannyS712) [19:47:49] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Fidelity import issue - same last name couples - https://phabricator.wikimedia.org/T285269 (10MDemosWMF) Hi @Eileenmcnaughton this fix is looking good on this weeks import! [20:03:09] !log payments-wiki revision is d9892207c1 [20:03:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:28:59] (03PS4) 10Ejegg: Update CNChoiceDataResourceLoaderModuleTest [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701673 (https://phabricator.wikimedia.org/T285449) (owner: 10AndyRussG) [20:29:16] (03CR) 10Ejegg: [C: 03+2] "Looks good, works locally!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701673 (https://phabricator.wikimedia.org/T285449) (owner: 10AndyRussG) [20:29:35] (03PS5) 10Ejegg: Revert "Remove non-injected accesss to ResourceLoaderModule::getConfig" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701419 (https://phabricator.wikimedia.org/T285449) (owner: 10AndyRussG) [20:33:14] (03Merged) 10jenkins-bot: Update CNChoiceDataResourceLoaderModuleTest [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701673 (https://phabricator.wikimedia.org/T285449) (owner: 10AndyRussG) [20:33:42] (03CR) 10Ejegg: [C: 03+2] Revert "Remove non-injected accesss to ResourceLoaderModule::getConfig" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701419 (https://phabricator.wikimedia.org/T285449) (owner: 10AndyRussG) [20:37:18] (03Merged) 10jenkins-bot: Revert "Remove non-injected accesss to ResourceLoaderModule::getConfig" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/701419 (https://phabricator.wikimedia.org/T285449) (owner: 10AndyRussG) [20:51:37] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog: turn on monthly convert for japan for the pretest on the 29th at 5pm pacific - https://phabricator.wikimedia.org/T285338 (10Cstone) This has been enabled [21:00:37] 10Fundraising-Backlog, 10FR-Adyen: Adyen Checkout: Pull donor contact from Apple Pay sheet - https://phabricator.wikimedia.org/T285722 (10Ejegg) [21:02:47] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, and 4 others: Handle Apple Pay submission in Adyen Components - https://phabricator.wikimedia.org/T282596 (10Ejegg) [21:23:55] (03PS1) 10Eileen: Submodule commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701981 [21:24:17] (03CR) 10Eileen: [C: 03+2] Submodule commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701981 (owner: 10Eileen) [21:34:01] (03Merged) 10jenkins-bot: Submodule commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701981 (owner: 10Eileen) [21:49:08] ejegg: dwisehaupt cstone I realised something I forgot to bring up in our meet - the monolog stuff - I deployed the last patch cstone approved & it is now logging to process-control when we do civi::log('wmf')->debug() or whatever but the issue is that it adds a timestamp & so does process control - it seems a bit of a pain to have it not add a timestamp for stdout logging but to add for all other forms [21:49:37] oh that's a bit ugly [21:49:48] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701983 [21:49:58] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701983 (owner: 10Eileen) [21:50:01] let's see, line formatters should be pretty flexible in monolog. lemme take a quick look [21:50:25] ejegg: yeah I'm just not sure if I can have one formatter for std out attached to the same processor [21:51:03] I'm assuming out process-control is adding the timestamps? [21:51:20] (03PS1) 10Eileen: Align verbosity with symfony [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701984 [21:51:29] yah, process-control does do that, i'm pretty sure [21:52:27] yeah I wondered if we needed it to if we have it coming from monolog [21:52:47] also see ^^ 701984 - I think might be an improvement [21:53:28] actually - I see that we are adding a line formatter for syslog handler specifically so it must be doable [21:55:38] (03CR) 10Ejegg: [C: 03+2] "Nice granularity!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701984 (owner: 10Eileen) [21:56:02] (03PS1) 10Eileen: Remove date from stdout [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701985 [21:56:15] I think ^^ will work but I need to test now [22:06:11] (03Merged) 10jenkins-bot: Align verbosity with symfony [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701984 (owner: 10Eileen) [22:07:37] (03PS2) 10Eileen: Remove date from stdout [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701985 [22:07:57] ok yeah I think 701985 will do the trick after testing [22:13:48] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog: turn on monthly convert for japan for the pretest on the 29th at 5pm pacific - https://phabricator.wikimedia.org/T285338 (10HNordeenWMF) thanks @cstone!! [22:28:30] !log civicrm revision changed from 9d1203fb28 to 927ab7cff7, config revision is 1739c53fcb [22:28:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:35:34] (03PS1) 10Eileen: Update triggers with shorter version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701986 (https://phabricator.wikimedia.org/T283561) [22:39:13] (03PS1) 10Eileen: Remove trailing white space [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701987 (https://phabricator.wikimedia.org/T283561) [22:39:51] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Source field not accepting negative amounts - https://phabricator.wikimedia.org/T284196 (10Eileenmcnaughton) this should be working now @LeanneS [22:55:39] (03PS1) 10Ejegg: Adyen Checkout: tuneForPaymentMethod suggestion [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701989 (https://phabricator.wikimedia.org/T282595) [22:58:13] (03CR) 10jerkins-bot: [V: 04-1] Adyen Checkout: tuneForPaymentMethod suggestion [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701989 (https://phabricator.wikimedia.org/T282595) (owner: 10Ejegg) [22:58:58] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Source field not accepting negative amounts - https://phabricator.wikimedia.org/T284196 (10LeanneS) Thanks @Eileenmcnaughton! I just tried it out and... [23:04:12] (03CR) 10Eileen: Update triggers with shorter version (033 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701986 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [23:04:42] if anyone can face trawling https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/701986 I've commented the things that don't follow the main pattern of just removing cruft [23:04:52] wheeee [23:05:13] heh, nice slimming down though! [23:05:15] +7 -5437 [23:05:35] oh right, mostly delimiter flipfloppery [23:08:04] i'm impressed that firefox can show the diff at all, but scrolling sure gets wonky - looking in meld [23:28:45] ejegg: yeah I had to take 2 breaks to get through my skim of it [23:42:17] (03PS1) 10Eileen: Switch our debug to 'notice' [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701994 [23:43:40] So there is a question about how we should work with Civi::log('wmf') - to keep the same level of logging we can either add -vv to every process control job that interacts with civi or start using Civi::log('wmf') ->notice() rather than Civi::log('wmf') ->info() - which is what ^^ does [23:44:49] I'm on the fence [23:52:29] (03PS1) 10Eileen: Add handling for comma thousand separator [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701996 (https://phabricator.wikimedia.org/T284196) [23:56:57] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Fidelity import issue - same last name couples - https://phabricator.wikimedia.org/T285269 (10Eileenmcnaughton) 05Open→03Resolved yay