[00:02:43] (03CR) 10Ejegg: [C: 03+2] "Does the trick!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701985 (owner: 10Eileen) [00:03:21] (03PS2) 10Ejegg: Update triggers with shorter version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701986 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [00:04:00] (03CR) 10Ejegg: [C: 03+2] "Looks good! Let's get the dev custom fields synced with prod again soon." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701986 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [00:13:13] (03Merged) 10jenkins-bot: Remove date from stdout [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701985 (owner: 10Eileen) [00:13:14] so was I imagining it, or is there a drush job to dump the prod fields to a nice list for dev sync? [00:13:44] (03Merged) 10jenkins-bot: Update triggers with shorter version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701986 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [00:13:46] (03PS2) 10Ejegg: Remove trailing white space [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701987 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [00:14:02] (03CR) 10Ejegg: [C: 03+2] "Triggers look good" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701987 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [00:15:02] (03PS2) 10Ejegg: Add handling for comma thousand separator [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701996 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [00:15:10] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701996 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [00:24:28] (03Merged) 10jenkins-bot: Remove trailing white space [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701987 (https://phabricator.wikimedia.org/T283561) (owner: 10Eileen) [00:26:15] (03Merged) 10jenkins-bot: Add handling for comma thousand separator [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701996 (https://phabricator.wikimedia.org/T284196) (owner: 10Eileen) [00:32:29] ejegg: you were imagining it [00:32:42] we've never been fully in sync - we've only got an ad hoc selection [00:33:50] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701997 [00:34:06] ejegg: did you see my comments further up about the log levels question [00:34:26] also on https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/701994/ [00:36:12] yep yep, just thinking about it myself [00:36:36] we do generally use 'info' in other codebases for 'normal'-ish output [00:38:58] yeah - I'm definitely undecided [00:42:59] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701997 (owner: 10Eileen) [01:12:58] (03CR) 10Eileen: [C: 03+2] "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/701997 (owner: 10Eileen) [01:27:42] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Target-Smart: Data Pull: New FY2122 Donors - https://phabricator.wikimedia.org/T284784 (10Eileenmcnaughton) I've split off the first 10 & am trying a UI import for them to check out the mappings - the UI... [01:57:08] (03CR) 10AndyRussG: [C: 03+2] Finalize migration to Event Plaform for EL schemas [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/699787 (https://phabricator.wikimedia.org/T271168) (owner: 10Ottomata) [01:59:19] (03PS1) 10AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702001 [01:59:31] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702001 (owner: 10AndyRussG) [02:00:24] (03CR) 10AndyRussG: "recheck" [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702001 (owner: 10AndyRussG) [02:04:09] (03CR) 10DannyS712: "CR-1" (031 comment) [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702001 (owner: 10AndyRussG) [02:05:29] (03CR) 10AndyRussG: Merge branch 'master' into wmf_deploy (031 comment) [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702001 (owner: 10AndyRussG) [02:10:42] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Target-Smart: Data Pull: New FY2122 Donors - https://phabricator.wikimedia.org/T284784 (10Eileenmcnaughton) @LeanneS - I just imported the first 9 rows using import https://civicrm.wikimedia.org/civicrm... [02:11:51] (03CR) 10AndyRussG: "@DannyS712 thanks so much for catching that. My bad. (More details inline.) I'll check with releng on how to remedy." (031 comment) [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702001 (owner: 10AndyRussG) [02:21:59] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Target-Smart: Data Pull: New FY2122 Donors - https://phabricator.wikimedia.org/T284784 (10Eileenmcnaughton) Ok we don't use supplemental_address_3 so that part is fine. For some reason we filled up the d... [02:25:50] !log civicrm revision changed from 927ab7cff7 to 789c92d13b, config revision is 1739c53fcb [02:25:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:27:38] 10Fundraising-Backlog: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10Eileenmcnaughton) @CDenes_WMF sure - this isn't actually in the sprint at the moment - @DStrine can let you know on that side of things [02:34:19] (03PS1) 10AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702004 [02:38:12] (03CR) 10AndyRussG: "Follow-on to at least start mopping up the mess I made: I3338a0f5e4" [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702001 (owner: 10AndyRussG) [02:42:46] (03CR) 10AndyRussG: [C: 03+2] "Gonna self +2 here, as is standard for merges to wmf_deploy, to hopefully speed up fixing the mistake of the previous merge commit." [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702004 (owner: 10AndyRussG) [02:45:13] thanks for handling that deploy AndyRussG ! [02:45:28] ejegg: aargh I messed it up eh [02:45:46] it slipped my mind until 4 minutes before the branch cut [02:45:51] see the above patches for details [02:45:55] looks like you're fixing it though... [02:46:04] just an incomplete merge I guess? [02:46:21] ejegg: I forgot to update master locally before saying merge master [02:46:31] ah shoot [02:46:35] yep, that happens [02:46:36] also the EventLogging one didn't even make it into the cleanup merge [02:46:43] oh hah [02:46:56] but we can add that one at least as a backport [02:47:32] however I would like to get the fixed up merge to go onto the train, but I don't know if releng is willing to do that these days, since the whole branch cut thing got automated [02:48:01] oh darn, i would hope so [02:48:29] yeah since the incorrect fix to the RL injection thing--the one we then reverted--does touch production code [02:48:46] basically no likelyhood of damage anywhere, I think, but still less than ideal [02:49:45] anyway I guess we'll see what releng says, and also hugely appreciate the help of the volunteer (Dannys712, apparently not here on this channel) who caught the mistake [02:57:40] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702004 (owner: 10AndyRussG) [02:59:45] (03CR) 10AndyRussG: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/699787 (https://phabricator.wikimedia.org/T271168) (owner: 10Ottomata) [03:06:33] (03CR) 10AndyRussG: [C: 03+2] Finalize migration to Event Plaform for EL schemas [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/699787 (https://phabricator.wikimedia.org/T271168) (owner: 10Ottomata) [03:19:56] ejegg: thanks for the support, moral and otherwise, btw! [03:20:21] cheering for ya, man! [03:20:53] ejegg: awwww thx :) [03:21:50] if you like next you can help motivate Sofi to study for the re-take of her Chemistry exam heh.... ;p [03:22:16] oh jeez, i wore myself out trying to motivate Tavi to go to sleep [03:23:50] awww ok no worries, you're off the hook then :) [03:27:44] 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Create unit tests for Adyen Checkout - https://phabricator.wikimedia.org/T285734 (10Ejegg) [03:28:41] (03PS1) 10Ejegg: WIP tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) [03:31:13] (03CR) 10jerkins-bot: [V: 04-1] WIP tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) (owner: 10Ejegg) [03:38:51] (03PS6) 10AndyRussG: Finalize migration to Event Plaform for EL schemas [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/699787 (https://phabricator.wikimedia.org/T271168) (owner: 10Ottomata) [03:39:10] (03CR) 10AndyRussG: [C: 03+2] Finalize migration to Event Plaform for EL schemas [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/699787 (https://phabricator.wikimedia.org/T271168) (owner: 10Ottomata) [03:55:54] (03Merged) 10jenkins-bot: Finalize migration to Event Plaform for EL schemas [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/699787 (https://phabricator.wikimedia.org/T271168) (owner: 10Ottomata) [04:46:13] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog: make acoustic mail data searchable through search kit - https://phabricator.wikimedia.org/T285359 (10Eileenmcnaughton) @EYener I deployed a change to staging and to live that addressed the issue you identified. I need to do some more work on upst... [04:47:09] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog: make acoustic mail data searchable through search kit - https://phabricator.wikimedia.org/T285359 (10Eileenmcnaughton) (back in doing for the upstreaming I need to do - ref https://github.com/civicrm/civicrm-core/pull/20707 [13:24:45] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Target-Smart: Data Pull: New FY2122 Donors - https://phabricator.wikimedia.org/T284784 (10EYener) Just a note as I saw this pop up - can we change the task title to `New FY2021 Donors` to avoid confusion?... [15:11:37] PROBLEM - check_puppetrun on fran1001 is CRITICAL: CRITICAL: Puppet has 6 failures. Last run 3 minutes ago with 6 failures. Failed resources (up to 3 shown): File[/etc/vim/vimrc.local],File[/usr/local/bin/package_update_check],File[/usr/local/bin/yubikey_otp_filter],File[/bin/nopeshell] [15:12:22] 10Fundraising-Backlog: Add search criteria to show Merchant Reference number in Civi - https://phabricator.wikimedia.org/T285770 (10RKumar_WMF) [15:13:05] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add search criteria to show Merchant Reference number in Civi - https://phabricator.wikimedia.org/T285770 (10DStrine) [15:14:04] 10Fundraising-Backlog, 10FR-AutoTY-Email: Languages that need soft descriptor to be donate@wikimedia.org - https://phabricator.wikimedia.org/T285499 (10DStrine) [15:14:19] 10Fundraising-Backlog, 10FR-AutoTY-Email: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10DStrine) [15:16:37] RECOVERY - check_puppetrun on fran1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [15:29:11] 10Wikimedia-Fundraising-Banners: [Dsk Lg] RML Popup stays active on scroll blocking Donate buttons in nag - https://phabricator.wikimedia.org/T285772 (10jbolorinos-ctr) [15:40:41] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog: make acoustic mail data searchable through search kit - https://phabricator.wikimedia.org/T285359 (10EYener) @Eileenmcnaughton thanks! This is working in dev but not in prod. Here is the same searchkit reproduced [[ https://civicrm.wikimedia.org/... [15:52:21] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Target-Smart: Data Pull: New FY2021 Donors - https://phabricator.wikimedia.org/T284784 (10LeanneS) [15:54:15] (03PS1) 10Jgleeson: WIP Applepay Payment Provider [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702149 (https://phabricator.wikimedia.org/T282596) [15:54:48] (03CR) 10jerkins-bot: [V: 04-1] WIP Applepay Payment Provider [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702149 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [15:56:05] (03PS2) 10Jgleeson: WIP Applepay Payment Provider [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702149 (https://phabricator.wikimedia.org/T282596) [15:56:36] (03CR) 10jerkins-bot: [V: 04-1] WIP Applepay Payment Provider [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702149 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [15:58:12] (03PS5) 10Jgleeson: WIP Adyen Checkout: Applepay [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699402 (https://phabricator.wikimedia.org/T282596) [16:01:23] (03CR) 10jerkins-bot: [V: 04-1] WIP Adyen Checkout: Applepay [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699402 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [16:02:35] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Target-Smart: Data Pull: New FY2021 Donors - https://phabricator.wikimedia.org/T284784 (10LeanneS) @Eileenmcnaughton Thank you! I'm around my afternoon/your morning to review together. I'll put some time... [16:04:23] (03PS1) 10Brennen Bearnes: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf/1.37.0-wmf.12) - 10https://gerrit.wikimedia.org/r/702166 [16:04:27] (03PS2) 10Ejegg: WIP tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) [16:04:59] (03CR) 10Brennen Bearnes: [C: 03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf/1.37.0-wmf.12) - 10https://gerrit.wikimedia.org/r/702166 (owner: 10Brennen Bearnes) [16:09:29] (03PS1) 10AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702151 [16:10:14] (03CR) 10jerkins-bot: [V: 04-1] WIP tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) (owner: 10Ejegg) [16:10:16] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf/1.37.0-wmf.12) - 10https://gerrit.wikimedia.org/r/702166 (owner: 10Brennen Bearnes) [16:10:23] (03CR) 10AndyRussG: [C: 03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702151 (owner: 10AndyRussG) [16:12:18] (03PS1) 10Brennen Bearnes: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf/1.37.0-wmf.12) - 10https://gerrit.wikimedia.org/r/702167 [16:14:58] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/702151 (owner: 10AndyRussG) [16:18:05] ^ my deploy mistakes from yesterday fixed thankfully [16:28:09] (03CR) 10Brennen Bearnes: [C: 03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf/1.37.0-wmf.12) - 10https://gerrit.wikimedia.org/r/702167 (owner: 10Brennen Bearnes) [16:36:22] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10MDemosWMF) @Eileenmcnaughton I just spoke with @RLewis... [16:37:13] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf/1.37.0-wmf.12) - 10https://gerrit.wikimedia.org/r/702167 (owner: 10Brennen Bearnes) [16:43:25] (03PS1) 10Ejegg: Adyen RTBT: Add RedirectShopper status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702156 (https://phabricator.wikimedia.org/T282595) [16:44:07] (03PS2) 10Ejegg: Adyen RTBT: Add RedirectShopper status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702156 (https://phabricator.wikimedia.org/T282595) [16:44:24] cstone: another little iDEAL status fix for the SmashPig layer ^^^ [16:44:47] found it while writing unit tests for the DonationInterface layer [16:44:52] already paying off! [16:45:37] nice ejegg [16:49:30] question ejegg on the isFailed part we added on Friday it's not making it to the front end apparently because its a boolean , does that make any sense? I haven't looked into the MW code thats in between yet [16:50:05] oh weird [16:51:32] hmm, I'm not seeing that in the code any more [16:51:39] did it get lost in the rebase cstone? [16:51:53] oh i didn't push it up cause it wasn't working lemme do it now [16:54:48] (03PS14) 10Cstone: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [16:55:00] (03CR) 10jerkins-bot: [V: 04-1] Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [16:55:26] ah bah now i messed up the rebase haha [16:55:52] oh darn [16:57:30] Ok, so it feels like maybe we should add both 'isFailed' and 'isComplete' to the thing that goes back to the JS [16:57:44] and the JS should be able to look up the fail and the TY pages in mw.config [16:58:09] that way we can save the redirect and formData properties so that they're strictly used for redirecting to the processor [16:58:19] oh hey, lunch time. back in a bit [17:02:10] (03PS15) 10Cstone: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [17:21:34] PROBLEM - check_puppetrun on pay-lvs2001 is CRITICAL: CRITICAL: Puppet has 9 failures. Last run 5 minutes ago with 9 failures. Failed resources (up to 3 shown): File[/etc/vim/vimrc.local],File[/usr/local/bin/package_update_check],File[/usr/local/bin/yubikey_otp_filter],File[/bin/nopeshell] [17:26:24] ^^^^ is known. testing puppet failures after reboot. [17:26:34] PROBLEM - check_puppetrun on pay-lvs2001 is CRITICAL: CRITICAL: Puppet has 9 failures. Last run 10 minutes ago with 9 failures. Failed resources (up to 3 shown): File[/etc/vim/vimrc.local],File[/usr/local/bin/package_update_check],File[/usr/local/bin/yubikey_otp_filter],File[/bin/nopeshell] [17:31:34] PROBLEM - check_puppetrun on pay-lvs2001 is CRITICAL: CRITICAL: Puppet has 9 failures. Last run 15 minutes ago with 9 failures. Failed resources (up to 3 shown): File[/etc/vim/vimrc.local],File[/usr/local/bin/package_update_check],File[/usr/local/bin/yubikey_otp_filter],File[/bin/nopeshell] [17:36:34] RECOVERY - check_puppetrun on pay-lvs2001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [18:15:38] how was the game, jgleeson ? [18:33:14] (03CR) 10Ejegg: [C: 03+2] Add iDEAL. (033 comments) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [18:33:24] oops [18:33:33] sorry, clicked in the wrong place [18:34:43] (03CR) 10Ejegg: [C: 04-1] "Looks like progress! We'll need to add that issuer_id to the api parameters over in adyen.api.php" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [18:34:54] hey ejegg, it was a tense game! After 75 minutes of stubborn defending England broke through with two late goals to seal the victory! [18:35:21] exciting! [18:38:18] England will face the winner of the Sweden v Ukraine game later tonight, in the quarter final on Saturday [18:38:39] Switzerland knocked out world #2 France last night on penalties [18:38:57] been a pretty entertaining tournament so far [18:42:15] right on. There's a south american tournament going on too, but Colombia have been doing pretty poorly [18:44:16] cstone ok, yeah, i guess i see where the boolean result is being stripped out of the ApiResult [18:44:41] so we need to add isFailed to the boolKeys array somehow [18:44:59] i was just debugging through its there through the whole addValue [18:45:02] ah okay where is that? [18:49:00] oh yeah ejegg I've been following the Copa America also although the kick-off times tend to be in the middle of the night :) [18:49:04] for me at least [18:49:56] Looks like Colombia have a big game against Uruguay on Saturday [18:50:10] 11pm my time, I might catch that one! [18:50:42] ok back to Apple [18:51:06] I've been distracted a little with the 'Foundation consultant' email [19:03:23] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, and 4 others: Handle Apple Pay submission in Adyen Components - https://phabricator.wikimedia.org/T282596 (10jgleeson) [19:03:27] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10FR-Adyen: Set up Adyen Apple pay test environment - https://phabricator.wikimedia.org/T285683 (10jgleeson) [19:09:26] cstone sorry got called away for baby help. I'm looking through ApiResult::applyTransformations [19:11:05] it's a little tricky to see how they set that metadata [19:14:33] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10MDemosWMF) @Eileenmcnaughton I just spoke with @LeanneS... [19:16:12] maybe using ApiResult->setPreserveKeysList ? [19:22:05] huh, that didn't do it [19:22:21] maybe needs a different 'path' ? [19:27:02] oh jeez, i found the way to fix it, and it's just wierd and dumb [19:27:15] will put up a patch to illustrate [19:27:54] (03PS1) 10Ejegg: Preserve 'isFailed' in api result even if false [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702216 [19:28:07] cstone feel free to just copy that into your patch ^^^ [19:28:35] huh thanks ejegg [19:28:43] that is weird [19:29:59] woo i see it! [20:06:18] lemme add a comment on that patch since it's so weird [20:07:57] (03PS2) 10Ejegg: Preserve 'isFailed' in api result even if false [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702216 [20:08:29] thanks ejegg [20:08:44] im going to go get some paddleboard time before these thunderstorms roll through ill be back in a bit [20:09:02] k, i'll keep plugging on the unit tests [21:30:15] (03PS16) 10Cstone: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [21:31:49] ejegg ^ thats more of a WIP again but I rearranged handleApiResult [21:31:56] cool cool [21:35:23] broke something cc related [21:35:28] lets see [21:37:51] i think that if (result.formData) has to be checked first cstone [21:40:13] ok yeah its not working how I thought it was working [21:42:28] so the 3ds has a redirect result but also something in form data that needs to send that 2nd api call? [21:42:39] yep yep [22:09:43] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Target-Smart: Data Pull: New FY2021 Donors - https://phabricator.wikimedia.org/T284784 (10LeanneS) @Eileenmcnaughton Also want to note that in the past we've needed to use null or something of the sort to... [23:06:08] (03PS2) 10Ejegg: Adyen Checkout: tuneForPaymentMethod suggestion [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701989 (https://phabricator.wikimedia.org/T282595) [23:06:10] (03PS3) 10Ejegg: WIP tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) [23:06:12] (03PS1) 10Ejegg: Adyen checkout suggestion for fail page [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702243 [23:06:23] ok cstone it's that last one ^^^ [23:06:27] thanks ejegg !! [23:06:32] yw! [23:08:51] (03CR) 10jerkins-bot: [V: 04-1] Adyen checkout suggestion for fail page [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702243 (owner: 10Ejegg) [23:08:57] (03CR) 10jerkins-bot: [V: 04-1] WIP tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) (owner: 10Ejegg)