[00:07:26] 10Fundraising-Backlog, 10FR-Ingenico: Ingenico new API key as of Jul 8, 2021 - https://phabricator.wikimedia.org/T282294 (10Ejegg) "Pre-Production" means that any error would be on our developer machines, not on payments-wiki. [00:11:05] (03PS1) 10Ejegg: Adyen Checkout: rewrite capture as REST call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702491 (https://phabricator.wikimedia.org/T282302) [00:14:09] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Just in time roller coaster building, and 4 others: Adyen: try to capture an old-style recurring with rest API - https://phabricator.wikimedia.org/T282302 (10Ejegg) a:03Ejegg Cod... [00:16:43] (03Abandoned) 10Ejegg: Adyen checkout suggestion for fail page [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702243 (owner: 10Ejegg) [00:17:45] (03Abandoned) 10Ejegg: Preserve 'isFailed' in api result even if false [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702216 (owner: 10Ejegg) [00:25:31] (03CR) 10Ejegg: "Just took a quick peek - haven't been able to look in Safari yet. Request to change our normalized payment method code to 'apple'" (032 comments) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699402 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [00:36:39] 10Fundraising-Backlog, 10FR-Ingenico: Ingenico new API key as of Jul 8, 2021 - https://phabricator.wikimedia.org/T282294 (10EMartin) sure. i wasn't sure how that impacted things [01:34:17] (03PS19) 10Cstone: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [01:41:32] (03CR) 10Ejegg: Add iDEAL. (031 comment) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [01:47:53] (03PS20) 10Cstone: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [01:50:32] (03CR) 10jerkins-bot: [V: 04-1] Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [01:51:51] (03PS21) 10Cstone: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 [01:54:41] (03CR) 10Ejegg: [C: 03+2] "Ship it!" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [01:55:00] nice cstone. Will rebase my tuneForPaymentMethod patch [01:55:28] niceee the continue button is still there as a last thing to get rid of but that has to be some simple thing [01:56:14] thanks for all the help [01:57:00] (03PS4) 10Ejegg: Adyen Checkout: tuneForPaymentMethod [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701989 (https://phabricator.wikimedia.org/T282595) [01:57:02] (03PS6) 10Ejegg: WIP tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) [01:57:04] (03Merged) 10jenkins-bot: Add iDEAL. [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699069 (owner: 10Cstone) [01:57:11] yw [01:57:41] that tuneForPaymentMethod is probs ready for some quick CR if you have a moment [01:57:49] sure [01:59:20] (03CR) 10jerkins-bot: [V: 04-1] WIP tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) (owner: 10Ejegg) [01:59:43] expected, though the first 3 are actually passing ^^^ [02:00:17] i just left a couple copypasted ones in there as placeholders to remind me what cases to test [02:05:20] (03CR) 10Cstone: [C: 03+2] "Looks good! All three working!" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701989 (https://phabricator.wikimedia.org/T282595) (owner: 10Ejegg) [02:05:34] nice ejegg [02:07:14] thanks! [02:07:30] oh phooey, just found another issue with the risk scorer [02:07:49] im gona have to run have a good evening ejegg [02:08:02] k, see ya! [02:08:04] (03Merged) 10jenkins-bot: Adyen Checkout: tuneForPaymentMethod [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/701989 (https://phabricator.wikimedia.org/T282595) (owner: 10Ejegg) [02:15:44] Hello. I entered through https://www.mediawiki.org/wiki/Extension:CentralNotice#Getting_help. I'm having problems installing CentralNotice, can you help? [02:18:08] shoot, we're kind of pressed for time at the moment, and i'm already up late as it is. That can be a bit of a tricky extension to install + troubleshoot. We usually suggest siteNotice for anything smaller than a giant wiki farm: https://www.mediawiki.org/wiki/Manual:Interface/Sitenotice [02:18:50] or the dismissable version for a slightly better user experience: https://www.mediawiki.org/wiki/Extension:DismissableSiteNotice [02:19:59] (03PS1) 10Ejegg: Adyen Checkout: more RiskScorer fix [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702495 (https://phabricator.wikimedia.org/T282641) [02:22:05] Already I am using sitenotice with the DismissableSiteNotice extension. However, I am not a giant wiki farm, but I am running a small wiki farm, and sitenotice can't make announcements for all wikis in the wiki farm, so I installed centralnotice extension. [02:22:28] ah, ok, so it's an appropriate use case :) [02:24:43] The problem I'm having is that the banner doesn't show up on the wiki even with the ?force=1 parameter. Example: https://www.lwiki.net/w/index.php?title=%EB%8C%80%EB%AC%B8&banner=test2&force=1&preview=1&uselang=en [02:24:54] unfortunately this team is under a lot of pressure to finish a project right now [02:28:55] The team is very busy right now, so it's hard to help? [02:29:28] yes, that's it. We are trying to hire more people! [02:38:13] (03PS7) 10Ejegg: WIP tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) [02:40:26] Guest5: I do see a DependencyError in the JS console on that link - perhaps you need to install another extension (EventLogging) to get CentralNotice to work: https://www.mediawiki.org/wiki/Extension:EventLogging [02:40:28] (03CR) 10jerkins-bot: [V: 04-1] WIP tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) (owner: 10Ejegg) [02:40:33] 10Fundraising-Backlog: Check and improve procedures and doc about code review, testing and linting of banner JS - https://phabricator.wikimedia.org/T214412 (10Seddon) a:05Seddon→03None [02:40:49] ok, I have to go to bed [02:42:04] 10Fundraising-Backlog, 10Wikimedia-CentralNotice-Administration: CentralNotice banner display issues - https://phabricator.wikimedia.org/T236782 (10Seddon) a:05Seddon→03None [02:54:28] @ejegg Installing the EventLogging extension solved the problem. Thanks for your help. [02:56:27] Guest5: you're welcome! i'm glad to hear it worked [02:57:52] (03PS1) 10Eileen: Fix enotice when running during setup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702497 [02:59:41] (03PS1) 10Eileen: Use same address setting on dev sites as live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702498 (https://phabricator.wikimedia.org/T284784) [03:01:08] (03PS1) 10Eileen: Update our custom field create to use preferred action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702499 (https://phabricator.wikimedia.org/T284784) [03:08:58] (03CR) 10jerkins-bot: [V: 04-1] Fix enotice when running during setup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702497 (owner: 10Eileen) [03:10:54] (03PS2) 10Eileen: Use same address setting on dev sites as live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702498 (https://phabricator.wikimedia.org/T284784) [03:10:56] (03CR) 10jerkins-bot: [V: 04-1] Use same address setting on dev sites as live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702498 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [03:12:01] (03CR) 10jerkins-bot: [V: 04-1] Update our custom field create to use preferred action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702499 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [03:27:24] (03CR) 10jerkins-bot: [V: 04-1] Use same address setting on dev sites as live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702498 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [07:32:22] (03PS2) 10Eileen: Update our custom field create to use preferred action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702499 (https://phabricator.wikimedia.org/T284784) [07:32:24] (03PS1) 10Eileen: Fix custom field create to correctly create option_values [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702582 (https://phabricator.wikimedia.org/T284784) [07:33:00] (03PS2) 10Eileen: Fix custom field create to correctly create option_values [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702582 (https://phabricator.wikimedia.org/T284784) [07:36:53] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Target-Smart, 10Patch-For-Review: Data Pull: New FY2021 Donors - https://phabricator.wikimedia.org/T284784 (10Eileenmcnaughton) I tried to run this today but hit an issue ` drush @wmff cvapi TargetSmart... [07:40:30] (03PS1) 10Eileen: Update targetsmart references for 2021 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702583 (https://phabricator.wikimedia.org/T284784) [07:43:30] (03CR) 10jerkins-bot: [V: 04-1] Fix custom field create to correctly create option_values [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702582 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [07:43:54] (03CR) 10jerkins-bot: [V: 04-1] Fix custom field create to correctly create option_values [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702582 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [07:45:30] (03PS1) 10Eileen: Why is jenkins being weird? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702586 [07:48:33] (03PS1) 10Eileen: Add new dev field to support targetsmart testing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702587 (https://phabricator.wikimedia.org/T284784) [07:51:52] (03CR) 10jerkins-bot: [V: 04-1] Update targetsmart references for 2021 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702583 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [07:55:31] (03CR) 10jerkins-bot: [V: 04-1] Why is jenkins being weird? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702586 (owner: 10Eileen) [07:58:49] (03CR) 10jerkins-bot: [V: 04-1] Add new dev field to support targetsmart testing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702587 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [08:05:04] (03PS2) 10Eileen: Why is jenkins being weird? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702586 [08:14:20] (03CR) 10jerkins-bot: [V: 04-1] Why is jenkins being weird? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702586 (owner: 10Eileen) [08:34:38] (03PS3) 10Eileen: Why is jenkins being weird? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702586 [08:43:55] (03CR) 10jerkins-bot: [V: 04-1] Why is jenkins being weird? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702586 (owner: 10Eileen) [09:00:55] (03PS4) 10Eileen: Why is jenkins being weird? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702586 [14:20:15] haha, changing the name to 'Why is jenkins being weird' fixed the tests? [14:21:05] arr, 'quietly ignored' field no longer [14:21:45] (03CR) 10Ejegg: [C: 03+2] "Strictly more correct!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702586 (owner: 10Eileen) [14:25:24] (03PS2) 10Ejegg: Add new dev field to support targetsmart testing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702587 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [14:27:54] (03CR) 10Ejegg: [C: 03+2] "More congruent dev env!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702587 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [14:35:05] (03CR) 10Ejegg: [C: 04-1] "on first pass, this looks like a good improvement! I see one place the old appeal value is still used" (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702582 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [14:49:21] (03Merged) 10jenkins-bot: Why is jenkins being weird? [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702586 (owner: 10Eileen) [14:49:23] (03Merged) 10jenkins-bot: Add new dev field to support targetsmart testing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702587 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [15:03:16] fr-tech got a micro-patch (2 chars) for SmashPig / adyen: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/702495 [15:03:59] also a more substantial patch that needs pretty thorough review and testing: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/702491 [15:12:06] ejegg: caught your email about the origin adyen settings. made sense [15:12:38] and i just read your email from this morning. hope you're doing OK! [15:14:44] not too bad once the pain meds kick in. Makes driving hard though not being able to turn my head to the right [15:14:46] (03CR) 10Ejegg: [C: 04-1] "Definitely better to have it updated! Looks like the targetsmart test dir is missing from phpunit.xml, and that the ImportTest there still" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702583 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [15:14:58] it's my own fault, should have dealt with it years ago [15:15:18] eesh, always tempting to put stuff off [15:15:38] but I've chickened out of the operation up to now as I haven't been keen on someone cutting my neck open [15:15:42] if I can help it [15:15:44] right? [15:16:15] just as a joke the surgeon comes in wearing an executioner's hood... [15:20:30] LOL [15:20:45] jgleeson: https://www.youtube.com/watch?v=8hJ1HDcMowk [15:24:32] haha cstone [15:24:47] I miss being an ambiturner [15:28:49] right fr-tech my plan so far today has been to flesh out as much of the smaspig applepay adyen stuff and simulate the call from the frontend with a unit test. Adyen came back to us last night asking for specifics so I'll reply with those if that makes sense. Also for the sake of consistency I'll switch over to the adyen api account we use on sandbox and put down the one I set up when evaluating [15:28:51] adyen web components. [15:29:11] thanks, please do reply! [15:29:25] also yah let's all use the same credentials [15:56:40] (03PS8) 10Ejegg: Unit / integration tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) [15:56:55] ok fr-tech those tests are all passing for me! ^^^ [15:58:29] hmm, that 'description' translation bug the tests found looks like it could be fixed by a staging helper [15:58:48] ehh or maybe not [15:59:55] lessee, maybe the txn array values should be able to indicate that something is a message key [16:00:29] (03CR) 10jerkins-bot: [V: 04-1] Unit / integration tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) (owner: 10Ejegg) [16:00:40] oh snap [16:00:59] ah, phpcs [16:10:45] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-Docker: Docker dev setup: Set up IPN listeners - https://phabricator.wikimedia.org/T268687 (10AndyRussG) a:03AndyRussG [16:21:45] 10Fundraising-Backlog, 10FR-Adyen: Adyen Checkout: IPN listener no longer needs to capture payments - https://phabricator.wikimedia.org/T285962 (10Ejegg) [16:26:53] (03PS9) 10Ejegg: Unit / integration tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) [18:16:31] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), 10User-DannyS712, 10ci-test-error: Master tests failing for CentralNotice, "RuntimeException: Config accessed before it is set" - https://phabricator.wikimedia.org/T285449 (10Krinkle) 05Open→03Res... [18:34:06] 10Wikimedia-Fundraising-Banners: [Dsk Lg] RML Popup stays active on scroll blocking Donate buttons in nag - https://phabricator.wikimedia.org/T285772 (10jbolorinos-ctr) Hey @EWilfong_WMF please just let me know if any further information is needed to help resolve this issue. Thanks! [19:03:32] (03PS1) 10Ejegg: Explicitly require EventLogging [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/702734 [19:03:49] AndyRussG: ^^^ thanks for finding that documentation [19:05:01] 10Fundraising-Backlog, 10FR-Adyen: Adyen Checkout: IPN listener no longer needs to capture payments - https://phabricator.wikimedia.org/T285962 (10Ejegg) p:05Triage→03Medium [19:05:29] so fr-tech I guess for the IPN listener change, maybe we put that behind a setting first? ^^^ [19:06:25] Since it's possible to switch front-end integrations just by changing the wgDonationInterfaceGatewayAdapters['adyen'] value to point at old vs new adapter [19:06:54] it would be nice to be able to just change settings on the IPN listener to swap back to old behavior [19:09:10] the flag approach makes sense to me ejegg [19:09:48] although we'd have to try and bunch up the optional behaviour in a nice contained way [19:10:04] is that doable? I feel like there are a few moving parts [19:11:45] ejegg: ^ [19:14:05] jgleeson I think I can just add a setting in the SmashPig config [19:14:29] and then check it before sending the capture job to the queue [19:15:37] So we'd still have to coordinate that setting with the wgDonationInterfaceGatewayAdapters [19:16:00] and I'd add a comment to that effect [19:16:19] but then when we are confident about the new code we can just remove the capture job and the setting [19:18:27] 10Fundraising-Backlog, 10fr-donorservices: Ingenico status 190s question - https://phabricator.wikimedia.org/T283524 (10EMartin) 05Resolved→03Open Hi FrTech, As of today we are still seeing the descriptor in Japanese and thus more 190 rejections of settlements from JCB. Example in this screen shot: {F3... [19:20:54] (03CR) 10Ejegg: "Thanks for taking a look at this AndyRussG! The composer.lock file in this repo only affects the standalone deployment. You can test it wi" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/701596 (owner: 10Ejegg) [19:39:02] (03PS1) 10Ejegg: Adyen: setting for capture on receiving auth IPN [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702748 (https://phabricator.wikimedia.org/T285962) [19:41:05] (03CR) 10Jgleeson: [C: 03+2] Adyen Checkout: more RiskScorer fix [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702495 (https://phabricator.wikimedia.org/T282641) (owner: 10Ejegg) [19:41:34] (03Merged) 10jenkins-bot: Adyen Checkout: more RiskScorer fix [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702495 (https://phabricator.wikimedia.org/T282641) (owner: 10Ejegg) [19:41:35] ejegg: what was the patch that needed thorough review? [19:41:48] I see that riskscorer and the patch AndyRussG is reviewing [19:42:19] jgleeson the one that rewrites the capture action as REST [19:42:24] also thanks for the CR! [19:43:03] got it [19:43:05] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/702491 [19:43:12] yep, exactly [19:43:52] (03CR) 10Ejegg: "I'm 99% sure that this actually fixes a bunch of places where tests are relying on brokenness." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 (owner: 10Ejegg) [19:44:42] that actually doesn't look too scary [19:44:52] yah jgleeson I think it should be fine [19:44:59] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10FR-Adyen, 10Patch-For-Review: Adyen Checkout: IPN listener no longer needs to capture payments - https://phabricator.wikimedia.org/T285962 (10Ejegg) [19:45:04] I was expecting more trees to have been chopped [19:45:28] Oh, I should look at the error handling around where it's used in the CRM recurring extension [19:50:33] I've not had a productive day today [19:52:57] I'd hoped to have had more to show on the Smashpig Adyen stuff but it looks like I'm going take it into tomorrow. I'll jump on the REST review ejegg in the morning if others don't get there before me. [19:53:27] fr-tech it feels like we might not be ready to merge the adyen branch into master as planned tomorrow? [19:54:21] That's fine, thinking more about it, that was the sprint goal, and we still have Monday and Tuesday on the other side of the break as part of the sprint. [19:55:01] I was just a little overly antsy about things on Tuesday, sorry about that. [19:55:39] ejegg: that REST patch looks straightforward but I'll like to try and test it with a sandbox transaction if possible before +2ing and I'm flagging a little now it'll be tomorrow [19:56:46] sounds good jgleeson, let's not rush it [20:00:13] (03PS1) 10Ejegg: Adyen: array initialization tweaks, DRY [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702750 (https://phabricator.wikimedia.org/T277120) [20:00:22] XenoRyet: I'm planning on working a day or two next week and maybe taking the following Monday (12th) off instead. It's the Euros final Sunday 11th and there's a slim chance England might make it which means Sunday might end up being a late one for me. [20:00:45] (03CR) 10jerkins-bot: [V: 04-1] Adyen: array initialization tweaks, DRY [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702750 (https://phabricator.wikimedia.org/T277120) (owner: 10Ejegg) [20:01:38] Don't feel pressured to work during the break, but yea if you want to move one of the days around to catch a game, that's cool by me. [20:01:56] thanks! [20:03:53] (03PS2) 10Ejegg: Adyen: array initialization tweaks, DRY [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702750 (https://phabricator.wikimedia.org/T277120) [21:48:46] (03PS10) 10Ejegg: Unit / integration tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) [21:48:48] (03PS1) 10Ejegg: Adyen Checkout cleanup [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702756 [22:04:19] 10Fundraising-Backlog, 10FR-Docker, 10Gerrit-Privilege-Requests, 10dev-images, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10thcipriani) 05Open→03Resolved a:03thcipriani Apologies for the delay here. I have you CR+2/CR-2... [22:23:58] (03PS2) 10Eileen: Update targetsmart references for 2021 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702583 (https://phabricator.wikimedia.org/T284784) [22:24:59] (03CR) 10Eileen: "@ejegg - I've updated those references - I should note that test hasn't been working for me locally at the moment anyway and I have this v" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702583 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [22:27:36] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-Adyen, and 2 others: Adyen Checkout: handle new recurring card donations - https://phabricator.wikimedia.org/T283106 (10Cstone) a:03Cstone [22:28:36] (03PS1) 10Cstone: WIP: Add recurring [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702762 (https://phabricator.wikimedia.org/T283106) [22:31:04] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add recurring [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702762 (https://phabricator.wikimedia.org/T283106) (owner: 10Cstone) [22:31:28] (03CR) 10Ejegg: [C: 03+2] "OK, thanks for the explanation!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702583 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [22:33:13] (03PS1) 10Ejegg: Adyen Checkout - move antifraud filter run [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702763 (https://phabricator.wikimedia.org/T282641) [22:34:06] ^^^ will fail tests because they're written to expect the antifraud runs against ideal [22:35:04] just wondering whether to rebase that before the tests or to change the tests in that patch [22:35:15] i guess better to rebase that before the tests [22:36:11] but... the tests have FIXME comments explaining why that move should happen [22:36:20] (03PS1) 10Cstone: WIP: Add recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702766 (https://phabricator.wikimedia.org/T283106) [22:36:21] fr-tech any preference for which way to do it? [22:38:31] (03PS1) 10Eileen: Remove legacy hard-coded campaigns [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702768 [22:39:01] ejegg: are you ok with ^^ - it makes the switch statement non-sensical but I'll look at that next if you agree with removing all that cruft [22:39:28] guessing those haven't been used in 6 or 7 years [22:40:34] that's my guess! [22:42:18] (03Merged) 10jenkins-bot: Update targetsmart references for 2021 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702583 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [22:42:39] ejegg: I'm rather tempted to db -update the name for the appeal field to just 'appeal' [22:43:06] yerp, that'd make things easier! [22:44:44] yeah - although it looks like it still creates the option group with a tricksy name so I'd need to do more work on the install side anyway [22:47:37] ok I think I have another idea [22:54:55] cstone maybe 'recurring' doesn't need to be added as a tuneFor... parameter? [22:55:16] up in DonationInterface we can just add it to all the authorize calls [22:56:13] just always pass it through? [22:56:18] yeah [22:57:01] i think all the payment methods for adyen ought to support it, right? [22:57:38] yeah i would just have to confirm on apple pay cause i didn't look there yet but i dont see why it wouldnt [22:57:49] yah pretty sure I saw it did [22:58:17] we just store the our-side-generated token like with the other methods [22:59:14] hmm, i thought that antifraud move patch would fail tests, but it doesn't seem to. are those new tests actually running? [23:00:03] whoa, only 32 tests run? [23:00:39] oh that is a separate run [23:03:06] was I wrong with those FIXMEs? [23:03:51] well, I do get one failure locally [23:03:55] thought i'd get more [23:05:48] oh derp, i had the bits commented out that would have failed [23:05:52] ok, will enable them [23:10:17] (03PS2) 10Ejegg: Adyen Checkout - move antifraud filter run [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702763 (https://phabricator.wikimedia.org/T282641) [23:17:55] (03PS1) 10Ejegg: Adyen Checkout: Add gateway_txn_id earlier [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702776 (https://phabricator.wikimedia.org/T282641) [23:24:19] (03PS3) 10Eileen: Fix custom field create to correctly create option_values [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702582 (https://phabricator.wikimedia.org/T284784) [23:24:29] (03PS11) 10Ejegg: Unit / integration tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) [23:24:31] (03PS2) 10Ejegg: Adyen Checkout: minor cleanup [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702756 [23:24:33] (03PS3) 10Ejegg: Adyen Checkout: move antifraud filter run [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702763 (https://phabricator.wikimedia.org/T282641) [23:24:35] (03PS2) 10Ejegg: Adyen Checkout: Add gateway_txn_id earlier [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702776 (https://phabricator.wikimedia.org/T282641) [23:25:23] (03CR) 10Eileen: "ejegg - I think this will get us around it - I noted in the code the way that I thought would be more elegant but didn't work for me just " (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702582 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [23:26:00] (03PS2) 10Eileen: Fix enotice when running during setup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702497 [23:27:28] (03PS3) 10Eileen: Fix enotice when running during setup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702497 [23:31:26] eileen: I'm pretty sure this is failing tests because the tests are wrong: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/701604 [23:31:49] it's making some donations NOT throw a bad currency exception [23:32:04] and that's changing the resulting data set [23:32:32] I haven't dug into the actual data far enough to fix the tests, but I might try that once Adyen is in a better place [23:32:41] ejegg: ok - I haven't caught up on this one - so you are proposing to change the tests to make that pass? [23:32:54] yeah, but it's not at all a priority [23:33:48] i just wrote it cause i thought it would be a trivial way to make local tests more painless (currently trying to import e.g. CAD on a fresh docker db fails) [23:34:05] then i got really puzzled when it failed a bunch of seemingly unrelated tests [23:34:10] ejegg: so my recollection about the currency rates in tests is they work by doing copy&paste & not thinking too hard about it... [23:34:16] haha [23:34:27] I think in some cases the copypaste was missing [23:34:43] (03CR) 10jerkins-bot: [V: 04-1] Fix custom field create to correctly create option_values [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702582 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [23:34:49] and there was enough exception catching in the code under test that it just mutated the output slightly [23:35:45] ok here is my theory (without looking at the code, just the failures) - the bitpay test is doing cleanup in the test rather than the tearDown & as a result a failure in this test is leaving extraneous contacts in the db which is messing with the expectations in the dedupe tests [23:36:02] so yah, i was actually thinking of making a patch BEFORE adding the fallback, which just adds the copypaste to set exchange rates to the ones that were failing and see if they fail the same way [23:36:19] hmm, that would actually be pretty trivial [23:38:57] (03PS1) 10Ejegg: Set exchange rate for bitpay test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702779 [23:39:11] Go banana! [23:39:21] I mean go zuul! [23:40:03] mmm, dinner is calling [23:41:03] (03PS4) 10Eileen: Fix custom field create to correctly create option_values [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702582 (https://phabricator.wikimedia.org/T284784) [23:41:44] ejegg: do you want me to +2 that bitpay test one? [23:41:57] let's just see what the tests do [23:42:27] sorry, that string of patches is just a distraction at present... [23:42:40] like negative priority [23:45:25] :-) [23:45:47] yeah I got bogged down on local targetsmart set up in the hope when I get it working I can replicate what I hit on live [23:46:31] ejegg: if you wanna +2 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/702768 the cleanup is in the next patch [23:46:57] (03PS3) 10Eileen: Use same address setting on dev sites as live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702498 (https://phabricator.wikimedia.org/T284784) [23:48:04] (03CR) 10Ejegg: [C: 03+2] "Have we tried a 'Mothman' direct mail appeal?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702768 (owner: 10Eileen) [23:48:51] I'm starting to lose my mind - changes I made seem to have disappeared (in the gerrit patches) [23:48:57] uff, that next one is a bit chunky for me to +2 right at the moment. maybe after dinner? [23:49:13] arr, rebase gremlins? [23:52:28] (03PS5) 10Eileen: Fix custom field create to correctly create option_values [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702582 (https://phabricator.wikimedia.org/T284784) [23:53:59] (03CR) 10Ejegg: "Note that the change from newFailureAndRedirect to just newFailure is possible because of the JS and API code added in Ic8db76d9b1f3b9506c" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702763 (https://phabricator.wikimedia.org/T282641) (owner: 10Ejegg) [23:58:16] (03Merged) 10jenkins-bot: Remove legacy hard-coded campaigns [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702768 (owner: 10Eileen)