[02:33:56] 10Fundraising Sprint Upbeat Upholstery, 10Fundraising Sprint Vagranty McVagrantface, 10Fundraising Sprint We all meet again, 10Fundraising-Backlog, and 3 others: Make payments phpunit tests pass under Docker - https://phabricator.wikimedia.org/T266088 (10AndyRussG) In addition to the above patches, I pushe... [03:17:40] oh dang, something's trying to insert very wrong contribution tracking queue IDs [03:18:11] i.e. using the gateway_txn_id instead of the ct_id [03:27:03] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Bad messages being sent to contribution tracking queue - https://phabricator.wikimedia.org/T286429 (10Ejegg) [04:18:51] ejegg|away: ? [04:19:11] ah I see the Phab ^ [04:23:54] is that urgent? [05:05:13] (03CR) 10AndyRussG: "Hey, thanks so much for this, nice work!!! :) A few more notes are inline... Regarding the use of random numbers in tests, I see it's a st" (033 comments) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) (owner: 10Ejegg) [06:00:44] (03CR) 10AndyRussG: [C: 03+2] "Since other patches along the chain do depend on this one, I'm +2'ing to allow the others to merge. Perhaps we can then make a follow-on c" (031 comment) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) (owner: 10Ejegg) [06:03:46] (03Merged) 10jenkins-bot: Unit / integration tests for Adyen Checkout [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702028 (https://phabricator.wikimedia.org/T285734) (owner: 10Ejegg) [06:09:41] (03CR) 10AndyRussG: "Thanks!! Just a couple small questions..." (032 comments) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702756 (owner: 10Ejegg) [06:34:11] (03CR) 10AndyRussG: "Nice!!!!!!! Just a couple questions inline... Thanks!" (032 comments) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702763 (https://phabricator.wikimedia.org/T282641) (owner: 10Ejegg) [14:43:53] hi fr-tech! [14:49:24] hi jgleeson [14:52:19] hey cstone :) [14:52:59] good break cstone ? [14:58:15] yeah rained a lot but it was good jgleeson [14:58:18] how was yours? [15:00:08] weather was ok actually more sun than rain here cstone but it's raining now :) [15:00:51] England got to the final of the Euros last night which hasn't happened in 55 years but we lost to Italy on penalties in the end :/ [15:01:08] hey fr-tech jgleeson cstone :) :) [15:01:52] on the whole though it was a big achievement and something to feel good about! [15:01:55] howdy AndyRussG ! [15:02:11] :) [15:03:14] I had planned to work a day last week and take today off but in the end I decided to switch off from work last week so here I am! :) [15:04:54] cool! Yeah I mostly didn't work [15:06:43] still in the midst of moderate-to-intense non-work stuff... Ceci had some friends over for a sleepover on Saturday, and they just kept asking if they could stay longer and longer... one of them is still here (expected to be picked up by parents soon) ... then I have to take my kids to their mom's place [15:22:38] ha AndyRussG! any longer than you'll have to start thinking about adding the friends to the chores list? [15:23:18] heheh indeed [16:53:40] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Patch-For-Review: make acoustic mail data searchable through search kit - https://phabricator.wikimedia.org/T285359 (10EYener) Sorry @Eileenmcnaughton I'm coming back to this now; is the query in prod in the correct format, or was the patch t... [16:56:38] hi fr-tech! [16:57:30] hi ejegg [16:57:55] hello there. [16:58:09] thanks for all the CR AndyRussG - will respond shortly [17:02:10] ejegg: I tested your patch rewriting the the create call using REST. it looks like we can't test it easily for recurring due to no recurring being available on the adyen branch. Am I right in guess that we need to switch back to the old Adyen code, create a recurring and then try to run a recurring test with the token generated, to test it works as expected? [17:02:46] 10Fundraising-Backlog: If check number is edited, contribution cannot be found in search - https://phabricator.wikimedia.org/T286495 (10MDemosWMF) [17:02:50] right, that's the idea, test it with a recurring generated from old-adyen [17:03:27] and to authorize a payment in the old-style, we need the IPN listeners no? [17:03:45] or can we skip that step [17:06:38] I'll add some further comments on the patch [17:06:40] 10Fundraising-Backlog: first/last name swap contact - https://phabricator.wikimedia.org/T286496 (10MSuijkerbuijk_WMF) [17:09:30] jgleeson yeah, to capture the initial payment we need an IPN listener [17:10:02] 10Fundraising-Backlog: first/last name swap contact - https://phabricator.wikimedia.org/T286496 (10MSuijkerbuijk_WMF) Clarifying that the error was spotted on a test email through Acoustic, not in a Thank you email. [17:12:17] (03CR) 10Jgleeson: "> Patch Set 1:" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702491 (https://phabricator.wikimedia.org/T282302) (owner: 10Ejegg) [17:12:41] 10Fundraising-Backlog: first/last name swap contact - https://phabricator.wikimedia.org/T286496 (10DStrine) [17:13:37] cool. It might be possible to reuse an existing recurring payment using the adyen recurring test script we added [17:18:50] 10Fundraising-Backlog: first/last name swap contact - https://phabricator.wikimedia.org/T286496 (10DStrine) This CID has the name flipped: 51128128 ... this one would create a TY email with the "wrong" name ordering. [17:45:11] jgleeson: ejegg idono if you saw but the token the new recurring sends back is a different format from the old recurring [17:45:21] (03CR) 10Jgleeson: [C: 03+2] "Tested with recurring and worked as expected. Transaction ID in adyen test console = RECURRING-TEST-5386" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702491 (https://phabricator.wikimedia.org/T282302) (owner: 10Ejegg) [17:45:46] I haven't seen cstone :O [17:45:59] (03Merged) 10jenkins-bot: Adyen Checkout: rewrite capture as REST call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702491 (https://phabricator.wikimedia.org/T282302) (owner: 10Ejegg) [17:47:16] btw cstone you might already use it but if not I found a maintenance script we added to test adyen recurring testing easier https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/4cfc0861f281f30b6e10f7b53d8a3a3f2e6d2426/PaymentProviders/Adyen/Maintenance/TestAdyenRecurring.php. Usage tips here also: [17:47:18] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/565059/9#message-4df64a6012d65594573a9de098a8586b8761d206 [17:47:36] to make* adyen recurring testing easier [17:47:42] I'd forgotten all about it [17:47:57] oh nice jgleeson [17:48:25] yeah late on friday I was trying to test with the main recurring processor and apparently completely forgot how it worked haha [17:49:02] ditto [17:50:29] jgleeson: do you have cli xdebug working? [17:50:36] ya [17:50:53] you having issues? [17:50:59] yeah hah [17:51:07] wanna hop on a call ? [17:51:09] sure [17:51:25] I'll join today's call [17:51:30] ok sounds good [19:00:33] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Wmf-donor - new year fields - https://phabricator.wikimedia.org/T280595 (10EYener) Hi @Eileenmcnaughton - I was just asking about this today! I'll offer to write a commit for wmf_donor for this and submit it to you as a reviewer, if @DStrine is okay with... [19:06:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Wmf-donor - new year fields - https://phabricator.wikimedia.org/T280595 (10DStrine) I thought this required a civi outage, right? It might be hard to schedule in the near term if this is so. [19:07:00] 10Fundraising-Backlog: dupe contact found with first/last names in wrong positions. - https://phabricator.wikimedia.org/T286496 (10DStrine) [19:20:50] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Wmf-donor - new year fields - https://phabricator.wikimedia.org/T280595 (10EYener) Just guessing - probably for the Civi UI update to ensure these fields are visible in the Civi UI, but for use in analytics and reporting, the update to the civicrm.wmf_don... [19:47:29] 10Fundraising-Backlog: dupe contact found with first/last names in wrong positions. - https://phabricator.wikimedia.org/T286496 (10DStrine) It seems @EWilson created this contact in May. It doesn't have any relationships or other data. @CaitVirtue is it ok to delete this contact? [19:52:15] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: If check number is edited, contribution cannot be found in search - https://phabricator.wikimedia.org/T286495 (10DStrine) [19:52:53] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Wmf-donor - new year fields - https://phabricator.wikimedia.org/T280595 (10Eileenmcnaughton) @EYener - there are a few steps involved - we have to load the triggers, create the fields, add to accoustic upload etc - so I won't be able to just +2 & deploy.... [19:53:52] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Remove unused imports / handling - https://phabricator.wikimedia.org/T286225 (10DStrine) [19:58:02] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Modification to Fredge Report - https://phabricator.wikimedia.org/T285321 (10Eileenmcnaughton) a:03Eileenmcnaughton [20:02:42] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Wmf-donor - new year fields - https://phabricator.wikimedia.org/T280595 (10EYener) Makes perfect sense, there are a lot of systems that these would have to go live in. I would just be interested in involvement up to the point of seeing new fields visible... [20:21:12] (03PS3) 10Ejegg: Adyen Checkout: minor cleanup [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702756 [20:21:14] (03PS4) 10Ejegg: Adyen Checkout: move antifraud filter run [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702763 (https://phabricator.wikimedia.org/T282641) [20:21:16] (03PS3) 10Ejegg: Adyen Checkout: Add gateway_txn_id earlier [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702776 (https://phabricator.wikimedia.org/T282641) [20:22:42] (03CR) 10Ejegg: "Thanks for the CR AndyRussG!" (032 comments) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702756 (owner: 10Ejegg) [20:23:10] (03CR) 10Ejegg: "Thanks for the CR! I added that comment back." (032 comments) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702763 (https://phabricator.wikimedia.org/T282641) (owner: 10Ejegg) [20:45:19] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Wmf-donor - new year fields - https://phabricator.wikimedia.org/T280595 (10Eileenmcnaughton) @EYener that is a generated file - but in terms of communicating the extra fields you want it might be a good way to do it - since I'm sure that you want to speak... [20:58:07] fr-tech: looking at the docs, if we are just adding a column onto the end, it should be instant: https://mariadb.com/kb/en/instant-add-column-for-innodb/ [20:59:07] within limits of course. and the only thing for our case that really is giving me pause is the possible index creation. [21:00:43] given that, our charset alters on the wmf_donor table took approximately 32 mins on the origin server. [21:01:20] i would plan for that same level if we wanted to take a maint window to do it. [21:05:01] nice dwisehaupt [21:35:07] nice dwisehaupt ! [21:38:26] 434 ff tabs open. i may have a problem letting go of things. [21:39:21] heh, [21:45:50] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: Would it be possible to have an 'Owns the Donor Advised Fund' field that would link that Individual to their DAF? - https://phabricator.wikimedia.org/T286520 (10Eil... [21:48:35] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10Eileenmcnaughton) @MDemosWMF I've spun off that latest... [21:49:35] (03CR) 10Ejegg: "Looks like a good start!" (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702766 (https://phabricator.wikimedia.org/T283106) (owner: 10Cstone) [21:53:08] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Patch-For-Review: make acoustic mail data searchable through search kit - https://phabricator.wikimedia.org/T285359 (10Eileenmcnaughton) @EYener this should be correct now - we just need to merge https://gerrit.wikimedia.org/r/c/wikimedia/fun... [21:56:37] this should be an easy review - which would put this task into done https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/703492 [21:56:53] just looking at that now, actually! [21:57:07] based on the phab comment from a few min back [22:03:43] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10MDemosWMF) Thank you @Eileenmcnaughton! I think you're... [22:13:01] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Modification to Fredge Report - https://phabricator.wikimedia.org/T285321 (10Eileenmcnaughton) The above patch is in review - I also put up a PR against master to fix the weird formatting o... [22:15:06] thanks ejegg - there is quite a lot in review tbh [22:15:43] yeah, just tracked down one thing with tabsets and then looking at the Specification.php use of 'field' vs 'fieldName' [22:16:18] for the primary key? [22:16:31] yep [22:17:12] Is this where the element is used? https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/CodeGen/Specification.php#L524 [22:17:47] ejegg: yep [22:18:35] huh, so with the element it just wasn't working at all? [22:19:45] yeah - basically [22:20:03] kk, does look more aligned with the code now [22:24:49] hmm, I seem to have something funky with my managed payment processors - i keep getting an insert collision when i system flush locally [22:25:46] ug [22:26:00] that will happen if you have the processor but not the row in your civicrm_managed table [22:26:31] ahhh [22:26:44] i probably created something by hand early on [22:26:50] thanks! [22:27:40] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703492 (https://phabricator.wikimedia.org/T285359) (owner: 10Eileen) [22:28:05] ok, so the tabs[] array key looks like it was mostly just used for caches and to generate a URL [22:28:22] but since you explicitly set a URL it doesn't matter [22:29:10] yeah - that tabs fix came through from Coleman [22:30:22] (03PS2) 10Ejegg: Fall back for contact id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702794 (owner: 10Eileen) [22:30:45] (03CR) 10Ejegg: [C: 03+2] ""Be tolerant in what you accept from others"" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702794 (owner: 10Eileen) [22:34:45] eileen: mind if I tweak the WS on this one for readability? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/702498 [22:35:14] sure [22:36:01] ejegg: just +2 when you are happy with the ws [22:36:07] cool cool [22:38:02] (03Merged) 10jenkins-bot: Update generated code for omnimail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703492 (https://phabricator.wikimedia.org/T285359) (owner: 10Eileen) [22:38:14] (03PS4) 10Ejegg: Use same address setting on dev sites as live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702498 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [22:39:13] (03CR) 10Ejegg: [C: 03+2] "PS4: rebase + WS rewrap" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702498 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [22:41:11] (03PS2) 10Eileen: Update generated code for omnimail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703261 (https://phabricator.wikimedia.org/T285359) [22:41:34] (03Abandoned) 10Eileen: Update generated code for omnimail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703261 (https://phabricator.wikimedia.org/T285359) (owner: 10Eileen) [22:41:45] (03Merged) 10jenkins-bot: Fall back for contact id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702794 (owner: 10Eileen) [22:49:29] (03Merged) 10jenkins-bot: Use same address setting on dev sites as live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702498 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [23:01:53] nice, I added some civicrm_managed rows and my creaky old local civi install is back on track [23:07:38] (03PS2) 10Eileen: Move new Hook classes to wmf-civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703493 [23:07:40] (03PS1) 10Eileen: Minor cleanup - switch to single get call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704192 (https://phabricator.wikimedia.org/T281268) [23:17:57] oh hey, now that we're W3C members, we can comment on the PaymentRequest API: https://github.com/w3c/payment-request/issues/ [23:18:21] they want comments by July 27th [23:44:14] (03CR) 10Ejegg: [C: 03+2] "Seems to be working well locally now. Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702582 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [23:44:20] (03PS6) 10Ejegg: Fix custom field create to correctly create option_values [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702582 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen)