[00:07:21] (03PS3) 10Eileen: Update our custom field create to use preferred action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702499 (https://phabricator.wikimedia.org/T284784) [00:09:57] hm seem to have lots of merge conflicts now [00:12:36] (03PS2) 10Eileen: [Refactor] Move the insert contact function internals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703264 (https://phabricator.wikimedia.org/T283104) [00:12:46] (03PS2) 10Eileen: [Refactor] extract all that tag 'noise' to it's own function. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703265 (https://phabricator.wikimedia.org/T283104) [00:13:10] (03PS4) 10Eileen: [Refactor] extract all the language noise to it's own function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703266 (https://phabricator.wikimedia.org/T283104) [00:13:21] (03PS5) 10Eileen: [Refactor] Move existing contact matching code to new WMFContact::save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703267 (https://phabricator.wikimedia.org/T283104) [00:13:30] (03PS4) 10Eileen: Remove match_on_import conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703268 (https://phabricator.wikimedia.org/T283104) [00:13:37] (03PS3) 10Eileen: Add ability to match on address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703270 (https://phabricator.wikimedia.org/T283104) [00:15:33] (03Abandoned) 10Eileen: Update our custom field create to use preferred action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702499 (https://phabricator.wikimedia.org/T284784) (owner: 10Eileen) [00:16:09] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701221 (https://phabricator.wikimedia.org/T285446) (owner: 10Eileen) [00:45:29] (03CR) 10Ejegg: [C: 03+2] "Moved code diffs cleanly, queue consumers like the new code locally. The api3-result-wrapped-in-an-api4-result return of the new Save acti" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703264 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [00:45:45] lol sorting by pasta diameter [00:50:36] :-) [00:54:47] (03Merged) 10jenkins-bot: [Refactor] Move the insert contact function internals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703264 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [01:04:20] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-production-error: TypeError: Cannot read property 'key' of undefined - https://phabricator.wikimedia.org/T285482 (10Krinkle) [01:35:31] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-production-error: TypeError: Cannot read property 'key' of undefined - https://phabricator.wikimedia.org/T285482 (10Ejegg) Perhaps this was an error in some in-banner JS? There haven't been any more occurrences of it in the past 12 days... [01:39:53] (03PS3) 10Eileen: Move new Hook classes to wmf-civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703493 [01:39:55] (03PS2) 10Eileen: Minor cleanup - switch to single get call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704192 (https://phabricator.wikimedia.org/T281268) [01:39:57] (03PS1) 10Eileen: Add mechanism to update date custom field when another field is altered [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704199 (https://phabricator.wikimedia.org/T281268) [01:40:44] (03CR) 10Ejegg: [C: 03+2] "Clean extraction" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703265 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [01:48:20] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Civi stock TY email template missing gift date - https://phabricator.wikimedia.org/T281313 (10Eileenmcnaughton) @MDemosWMF it looks like we already deploy... [01:49:29] (03CR) 10Ejegg: [C: 04-1] "I think we'll want one more null check on contribution_tracking_id" (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703266 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [01:51:09] (03Merged) 10jenkins-bot: [Refactor] extract all that tag 'noise' to it's own function. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703265 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [01:51:55] ejegg: hmm annoying I can't rebase that one out & separate it from the chain :-( [01:52:04] arr [01:54:44] (03CR) 10Ejegg: "This looks like it really changes the way the code works! In the old code, a contact matched on email would go down the 'else' clause with" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703267 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [01:55:06] am I misunderstanding that one? https://gerrit.wikimedia.org/r/703267 seems like a pretty big change eileen [01:56:34] just checking [01:59:22] (03PS5) 10Eileen: [Refactor] extract all the language noise to it's own function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703266 (https://phabricator.wikimedia.org/T283104) [01:59:25] I've just added an IF to the language one [01:59:32] cool cool [02:03:13] (03CR) 10Ejegg: [C: 03+2] "Better organized, should work the same as before!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703266 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [02:04:23] getting rid of those 'watchdog' calls can happen closer to D7 EOL [02:04:23] D7: Testing: DO not merge - https://phabricator.wikimedia.org/D7 [02:04:40] hah, what is the D phab namespace even? [02:06:48] yeah - we still need to make a couple of decisions about logging before we swap out more [02:07:04] ie - the question around this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/701994 [02:08:03] so - we have somethings going directly to the contact_create stuff & others going via that message_insert & we have 2 behaviour patterns - for no clear reason [02:09:42] & some things are probably a bit wrong - ie we don't update preferred language for updates.... [02:09:54] yeah, that's a bug [02:10:08] but we do want to preserve that special handling for do not contact fields, right? [02:14:38] (03Merged) 10jenkins-bot: [Refactor] extract all the language noise to it's own function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703266 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [02:14:57] ok, i gotta hang it up for the night. will look at that one again tomorrow [02:15:33] (03PS1) 10Eileen: Remove obsolete code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704205 [02:15:45] ejegg|away: yeah looking again [04:15:16] (03PS1) 10Eileen: Remove nonsense if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704211 [05:03:48] (03PS6) 10Eileen: [Refactor] Move existing contact matching code to new WMFContact::save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703267 (https://phabricator.wikimedia.org/T283104) [05:03:50] (03PS5) 10Eileen: Remove match_on_import conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703268 (https://phabricator.wikimedia.org/T283104) [05:03:52] (03PS4) 10Eileen: Add ability to match on address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703270 (https://phabricator.wikimedia.org/T283104) [05:03:54] (03PS1) 10Eileen: Extract code to create a relationship [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704213 [05:03:56] (03PS1) 10Eileen: Add functions to start and stop the timer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704214 (https://phabricator.wikimedia.org/T283104) [05:03:58] (03PS1) 10Eileen: Move contact update code to save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704215 (https://phabricator.wikimedia.org/T283104) [05:14:56] (03CR) 10jerkins-bot: [V: 04-1] Add ability to match on address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703270 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [05:15:01] (03CR) 10jerkins-bot: [V: 04-1] [Refactor] Move existing contact matching code to new WMFContact::save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703267 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [05:15:45] (03CR) 10jerkins-bot: [V: 04-1] Move contact update code to save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704215 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [05:16:00] (03CR) 10jerkins-bot: [V: 04-1] Remove match_on_import conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703268 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [05:29:27] (03PS2) 10Eileen: Move contact update code to save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704215 (https://phabricator.wikimedia.org/T283104) [05:39:31] (03CR) 10jerkins-bot: [V: 04-1] Move contact update code to save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704215 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [05:43:24] (03PS3) 10Eileen: Move contact update code to save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704215 (https://phabricator.wikimedia.org/T283104) [05:56:53] (03PS7) 10Eileen: [Refactor] Move existing contact matching code to new WMFContact::save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703267 (https://phabricator.wikimedia.org/T283104) [05:58:28] (03PS6) 10Eileen: Remove match_on_import conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703268 (https://phabricator.wikimedia.org/T283104) [05:58:30] (03PS5) 10Eileen: Add ability to match on address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703270 (https://phabricator.wikimedia.org/T283104) [06:06:28] (03CR) 10jerkins-bot: [V: 04-1] [Refactor] Move existing contact matching code to new WMFContact::save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703267 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [06:09:06] (03CR) 10jerkins-bot: [V: 04-1] Remove match_on_import conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703268 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [06:09:14] (03CR) 10jerkins-bot: [V: 04-1] Add ability to match on address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703270 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [06:21:37] (03PS8) 10Eileen: [Refactor] Move existing contact matching code to new WMFContact::save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703267 (https://phabricator.wikimedia.org/T283104) [06:22:13] (03PS7) 10Eileen: Remove match_on_import conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703268 (https://phabricator.wikimedia.org/T283104) [06:22:15] (03PS6) 10Eileen: Add ability to match on address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703270 (https://phabricator.wikimedia.org/T283104) [06:35:34] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10Patch-For-Review: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10RLewis) @Eileenmcnaughton I think it's OK to send the a... [12:03:22] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Patch-For-Review: make acoustic mail data searchable through search kit - https://phabricator.wikimedia.org/T285359 (10EYener) Ah, got it. Thanks @Eileenmcnaughton [15:03:31] hi fr-tech! [15:03:45] hi jgleeson [15:05:01] looks like most of the ERC sessions have been moved back an hour this week and clash with the time I pick up oscar :/ [15:05:20] not sure if they're recorded [15:06:10] there's a code review one tomorrow at 4pm which I should make [15:10:50] hey jgleeson cstone fr-tech [15:10:59] hey AndyRussG [15:11:03] jgleeson ah sorry you've missed those, yeah they've been great so far [15:11:29] I don't think they're recorded, but I think the notes documents will be shared with opportunities for people to add further comments [15:11:41] :| [15:12:30] I think the reason for not recording is so that people don't feel pressured and can speak quite freely... when everyone writes in the notes docs, it's automatically anonymized [15:13:17] supposedly there will be a lot of further opportunities for feedback before a final report [15:13:20] yeah makes sense [15:13:28] the sessions I've been in so far have been pretty good [15:13:39] although the code review one really stands out [15:13:58] heheh yeah that one promises to be quite rich [15:19:37] fr-tech I mentioned in my EOD email last night that I'm setting up payments-wiki on the AWS applepay test box and to test Adyen checkout, I need to use some sandbox credentials. Does anyone see any problems with using the ones we're using in dev atm? [15:21:21] jgleeson hey thanks for asking... maybe let's confirm with fr-tech ops? on general principle my inclination is that we not do that, but I guess if it's only Adyen and only sandbox credentials, maybe? [16:16:52] (03CR) 10Ejegg: [C: 03+2] "Looks like core's checkPrimaryBlocks is now completely unused" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704205 (owner: 10Eileen) [16:19:54] (03CR) 10Ejegg: [C: 04-1] "Maybe just ` $verb = $contact_id ? 'updated' : 'created' ` to DRY? I like having the distinction in the log." (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704211 (owner: 10Eileen) [16:26:52] (03CR) 10Ejegg: [C: 03+2] "Looks good" (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704213 (owner: 10Eileen) [16:27:43] (03Merged) 10jenkins-bot: Remove obsolete code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704205 (owner: 10Eileen) [16:30:50] (03CR) 10Ejegg: [C: 04-1] "Handy, but potentially problematic till we move ALL the timer-using code to this class." (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704214 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [16:31:26] jgleeson|brb: ^^^ is an eileen patch that has to do with your StatCollector [16:31:58] Is my comment accurate about ->init() being potentially harmful? [16:32:45] And would it be useful to make the ->init() function check to see if the token is already initted and do nothing in that case? [16:33:05] Or do you see it being more useful to be able to re-init a singleton? [16:57:05] reading ejegg [17:19:16] ejegg: yeah, if the Save.php behaviour is called during the execution of the code that it was intended for here https://github.com/wikimedia/wikimedia-fundraising-crm/blob/9413580650c5dbf0b4581caafd324888c3825202/drupal/sites/all/modules/wmf_civicrm/wmf_civicrm.module#L197 then it would likely cause problems [17:19:40] she could also subclass that class to avoid any collisions [17:20:34] the singleton inheritance trait allows multiple different statscollectors to exist [17:21:10] I feel like that init thing is only specific to the import timings we added recently and isn't a feature of the stats collector itself [17:22:02] yeah there's no init() on the Abstract [17:22:43] I'd recommended subclassing to avoid problems and maintain the same usage [17:30:03] ejegg: it looks like the init/deinit stuff was added to handle capturing timings over collections of donations when order_id alone wasn't unique enough [17:30:26] there's a comment about it breaking in tests due to duplicate ids [17:38:42] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Civi stock TY email template missing gift date - https://phabricator.wikimedia.org/T281313 (10MDemosWMF) @Eileenmcnaughton Just tested and it looks good!... [18:00:08] (03PS1) 10AndyRussG: Update civi image with updated PATH for civix from repo [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/704396 (https://phabricator.wikimedia.org/T283044) [18:01:21] (03PS2) 10AndyRussG: Update civi image with PATH for civix from repo [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/704396 (https://phabricator.wikimedia.org/T283044) [18:04:20] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Docker config - use civix from repo - https://phabricator.wikimedia.org/T283044 (10AndyRussG) The above patches are ready for review. Also, merging the dev-images patch should take us one step closer to using the WMF image registry.... [18:23:54] 10Wikimedia-Fundraising-Banners: [Dsk Lg] RML Popup stays active on scroll blocking Donate buttons in nag - https://phabricator.wikimedia.org/T285772 (10RStearns_WMF) @jbolorinos-ctr @EWilfong_WMF, I think the banner is set now. Let me know if you find anything else. [19:21:21] (03PS1) 10AndyRussG: Add smashpig https listener [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/704407 (https://phabricator.wikimedia.org/T268687) [19:21:55] (03CR) 10Jgleeson: "Looks good! Added some notes on the StatsCollector stuff!" (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704214 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [19:43:30] (03CR) 10Eileen: "Oh dang - the change to check if it is null is in the next commit" (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704214 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [19:44:18] (03PS2) 10Eileen: Add functions to start and stop the timer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704214 (https://phabricator.wikimedia.org/T283104) [19:45:13] (03CR) 10Eileen: "OK - I brought that null check back into this patch" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704214 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [19:46:08] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Civi stock TY email template missing gift date - https://phabricator.wikimedia.org/T281313 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton [19:47:26] (03PS2) 10Eileen: Extract code to create a relationship [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704213 [19:52:26] (03CR) 10Jgleeson: "nice!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704214 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [19:53:12] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline: Would it be possible to have an 'Owns the Donor Advised Fund' field that would link that Individual to their DAF? - https://phabricator.wikimedia.org/T286520 (10DStrine) [20:25:55] (03PS2) 10Eileen: Remove nonsense if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704211 [20:26:49] (03PS4) 10Eileen: Move contact update code to save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704215 (https://phabricator.wikimedia.org/T283104) [20:31:31] (03CR) 10Ejegg: [C: 03+2] Remove nonsense if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704211 (owner: 10Eileen) [20:33:08] (03PS3) 10Ejegg: Add functions to start and stop the timer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704214 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [20:33:18] (03CR) 10Ejegg: [C: 03+2] Add functions to start and stop the timer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704214 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [20:34:56] (03PS5) 10Eileen: Move contact update code to save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704215 (https://phabricator.wikimedia.org/T283104) [20:39:36] (03PS9) 10Eileen: [Refactor] Move existing contact matching code to new WMFContact::save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703267 (https://phabricator.wikimedia.org/T283104) [20:39:48] (03PS8) 10Eileen: Remove match_on_import conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703268 (https://phabricator.wikimedia.org/T283104) [20:39:56] (03PS7) 10Eileen: Add ability to match on address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703270 (https://phabricator.wikimedia.org/T283104) [20:40:55] fr-tech trying to charge a new recurring on the old createPayment returns 800 Contract not found with refused as the resultCode [20:41:05] arrr [20:41:06] dang [20:41:34] well then, I guess we do need some way to differentiate [20:42:06] so let's see what the new create payment call will need for params [20:42:20] and whether the existing CRM nightly charge code is already sending all of those [20:42:33] i can put up my current WIP [20:42:47] yes please! [20:43:34] its all hardcoded at the moment [20:45:40] (03PS4) 10Cstone: WIP: Add recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702766 (https://phabricator.wikimedia.org/T283106) [20:46:08] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702766 (https://phabricator.wikimedia.org/T283106) (owner: 10Cstone) [20:46:50] it needs the token, the payment method and the 123456.7 that i can never remember the right name for but we should have all that [20:48:03] (03PS1) 10Ejegg: Token property for details / create response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/704420 (https://phabricator.wikimedia.org/T283106) [20:48:34] cstone there's that patch to add the new property ^^ [20:50:23] ejegg: cstone didn't we discuss adding a few subclasses for the variants of card createPayments? [20:50:41] standard/encrypted/recurring [20:52:31] maybe even just submethods [20:52:44] they seem to cover much of the same ground [20:54:30] yeah thats what i was mentioning [20:56:54] ah yeah [20:58:11] and thanks ejegg ! [21:19:19] cstone OK so let's see if we can use the NEW tokenized create payment to charge the OLD payments... [21:19:59] yeah I still need to test that [21:20:28] i have one OLD test adyen recur in my local db, will take a stab at it [21:20:33] ooh nice [21:20:39] i was just trying to see if I could dig one up [21:20:50] but hmm, it would be nice to have a drush option to charge a specific payment_recur_id [21:21:02] or contribution_recur.id whatever we call that id [21:22:50] oh hey, does anyone want to +2 this? Just updates the php requirement to 7.3 (the minimum non-EOL php) and does point upgrades to the libs in dev + IPN listener install: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/701596 [21:23:31] changing the php version in composer.json meant I had to regenerate the .lock file anyway for the hash value [21:23:42] so I figured I might as well get the little version updates done too [21:24:44] ejegg: that's an old recurring charge I used the other day https://ca-test.adyen.com/ca/ca/accounts/showTx.shtml?pspReference=853626111666064D&txType=Payment [21:25:00] And the PHP requirement update is so that IDEs quit complaining about the nullable type hints [21:25:01] also I just noticed something of interest, there's an "integration type" block on the payment details [21:25:09] thanks jgleeson [21:26:28] (03PS3) 10Ejegg: Update min PHP version + composer libs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/701596 [21:27:12] AndyRussG: dunno if you saw, but I responded to your comment on ^^^ [21:28:36] 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Adyen Checkout: Fine tune CSS - https://phabricator.wikimedia.org/T283306 (10Ejegg) [21:28:48] was just gonna say, AndyRussG this looks good to +2 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/701596 but do you wanna confirm you're ok with the .lock question? [21:30:46] ejegg: yes sorry haven't gotten to it... jgleeson pls go ahead and +2 if you wish :) thanks both!! :) [21:33:11] thanks AndyRussG [21:33:16] (03CR) 10Jgleeson: [C: 03+2] Update min PHP version + composer libs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/701596 (owner: 10Ejegg) [21:34:14] (03Merged) 10jenkins-bot: Update min PHP version + composer libs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/701596 (owner: 10Ejegg) [21:37:45] thanks! [22:09:19] (03CR) 10Ejegg: [C: 03+2] "Clean move" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704215 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [22:13:07] (03PS5) 10Cstone: WIP: Add recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702766 (https://phabricator.wikimedia.org/T283106) [22:13:43] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702766 (https://phabricator.wikimedia.org/T283106) (owner: 10Cstone) [22:19:43] (03Merged) 10jenkins-bot: Move contact update code to save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704215 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [23:03:44] (03PS1) 10Eileen: Change subject for endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704438 (https://phabricator.wikimedia.org/T284184) [23:06:28] (03PS2) 10Eileen: Change subject for endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704438 (https://phabricator.wikimedia.org/T284184) [23:16:08] (03CR) 10jerkins-bot: [V: 04-1] Change subject for endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704438 (https://phabricator.wikimedia.org/T284184) (owner: 10Eileen) [23:22:18] (03PS3) 10Eileen: Change subject for endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704438 (https://phabricator.wikimedia.org/T284184) [23:22:51] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-AutoTY-Email, and 2 others: Endowment Auto Thank You Email needs small copy change - https://phabricator.wikimedia.org/T284184 (10Eileenmcnaughton) a:03Eileenmcnaughton [23:29:53] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-AutoTY-Email, 10FR-Email: Formatting issue with Civi recurring expiry/fail email? - https://phabricator.wikimedia.org/T282582 (10Eileenmcnaughton) Just noting that the issue with the non-french sub... [23:30:05] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-AutoTY-Email, 10FR-Email: Formatting issue with Civi recurring expiry/fail email? - https://phabricator.wikimedia.org/T282582 (10Eileenmcnaughton) a:03Eileenmcnaughton [23:43:33] huh, fn signature looks funny no matter where I extract [23:55:36] 10Fundraising-Backlog, 10donate.wikimedia.org, 10MediaWiki-Core-Skin-Architecture: Provide a donate skin for donate.wikimedia.org - https://phabricator.wikimedia.org/T257862 (10Jdlrobson) Assuming Fundraising tech maintain this. Higher performance could equal more donations... [23:57:03] cstone: it looks like that endowment msg tweak was really easy after all - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/704438 [23:57:31] 10Fundraising-Backlog, 10donate.wikimedia.org: Provide a donate skin for donate.wikimedia.org - https://phabricator.wikimedia.org/T257862 (10Jdlrobson)