[00:59:03] (03PS1) 10Ejegg: Add entity for processor-specific contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704648 (https://phabricator.wikimedia.org/T283106) [01:01:26] eileen: what should I add to ^^^ to make it add the new table on upgrade? [01:02:13] ah, needs an Upgrader.php? [01:03:51] ok, generated one with civix, let's see what we put in there [01:06:07] cool, with an upgrade_xxx fn, I get the 'execute the updates' prompt [01:08:55] (03CR) 10jerkins-bot: [V: 04-1] Add entity for processor-specific contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704648 (https://phabricator.wikimedia.org/T283106) (owner: 10Ejegg) [01:09:22] ah those fks are badly formed? [01:13:06] oh jeez how does it make all the tests fail? [01:35:25] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 9 others: Update Fundraising tech CI image to use upstream buildkit, no symlink for civi... - https://phabricator.wikimedia.org/T277500 [01:37:49] ejegg: I saw your question fly in but couldn't find where it was - just looking at the fks now [01:40:00] ejegg: try running civix generate:upgrader [01:40:22] I think the autoinstall.sql is not running because there is no generated upgrader [01:40:30] (03CR) 10Eileen: "try running civix generate:upgrader" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704648 (https://phabricator.wikimedia.org/T283106) (owner: 10Ejegg) [01:43:56] thanks! [01:44:36] I also had to massage the generated SQL to get the FK columns to match the 'precision' (really just display padding!) of the int columns [01:46:16] (03PS2) 10Ejegg: Add entity for processor-specific contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704648 (https://phabricator.wikimedia.org/T283106) [01:49:10] dang, I still get an error on the upgrade but it's not very clear what the problem is [01:49:18] Error: Upgrade org.wikimedia.smashpig to revision 1100 [01:49:53] oh, do I need an absolute path for that SQL file? [01:50:24] (03CR) 10jerkins-bot: [V: 04-1] Add entity for processor-specific contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704648 (https://phabricator.wikimedia.org/T283106) (owner: 10Ejegg) [01:50:30] no, executeSqlFile finds it relative to extensionDir [01:51:25] Yeah - it looks right - I'll pull it down & see [01:52:07] restoring dumped sql to pre-upgrade and trying without that added upgrade_1100 fn, just the pure generated Upgrader.php [01:52:44] so the SQL file from PS2 does run just sourcing it from mysql [01:55:46] ejegg: I think I see it [01:55:52] the function needs to return TRUE [01:56:08] aha, thanks! [01:56:30] And it looks like we DO need that fn for it to trigger that upgrade message [01:56:45] yep [01:56:52] the other is for on -install [01:57:16] ah, the auto_install.sql file isn't 'auto'-matically run? [01:59:13] (03PS3) 10Ejegg: Add entity for processor-specific contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704648 (https://phabricator.wikimedia.org/T283106) [02:01:08] ejegg: it should be when installing [02:01:19] but you want it to run an upgrade when updating on live [02:02:11] right, I hope it's not to cheesy for my upgrade fn to re-use that auto_install.sql file [02:02:50] I guess once we add another schema change i'd break the upgrade sql files out [02:03:02] OK, PS3 runs the upgrade cleanly [02:03:24] (03CR) 10jerkins-bot: [V: 04-1] Add entity for processor-specific contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704648 (https://phabricator.wikimedia.org/T283106) (owner: 10Ejegg) [02:03:46] and seems to create the table right [02:04:58] hmm, tests failing with DB Error: unknown error [02:05:14] lessee, on drush --in\json cvapi Setting.create [02:05:25] s/\\/=/ [02:06:04] now why would applying the WMF_SETTINGS_FILE give a db error? [02:06:29] guess I need to go to docker to see what a fresh setup looks like [02:08:19] ejegg: so my main thought looking through the code is that unless there is a good reason not to have an id field we should have id as the primary key. For the mailing provider data table we don't because of the volume - but it has been painful [02:08:37] so I think it's better just to have an id field as the primary key [02:08:47] ok, seems fine [02:09:35] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704648 (https://phabricator.wikimedia.org/T283106) (owner: 10Ejegg) [02:09:51] let' sjust make sure that is not transient [02:09:52] arg, i guess it's possible a donor could have two paypal accounts too [02:10:03] if it's possible they will.... [02:10:13] and we could create two shopper references for a donor in adyen [02:11:02] so that will make it a drag to find the correct one to make charges [02:12:00] wait, let me look back at the token table to make sure we don't have an extra field in there we could use [02:13:14] nice civix fix eileen [02:16:30] ok, I'll leave that patch as WIP till tomorrow and will add the ID column then [02:17:24] thanks again for spotting that error [02:24:07] eileen: yeah I did see that! I added a note to the releng task about giving us +2, if they don't reply there I guess we'll ping elsewhere... [03:48:46] eileen fr-tech we got +2 Verified for dev-images now too! :) :) https://phabricator.wikimedia.org/T274303#7212283 [03:49:25] it worked! [03:49:30] Nice [03:49:38] yeeee [03:49:40] eileen: thanks! :) [03:50:05] I'm so used to not having to do V+2 [03:50:42] yeah I guess that was the thinking of releng folks too heh ;p [03:53:23] 10Fundraising-Backlog, 10FR-Docker, 10Gerrit-Privilege-Requests, 10dev-images, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10AndyRussG) >>! In T274303#7212283, @thcipriani wrote: > Adjusted to give you V+2 and submit, try it n... [03:54:43] AndyRussG: so next challenge - I also tested Jack's patch - but I can't rebase it and .... it looks like ANOTHER permission we need [03:55:49] I was able to push it up as a commit with a new ref - [03:56:38] 10Fundraising-Backlog, 10FR-Docker, 10Gerrit-Privilege-Requests, 10dev-images, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10Eileenmcnaughton) @thcipriani is there an extra permission required to be able to rebase https://gerri... [03:59:06] eileen: ah cool fantastic! [03:59:55] I'm just about to push the image for smashpig also [03:59:57] AndyRussG: yeah - if they don't add a rebase permission fairly quickly I'll +2 my own gerrit (which is not my own code) [04:00:25] actually - I'll just do it huh? then we are not gonna get more conflicts when you push smashpig [04:01:01] sure go ahead! Just to be formal you could add a note saying it's another person's patch that you just resubmitted... [04:01:22] yeah no conflicts on the smashpig thing [04:01:57] where were the merge conflicts with the civiproxy one? I only see new files there [04:03:25] one lingering change for fr-dev wrt civiproxy btw is this one: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/685546 [04:04:30] however that one has something that looks possibly stalled in its "depends" tag? (switching the branch we use for civiproxy?) [04:06:11] AndyRussG: so I merged the main civiproxy one [04:06:46] the one you are flagging is in the other repo from the looks? [04:07:03] yeah indeed [04:07:44] 10Fundraising-Backlog, 10FR-Docker, 10Gerrit-Privilege-Requests, 10dev-images, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10Eileenmcnaughton) Also - I replaced the above since I couldn't rebase - and then found I can't abandon... [04:08:36] AndyRussG: it's a bit of a mess - this was +2 ages ago but not merged https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civiproxy/+/685543 [04:08:58] ditto https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civiproxy/+/664901 [04:09:46] eileen: right... I was kinda just ignoring it until we got to working on email preferences center again, since currently Adyen is the thing [04:09:53] I am submitting on the assumption that was thought to have been done (& also my philosophy that we just want to get everything to one state for our dev stuff & then we can fix further) [04:10:34] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] "Cool!!!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/699324 (owner: 10Eileen) [04:10:55] yeah agreed also with that approach eh [04:11:09] On that count, this one is now merged [04:11:10] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/699324 [04:11:38] cool thanks [04:11:52] eh sorry for not getting to it before, and thank u :) [04:11:54] so are we now at the state where our dev related patches are all merged? [04:12:34] eileen: getting closer all the time! https://gerrit.wikimedia.org/r/q/project:wikimedia%252Ffundraising%252Fdev [04:12:48] I'm just about to send up a new PS for the smashipg https listener one btw [04:13:10] ok cool - I'll standby & try that one [04:13:16] :) [04:14:45] (03CR) 10Eileen: [V: 03+2 C: 03+2] Add docker-compose.override.yml to .gitignore [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/697697 (owner: 10AndyRussG) [04:15:36] AndyRussG: do we need this or was it incorporated into what I merged yesterday - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/704396 [04:16:59] eileen: that'll depend on whether the new images are magically available in the WMF registry... lemme check [04:17:10] it's incorporated into what you merged just now on dev-images [04:19:17] eileen: yeah not yet published, I dunno if that happens on a daily or hourly cycle or is manual... https://docker-registry.wikimedia.org/ [04:19:47] hmm I guess we only just merged it [04:20:09] yeah... so if it works for you, I'd say go ahead and +2 that fr-dev change and then once all our images are there in the registry we can switch everything off docker hub [04:20:52] (03PS2) 10AndyRussG: Add smashpig https listener [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/704407 (https://phabricator.wikimedia.org/T268687) [04:21:18] ^ there's the smashpig one, also grabbing the image from docker hub for now [04:21:45] I haven't actually verified that it does the right thing, but at least I know the correct php code is running now [04:23:00] so that one plus the smashpig image one in dev-images are the patches working together there, but locally if you only pull down the fundraising-dev one it should work [04:23:56] So with that running (remember to do docker-compose down before updating) then you can run setup.sh and go to for example https://localhost:9006/adyen [04:24:04] (or whatever port you set for smashpig) [04:24:49] I was also able to debug into the smashpig code running on the apache in that image, so it seems good enuf for now I think! [04:26:13] (03PS1) 10Eileen: Readme fixes [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/704653 [04:26:59] AndyRussG: I put up ^^ so we can abandon https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/697696 without losing the info [04:28:02] cool done [04:29:06] AndyRussG: so you are saying I should +2 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/704396 [04:29:39] eileen: yeah that'd be great thx much for all this eh :) [04:29:56] (03CR) 10Eileen: [V: 03+2 C: 03+2] Update civi image with PATH for civix from repo [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/704396 (https://phabricator.wikimedia.org/T283044) (owner: 10AndyRussG) [04:30:27] so just to understand, the override and this one don't serve the same purpose? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/699324 [04:31:07] AndyRussG: so the override would be like the server default [04:31:15] if you are NOT using drush it would kick in [04:31:36] ah okok cool [04:33:06] and then if you use the override I guess you don't need to ever uncomment out those lines in config/civicrm/drush/site-aliases/aliases.drushrc.php ? [04:33:39] just asking in case you want to add a note about that too in the readme [04:35:03] so the override is overriding docker [04:35:09] but it is a system default [04:35:19] the drush commands override the override [04:35:28] ie they set the environment per process [04:36:06] ahhh right gotcha [04:36:09] cool thanks! [04:36:26] so do you want to expand on that in the readme or shall I +2 as is? [04:38:57] (03PS2) 10Eileen: Readme fixes [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/704653 [04:39:54] Andy is ^^ clearer? [04:41:45] yee lgtm thanks! [04:42:02] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] "ahhh yeeee :) :)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/704653 (owner: 10Eileen) [04:42:47] AndyRussG: I feel like we should consider swapping the day-to-day stuff to the top of that readme - I'm conscious that we will be onboarding someone soon [04:46:53] yeah [04:47:06] well let's also see what happens with the image registry [04:47:22] 'cause if that starts working we can revamp a lot of the image talk [04:48:57] AndyRussG: I'm getting 403 error on smashpig - just looking - but I also note there is no addition of the url in the final output (which probaby just needs adding) [04:51:29] hmm I guess 403 might be OK & I need the actual url [04:51:40] eileen: yes, this 403 is a happy 403 [04:51:54] if you add /adyen to the end you should see a SOAP XML output thingy [04:52:24] as in https://localhost:9006/adyen [04:52:36] I get 500 [04:52:45] huh [04:52:55] did you do docker-compose down and then up? [04:53:45] let me try - I ran setup.sh - but maybe too gently [04:54:18] with the latest patch set of https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/704407 [04:54:24] yeah also maybe hard refresh needed [04:54:55] ah yes definitely you'll need to bring down and up the application [04:55:08] hmm yeah I just did but ... - it's still the vendor thing [04:55:09] or maybe just if you say docker-compose up smashpig -d ? [04:55:22] huh works for me [04:56:14] eileen: do you have a vendor directory under src/smashpig/ ? [04:56:23] no - that's what I just spotted [04:56:24] if not then you need to tell setup.sh to run composer for the standalone smashpig [04:56:28] k that's it then [04:56:59] I thought it did it without asking if there is no vendor dir [04:57:07] or you could just find that line inside setup.sh and run it directly [04:57:12] no sadly no such smartness yet [04:57:26] we really do need to break up and fix up the setup there [04:58:37] yeah I guess - it's mostly just a few missing smarts that trip me up - [05:00:54] mmmm important stuff to make a not of [05:01:17] all add a mention on the script-fix-Phab-ticket [05:01:21] (03CR) 10Eileen: [V: 03+2 C: 03+2] "Seems to be working - I think we should add the url info to the output of setup.sh but non-blocking" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/704407 (https://phabricator.wikimedia.org/T268687) (owner: 10AndyRussG) [05:01:56] yeah the reason I didn't add the URL at the end is that you're not actually supposed to visit it [05:02:09] ah ok [05:02:39] and I thought it'd be better to figure out first how to actually use the listener with a payment processor, add that explanation to the README, and then maybe as appropriate add a short note at the end of setup.sh [05:03:04] (i.e. a short not with the final output of setup.sh) [05:03:17] OK fair enough [05:03:20] what about https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/703259/1/config/payments/LocalSettings.php [05:04:20] eileen: well that one's really fully on the payments side of things... notes here: https://phabricator.wikimedia.org/T266088#7204109 [05:04:35] if you want to test I can tell you how [05:05:00] but also you're more than welcome to ignore of course :) [05:05:47] even with that patch, payments tests won't pass... they'll still need a patch that's in Gerrit for DonationInterface [05:05:52] (03CR) 10Eileen: [C: 03+1] "The other is merged - it got stalled on 'submit' not being actioned - @jgleeson please go ahead & +2 / merge this is you are happy for it " [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/685546 (owner: 10Jgleeson) [05:06:17] oh ok - I guess I'll leave that one then [05:06:40] k yeah thanks so much for all this help btw also :) [05:08:44] 10Fundraising-Backlog, 10FR-Docker: Docker dev setup: break out setup.sh into smaller scripts, maybe add a few new ones - https://phabricator.wikimedia.org/T278728 (10AndyRussG) Quick note for a feature here: somewhere or other, composer should be run automatically, maybe when there's no vendor directory? [05:09:09] (03CR) 10Eileen: Remove nonsense if (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704211 (owner: 10Eileen) [05:12:02] AndyRussG: I see the time on https://docker-registry.wikimedia.org/ is incrementing each hour - but the images are not magically appearing [05:12:39] hmmm interesting [05:12:44] however the older images are indeed there [05:13:46] Looks like that update is just for the job that updates the registry's public-facing page: https://gerrit.wikimedia.org/g/operations/puppet/+/refs/heads/production/modules/docker_registry_ha/files/registry-homepage-builder.py [05:14:07] If the new images aren't there tomorrow I can ask releng [05:14:18] cool - it would be nice to get somewhere on that [05:14:30] yeah absolutely that'll be great [05:15:04] AndyRussG: can I get you to +2 this one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/702497 - it just fixes an enotice because from the CLI those vars might not be set [05:15:07] K I believe it's now sleepy sleepy time time [05:15:51] ok no worries I'm going offline too [05:16:03] K thanks again, cya! :) :) [09:25:10] 10Fundraising-Backlog: Edit to Japanese TY Email - https://phabricator.wikimedia.org/T286706 (10CDenes_WMF) [13:26:56] 10Fundraising-Backlog, 10FR-Docker, 10Gerrit-Privilege-Requests, 10dev-images, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10thcipriani) >>! In T274303#7214004, @Eileenmcnaughton wrote: > Also - I replaced the above since I cou... [14:06:11] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-AutoTY-Email, 10fr-donorservices: Endowment Auto Thank You Email needs small copy change - https://phabricator.wikimedia.org/T284184 (10KHaggard) Thanks @Eileenmcnaughton ! Let me check with @TSkaf... [14:28:25] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising sprint Legø Trampoline, 10FR-AutoTY-Email, 10fr-donorservices: Endowment Auto Thank You Email needs small copy change - https://phabricator.wikimedia.org/T284184 (10KHaggard) 05Open→03Resolved Just sent myself a test email... [15:09:26] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10FR-AutoTY-Email: Edit to Japanese TY Email - https://phabricator.wikimedia.org/T286706 (10DStrine) [15:16:35] (03PS1) 10Ejegg: Edit Japanese TY email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704803 (https://phabricator.wikimedia.org/T286706) [15:16:56] fr-tech ^^^ is the fix dstrine just requested [15:18:04] (03PS4) 10Ejegg: Fix enotice when running during setup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702497 (owner: 10Eileen) [15:18:28] hah ejegg beat me to it [15:18:28] (03CR) 10Ejegg: [C: 03+2] Fix enotice when running during setup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702497 (owner: 10Eileen) [15:18:54] oh lemme rebase over that other one [15:19:00] (03PS2) 10Ejegg: Edit Japanese TY email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704803 (https://phabricator.wikimedia.org/T286706) [15:19:35] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Some CentralNotice translatable banner messages do not return message definition - https://phabricator.wikimedia.org/T286699 (10DStrine) [15:19:37] cstone I had a patch up to add that processor-specific donor id [15:19:46] nice ejegg [15:20:02] but now i'm realizing it really needs to be attached to the payment_token, not the donor [15:20:15] (03CR) 10AndyRussG: [C: 03+2] Edit Japanese TY email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704803 (https://phabricator.wikimedia.org/T286706) (owner: 10Ejegg) [15:20:35] so like you said, tempting to misuse another one of those payment_token fields [15:21:08] or I guess the invoice_id on the contribution_recur table wouldn't be such a misuse [15:21:51] well, at least I had the experience of adding a new entity in an extension [15:22:48] so maybe we try going with that invoice_id ? [15:23:02] I guess we still have to migrate all the existing adyen tokens [15:23:48] did you see my test where I did get the token id back for an old recurring? [15:24:19] i saw that gerrit patch to add an Api.php method - is that what you're referring to? [15:25:27] i added more on the phab for what it returns but yeah I used that with an old shopper reference and it returns the token id [15:26:29] cool cool. I guess we would want a paymentProvider-level call for that too, then we write an Api method in the SmashPig CRM extension to use that call to update a recur record [15:26:51] yeah it was just a test to see what it returned I should have put WIP on it [15:27:39] ah yeah, no worries on that. thanks for sharing the draft! [15:29:11] (03Merged) 10jenkins-bot: Fix enotice when running during setup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/702497 (owner: 10Eileen) [15:31:05] (03Merged) 10jenkins-bot: Edit Japanese TY email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704803 (https://phabricator.wikimedia.org/T286706) (owner: 10Ejegg) [15:32:13] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/704805 [15:32:27] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/704805 (owner: 10Ejegg) [15:46:32] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/704829 [15:46:41] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/704829 (owner: 10Ejegg) [15:47:57] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/704829 (owner: 10Ejegg) [16:04:08] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/704834 [16:14:24] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/704834 (owner: 10Ejegg) [16:22:53] ooh, that's a bigger payments-wiki deploy than I expected [16:23:36] 10Fundraising-Backlog, 10FR-Docker, 10Gerrit-Privilege-Requests, 10dev-images, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10AndyRussG) @thcipriani thanks so much for all your help on this, it's hugely appreciated!! :) Ahh jus... [16:24:04] !log updated payments-wiki from 0e7800027a to 844b59ee42 [16:24:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:27:39] !log updated fundraising CiviCRM from e0d53c92b5 to 20e9ef6bbb [16:27:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:28:57] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10FR-AutoTY-Email: Edit to Japanese TY Email - https://phabricator.wikimedia.org/T286706 (10Ejegg) This is deployed [16:30:31] fr-tech I will need to leave standup early. I've gotta go pick up Oscar as he's at his school friend's house. [16:31:48] 10Fundraising-Backlog, 10FR-Docker, 10Gerrit-Privilege-Requests, 10dev-images, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10thcipriani) >>! In T274303#7215535, @AndyRussG wrote: > @thcipriani thanks so much for all your help o... [16:40:44] !log updated payments-wiki from d9892207c1 to 844b59ee42 [16:40:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:53:23] 10Fundraising-Backlog, 10FR-Docker, 10Gerrit-Privilege-Requests, 10dev-images, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10brennen) > My understanding is there's still a manual step of actually publishing these image (unless... [16:57:06] fr-tech i'm going to relocate back out to the lake so I can have a desk be back in like 15 [17:08:48] 10Fundraising-Backlog, 10FR-Docker, 10Gerrit-Privilege-Requests, 10dev-images, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10AndyRussG) >>! In T274303#7215593, @brennen wrote: >> My understanding is there's still a manual step... [17:15:37] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-Banners, 10donate.wikimedia.org, 10MW-1.37-notes (1.37.0-wmf.15; 2021-07-19): Disable AMEX for JP campaign 2021 - https://phabricator.wikimedia.org/T286657 (10Ejegg) OK, AMEX is off the JP forms [17:58:45] fr-tech I gotta admit it's pretty sad seeing freenode looking like a ghost town after it's recent implosion. I remember asking questions on how to use PHP in the official channel before I even considered doing it as a job [17:59:21] building counterstrike class sites trying to understand how to use phpnuke [18:00:03] it's just servers, man, the team and the community is all here on liberachat [18:00:18] jgleeson: it was sad how it went but the community ain't lost [18:00:52] s/class/clan/ [18:01:41] yeah ejegg RhinosF1 good point. The spirit of freenode still lives! [18:02:14] Open source is a very resilient community [18:02:33] Projects are quite happy to tell people like Andrew to do one [18:24:06] jgleeson: "Men fight and lose the battle, and the thing that they fought for [18:24:08] comes about in spite of their defeat, and then it turns out not to be [18:24:10] what they meant, and other men have to fight for what they meant [18:24:12] under another name. [18:24:14] William Morris" [18:24:41] (epigraph in Negri and Hardt's Empire) [18:24:53] RhinosF1 ^ [18:25:02] ejegg ^ [18:51:43] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Some CentralNotice translatable banner messages do not return message definition - https://phabricator.wikimedia.org/T286699 (10Rileych) @DStrine Is this blocked or not fr-tech? We're unsure about how to proceed. Thank you! [18:53:08] AndyRussG: I read that on someones user page recently! it their favourite quote [18:53:18] it was* [18:53:26] yours maybe? [19:10:55] jgleeson: some nostalgia is healthy :) [19:15:48] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Some CentralNotice translatable banner messages do not return message definition - https://phabricator.wikimedia.org/T286699 (10AndyRussG) >>! In T286699#7215818, @Rileych wrote: > @DStrine Is this blocked or not fr-tech? We're unsure about how to p... [19:18:54] jgleeson it is one of my favorites (unfortunate sexist language aside) but it wasn't on my page [19:20:18] :) Nemo_bis [19:20:40] ah ok AndyRussG... another fan is out there! [19:58:12] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Adyen, 10FR-Smashpig: Adyen Checkout: Handle new shopper reference field - https://phabricator.wikimedia.org/T286739 (10Ejegg) [19:58:43] cstone want to read ^^^ and let me know if you think that sounds like a good plan? [19:59:54] I guess if your SmashPig createPayment code was able to deal with both old-style (one ID) and new-style (two IDs) requests [20:00:04] nice ejegg and a nice way to distinguish between new and old I couldn't think of a good way [20:00:43] we need to send payment method through on crm too but its right there in the line above it already [20:02:36] oh hmm, we wouldn't just send a different value depending on which class we're in ? I.e the card payment provider sends 'scheme' and the DirectDebitPaymentProvider sends 'ideal' ? [20:02:58] that works too [20:03:52] yah, let's keep the number of required params to a minimum [20:04:13] yeah [20:05:21] ooh, here's a dumb thought: what if we were just really lazy and kept only storing the shopper reference, then had SmashPig always look up the stored token before making a charge? [20:05:58] ehh, no, more lookups = more points of failure [20:09:53] oh hmm, i just realized the plan in the ticket lets us switch from all-old-style charges to all-new-style charges with just a CRM deploy (not a SmashPig version change) [20:10:11] but... it doesn't let us switch over just a few recurrings [20:10:13] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: record which email addresses are on the MSL in civi - https://phabricator.wikimedia.org/T286741 (10DStrine) [20:10:31] since the CRM extension code will go from always sending one to always sending both [20:11:00] I guess if the SmashPig code detected when both were the same value, then treated that like the single-value case, we could switch over gradually [20:11:25] seems super ugly, but we could get rid of all that detection and the old code once the old ones were all transitioned [20:11:59] gonna go out on a bicycle for a real short ride to see if I focus better after [20:16:26] (03CR) 10Cstone: [C: 03+2] "This works really nicely and will save a lot of time and testing worry!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704445 (https://phabricator.wikimedia.org/T283106) (owner: 10Ejegg) [20:17:58] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Test relationship giving history with search kit - https://phabricator.wikimedia.org/T286742 (10DStrine) [20:28:05] (03Merged) 10jenkins-bot: New parameter to test SmashPig recurring job [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704445 (https://phabricator.wikimedia.org/T283106) (owner: 10Ejegg) [20:59:22] thanks cstone [20:59:55] ok cstone, so I'll take a crack at the CRM parts of that ticket if you want to keep doing the SmashPig parts [21:00:39] sounds good ejegg [21:03:15] for the switch between old and new, could it just be an if in the cardpaymentprovider where it makes an extra call if there is no token? [21:03:54] so the issue is that the old ones actually HAVE values in both fields, it's just the same value [21:04:08] ah okay [21:04:26] at least, i'm pretty sure it is [21:04:39] i thought invoice_id was just unused [21:04:47] we don't update the contribution_recur.invoice_id every time, do we? [21:04:51] ohhhh, is it blank? [21:04:53] checking [21:05:02] it is locally for me [21:05:08] maybe paypals have something? [21:05:14] ok then, that's perfect [21:05:23] so we can go with the plan in the ticket [21:05:51] and when the processor_contact_id is blank your code calls the old WSDL create [21:06:10] that just means there's one more piece of work on the CRM side [21:06:30] to populate that field when creating the new recurrings [21:07:30] processor_contact_id = shopperReference = contributionRecur.invoice_id ? [21:20:07] yep yep yep cstone ^^ [21:21:32] yep, confirmed on prod those invoice_ids are all NULL for adyen [21:23:46] so I guess we add the new field to messages from payments-wiki too [21:58:57] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-production-error: TypeError: Cannot read property 'key' of undefined - https://phabricator.wikimedia.org/T285482 (10Krinkle) 05Open→03Declined The stack from `setBannerShown()` onwards is in built-in CentralNotice code and takes no... [21:59:48] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wiki-Loves-Monuments: It should not be possible to run a banner campaign with a syntax error - https://phabricator.wikimedia.org/T268792 (10Krinkle) Good idea for preventing errors. Not in itself a concrete error, however. [22:16:25] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-production-error: TypeError: Cannot read property 'key' of undefined - https://phabricator.wikimedia.org/T285482 (10AndyRussG) @Krinkle thanks!! :) [22:38:32] (03PS1) 10Ejegg: WIP api4 call to update payment token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704871 (https://phabricator.wikimedia.org/T286739) [22:38:42] cstone: ^^^ should theoretically do it [22:39:02] but I think I'm missing something to register the API call as existing [22:40:04] eileen: is there something obvious to your eye to explain why I can't make that new API call? [22:40:07] drush cvapi --version=4 ContributionRecur.updateToken contributionRecurId=1995 processorName=adyen [22:40:10] API (ContributionRecur, updatetoken) does not exist (join the API team and implement it!) [22:40:58] ejegg: I think the version shouldn't have -- [22:41:06] aha [22:41:10] & it should go after entity.action [22:41:17] it's an api parameter [22:41:43] oh hey, that worked! Now I get Authorization failed :P [22:41:44] thanks! [22:42:36] adding a --user=1 fixes the auth [22:44:56] nice ejegg I'll try it after dinner [22:46:32] cstone: it's making a call to the SmashPig paymentProvider that currently is only on the SmashPig Api.php class, so you'll need to add that pass-through bit to your SmashPig patch to make it actually work [22:49:52] (03PS2) 10Ejegg: WIP api4 call to update payment token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704871 (https://phabricator.wikimedia.org/T286739) [22:51:50] 10fundraising-tech-ops: Civi access for contractors - https://phabricator.wikimedia.org/T286750 (10Dwisehaupt) [23:15:37] (03CR) 10AndyRussG: [C: 03+2] Adyen Checkout: minor cleanup (031 comment) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702756 (owner: 10Ejegg) [23:31:26] (03Merged) 10jenkins-bot: Adyen Checkout: minor cleanup [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702756 (owner: 10Ejegg)