[03:01:36] 10Fundraising-Backlog, 10FR-Docker: Docker dev setup: break out setup.sh into smaller scripts, maybe add a few new ones - https://phabricator.wikimedia.org/T278728 (10Ejegg) We might want to crib what the vagrant folks did with `vagrant git-update`: https://github.com/wikimedia/mediawiki-vagrant/blob/master/pu... [06:20:30] (03CR) 10AndyRussG: "Looks good, works as advertised! See just one inline comment... Thanks much!!! :)" (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702748 (https://phabricator.wikimedia.org/T285962) (owner: 10Ejegg) [06:23:09] (03PS1) 10AndyRussG: Disable session velocity filter for Payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705336 [06:55:06] (03PS1) 10AndyRussG: Send log messages from rsyslogd itself to a separate file [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705340 [07:01:10] (03PS1) 10AndyRussG: Ignore smashpig xdebug config [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705344 [08:27:20] 10Fundraising-Backlog: Adding disambiguation clause to Payments Wiki in France - https://phabricator.wikimedia.org/T286880 (10CDenes_WMF) [08:28:42] 10Fundraising-Backlog: Adding tax disambiguation clause to Payments Wiki in France - https://phabricator.wikimedia.org/T286880 (10CDenes_WMF) [13:01:42] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10MSuijkerbuijk_WMF) Hi @DStrine -- could I ask if there's any update or info needed on this task? Thanks! [13:44:15] (03PS1) 10Ejegg: Fix adding txn ID [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/705380 (https://phabricator.wikimedia.org/T282641) [14:12:21] (03CR) 10Ejegg: "> Patch Set 1:" (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702748 (https://phabricator.wikimedia.org/T285962) (owner: 10Ejegg) [14:36:24] test [14:36:30] can you see this damilare [14:36:49] yes I can [14:37:59] awesome [14:43:05] hello fr-tech [14:43:26] fr-tech our newest fr-techer is in the house. damilare :) [14:45:17] Welcome damilare !! [14:45:31] Indeed welcome [14:49:26] Thanks everyone [15:13:28] welcome damilare ! [15:25:48] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10DStrine) this isn't in an active sprint. I has hoping to get this into the next sprint, starting tomorrow. [15:27:41] so we've got the deduper stuck on a certain contact, it looks like? [15:28:02] fr-tech do folks know what to do to investigate those failmails? [15:28:31] and damilare are you getting emails every 25 min with a subject like 'Dedupe CiviCRM contacts failed with code 1' ? [15:28:47] (if not, we need to add you to an email list or two) [15:30:12] ooh, this one's a SQL syntax error! let's see what's going on with that [15:30:13] Thank you ejegg, no I'm not getting those emails. Should I be getting them? [15:30:41] Oh ok then [15:31:18] yes damilare, I think we need to add you to the 'fr-tech-failmail' list. Jeff_Green - can you add him to that list, or should I ask OIT? [15:31:48] damilare: that list receives automated emails from our scheduled job runner when jobs break [15:32:20] and from the payments site when there are certain kinds of errors connecting to the card processing companies [15:32:40] so unfortunately it's not always obvious how serious a problem is. [15:33:07] the current problem that's resulting in an email every 25 minutes is medium-low seriousness. [15:33:28] It's with a scheduled job to find duplicate contacts in the database and combine them into one record [15:34:20] ok noted, would be on the look out for them [15:34:33] We worry about that job when we are sending a lot of email to previous donors who have not yet given this year [15:35:25] because if a donor gives and we create a new record, but DON'T merge it into the existing one, we sometimes keep emailing the donor asking for a donation [15:35:38] and that's one of the quickest ways to make people complain [15:36:30] hi dwisehaupt ! Our new hire damilare is in the chat, and we've just discovered he's not on the fr-tech-failmail list yet. Can you add him to that, or should I ask OIT? [15:37:21] let me take a look. i'm pretty sure that's one we control. [15:37:40] damilare: OIT = Office Information Technology, the people who run the staff network, fileserver, and a bunch of mailing lists [15:38:16] howdy damilare! glad to have you here. [15:39:10] noted, thank you ejegg [15:39:20] not to be confused with SRE (Site Reliability Engineering), the (larger) group that manages operations for the wiki* web sites + backend data centers [15:39:38] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10MSuijkerbuijk_WMF) Thanks for the update. [15:40:56] ejegg: actually, it looks like that is one that OIT/ITS should handle. i'm not seeing it in any of the aliases files we handle. [15:41:11] ok, thanks dwisehaupt. I'll send an email to them [15:44:04] sent [15:44:40] so I see the SQL error in the log - there's a space missing [15:44:58] Reviewing revent deduper changes to see where it might have been introduced [15:56:30] so it doesn't SEEM to be related to the very last change - that added a new table for japanese family names [15:56:45] but the SQL error is with the pre-existing nickname table [16:04:23] ejegg -- sure, is it damilare@wm.o? [16:05:00] Jeff_Green: thanks! dwisehaupt actually already checked and said it was a job for OIT [16:05:03] so I emailed them [16:05:09] no it's dadedoyin@wikimedia.org [16:05:16] oh oops [16:05:24] I need to send another email [16:05:27] ejegg: it's actually something I can do [16:05:33] damilare got it, thx! [16:05:37] oh, ok, thanks Jeff_Green ! [16:05:39] yeah. looks like it's in a repo i don't have access to. :) [16:05:48] sorry about that. [16:05:56] will email OIT in any case to say you've got it covered [16:06:17] awesome thanks jee_Green and ejegg [16:06:27] jeff_Green* [16:06:37] ejegg: should I add to the other *failmail lists too, since I'm in there? [16:07:38] Yes please Jeff_Green, and to any other fr-tech lists that e.g. cstone and jgleeson are on [16:07:46] cool [16:09:03] done (ish, give it 15m or so to propagate) [16:11:06] ok, regarding this particular failmail I don't see an obvious cause [16:11:22] so I'mma just try to focus more on adyen [16:11:36] and let eileen handle the deduper when she comes online [16:19:37] hi damilare!!! welcome to the org and to the team!!! :) [16:20:27] hi also fr-tech ejegg Jeff_Green cstone jgleeson XenoRyet dwisehaupt [16:20:34] hi AndyRussG [16:20:46] :) [16:20:50] hey AndyRussG [16:20:58] hi AndyRussG [16:21:04] :) :) [16:21:25] hi AndyRussG, thank you! [16:23:47] damilare :) looking forward to meeting "virtually in person", please don't hesitate to reach out anytime with any questions or if you need anything at all btw [16:25:10] Thanks AndyRussG, I sure will [16:25:10] btw also I don't know if you've heard yet, but you can get the whole team's attention anytime by typing "fr-tech" here or in any other IRC channel folks are in [16:26:42] and I guess you can also add that on your IRC client to the words that will cause an alert for you [16:27:46] (apologies if u knew that already) [16:28:26] hi AndyRussG ! [16:30:09] jgleeson :) [16:38:54] AndyRussG: so those sha suffixes removed in the docker-compose.yaml patch are unneeded with the images pushed to the WMF registry? [16:39:20] damilare: do you have a gerrit account yet? I'll add you to our group there if so [16:41:00] Thank you AndyRussG, I didn’t know that and I definitely need tips like this. Please keep them coming [16:42:19] 10fundraising-tech-ops: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10Jgreen) [16:42:41] 10fundraising-tech-ops: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10Jgreen) [16:43:28] damilare: I just added you as an optional invitee to the fundraising-department-wide Monday check-in meetings (today's starts in 17 min). dstrine always attends those to let the non-tech fundraising folks know what our team is doing, but usually a couple of us programmers attend too, just to keep an eye on what the department might need. [16:43:50] I haven’t setup an account on gerrit yet ejegg. Give me a few minutes [16:44:27] Ok ejegg, thank you [16:44:38] ok, cool. The procedure for gerrit is to first make an account at https://wikitech.wikimedia.org [16:44:56] then to use those credentials to log in at https://gerrit.wikimedia.org [16:45:12] oh heh, looks like gerrit is currently being upgraded [16:45:36] so you'll have to wait a bit fin any case. [16:45:42] *for that second step in any case [16:49:57] Ok sounds good. [16:50:36] Sorry afk at the moment, trying to get lunch. Can I get back to this in about 45mins [16:51:21] Got my first fail mail just now [16:51:28] Fail Mail (civi1001) run-job: Dedupe CiviCRM contacts failed with code 1 [16:54:31] damilare: no problem go eat! [16:55:12] also I just realised you might not have been sent the "become a mediawiki hacker" onboarding link which I think includes all the info about setting up your wikitech account [16:55:32] ejegg: XenoRyet sent over a bunch of links for damilare to get stuck in [16:56:58] I think this was the page we used to give out https://office.wikimedia.org/wiki/Guide_for_new_engineering_staff [16:57:11] but apparently that's now obsolete [16:58:17] it's probably still ok as a rough guide, what you think XenoRyet ? [17:00:25] looks like there's tons of good onboarding stuff here damilare https://office.wikimedia.org/wiki/Technology/Onboarding/Checklists/Template [17:00:37] ah that's if you can log in to officewiki [17:01:06] lemme know when you get back from lunch and if not we can work out how to get you access [17:02:18] it looks like we do have a link to that "obsolete" page in our onboarding draft here https://collab.wikimedia.org/wiki/Fundraising/Engineering/Draft:OnboardingDoc [17:02:58] Thank you jgleeson I have an account for officewiki and going through the checklists. However I’m not sure I’ve seen the “Become a media wiki hacker” document [17:05:23] damilare: sorry!! that specific page probably isn't relevant just yet but for reference in case you wanna take a peek it's here https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [17:15:17] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: record which email addresses are on the MSL in civi - https://phabricator.wikimedia.org/T286741 (10EYener) Update on the immediate use case for this that I was able to pretty easily provide an update for the Email team on who was / was not on the MSL on t... [17:18:49] phew, pressure's on for Adyen [17:19:11] so let's see why that lil CRM patch to add the new param is failing tests [17:19:50] oh AndyRussG i have a tiny update to a patch you +2ed over the weekend: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/705380 [17:20:17] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: record which email addresses are on the MSL in civi - https://phabricator.wikimedia.org/T286741 (10DStrine) Thanks for the note! I'll keep this open just in case we need this in the future. [17:21:00] 10Fundraising-Backlog, 10FR-France: Adding tax disambiguation clause to Payments Wiki in France - https://phabricator.wikimedia.org/T286880 (10DStrine) [17:22:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: dupe contact found with first/last names in wrong positions. - https://phabricator.wikimedia.org/T286496 (10DStrine) [17:26:30] ejegg: I'm still trying to work out why we're getting the 422 error with Applepay. I think it might be due to us sending in the config in an invalid format [17:27:15] if we can't figure it out then we'll probably need to speak to them again as this time we've done everything they've asked for [17:28:18] ejegg: did you have a way to see the adyen typescript from your browser? I remember you saying something about type hints making it easier. Currently I'm stepping through it in Safari and it's a horrible experience [17:29:24] (03CR) 10AndyRussG: [C: 03+2] "lgtm! :)" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/705380 (https://phabricator.wikimedia.org/T282641) (owner: 10Ejegg) [17:30:19] ejegg: in response to your earlier question about docker-compose.yaml sha suffixes--correct, they're not needed in the WMF registry [17:30:38] those were only added on the tags for the images uploaded to Docker Hub [17:31:01] their purpose was to distinguish which exact unmerged Gerrit patch set the images were generated from [17:31:46] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: update the docs on the civi-acoustic import and export scripts - https://phabricator.wikimedia.org/T286934 (10DStrine) [17:31:48] now with the WMF registry we're getting only merged images, with the tags as specified in the changelog/control files in each image config directory in dev-images/dockerfiles [17:32:22] (03Merged) 10jenkins-bot: Fix adding txn ID [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/705380 (https://phabricator.wikimedia.org/T282641) (owner: 10Ejegg) [17:47:54] jgleeson oh bummer about safari dev tools. The firefox dev tools seem to load all the TS files from the .map automatically when one opens the debug tab [17:57:07] ejegg|food: I think i see what you mean now [18:38:03] along with meeting damilare/n [18:38:59] heh. nothing to see there. just talking about the agenda for the meeting in a few. :) [18:39:45] dwisehaupt :) [18:50:48] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fr-donorservices: Ingenico status 190s question - https://phabricator.wikimedia.org/T283524 (10DStrine) [18:52:34] PROBLEM - check_mysql on payments1005 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [18:56:22] ^^ that is us doing a mysql primary swap for payments. swap is all done just finishing up the puppet bits now. [18:57:34] PROBLEM - check_mysql on payments1005 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [19:02:04] 10fundraising-tech-ops: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10Jgreen) [19:02:34] RECOVERY - check_mysql on payments1005 is OK: Uptime: 1461812 Threads: 28 Questions: 11767414 Slow queries: 0 Opens: 115 Flush tables: 1 Open tables: 109 Queries per second avg: 8.049 [19:04:58] 10fundraising-tech-ops: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10Jgreen) [19:13:32] (03CR) 10AndyRussG: [C: 03+2] "> So yeah, it's a situation we should try to handle, just not here." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702748 (https://phabricator.wikimedia.org/T285962) (owner: 10Ejegg) [19:14:08] (03Merged) 10jenkins-bot: Adyen: setting for capture on receiving auth IPN [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702748 (https://phabricator.wikimedia.org/T285962) (owner: 10Ejegg) [19:14:10] (03Merged) 10jenkins-bot: Adyen: array initialization tweaks, DRY [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702750 (https://phabricator.wikimedia.org/T277120) (owner: 10Ejegg) [19:14:43] ^ wow speed of light Jenkins today [19:15:02] 10fundraising-tech-ops: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10Jgreen) [19:15:15] 10fundraising-tech-ops: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10Jgreen) [19:19:31] 10fundraising-tech-ops, 10Patch-For-Review: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10Jgreen) [19:21:03] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: dupe contact found with first/last names in wrong positions. - https://phabricator.wikimedia.org/T286496 (10CaitVirtue) Yes, ok to delete CID 51128128 [19:26:59] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: dupe contact found with first/last names in wrong positions. - https://phabricator.wikimedia.org/T286496 (10DStrine) 05Open→03Resolved a:03DStrine thanks! I've deleted this contact. The originally reported bug of the TY mail was due to manual creati... [19:39:19] 10fundraising-tech-ops, 10Patch-For-Review: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10Jgreen) [19:54:29] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline: New Payment Method added: Money Order - https://phabricator.wikimedia.org/T283023 (10DStrine) [19:55:12] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline: New Payment Method added: Money Order - https://phabricator.wikimedia.org/T283023 (10DStrine) Per our talk in civi fortnightly, we'll hold off on this until we hear back fr... [19:57:30] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Benefactor Page Listing Custom field - https://phabricator.wikimedia.org/T281268 (10DStrine) [19:57:32] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Automatic date added when Benefactor Page Listing fields are updated - https://phabricator.wikimedia.org/T282448 (10DStrine) [20:05:09] (03CR) 10Eileen: Pull images from WMF Registry (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705017 (owner: 10AndyRussG) [20:18:25] 10fundraising-tech-ops: Fundraising access request for Damilare Aderdoyin - https://phabricator.wikimedia.org/T286956 (10XenoRyet) [20:22:21] 10fundraising-tech-ops: Fundraising access request for Damilare Aderdoyin - https://phabricator.wikimedia.org/T286956 (10Dwisehaupt) a:03Dwisehaupt [20:48:09] (03PS2) 10AndyRussG: Pull images from WMF Registry [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705017 [20:48:57] (03CR) 10AndyRussG: "Thanks!!" (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705017 (owner: 10AndyRussG) [21:03:00] AndyRussG: I was worried about losing the mention of the -w switch altogether - because when we are next working on the image development we might want that info? [21:05:05] although perhaps it only relates to docker hub I thought it might relate to when we are building / tweaking [21:09:30] \x0D is the escaped hexadecimal Carriage Return. The equivalent of \r [21:09:35] yep ejegg|brb [21:24:10] (03CR) 10Eileen: [C: 03+2] "I just tested this & it works well & is an appreciated improvement" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705340 (owner: 10AndyRussG) [21:24:15] (03PS2) 10Eileen: Send log messages from rsyslogd itself to a separate file [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705340 (owner: 10AndyRussG) [21:24:50] (03CR) 10Eileen: [C: 03+2] "Yep I spotted the need for this too" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705344 (owner: 10AndyRussG) [21:24:55] (03PS2) 10Eileen: Ignore smashpig xdebug config [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705344 (owner: 10AndyRussG) [21:25:04] (03CR) 10Eileen: [V: 03+2 C: 03+2] Ignore smashpig xdebug config [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705344 (owner: 10AndyRussG) [21:25:16] (03CR) 10Eileen: [V: 03+2 C: 03+2] Send log messages from rsyslogd itself to a separate file [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705340 (owner: 10AndyRussG) [21:36:57] ejegg|brb: so the reason I wasn't seeing a response is because I think the cached result is being sent back instead [21:39:15] (03CR) 10Eileen: [C: 03+1] "I got rid of all my images & did docker-compose up - and it built & so the actual change is good. My only worry is that we might be removi" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705017 (owner: 10AndyRussG) [21:41:43] I merged some of the docker fixes - but this just needs a super quick check by someone who knows more about the payment velocity filter setting https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/705336 [21:43:36] that's fine eileen [21:44:10] jgleeson: cool - also - did you see - your docker patch should be mergeable now - I just left it to you to confirm it still should be [21:44:16] but the dependency is merged [21:46:50] the session velocity filter basically throttles donation attempts by IP to prevent carders and bots, which we can turn off locally [21:47:20] cool [21:47:33] ah ok eileen I did see something but it looked like an old one for civiproxy [21:47:38] I'll check it before I jump off [21:48:03] jgleeson: yeah - if not needed you can abandon - but we have all those images coming from the right place now [21:48:20] (03CR) 10Eileen: [V: 03+2 C: 03+2] "Jack confirmed we should make this change" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705336 (owner: 10AndyRussG) [21:48:26] (03PS2) 10Eileen: Disable session velocity filter for Payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705336 (owner: 10AndyRussG) [21:48:34] (03CR) 10Eileen: [V: 03+2 C: 03+2] Disable session velocity filter for Payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705336 (owner: 10AndyRussG) [21:53:31] oh hey I was actually mixing up the IP Velocity filter with the Session Velocity filter then. The Session filter (which AndyRussG has turned off) actually throttles at the session level and not attempt from the IP. Still fine to turn off locally [22:02:56] oh nice that the session got turned off i was going to put up a patch for that [22:03:08] (03CR) 10Jgleeson: [C: 03+2] "This is good to go!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/685546 (owner: 10Jgleeson) [22:04:51] bye for now fr-tech [22:57:14] (03CR) 10AndyRussG: [V: 03+2] "Thanks much @Jgleeson @Eileen! :)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/685546 (owner: 10Jgleeson) [23:14:39] cstone: you might have an opinion on this one -https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/703259 - I thought the 'tests pass' bit was compelling :-) [23:16:25] (03CR) 10AndyRussG: "> Patch Set 2: Code-Review+1" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/705017 (owner: 10AndyRussG) [23:16:51] eileen: ^ follow-up on your comment :) [23:17:15] thanks much for all the review btw! [23:19:02] fr-tech any thoughts on this one? (for making payments tests pass under fr-dev) https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/703259 [23:21:22] i was distracted taking sun pictures but i can look now [23:22:27] https://photos.app.goo.gl/pUW9avDHSMqf7jwF7 just a normal day here [23:24:54] orange suns are back. [23:25:02] cool pic! also thx much in advance :) [23:25:13] I think that's clouds, though, not forest fire smoke? I hope....... [23:25:19] its fire smoke [23:25:23] from canada :P [23:25:26] oh noes! [23:25:31] ahhhhh [23:25:58] should be interesting closer to the horizon [23:26:04] I've like never heard of forest fires anywhere even vaguely near Montreal [23:26:32] I did read about smoke in Alberta... is it drifting in all the way from there or are there fires in Ontario or Quebec? [23:26:32] i assume northern parts of ontario or quebec i dont knoe exactly where it is [23:26:45] but could possibly be alberta cause we have gotten a TON of rain here [23:27:28] like the upper waterfall went from being turned off to flood stage like in a week [23:29:27] https://fire.airnow.gov/ [23:29:32] https://www.windy.com/-Aerosol-aod550?aod550,47.288,-87.803,5 [23:30:47] hmm maybe on the border there? [23:30:53] https://cartes.sopfeu.qc.ca/?lang=en#incendies [23:31:24] maybe like u said up north? [23:32:43] AndyRussG: do I need to reload anything to get that change to take effect im seeing the same amount of failures before and after [23:33:45] cstone: to make all tests pass you need this patch (which actually currently needs rebasing) https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/703258 and also to pull the most recent config-private changes [23:34:03] I can rebase the DI change [23:34:19] (03PS2) 10AndyRussG: PHPUnit tests: reset globals and use salt in API tests [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/703258 (https://phabricator.wikimedia.org/T266088) [23:35:30] ah okay [23:35:36] well i trust it fixes something in the meantime [23:35:51] rebase done btw, just an easy click in the UI [23:36:23] do you want it on the adyen branch? [23:37:06] yeah I mean to test that specific patch you could pull in all the other stuff too to make tests pass, then remove that patch to see how things fail [23:37:11] cstone: ah good point eh [23:37:16] I think so, yes [23:37:29] either that or on master and then merge master into the adyen branch [23:37:45] because adyen branch is where we're currently working and we do want to be able to do tests there, I guess? [23:37:54] that makes sense too [23:38:05] :) [23:39:11] ill be a bit slow with testing being very distracted by this sun hah [23:39:20] whichever seems easiest to you is cool... dunno if there are other changes from DI master that we also want to merge into adyen, before merging in the opposite direction, adyen into master? [23:39:46] i know theres a least a couple of easy ones but leaving it on adyen seems more straightforward [23:39:55] okok yeah cool :) [23:39:57] (easy ones that have merged on master) [23:40:15] hmmm right [23:40:52] though if they don't conflict with and are not needed by any of the new Adyen stuff then they won't be an obstacle when we merge adyen to master, either, I guess.... [23:41:29] yeah i can see an argument either way [23:47:54] hmmm [23:53:21] (03PS1) 10Cstone: Add invoice_id on recurring queue consume [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/705518 (https://phabricator.wikimedia.org/T286739) [23:54:02] (03PS2) 10Cstone: Add invoice_id on new recurring insert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/705518 (https://phabricator.wikimedia.org/T286739)