[00:28:34] (03CR) 10Cstone: [C: 03+2] "Looks good, thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/705723 (https://phabricator.wikimedia.org/T283106) (owner: 10Ejegg) [00:29:09] (03Merged) 10jenkins-bot: Add recurring IDs to getDetails response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/705723 (https://phabricator.wikimedia.org/T283106) (owner: 10Ejegg) [00:29:49] (03PS8) 10Cstone: Add ability to create new recurring credit card payments [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702762 (https://phabricator.wikimedia.org/T283106) [00:30:34] (03CR) 10jerkins-bot: [V: 04-1] Add ability to create new recurring credit card payments [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702762 (https://phabricator.wikimedia.org/T283106) (owner: 10Cstone) [00:36:04] (03PS9) 10Cstone: Add ability to create new recurring credit card payments [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702762 (https://phabricator.wikimedia.org/T283106) [00:36:43] well that didn't do what i wanted it to do haha [00:50:50] (03PS4) 10Eileen: Move the custom fields definition to a more logical place [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/705614 (https://phabricator.wikimedia.org/T281268) [00:52:43] (03PS1) 10Eileen: Remove function to remove old fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/705777 (https://phabricator.wikimedia.org/T280595) [00:59:54] (03PS10) 10Cstone: Add ability to create new recurring credit card payments [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702762 (https://phabricator.wikimedia.org/T283106) [01:46:11] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Adyen, 10FR-Smashpig: Adyen Checkout: normalize API error codes - https://phabricator.wikimedia.org/T283307 (10Cstone) It looks like they don't have card numbers that return bad responses yo... [03:02:21] (03CR) 10Ejegg: [C: 03+2] "This seems to do the trick!" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702762 (https://phabricator.wikimedia.org/T283106) (owner: 10Cstone) [03:05:06] (03Merged) 10jenkins-bot: Add ability to create new recurring credit card payments [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/702762 (https://phabricator.wikimedia.org/T283106) (owner: 10Cstone) [03:52:36] (03PS1) 10Eileen: Sync with upstream [wikimedia/fundraising/crm/civicrm-buildkit] - 10https://gerrit.wikimedia.org/r/705784 [03:53:04] (03CR) 10Eileen: [V: 03+2 C: 03+2] "Per agreement - syncing with master can self-merge" [wikimedia/fundraising/crm/civicrm-buildkit] - 10https://gerrit.wikimedia.org/r/705784 (owner: 10Eileen) [03:54:58] (03PS1) 10Ejegg: Add new classes for saved payment details [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/705785 (https://phabricator.wikimedia.org/T286739) [03:55:36] (03CR) 10jerkins-bot: [V: 04-1] Add new classes for saved payment details [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/705785 (https://phabricator.wikimedia.org/T286739) (owner: 10Ejegg) [04:02:43] (03PS2) 10Ejegg: Add new classes for saved payment details [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/705785 (https://phabricator.wikimedia.org/T286739) [04:06:55] (03PS3) 10Ejegg: API4 call to update payment token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704871 (https://phabricator.wikimedia.org/T286739) [04:07:32] ok cstone I think ^^ and the new SmashPig patch should work. I just was able to update my local rtbt old-recurring with that [04:08:11] If you want to take that WIP off https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/704627 I'll +2 it [04:11:11] whew, it got late [04:45:50] (03PS1) 10Eileen: Remove code to install extensions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/705787 (https://phabricator.wikimedia.org/T280595) [04:58:51] (03PS1) 10Eileen: Sync with upstream [wikimedia/fundraising/crm/civicrm-buildkit] - 10https://gerrit.wikimedia.org/r/705788 (https://phabricator.wikimedia.org/T281609) [04:59:27] (03CR) 10Eileen: [V: 03+2 C: 03+2] "Current agreement is to just merge & keep in sync" [wikimedia/fundraising/crm/civicrm-buildkit] - 10https://gerrit.wikimedia.org/r/705788 (https://phabricator.wikimedia.org/T281609) (owner: 10Eileen) [09:57:44] 10fundraising-tech-ops: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10ayounsi) [09:57:46] 10fundraising-tech-ops, 10Patch-For-Review: Reconfigure fundraising public-reporting server role to fundraising-data - https://phabricator.wikimedia.org/T255435 (10ayounsi) [13:59:50] 10fundraising-tech-ops, 10Patch-For-Review: Reconfigure fundraising public-reporting server role to fundraising-data - https://phabricator.wikimedia.org/T255435 (10Jgreen) [14:18:36] 10fundraising-tech-ops: fundraising tech operations GDPR tracking task - https://phabricator.wikimedia.org/T226749 (10Jgreen) [14:19:00] 10fundraising-tech-ops, 10Patch-For-Review: Reconfigure fundraising public-reporting server role to fundraising-data - https://phabricator.wikimedia.org/T255435 (10Jgreen) 05Open→03Resolved p:05Triage→03Medium [14:19:13] 10fundraising-tech-ops, 10Patch-For-Review: Reconfigure fundraising public-reporting server role to fundraising-data - https://phabricator.wikimedia.org/T255435 (10Jgreen) a:03Jgreen [14:37:39] hi fr-tech [14:39:56] hey cstone :) [14:44:34] cstone: which adyen patch would be best to start review on? [14:45:47] ejegg: ^ [14:53:07] hi jgleeson ! [14:53:15] err, lemme see [14:53:17] hmmm jgleeson the ejegg patches are dependant on mine i can look at those maybe the error code task? [14:53:25] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Adyen: Set up Adyen Apple pay test environment - https://phabricator.wikimedia.org/T285683 (10jgleeson) This is technically done although we're yet to see a successful transaction due to issue... [14:54:04] cstone: I'm easy I can review/look at anything that needs picking up while Applepay is on hold [14:54:18] jgleeson: yeah, i'd agree with cstone's suggestion - coding up the error normalization [14:54:18] is the error stuff worth pairing on maybe? [14:54:24] ah ok thanks [14:54:43] I added some comments on the task last night just trying to get responses back from adyen [14:54:45] jgleeson: want to take a look at it and see if you want more input? [14:54:48] sorry I misread cstone's reply, I read it as she could look at it [14:55:26] I think we can re-use some of the existing logic from the mapTxnIdAndErrors function [14:55:52] sounds good I'll take a look [14:55:57] thanks! [14:56:32] i'm happy to video chat if you feel like there's ambiguous stuff [14:56:56] 10fundraising-tech-ops: deploy Let's Encrypt certificates for additional fundraising services - https://phabricator.wikimedia.org/T280034 (10Jgreen) [15:12:10] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Adyen, 10FR-Smashpig: Adyen Checkout: handle authorization decline reasons - https://phabricator.wikimedia.org/T283117 (10jgleeson) a:03jgleeson [15:19:50] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add selection criteria for "Find Contribution" in Civi search - https://phabricator.wikimedia.org/T287020 (10EMartin) Could this be accomplished within the Fredge query? [15:22:00] (03PS3) 10Cstone: Add getSavedPaymentDetails [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/704627 (https://phabricator.wikimedia.org/T286739) [15:26:21] ah hi over here too :) [15:27:18] hi AndyRussG! [15:27:26] :) [15:28:00] (03PS4) 10Cstone: Add getSavedPaymentDetails [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/704627 (https://phabricator.wikimedia.org/T286739) [15:43:30] (03PS5) 10Ejegg: Add getSavedPaymentDetails [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/704627 (https://phabricator.wikimedia.org/T286739) (owner: 10Cstone) [15:43:38] (03CR) 10Ejegg: [C: 03+2] Add getSavedPaymentDetails [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/704627 (https://phabricator.wikimedia.org/T286739) (owner: 10Cstone) [15:44:17] (03Merged) 10jenkins-bot: Add getSavedPaymentDetails [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/704627 (https://phabricator.wikimedia.org/T286739) (owner: 10Cstone) [15:46:42] (03PS3) 10Ejegg: Add new classes for saved payment details [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/705785 (https://phabricator.wikimedia.org/T286739) [15:47:24] (03CR) 10jerkins-bot: [V: 04-1] Add new classes for saved payment details [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/705785 (https://phabricator.wikimedia.org/T286739) (owner: 10Ejegg) [15:53:19] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart: Sprint Goal: At least get credit cards working on prod - https://phabricator.wikimedia.org/T287043 (10DStrine) p:05Triage→03High [15:53:28] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Adyen: Adyen Checkout: Make a rollback plan and test it - https://phabricator.wikimedia.org/T287039 (10DStrine) p:05Triage→03High [15:53:59] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart: update the docs on the civi-acoustic import and export scripts - https://phabricator.wikimedia.org/T286934 (10DStrine) p:05Triage→03Medium [15:54:12] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-France: Adding tax disambiguation clause to Payments Wiki in France - https://phabricator.wikimedia.org/T286880 (10DStrine) p:05Triage→03Medium [15:54:19] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart: Test relationship giving history with search kit - https://phabricator.wikimedia.org/T286742 (10DStrine) p:05Triage→03Medium [15:54:32] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10FR-Adyen, and 2 others: Adyen Checkout: Handle new shopper reference field - https://phabricator.wikimedia.org/T286739 (10DStrine) p:05Triage→03High [15:54:38] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart: If check number is edited, contribution cannot be found in search - https://phabricator.wikimedia.org/T286495 (10DStrine) p:05Triage→03Medium [15:54:47] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-AutoTY-Email: Languages that need soft descriptor to be donate@wikimedia.org - https://phabricator.wikimedia.org/T285499 (10DStrine) p:05Triage→03Medium [15:54:59] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 10 others: Some of our CI tests are not running - https://phabricator.wikimedia.org/T285446 (10DStrine) p:05Triage→03Medium [15:55:04] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-AutoTY-Email: Edit to Thank You Email footer in 13 languages - https://phabricator.wikimedia.org/T285383 (10DStrine) p:05Triage→03Medium [15:55:14] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-AutoTY-Email: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10DStrine) p:05Triage→03Medium [15:55:24] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fr-donorservices, 10FR-Email: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10DStrine) p:05Triage→03Medium [15:55:35] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Adyen Checkout: Fine tune CSS - https://phabricator.wikimedia.org/T283306 (10DStrine) p:05Triage→03High [15:55:51] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10Patch-For-Review: Wmf-donor - new year fields - https://phabricator.wikimedia.org/T280595 (10DStrine) p:05Triage→03Medium [15:56:05] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Adyen: Set up Adyen Apple pay test environment - https://phabricator.wikimedia.org/T285683 (10DStrine) p:05Triage→03High [15:58:26] oh shoot, rebase glitch? [16:05:30] (03PS4) 10Ejegg: Add new classes for saved payment details [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/705785 (https://phabricator.wikimedia.org/T286739) [16:15:45] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Adyen, 10FR-Smashpig: Adyen Checkout: handle authorization decline reasons - https://phabricator.wikimedia.org/T283117 (10Cstone) It looks like they don't have card numbers that return bad r... [16:17:02] 10fundraising-tech-ops: Fundraising access request for Damilare Adedoyin - https://phabricator.wikimedia.org/T286956 (10Dwisehaupt) [16:26:17] damilare: what is your gerrit username? [16:26:39] damilare [16:26:52] thanks, I'll add you to the fundraising group there [16:29:28] ok, done. So that gives you C+2 rights on all our repos, meaning you can approve code changes to be merged to master [16:29:43] and... let me see which of our repos have rules to automatically assign reviewers [16:31:11] heh, was I just imagining that there was a gerrit-native way to do that? [16:35:26] seems it's part of the 'reviewers' plugin, but I'm not actually seeing that enabled on CRM [16:36:37] so damilare if you want to search for our patches you can start by typing project:fundraising in the gerrit search box and see what the autocompleted options are [16:37:04] heh, actually, most of those are not so helpful [16:37:13] OK, let's say project:DonationInterface [16:37:26] there are a few defunct projects there, no ejegg? [16:37:28] or project:crm [16:37:50] fr-tech btw commenting out the bind mount with the docker database config did not speed up Civi on Mac [16:38:05] yes AndyRussG , and some things at the top of the list that may be good code, but that we don't touch very often [16:38:32] damilare: these are the three projects that see the most use [16:38:33] https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/DonationInterface+is:open [16:38:52] https://gerrit.wikimedia.org/r/q/project:wikimedia/fundraising/SmashPig+is:open [16:39:07] https://gerrit.wikimedia.org/r/q/project:wikimedia/fundraising/crm+is:open [16:39:44] so those links also all have a filter to only 'open' changes, i.e. patches that are not yet merged into master [16:42:57] ok, looks like there formerly was a section of gerrit preferences called 'Watched Projects' where one can automatically subscribe to changes [16:43:11] but it seems to have been removed. [16:43:29] THere is a new section called 'Notifications' but I'm not sure if it adds one as a reviewer [16:57:40] hmmm adding ":cached" to all the volume definitions in Docker also doesn't speed up Civi [17:01:19] Thanks ejegg, I’ll check them out [17:03:34] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: Fundraising Access for Joseph Mando - https://phabricator.wikimedia.org/T286556 (10Dwisehaupt) [17:03:53] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: Fundraising Access for Joseph Mando - https://phabricator.wikimedia.org/T286556 (10Dwisehaupt) [17:52:40] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10netops: Automate diff and commit of frack ACL - https://phabricator.wikimedia.org/T260655 (10Jgreen) a:05Jgreen→03None [18:03:32] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add selection criteria for "Find Contribution" in Civi search - https://phabricator.wikimedia.org/T287020 (10EMartin) Some follow up thoughts on this task as we are inheriting the fraud scan process from Donor Relations. Much of the data we are needing t... [18:12:12] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add selection criteria for "Find Contribution" in Civi search - https://phabricator.wikimedia.org/T287020 (10EMartin) Please note that this associated task: https://phabricator.wikimedia.org/T285770 is redundant to the requests being discussed in this tas... [18:20:44] (03Abandoned) 10Legoktm: build: Updating npm dependencies [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/687721 (owner: 10Libraryupgrader) [18:20:46] (03Abandoned) 10Legoktm: build: Updating npm dependencies [extensions/DonationInterface] (REL1_36) - 10https://gerrit.wikimedia.org/r/687722 (owner: 10Libraryupgrader) [19:42:12] AndyRussG: have you come across this saga of mac docker perf yet? https://medium.com/homullus/beating-some-performance-into-docker-for-mac-f5d1e732032c [19:42:55] jejeje no aún no lo he visto [19:46:36] so that 'mutagen' sync that he landed on was apparently briefly built into the alpha version of docker but was removed before it got to stable [23:40:39] whew, on the macbook air the docker civi setup is taking more like 4 hours [23:41:01] i wonder if there are other filesystem options that would help [23:41:04] like noatime [23:53:41] oh dang, after so long it finally pooped out with 'MySQL server has gone away' [23:55:32] trying again with :delegated on dbdata [23:59:40] whoa