[00:30:04] (03CR) 10Cstone: [C: 03+2] "All the values! Looks good and works well" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/705785 (https://phabricator.wikimedia.org/T286739) (owner: 10Ejegg) [00:30:41] (03Merged) 10jenkins-bot: Add new classes for saved payment details [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/705785 (https://phabricator.wikimedia.org/T286739) (owner: 10Ejegg) [00:33:14] (03CR) 10Cstone: [C: 03+2] "Looks good! Grabbed a shopperReference from 2020-05-13, it returned the token and it set it correctly. I then was able to successfully cha" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704871 (https://phabricator.wikimedia.org/T286739) (owner: 10Ejegg) [00:46:10] (03Merged) 10jenkins-bot: API4 call to update payment token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704871 (https://phabricator.wikimedia.org/T286739) (owner: 10Ejegg) [00:54:46] thanks cstone! [01:21:41] ok fr-tech I just tested the old-style adyen on the new branch with just the config changed [01:21:44] and it worked fine [01:25:34] durn, that civi install on the mac air died again though [01:25:46] even with :delegated [01:30:13] hmm, we could maybe disable the write barrier on the filesystem for the mysql container? [01:30:22] more potential for dataloss on crash [01:30:27] but might be worth it for dev [01:33:57] (03PS1) 10Eileen: Ukranian thank you mail update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706055 (https://phabricator.wikimedia.org/T285383) [01:34:11] hmm, no fstab [01:34:59] cstone: I took a look at the thank yous - there are 13 templates - I'm inclined to do 13 commits - just because it's easier to check one & then go 'done that' - whereas I find it hard to keep track of 13 changes in 13 languages - not sure what you think [01:35:38] probably more likely to get thorough review that way too, i guess [01:35:40] Eileen I think whatever makes it easiest for you to do them all [01:36:17] I just spotted that slovak has no colon & I don't know if it is on purpose https://docs.google.com/document/d/1wTK-jRe8y65YXoaUmFzjcPmNKswhGQwYDTDcEexjE5E/edit [01:37:33] ahh, looks like this is how to disable the flush/full sync in all docker everything for mac [01:37:36] https://espeo.eu/blog/docker-for-mac-performance-tweaks/ [01:37:45] I'mma try that [01:38:25] because even just trying to enable 4 drupal modules via docker-compose exec has taken like 15 min so far [01:38:46] (03PS1) 10Eileen: Slovakian thank you update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706056 (https://phabricator.wikimedia.org/T285383) [01:40:18] (03PS1) 10Eileen: Russian thank you fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706057 (https://phabricator.wikimedia.org/T285383) [01:40:29] ug [01:40:56] it's interesting to see how similar Russian & Ukranian are [01:41:14] heh, don't say that to a Ukranian [01:41:41] Ukraine wiki I think once had a language fallback to Russian then to English [01:41:57] but for at least the last 5 years the fallback has been direct to English [01:42:03] (03PS1) 10Eileen: Romanian thank you fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706058 (https://phabricator.wikimedia.org/T285383) [01:42:09] lol [01:43:40] durn, that 'docker-for-mac-performance-tweaks' article seems to be a bit outdated [01:43:50] so I can't use the exact paths mentioned [01:44:04] hopefully i can figure out what the equivalent should be [01:46:42] oh, there should be a db-level option to disable it too [01:48:31] heh, or a dozen innodb globals to fine tune the flush strategy [02:02:35] ejegg: ohnoes how did it die? [02:03:09] fun rabbit hole eh? [02:03:22] I just want to run it all in my own Linux VM on the mac [02:03:38] and then do some kind of standard vm-host sharing of the directories and the ports [02:03:46] (source and config directories) [02:04:07] I wouldn't expect Mac VMs to be all that broken? [02:05:39] ugh, right? [02:05:58] but then again, this is one of those Mac-interacting-with-not-mac boundaries [02:06:17] which have always been the crappy experience of the apple ecosystem [02:06:53] still so annoyed that their products all have bluetooth now but refuse to let you use it to send files to non-mac bluetooth capable things [02:09:30] so the civi install bombed out those two times with a 'mysql server has gone away' error, i guess from the php mysql driver on the civicrm vm [02:42:25] ejegg: hummm crazy [02:42:32] that didn't happen on my mac on the civi install [02:42:54] maybe the air is just too pokey to run it [02:43:22] ejegg: ah one thing I did was number of CPUs and memory on the Docker Desktop config [02:43:42] ah, i'll try increasing that too [02:45:25] good luck! [03:17:13] hmm, seeing other folks recommending what you say - running a linux VM directly, then docker under that [03:19:41] this approach using 'vftool' to run the exterior linux VM seems promising: https://medium.com/carvago-development/my-docker-on-macos-part-1-setup-ubuntu-virtual-machine-both-intel-and-apple-silicon-cpu-5d886af0ebba [03:32:12] (03PS1) 10Eileen: Portugese thank you updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706117 (https://phabricator.wikimedia.org/T285383) [03:32:14] (03PS1) 10Eileen: Polish thank you updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706118 (https://phabricator.wikimedia.org/T285383) [03:33:10] (03PS1) 10Eileen: Norwegian thank you updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706119 (https://phabricator.wikimedia.org/T285383) [03:34:05] (03PS1) 10Eileen: Latvian thank you updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706120 (https://phabricator.wikimedia.org/T285383) [03:34:53] (03PS1) 10Eileen: Italian thank you updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706121 (https://phabricator.wikimedia.org/T285383) [03:39:03] (03PS1) 10Eileen: Spanish thank you updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706122 (https://phabricator.wikimedia.org/T285383) [03:39:06] (03PS1) 10Eileen: Danish thank you updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706123 (https://phabricator.wikimedia.org/T285383) [03:51:16] ejegg: hmmm interesting thanks for doing all that digging btw! [04:12:29] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-AutoTY-Email, 10Patch-For-Review: Edit to Thank You Email footer in 13 languages - https://phabricator.wikimedia.org/T285383 (10Eileenmcnaughton) I've made these changes & put them on staging. @CDenes_WMF - was the ommission of the :... [05:27:37] (03PS1) 10Eileen: Drupal upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706182 [05:28:09] (03PS1) 10Eileen: Re-apply WMF patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706183 [05:37:01] (03CR) 10jerkins-bot: [V: 04-1] Drupal upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706182 (owner: 10Eileen) [13:47:53] hi fr-tech! [13:50:47] Hi jgleeson [13:52:39] hows it goin cstone ? [13:54:55] Good jgleeson it hasn't rained now in two days ! How about you? [13:56:51] not too bad thanks. had my second vaccine earlier which was ok. it's still hot here! 31c today so the fan is on full :) [14:07:11] damilare: you about for our check-in? [14:09:11] Hi jqleeson, I am on the call [15:38:07] hi fr-tech jgleeson cstone damilare :) :) [15:40:46] howdy AndyRussG [15:50:01] :) [15:52:50] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Adyen Checkout: Fine tune CSS - https://phabricator.wikimedia.org/T283306 (10AndyRussG) [15:53:33] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Adyen Checkout: Fine tune CSS - https://phabricator.wikimedia.org/T283306 (10AndyRussG) a:03AndyRussG [16:30:40] 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.37-notes (1.37.0-wmf.3; 2021-04-27): Non-english soft descriptor - https://phabricator.wikimedia.org/T277598 (10EMartin) Hello, I am seeing th... [16:43:19] 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.37-notes (1.37.0-wmf.3; 2021-04-27): Non-english soft descriptor - https://phabricator.wikimedia.org/T277598 (10DStrine) We can only adjust th... [16:54:06] 10Fundraising-Backlog: Issue with descriptor @ sign re AMEX transactions in JP - https://phabricator.wikimedia.org/T287192 (10EMartin) [17:18:46] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-AutoTY-Email: Languages that need soft descriptor to be donate@wikimedia.org - https://phabricator.wikimedia.org/T285499 (10DStrine) [17:18:50] 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.37-notes (1.37.0-wmf.3; 2021-04-27): Non-english soft descriptor - https://phabricator.wikimedia.org/T277598 (10DStrine) [17:27:30] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Astropay-DLocal_endpoint_critical 7 [=1] [17:29:07] 10Fundraising Sprint Da Vinci Coder, 10Fundraising Sprint Ewoks Take Manhattan, 10Fundraising-Backlog: fill out PCI forms for this year - https://phabricator.wikimedia.org/T217184 (10DStrine) You have been invited to the following event. Title: David:Evelyn Touch base https://docs.google.com/document/d/1... [17:30:52] 10Fundraising Sprint Da Vinci Coder, 10Fundraising Sprint Ewoks Take Manhattan, 10Fundraising-Backlog: fill out PCI forms for this year - https://phabricator.wikimedia.org/T217184 (10DStrine) This event has been canceled. Title: David:Evelyn Touch base https://docs.google.com/document/d/1SCJqolS8d3jMy3Q5... [17:32:32] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Astropay-DLocal_endpoint_critical 7 [=1] [17:37:32] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Astropay-DLocal_endpoint_critical 7 [=1] [17:42:32] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Astropay-DLocal_endpoint_critical 7 [=1] [17:47:30] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Astropay-DLocal_endpoint_critical 7 [=1] [17:51:15] looks like that Astropay issue started to clear about 3 mins ago [17:52:06] ah thanks dwisehaupt for noticing that. [17:52:32] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Astropay-DLocal_endpoint_critical 1 [=1] [17:52:37] sorry for the delay, not that there was anything we could have done about it. [17:52:53] I got distracted reading about why there's no team GB representing the UK at the Tokyo Olympics this year [17:53:31] we will still see the alert (probably for 1-2 more) as the check looks at volume of success/failure messages and may pick up some of the older ones. [17:53:52] no team GB at all? or just not in one sport? [17:57:32] RECOVERY - check_log_messages on frav1002 is OK: OK [18:04:43] just football dwisehaupt [18:04:44] Mexico beat France today! [18:05:01] ah. [18:09:20] fr-tech I'm finishing for today. we didn't get to the Adyen error normalizing call but if folks wanna make a start on that in a call and have me review that's fine. If not, no problem I'll continue where I left off. Have a good rest of your day! [18:47:53] 10Fundraising-Backlog: Issue with descriptor @ sign re AMEX transactions in JP - https://phabricator.wikimedia.org/T287192 (10DStrine) [18:48:10] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-AutoTY-Email: Languages that need soft descriptor to be donate@wikimedia.org - https://phabricator.wikimedia.org/T285499 (10DStrine) [18:50:50] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-AutoTY-Email: All languages need a soft descriptor to be a version of "Wikimedia 877 600 9454" - https://phabricator.wikimedia.org/T285499 (10DStrine) [18:51:30] fr-tech I'll be a bit late or might miss the Analytics meeting, apologies!! [18:57:37] 10fundraising-tech-ops: deploy Let's Encrypt certificates for additional fundraising services - https://phabricator.wikimedia.org/T280034 (10Jgreen) [19:03:07] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: (Need By: TBD) rack/setup/install frdb2003.frack.codfw.wmnet - https://phabricator.wikimedia.org/T281177 (10Jgreen) [19:49:04] 10Fundraising-Backlog, 10Fundraising-Backlog-Old, 10Epic: Write puppet (for vagrant) modules to provision all fundraising components - https://phabricator.wikimedia.org/T88658 (10Aklapper) p:05High→03Low [19:49:18] 10Fundraising-Backlog, 10Fundraising-Backlog-Old, 10Tracking-Neverending: Fundraising Tech Staging (tracking) - https://phabricator.wikimedia.org/T88657 (10Aklapper) p:05High→03Low [20:04:09] 10Fundraising-Backlog, 10Analytics, 10Analytics-Kanban, 10Event-Platform, and 2 others: CentralNoticeBannerHistory and CentralNoticeImpression Event Platform Migration - https://phabricator.wikimedia.org/T271168 (10Ottomata) [21:54:10] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Adyen: Adyen Checkout: Make a rollback plan and test it - https://phabricator.wikimedia.org/T287039 (10Ejegg) After everything in the DonationInterface adyen feature branch is merged to master, the default implementation for the 'adyen'... [21:54:47] AndyRussG: I described the config changes to switch between Adyen integrations there ^^^ [21:54:58] does it seem clear? [21:57:42] (03PS1) 10Ejegg: Normalize refusal reasons to ErrorCodes for REST [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/706805 (https://phabricator.wikimedia.org/T283117) [21:58:11] cstone I just did a copy-paste-modify version of that refusalReason normalization patch ^^^ [21:58:21] (03CR) 10jerkins-bot: [V: 04-1] Normalize refusal reasons to ErrorCodes for REST [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/706805 (https://phabricator.wikimedia.org/T283117) (owner: 10Ejegg) [21:58:23] thinking maybe we could get it merged today [21:58:31] well, once i fix that v-1 [21:58:45] and then maybe have it merged to tag the new SmashPig library version [21:59:23] Ok ejegg [21:59:40] ooh, did I add that to the wrong codepath? [21:59:55] a test for the old code is failing [22:01:09] ahh, maybe that test is invalid now, since it's assuming the approvePayment goes through WSDL [22:01:31] let me see what the equivalent failure mode would be for Checkout [22:02:36] (03PS1) 10Eileen: Add civisualise extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706813 [22:16:38] (03CR) 10jerkins-bot: [V: 04-1] Add civisualise extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/706813 (owner: 10Eileen) [22:24:01] ejegg: I need to go pickup dinner but ill be back in like 15, but stepping through the error code so far looks like its behaving [22:24:06] cool cool [22:24:19] i guess when the json_decode fails it can come back 'false' as well [22:24:31] so that type hint needs to go [22:25:28] oh, return value is NULL rather [22:25:33] ok, I'll update that test [22:37:23] (03PS2) 10Ejegg: Normalize refusal reasons to ErrorCodes for REST [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/706805 (https://phabricator.wikimedia.org/T283117) [22:40:56] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/706817 [22:41:05] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/706817 (owner: 10Ejegg) [22:42:41] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/706819 [22:42:45] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/706819 (owner: 10Ejegg) [22:48:21] (03CR) 10DannyS712: [C: 03+2] build: Updating dependencies [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/706716 (owner: 10Libraryupgrader) [22:48:28] (03CR) 10DannyS712: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 37.0.0 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/706718 (owner: 10Libraryupgrader) [22:56:29] im back [22:57:18] cool! [22:58:06] cstone: it looks like the tests pass now! https://gerrit.wikimedia.org/r/706805 [22:58:29] nice ejegg ! [23:03:27] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/706817 (owner: 10Ejegg) [23:04:49] ejegg: for testing if something isn't in $noRetryReasons is it a retry reason then? [23:09:54] nevermind i see what its doing [23:21:11] (03CR) 10Cstone: [C: 03+2] "Looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/706805 (https://phabricator.wikimedia.org/T283117) (owner: 10Ejegg) [23:22:07] (03Merged) 10jenkins-bot: Normalize refusal reasons to ErrorCodes for REST [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/706805 (https://phabricator.wikimedia.org/T283117) (owner: 10Ejegg)