[00:00:19] XenoRyet: cool thanks so much! hmmm I'll dig into the CI error with the other stuff later then 8p [00:01:19] heh same error as on the other stuff, that's a data point forsure [00:01:24] https://integration.wikimedia.org/ci/job/quibble-donationinterface-REL1_35-php73-docker/621/console [00:01:38] heading to the Oxxo to pay my IPS, back a bit later :) [00:07:08] Yea, looks like it's just running into the same thing, so it should get solved when we figure out the root cause. [01:11:56] yip! [02:30:36] (03PS1) 10Eileen: Fix setting for finding template files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/708197 (https://phabricator.wikimedia.org/T285375) [03:46:46] (03CR) 10AndyRussG: "recheck" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708034 (https://phabricator.wikimedia.org/T283306) (owner: 10AndyRussG) [07:58:15] (03PS1) 10AndyRussG: Update SmashPig version requirement [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708208 [08:03:20] (03CR) 10AndyRussG: [C: 03+2] Update SmashPig version requirement [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708208 (owner: 10AndyRussG) [08:06:30] (03Merged) 10jenkins-bot: Update SmashPig version requirement [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708208 (owner: 10AndyRussG) [08:10:14] (03CR) 10AndyRussG: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/706905 (owner: 10Ejegg) [13:12:30] Jeff_Green: are you able to add Damilare to our fr-tech@wikimedia.org mailing list? He doesn't seem to be getting emails sent there [13:14:03] jgleeson: fr-tech is a gmail list which is administered by OIT [13:14:43] I think he can just email techsupport@ requesting to be added [13:18:35] ok cool. I had a vague memory of seeing a step on the onboarding docs which covered getting added to the mailing lists [13:19:26] yeah, usually fr-tech@ gets added early on [14:16:16] hi fr-tech [14:23:42] hey cstone ! [14:24:58] I'm just gonna grab a late lunch, back shortly! [14:57:55] g'morning fr-tech [15:01:04] (03PS1) 10Cstone: Add processor_contact_id [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708303 (https://phabricator.wikimedia.org/T286739) [15:18:18] hey fr-tech did everyone get and chance to see andy's email last night? how's it going today? [15:18:47] im working on fixing the failing tests [15:19:20] cool and thanks [15:19:33] theres just 3 and it doesnt look complicated just figuring out where stuff is missing [15:20:28] Is that one above ready to merge? I can CR it real fast if you want. [15:21:00] (03PS2) 10Cstone: WIP: Test fixes for adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708303 [15:21:12] nah ill just stick them all together [15:22:37] theres one more that needs to be added [15:30:00] 10Fundraising-Backlog: Gather information related to audit files and Civi import timings - https://phabricator.wikimedia.org/T253347 (10EMartin) Fr Tech, here is an example of why we are asking for this information. In this example: 7/13/21 21:33 102296340.5 100.05 JP you will see we settled the transaction o... [15:40:23] 10Fundraising-Backlog, 10fr-donorservices: Gather information related to audit files and Civi import timings - https://phabricator.wikimedia.org/T253347 (10MBeat33) [15:42:46] cstone: need any help with those test fixes? [15:43:09] hi jgleeson yeah I have a question on the WIP no idea what its supposed to say haha I have test right now [15:43:25] er on the en.json one if you look [15:43:53] the summary field? [15:44:04] yeah [15:46:18] Looks like the others describe what the behaviour is offered by the API. also reading https://www.mediawiki.org/wiki/API:Localisation#Message_documentation cstone [15:47:09] "apihelp-employerSearch-summary": "This API allow you to search for employers participating in the WMF matching gifts program.", [15:47:18] that's one I added for the employer search [15:47:30] yeah i just didn't figure out where the adyen one came from [15:49:17] mmm yeah at first I was thinking it might have been due to updating the donate api [15:49:21] lemme checkthat [15:58:10] hmm lemme merge adyen into master locally and see if I can recreate those test failures [15:58:18] yeah ive been able to [15:58:34] the WIP fixes the 3 failures and looking at the erroring one now [15:58:48] nice! [15:59:08] just need to figure out what words to actually put in en.json haha [16:08:29] cstone: I think for now we can just put a short summary to get it passing and then circle back to work out why it actually needs to be there later? [16:08:41] that works [16:08:48] the last one is confusing me a bit if you want to jump on a call [16:09:33] sure let's jump on today's call [16:13:07] (03PS3) 10Cstone: WIP: Test fixes for adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708303 [16:14:50] I think placeholder text to get the tests passing is a fine idea for today. There will be time before the full campaign to come back and put something more appropriate there. [16:20:42] hi fr-tech! Yeah agreed XenoRyet... cstone jgleeson great you could fix the tests!!!! Looks totally +2-able, except for the WIP in the commit message [16:20:54] there is still one broken test AndyRussG [16:21:01] we are in a call trying to figure it out [16:21:53] ahhh huh cstone since I saw jenkins looked happy on Gerrit I thought it was fixed... [16:22:15] I can join in about 10 minutes [16:22:31] okie [16:50:35] damilare XenoRyet fr-tech we're in an ad-hoc call to fix the last test error, if anyone feels like joining :) https://meet.google.com/aio-mocx-ggt?authuser=0 [16:50:51] Cool, I'm in a different meeting right now, but I'll pop in after [16:58:26] 10fundraising-tech-ops: fix data snapshots from fundraising SEIM server to logger/archive servers - https://phabricator.wikimedia.org/T287503 (10Jgreen) [17:03:08] (03PS1) 10Cstone: WIP: Test fixes for adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708217 [17:05:52] (03CR) 10jerkins-bot: [V: 04-1] WIP: Test fixes for adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708217 (owner: 10Cstone) [17:07:59] (03Abandoned) 10Cstone: WIP: Test fixes for adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708217 (owner: 10Cstone) [17:08:28] (03PS4) 10Cstone: Test fixes for adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708303 [17:11:43] 10fundraising-tech-ops: Fundraising access request for Jayde Antonio - https://phabricator.wikimedia.org/T287387 (10Dwisehaupt) [17:13:54] 10fundraising-tech-ops: Fundraising access request for Jayde Antonio - https://phabricator.wikimedia.org/T287387 (10Dwisehaupt) Approval for access. ` Date: Mon, 26 Jul 2021 17:46:34 From: Lisa Gruwell Subject: Re: C-level approval Jayde Antonio civi access ---------------------------------------- Yes, I appro... [17:15:36] 10fundraising-tech-ops: Fundraising access request for Jayde Antonio - https://phabricator.wikimedia.org/T287387 (10Dwisehaupt) a:03Dwisehaupt SSL client cert created and emailed to jantonio. Password sent via SMS. Civi account created with temp password. Superset account created with temp password. Instructio... [17:21:50] 10fundraising-tech-ops: Update dns_to_ipset to not use domain name as key for set - https://phabricator.wikimedia.org/T287416 (10Dwisehaupt) a:03Dwisehaupt ` commit ba5840fc8873fbdf0efb7ceefa547a431fbc70d6 Author: Dallas Wisehaupt Date: Tue Jul 27 09:35:04 2021 -0700 Update dn... [17:22:45] 10fundraising-tech-ops: Update dns_to_ipset to not use domain name as key for set - https://phabricator.wikimedia.org/T287416 (10Dwisehaupt) [17:30:39] (03PS5) 10Cstone: Test fixes for adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708303 [18:24:12] 10Fundraising-Backlog, 10FR-LATAM, 10FR-dlocal: DLocal not loading on IE 11 - https://phabricator.wikimedia.org/T276333 (10jbolorinos-ctr) 05Open→03Declined Given that banners arent displayed to IE 11 users anymore (T280735), we can go ahead and just close this [18:30:32] (03PS6) 10Jgleeson: Test fixes for adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708303 (owner: 10Cstone) [18:36:52] (03CR) 10AndyRussG: [C: 03+2] "Yaaaaa congrats!!!" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708303 (owner: 10Cstone) [18:37:54] (03CR) 10Cstone: "recheck" [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708034 (https://phabricator.wikimedia.org/T283306) (owner: 10AndyRussG) [18:40:00] (03Merged) 10jenkins-bot: Test fixes for adyen [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708303 (owner: 10Cstone) [18:42:10] (03CR) 10Cstone: [C: 03+2] Consistent styles for Adyen and non-Adyen elements [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708034 (https://phabricator.wikimedia.org/T283306) (owner: 10AndyRussG) [18:53:27] (03Merged) 10jenkins-bot: Consistent styles for Adyen and non-Adyen elements [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708034 (https://phabricator.wikimedia.org/T283306) (owner: 10AndyRussG) [19:04:57] (03PS1) 10AndyRussG: Merge feature branch 'adyen' into master [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708333 [19:07:07] (03CR) 10jerkins-bot: [V: 04-1] Merge feature branch 'adyen' into master [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708333 (owner: 10AndyRussG) [19:21:43] 10Fundraising-Backlog, 10Analytics, 10Analytics-Kanban, 10Event-Platform, and 2 others: CentralNoticeBannerHistory and CentralNoticeImpression Event Platform Migration - https://phabricator.wikimedia.org/T271168 (10Ottomata) 05Open→03Resolved [19:57:27] 10Fundraising-Backlog, 10fundraising-tech-ops: fill out fr-tech analytics requirements spreadsheet. - https://phabricator.wikimedia.org/T287515 (10DStrine) [19:58:04] (03PS1) 10Jgleeson: WIP: Legacy AdyenApi test fix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708338 [20:00:53] (03CR) 10jerkins-bot: [V: 04-1] WIP: Legacy AdyenApi test fix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708338 (owner: 10Jgleeson) [20:12:02] (03PS1) 10Jgleeson: DO NOT MERGE: CI testing for adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708343 [20:14:40] (03CR) 10jerkins-bot: [V: 04-1] DO NOT MERGE: CI testing for adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708343 (owner: 10Jgleeson) [20:23:46] (03PS1) 10AndyRussG: DO NOT MERGE Testing CI stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708345 [20:26:44] (03CR) 10jerkins-bot: [V: 04-1] DO NOT MERGE Testing CI stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708345 (owner: 10AndyRussG) [20:35:55] (03PS1) 10Cstone: Do not merge: Testing CI [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708346 [20:37:56] (03PS2) 10AndyRussG: DO NOT MERGE Testing CI stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708345 [20:38:47] (03CR) 10jerkins-bot: [V: 04-1] Do not merge: Testing CI [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708346 (owner: 10Cstone) [20:40:25] (03PS2) 10Cstone: Do not merge: Testing CI [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708346 [20:40:50] (03CR) 10jerkins-bot: [V: 04-1] DO NOT MERGE Testing CI stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708345 (owner: 10AndyRussG) [20:43:30] (03CR) 10jerkins-bot: [V: 04-1] Do not merge: Testing CI [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708346 (owner: 10Cstone) [20:45:19] 10fundraising-tech-ops: Update dns_to_ipset to not use domain name as key for set - https://phabricator.wikimedia.org/T287416 (10Dwisehaupt) `[frack::puppet] fd69f847 Add new ipset rules with shorter names` [20:55:17] (03PS3) 10AndyRussG: DO NOT MERGE Testing CI stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708345 [20:58:08] (03CR) 10jerkins-bot: [V: 04-1] DO NOT MERGE Testing CI stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708345 (owner: 10AndyRussG) [21:08:33] (03Abandoned) 10Cstone: Do not merge: Testing CI [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708346 (owner: 10Cstone) [21:25:09] (03PS4) 10AndyRussG: DO NOT MERGE Testing CI stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708345 [21:30:31] (03CR) 10jerkins-bot: [V: 04-1] DO NOT MERGE Testing CI stuff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708345 (owner: 10AndyRussG) [21:36:54] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-AutoTY-Email, 10Patch-For-Review: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10Eileenmcnaughton) Just noting that the old translations & new translations are technically... [21:48:05] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-AutoTY-Email, 10Patch-For-Review: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10Eileenmcnaughton) Ok - it looks like there are supported tokens {now.MMMM} = Month {contr... [21:53:01] (03PS1) 10AndyRussG: Legacy AdyenApi test fix [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/708221 [22:03:40] is there tech talk or did it get canned ? [22:05:44] eileen: i think folks are still in the midsprint call working through things. [22:06:01] oh right - so it's still happening - [22:06:15] yeah. it ended up being more of a working meeting. [22:12:15] (03PS1) 10Eileen: Show html message first on qa form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/708366 (https://phabricator.wikimedia.org/T285375) [22:12:17] (03PS1) 10Eileen: Update Swedish translation for recurring failure [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/708367 (https://phabricator.wikimedia.org/T285375) [22:13:07] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-AutoTY-Email, 10Patch-For-Review: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10Eileenmcnaughton) [22:19:53] (03PS2) 10Eileen: Update Swedish translation for recurring failure [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/708367 (https://phabricator.wikimedia.org/T285375) [22:50:57] 10fundraising-tech-ops: Fundraising access request for Asjah Jett - https://phabricator.wikimedia.org/T286805 (10EMartin) Hi Dallas, Asjah doesn't seem to have her Civi certificate as yet. Can you confirm what email you sent it to? She does not have the SMS text either that we can see. [22:56:50] (03PS1) 10Jgleeson: Update Donation Interface & Vendor submodules [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/708377 [23:02:54] 10fundraising-tech-ops: Fundraising access request for Asjah Jett - https://phabricator.wikimedia.org/T286805 (10Dwisehaupt) @EMartin Sure thing. I have just confirmed and the ssl cert was sent to the email address listed on the collab contact list. I also verified that I sent the SMS to the number listed there... [23:07:31] (03CR) 10jerkins-bot: [V: 04-1] Update Donation Interface & Vendor submodules [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/708377 (owner: 10Jgleeson) [23:08:33] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] "Do it!" [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/708377 (owner: 10Jgleeson) [23:19:16] 10fundraising-tech-ops: Fundraising access request for Asjah Jett - https://phabricator.wikimedia.org/T286805 (10EMartin) How does Asjah get her User Name and Password for Civi once she gets her certificate? [23:21:13] 10fundraising-tech-ops: Fundraising access request for Asjah Jett - https://phabricator.wikimedia.org/T286805 (10EMartin) She found the certificate and SMS but does not have a user name or password for Civi. How can she get those? thank you! [23:23:08] dwisehaupt: around? [23:24:27] 10fundraising-tech-ops: Fundraising access request for Asjah Jett - https://phabricator.wikimedia.org/T286805 (10Dwisehaupt) When her civi account was created it sent a welcome email about with how to update/change her password. For reference the email on the account is her email address. On the main login pag...