[05:42:11] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart: Adyen Checkout: Investigate possible changes to allow simultaneous deployment of old and new integrations - https://phabricator.wikimedia.org/T287604 (10AndyRussG) Here's how I think we can do this: - Add a new gateway code for Adyen Checkout... [06:39:05] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709297 (owner: 10L10n-bot) [06:54:03] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709297 (owner: 10L10n-bot) [07:23:03] 10Wikimedia-Fundraising-Banners: [Enhancement] Improve error message for opt-in - https://phabricator.wikimedia.org/T277200 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [07:23:05] 10Wikimedia-Fundraising-Banners: Orphan text visible on certain mobile devices - https://phabricator.wikimedia.org/T271749 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [07:23:08] 10Wikimedia-Fundraising-Banners: RML link disappears after clicking back on form [modal5] - https://phabricator.wikimedia.org/T266123 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [07:23:10] 10Wikimedia-Fundraising-Banners: Share links disappear after clicking back [Otherwaystogive variant] - https://phabricator.wikimedia.org/T264256 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [07:23:13] 10Wikimedia-Fundraising-Banners: Establish naming convention for shared banner UI elements - https://phabricator.wikimedia.org/T241857 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [07:23:15] 10Wikimedia-Fundraising-Banners: Separate out JS for iPad/Tablet banners - https://phabricator.wikimedia.org/T241856 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [07:23:18] 10Wikimedia-Fundraising-Banners: Separate out JS for Mobile banners - https://phabricator.wikimedia.org/T241854 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [07:23:20] 10Wikimedia-Fundraising-Banners: [Enhancement] India - Rearrange Visa payment logos to match other payment option button - https://phabricator.wikimedia.org/T259937 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [07:23:22] 10Wikimedia-Fundraising-Banners: No error message displayed when clicking "Submit" on Step 2 and missing data - https://phabricator.wikimedia.org/T257880 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [07:23:24] 10Wikimedia-Fundraising-Banners: Separate out JS for Desktop Banners - https://phabricator.wikimedia.org/T241855 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [07:23:26] 10Wikimedia-Fundraising-Banners: Stacked logos on payment options Desktop Large/Safari 9.0 - https://phabricator.wikimedia.org/T250094 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [07:23:28] 10Wikimedia-Fundraising-Banners: Numbers spill over behind modal on Donate Monthly button [Other input] - https://phabricator.wikimedia.org/T259523 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [07:23:30] 10Wikimedia-Fundraising-Banners: [Enhancement] Update radio inputs to be larger buttons - https://phabricator.wikimedia.org/T255637 (10Aklapper) a:05jbolorinos-ctr→03None Removing deactivated user account from assignee field. [09:06:01] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-AutoTY-Email, 10Patch-For-Review: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10CDenes_WMF) Great, thank you Eileen! @TomaszGorski Auto Recurring is off 'hold' and ready f... [14:31:06] hi fr-tech [14:38:47] hi cstone! [14:38:51] and hi fr-tech! [14:46:33] heyyy cstone ejegg fr-tech :) [14:47:36] further notes on old-and-new Adyen simulcast here, feedback appreciated :) https://phabricator.wikimedia.org/T287604#7251125 [15:00:09] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart: Adyen Checkout: Investigate possible changes to allow simultaneous deployment of old and new integrations - https://phabricator.wikimedia.org/T287604 (10Ejegg) >>! In T287604#7251125, @AndyRussG wrote: > Here's how I think we can do this: > >... [15:00:21] some replies inline AndyRussG ^^^ [15:00:28] I really want to avoid adding another gateway code [15:00:51] it's just been such a drag for ingenico and paypal [15:01:40] and with adyen the actual API difference is so minimal [15:08:23] hi fr-tech! [15:08:50] hi jgleeson [15:09:17] the mepps maxmind thing sounds odd ejegg [15:09:36] maybe mepps got fed up of the notifications? [15:15:51] (03CR) 10Ejegg: [C: 03+1] "Thanks for the fix Jgleeson! +2 to your change, but I'm just +1ing the patch overall. Someone else want to +2 it?" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/708806 (owner: 10Ejegg) [15:16:51] AndyRussG: damilare is adding a phab task relating to a bug when adding the smashpig db as part of the fundraisisng-dev setup. For some reason that step doesn't work for him. We managed to add them manually, and the code in the setup script looks right, and works for me on linux! Have you seen anything strange regarding that on mac when playing with stuff? [15:17:24] yeah jgleeson it doesnt do the db install on a mac [15:18:12] https://gerrit.wikimedia.org/g/wikimedia/fundraising/dev/+/refs/changes/90/682190/3/setup.sh#659 [15:18:48] i just ran it manually when i was doing it a while ago [15:18:50] so my hunch is that there might be a magic space getting added to the host argument 'database' on linux and not on mac OS for some reason [15:19:27] meaning the cat file.sql | ... actually gets appended to the mysql -h arg [15:19:46] that could be wrong though and it could be something completely unrelated [15:20:11] running via `docker-compose exec ... < mysql_file.sql` worked [15:21:48] jgleeson cstone damilare ah cool thanks for digging in there! [15:22:23] Also AndyRussG, this is on we could all fix I think so sorry if it feels like these things get pushed you way all the time! [15:22:41] might be a good ticket for damilare to pick up when we do refinement [15:22:49] jgleeson ah no worries, on the contrary thanks for mentioning it :) [15:22:59] your* [15:23:02] cool cool :) [15:31:17] 10Fundraising-Backlog: Smashpig database is not initialized after setup - https://phabricator.wikimedia.org/T287885 (10Damilare) [15:34:24] wrt to mac btw one option also could be running basically everything, including the IDE, inside a linux VM [15:35:05] and then only exposing ports for the web frontends, not even source code, on the host [15:35:23] that way we could still use Safari and apple dev tools for Apple Pay, I think? [15:36:09] and for people with a Linux box, you could also only run the whole setup there, and just connect with Safari from the mac over your local network [15:36:54] AndyRussG: it's been a while since I did any virtulisation on a mac. Looks like virtualbox mac binaries are available so that could work! I remember having to use Parallels back in the day and I think I had to pay for it! [15:37:14] what are Parallels? [15:37:58] it's pretty much a like-for-like virtual box alternative with a nicer UI [15:38:18] https://www.parallels.com/uk/ [15:39:02] £69 a licence! [15:39:38] hmmmm [15:39:47] I wonder if we have a company license or something [15:39:57] everyone i know that does vms on the mac sticks with virtualbox. despite some of it's warts. [15:40:18] at least for linux mvs. [15:40:23] vms that is. [15:40:29] yeah sorry if I wasn't clear, it looks like we can use virtualbox on a mac also AndyRussG [15:40:38] dwisehaupt does it work like well with a graphical enironment? [15:40:42] no need to use the paid for thingy [15:41:50] not sure what you mean by 'with a graphical environment'. would you mind expanding that a little more? [15:43:50] dwisehaupt: he means a headed/full vm vs a headless/no-gui vm [15:44:19] I think! [15:44:50] ah. yeah. i could ask. i'm assuming it has the same warts of copy/paste buffers and 'who has control of the mouse' issues, but those aren't insurmountable. [15:45:41] it looks like the set up is a bit fiddly on mac OS https://www.virtualbox.org/wiki/Mac%20OS%20X%20build%20instructions [15:47:48] I see a ubuntu GUI here https://www.imore.com/virtualbox-review-free-virtualization-your-mac [15:47:51] jgleeson: i think that's just if you want to build it from source. there are definitely builds for it. [15:48:24] ahh yeah dwisehaupt fair point [15:52:39] yeah that is what I meant about the graphical environment [15:52:56] thanks for the notes and links btw!!! [15:53:10] i sent out a query, we'll see what i hear back. [15:59:28] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart: Adyen Checkout: Investigate possible changes to allow simultaneous deployment of old and new integrations - https://phabricator.wikimedia.org/T287604 (10AndyRussG) Thanks so much!! :) More below... >>! In T287604#7252238, @Ejegg wrote: > The... [16:29:24] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart: Adyen Checkout: Investigate possible changes to allow simultaneous deployment of old and new integrations - https://phabricator.wikimedia.org/T287604 (10Ejegg) >>! In T287604#7252427, @AndyRussG wrote: > Thanks so much!! :) More below... > >>... [16:42:33] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart: Adyen Checkout: Investigate possible changes to allow simultaneous deployment of old and new integrations - https://phabricator.wikimedia.org/T287604 (10Ejegg) > Hmm, so the capture job DOES already wait till it finds a pending message to do t... [17:24:40] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Japan, 10Recurring-Donations: set Japanese monthly convert variant 11 to default - https://phabricator.wikimedia.org/T287262 (10DStrine) [17:25:44] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Japan, 10Recurring-Donations: set Japanese monthly convert variant 11 to default - https://phabricator.wikimedia.org/T287262 (10DStrine) I updated this task per standup today. We want all countries to see variant 11 until the japan ca... [17:39:48] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart: Adyen Checkout: Investigate possible changes to allow simultaneous deployment of old and new integrations - https://phabricator.wikimedia.org/T287604 (10AndyRussG) > It also makes it more difficult for Donor Relations to correlate a donation i... [17:51:59] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart: Adyen Checkout: Investigate possible changes to allow simultaneous deployment of old and new integrations - https://phabricator.wikimedia.org/T287604 (10AndyRussG) (also regarding adding a new gateway code) > We get information about payment... [18:35:30] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Japan, 10Recurring-Donations: set Japanese monthly convert variant 11 to default - https://phabricator.wikimedia.org/T287262 (10DStrine) p:05Medium→03High [19:23:04] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart: Adyen Checkout: Investigate possible changes to allow simultaneous deployment of old and new integrations - https://phabricator.wikimedia.org/T287604 (10AndyRussG) >> It also makes it more difficult for Donor Relations to correlate a donation... [19:58:38] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart: Adyen Checkout: Investigate possible changes to allow simultaneous deployment of old and new integrations - https://phabricator.wikimedia.org/T287604 (10DStrine) 05Open→03Resolved [20:09:47] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart: Smashpig database is not initialized after setup - https://phabricator.wikimedia.org/T287885 (10DStrine) [20:39:32] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Adyen: endpoint monitoring for adyen endpoints - https://phabricator.wikimedia.org/T287411 (10Ejegg) According to the API explorer at https://docs.adyen.com/api-explorer/#/CheckoutService/v67/overview there's only one service available on the new API via a... [20:56:01] (03CR) 10Jgleeson: WIP Adyen Checkout: Applepay (031 comment) [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/699402 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [21:00:06] 10fundraising-tech-ops: Update dns_to_ipset to not use domain name as key for set - https://phabricator.wikimedia.org/T287416 (10Dwisehaupt) [21:04:12] oho... now i see how the country-specific monthly convert list works [21:05:15] https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_forms/Mustache.php$490 [21:09:21] so.... do we just make that module name into a global var? [21:10:04] 10Fundraising-Backlog, 10fr-matching-gifts: Perform CPR on Matching Gifts process. - https://phabricator.wikimedia.org/T273551 (10DStrine) [21:10:15] 10Fundraising-Backlog, 10fr-matching-gifts: Enable matching_gifts_sync process-control job - https://phabricator.wikimedia.org/T273553 (10DStrine) [21:10:25] 10Fundraising-Backlog, 10fr-matching-gifts: New process-control job for drush civicrm-matching-gifts-employers-check - https://phabricator.wikimedia.org/T273555 (10DStrine) [21:10:45] 10Fundraising-Backlog, 10fr-matching-gifts: Matching gifts sync continually updating six records - https://phabricator.wikimedia.org/T273790 (10DStrine) [21:10:54] 10Fundraising-Backlog, 10fr-matching-gifts: Update 'matching gifts employer data file' drupal setting to correct path - https://phabricator.wikimedia.org/T273556 (10DStrine) [21:11:04] 10Fundraising-Backlog, 10fr-matching-gifts: Test out the end-to-end matching gifts file deployment process. - https://phabricator.wikimedia.org/T273558 (10DStrine) [21:11:32] 10Fundraising-Backlog, 10fr-matching-gifts: Document matching gifts employer data deployment process - https://phabricator.wikimedia.org/T273559 (10DStrine) [21:12:00] 10Fundraising Sprint Vagranty McVagrantface, 10Fundraising Sprint We all meet again, 10Fundraising-Backlog, 10fr-matching-gifts: matching gifts values don't match between databases - https://phabricator.wikimedia.org/T266475 (10DStrine) [21:12:33] 10Fundraising-Backlog, 10fr-matching-gifts: Add process-control job to run the drush civicrm-matching-gifts-employers-check command - https://phabricator.wikimedia.org/T260726 (10DStrine) [21:13:06] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fr-matching-gifts: Omit useless entries when syncing matching gifts data - https://phabricator.wikimedia.org/T264944 (10DStrine) [21:13:38] 10Fundraising-Backlog, 10fr-matching-gifts: Look at migrating the 'matching gifts employer data check command' over to civicrm - https://phabricator.wikimedia.org/T257498 (10DStrine) [21:13:57] 10Fundraising-Backlog, 10fr-matching-gifts, 10Epic: Epic: matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (10DStrine) [21:25:42] 10Fundraising-Backlog, 10FR-Adyen, 10Epic: Epic: Adyen reintegration, Drop In Web - https://phabricator.wikimedia.org/T277120 (10Jgreen) [21:26:44] 10fundraising-tech-ops: Fundraising access request for Scarlett Jett - https://phabricator.wikimedia.org/T286806 (10Dwisehaupt) [21:27:14] 10fundraising-tech-ops: Fundraising access request for Scarlett Jett - https://phabricator.wikimedia.org/T286806 (10Dwisehaupt) 05Open→03Resolved Verified civi logins are working. Closing. [21:28:20] 10fundraising-tech-ops: Fundraising access request for Asjah Jett - https://phabricator.wikimedia.org/T286805 (10Dwisehaupt) [21:28:52] 10fundraising-tech-ops: Fundraising access request for Asjah Jett - https://phabricator.wikimedia.org/T286805 (10Dwisehaupt) 05Open→03Resolved Verified civi logins are working. Closing. [21:55:49] oh crap, message_replacements is not going to be part of this [21:55:50] boo [21:57:39] (03PS1) 10Ejegg: Configurable default monthly convert module [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709549 (https://phabricator.wikimedia.org/T287262) [21:57:58] so there's the version that ALMOST gets us there ^^^^ [21:58:51] but as previously stated the message_replacements won't work [21:59:07] and i gather that's the important part of this bug [21:59:22] hmph [21:59:40] so what we really want is a list of variants to load based on country? [21:59:45] I think we can do that [22:01:34] hmph hmph hmph though... some variants conflict with each other [22:01:48] like two non-base monthlyConverts [22:01:56] while some variants should be allowed to coexist [22:02:07] like employer collection and monthly convert [22:02:46] oh right, and there's really no good way to stack variants [22:03:02] since we've got them just obliterating any matching yaml file [22:04:03] so... are those yes/no strings just plain better? Can we just make those the default? [22:20:03] hmm, looking into overriding in JS [22:28:59] jj [22:29:12] is my typing coming through [22:29:20] was there tech talk? [22:29:32] i see youre jj and on. [22:29:54] can you see my typos? :) [22:36:28] :-) [22:36:47] (03PS1) 10Ejegg: Monthy convert variant 11 - replace text in JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709553 (https://phabricator.wikimedia.org/T287262) [22:50:15] cstone: did you have a go at that hebrew? I'm wondering if I should try again [22:51:18] Hey eileen I was pretty braindead today and didn't get too far [22:58:49] (03PS2) 10Ejegg: Monthy convert variant 11 - replace text in JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709553 (https://phabricator.wikimedia.org/T287262) [22:59:02] oh derp, was going to edit the commit message and didn't [23:00:05] cstone: fair enough - I'm gonna check what else I have before I decide whether to tackle it :-) [23:02:09] (03PS3) 10Ejegg: Monthy convert variant 11 - replace text in JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709553 (https://phabricator.wikimedia.org/T287262) [23:06:05] oh derp, headline typo still there [23:06:20] (03PS4) 10Ejegg: Monthly convert variant 11 - replace text in JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709553 (https://phabricator.wikimedia.org/T287262) [23:06:29] ok, no more 'monthy' convert [23:08:12] hmph, display:flex is not the vertical-align fix i'm looking for [23:17:51] well, it aligns the things inside it fine, but the buttons themselves then float around funny [23:18:47] so is the answer MORE flexbox? [23:18:57] i.e. in the thing outside? [23:20:28] or display:grid ? [23:23:17] oho, inline-flex! [23:27:24] urf - align-items is tricksy [23:27:41] i swear i had it looking nice in browser tools before reload! [23:28:06] heh, this talk reminds me of $daughter's participation in a hackathon over the weekend where she learned about z-levels [23:28:30] she has a newfound love/hate of css [23:28:35] (03PS5) 10Ejegg: Monthly convert variant 11 - replace text in JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709553 (https://phabricator.wikimedia.org/T287262) [23:29:49] i used to be up on CSS, but then they changed what CSS was. Now what I'm on in isn't current CSS anymore and what's current seems weird and scary! [23:30:02] bah, botched the reference [23:31:45] but anyway, flexbox and grid seem like good things to learn [23:34:28] cool. she got paired with a person from nigeria and a person from canada and they built a small chatboard with login functionality. not bad at all for the limited time and working cross time zones. [23:34:38] sounds fun! [23:35:41] yeah. it was pretty good. i worked with her for a chunk. a bit stressful closer to the deadline time, but good nonetheless. [23:36:20] (03PS1) 10Ejegg: Use flexbox for MC button text alignment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709564 (https://phabricator.wikimedia.org/T287262) [23:37:40] heh, z-levels. Firefox used to have a 3-D page layout view that was awesome for debugging those [23:38:15] https://developer.mozilla.org/en-US/docs/Tools/3D_View sadly removed in version 47 [23:39:57] lololol Edge now has it! [23:39:57] that's cool. although it gives me some flashbacks to early 90s 3d rendered logos. :) [23:46:23] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10FR-Japan, 10Recurring-Donations, 10Patch-For-Review: set Japanese monthly convert variant 11 to default - https://phabricator.wikimedia.org/T287262 (10Ejegg) a:03Ejegg