[01:00:02] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit: Search kit links not loading when sharing out to Engage - https://phabricator.wikimedia.org/T279686 (10Eileenmcnaughton) I've logged https://lab.civicrm.org/dev/core/-/issues/2737 to clarify expectations [01:48:24] (03PS10) 10Eileen: [Refactor] Move existing contact matching code to new WMFContact::save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703267 (https://phabricator.wikimedia.org/T283104) [01:48:26] (03PS9) 10Eileen: Remove match_on_import conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703268 (https://phabricator.wikimedia.org/T283104) [01:48:28] (03PS8) 10Eileen: Add ability to match on address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703270 (https://phabricator.wikimedia.org/T283104) [01:48:30] (03PS1) 10Eileen: Add support for 'Money Order Number' to engage import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/709864 (https://phabricator.wikimedia.org/T283023) [01:48:44] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, and 2 others: New Payment Method added: Money Order - https://phabricator.wikimedia.org/T283023 (10Eileenmcnaughton) [01:50:57] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, and 2 others: New Payment Method added: Money Order - https://phabricator.wikimedia.org/T283023 (10Eileenmcnaughton) I turns out this isn't in the sprint but by the time I'... [01:51:27] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, and 2 others: New Payment Method added: Money Order - https://phabricator.wikimedia.org/T283023 (10Eileenmcnaughton) a:03Eileenmcnaughton [01:56:41] 10Fundraising-Backlog, 10FR-Smashpig, 10Security-Team, 10Security, 10Vuln-VulnComponent: wikimedia/fundraising/SmashPig (deployment) has vulnerable dependencies - https://phabricator.wikimedia.org/T272087 (10sbassett) 05Open→03Resolved p:05Triage→03Low a:03sbassett [01:56:57] 10Fundraising-Backlog, 10FR-Smashpig, 10Security-Team, 10Security, 10Vuln-VulnComponent: wikimedia/fundraising/SmashPig (deployment) has vulnerable dependencies - https://phabricator.wikimedia.org/T272087 (10sbassett) [02:04:26] (03PS1) 10Ejegg: DO NOT MERGE: Check to see if CI is testing current patch [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709865 [02:04:37] (03CR) 10Eileen: "Thanks @ejegg - those should be addressed now" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704199 (https://phabricator.wikimedia.org/T281268) (owner: 10Eileen) [02:06:59] (03CR) 10jerkins-bot: [V: 04-1] Add support for 'Money Order Number' to engage import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/709864 (https://phabricator.wikimedia.org/T283023) (owner: 10Eileen) [02:07:47] (03CR) 10Ejegg: [C: 04-1] "Eileen I'm confused, I see your comments but no code changes from ps1 - is the new gerrit UI hiding something from me?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704199 (https://phabricator.wikimedia.org/T281268) (owner: 10Eileen) [02:07:55] (03CR) 10jerkins-bot: [V: 04-1] DO NOT MERGE: Check to see if CI is testing current patch [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709865 (owner: 10Ejegg) [02:08:05] (03PS3) 10Eileen: Add mechanism to update date custom field when another field is altered [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704199 (https://phabricator.wikimedia.org/T281268) [02:08:18] ejegg|away: maybe It didn't get pushed up [02:08:27] ah now i see PS3 [02:09:59] ejegg|away: I think I hadn't completed git review [02:10:03] command [02:15:50] (03PS2) 10Eileen: Add support for 'Money Order Number' to engage import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/709864 (https://phabricator.wikimedia.org/T283023) [02:54:14] oh dang, is my wmf_donor table myisam? getting a too many keys / max 64 error [02:54:38] * ejegg|away should probably give up on the local db [02:55:36] huh, no, it's innodb [02:55:45] ok, actually |away [03:10:16] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, and 2 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10Eileenmcnaughton) @MSuijkerbuijk_WMF @KHaggard - what about... [03:11:40] ejegg|away: are you getting too many keys with my latest patch? [03:12:04] because that IS an issue - see the phab [03:12:15] ah ok [03:12:17] yep [03:13:24] and there's something else where when I try to run the _wmf_civicrm_update_custom_fields it keeps bombing out with a syntax error trying to alter the log tables [03:13:51] leaving me with the civicrm_custom_field rows created but no columns [03:14:03] neither on the log table nor on the real table [03:28:25] (03PS2) 10Eileen: WIP Hebrew recurring copy [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/708968 (https://phabricator.wikimedia.org/T285375) [03:28:42] (03CR) 10Eileen: "In updating I realised it was even worse than I thought" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/708968 (https://phabricator.wikimedia.org/T285375) (owner: 10Eileen) [03:29:15] ejegg|away: yeah - on master it should still be ok - but there are patches on gerrit that totally bomb because of that [03:30:51] (03PS3) 10Eileen: WIP Hebrew recurring copy [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/708968 (https://phabricator.wikimedia.org/T285375) [03:46:01] (03PS1) 10Eileen: Add the 2 extra desired tracking fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/709873 (https://phabricator.wikimedia.org/T281268) [05:03:57] (03PS2) 10Eileen: Add the 2 extra desired tracking fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/709873 (https://phabricator.wikimedia.org/T281268) [06:04:17] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit: Fredge report only lets you export <200 rows - https://phabricator.wikimedia.org/T287994 (10RKumar_WMF) https://docs.google.com/spreadsheets/d/1SbpIsNz3UW9Mh4n1LVU7ZJWI8BBHvXMj9FHAjO4JCRk/edit#gid=0 Please use above for... [08:44:06] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, 10FR-AutoTY-Email, 10Patch-For-Review: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10CDenes_WMF) Thanks yall. We are coordinating a final roun... [12:17:50] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Adyen: endpoint monitoring for adyen endpoints - https://phabricator.wikimedia.org/T287411 (10Jgreen) >>! In T287411#7253547, @Ejegg wrote: > If we're able to use a POST method somehow the /paymentMethods endpoint might be a good candidate. That endpoint is... [13:18:47] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit: server error seen when attempting to export long search kit list - https://phabricator.wikimedia.org/T287995 (10DStrine) p:05Triage→03Medium [13:18:58] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit: Fredge report only lets you export <200 rows - https://phabricator.wikimedia.org/T287994 (10DStrine) p:05Triage→03Medium [13:19:12] 10Fundraising-Backlog, 10fundraising sprint onion pit, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Test Adyen Checkout via CODFW hosts - https://phabricator.wikimedia.org/T287987 (10DStrine) p:05Triage→03High [13:19:23] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit, 10fundraising-tech-ops: Request for fr-tech-ops to Update civi staging databases back in sync with production - https://phabricator.wikimedia.org/T287632 (10DStrine) p:05Triage→03Medium [13:19:36] 10Fundraising-Backlog, 10fundraising sprint onion pit, 10FR-Adyen: Adyen Checkout: Pull donor contact from Apple Pay sheet - https://phabricator.wikimedia.org/T285722 (10DStrine) p:05Triage→03High [13:20:13] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit, 10FR-Civi-Prospect: Remove switcheroo button from activities - https://phabricator.wikimedia.org/T287644 (10DStrine) p:05Triage→03High [13:20:21] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit: Search kit links not loading when sharing out to Engage - https://phabricator.wikimedia.org/T279686 (10DStrine) p:05Triage→03Medium [13:26:08] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit, 10fundraising-tech-ops: Request for fr-tech-ops to Update civi staging databases back in sync with production - https://phabricator.wikimedia.org/T287632 (10Jgreen) This was started today at ~8:30 EDT. [13:32:21] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, 10FR-France: Adding tax disambiguation clause to Payments Wiki in France - https://phabricator.wikimedia.org/T286880 (10DStrine) p:05Medium→03High [14:32:26] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, and 2 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10MSuijkerbuijk_WMF) Thanks @Eileenmcnaughton -- The start and... [14:41:07] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Adyen: endpoint monitoring for adyen endpoints - https://phabricator.wikimedia.org/T287411 (10Ejegg) The simplest valid POST to that endpoint just has this for body: ` lang=json { "merchantAccount": "YOUR_MERCHANT_ACCOUNT" } ` And at least these headers:... [14:49:06] AndyRussG: I thought of another reason why CI needs to run at least composer install if not composer update - we don't have the dev dependencies checked into vendor [15:43:17] ejegg: ah right and those are needed for tests I guess [17:13:29] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, and 2 others: New Payment Method added: Money Order - https://phabricator.wikimedia.org/T283023 (10MDemosWMF) @Eileenmcnaughton Got it! That sounds good to me. I just teste... [17:27:07] !log updated payments-wiki config to 360c8a1f08 [17:27:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:56:02] fr-tech I'll likely be a few minutes late to tech-talk, apologies especially since I had also asked to change the time!! [18:03:12] 10Fundraising-Backlog: Send Receipts not working from civi - https://phabricator.wikimedia.org/T288149 (10NNichols) [18:22:46] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit: Search kit links not loading when sharing out to Engage - https://phabricator.wikimedia.org/T279686 (10MDemosWMF) @Eileenmcnaughton Thanks for testing this! I will ask Engage if the form links are working for them now. I... [18:29:49] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, and 2 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10KHaggard) To add on to Mariana's questions, do I have it rig... [18:41:45] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit: Send Receipts not working from civi - https://phabricator.wikimedia.org/T288149 (10DStrine) p:05Triage→03High a:05Eileenmcnaughton→03None [18:46:26] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit: Send Receipts not working from civi - https://phabricator.wikimedia.org/T288149 (10DStrine) more info: it seems @MDemosWMF can send receipt but not @NNichols [19:10:54] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, 10FR-France: Adding tax disambiguation clause to Payments Wiki in France - https://phabricator.wikimedia.org/T286880 (10Damilare) a:03Damilare [20:32:12] (03PS1) 10Ejegg: Script to test Adyen connectivity [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/710113 (https://phabricator.wikimedia.org/T287411) [20:32:22] Jeff_Green: ^^^^ [20:33:01] great, thanks! [21:36:58] 10Fundraising-Backlog, 10fundraising-tech-ops: Deactivate FR Tech account for John Bolorinos - https://phabricator.wikimedia.org/T287998 (10Dwisehaupt) [21:37:27] 10Fundraising-Backlog, 10fundraising-tech-ops: Deactivate FR Tech account for John Bolorinos - https://phabricator.wikimedia.org/T287998 (10Dwisehaupt) 05Open→03Resolved [21:38:42] (03CR) 10Ejegg: "Looks good, works in local testing!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704199 (https://phabricator.wikimedia.org/T281268) (owner: 10Eileen) [21:43:06] eileen: should a system.flush be enough to get those new fields created after I pull down the patch? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/709873 [21:44:02] ejegg: no - there is a drush command - I do want to switch to using mgd files but I need to do a bit of upstream work first [21:44:30] what's the drush command? [21:44:36] drush_wmf_civicrm_update_custom_fields [21:44:42] ahh got it [21:45:07] it looks like drush ucf should work [21:45:12] drush @wmff ucf [21:45:25] thanks! [21:46:47] bother, even on a newly created wmff db it's spitting out some HTML error message complaining of invalid SQL syntax on an alter table [21:47:49] cutting the table name off after 'civ' though, so that doesn't exactly narrow it down [21:48:24] ah, ok, below i see CRM_Logging_Schema->fixSchemaDifferencesFor('civicrm_value_be [21:48:35] so it IS indeed the benefactor page listing table [21:48:58] lemme see if I can dump the full alter it's trying to run [21:52:54] huh, running again was quiet [21:52:59] let's see if the fields got created [21:54:01] yes! [21:54:11] * ejegg shrug [21:58:05] hmm, some combination of the docker-compose exec escaping and the drush @wmff escaping is not letting me pass params to drush commands from outside the docker container [21:58:23] $ docker-compose exec civicrm drush @wmff setting.getvalue name=custom_field_tracking [21:58:26] The drush command 'setting.getvalue name=custom_field_tracking' [error] [21:58:29] could not be found. [21:59:38] oh derp [21:59:42] forgot the cvapi [21:59:59] to be fair, there was a lot of preamble to remember! [22:01:24] huh, the setting doesn't seem to have updated after a flush or two [22:01:42] and now i can't edit the benefactor values [22:01:47] let's see what error i'm getting [22:03:37] oh weird, Unknown column 'wls_listing_last_updated_162' in field list [22:03:38] ug - to be fair I did limited testing on creating those 2 fields like that so I probably missed a beat [22:04:48] ejegg: did you mean to +2 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/704199 - if so I'll deploy it first [22:05:05] oh ha, yep [22:05:08] (03CR) 10Ejegg: [C: 03+2] Add mechanism to update date custom field when another field is altered [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704199 (https://phabricator.wikimedia.org/T281268) (owner: 10Eileen) [22:05:49] that column sure looks like it's there in the db [22:08:05] there's a line in the trace which mentions rpow [22:08:24] but I don't think the docker setup actually has a second db configured, does it? [22:08:38] and in any case an update should go to the primary [22:12:51] hmph, and debugging isn't connecting again [22:14:36] oh that was an easy fix [22:14:47] config file had remote autostart commented out [22:15:06] (03Merged) 10jenkins-bot: Add mechanism to update date custom field when another field is altered [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/704199 (https://phabricator.wikimedia.org/T281268) (owner: 10Eileen) [22:17:00] jeepers but there are a LOT of queries involved in saving this stuff [22:17:07] lots of stuff you'd think would be cached [22:17:18] oh right, i just restarted the container [22:17:23] maybe it will be cached [22:17:46] but also a lot of queries that seem like they should be easy to combine [22:18:12] like several in a row asking for different single fields from the same row [22:18:48] for creating the fields - or runtime? [22:18:57] this is just saving an edit [22:19:12] but like I said, i had just restarted the container to pick up the xdebug ini [22:19:23] so maybe a lot of this will be cached on the next request [22:21:50] wat... [22:22:03] so i grabbed the query and ran it in mysql [22:22:26] with this non-existent sample data user [22:22:29] MariaDB [civicrm]> UPDATE civicrm_value_benefactor_pa_12 SET `listed_as_148` = 'public',`listed_on_benefactor_page_as_149` = 'BeeYooLa Adddammmas',`benefactor_order_as_150` = '',`endowment_site_listed_as_151` = 'FOOHOO',`wls_listed_as_152` = '',`benefactor_page_last_updated_153` = 20210804213811,`wls_listing_last_updated_162` = null,`endowment_listing_last_updated_163` = 20210804221838 [22:22:35] WHERE id = 1; [22:22:38] ERROR 1054 (42S22): Unknown column 'wls_listing_last_updated_162' in 'field list' [22:22:41] MariaDB [civicrm]> describe civicrm_value_benefactor_pa_12; [22:22:43] +------------------------------------+------------------+------+-----+-------------+----------------+ [22:22:46] | Field | Type | Null | Key | Default | Extra | [22:22:49] +------------------------------------+------------------+------+-----+-------------+----------------+ [22:22:52] | id | int(10) unsigned | NO | PRI | NULL | auto_increment | [22:22:55] | entity_id | int(10) unsigned | NO | UNI | NULL | | [22:22:58] | listed_as_148 | varchar(255) | YES | MUL | not_replied | | [22:23:01] | listed_on_benefactor_page_as_149 | varchar(255) | YES | MUL | NULL | | [22:23:04] | benefactor_order_as_150 | varchar(255) | YES | MUL | NULL | | [22:23:07] | endowment_site_listed_as_151 | varchar(255) | YES | MUL | NULL | | [22:23:10] | wls_listed_as_152 | varchar(255) | YES | MUL | NULL | | [22:23:13] | benefactor_page_last_updated_153 | datetime | YES | | NULL | | [22:23:16] | wls_listing_last_updated_162 | datetime | YES | | NULL | | [22:23:19] | endowment_listing_last_updated_163 | datetime | YES | | NULL | | [22:23:22] +------------------------------------+------------------+------+-----+-------------+----------------+ [22:23:25] how???? [22:23:34] wls_listing_last_updated_162 <--- value from error message [22:23:53] wls_listing_last_updated_162 <--- value from 'describe' [22:24:06] identical, right? Am I missing something? [22:25:47] ohhhh derp [22:25:57] gotta be log triggers I guess? [22:26:47] right, log table is missing those columns [22:28:07] yep, and the triggers HAVE been updated [22:28:18] ok, so custom field sync seems to skip log tables [22:28:46] though I guess we don't want to log those change dates anyway [22:29:04] ejegg: that won't be a problem on master because we don't auto-create triggers there [22:29:28] shouldn't creating custom fields automatically sync the log schema though? [22:29:32] when logging is on? [22:32:52] lessee, cvapi system.updatelogtable should fix it? [22:32:53] hmm - yeah you'd think it would reload triggers .... [22:33:03] ejegg: fyi https://lab.civicrm.org/dev/mail/-/issues/98 [22:33:25] so it DID update the triggers, just didn't create the new columns on the log tables [22:33:56] ohh, maybe the log table alters were what threw the error the first time I tried to run the update custom fields drush [22:34:11] lemme try the cvapi log table update command [22:35:21] hmm, that didn't add the columns either [22:35:33] i bet if I dropped that log table it would recreate it [22:36:09] hah, nope [22:36:21] lessee, disabling and re-enabling logging setting? [22:37:49] * ejegg thought he'd be free from schema sync troubles using civi under docker [22:38:20] ok, dropped the table, toggled logging off and on, and now I have the columns in the log table [22:38:43] yay [22:39:06] and can save the fields, and tracking for endowment and wls works as expected [22:41:06] (03CR) 10Ejegg: [C: 03+2] "Looks good, works as expected!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/709873 (https://phabricator.wikimedia.org/T281268) (owner: 10Eileen) [22:42:55] yay - I'll deploy it once it merges [22:52:48] (03Merged) 10jenkins-bot: Add the 2 extra desired tracking fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/709873 (https://phabricator.wikimedia.org/T281268) (owner: 10Eileen) [22:52:55] just tried adding another datetime custom field via the UI and it created the log table column fine [22:53:28] but then I tried adding another via that same managed file + drush, and got another HTML error barf [22:53:38] will try one more and see if I can capture the alter statement [22:58:43] ejegg: I want to change all that logic anyway so if it's only a local dev issue Iwouldn't put much time into it [22:59:15] (03CR) 10Cstone: [C: 03+2] "Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709549 (https://phabricator.wikimedia.org/T287262) (owner: 10Ejegg) [22:59:49] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/710122 [23:00:12] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/710122 (owner: 10Eileen) [23:07:26] hmm, a problem in Schema::_getColumnQuery maybe? [23:07:34] $line came out blank [23:07:52] oh jeez, that looks fragile: $line = preg_grep("/^ `$col` /", $createQuery); [23:10:31] oho, it's the case sensitivity [23:10:51] eileen i think it might error on production too [23:11:03] dang [23:11:18] hang on - the columns should be lower case [23:11:24] so... we could make that preg_grep case-insensitive [23:11:25] are they not? [23:11:37] ah, not in that managed CustomGroups file [23:11:39] yeah we could do - but really we just want them to always be lcase [23:11:53] ok - I'm not specifiying column_name - but I could [23:12:09] oh right, not specified there [23:12:27] so I guess the thing that derives column name when not given should lcase it [23:14:01] (03Merged) 10jenkins-bot: Configurable default monthly convert module [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709549 (https://phabricator.wikimedia.org/T287262) (owner: 10Ejegg) [23:14:40] line 157 of BAO/CustomField.php - $addedColumns[$tableName][] = $customField->name; [23:14:47] (03CR) 10Cstone: [C: 03+2] Monthly convert variant 11 - replace text in JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709553 (https://phabricator.wikimedia.org/T287262) (owner: 10Ejegg) [23:15:04] i think is what gets passed in there? [23:15:51] ejegg: yeah it should - but let's just define it for now [23:17:20] (03Merged) 10jenkins-bot: Monthly convert variant 11 - replace text in JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709553 (https://phabricator.wikimedia.org/T287262) (owner: 10Ejegg) [23:17:21] going to debug through a UI field addition to see how that's actually working - i don't see it referring to ->column_name anywhere [23:17:48] oh, will do that after dinner [23:17:48] (03PS1) 10Eileen: Use lcase name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/710124 [23:17:51] ejegg: I think the form does it [23:17:56] ahhh [23:18:16] so - I will look upstream but in terms of creating the fields on master I've lcased the names of the 2 new ones (which I prefer anyway) [23:18:44] ok, do those need to be changed in the Settings.php too? [23:19:15] fieldsUsedInSettings + below? [23:19:49] back in a bit! [23:20:13] (03PS2) 10Eileen: Use lcase name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/710124 [23:20:13] yep [23:22:23] (03CR) 10Cstone: [C: 03+2] "Looks good. Had no issues when loading it in Firefox." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709564 (https://phabricator.wikimedia.org/T287262) (owner: 10Ejegg) [23:23:40] eileen: im going to eat dinner too but then try the Hebrew [23:23:49] cool [23:38:30] (03Merged) 10jenkins-bot: Use flexbox for MC button text alignment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709564 (https://phabricator.wikimedia.org/T287262) (owner: 10Ejegg)