[01:22:50] (03PS1) 10Eileen: Update minimal schema for tests [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711243 (https://phabricator.wikimedia.org/T283798) [01:32:22] (03PS1) 10Eileen: Add new totals fields to silverpop schema [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711244 (https://phabricator.wikimedia.org/T283798) [01:40:05] (03PS2) 10Eileen: Add new totals fields to silverpop schema [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711244 (https://phabricator.wikimedia.org/T283798) [01:48:20] (03PS1) 10Eileen: Add annual total fields to everywhere except the final view [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711246 (https://phabricator.wikimedia.org/T280595) [04:17:10] (03PS1) 10Eileen: local test fix [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711252 [04:17:12] (03PS1) 10Eileen: Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711253 (https://phabricator.wikimedia.org/T283798) [04:18:23] (03CR) 10jerkins-bot: [V: 04-1] Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711253 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:18:29] (03PS2) 10Eileen: Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711253 (https://phabricator.wikimedia.org/T283798) [04:18:31] (03PS2) 10Eileen: [DO NOT MERGE] local test fix [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711252 [04:19:00] (03CR) 10jerkins-bot: [V: 04-1] [DO NOT MERGE] local test fix [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711252 (owner: 10Eileen) [04:19:28] (03CR) 10jerkins-bot: [V: 04-1] [DO NOT MERGE] local test fix [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711252 (owner: 10Eileen) [04:20:04] (03CR) 10jerkins-bot: [V: 04-1] Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711253 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [05:44:50] eileen: hi! getting this error: https://paste.toolforge.org/view/e0440ef3 [05:45:06] (also had to add checkPermissions=0) [05:56:57] (03CR) 10AndyRussG: "Nice work!!!! :) I tried running this with the following command:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595) (owner: 10Eileen) [06:11:50] (03CR) 10AndyRussG: "Hey, thanks so much for this!!! I really like this approach!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) (owner: 10Damilare Adedoyin) [06:20:49] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/711274 (owner: 10L10n-bot) [06:34:21] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/711274 (owner: 10L10n-bot) [09:54:13] (03PS2) 10WMDE-Fisch: selenium: Update README.md file [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/711179 (https://phabricator.wikimedia.org/T282237) (owner: 10Sahilgrewalhere) [09:54:26] (03CR) 10WMDE-Fisch: [C: 03+2] selenium: Update README.md file [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/711179 (https://phabricator.wikimedia.org/T282237) (owner: 10Sahilgrewalhere) [10:26:04] (03Merged) 10jenkins-bot: selenium: Update README.md file [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/711179 (https://phabricator.wikimedia.org/T282237) (owner: 10Sahilgrewalhere) [10:39:10] (03PS9) 10Damilare Adedoyin: Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) [10:42:33] (03CR) 10jerkins-bot: [V: 04-1] Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) (owner: 10Damilare Adedoyin) [10:43:24] (03PS10) 10Damilare Adedoyin: Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) [10:46:10] (03CR) 10jerkins-bot: [V: 04-1] Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) (owner: 10Damilare Adedoyin) [11:19:35] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 5 others: Benefactor Page Listing Custom field - https://phabricator.wikimedia.org/T281268 (10RLewis) @Eileenmcnaughton - yes!!! This is really helpful, thank you s... [11:24:10] (03PS11) 10Damilare Adedoyin: Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) [11:26:39] (03CR) 10jerkins-bot: [V: 04-1] Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) (owner: 10Damilare Adedoyin) [11:34:58] (03PS12) 10Damilare Adedoyin: Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) [11:37:21] (03CR) 10jerkins-bot: [V: 04-1] Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) (owner: 10Damilare Adedoyin) [12:41:06] hey damilare fr-tech [13:01:18] damilare: just grabbing my earphones brb [13:02:08] ok jgleeson [14:29:26] (03CR) 10Ejegg: [C: 03+2] Update minimal schema for tests [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711243 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [14:31:17] (03Merged) 10jenkins-bot: Update minimal schema for tests [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711243 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [15:13:10] hey damilare, how did you get on with the XX country thing? [15:13:24] do you wanna jump back on a call [15:13:47] actually I just realised there's a New Employee Check-in call that you might be on [15:14:03] Hi jgleeson, I'm on the new employee check-in call [15:14:18] no worries! [15:14:54] Could we reschedule till after stand up [15:15:05] thank you [15:16:19] damilare: we could probably talk through your issue on tech-talk later today. probably makes sense to do it then if that's ok? [15:18:08] fr-tech for context, one of Dami's patches is failing on CI due to a handful of tests failing. The tests are failing because the testy 'XX' value doesn't play nice with this line https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/710364/8/gateway_forms/Mustache.php#110 [15:19:01] we were looking at ways to inject some fixture data into the countries list being called. There's probably a few other ways to fix it also [15:19:20] patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/710364/8 [15:38:29] sounds good jgleeson, that'd be helpful [15:42:24] we usually pass in a country value in the test setup [15:42:47] ya [15:44:29] * jgleeson realises he needs to set up github links on the cldr extension [15:44:59] hah, yep, i was just writing a gerrit comment to point dami to CLDR for translated country names [15:46:04] https://github.com/wikimedia/mediawiki-extensions-cldr/blob/8cace7bebf3cd9da27311adb7b1c4f5b355a4b83/includes/CountryNames.php#L22 [15:46:30] so that's the thing he's currently calling [15:47:20] and we were trying to inject the XX value into the static $cache property during test setup but turns out that var is private and reflection felt like overkill [15:47:59] I couldn't see an easy way to add fixture data to that reference class [15:49:21] maybe only bother translating if the country code is in taxDedCountries ? [15:49:42] hi fr-tech jgleeson ejegg damilare :) [15:49:57] hey AndyRussG ! [15:50:09] ejegg: I didn't see any API in CountryNames to only fetch one country name, but I could have easily missed it [15:50:13] jgleeson :) [15:50:46] yeah ejegg maybe that code could be extracted out into it's own function and a check like that added [15:51:01] although it does feel a little bit like we are indirectly modifying the code to fix the test [15:51:19] but I guess it's technically less processing also [15:51:56] is $data['country_full'] only used in the tax_ded scenario? [15:52:25] yes it is only in the tax_ded scenario [15:53:12] oh ok so ejegg's solution should fix our problem [15:54:18] damilare: you could extract that tax_ded specific code out into a method and then check if the current country is in the tax_ded list. That would mean the country_full var only gets set when it's needed and also prevent the current tests failing [15:54:38] HOWEVER, it would mean you couldn't write a test to test your new code, in the event you wanted to [15:55:20] as the test data would result in your new var being skippd. you could probably work around that in the test setup if needed [15:56:24] that's one idea! [16:03:14] I'll be 5mins late, trying to get lunch [16:05:18] oops, i'll be right there [17:04:29] (03PS13) 10Damilare Adedoyin: Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) [17:06:56] (03CR) 10jerkins-bot: [V: 04-1] Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) (owner: 10Damilare Adedoyin) [17:08:17] (03PS14) 10Damilare Adedoyin: Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) [17:11:18] (03CR) 10jerkins-bot: [V: 04-1] Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) (owner: 10Damilare Adedoyin) [17:13:20] (03PS15) 10Damilare Adedoyin: Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) [17:13:30] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, and 2 others: Adyen Checkout: normalize API error codes - https://phabricator.wikimedia.org/T283307 (10Ejegg) a:03Ejegg [17:14:14] (03PS1) 10Ejegg: Rename mapErrors function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/711606 (https://phabricator.wikimedia.org/T283307) [17:22:30] (03PS16) 10Damilare Adedoyin: Add tax disambiguation clause to Payments Wiki in France [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710364 (https://phabricator.wikimedia.org/T286880) [17:25:02] (03CR) 10Ejegg: [C: 04-1] "Actually, maybe the API errors should throw exceptions instead of adding errors to the response. There's no good FinalStatus constant to m" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/711606 (https://phabricator.wikimedia.org/T283307) (owner: 10Ejegg) [17:50:35] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/711626 [17:56:43] (03PS1) 10Jgleeson: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/711630 [17:57:21] (03CR) 10Jgleeson: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/711626 (owner: 10Jgleeson) [18:06:15] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/711626 (owner: 10Jgleeson) [18:11:08] (03CR) 10Jgleeson: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/711630 (owner: 10Jgleeson) [18:22:20] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/711630 (owner: 10Jgleeson) [18:27:59] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, and 3 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10KHaggard) >>! In T283798#7274025, @Eileenmcnaughton wrote: >... [18:38:17] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, and 3 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10EYener) Chiming in here to clarify a few things on my side -... [18:41:53] 10Fundraising-Backlog, 10fr-donorservices: Civi email address format exception request - https://phabricator.wikimedia.org/T288644 (10MBeat33) [18:47:26] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit: Search kit links not loading when sharing out to Engage - https://phabricator.wikimedia.org/T279686 (10MDemosWMF) @Eileenmcnaughton sorry for the late update! From what I was able to gather from Engage (specifically CID/U... [19:01:56] !log payments-wiki updated from a70aaa7944 to 0a27dbe9b6 [19:02:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:39:02] 10fundraising-tech-ops: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10Cmjohnson) [19:39:21] 10fundraising-tech-ops: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10Cmjohnson) [19:39:37] 10fundraising-tech-ops: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10Cmjohnson) [19:39:51] 10fundraising-tech-ops: remove payments100[1-4] from service and prep for decom - https://phabricator.wikimedia.org/T286044 (10Cmjohnson) [20:04:01] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 5 others: Benefactor Page Listing Custom field - https://phabricator.wikimedia.org/T281268 (10Eileenmcnaughton) 05Open→03Resolved [20:11:52] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, and 2 others: New Payment Method added: Money Order - https://phabricator.wikimedia.org/T283023 (10MDemosWMF) @Eileenmcnaughton Please ignore the above since it is still in... [20:16:31] (03CR) 10Ejegg: "The error seems to happen when there are no contact IDs selected and the clause ends up being "WHERE contact_id IN ()" - maybe just short" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595) (owner: 10Eileen) [20:57:07] (03PS2) 10Jgleeson: WIP: Add ApplePay payments-wiki override setup options [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T282596) [21:02:41] (03PS3) 10Jgleeson: WIP: Add ApplePay payments-wiki override setup options [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T282596) [21:10:38] (03PS4) 10Jgleeson: WIP: Add ApplePay payments-wiki override setup options [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T282596) [21:15:19] (03PS5) 10Jgleeson: WIP: Add ApplePay payments-wiki override setup options [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T282596) [21:19:51] (03PS6) 10Jgleeson: WIP: Add ApplePay payments-wiki override setup options [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T282596) [21:27:57] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit: server error seen when attempting to export long search kit list - https://phabricator.wikimedia.org/T287995 (10Eileenmcnaughton) @Jgreen @Dwisehaupt - do you know what limit we have on url length? "6.5.12. 414 URI Too... [21:46:52] (03PS1) 10Ejegg: Map Adyen API error codes to exceptions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/711700 (https://phabricator.wikimedia.org/T283307) [21:47:43] (03CR) 10jerkins-bot: [V: 04-1] Map Adyen API error codes to exceptions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/711700 (https://phabricator.wikimedia.org/T283307) (owner: 10Ejegg) [21:49:36] (03PS2) 10Ejegg: Map Adyen API error codes to exceptions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/711700 (https://phabricator.wikimedia.org/T283307) [21:52:03] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: adding country to fraud scan doesn't return any data (search kit) - https://phabricator.wikimedia.org/T288679 (10DStrine) [21:52:09] (03PS3) 10Ejegg: Map Adyen API error codes to exceptions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/711700 (https://phabricator.wikimedia.org/T283307) [22:15:32] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, and 3 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10KHaggard) Got it, thanks @EYener. Giving more context below:... [23:24:58] (03PS4) 10Eileen: Add api to fill wmf_donor table for 2021 donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595) [23:26:02] (03CR) 10Eileen: Add api to fill wmf_donor table for 2021 donations (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595) (owner: 10Eileen) [23:29:51] (03PS5) 10Eileen: Add api to fill wmf_donor table for 2021 donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595) [23:30:32] (03CR) 10Eileen: Add api to fill wmf_donor table for 2021 donations (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595) (owner: 10Eileen) [23:31:35] (03PS6) 10Eileen: Add api to fill wmf_donor table for 2021 donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595)