[00:01:23] I'm just figuring out if I have 2 gerrit chains for some reason :-( If someone can merge this it would help https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/711244 [00:03:48] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit: Review upstream PRs related to contracted token work - https://phabricator.wikimedia.org/T288698 (10Eileenmcnaughton) [00:49:18] (03PS3) 10Eileen: Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711253 (https://phabricator.wikimedia.org/T283798) [00:51:24] (03CR) 10jerkins-bot: [V: 04-1] Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711253 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [00:51:51] (03PS4) 10Eileen: Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711253 (https://phabricator.wikimedia.org/T283798) [01:04:49] (03PS1) 10Eileen: Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711816 (https://phabricator.wikimedia.org/T283798) [01:14:05] eileen: hi! I can dig in in about 1 hour [01:14:28] cool - it's a bit of a process - I'm just getting my head around it [01:14:29] also thanks for sending the updated patchset and comments on https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/711024 [01:14:53] Yeah - I was relieved when I saw ejegg had diagnosed the sql error for me & I didn't have to :-) [01:15:06] ah yeah also happy to see that :) [01:15:50] AndyRussG: oh - I will add checkPermissions to the commit message - I'm just wondering whether to do it in the UI now & risk a muddle later if you have other changes [01:16:21] hmmm just hoping to make it work locally [01:16:45] eileen: in fact the not-too-tardy non-work things I was gonna do just now can also wait, just in case a call would help with any of this, and in that case, just to say really anytime would be fine [01:16:54] oh right, I had to run it with --user=1 as well [01:17:09] oh ok - good point [01:17:30] ejegg: ah instead of the don't check permissions? hmmm that sounds also reasonable [01:17:32] I'm free if it's useful to talk - I'm just trying to figure out the extra acoustic stuff [01:17:42] oh yeah either or should work [01:17:47] eileen: when would work best for you, now or a bit later? [01:18:07] ejegg: thanks so much for finding the error btw! did the log queries thing work? [01:18:10] either or for that too - well maybe give me 20 mins to just get this bit of the acoustic stuff up there [01:18:30] eileen: ok sounds great pls ping when you're ready, sound good? [01:18:44] ejegg: also pls don't hesitate to join if you'd like of course eh :) [01:19:21] AndyRussG: I just set a breakpoint where it was about to send the query to the db [01:19:35] heehehe ah also that sounds like it'd work ;p [01:20:02] hmmm so maybe the lack of ids was due to me not bothering to set the minumReceiveDate as well as the max? [01:20:14] I guess i didn't check what the default there was [01:20:27] AndyRussG: yeah probably - it defaults to the start of this fiscal year (2021-07-01) [01:21:03] and the sample data I think is all older [01:24:01] ejegg: oh yeah it's all June rth [01:24:08] I'll try again with that [01:25:35] oh phooey now my local civi site is not working [01:25:52] out of the blue some ssl cert issue, on both FF and Chrome [01:26:05] SSL_ERROR_RX_RECORD_TOO_LONG [01:27:11] local payments is fine, though [01:27:15] I'll try rebuilding [01:27:31] (03PS2) 10Eileen: Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711816 (https://phabricator.wikimedia.org/T283798) [01:29:56] (03PS3) 10Eileen: Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711816 (https://phabricator.wikimedia.org/T283798) [01:30:27] K rebuilding fixed it [01:30:38] quite fast now on linux! [01:31:21] ejegg: AndyRussG looks like an easier way might be to update our @wmff alias to specify the user (on dev & prod) https://drupalize.me/tutorial/drush-site-aliases?p=2458 [01:32:19] hmmm [01:34:14] hmmm still getting the same db error when running like this: drush @wmff cvapi WMFDataManagement.updateWMFDonor version=4 maximumReceiveDate=2021-08-10 checkPermissions=0 minimumReceiveDate=2020-01-01 [01:34:21] on a fresh civibuild create [01:45:21] oh yeah, i thought maybe it already did specify the user ID - I was testing on my old local install where I don't have the alias [01:45:47] oh hmm, let me try with a different minimum [01:45:58] there could be additional errors [01:46:07] ejegg: I don't think we have that alias [01:46:08] yet [01:47:17] (03Abandoned) 10Eileen: Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711253 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [01:55:08] (03PS4) 10Eileen: Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711816 (https://phabricator.wikimedia.org/T283798) [01:55:11] eileen: oh hah, i found the typo [01:55:16] addWhere('receive_date', '>', $this->getMinimumReceiveDate()); if [01:55:19] $api->addWhere('receive_date', '<', $this->getMinimumReceiveDate()); [01:55:27] one of those should say 'Maximum' [01:55:35] oh yeah [01:55:50] pick one any one? [01:56:03] heh, the second would work better [01:56:07] :-) [01:56:16] are you gonna make that change or you want me to? [01:56:21] AndyRussG: I can do a call in 5 [01:56:27] I might as well, just did it on local [01:57:29] (03PS7) 10Ejegg: Add api to fill wmf_donor table for 2021 donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595) (owner: 10Eileen) [01:58:00] ohhh noice [01:58:14] eileen: sure! [01:58:47] (03CR) 10Ejegg: [C: 03+1] "Looks good to me, leaving final +2 to AndyRussG" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595) (owner: 10Eileen) [01:59:44] (03PS8) 10Ejegg: Add api to fill wmf_donor table for 2021 donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595) (owner: 10Eileen) [01:59:55] PS8: just a spacing thing [01:59:55] cool [02:01:19] oh yeah - that's kinda not the 'right' way to do it - the right way would be to return the array with all the touched ids - but it is only wmf code [02:01:28] so I can be a bit fast & loose [02:02:03] oh totally, i just wanted to see the number out of curiousity [02:02:10] AndyRussG: I'm in https://meet.google.com/pau-rggj-byc?authuser=0 when you want [02:02:35] and figured it would be easy to get either that id count or just the affected row count from the query [02:03:25] so for the acoustic - we need the new fields in silverpop (I added), we need to start populating them & then (:-() we need to backfill them & also need to co-ordinate deploy with Katie [02:05:47] eileen: okok one sec :) [02:14:51] (03PS1) 10Eileen: Add user 1 to alias [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711823 [02:18:43] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add user = 1 to drush alias - https://phabricator.wikimedia.org/T288708 (10Eileenmcnaughton) [02:21:47] (03PS9) 10Eileen: Add api to fill wmf_donor table for 2021 donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595) [02:23:26] (03CR) 10AndyRussG: [C: 03+2] "Yeaaah @eileen thanks for this, and for the explanations, and for the careful review @ejegg!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595) (owner: 10Eileen) [02:33:46] (03Merged) 10jenkins-bot: Add api to fill wmf_donor table for 2021 donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/711024 (https://phabricator.wikimedia.org/T280595) (owner: 10Eileen) [02:48:53] (03CR) 10AndyRussG: [C: 03+2] Add new totals fields to silverpop schema [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711244 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [02:49:52] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/711854 [02:50:01] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/711854 (owner: 10Eileen) [02:51:19] (03Merged) 10jenkins-bot: Add new totals fields to silverpop schema [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711244 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [03:00:13] (03CR) 10AndyRussG: [C: 03+2] "A nice patch for adding export fields with!!!! :)" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711246 (https://phabricator.wikimedia.org/T280595) (owner: 10Eileen) [03:01:16] (03Merged) 10jenkins-bot: Add annual total fields to everywhere except the final view [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711246 (https://phabricator.wikimedia.org/T280595) (owner: 10Eileen) [03:01:39] !log civicrm revision changed from d8ebf45819 to f3895dc907, config revision is 7bdc78073d [03:01:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:06:46] (03Abandoned) 10Ejegg: Rename mapErrors function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/711606 (https://phabricator.wikimedia.org/T283307) (owner: 10Ejegg) [03:08:47] (03PS5) 10Eileen: Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711816 (https://phabricator.wikimedia.org/T283798) [03:10:10] (03CR) 10jerkins-bot: [V: 04-1] Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711816 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [03:17:56] (03PS6) 10Eileen: Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711816 (https://phabricator.wikimedia.org/T283798) [03:35:32] (03CR) 10AndyRussG: [C: 03+2] "Yaaaay many recurring! :)" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711816 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [03:36:44] (03Merged) 10jenkins-bot: Add new recurring fields for tracking new data [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711816 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [03:38:40] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/711871 [03:39:18] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/711871 (owner: 10Eileen) [03:40:09] !log process-control config revision is 7bdc78073d [03:40:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:44:51] !log tools revision changed from c26a8c0cb6 to 15bfaa7117 [04:45:06] (Argh I pushed out process control not tools - hence it dinna work before) [04:45:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [05:22:03] eileen: and this one? superseded now? [05:22:05] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/711093/ [05:22:41] AndyRussG: yeah - kinda - that has the renaming in it that I decided to do right at the end [05:22:49] but def not reviewable at the moment [05:29:44] ah okok cool :) [05:32:43] I ran the data fill - but I messed up the min & max date - which was the fail mail & also it seems it was a bit less efficient for unknown reasons that I hoped - it's done now though & the data is filled [05:41:36] (03CR) 10AndyRussG: "Hi! Thanks for this...!! Just to say, apologies for not getting to this yet, I can dig in tomorrow :)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [05:42:09] eileen: yay congrats!! [05:42:37] AndyRussG: yeah - now just dealing with having done silverpop stuff not-quite-in-order - but I'll get there with it [05:42:56] K good luck! [05:45:33] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1320 [05:49:19] AndyRussG: I also figured out the menu issue [05:49:45] dang - that replication lag is my silverpop fill query [05:50:37] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1621 [05:55:33] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1920 [05:58:37] (03PS2) 10Eileen: Add wmf-config to menu [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/708606 [06:00:33] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 3601282 Threads: 17 Questions: 149740056 Slow queries: 2939864 Opens: 1041913209 Flush tables: 1 Open tables: 266 Queries per second avg: 41.579 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 600 [06:03:30] gonna do one more tho [07:04:42] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit: Create new WMF donor fields - https://phabricator.wikimedia.org/T288721 (10Eileenmcnaughton) [07:05:52] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, 10Patch-For-Review: Wmf-donor - new year fields - https://phabricator.wikimedia.org/T280595 (10Eileenmcnaughton) I've put this in done as the original task is complete now... [07:11:55] (03PS1) 10Eileen: Add addition export fields [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712067 (https://phabricator.wikimedia.org/T283798) [07:11:57] (03PS1) 10Eileen: Field name changes in acoustic export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712068 (https://phabricator.wikimedia.org/T283798) [07:13:23] (03CR) 10jerkins-bot: [V: 04-1] Add addition export fields [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712067 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [07:13:29] (03CR) 10jerkins-bot: [V: 04-1] Field name changes in acoustic export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712068 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [07:27:39] (03PS2) 10Eileen: Add addition export fields [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712067 (https://phabricator.wikimedia.org/T283798) [07:29:30] (03CR) 10jerkins-bot: [V: 04-1] Add addition export fields [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712067 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [07:40:34] (03PS3) 10Eileen: Add addition export fields [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712067 (https://phabricator.wikimedia.org/T283798) [07:42:10] (03CR) 10jerkins-bot: [V: 04-1] Add addition export fields [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712067 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [07:52:16] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint onion pit: Review upstream PRs related to contracted token work - https://phabricator.wikimedia.org/T288698 (10Eileenmcnaughton) a:03Eileenmcnaughton [07:56:35] (03PS4) 10Eileen: Add addition export fields [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712067 (https://phabricator.wikimedia.org/T283798) [08:01:06] 10Fundraising-Backlog, 10Fr-CentralNotice-Translation-Bugs, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: BUG: CentralNotice banner translations sometimes go missing from Translate interface - https://phabricator.wikimedia.org/T90863 (10Ameisenigel) [08:01:39] (03PS2) 10Eileen: Field name changes in acoustic export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712068 (https://phabricator.wikimedia.org/T283798) [08:08:53] (03PS1) 10Eileen: Rename all prospect fields to TS [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712087 (https://phabricator.wikimedia.org/T283798) [08:12:46] (03PS1) 10Eileen: Rename all_funds to both_funds in final views [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712088 (https://phabricator.wikimedia.org/T283798) [08:32:13] (03PS1) 10Eileen: Rename endowment_number_donations to endowment_donation_count [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712101 (https://phabricator.wikimedia.org/T283798) [08:32:15] (03PS1) 10Eileen: Rename foundation fields to 'AF' for Annual fund' in final view [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712102 (https://phabricator.wikimedia.org/T283798) [08:32:39] (03Abandoned) 10Eileen: Fields update for acoustic export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/711093 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [13:36:27] hi fr-tech! [13:36:47] hmmm looks like the silverpop export job failed after Eileen's email about the previous one failing [14:19:30] Hi jgleeson [14:25:27] hi cstone ! :) [14:28:55] ok I'm gonna check out the logs on that silverpp job [17:09:09] 10Fundraising-Backlog, 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10Release-Engineering-Team (Next): Create composer-test-php70 docker image for fundraising tech's crm tests - https://phabricator.wikimedia.org/T230446 (10Jdforrester-WMF) a:05Jdforrester-WMF→03None [19:19:15] (03PS7) 10Jgleeson: Add ApplePay payments-wiki override setup options [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T282596) [19:26:42] 10Fundraising-Backlog, 10FR-Adyen: Add Apple Pay test server support to fundraising-dev - https://phabricator.wikimedia.org/T288772 (10jgleeson) [19:28:32] (03PS8) 10Jgleeson: Add ApplePay payments-wiki override setup options [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T288772) [19:29:21] 10Fundraising-Backlog, 10fundraising sprint onion pit, 10FR-Adyen, 10Patch-For-Review: Add Apple Pay test server support to fundraising-dev - https://phabricator.wikimedia.org/T288772 (10jgleeson) [19:31:25] 10Fundraising-Backlog, 10fundraising sprint onion pit, 10FR-Adyen, 10Patch-For-Review: Add Apple Pay test server support to fundraising-dev - https://phabricator.wikimedia.org/T288772 (10jgleeson) The command to initiate tunnelling between the cloud VPS and your local docker payments-wiki is: `ssh -v -R 4... [19:38:12] (03PS11) 10Ejegg: [Refactor] Move existing contact matching code to new WMFContact::save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703267 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [19:39:24] (03CR) 10Ejegg: [C: 03+2] "Clean refactor!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703267 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [19:41:05] (03PS10) 10Ejegg: Remove match_on_import conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703268 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [19:42:05] (03CR) 10Ejegg: [C: 03+2] "I agree with the reasoning, let's always match on import." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703268 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [19:50:41] (03Merged) 10jenkins-bot: [Refactor] Move existing contact matching code to new WMFContact::save class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703267 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [19:52:30] (03Merged) 10jenkins-bot: Remove match_on_import conditional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703268 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [20:04:04] 10Fundraising-Backlog, 10FR-Ingenico: Swedish donations stuck at status 600 - https://phabricator.wikimedia.org/T246710 (10EMartin) You have been invited to the following event. Title: Adyen : Wikimedia Placeholder for technical call When: Fri Aug 13, 2021 5am – 6am Pacific Time - Los Angeles Joining in... [20:12:20] (03PS9) 10Ejegg: Add ability to match on address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703270 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [20:13:56] (03CR) 10Ejegg: [C: 03+2] "Looks safe and works locally with a manipulated queue message." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703270 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [20:15:07] (03CR) 10Ejegg: [C: 03+2] "Thanks, this looks handy!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711823 (owner: 10Eileen) [20:20:01] (03CR) 10Eileen: [V: 03+2] Add user 1 to alias [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711823 (owner: 10Eileen) [20:25:29] (03Merged) 10jenkins-bot: Add ability to match on address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703270 (https://phabricator.wikimedia.org/T283104) (owner: 10Eileen) [20:50:35] (03CR) 10Ejegg: "Still looking. So far I can see that it generates some valid SQL, but the UI is much harder to use. Most of the filters are now collapsed " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703637 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [20:51:33] (03CR) 10Eileen: "On the UI side I did deal with the identical headers thing in upstream code fixes - which will be in the next release" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703637 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [20:52:43] (03CR) 10Eileen: "It might be worth trying against the 5.41 rc https://download.civicrm.org/latest/" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703637 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [21:08:16] (03CR) 10Cstone: "Working nicely just question on user experience. With this patch it gets into one of the JS alert errors that says a generic "There was an" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/711700 (https://phabricator.wikimedia.org/T283307) (owner: 10Ejegg) [21:14:48] (03CR) 10Ejegg: "Thanks for taking a look! Agreed that we should improve the DI error handling" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/711700 (https://phabricator.wikimedia.org/T283307) (owner: 10Ejegg) [21:57:06] eileen: I'm getting some upgrade hiccups in 5.41 [21:57:24] ejegg: ug - good to know though I guess - what are they? [21:57:28] something is looking for an unknown method getLanguage() on all the Get classes [21:57:37] maybe to do with civi_data_translate ? [21:57:43] I can't seem to load any UI though [22:01:27] hmm, drush civicrm-ext-disable civi-data-translate doesn't seem to actually disable it [22:03:39] ok, setting is_active to 0 in the db seemed to do it [22:03:45] and now I can load the main page [22:06:03] ok, and ran the extension updates [22:07:24] hmm, even after system.flush and sudo rm -rf all the templates_c contents, there are screenfuls of warnings about 'Notice: Undefined index:blah in include() ....' in templates_c paths [22:11:58] let's see if enabling the translate ext via the UI blows it all up again... [22:12:47] eileen: had you tried 5.41RC locally with civi-data-translate yet? [22:13:02] ejegg: ah no -it is moved into core [22:13:26] oho, so we should remove that extension when we update [22:13:39] along with apiv4 it seems? [22:14:52] ah, and mark wmf-civicrm as not depending on it [22:21:13] eileen: is it worth digging into all those missing indexes in the templates? Or is someone else working through all of those? [22:21:22] I guess I should at least try on a fresh install [22:21:39] missing indexes ? [22:22:04] with the RC i get a bunch of warnings at the top of the page about missing indexes in the templates [22:22:21] like, the templates are referring to keys that are not provided [22:22:36] even after clearing out templates_c and flushing the system [22:29:23] shoot, setup.sh bombed out during civibuild, right after it called composer install [22:29:31] let's update buildkit... [22:30:32] not much change there [22:30:33] hmm [22:33:54] and... still dies [22:34:13] oh right, probably the xdebug config [22:36:19] yarp [22:36:34] had to comment out the remote_autostart line [22:36:51] guess i should tear down and rebuild more often [22:38:32] ok, in civibuild set I now get API error: Entity not loadedSearchDisplay on SavedSearch.create [22:38:42] so lets see which extension that would be [22:38:55] ahhh, org.civicrm.search_kit [1] => wmf-civicrm [22:42:33] huh, so the only managed entities in search_kit seem to be an OptionGroup and two OptionValues [22:42:34] ejegg: I'm actually gonna be offline for most of today - which is a shame because it would be good to work through this [22:43:12] no worries eileen [22:43:40] i just may not get to the point of seeing the good UI for the new fredge report [22:45:50] ok, so monolog and deduper both install SearchDisplay via mgd files [22:46:12] let me try putting the search_kit enablement on a separate command line [22:50:40] so search_kit got enabled fine on its own [22:51:14] ok, not the wmf-civicrm enablement fails on monolog entity not loaded [22:51:47] so it seems there was some mechanism in 5.39 for loading entities after loading dependent extensions [22:52:08] that's been lost on the 5.41 upgrade [22:52:17] let's see what's changed in the extension handling [22:55:39] huh, no changes under CRM/Extension [22:58:43] ohh, so that's a new exception being thrown [22:59:11] though it seems there would have been a different exception if it weren't there [23:00:39] so that's just looked up the entity in CoreUtil::getBAOFromApiName [23:00:47] which does seem to have a few changes [23:01:45] ejegg: [23:02:05] if you want to try with the nightly (dmaster) instead of the rc you could pull in Tim's token patch too [23:02:07] now calling self::getInfoItem [23:02:13] https://github.com/civicrm/civicrm-core/pull/20975 [23:02:22] thanks eileen ! [23:03:13] there is a goal to review that patch over the next 3-4 days [23:03:18] I'm still learning things tracking down this managed entity load bit [23:03:25] oh yeah [23:04:40] i would definitely like to get up to speed on the code totten's writing though [23:06:17] hmm, the change in getBAOFromApiName seems to be a pretty harmless refactor [23:07:04] but that seems to depend on class_exists [23:11:39] so has the autoloader changed? [23:11:48] or something that refreshes its cache? [23:12:23] well... i could try with the nightly i guess and see if this is working [23:26:11] huh, hard to do git bisect on civicrm-core [23:26:26] what with the generated code [23:47:52] (03PS1) 10Ejegg: Remember chosen xdebug port [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/712755 [23:54:35] uff, why does bash's option getting stink so hard