[00:04:13] (03PS1) 10Eileen: Permit pass through of money order [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713371 (https://phabricator.wikimedia.org/T283023) [00:04:39] dwisehaupt: I feel like the main reason not to would be a publicly exposed website with DOS potential? [00:05:17] yeah. [00:05:20] ejegg: can I get you to +2 ^^ - that just allows 'Money Order' to be accepted as a payment instrument & basically means that 'any' legit value will work [00:05:40] looking [00:06:09] i'm just trying to see if we could get a scale determination. we should be able to bump it but just wondering if there is a realistic limit. [00:06:20] uff, yeah, that mapping should def be in the database if anywhere [00:06:37] ejegg: yeah it will fail other validation [00:06:41] if it's wrong [00:08:47] right, seems safe enough [00:08:55] it's not going to automatically create new instruments [00:09:55] eileen if you wanted to fix it on the other end you could pass the parameter as 'raw_payment_instrument' [00:10:13] Would that be a big mutation to the import code? [00:10:27] ejegg: yeah I guess I could - my feeling is that we probably just want to unravel that whole function over time [00:11:09] it feels like it exists because the pre-v3-api world was tricky [00:19:55] ok. i did some tests but i'm not sure i'm getting anything useful. i'll look into it tomorrow. [00:21:54] eileen: yeah, I guess we also have a funky payment method / payment submethod 'normalized' queue format that would be tricky to map to payment instruments just using civi core functions [00:22:23] ejegg: yeah - so my thinking is we need a function where we have weird stuff going on [00:22:31] where we don't we could just pass it through [00:23:02] raw_payment_instrument is meant to be that passthrough, no? [00:23:15] just to say explicitly 'this is the civi code' [00:23:36] rather than stuffing the civi code into the normalized-for-queue field [00:24:28] i'm not totally set on this, just trying to see how strong a case there is for keeping the distinction [00:26:03] so engage generally imports things with the payment_method column set to one of our internal codes? [00:29:08] ejegg: yeah so theoretically we have a bit of a mapping - which would look like an array of 'if we get this then switch to that' [00:29:09] well, looks like that function is only called in one place [00:29:23] seems safe enough [00:29:56] about 95% of the code that relates to payment_instrument_id (including in the imports) should go in favour of what would basically be a conversion array for our legacy stuff IMHO [00:30:10] legacy or queue related I guess is fairer [00:30:36] (03CR) 10Ejegg: [C: 03+2] "Seems safe enough - would let us get rid of raw_payment_instrument if there's no possibility of collision. The fn is only called from one " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713371 (https://phabricator.wikimedia.org/T283023) (owner: 10Eileen) [00:30:49] back in a bit... [00:41:36] (03Merged) 10jenkins-bot: Permit pass through of money order [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713371 (https://phabricator.wikimedia.org/T283023) (owner: 10Eileen) [00:42:53] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/713373 [00:43:02] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/713373 (owner: 10Eileen) [00:44:57] !log civicrm revision changed from ba0c7705bb to 175a3101f7, config revision is 7bdc78073d [00:45:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:52:08] ok - one more import related to merge if possible - then it should be 'done' https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/709864 [00:53:18] Also AndyRussG - did you see I figured out the missing bit for getting that menu link to show up & work - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/708606 - it should just need to be pulled down & a system flush (drush @wmff cvapi System.flush) [01:05:32] (03PS3) 10Eileen: Add wmf-config to menu [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/708606 [01:05:34] (03PS1) 10Eileen: Stock CiviCRM 5.41 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713376 [01:06:28] (03Abandoned) 10Eileen: Stock CiviCRM 5.41 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713376 (owner: 10Eileen) [01:18:23] eileen: hey... didn't see it yet, but thanks for the heads-up! [01:24:25] AndyRussG: yeah - it's pretty trivial - you have to add to the menu AND the navigation - the first makes the url work, the second adds it to the menu (which is kinda confusing) - I only did 1 first time [01:33:07] (03PS1) 10Eileen: Stock CiviCRM 5.41 rc [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/713378 [01:41:15] (03CR) 10jerkins-bot: [V: 04-1] Stock CiviCRM 5.41 rc [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/713378 (owner: 10Eileen) [02:00:31] eileen: ahh cool gotcha :) [02:35:21] eileen: oh dang, you're getting that entity not loaded error I was running into locally [02:36:25] do you know where in the loading of multiple extensions it should be reloading the new entities? I didn't see anything changed in the CRM/Core/Extension bits [02:41:23] (03PS4) 10Ejegg: Add wmf-config to menu [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/708606 (owner: 10Eileen) [02:41:27] (03CR) 10Ejegg: [C: 03+2] Add wmf-config to menu [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/708606 (owner: 10Eileen) [02:45:24] (03PS3) 10Ejegg: Add support for 'Money Order Number' to engage import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/709864 (https://phabricator.wikimedia.org/T283023) (owner: 10Eileen) [02:45:34] (03CR) 10Ejegg: [C: 03+2] Add support for 'Money Order Number' to engage import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/709864 (https://phabricator.wikimedia.org/T283023) (owner: 10Eileen) [02:51:56] (03Merged) 10jenkins-bot: Add wmf-config to menu [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/708606 (owner: 10Eileen) [02:57:07] (03Merged) 10jenkins-bot: Add support for 'Money Order Number' to engage import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/709864 (https://phabricator.wikimedia.org/T283023) (owner: 10Eileen) [02:58:35] ejegg: sorry was out getting vaxxed - looks like we might be going into lockdown [02:58:47] oh damn! [02:58:55] what a bummer [02:59:33] so i was looking into the failmail on the unknown campaign id (I thought you'd solved it with a fallback search) [02:59:42] oh right [02:59:56] yeah I thought we created them if they don't exist? [03:00:03] and I selected from the wrong option group and noticed that something is creating lots of multiple name suffixes [03:00:17] right, right, we should [03:00:43] oh right, the last problem was that we checked for existence by value and then created by label [03:01:20] or vice versa [03:02:26] anyway, looks like Jenkins has the same 'entity not loaded' issue on 5.41 as I had locally [03:02:48] ejegg: yeah - I assumed it would - I'll take a look [03:09:06] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/713381 [03:10:32] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/713381 (owner: 10Eileen) [03:11:10] !log civicrm revision changed from 175a3101f7 to 66568246a2, config revision is 7bdc78073d [03:11:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:12:00] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, 10fundraising sprint onion pit: New Payment Method added: Money Order - https://phabricator.wikimedia.org/T283023 (10Eileenmcnaughton) @MDemosWMF please test now (it's on... [03:19:25] ok, so the getoptions triggered by this line: https://phabricator.wikimedia.org/diffusion/WFCG/browse/master/drupal/sites/all/modules/wmf_civicrm/wmf_civicrm.module$1809 returns value => label, so when the utm_campaign exists as a value we don't create anything new [03:20:18] then I guess the api creation logic looks for it by name? [03:21:29] ejegg: yeah so I can see for the install where it's coming from but it should get turned back by if (!civicrm_api3('Extension', 'getcount', [03:22:03] the loading? [03:22:05] re campaign - v3 api should accept a name or id for campaign_id [03:22:23] v4 api expects you to pass an id unless you use campaign_id:name [03:22:26] aha, but what we're passing here only matches the value [03:22:32] neither name nor id [03:23:01] yeah - it's not campaign is it - it is direct mail appeal [03:23:06] value should work [03:23:19] perhaps if it has just been created there is a caching issue? [03:23:34] so it would happen in https://phabricator.wikimedia.org/diffusion/WFCH/browse/master/api/v3/utils.php$2272 [03:23:39] _civicrm_api3_api_match_pseudoconstant [03:24:00] I'm pretty sure this one was created in the UI [03:24:21] and not via the automatic process [03:24:34] since via the automatic process they all have name==value [03:25:51] https://phabricator.wikimedia.org/diffusion/WFCH/browse/master/api/v3/utils.php$2286 seems to be looking at just the 'name' field to match on though [03:26:08] https://www.nzherald.co.nz/nz/covid-19-coronavirus-case-identified-in-auckland-community-no-link-to-border-or-miq/JQEPSWCF7HZBEYK472MDETKMQE/ - this is why I'm expecting to be in lockdown tomorrow [03:26:25] dang [03:27:20] yeah - they will probably go straight to lock down because, delta [03:27:27] yep [03:27:58] it's nice to think that NZ can get back to zero cases [03:28:01] we will know if 2.5 hours but my money says we'll be in lockdown by morning [03:28:44] but with the rest of the world seeming to fail completely at controling it, that'll mean a lonnnnng time without international travel, no? [03:29:23] I think they will have to open our borders once the vaccine rollout is 'complete' - however that is defined [03:30:16] i guess maybe by the time it's approved for + distributed to kids? [03:31:16] yeah - I think by the end of the year our vaccine rollout will be done for adults & that should be around about the timing it's approved for kids maybe [03:31:49] so I think we'll see a lot more of that new FallGiftChallenge appeal - for now i'll just fix the 'name' field of that row to match the 'value' [03:32:25] ok cool & we can dig in more later - it should be accepting value but maybe ignoring is also good [03:41:45] ok, I described the issue at the failmail zoo - https://www.mediawiki.org/wiki/Fundraising_tech/Failmail_zoo#INVALID_MESSAGE_Cannot_create_contribution,_civi_error! [03:41:53] and fixed the name for that one value [03:46:20] ooh, it's late here [03:46:23] good night! [03:48:14] on the entnight [03:59:31] eileen: hi [03:59:36] finally getting to Civi stuff ;p [03:59:44] :-) [04:26:42] (03CR) 10AndyRussG: Add addition export fields (031 comment) [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712067 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:33:44] eileen: so if I understand correctly, you've smoke tested the SQL in the last version of the chain of Gerrit changes correctly? [04:33:52] *somewheree [04:34:21] AndyRussG: only by making test pass I think tbh [04:34:22] (I mean to say "somewhere" instead of "correctly".... dunno how that brain fart happened...) [04:34:43] eileen: oki... should it be smoke tested somewhere? [04:35:02] although having tests pass mean that the view is valid & all the fields & other sql is valid [04:35:28] oki [04:35:33] is that sufficient? [04:35:55] AndyRussG: silverpop export has run for the day - which means the silverpop database on staging could have the view dropped & rebuilt by copy & paste sql [04:36:26] there is also another qa step in the mix - which is the deployment involves co-ordinating with Katie who also does some checks [04:36:42] so, the biggest risks I guess would be mis-mapping the data fields [04:37:10] ah cool [04:37:12] I mean it's OK to scramble a bit when we are deploying but we don't want to have mapped total_2020 to total_2021 [04:37:43] AndyRussG: the other thing that probably needs more eyes on is the phab has Katie's list of new field names [04:38:10] unfortunately it's mostly in a spreadsheet & a little bit in the comments - I tried to do the bit in the comments first & link to the comment in question [04:38:28] that was after the spreadsheet so supercedes it [04:38:34] ok [04:39:06] but the other fields *should* be per the spreadsheet now (there is a piece of me that wonders if I did them all or got bored before I got to the end :-) [04:39:34] but you also might find it rewarding to look at the docker side of it & improve that as part of the review [04:42:58] eileen: I'm sure I would find that rewarding [04:43:08] but am also kinda thinking of going to sleep "early" this evening ;p [04:43:17] also a good plan [04:45:47] eileen: I'm inclined to +2 it all... I looked it all over and it looks great :) [04:46:09] AndyRussG: cool - we get another QA when Katie does her bit [04:46:20] ok yeah [04:46:28] as long as no fields are cross mapped I don't think too much can go wrong [04:46:32] (03CR) 10AndyRussG: [C: 03+2] Add addition export fields [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712067 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:46:36] (03CR) 10AndyRussG: [C: 03+2] Field name changes in acoustic export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712068 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:46:39] (03CR) 10AndyRussG: [C: 03+2] Rename all prospect fields to TS [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712087 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:46:42] (03CR) 10AndyRussG: [C: 03+2] Rename all_funds to both_funds in final views [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712088 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:46:45] (03CR) 10AndyRussG: [C: 03+2] Rename endowment_number_donations to endowment_donation_count [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712101 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:46:48] (03CR) 10AndyRussG: [C: 03+2] Rename foundation fields to 'AF' for Annual fund' in final view [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712102 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:47:28] eileen: the docker bit is indeed a great idea to work on, indeed it would be fun to have that as a standardized testing ground [04:47:58] (03Merged) 10jenkins-bot: Add addition export fields [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712067 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:48:01] AndyRussG: yeah I was mostly taking pity on you doing review rather than being able to get your teeth into something :-) [04:48:11] - of course it would also be useful [04:48:11] (03Merged) 10jenkins-bot: Field name changes in acoustic export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712068 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:48:13] (03Merged) 10jenkins-bot: Rename all prospect fields to TS [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712087 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:48:20] (03Merged) 10jenkins-bot: Rename all_funds to both_funds in final views [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712088 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:48:22] (03Merged) 10jenkins-bot: Rename endowment_number_donations to endowment_donation_count [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712101 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [04:48:37] eileen: hehehe don't worry it's ok, I do appreciate the concern tho ;) [04:49:03] (03Merged) 10jenkins-bot: Rename foundation fields to 'AF' for Annual fund' in final view [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/712102 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [05:10:23] eileen: cya! :) [05:10:24] thx! [06:22:23] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713404 (owner: 10L10n-bot) [07:59:55] (03CR) 10DannyS712: [C: 03+2] "False positive donate_interface-taxded-msg-x" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713404 (owner: 10L10n-bot) [08:39:46] (03PS2) 10Eileen: Stock CiviCRM 5.41 rc [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/713378 [08:42:39] (03CR) 10jerkins-bot: [V: 04-1] Stock CiviCRM 5.41 rc [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/713378 (owner: 10Eileen) [08:55:27] (03PS3) 10Eileen: Stock CiviCRM 5.41 rc [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/713378 [09:05:38] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit: Create new WMF donor fields - https://phabricator.wikimedia.org/T288721 (10Eileenmcnaughton) @eyener - yep [09:06:01] (03CR) 10jerkins-bot: [V: 04-1] Stock CiviCRM 5.41 rc [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/713378 (owner: 10Eileen) [14:05:45] hi fr-tech! [14:05:59] anyone looking into those recurring qc failures? [14:07:04] oh weird, Error: Unsupported operand types in Statistics\Collector\AbstractCollector->endTimer() [14:07:27] maybe has to do with last night's deploy [14:07:44] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Corrugated super slide, 10Fundraising Sprint Downed power line jump rope, and 23 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10jgleeson) [14:08:08] so it looks like that happens after the queue consumer finishes, at least [14:10:32] hmm, or does it? [14:14:14] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Corrugated super slide, 10Fundraising Sprint Downed power line jump rope, and 23 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10jgleeson) [14:41:15] hi fr-tech [14:41:30] hi cstone! [14:46:16] what operand could even be unsupported in that endTimer function? [14:46:31] all it does is assignment, concatenation, and subtraction [14:46:51] but php seems to be fine with echo 'blue' - NULL; [14:46:57] just coerces types [14:50:56] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Corrugated super slide, 10Fundraising Sprint Downed power line jump rope, and 23 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10jgleeson) [14:56:16] hi ejegg cstone fr-tech! [14:57:53] looking now ejegg [14:59:17] i was just talking through fr-tech chores with damilare and picked up another failmail to use an example of how we dig into stuff. I'm wishing I picked the recurring failmail now! [15:01:12] what got deployed last night ejegg ? [15:01:28] the recurring numbers dont look off but I haven't looked at anything else [15:02:52] jgleeson: some refactors to the WmfContact::Save() bits [15:03:04] let me get a diff up [15:03:06] ooh its the paypal one okay [15:03:18] ohh, is that the pattern? [15:03:27] 4am and paypal haha [15:05:25] paypal donations missing contribution tracking IDs? [15:06:06] i was just thinking it was the smashpig job guess im still not awake haha [15:08:09] the ones in the log i opened both had ct ids ejegg [15:12:11] ejegg: I can't see any code that interacts differently with the stats timer stuff [15:17:46] hey fr-tech! :) [15:18:36] hey AndyRussG [15:18:57] jgleeson: hi! :) [15:19:03] Thanks for the reply about the apple pay stuff [15:19:13] thanks for digging in! [15:19:30] sorry I missed where you'd already documented the ssh command, my bad 8p [15:19:51] ejegg: what was that patch of eileen's you commented on that might have damaging side effects ? [15:20:19] AndyRussG: that was another good example why I think we need a civicrm-community-like "how to test" format to our commits [15:20:30] or phab format even [15:21:01] like ejegg did here https://github.com/civicrm/civicrm-core/pull/21019 [15:21:40] yeah I see now [15:22:31] I did look on other Phab tasks, but not on the Docker one [15:22:58] wrt smash-pig, I do have it on a58edc020a5ec194dea0830c27268c6271b92b81 [15:23:23] jgleeson: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/713326 was the change i suspected [15:23:34] that's smash-pig in payments/vendor/wikimedia/smash-pig/ [15:23:45] ejegg: I think that might happen when the startTimer value is unset or invalid in some way [15:24:01] so maybe it's being wiped mid process [15:24:16] I'll run a donation locally to see if i can recreate it [15:24:27] jgleeson: I have to run to the bank in a few minutes but will take the computer, so I may be able to do some work while waiting there [15:24:37] hmm, yeah, that change seems really hard to connect to a timer issue [15:27:56] AndyRussG: yeah I have some local changes on donation interface I applied during testng with the apply pay test server to get around some of the smashpig gaps yet to be added in the WIP patch so you probably just need those to get it working. [15:29:30] jgleeson: ahh ok... yeah it didn't seem like an especially complicated issue, btw, just didn't get to debugging thru it yet 8p [16:57:28] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Civi certificate request: Yamini - https://phabricator.wikimedia.org/T288987 (10Dwisehaupt) a:03Dwisehaupt [16:59:12] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Civi certificate request: Yamini - https://phabricator.wikimedia.org/T288987 (10Dwisehaupt) [16:59:37] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Civi certificate request: Lefki - https://phabricator.wikimedia.org/T288986 (10Dwisehaupt) a:03Dwisehaupt [17:00:00] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Civi certificate request: Lefki - https://phabricator.wikimedia.org/T288986 (10Dwisehaupt) [17:49:03] 10Fundraising Sprint Interstitial ads halfway down the coaster hill, 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, and 4 others: deprecate and or move wikitech documentation to Mediawiki - https://phabricator.wikimedia.org/T281304 (10AndyRussG) [17:57:23] fr-tech I tried recreating the recurring recurring failmail locally but didn't manage it [17:58:46] jgleeson: yeah, it didn't happen for me either [17:58:55] and i notice it doesn't happen for every run on prod [17:59:09] so there must be some particular code path [17:59:23] lemme look at those logs again [18:00:02] jgleeson: locally you were consuming a subscr_payment message (i.e. a recurring installment)? [18:00:17] I wonder if it was a subscr_start or something hitting that problem on prod [18:02:05] yep, it's a subscr_signup! [18:02:14] ok, let's see if all of them do that [18:03:49] hmm, so in the log connected to the first failmail there are two subscr_signups and the issue happens after the second [18:04:09] jgleeson: is your stats collector doing anything on destruct? [18:04:22] i.e. should we be looking for cleanup handler type of logic? [18:04:40] or just when explicitly called by the wmf_civicrm code? [18:10:43] lemme check [18:17:33] nothing that I can see ejegg [18:17:50] how were you able to recreate it locally? [18:22:24] still haven't recreated it locally [18:22:44] ah sorry [18:22:52] just noticed that the occurrences in the logs are after subscr_signup messages jgleeson [18:23:44] yeah I'm fumbling around paypal dev account trying to remember how to test with it [18:24:16] looks like we need to run ngrok to get the ipns in [18:24:17] we should be able to send some test messages to the queue, I think [18:25:46] yep, there's a recurring_signup.json in the tests/data folder inside queue2civicrm [18:25:58] gonna have some lunch, back in a bit [18:30:26] thanks I'll check it out [18:51:41] right let's try that test [19:06:19] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit: If check number is edited, contribution cannot be found in search - https://phabricator.wikimedia.org/T286495 (10DStrine) 05Open→03Resolved [19:06:46] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, 10FR-Japan, and 2 others: set Japanese monthly convert variant 11 to default - https://phabricator.wikimedia.org/T287262 (10DStrine) 05Open→03Resolved [19:07:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, 10Patch-For-Review: Wmf-donor - new year fields - https://phabricator.wikimedia.org/T280595 (10DStrine) 05Open→03Resolved [19:08:09] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Civi certificate request: Lefki - https://phabricator.wikimedia.org/T288986 (10Dwisehaupt) SSL Client certificate created. Password sent via SMS. CiviCRM account created. Welcome email sent to instruct now to change the civi password. [19:08:21] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Civi certificate request: Yamini - https://phabricator.wikimedia.org/T288987 (10Dwisehaupt) SSL Client certificate created. Password will be sent via SMS when it's not the middle of the night. CiviCRM account created. Welcome email sent to in... [19:08:59] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Civi certificate request: Lefki - https://phabricator.wikimedia.org/T288986 (10Dwisehaupt) [19:09:10] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, 10FR-AutoTY-Email, 10Patch-For-Review: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10DStrine) 05Open→03Resolved @MBeat33 we're going to cl... [19:09:50] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Civi certificate request: Yamini - https://phabricator.wikimedia.org/T288987 (10Dwisehaupt) [19:10:48] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, 10FR-AutoTY-Email, 10MW-1.37-notes (1.37.0-wmf.19; 2021-08-16): All non english soft descriptors should be the DR email address: donate@wikimedia.org - https://phabricator.wikimedia.org/T285499 (10DStrine)... [19:12:05] 10Fundraising Sprint Interstitial ads halfway down the coaster hill, 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, and 4 others: deprecate and or move wikitech documentation to Mediawiki - https://phabricator.wikimedia.org/T281304 (10DStrine) 05O... [19:12:07] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: epic: frtech onwiki documentation overhaul - https://phabricator.wikimedia.org/T209872 (10DStrine) [19:28:19] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, 10fundraising sprint onion pit: New Payment Method added: Money Order - https://phabricator.wikimedia.org/T283023 (10MDemosWMF) Thanks @Eileenmcnaughton Just tested, but... [19:34:17] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, 10FR-AutoTY-Email, 10Patch-For-Review: Production of new Auto Recurring Failure Email (multilingual) - https://phabricator.wikimedia.org/T285375 (10MBeat33) Thank you @DStrine we'll have some edits the end... [19:40:24] 10Fundraising-Backlog: sprint goal for sprint P - https://phabricator.wikimedia.org/T289080 (10DStrine) [19:43:44] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Legø Trampoline, and 3 others: Adyen Checkout: create new recurring iDEAL donations - https://phabricator.wikimedia.org/T284606 (10DStrine) [19:49:16] 10Fundraising-Backlog: sprint goal: dev test donation for apple pay and something for matching gifts - https://phabricator.wikimedia.org/T289080 (10DStrine) [19:51:30] 10Fundraising-Backlog, 10fr-matching-gifts, 10Epic: Perform CPR on Matching Gifts process. - https://phabricator.wikimedia.org/T273551 (10DStrine) [19:54:23] 10Fundraising-Backlog, 10fr-matching-gifts: Enable matching_gifts_sync process-control job - https://phabricator.wikimedia.org/T273553 (10DStrine) [19:59:37] 10Fundraising-Backlog, 10fr-matching-gifts: New process-control job for drush civicrm-matching-gifts-employers-check - https://phabricator.wikimedia.org/T273555 (10DStrine) [20:01:43] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fr-matching-gifts: Omit useless entries when syncing matching gifts data - https://phabricator.wikimedia.org/T264944 (10DStrine) [20:01:46] 10Fundraising-Backlog, 10fr-matching-gifts: Enable and extend process-control matching_gifts_sync job to also call civicrm-matching-gifts-employers-check - https://phabricator.wikimedia.org/T273555 (10jgleeson) [20:02:30] 10Fundraising-Backlog, 10fr-matching-gifts: Enable matching_gifts_sync process-control job - https://phabricator.wikimedia.org/T273553 (10jgleeson) 05Open→03Resolved [20:02:32] 10Fundraising-Backlog, 10fr-matching-gifts, 10Epic: Perform CPR on Matching Gifts process. - https://phabricator.wikimedia.org/T273551 (10jgleeson) [20:02:34] 10Fundraising-Backlog, 10fr-matching-gifts, 10Epic: Epic: matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (10jgleeson) [20:06:44] 10Fundraising-Backlog, 10fr-matching-gifts: Look at migrating the 'matching gifts employer data check command' over to civicrm - https://phabricator.wikimedia.org/T257498 (10DStrine) [20:15:28] 10Fundraising-Backlog, 10fr-matching-gifts: add employer drop down to all matching gifts variants - https://phabricator.wikimedia.org/T289082 (10DStrine) [20:15:56] 10Fundraising-Backlog, 10fr-matching-gifts: add employer drop down to all matching gifts variants - https://phabricator.wikimedia.org/T289082 (10DStrine) [20:23:24] 10Fundraising-Backlog, 10fr-matching-gifts: when an employer is not in HEP data or misspelled, save the string in the "employer" custom field - https://phabricator.wikimedia.org/T289083 (10DStrine) [20:30:31] 10Fundraising-Backlog: Documentation: General organization of topics and subtopics - https://phabricator.wikimedia.org/T288279 (10DStrine) [20:35:20] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, and 4 others: Time boxed adyen related code organizaiton/planning - https://phabricator.wikimedia.org/T282608 (10DStrine) [20:45:53] 10Fundraising-Backlog, 10fundraising sprint P 2021 placeholder, 10fr-matching-gifts: when an employer is not in HEP data or misspelled, save the string in the "employer" custom field - https://phabricator.wikimedia.org/T289083 (10DStrine) [20:45:55] 10Fundraising-Backlog, 10fundraising sprint P 2021 placeholder, 10fr-matching-gifts: add employer drop down to all matching gifts variants - https://phabricator.wikimedia.org/T289082 (10DStrine) [20:46:00] 10Fundraising-Backlog, 10fundraising sprint P 2021 placeholder: sprint goal: dev test donation for apple pay and something for matching gifts - https://phabricator.wikimedia.org/T289080 (10DStrine) [20:46:02] 10Fundraising-Backlog, 10fundraising sprint P 2021 placeholder: Catch Adyen Checkout API errors on the DI side - https://phabricator.wikimedia.org/T288830 (10DStrine) [20:46:04] 10Fundraising-Backlog, 10fundraising sprint P 2021 placeholder, 10fundraising sprint onion pit, 10FR-Adyen, 10Patch-For-Review: Add Apple Pay test server support to fundraising-dev - https://phabricator.wikimedia.org/T288772 (10DStrine) [20:46:06] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint P 2021 placeholder, 10fundraising sprint onion pit: Create new WMF donor fields - https://phabricator.wikimedia.org/T288721 (10DStrine) [20:46:08] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint P 2021 placeholder: adding country to fraud scan doesn't return any data (search kit) - https://phabricator.wikimedia.org/T288679 (10DStrine) [20:46:10] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint P 2021 placeholder, 10fundraising sprint onion pit: Review upstream PRs related to contracted token work - https://phabricator.wikimedia.org/T288698 (10DStrine) [20:46:12] 10Fundraising-Backlog, 10fundraising sprint P 2021 placeholder, 10fr-donorservices: Civi email address format exception request - https://phabricator.wikimedia.org/T288644 (10DStrine) [20:46:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint P 2021 placeholder, 10Recurring-Donations: Trickle of damaged recurring donation messages with contact_id but without gateway_txn_id - https://phabricator.wikimedia.org/T285396 (10DStrine) [20:46:19] 10Fundraising-Backlog, 10fundraising sprint P 2021 placeholder: Documentation: General organization of topics and subtopics - https://phabricator.wikimedia.org/T288279 (10DStrine) [20:46:21] 10Fundraising-Backlog, 10fundraising sprint P 2021 placeholder, 10fr-matching-gifts: Test out the end-to-end matching gifts file deployment process. - https://phabricator.wikimedia.org/T273558 (10DStrine) [20:46:23] 10Fundraising-Backlog, 10fundraising sprint P 2021 placeholder, 10fr-matching-gifts: Enable and extend process-control matching_gifts_sync job to also call civicrm-matching-gifts-employers-check - https://phabricator.wikimedia.org/T273555 (10DStrine) [20:46:26] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint P 2021 placeholder, 10fundraising sprint onion pit: Send Receipts not working from civi - https://phabricator.wikimedia.org/T288149 (10DStrine) [20:46:30] 10Fundraising-Backlog, 10fundraising sprint P 2021 placeholder, 10fundraising sprint onion pit, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Test Adyen Checkout via CODFW hosts - https://phabricator.wikimedia.org/T287987 (10DStrine) [20:46:31] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint P 2021 placeholder, 10fundraising sprint onion pit, 10FR-Civi-Prospect: Remove switcheroo button from activities - https://phabricator.wikimedia.org/T287644 (10DStrine) [20:46:33] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint P 2021 placeholder, 10fundraising sprint onion pit, and 2 others: Adding tax disambiguation clause to Payments Wiki in France - https://phabricator.wikimedia.org/T286880 (10DStrine) [20:46:35] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint P 2021 placeholder, and 3 others: Adyen Checkout: normalize API error codes - https://phabricator.wikimedia.org/T283307 (10DStrine) [20:46:37] 10Fundraising-Backlog, 10fundraising sprint P 2021 placeholder, 10fundraising sprint onion pit, 10FR-Adyen: Adyen Checkout: Pull donor contact from Apple Pay sheet - https://phabricator.wikimedia.org/T285722 (10DStrine) [20:46:39] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint P 2021 placeholder, 10fundraising sprint onion pit: update the docs on the civi-acoustic import and export scripts - https://phabricator.wikimedia.org/T286934 (10DStrine) [20:46:41] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, and 3 others: Modification to Fredge Report - https://phabricator.wikimedia.org/T285321 (10DStrine) [20:46:43] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint P 2021 placeholder, and 4 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10DStrine) [20:46:45] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, and 4 others: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10DStrine) [20:46:47] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint P 2021 placeholder, 10fundraising sprint onion pit: Search kit links not loading when sharing out to Engage - https://phabricator.wikimedia.org/T279686 (10DStrine) [20:46:49] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, and 2 others: New Payment Method added: Money Order - https://phabricator.wikimedia.org/T283023 (10DStrine) [20:46:51] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Corrugated super slide, 10Fundraising Sprint Downed power line jump rope, and 24 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10DStrine) [20:46:54] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, and 7 others: Handle Apple Pay submission in Adyen Components - https://phabricator.wikimedia.org/T282596 (10DStrine) [20:46:56] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 12 others: Update Fundraising tech CI image to use upstream buildkit, no symlink for civ... - https://phabricator.wikimedia.org/T277500 [20:59:35] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster: adding country to fraud scan doesn't return any data (search kit) - https://phabricator.wikimedia.org/T288679 (10Eileenmcnaughton) @DStrine I think @ejegg was right - removing the location = billi... [21:00:30] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: sprint goal: dev test donation for apple pay and get matching gifts to internal test - https://phabricator.wikimedia.org/T289080 (10DStrine) [21:02:48] ejegg: you got one more second? I don't understand what you were saying and what eileen commented on the search kit task. do you have a second to hop back on that call? [21:02:53] https://phabricator.wikimedia.org/T288679 [21:03:31] i'm back on dstrine [21:05:08] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster: adding country to fraud scan doesn't return any data (search kit) - https://phabricator.wikimedia.org/T288679 (10DStrine) 05Open→03Resolved [21:06:12] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: when an employer is not in HEP data or misspelled, save the string in the "employer" custom field - https://phabricator.wikimedia.org/T289083 (10DStrine) p:05Triage→03Medium [21:06:20] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: add employer drop down to all matching gifts variants - https://phabricator.wikimedia.org/T289082 (10DStrine) p:05Triage→03Medium [21:06:29] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: sprint goal: dev test donation for apple pay and get matching gifts to internal test - https://phabricator.wikimedia.org/T289080 (10DStrine) p:05Triage→03High [21:06:41] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: Catch Adyen Checkout API errors on the DI side - https://phabricator.wikimedia.org/T288830 (10DStrine) p:05Triage→03Medium [21:06:51] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint onion pit, 10FR-Adyen, 10Patch-For-Review: Add Apple Pay test server support to fundraising-dev - https://phabricator.wikimedia.org/T288772 (10DStrine) p:05Triage→03High [21:06:56] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint onion pit: Create new WMF donor fields - https://phabricator.wikimedia.org/T288721 (10DStrine) p:05Triage→03Medium [21:07:06] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint onion pit: Review upstream PRs related to contracted token work - https://phabricator.wikimedia.org/T288698 (10DStrine) p:05Triage→03Medium [21:07:21] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-donorservices: Civi email address format exception request - https://phabricator.wikimedia.org/T288644 (10DStrine) p:05Triage→03Low [21:07:29] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: Documentation: General organization of topics and subtopics - https://phabricator.wikimedia.org/T288279 (10DStrine) p:05Triage→03Medium [21:07:42] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10Recurring-Donations: Trickle of damaged recurring donation messages with contact_id but without gateway_txn_id - https://phabricator.wikimedia.org/T285396 (10DStrine) p:05Triage→03Medium [21:07:49] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: Test out the end-to-end matching gifts file deployment process. - https://phabricator.wikimedia.org/T273558 (10DStrine) p:05Triage→03Medium [21:07:58] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: Enable and extend process-control matching_gifts_sync job to also call civicrm-matching-gifts-employers-check - https://phabricator.wikimedia.org/T273555 (10DStrine) p:05Triage→03Medium [21:08:07] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: Omit useless entries when syncing matching gifts data - https://phabricator.wikimedia.org/T264944 (10DStrine) p:05Triage→03Medium [21:08:14] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: Add process-control job to run the drush civicrm-matching-gifts-employers-check command - https://phabricator.wikimedia.org/T260726 (10DStrine) p:05Triage→03Medium [21:32:14] oh boy, codename 'bookworm' packages starting to arrive in debian experimental [21:33:15] wonder when i'll get php 8 [21:41:01] (03PS1) 10Jgleeson: WIP Adyen Checkout: Applepay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713551 (https://phabricator.wikimedia.org/T282596) [21:42:28] AndyRussG: I just added in the *hacks* needed to get the Apple pay DI patch loading with the WIP patches. If you get a chance try that out and lemme know if it fixes it for you. Sorry I haven't had a chance to test it myself (mac not out) as I'm jumping off now cause it's late but hopefully that'll do it! I'll test it out myself tomorrow [21:44:17] (03CR) 10jerkins-bot: [V: 04-1] WIP Adyen Checkout: Applepay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713551 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [21:50:18] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: when an employer is not in HEP data or misspelled, save the string in the "employer" custom field - https://phabricator.wikimedia.org/T289083 (10Ejegg) confirmed using variant=employer that non-matched employ... [22:03:21] 10Fundraising-Backlog: Formatting of Acoustic contact field "Last Native Amount" with decimal point alters how the amount populates in Donatewiki - https://phabricator.wikimedia.org/T289091 (10nisrael) [22:07:58] (03Abandoned) 10Ejegg: DO NOT MERGE: Check to see if CI is testing current patch [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/709865 (owner: 10Ejegg) [22:08:07] (03Abandoned) 10Eileen: Save new paymethod type on edit of payment [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/642148 (https://phabricator.wikimedia.org/T266617) (owner: 10Mepps) [22:08:36] (03Abandoned) 10Ejegg: DO NOT MERGE: Test CI branchery [extensions/DonationInterface] (adyen) - 10https://gerrit.wikimedia.org/r/709849 (owner: 10Ejegg) [22:08:52] (03Abandoned) 10Eileen: Add additional fields for totals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/709628 (https://phabricator.wikimedia.org/T280595) (owner: 10Eileen) [22:09:37] (03CR) 10Cstone: [C: 03+2] "Sorry about this!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710345 (owner: 10Ejegg) [22:12:35] (03Merged) 10jenkins-bot: Remove Adyen test adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/710345 (owner: 10Ejegg) [22:16:13] (03PS2) 10Ejegg: Fix a couple of undefined var errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/676472 [22:16:15] (03PS4) 10Ejegg: Get rid of card_type [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/676473 [22:18:31] (03Abandoned) 10Cstone: Do Not Merge: Testing CI [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708575 (owner: 10Cstone) [22:18:45] (03Abandoned) 10Cstone: Update field lengths and types. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/556079 (owner: 10Cstone) [22:22:33] (03PS4) 10Ejegg: Eliminate a couple redundant if conditions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/676475 [22:23:00] (03Abandoned) 10Ejegg: DO NOT MERGE Logging for wmf_install functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/645204 (owner: 10Ejegg) [22:23:30] (03PS3) 10Ejegg: Remove unused parameters from txn building fns [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/584062 [22:26:35] (03CR) 10Ejegg: Robust-ify needsTokenizing logic (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/448832 (https://phabricator.wikimedia.org/T195337) (owner: 10Ejegg) [22:28:09] (03PS2) 10Ejegg: Robust-ify needsTokenizing logic [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/448832 (https://phabricator.wikimedia.org/T195337) [22:28:59] (03CR) 10jerkins-bot: [V: 04-1] Robust-ify needsTokenizing logic [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/448832 (https://phabricator.wikimedia.org/T195337) (owner: 10Ejegg) [23:58:00] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-donorservices: Civi email address format exception request - https://phabricator.wikimedia.org/T288644 (10Eileenmcnaughton) a:03Eileenmcnaughton I have a fix - just waiting for upstream feedback https://lab.civicrm.org/dev... [23:58:38] (03PS1) 10Eileen: Do not call getLanguage if not available [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713562 (https://phabricator.wikimedia.org/T285321) [23:59:42] ejegg are you able to merge https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/713562 - I just need a bit of help to get jenkins to NOT call that code on the upgraded version of civi [23:59:49] (since it fatals) [23:59:58] & I want to get past that to the actual issues