[00:04:15] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 11 others: Fix civicrm repo to be non-symlinked - https://phabricator.wikimedia.org/T289100 (10Eileenmcnaughton) [00:04:39] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 11 others: Fix civicrm repo to be non-symlinked - https://phabricator.wikimedia.org/T289100 (10Eileenmcnaughton) p:05Triage→03H... [00:08:47] welp that's one way for doggie to get his bath ;p [00:09:51] (03CR) 10jerkins-bot: [V: 04-1] Do not call getLanguage if not available [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713562 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [00:09:53] (03PS1) 10Ejegg: Use dropdown/autocomplete for all employer variants [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713563 (https://phabricator.wikimedia.org/T289082) [00:10:17] oops eileen just saw your message [00:10:30] yeah it failed tho - not sure why [00:11:19] ah method_exists might not work with magics [00:11:49] aha, right, i guess it wouldn't [00:11:58] well that's annoying [00:12:04] maybe is_callable will work tho [00:12:38] ooh: If the target class has __call() magic function implemented, then is_callable will ALWAYS return TRUE for whatever method you call it [00:16:22] lol there's a convenient ->reflect() method on AbstractAction to check for a 'language' property [00:18:32] ejegg: yeah - I could also just check civi version since it's temporay I guess [00:20:45] oh sure [00:21:03] civi version would be speedier [00:21:03] actually - it IS returning false for me on the later version [00:21:42] so method_exists would return false in any version, right? [00:22:05] (03PS2) 10Eileen: Do not call getLanguage if not available [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713562 (https://phabricator.wikimedia.org/T285321) [00:22:09] yeah [00:22:21] and the tests are failing because we are skipping the translation on some API calls that actually DO have a language property [00:22:50] so the ones against current master - yes [00:23:07] oh you're saying is_callable returns false for the places it should return false on the new version? Cool! [00:23:26] yeah - I don't know that is the last problem - just enough to move the fails along a bit [00:24:57] - it's still failing pretty heavily but now I don't know if that's db state after switching around :-) [00:25:17] eileen: i don't think you need that get_class around $apiRequest in PS2 - [$object, 'methodName'] should be callable too [00:26:34] and given php's blobbiness, might actually return different results on a late-created property and a magic method [00:27:42] so I'd say let's just put the Civi version check in there [00:27:53] and not add an extra bit of reflection to each API call [00:29:38] ok - I'll try that [00:31:00] gonna get some dinner [00:31:40] (03PS3) 10Eileen: Do not call getLanguage if not available [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713562 (https://phabricator.wikimedia.org/T285321) [00:37:15] More info on the proliferation of Japanese surnames: https://www.japantimes.co.jp/life/2009/10/11/general/the-long-road-to-identity/ [00:42:35] (03CR) 10jerkins-bot: [V: 04-1] Do not call getLanguage if not available [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713562 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [00:48:49] (03PS4) 10Eileen: Do not call getLanguage if not available [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713562 (https://phabricator.wikimedia.org/T285321) [01:00:09] ejegg|food: ok THAT did it ^^ [01:03:04] (03PS5) 10Ejegg: Do not call getLanguage if not available [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713562 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [01:03:13] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713562 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [01:13:43] (03Merged) 10jenkins-bot: Do not call getLanguage if not available [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713562 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [01:56:25] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/713378 (owner: 10Eileen) [05:44:39] (03PS1) 10Eileen: Update where join fields in apiv4 call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713573 (https://phabricator.wikimedia.org/T285321) [08:44:45] (03CR) 10Thiemo Kreuz (WMDE): Fix a couple of undefined var errors (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/676472 (owner: 10Ejegg) [14:09:16] damilare: wanna jump on our call and finish this code review? [14:09:35] we're close to the end! :) [14:17:49] I'll go ahead and +2 it now damilare as I have to head out shortly to run an errand but we can jump back on a call when I get back if you like I can show you the other variants working as expected! back later! [14:18:59] (03CR) 10Jgleeson: [C: 03+2] "Both I and Dami looked over this change and tested it locally and it worked as expected. Nice work!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713563 (https://phabricator.wikimedia.org/T289082) (owner: 10Ejegg) [14:21:38] (03Merged) 10jenkins-bot: Use dropdown/autocomplete for all employer variants [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713563 (https://phabricator.wikimedia.org/T289082) (owner: 10Ejegg) [14:56:39] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: ☂ Membership in Givarguiden - https://phabricator.wikimedia.org/T230907 (10Jopparn) [15:41:18] 10Fundraising-Backlog, 10fr-matching-gifts: Update 'matching gifts employer data file' drupal setting to correct path - https://phabricator.wikimedia.org/T273556 (10Ejegg) Looks like this is a fine location and does not need updating - the path exists on the civi box and the drush user is able to write to the... [15:45:19] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: Test out the end-to-end matching gifts file deployment process. - https://phabricator.wikimedia.org/T273558 (10Ejegg) I created a small script to copy the file from civi to frpm, add it to the settings repo,... [15:46:20] !log updated matching gift employers list on payments-wiki [15:46:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:53:53] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Civi TY email shows two different dates for same contrib - https://phabricator.wikimedia.org/T289165 (10MBeat33) [15:54:55] 10Fundraising-Backlog, 10FR-Adyen, 10Epic: Add ability to accept JSON notifications - https://phabricator.wikimedia.org/T289166 (10Cstone) [15:56:16] that script will come in handy ejegg [15:56:19] thanks for that [15:56:28] yw! [15:56:39] i thought about adding more checks [15:56:49] but it turns out the && logic works fine [15:57:06] so when there are no changes to the file, the git commit step exits with a non-zero error code [15:58:40] oh nice [15:59:33] fr-tech I'll be a few mins late to standup. I've had tree surgeons here today cutting down dead trees in my garden and they are just finishing up so I'm gonna lock the gate. brb [16:23:56] 10Fundraising-Backlog: Non-English descriptor change to English standard - https://phabricator.wikimedia.org/T289171 (10EMartin) [16:31:26] 10Fundraising-Backlog: Non-English descriptor change to English standard - https://phabricator.wikimedia.org/T289171 (10DStrine) Hey @EMartin this is the task we just used to update soft descriptors: https://phabricator.wikimedia.org/T285499 The short list of countries at the top had the donate@ email address.... [16:35:08] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations: Recurring queue consumer fails with funny stats execption - https://phabricator.wikimedia.org/T289175 (10Ejegg) [16:35:52] jgleeson: can you think of a way to make that stats call safer? Seems like a stats collector should not cause the actual queue consumption to fail even when stats collection is impossible [16:39:03] hmm, so most recent failure is on a non-USD recurring subscr_start message right after a USD recurring subscr_start message went through fine [16:40:08] subscr_signup that is [16:40:15] maybe ejegg. i can't really explain why it's losing the starting value for the timer as the behaviour which works out the actual diff checks to see if the start key is set before attempting any arithmetic [16:40:48] lemme take another look at that code [16:41:31] we could just get rid of the timers also. [16:45:20] so here's the recent change involving timer logic: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/704214 [16:48:22] oho, maybe replication depends on the contact being matched on name + address? [16:48:46] email address that is [16:51:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations: Recurring queue consumer fails with funny stats execption - https://phabricator.wikimedia.org/T289175 (10Ejegg) [16:59:15] 10Fundraising-Backlog: Non-English descriptor change to English standard - https://phabricator.wikimedia.org/T289171 (10EMartin) Yes, where we have had any AMEX transactions at all in those markets, the rejects occurred in the markets where we implemented this in the last 30 days: Last 30 day AMEX declines + %... [18:14:11] doing some mariadb updates in codfw. just fyi [18:35:23] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: Non-English descriptor change to English standard - https://phabricator.wikimedia.org/T289171 (10DStrine) p:05Triage→03High [18:39:09] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: Non-English descriptor change back to 877 number string - https://phabricator.wikimedia.org/T289171 (10DStrine) [18:47:23] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: Non-English descriptor change back to 877 number string - https://phabricator.wikimedia.org/T289171 (10Ejegg) @AndyRussG points out that toll free numbers can't be used outside the US. Would this URL be acceptable? https://w.wiki/3... [18:58:44] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: Non-English descriptor change back to 877 number string - https://phabricator.wikimedia.org/T289171 (10Ejegg) I see some charges on my card statement with slashes in the descriptor, but nothing with colon. would this be too confu... [19:02:34] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: Non-English descriptor change back to 877 number string - https://phabricator.wikimedia.org/T289171 (10DStrine) I'm in a call with Evelyn. We're asking for the 877 number again. But this idea is much appreciated! [19:23:26] (03PS1) 10Jgleeson: Update stats-collector to 1.4.11 to better handle startTimer bug. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713686 (https://phabricator.wikimedia.org/T289175) [19:36:45] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: Non-English descriptor change back to 877 number string - https://phabricator.wikimedia.org/T289171 (10AndyRussG) >>! In T289171#7292781, @DStrine wrote: > I'm in a call with Evelyn. We're asking for the 877 number again. But this... [20:05:42] (03PS2) 10Jgleeson: Update stats-collector to 1.4.11 to better handle startTimer bug. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713686 (https://phabricator.wikimedia.org/T289175) [20:10:11] (03PS1) 10Jgleeson: Update stats-collector [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/713695 [20:11:28] (03PS1) 10Jgleeson: Update stats-collector to 1.4.11 to better handle startTimer bug. [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/713696 (https://phabricator.wikimedia.org/T289175) [20:14:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10Patch-For-Review: Recurring queue consumer fails with funny stats execption - https://phabricator.wikimedia.org/T289175 (10Ejegg) Seems like it might be happening specifically when the recurring queue consumer updates an exist... [20:19:26] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: Test out the end-to-end matching gifts file deployment process. - https://phabricator.wikimedia.org/T273558 (10Ejegg) On frpm you can now pull down this script from the local scripts repo in /var/lib/git. g... [20:19:37] eileen: are you about? I just pushed up a composer package to civicrm to pull in a new version of the stats-collector to help with the recurring failmail. I haven't deployed civicrm for a while, could you confirm the deployment patches above look ok pls? [20:20:13] jgleeson: lookin [20:20:43] thanks much! [20:21:00] so it's merged to vendor & this just updates the lock file & vendor submodule? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/713696 [20:21:43] the vendor patch isn't merged yet, that's here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/vendor/+/713695/ [20:21:49] but once merged, yep [20:26:07] jgleeson: ok so I think the process is that the lock file update is merged to master first (& that one gets reviewed ) & then the vendor update doesn't require someone else to review & the deployment update is a merge commit with the vendor bit merged into it (which you can also self-merge) [20:26:43] I guess the vendor bit is amended into it, not merged into it [20:28:15] ah ok I did push the master update first [20:28:17] I'll find it [20:28:26] I then cherry picked that change from master [20:28:38] as there was some other stuff I didn't wanna add [20:28:40] lemme get that [20:28:54] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/713686/ [20:29:04] that's the update to master eileen ^ [20:29:14] so if that gets merged, the other stuff should be ok i think [20:29:32] (ok to merge and deploy) [20:30:31] (03CR) 10Eileen: [C: 03+2] Update stats-collector to 1.4.11 to better handle startTimer bug. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713686 (https://phabricator.wikimedia.org/T289175) (owner: 10Jgleeson) [20:30:55] (03CR) 10Eileen: [C: 03+2] "This really is just this commit https://github.com/jackgleeson/stats-collector/commit/29a4b4942df2f300133804b9e1f0b787c129a9b3 - so seems " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713686 (https://phabricator.wikimedia.org/T289175) (owner: 10Jgleeson) [20:31:01] thank you!! [20:31:21] jgleeson: so how does the psalm checking work in that repo? [20:31:40] errr it shouldn't just be that commit [20:31:40] does travis provide it? [20:32:28] the previous commit was https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/713686/2/composer.lock#b1704 which looks like only 1 commit ago [20:33:38] eileen: this is the comit https://github.com/jackgleeson/stats-collector/commit/5d6e1a8b58bea5c06e63841a7187cb961272a9f2 [20:34:32] that 1.4.11 pulls in [20:35:13] jgleeson: hmm but the lock file update is for much less difference [20:36:44] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: Non-English descriptor change back to 877 number string - https://phabricator.wikimedia.org/T289171 (10DStrine) yup this is a known issue with this string. But it's better to go back to this known issue than introduce more possible... [20:36:47] eileen: this one ? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/713686/2/composer.lock#1704 [20:37:03] yeah - I'm seeing something different now - argh [20:37:41] ah ok there might be some weirdness due to me originally tagging the wrong branch, deleting the tag and then retagging the file branch [20:37:57] the first branch I mistakenly tagged did have a bunch of psalm stuff [20:38:17] although I thought I'd fixed that and cleared out the github/packagist cache [20:38:29] jgleeson: ok - well the intended change seems sensible & safe too :-) [20:38:38] :) [20:39:48] jgleeson: so that change that is merged to master that would go out is fine to go out [20:40:13] I might yet re-work it but it is fine for now [20:41:26] thanks. just waiting for jenkins to do it's thing [20:41:32] then I can push it out before I head off [20:41:44] (03Merged) 10jenkins-bot: Update stats-collector to 1.4.11 to better handle startTimer bug. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713686 (https://phabricator.wikimedia.org/T289175) (owner: 10Jgleeson) [20:41:45] hopefully that should give us more info on the recurring failmails [20:42:00] (03CR) 10Jgleeson: [C: 03+2] Update stats-collector to 1.4.11 to better handle startTimer bug. [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/713696 (https://phabricator.wikimedia.org/T289175) (owner: 10Jgleeson) [20:42:50] eileen: the recurring failmail were seeing seems to be related to the endTimer call on the stats-collector. It only started happening this week I think [20:43:07] ejegg: added a ticket for it here https://phabricator.wikimedia.org/T289175 [20:43:40] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7017 7000 - REDIS 5.0.3 on 127.0.0.1:6379 has 1 databases (db0) with 13 keys, up 86 days 7 hours - memory use is 11.83M (peak 14.10M, 0.21% of max, fragmentation 1.44%), connected_slaves is 3, donations is 1292, jobs is 0, jobs-adyen is 2, jobs-paypal is 202, payments-antifraud is 759, payments-init is 7, pending is 34, refund is 0, unsubscribe is 132 [20:44:28] (03CR) 10Jgleeson: [C: 03+2] Update stats-collector [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/713695 (owner: 10Jgleeson) [20:44:38] jgleeson: ok - we DID merge a change that is likely to relate [20:44:50] that change to use the WMFContact::save [20:45:08] & my first cut of that had to be fixed for stats collector [20:45:16] so, it's probably the culprit [20:46:26] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/703267 [20:46:59] hmm - that is less obviously related than I thought it might be [20:48:31] eileen: it's possible something has changed but so far it's not clear how or why [20:48:36] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7140 7000 - REDIS 5.0.3 on 127.0.0.1:6379 has 1 databases (db0) with 13 keys, up 86 days 7 hours - memory use is 13.02M (peak 14.10M, 0.20% of max, fragmentation 1.31%), connected_slaves is 3, donations is 1023, jobs is 0, jobs-adyen is 3, jobs-paypal is 174, payments-antifraud is 717, payments-init is 370, pending is 47, refund is 0, unsubscribe is 143 [20:49:02] (03CR) 10Jgleeson: [C: 03+2] "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/713696 (https://phabricator.wikimedia.org/T289175) (owner: 10Jgleeson) [20:49:14] jgleeson: yeah - I know I had some trickiness getting that class to play nice but - well we'll see [20:50:06] If anyone can +2 this - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/713573 - it would completely fail tests if it didn't work (since I picked it up through tests) [20:53:36] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7257 7000 - REDIS 5.0.3 on 127.0.0.1:6379 has 1 databases (db0) with 13 keys, up 86 days 7 hours - memory use is 12.45M (peak 14.10M, 0.21% of max, fragmentation 1.37%), connected_slaves is 3, donations is 1332, jobs is 0, jobs-adyen is 1, jobs-paypal is 201, payments-antifraud is 848, payments-init is 2, pending is 37, refund is 0, unsubscribe is 160 [20:53:51] (03CR) 10Jgleeson: [C: 03+2] Update where join fields in apiv4 call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713573 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [20:54:00] thanks jgleeson [20:54:05] eileen: I don't trust CI. I just you though [20:54:09] trust* [20:54:10] lol [20:54:51] ok those patches are merged and ready to go. just gonna say good night to the kids then push em out! [20:55:29] (03Merged) 10jenkins-bot: Update stats-collector [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/713695 (owner: 10Jgleeson) [20:55:43] lol [20:58:40] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7385 7000 - REDIS 5.0.3 on 127.0.0.1:6379 has 1 databases (db0) with 13 keys, up 86 days 7 hours - memory use is 12.40M (peak 14.53M, 0.20% of max, fragmentation 1.31%), connected_slaves is 3, donations is 1235, jobs is 0, jobs-adyen is 5, jobs-paypal is 193, payments-antifraud is 516, payments-init is 361, pending is 51, refund is 0, unsubscribe is 174 [21:03:21] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: Non-English descriptor change back to 877 number string - https://phabricator.wikimedia.org/T289171 (10AndyRussG) >>! In T289171#7293087, @DStrine wrote: > yup this is a known issue with this string. But it's better to go back to t... [21:03:40] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7498 7000 - REDIS 5.0.3 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 86 days 7 hours - memory use is 13.31M (peak 15.07M, 0.22% of max, fragmentation 1.31%), connected_slaves is 3, donations is 1305, jobs is 0, jobs-adyen is 2, jobs-paypal is 191, payments-antifraud is 1217, payments-init is 873, pending is 37, refund is 0, unsubscribe is 7 [21:05:37] (03Merged) 10jenkins-bot: Update where join fields in apiv4 call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713573 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [21:08:40] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7600 7000 - REDIS 5.0.3 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 86 days 7 hours - memory use is 9.77M (peak 15.07M, 0.18% of max, fragmentation 1.49%), connected_slaves is 3, donations is 52, jobs is 0, jobs-adyen is 0, jobs-paypal is 34, payments-antifraud is 2, payments-init is 130, pending is 3, refund is 0, unsubscribe is 25 [21:09:50] ACKNOWLEDGEMENT - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7600 7000 - REDIS 5.0.3 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 86 days 7 hours - memory use is 9.77M (peak 15.07M, 0.18% of max, fragmentation 1.49%), connected_slaves is 3, donations is 52, jobs is 0, jobs-adyen is 0, jobs-paypal is 34, payments-antifraud is 2, payments-init is 130, pending is 3, refund is 0, unsubscribe is 25 Dwisehaupt k [21:09:50] being tracked. [21:13:26] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/713378 (owner: 10Eileen) [21:15:14] !log civicrm changed from 66568246a2 to 73f6ec9190 [21:15:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:34:21] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10Patch-For-Review: Recurring queue consumer fails with funny stats execption - https://phabricator.wikimedia.org/T289175 (10Ejegg) OK, so the start value is ending up as an array, which is a hard thing to subtract from an integ... [22:52:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10Patch-For-Review: Recurring queue consumer fails with funny stats execption - https://phabricator.wikimedia.org/T289175 (10Ejegg) OK, so the reason this fails for multiple recurring signups and not for multiple payments that u... [23:20:19] (03PS1) 10Ejegg: Reset unique stats token on each message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/713714 (https://phabricator.wikimedia.org/T289175) [23:21:00] AndyRussG / cstone ^^^ might be enough of a band-aid to keep the recurring QC running at full speed [23:21:19] will test locally after dinner [23:57:23] ejegg: not sure what to test but my queues locally are running fine with that change [23:58:05] cstone cool! The instructions for reproducting the error are in https://phabricator.wikimedia.org/T289175#7293508 [23:58:16] so let me try that again with the fix [23:58:48] ah okay thanks