[05:13:49] (03CR) 10AndyRussG: "Cooooool! Looking good!!!! (Just a some drive-by nit-picks and idle questions inline...)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713551 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [05:17:00] (03CR) 10AndyRussG: "Woohooo!! Again here, just a tiny, unimportant nit-pick inline..." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/714876 (https://phabricator.wikimedia.org/T282596) (owner: 10Ejegg) [05:48:18] (03CR) 10AndyRussG: Apple Pay Payment Provider (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702149 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [05:56:58] (03CR) 10AndyRussG: "Wooohooo, this is working, eh!!!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715135 (https://phabricator.wikimedia.org/T285722) (owner: 10Ejegg) [06:23:15] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715397 (owner: 10L10n-bot) [06:30:13] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715397 (owner: 10L10n-bot) [13:30:01] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 4 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10KHaggard) Thanks @Eileenmcnaughton... [13:32:32] 10fundraising-tech-ops: staging-server changes for payments1008 - https://phabricator.wikimedia.org/T289869 (10Jgreen) [15:47:08] hi fr-tech! [15:53:54] (03PS1) 10Ejegg: Use Apple-branded 'donate' button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715545 [15:58:56] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 4 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10KHaggard) Ok, so I checked out some... [16:05:33] (03PS8) 10Ejegg: Adyen Checkout: Apple Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713551 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [16:06:02] (03CR) 10Ejegg: "Thanks for the CR AndyRussG! PS8 updates that label, answers to the other Qs inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713551 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [16:07:12] (03CR) 10Ejegg: Apple Pay: correctly format amount for all currencies (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/714876 (https://phabricator.wikimedia.org/T282596) (owner: 10Ejegg) [16:13:40] (03CR) 10Ejegg: "Thanks for the CR! Yeah, that tune method probably isn't the place for it." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715135 (https://phabricator.wikimedia.org/T285722) (owner: 10Ejegg) [16:27:15] (03PS1) 10Ejegg: Rename CurrencyRoundingHelper properties [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/715554 [16:27:54] (03CR) 10jerkins-bot: [V: 04-1] Rename CurrencyRoundingHelper properties [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/715554 (owner: 10Ejegg) [16:28:45] (03PS2) 10Ejegg: Rename CurrencyRoundingHelper properties [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/715554 [16:31:26] (03PS3) 10Ejegg: Apple Pay: correctly format amount for all currencies [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/714876 (https://phabricator.wikimedia.org/T282596) [16:58:18] hrm, docker logs complaining of an unsupported php version (7.2) [16:58:23] I thought docker had 7.3? [16:59:22] ohhhh [17:00:11] i ran docker-composer up in a subdir of src/payments [17:00:18] and it picked up the wrong project [17:02:50] durn, running the right project now and still not able to serve apple-payments-wiki [17:02:57] An error occurred during a connection to localhost:9443. PR_END_OF_FILE_ERROR [17:03:16] so it's not the forwarding via jackgleeson.co.uk [17:03:20] it's something local [17:03:24] let's see the logs [17:05:17] hmm apache-error has the same warnings as last thurs when it was all working [17:06:22] nuthin from today in syslog , apache-access, or mediawiki logs [17:14:21] well, might as well rebuild [17:20:07] so my localhost:9001 still works [17:20:17] might as well just forward to that port [17:21:26] well, the cert is even less official, but Safari lets me get past that [17:21:29] woot [17:21:39] at least some things are easier for developers in macland [18:09:55] ejegg|food: maybe that error happens when you try an http connection over https? [18:10:15] or rather the revers, when the server is talking https and the browser tries to speak http? [18:10:35] also hi ejegg fr-tech :) [18:45:55] AndyRussG: the ports line in docker-compose.yaml was forwarding the 9443 port to 443, and 443 was listening on https last thursday [18:46:07] anyway, on 9001 it's good enough to keep testing [18:46:19] now i'm just confusing myself about how to use javascript promises [18:54:41] it seems most natural to use the 'deferred' style since I need to have a couple of promises to depend out way outside of where I want to resolve them [18:55:11] but i'm seeing arguments that 'deferred' is an antipattern [18:55:48] ok, so error handling is busted in 'deferred' [19:15:10] (03PS3) 10Ejegg: WIP get contact info from Apple Pay sheet [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715135 (https://phabricator.wikimedia.org/T285722) [19:15:33] so ^^^ seems to work, but it feels awful weird to wrap that much stuff in the promise constructors [19:15:53] ... and we're not really doing any error handling anyway [19:18:20] (03CR) 10jerkins-bot: [V: 04-1] WIP get contact info from Apple Pay sheet [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715135 (https://phabricator.wikimedia.org/T285722) (owner: 10Ejegg) [19:19:15] yeah, jenkins doesn't like it either [19:19:41] thpthptht: error Promise is not supported in IE 11 [19:20:19] sorry jenkins we don't care about IE 11 [19:31:44] ejegg: right but maybe you put a https URL in the browser bar? [19:32:15] AndyRussG: yep, that was with a https URL. Anyway, I did a full rebuild and now 9443 works too [19:32:41] I had 9001 working after the first payments setup step, then the overrides happen at the end [19:33:35] (03CR) 10Ejegg: "Thanks for this! Just one suggestion about when to apply the overrides" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T288772) (owner: 10Jgleeson) [19:46:06] ejegg: hmmmm also to note that the applepay fr-dev setup as currently in Gerrit does not follow the ephemerals-containers practice [19:46:27] so after you do docker-compose down you'll have to redo the applepay setup setps in setup.sh [19:47:00] 10Fundraising-Backlog: Automatically send status 800 on prior donors stopped at 600 - https://phabricator.wikimedia.org/T276183 (10DStrine) [19:52:38] 10fundraising-tech-ops: Fundraising access request for Damilare Adedoyin - https://phabricator.wikimedia.org/T286956 (10Dwisehaupt) [20:00:17] 10Fundraising-Backlog: Automatically send status 800 on prior donors stopped at 600 - https://phabricator.wikimedia.org/T276183 (10Ejegg) So this looks like something we would do in the orphan rectifier. We currently delete pending rows (so the rectifier doesn't have to process them) when a payment is rejected.... [20:06:10] 10Fundraising-Backlog, 10FR-Adyen: Adyen Real Time Account Updater - https://phabricator.wikimedia.org/T282611 (10DStrine) For the record. Fr-tech and @EMartin talked about this and it does not need any work from us. As I write this we are about to release the new Adyen credit cards. We're going to get those... [20:21:42] 10fundraising-tech-ops: staging-server changes for payments1008 - https://phabricator.wikimedia.org/T289869 (10Jgreen) [20:22:12] 10fundraising-tech-ops: staging-server changes for payments1008 - https://phabricator.wikimedia.org/T289869 (10Jgreen) [20:40:40] ejegg as mentioned earlier the test donation worked on the link to the Adyen checkout page you sent [20:41:52] Although I noticed that I was redirected to the ingenico page when I started from donate.wiki and the payment failed there [20:43:52] bug report: https://imgur.com/a/vJRmA86 [20:44:20] oh interesting damilare, I'll take a look in the logs to see why it would have failed [20:44:42] good to hear about the successful adyen payment tho! [20:48:40] :) looks like a blocker [20:55:17] hmm - looks like we should get the contact layout editor update out - I get red notices on cid 714835 - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/714835 [21:07:26] ejegg: are you ok +2ing ^^ [21:08:21] looking eileen [21:08:49] oh hey, there's a good number of updates there [21:09:20] ejegg: in that extension - or the other ones? [21:09:30] in your gerrit stream [21:09:40] yeah, i just noticed the other patches [21:09:47] ejegg: yeah - the others are kinda optional / housekeeping [21:09:59] but this one will put red noise on the screen [21:10:15] (Ihaven't looked but I'd be surprised if no-one has added a phab for it) [21:13:20] ok, looks fine to me locally [21:13:48] oh, i get a
after the layout name on the contact main screen but I think the last version did that too [21:17:17] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 4 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10Eileenmcnaughton) @KHaggard I took... [21:17:47] ejegg: is that a bug or a feature? [21:19:21] heh [21:19:46] ok, just trying to test the new group limits on the layout editor [21:21:20] (03PS2) 10Ejegg: Update contactlayouteditor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714835 (https://phabricator.wikimedia.org/T289696) (owner: 10Eileen) [21:21:30] (03CR) 10Ejegg: [C: 03+2] Update contactlayouteditor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714835 (https://phabricator.wikimedia.org/T289696) (owner: 10Eileen) [21:32:48] (03Merged) 10jenkins-bot: Update contactlayouteditor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714835 (https://phabricator.wikimedia.org/T289696) (owner: 10Eileen) [21:36:14] (03PS1) 10Eileen: Add sql update to remove end dates where they shouldn't be there [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715602 (https://phabricator.wikimedia.org/T283798) [21:39:41] looks like we have end dates from years back on some ongoing recurrings ^^ data fix for review [21:41:01] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/715606 [21:41:15] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/715606 (owner: 10Eileen) [21:48:20] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 4 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10KHaggard) Thanks @Eileenmcnaughton... [21:56:25] !log civicrm revision changed from 13bf3a02df to e89504652a, config revision is cb0a008cad [21:56:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:03:45] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10Patch-For-Review: Error message on Civi records - https://phabricator.wikimedia.org/T289696 (10Eileenmcnaughton) This should be fixed now [22:04:31] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint onion pit, 10FR-Civi-Prospect: Remove switcheroo button from activities - https://phabricator.wikimedia.org/T287644 (10Eileenmcnaughton) @NNichols switcheroo should be gon... [22:05:48] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint onion pit: Send Receipts not working from civi - https://phabricator.wikimedia.org/T288149 (10Eileenmcnaughton) a:05Eileenmcnaughton→03None @NNichols see ^^ [22:06:16] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint onion pit: Search kit links not loading when sharing out to Engage - https://phabricator.wikimedia.org/T279686 (10Eileenmcnaughton) a:03Eileenmcnaughton [22:13:55] (03PS4) 10Ejegg: WIP get contact info from Apple Pay sheet [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715135 (https://phabricator.wikimedia.org/T285722) [22:17:31] (03CR) 10jerkins-bot: [V: 04-1] WIP get contact info from Apple Pay sheet [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715135 (https://phabricator.wikimedia.org/T285722) (owner: 10Ejegg) [22:18:36] (03PS5) 10Ejegg: WIP get contact info from Apple Pay sheet [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715135 (https://phabricator.wikimedia.org/T285722) [22:46:37] (03PS1) 10Eileen: Further update on contact layout editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715618 (https://phabricator.wikimedia.org/T289696) [22:46:58] ejegg|afk: seems there was one more in contact layout editor ^ [23:38:52] (03PS1) 10Eileen: Fix OR to have parentheses [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/715628 (https://phabricator.wikimedia.org/T283798) [23:39:34] Can someone +2 that one I just pushed up - it's a fairly obvious +2 in my books but I'll need to regenerate some stuff...