[00:23:13] (03CR) 10Eileen: "ejegg - I've fixed the join. I *think* the join you questioned is right - but it was a long time ago so haven't quite gotten my head back" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703637 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [00:28:16] (03CR) 10Eileen: Update fredge report to show additional information where civicrm reached (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703637 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [00:59:27] AndyRussG: any chance you could check https://gerrit.wikimedia.org/r/715628 [01:49:41] eileen: yes for sure [01:51:30] (03CR) 10AndyRussG: [C: 03+2] "(to parenthesize OR not to parenthesize) AND..." [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/715628 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [01:51:42] :-) [01:52:41] (03Merged) 10jenkins-bot: Fix OR to have parentheses [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/715628 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [02:02:57] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/715642 [02:03:10] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/715642 (owner: 10Eileen) [02:04:32] !log tools revision changed from 14e4125f73 to 1d67c52c12 [02:04:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:13:37] (03CR) 10Ejegg: [C: 03+2] Further update on contact layout editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715618 (https://phabricator.wikimedia.org/T289696) (owner: 10Eileen) [03:24:13] (03Merged) 10jenkins-bot: Further update on contact layout editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715618 (https://phabricator.wikimedia.org/T289696) (owner: 10Eileen) [03:36:40] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/715645 [03:36:51] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/715645 (owner: 10Eileen) [03:39:39] !log civicrm revision changed from e89504652a to 718aa9cad3, config revision is cb0a008cad [03:39:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:42:29] (03PS1) 10Ejegg: Add instructions to employer update notification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715646 [05:30:36] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 4 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10Eileenmcnaughton) @KHaggard I've do... [05:31:22] (03PS2) 10Eileen: Extended report update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714836 [05:32:09] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update CiviCRM extensions - https://phabricator.wikimedia.org/T290050 (10Eileenmcnaughton) [05:32:32] (03PS3) 10Eileen: Extended report update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714836 (https://phabricator.wikimedia.org/T290050) [05:33:05] (03PS2) 10Eileen: Update export permissions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714840 (https://phabricator.wikimedia.org/T290050) [05:33:11] (03PS3) 10Eileen: Update export permissions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714840 (https://phabricator.wikimedia.org/T290050) [05:33:43] (03PS2) 10Eileen: Update civitoken [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714843 (https://phabricator.wikimedia.org/T290050) [05:33:50] (03PS3) 10Eileen: Update civitoken [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714843 (https://phabricator.wikimedia.org/T290050) [05:34:15] (03PS2) 10Eileen: Update civi-tutorial [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714842 (https://phabricator.wikimedia.org/T290050) [05:34:20] (03PS3) 10Eileen: Update civi-tutorial [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714842 (https://phabricator.wikimedia.org/T290050) [05:35:06] (03PS2) 10Eileen: Update ckeditor5 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714837 (https://phabricator.wikimedia.org/T290050) [05:35:12] (03PS3) 10Eileen: Update ckeditor5 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/714837 (https://phabricator.wikimedia.org/T290050) [05:37:26] (03PS1) 10Eileen: Yet another join fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715647 (https://phabricator.wikimedia.org/T289696) [05:39:28] (03CR) 10Eileen: [C: 03+2] Add instructions to employer update notification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715646 (owner: 10Ejegg) [05:51:01] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint onion pit: Search kit links not loading when sharing out to Engage - https://phabricator.wikimedia.org/T279686 (10Eileenmcnaughton) Just updating this to note where I'm at.... [05:51:17] (03Merged) 10jenkins-bot: Add instructions to employer update notification [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715646 (owner: 10Ejegg) [05:54:15] (03PS1) 10Eileen: Add, possibly temporary, permission adjustment to give engage payment search access [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715648 [13:47:43] howdy fr-tech! [14:01:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 4 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10KHaggard) Thanks @Eileenmcnaughton... [14:10:10] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint onion pit, 10FR-Civi-Prospect: Remove switcheroo button from activities - https://phabricator.wikimedia.org/T287644 (10NNichols) Yay! Thank you! [14:26:35] 10fundraising-tech-ops: staging-server changes for payments1008 - https://phabricator.wikimedia.org/T289869 (10Jgreen) [14:28:22] 10fundraising-tech-ops: staging-server changes for payments1008 - https://phabricator.wikimedia.org/T289869 (10Jgreen) p:05Triage→03Medium a:03Jgreen [14:44:20] 10fundraising-tech-ops: Fundraising access request for Damilare Adedoyin - https://phabricator.wikimedia.org/T286956 (10Damilare) ccccccvvlgkg [14:46:22] jgleeson fr-tech hi! [14:48:28] hey AndyRussG :) [14:53:52] :) [15:06:46] 10fundraising-tech-ops: Fundraising access request for Damilare Adedoyin - https://phabricator.wikimedia.org/T286956 (10Damilare) ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQDp1RTblOTdI2A2cRAOEHepn34AtutVH+2SkrQFhf2eUqPuWTN2qP+7i39viBWOOdt1cGR7uwobuatRQdYf+6e1XvFG4x8G9hElAZbDagYy2LeST8SREMGQlCO0nW97L1P7IgGSwbimTjwHlD6... [15:11:39] (03PS1) 10Ejegg: More logging for Adyen Checkout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715749 [15:12:14] fr-tech someone want to peek at that ^^^ ? [15:12:30] I'd like to deploy that along with the switchover to Checkout [15:13:11] ejegg: looking :) [15:21:48] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint onion pit, 10FR-Civi-Prospect: Remove switcheroo button from activities - https://phabricator.wikimedia.org/T287644 (10CaitVirtue) Wahoooooo!! Thank you @Eileenmcnaughton... [16:00:49] 10fundraising-tech-ops: Fundraising access request for Damilare Adedoyin - https://phabricator.wikimedia.org/T286956 (10Jgreen) [16:04:03] fr-tech https://bit.ly/3kLKfMK [16:07:38] jgleeson lolll ;) [16:09:24] ejegg: I just smoke tested that logging patch and nothing died, stuff did get loged [16:09:35] great AndyRussG [16:09:40] any reason not to put a standard unique identifier like order_id in every log line? [16:09:44] ejegg: ^ ? [16:10:01] AndyRussG: that's already prepended [16:10:58] https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/DonationLoggerFactory.php$79 [16:11:07] ejegg: ahh right yeah I see that now in the logs heheh [16:11:11] * AndyRussG facepalms [16:26:31] (03CR) 10AndyRussG: [C: 03+2] "Coooool!!!! Thx for this :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715749 (owner: 10Ejegg) [16:27:04] thanks! [16:32:12] ejegg: thank u! :) [16:39:39] (03CR) 10AndyRussG: [C: 03+2] "yeeeee" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/714877 (owner: 10Ejegg) [16:39:43] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] Add links for Adyen / Apple Pay [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/714877 (owner: 10Ejegg) [16:39:53] thanks again AndyRussG [16:40:14] (03PS3) 10AndyRussG: Add links for Adyen / Apple Pay [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/714877 (owner: 10Ejegg) [16:40:32] (03PS4) 10AndyRussG: Add links for Adyen / Apple Pay [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/714877 (owner: 10Ejegg) [16:40:41] (03PS2) 10AndyRussG: Add debug=true to all payments links [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/715139 (owner: 10Ejegg) [16:40:47] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] Add links for Adyen / Apple Pay [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/714877 (owner: 10Ejegg) [16:41:05] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] Add debug=true to all payments links [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/715139 (owner: 10Ejegg) [16:42:32] ejegg: :) [16:44:06] fr-tech when that logging changes merges, I'll prep the deploy [16:44:18] we seem to be getting an adyen donation every few minutes [16:44:29] so we should see the results pretty soon [16:45:45] yay [16:48:05] sounds good ejegg [16:51:02] (03Merged) 10jenkins-bot: More logging for Adyen Checkout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715749 (owner: 10Ejegg) [16:52:17] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/715764 [16:52:26] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/715764 (owner: 10Ejegg) [16:53:04] (03CR) 10AndyRussG: "Thanks much for this update!!!! ahhh still one small comment, pls see inline :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/676472 (owner: 10Ejegg) [16:56:10] AndyRussG: sorry to waste so much time on that XML formatting code [16:56:32] It's hopefully on the chopping block as soon as we get rid of the old globalcollect adapter [16:57:43] I'll just drop that change and leave the one in the GatewayFormChooser, sound good? [17:00:09] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/715765 [17:00:43] ejegg: I'm breaking for dinner shortly. What time are you thinking of deploying ? [17:01:55] jgleeson: I was hoping to do it pretty soon after those merges clear gerrit [17:02:11] actually, i'd be happy to delay a bit more [17:02:17] i'm going to be breaking for lunch soon [17:03:58] ejegg: does it not seem ok also just to move that single line as suggested? understood that it's not important and will go away, just now I'm morbidly curious.... 8p [17:04:34] AndyRussG: moving that one line would change existing behavior, no? [17:06:45] ok cool. was aiming to push up changes to the apple pay local overrides patch before breaking but I'll resume after dinner so i can be around when the adyen stuff gets deployed. back later! [17:08:16] ejegg: ah I see... and the existing behaviour when that is undefined is just to issue a warning? [17:09:00] I mean I get the sense the existing behaviour is wrong, but if the point is just to remove warnings and keep existing behaviour, I'm happy to +2, also :) [17:09:17] yeah, just trying to clean up IDE warnings [17:09:30] I see [17:09:49] with any decent XML file you'd hit one of the other cases before the pad-- case [17:09:57] so it's probably fine to just drop that change [17:10:00] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/715764 (owner: 10Ejegg) [17:10:10] ok, going to have some lunch [17:10:43] ejegg|food: I'll add a fixme explanation and then +2 okok? [17:54:17] Jeff_Green: dwisehaupt: hey I think you weren't in the tech-talks where we discussed this... so for the apple pay testing infrstructure [17:54:43] we've been using the AWS servers jgleeson set up, just as simple DNS-available ssh tunnels [17:54:47] yes [17:55:56] we reached the conclusion that we actually will need multiple boxes DNS-available, or apparently so, at least, so that multiple devs can have port 80 and 443 endpoints forward simultaneously [17:56:10] apologies if this has not yet been documented here yet https://etherpad.wikimedia.org/p/fr-dev-endpoint-notes [17:56:29] that's what we have working currently for Apple Pay [17:56:33] ok [17:57:07] since the fundraising cluster doesn't have a system of VPSs set up, we thought the easiest thing might be to request a project on WMF Cloud Services [17:57:29] to replace the AWS setup eventually [17:57:35] I think that makes a lot of sense [17:57:43] ah cool.... [17:58:07] we also have a pretty small IP allocation [17:58:10] yeah I want to apologies, though, I know you and dwisehaupt have put time into looking at how to set this up on the fr cluster [17:58:20] no worries about that at all [17:58:26] ah okok cool [17:58:58] so I guess you're OK with us requesting the creation of the Cloud Services project, right? [17:59:26] and thanks so much for the work done so far on this!! it did take us a while to figure out what kind of setup would actually work [18:00:17] yeah, definitely, I think that's a logical place for it [18:01:41] oki cool!! :) [18:04:23] 10Fundraising-Backlog, 10Cloud-VPS (Project-requests): Request creation of fr-tech-dev VPS project - https://phabricator.wikimedia.org/T290098 (10AndyRussG) [18:05:36] 10Fundraising-Backlog, 10Cloud-VPS (Project-requests): Request creation of fr-tech-dev VPS project - https://phabricator.wikimedia.org/T290098 (10AndyRussG) [[ https://etherpad.wikimedia.org/p/fr-dev-endpoint-notes | Previous notes ]] on setting something like this up on the Fundraising cluster. [18:11:13] (03PS4) 10AndyRussG: Fix a couple of undefined var errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/676472 (owner: 10Ejegg) [18:13:02] (03CR) 10AndyRussG: [C: 03+2] "Coool... (my only contributions here are some inline comments, so I think I can +2...)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/676472 (owner: 10Ejegg) [18:15:55] (03Merged) 10jenkins-bot: Fix a couple of undefined var errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/676472 (owner: 10Ejegg) [18:20:43] 10fundraising-tech-ops: Fundraising access request for Damilare Adedoyin - https://phabricator.wikimedia.org/T286956 (10Dwisehaupt) [18:21:44] fr-tech hmm, should that meeting in 10 minutes be cancelled? [18:21:52] 10fundraising-tech-ops: Fundraising access request for Damilare Adedoyin - https://phabricator.wikimedia.org/T286956 (10Dwisehaupt) 05Open→03Resolved @Jgreen assisted on the final steps this morning and @Damilare is all set up. Closing. [18:23:33] yeah I guess so ejegg [18:23:40] fr-tech I' [18:23:51] m going to deploy that adyen change! [18:23:56] nice! [18:24:03] I'll jump on the logs [18:25:07] there's definitely a bit more adyen traffic still flowing [18:25:25] a donation per minute or so [18:25:31] hmm, maybe more? [18:26:07] wait, did that submodule update not merge? [18:26:18] oh, no C+2 [18:26:32] ok, it'll be a little bit longer fr-tech, sorry for the false alarm [18:26:37] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/715765 (owner: 10Ejegg) [18:30:34] (03PS1) 10Ejegg: Adyen: Add applepay to ReferenceData [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/715774 [18:31:13] where does that get used ejegg ? [18:31:21] Audit parsing, at least [18:31:25] ah [18:31:33] looking to see if we call it from elsewhere in the stack [18:32:14] looks like the AdyenMethodCoded unstaging also uses it, but I think we don't actually use that class for the new integration [18:32:20] *codec [18:32:43] and nothing else in CRM [18:33:03] though we should I think add a paymentMethod for applepay [18:33:21] err, i mean a civicrm_payment_instrument [18:34:36] yeah that makes sense [18:36:15] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/715765 (owner: 10Ejegg) [18:36:35] ok, actually ready to deploy now :) [18:37:40] typing the code in for the rsync, fr-tech [18:38:17] !log updated payments-wiki from 564daed816 to c4d56178d0, switched Adyen to Checkout integration [18:38:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:38:49] ok, going to turn off capture-from-ipn-listener [18:38:50] errors ejegg [18:38:55] ooh [18:38:57] reverting [18:39:17] hmmm [18:39:22] ah crap [18:39:29] looks like that annoying authorise wsdl thing [18:39:33] moving into other channel [18:39:34] yeah [18:40:59] !log switched Adyen back to HPP integration [18:41:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:06:12] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: Omit useless entries when syncing matching gifts data - https://phabricator.wikimedia.org/T264944 (10DStrine) 05Open→03Resolved [19:06:19] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint onion pit, 10FR-Civi-Prospect: Remove switcheroo button from activities - https://phabricator.wikimedia.org/T287644 (10DStrine) 05Open→03Resolved [19:06:33] 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint onion pit, and 2 others: Adding tax disambiguation clause to Payments Wiki in France - https://phabricator.wikimedia.org/T286880 (10DStrine) 05Open→03Resolved [19:06:48] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10MW-1.37-notes (1.37.0-wmf.20; 2021-08-23): Non-English descriptor change back to 877 number string - https://phabricator.wikimedia.org/T289171 (10DStrine) 05Open→03Resolved [19:07:09] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: when an employer is not in HEP data or misspelled, save the string in the "employer" custom field - https://phabricator.wikimedia.org/T289083 (10DStrine) 05Open→03Resolved [19:07:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10Recurring-Donations: Trickle of damaged recurring donation messages with contact_id but without gateway_txn_id - https://phabricator.wikimedia.org/T285396 (10DStrine) 05Open→03Resolved [19:07:50] 10Fundraising-Backlog, 10FR-Adyen: Adyen Checkout: Remove flash of unused card type selection buttons - https://phabricator.wikimedia.org/T290103 (10AndyRussG) [19:11:59] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10FR-Adyen: Set up Additional Apple Pay Test servers - https://phabricator.wikimedia.org/T289511 (10DStrine) 05Open→03Resolved [19:12:54] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10Recurring-Donations, 10Patch-For-Review: Recurring queue consumer fails with funny stats execption - https://phabricator.wikimedia.org/T289175 (10DStrine) 05Open→03Resolved [19:13:10] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: Add process-control job to run the drush civicrm-matching-gifts-employers-check command - https://phabricator.wikimedia.org/T260726 (10DStrine) 05Open→03Resolved [19:13:25] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: Enable and extend process-control matching_gifts_sync job to also call civicrm-matching-gifts-employers-check - https://phabricator.wikimedia.org/T273555 (10DStrine) 05Open→03Resolved [19:13:27] 10Fundraising-Backlog, 10fr-matching-gifts, 10Epic: Perform CPR on Matching Gifts process. - https://phabricator.wikimedia.org/T273551 (10DStrine) [19:15:02] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts, 10MW-1.37-notes (1.37.0-wmf.20; 2021-08-23): add employer drop down to all matching gifts variants - https://phabricator.wikimedia.org/T289082 (10DStrine) 05Open→03Resolved [19:16:13] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, and 4 others: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10DStrine) 05Open→03Resolved [19:17:00] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fr-matching-gifts: Test out the end-to-end matching gifts file deployment process. - https://phabricator.wikimedia.org/T273558 (10DStrine) 05Open→03Resolved [19:17:03] 10Fundraising-Backlog, 10fr-matching-gifts, 10Epic: Perform CPR on Matching Gifts process. - https://phabricator.wikimedia.org/T273551 (10DStrine) [19:17:05] 10Fundraising-Backlog, 10fr-matching-gifts, 10Epic: Epic: matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (10DStrine) [19:18:03] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster: sprint goal: dev test donation for apple pay and get matching gifts to internal test - https://phabricator.wikimedia.org/T289080 (10DStrine) 05Open→03Resolved [19:18:33] 10Fundraising-Backlog, 10FR-Adyen: Adyen Checkout: Further CSS tweaks - https://phabricator.wikimedia.org/T290105 (10AndyRussG) [19:18:58] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint onion pit, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Test Adyen Checkout via CODFW hosts - https://phabricator.wikimedia.org/T287987 (10Ejegg) 05Open→03Resolved [19:42:00] 10Fundraising-Backlog, 10FR-Adyen: Adyen Checkout: Further CSS tweaks - https://phabricator.wikimedia.org/T290105 (10DStrine) [19:44:10] (03PS2) 10Eileen: Yet another join fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715647 (https://phabricator.wikimedia.org/T289696) [19:49:18] 10Fundraising-Backlog, 10FR-Adyen: Adyen Checkout: Remove flash of unused card type selection buttons - https://phabricator.wikimedia.org/T290103 (10DStrine) [19:54:36] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update CiviCRM extensions - https://phabricator.wikimedia.org/T290050 (10DStrine) [19:59:01] 10Fundraising-Backlog, 10FR-Adyen: research recurring for apple pay through adyen - https://phabricator.wikimedia.org/T290106 (10DStrine) [20:00:12] 10Fundraising-Backlog, 10FR-Adyen: research recurring for apple pay through adyen - https://phabricator.wikimedia.org/T290106 (10DStrine) [20:27:50] 10Fundraising-Backlog, 10fundraising-tech-ops: simplify download UI for the donor data delivery tool - https://phabricator.wikimedia.org/T285881 (10DStrine) [20:30:16] 10Fundraising-Backlog: sprint goal: get apple pay ready to deploy and start on the 600/800 task - https://phabricator.wikimedia.org/T290107 (10DStrine) [20:34:58] 10Fundraising-Backlog, 10fundraising sprint Q 2021: sprint goal: get apple pay ready to deploy and start on the 600/800 task - https://phabricator.wikimedia.org/T290107 (10XenoRyet) [20:35:00] 10Fundraising-Backlog, 10FR-Adyen: Switch over to using WMF-generated certificates with Adyen Apple Pay - https://phabricator.wikimedia.org/T290108 (10jgleeson) [20:35:02] 10Fundraising-Backlog, 10fundraising sprint Q 2021, 10FR-Adyen: research recurring for apple pay through adyen - https://phabricator.wikimedia.org/T290106 (10XenoRyet) [20:35:04] 10Fundraising-Backlog, 10fundraising sprint Q 2021, 10FR-Adyen: Adyen Checkout: Further CSS tweaks - https://phabricator.wikimedia.org/T290105 (10XenoRyet) [20:35:07] 10Fundraising-Backlog, 10fundraising sprint Q 2021, 10FR-Adyen: Adyen Checkout: Remove flash of unused card type selection buttons - https://phabricator.wikimedia.org/T290103 (10XenoRyet) [20:35:11] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Q 2021: Update CiviCRM extensions - https://phabricator.wikimedia.org/T290050 (10XenoRyet) [20:35:15] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint Q 2021, 10Patch-For-Review: Error message on Civi records - https://phabricator.wikimedia.org/T289696 (10XenoRyet) [20:35:25] 10Fundraising-Backlog, 10fundraising sprint Q 2021, 10fundraising-tech-ops: simplify download UI for the donor data delivery tool - https://phabricator.wikimedia.org/T285881 (10XenoRyet) [20:35:27] 10Fundraising-Backlog, 10fundraising sprint Q 2021: Automatically send status 800 on prior donors stopped at 600 - https://phabricator.wikimedia.org/T276183 (10XenoRyet) [20:35:29] 10Fundraising Sprint Nitpicking, 10Fundraising Sprint Octopus Untangling, 10Fundraising Sprint Pretending This Isn't Happening, 10Fundraising-Backlog, and 3 others: Documentation: UML activity and sequence diagrams for all processors - https://phabricator.wikimedia.org/T141617 (10XenoRyet) [20:35:32] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 12 others: Fix civicrm repo to be non-symlinked - https://phabricator.wikimedia.org/T289100 (10XenoRyet) [20:35:38] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint Q 2021, 10fundraising sprint onion pit, and 2 others: Add Apple Pay test server support to fundraising-dev - https://phabricator.wikimedia.org/T288772 (10XenoRyet) [20:35:41] 10Fundraising-Backlog, 10FR-Adyen: Switch over to using WMF-generated certificates with Adyen Apple Pay - https://phabricator.wikimedia.org/T290108 (10jgleeson) [20:35:43] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint Q 2021, 10fundraising sprint onion pit: Send Receipts not working from civi - https://phabricator.wikimedia.org/T288149 (10XenoRyet) [20:35:53] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint Q 2021, 10fundraising sprint onion pit, and 2 others: Adyen Checkout: Pull donor contact from Apple Pay sheet - https://phabricator.wikimedia.org/T285722 (10XenoRyet) [20:35:58] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 4 others: Adyen Checkout: normalize API error codes - https://phabricator.wikimedia.org/T283307 (10XenoRyet) [20:36:00] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint Q 2021: Catch Adyen Checkout API errors on the DI side - https://phabricator.wikimedia.org/T288830 (10XenoRyet) [20:36:03] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 2 others: Create new WMF donor fields - https://phabricator.wikimedia.org/T288721 (10XenoRyet) [20:36:08] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint Q 2021, 10fundraising sprint onion pit: Review upstream PRs related to contracted token work - https://phabricator.wikimedia.org/T288698 (10XenoRyet) [20:36:10] 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint Q 2021: Documentation: General organization of topics and subtopics - https://phabricator.wikimedia.org/T288279 (10XenoRyet) [20:36:15] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 2 others: update the docs on the civi-acoustic import and export scripts - https://phabricator.wikimedia.org/T286934 (10XenoRyet) [20:36:20] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, and 4 others: Modification to Fredge Report - https://phabricator.wikimedia.org/T285321 (10XenoRyet) [20:36:29] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 5 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10XenoRyet) [20:36:43] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, and 8 others: Handle Apple Pay submission in Adyen Components - https://phabricator.wikimedia.org/T282596 (10XenoRyet) [20:36:54] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint Q 2021, 10fundraising sprint onion pit: Search kit links not loading when sharing out to Engage - https://phabricator.wikimedia.org/T279686 (10XenoRyet) [20:37:00] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 13 others: Update Fundraising tech CI image to use upstream buildkit, no symlink for civ... - https://phabricator.wikimedia.org/T277500 [20:37:09] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Corrugated super slide, 10Fundraising Sprint Downed power line jump rope, and 25 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10XenoRyet) [21:51:48] 10Fundraising-Backlog, 10fundraising sprint Q 2021, 10FR-Adyen: Switch over to using WMF-generated certificates with Adyen Apple Pay - https://phabricator.wikimedia.org/T290108 (10DStrine) [21:58:07] !log switched Adyen to new Checkout integration [21:58:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:59:53] ok fr-tech, adyen is back on the new integration [22:00:15] woot [22:02:09] yay [22:02:28] congrats!!! btw fr-tech I'll be a few mins late to tech-talk btw [22:03:24] ejegg: I see one error in payments.error about skin codes [22:03:59] hmmm is that from earlier [22:05:22] ejegg: looks like it's related to your donation [22:08:06] do we have tech talk? [22:08:27] eileen: not for me [22:08:38] no fair enough! [22:11:09] i'll be there in a sec eileen [22:14:14] ejegg I need to run at 4. if you are going to deploy adyen after that, can you email fr-all to let everyone know it's out? [22:14:36] dstrine: read up a few lines [22:14:45] :) [22:14:47] dstrine it's deployed! [22:14:58] oh ok! [22:15:06] just poking around in the logs + looking at the imported donation [22:15:09] can I get a link to test a donation? [22:15:18] we already opened the champagne! [22:15:53] dstrine: dropped test link in otherchan [22:22:55] (03PS14) 10Jgleeson: Add ApplePay payments-wiki override setup options [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T288772) [22:28:10] (03CR) 10Jgleeson: Add ApplePay payments-wiki override setup options (032 comments) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T288772) (owner: 10Jgleeson) [22:29:47] ejegg: thanks. I got my TY email and I see it in civi. I'm gonna email fr-all [22:29:55] thanks dstrine [22:41:01] eileen and AndyRussG sorry, connection troubles [22:41:05] (03PS2) 10Eileen: Add sql update to remove end dates where they shouldn't be there [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715602 (https://phabricator.wikimedia.org/T283798) [22:50:04] (03PS3) 10Eileen: Add sql update to remove end dates where they shouldn't be there [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715602 (https://phabricator.wikimedia.org/T283798) [22:55:51] (03PS4) 10Ejegg: Add sql update to remove end dates where they shouldn't be there [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715602 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [22:55:55] (03CR) 10Ejegg: [C: 03+2] Add sql update to remove end dates where they shouldn't be there [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715602 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [23:08:03] (03Merged) 10jenkins-bot: Add sql update to remove end dates where they shouldn't be there [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715602 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [23:19:07] eileen: ah didn't mean to interrupt you a second ago [23:19:26] I'm still around this evening if there's more stuff to check out then :) [23:19:29] AndyRussG: no - I got distracted with too many pings [23:20:00] ah heheh yeah that can happen :) [23:33:13] (03PS1) 10Eileen: Run sql to add end dates to old recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715829 (https://phabricator.wikimedia.org/T283798) [23:33:48] ejegg: AndyRussG so I think ^^ should be good - I tested on staging & got 4040 rows which is what I was expecting [23:35:29] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/715830 [23:35:58] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/715830 (owner: 10Eileen) [23:38:29] !log civicrm revision changed from 718aa9cad3 to e567b4c289, config revision is 7a24870bc7 [23:38:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:52:34] eileen: seems legit [23:52:47] should lines 101-108 be indented on level further? [23:53:33] and maybe civicrm_contribution_recur cr should be on a separate line and also indented at that same level? [23:54:32] I was trying to mentally parse the SQL and my brain is understanding it as everything from the civicrm_contribution_recur (i.e. immediately following the UPDATE) to just before the SET feels like it's one block [23:55:22] also I imagine ejegg might understand better and have feedback, otherwise I'm fine +2'ing [23:55:48] if it's not super urgent for this evening I might go out and walk the dog, then see if there has been further feedback afterwards?