[01:00:49] ok, I'm not going to be able to test those tonight, will mark -1 to warn folks [01:01:21] (03CR) 10Ejegg: [C: 04-1] "Needs testing, please don't merge yet" [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/716621 (owner: 10Ejegg) [01:01:37] (03CR) 10Ejegg: [C: 04-1] "Needs testing, please don't merge yet" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716620 (owner: 10Ejegg) [01:07:43] huh, docker payments is now just about hanging [01:07:54] a bit of this in the log: SqlBagOStuff::lock failed due to timeout for payments:messages:en. [01:08:47] hmph, will destroy and re-set-up [01:20:57] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Mailings pages fail to load on prod Civi - https://phabricator.wikimedia.org/T290289 (10Ejegg) [01:29:44] (03PS2) 10Ejegg: Add 'Apple' payment instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716109 [01:30:30] (03PS3) 10Ejegg: Add 'Apple' payment instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716109 [01:44:27] (03PS6) 10Ejegg: Get rid of card_type [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/676473 [01:46:25] (03CR) 10jerkins-bot: [V: 04-1] Get rid of card_type [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/676473 (owner: 10Ejegg) [01:51:36] (03CR) 10Ejegg: [C: 03+2] "This works for me! Agreed with AndyRussG that it would be best for the apache setup to survive a down/up cycle, but this is worth merging " [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T288772) (owner: 10Jgleeson) [06:16:35] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/716974 (owner: 10L10n-bot) [06:43:34] 10Fundraising-Backlog, 10Analytics, 10Analytics-EventLogging, 10Analytics-Kanban, and 4 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10awight) From what I can see, support for producing Schema:EditConflict w... [07:16:45] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/716974 (owner: 10L10n-bot) [07:29:58] 10Fundraising-Backlog, 10Analytics, 10Analytics-EventLogging, 10Analytics-Kanban, and 4 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10awight) I'd like to see some discussion about the `$wgPingback` defaults... [08:31:16] 10Fundraising-Backlog, 10Analytics, 10Analytics-EventLogging, 10Analytics-Kanban, and 4 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10Michael) [13:19:48] 10Fundraising-Backlog, 10Analytics, 10Analytics-EventLogging, 10Analytics-Kanban, and 4 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10Ottomata) [13:20:31] 10Fundraising-Backlog, 10Analytics, 10Analytics-EventLogging, 10Analytics-Kanban, and 4 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10Ottomata) [13:54:25] (03CR) 10Awight: [C: 03+2] "It might be nice to decouple the two extensions in the future, but for now it's correct to reflect the hard dependency." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/702734 (owner: 10Ejegg) [13:59:09] (03Merged) 10jenkins-bot: Explicitly require EventLogging [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/702734 (owner: 10Ejegg) [14:02:11] (03CR) 10Awight: [C: 03+2] Update small code pieces to use more modern PHP 7 syntax (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/683617 (owner: 10Thiemo Kreuz (WMDE)) [14:05:00] (03PS5) 10Awight: Add unit test for CentralNotice::sanitizeSearchTerms [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/688951 (owner: 10Thiemo Kreuz (WMDE)) [14:05:07] (03CR) 10Awight: [C: 03+2] Add unit test for CentralNotice::sanitizeSearchTerms (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/688951 (owner: 10Thiemo Kreuz (WMDE)) [14:07:19] (03CR) 10Awight: [C: 03+2] Avoid using ContentHandler::getContentText() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/692423 (owner: 10Zabe) [14:11:32] (03CR) 10Awight: [C: 03+2] Replace link() function with linkRenderer() (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/691166 (https://phabricator.wikimedia.org/T279326) (owner: 10Palak199) [14:19:12] hi fr-tech [14:20:56] (03Merged) 10jenkins-bot: Update small code pieces to use more modern PHP 7 syntax [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/683617 (owner: 10Thiemo Kreuz (WMDE)) [14:20:58] (03Merged) 10jenkins-bot: Add unit test for CentralNotice::sanitizeSearchTerms [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/688951 (owner: 10Thiemo Kreuz (WMDE)) [14:22:52] (03CR) 10Awight: [C: 03+1] "Looks right to me." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/683619 (owner: 10Thiemo Kreuz (WMDE)) [14:23:55] (03CR) 10Awight: [C: 03+1] "Let's do this 👍" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/78172 (owner: 10Mwalker) [14:26:28] (03CR) 10Awight: "Need to squint at this further." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/688960 (owner: 10Thiemo Kreuz (WMDE)) [14:26:55] (03Merged) 10jenkins-bot: Avoid using ContentHandler::getContentText() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/692423 (owner: 10Zabe) [14:46:30] (03Merged) 10jenkins-bot: Replace link() function with linkRenderer() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/691166 (https://phabricator.wikimedia.org/T279326) (owner: 10Palak199) [14:48:05] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe, 10fr-donorservices: Dedupe hover tool tip should show a total of all contributions - https://phabricator.wikimedia.org/T277307 (10SHust) @DStrine you are correct, the issue has been solved. Thanks for double-checking! [14:59:11] (03CR) 10Thiemo Kreuz (WMDE): Simplify CentralNotice::sanitizeSearchTerms implementation (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/688960 (owner: 10Thiemo Kreuz (WMDE)) [15:05:19] (03CR) 10Thiemo Kreuz (WMDE): Add unit test for CentralNotice::sanitizeSearchTerms (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/688951 (owner: 10Thiemo Kreuz (WMDE)) [15:21:32] (03PS4) 10Thiemo Kreuz (WMDE): Optimize regular expression code in PHP and JavaScript [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/683619 [15:21:39] (03CR) 10jerkins-bot: [V: 04-1] Optimize regular expression code in PHP and JavaScript [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/683619 (owner: 10Thiemo Kreuz (WMDE)) [15:22:52] hi cstone fr-tech :) [15:22:54] (03CR) 10Thiemo Kreuz (WMDE): Optimize regular expression code in PHP and JavaScript (033 comments) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/683619 (owner: 10Thiemo Kreuz (WMDE)) [15:22:59] hi awight!! [15:23:33] hi AndyRussG [15:23:51] :) [15:23:52] were you able to xdebug through our apple pay test env or was that something else I'm thinking of [15:24:14] cstone yep xdebug worked fine as always [15:24:54] server component stayed on the linux laptop [15:25:05] and for front-end debugging had to activate Safari dev tools [15:25:36] hmm okay maybe i turned something off on my end then [15:30:11] cstone: if you set xdebug_web.ini for autostart to true, then you have to restart the payments container... but don't destroy ("down") it [15:30:30] just instead you can say docker-compose restart payments [15:35:24] hah hmm well now nothing is showing up haha what did i do [15:39:07] ok progress! [15:40:25] ok its working!! [15:41:44] cstone: yaaayyyy:) :) [15:46:54] (03CR) 10AndyRussG: [V: 03+2] "Thanks so much for this, @jgleeson and @ejegg! Just giving this CI-forsaken repo the required push over the edge... :)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T288772) (owner: 10Jgleeson) [15:55:15] (03PS5) 10Thiemo Kreuz (WMDE): Optimize regular expression code in PHP and JavaScript [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/683619 [15:56:22] (03PS4) 10Thiemo Kreuz (WMDE): Simplify CentralNotice::sanitizeSearchTerms implementation [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/688960 [15:58:10] thanks AndyRussG ! [15:58:19] also hi hi! [16:13:12] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe, 10fr-donorservices: Dedupe hover tool tip should show a total of all contributions - https://phabricator.wikimedia.org/T277307 (10DStrine) 05Open→03Resolved [16:13:47] (03CR) 10AndyRussG: "resubmit" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713551 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [16:15:45] (03CR) 10AndyRussG: [C: 03+2] Adyen Checkout: Apple Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713551 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [16:17:35] 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog, 10FR-Adyen: research recurring for apple pay through adyen - https://phabricator.wikimedia.org/T290106 (10Cstone) a:03Cstone [16:18:28] (03Merged) 10jenkins-bot: Adyen Checkout: Apple Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713551 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [16:18:31] 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog, 10FR-Adyen: Switch over to using WMF-generated certificates with Adyen Apple Pay - https://phabricator.wikimedia.org/T290108 (10jgleeson) a:03jgleeson [16:19:58] 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog, 10FR-Adyen: research recurring for apple pay through adyen - https://phabricator.wikimedia.org/T290106 (10Cstone) https://docs.adyen.com/payment-methods/apple-pay/web-component#recurring-payments They use the same method as we implemented for the... [16:20:48] 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog, 10FR-Adyen: Adyen Checkout: Further CSS tweaks - https://phabricator.wikimedia.org/T290105 (10Damilare) a:03Damilare [16:23:59] 10fundraising-tech-ops: staging-server changes for payments1008 - https://phabricator.wikimedia.org/T289869 (10Jgreen) [16:30:12] 10Fundraising-Backlog: Implement GPAY through adyen, in a variant - https://phabricator.wikimedia.org/T244513 (10DStrine) [16:30:15] fr-tech this one finally merged: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/713551 [16:31:58] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Unable to run "Fraud Rejections by IP" report in Civi - https://phabricator.wikimedia.org/T290139 (10DStrine) @Eileenmcnaughton any ideas on why this might be happening? If this is a quick fix, could you help out? If this seems more complicated I'll leave... [16:37:23] 10Fundraising-Backlog, 10FR-Adyen: Monthly convert for Adyen - https://phabricator.wikimedia.org/T290338 (10DStrine) [16:38:27] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Quantum Leapfrog: Email templates in Civi not working properly - https://phabricator.wikimedia.org/T290265 (10DStrine) a:05DStrine→03None [16:38:41] 10fundraising-tech-ops, 10Patch-For-Review: staging-server changes for payments1008 - https://phabricator.wikimedia.org/T289869 (10Jgreen) [17:26:51] 10Fundraising-Backlog, 10fundraising-tech-ops: investigate setting up a staging version of payments wiki - https://phabricator.wikimedia.org/T248701 (10Jgreen) [18:00:29] 10fundraising-tech-ops: staging-server changes for payments1008 - https://phabricator.wikimedia.org/T289869 (10Jgreen) 05Open→03Resolved [18:00:31] 10Fundraising-Backlog, 10fundraising-tech-ops: investigate setting up a staging version of payments wiki - https://phabricator.wikimedia.org/T248701 (10Jgreen) [18:01:18] 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog: Automatically send status 800 on prior donors stopped at 600 - https://phabricator.wikimedia.org/T276183 (10MBeat33) One other process point: sometimes legitimate donors get a status 600 but retry shortly after, and the next attempt succeeds. Can we... [19:15:55] XenoRyet: you're fake employer did not show up in civi :/ I'm not sure how ejegg|away tested that [19:16:24] Is it supposed to just land in the employer field on my contact? [19:16:38] we might have to reopen that bug [19:17:01] Yea, possibly [19:17:43] I think that's how Elliott explained it :/ I just tried a bogus employer name with my WMF email address. gonna see what that looks like [19:18:47] Would it be useful for me to try one from the dropdown on an alternate email? I've got a few of those laying around [19:20:06] XenoRyet: yeah that would help too, thanks [19:20:24] Cool, I'll put that on the thread when it goes through as well. [19:20:28] thanks [19:20:55] the rando employer input bug is what I was worried about. [19:21:36] eyener: do you remember if we have 2 fields in civi with "employer" in the name? [19:22:03] I'm wondering if the custom one we made is hidden in the UI and the one I see is a default employer in civi core [19:22:41] but Elliott was saying it was all going to the same field.... at least that's what I heard. [19:30:00] dstrine, ok, picked from the dropdown and looks like it worked fine, so yea, maybe we have something buggy around rando stuff [19:30:45] Oh, wait. Xeno Labs did get in there somewhere. [19:31:07] It's in my communications section under "Employer Name" [19:36:48] AH! XenoRyet I see it [19:37:00] I also see Strine inc in my @WMF account [19:37:46] Cool. Seems like that probably is the intended behavior when we don't have an employer to match to. [19:40:51] uhh hmm dstrine I'm not quite sure about employer [19:41:52] I just see employer_id in civicrm_contact but that has to map to somwhere [19:42:43] eyener: sorry never mind. we figured it out [19:52:53] awesome [20:04:49] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 5 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10KHaggard) 05Open→03Resolved ^ A...