[00:00:14] ohhh, but without the parens you add we are currently just deleting whenever e.email = '', regardless of log_date??? [00:00:59] right, AND takes precedence over OR [00:01:45] yeah basically [00:01:46] (03PS1) 10Ejegg: WIP notes towards moving orphan logic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) [00:02:25] tbh that log stuff is probably in there for speed - but it might be quicker without [00:08:07] I get 196 emails (many duplicates) after 4.5 mins with that query - just trying to see if the contact in question is in [00:13:31] ok - it looks like she WAS deleted from that table [00:13:39] but not silverpop_export [00:15:14] & we eventually use silverpop_export... [00:16:29] perhaps that changed along the way - if this was under php I'd be so much happier [00:39:25] sorry, back in a bit [01:43:52] 10Fundraising-Backlog, 10Wikipedia-Android-App-Backlog, 10fr-donorservices: "No App" error from monthly convert on mobile - https://phabricator.wikimedia.org/T291199 (10LGoto) Long press should show the app info as here: {F34650407} If it does not work, you may need to change your phone settings: https://su... [02:23:08] (03Abandoned) 10Ejegg: Replace obsolete jquery multiselect plugin with working one [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/722441 (https://phabricator.wikimedia.org/T291431) (owner: 10Ejegg) [02:48:10] (03CR) 10Ejegg: [C: 03+2] "Works for me locally in Chrome and FireFox! Nicely done. I had forgotten completely that you had made another fix to this library 3 years " [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/722695 (https://phabricator.wikimedia.org/T291431) (owner: 10AndyRussG) [02:50:32] 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, 10Design-Systems-team-project, 10MediaWiki-extensions-CentralNotice, 10Patch-For-Review: Update CentralNotice admin UI not to use broken JQ multiselect widget - https://phabricator.wikimedia.org/T291431 (10Ejegg) In case we do ever need the actu... [02:50:58] (03Merged) 10jenkins-bot: Close all tags in multiselect for jQuery update [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/722695 (https://phabricator.wikimedia.org/T291431) (owner: 10AndyRussG) [02:57:14] 10Fundraising-Backlog, 10Wikipedia-Android-App-Backlog, 10fr-donorservices: "No App" error from monthly convert on mobile - https://phabricator.wikimedia.org/T291199 (10KHancock99) Thank you, @LGoto, but no luck with the long press producing //App Info// via an array of modifications to phone settings on a H... [02:57:51] (03PS1) 10Ejegg: Tiny smash-pig library update [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/722727 [02:57:57] (03CR) 10Ejegg: [C: 03+2] Tiny smash-pig library update [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/722727 (owner: 10Ejegg) [02:58:31] (03CR) 10AndyRussG: "Thanks for the review!!!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/722695 (https://phabricator.wikimedia.org/T291431) (owner: 10AndyRussG) [03:01:42] oh boy, in https://phabricator.wikimedia.org/T185913 matmarex suggested OO.ui.MenuTagMultiselectWidget [03:01:48] those who do not remember history? [03:03:26] oh hey, I also got this (pre-existing) weirdness at one point tonight trying to test your patch: https://phabricator.wikimedia.org/T74421 [03:03:51] though on FF, not Chrome as reported in the bug [03:04:24] and.... awight 2015 says 'Let's start looking at how to replace this plugin with something else... [03:04:29] ' [03:10:20] (03Merged) 10jenkins-bot: Tiny smash-pig library update [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/722727 (owner: 10Ejegg) [03:12:00] ejegg: heheh that's hilarious [03:12:05] I have exactly 0 memory of any of that [03:12:18] aww [03:12:33] though since that was shortly after my divorce I'm not surprised that something has blocked stuff in my brain from that time [03:12:46] aii, yeah :( [03:12:52] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Browser-Support-Google-Chrome, 10Patch-For-Review: Multiselects in Special:CentralNotice sometimes load incorrectly - https://phabricator.wikimedia.org/T74421 (10Ejegg) I was just able to see it again, but only in FF (with debug=true) and not i... [03:12:55] I have no such excuse to not remember [03:13:11] ejegg: it's okok I'm glad it's over and done with... heheh no excuse required eh! [03:14:35] hmmm well one part of CN that could use a good old major overhaul is indeed the Admin UI [03:15:03] (03PS1) 10Eileen: Add delete for rows in silverpop_export not in silverpop_export_staging [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/722728 (https://phabricator.wikimedia.org/T244811) [03:15:23] ejegg: I think ^^ is the one that would have gotten rid of the relevant contacts [03:15:37] (the other wouldn't have affected that contact) [03:17:00] ok eileen [03:17:37] ejegg: I put the rows that would be deleted by that in 2 tables in the silverpop db for now [03:17:59] so export_staging is still the full accumulated list, not just the last N days [03:18:02] ? [03:18:03] ejegg: https://phabricator.wikimedia.org/T74421 a bug like Haley's commet [03:18:16] *comet [03:19:43] * ejegg looks up comets with period=6 years [03:20:12] "P/2014 L2" just doesn't have that ring to it [03:20:37] https://en.wikipedia.org/wiki/List_of_periodic_comets [03:22:27] https://en.wikipedia.org/wiki/Comet_Kohoutek [03:23:37] Eileen had you heard of this almost eponymous comet? https://en.wikipedia.org/wiki/Comet_McNaught [03:24:20] * ejegg stops procrastinating looking at silverpop code [03:26:03] 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, 10Design-Systems-team-project, 10MediaWiki-extensions-CentralNotice: Update CentralNotice admin UI not to use broken JQ multiselect widget - https://phabricator.wikimedia.org/T291431 (10AndyRussG) Just to note, the solution that was merged is appr... [03:26:35] argh eileen i really need to get to bed - i know I owe you a ton of code review [03:26:41] ejegg: yeah they don't have to accumulate I don't think but then we wind up having to do a full update and ... [03:26:48] but it's going to have to wait another day [03:26:49] 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, 10MediaWiki-extensions-CentralNotice: Update CentralNotice admin UI not to use broken JQ multiselect widget - https://phabricator.wikimedia.org/T291431 (10AndyRussG) [03:26:57] night [03:32:52] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: GlobalCollect_endpoint_critical 2 [=1] [03:37:48] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: GlobalCollect_endpoint_critical 3 [=1] [03:42:32] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: GlobalCollect_endpoint_critical 3 [=1] [03:47:32] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: GlobalCollect_endpoint_critical 1 [=1] [03:52:32] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: GlobalCollect_endpoint_critical 2 [=1] [03:57:32] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: GlobalCollect_endpoint_critical 4 [=1] [04:02:32] RECOVERY - check_log_messages on frav1002 is OK: OK [04:12:32] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: GlobalCollect_endpoint_critical 4 [=1] [04:17:32] RECOVERY - check_log_messages on frav1002 is OK: OK [13:36:39] 10Fundraising-Backlog, 10Wikipedia-Android-App-Backlog, 10fr-donorservices: "No App" error from monthly convert on mobile - https://phabricator.wikimedia.org/T291199 (10Dbrant) Thanks @KHancock99, Since we're now able to reproduce the issue, we no longer need additional information from affected users. We're... [13:40:59] 10Fundraising-Backlog, 10Wikipedia-Android-App-Backlog, 10fr-donorservices: "No App" error from monthly convert on mobile - https://phabricator.wikimedia.org/T291199 (10MBeat33) Many thanks, @Dbrant [15:34:13] 10Fundraising-Backlog: Tech talk on EOY receipt email - https://phabricator.wikimedia.org/T291572 (10DStrine) [15:35:18] 10Fundraising-Backlog, 10Cloud-VPS (Project-requests): Request creation of fr-tech-dev VPS project - https://phabricator.wikimedia.org/T290098 (10aborrero) a:03dcaro This was approved in the WMCS team meeting! @dcaro will follow up soon. [15:46:49] 10Fundraising-Backlog, 10FR-Paypal: Dust off braintree docs and break down tasks? - https://phabricator.wikimedia.org/T291573 (10DStrine) [15:56:08] 10Fundraising-Backlog, 10Cloud-VPS (Project-requests): Request creation of fr-tech-dev VPS project - https://phabricator.wikimedia.org/T290098 (10jgleeson) Great news @aborrero!!! thanks for the update. [16:04:33] 10Fundraising-Backlog, 10FR-Adyen: Set up new fr-dev staging server for Apple Pay - https://phabricator.wikimedia.org/T291577 (10jgleeson) [16:09:29] 10Fundraising-Backlog, 10FR-Adyen: Set up new fr-dev staging server for Apple Pay - https://phabricator.wikimedia.org/T291577 (10jgleeson) [17:14:03] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint Quantum Leapfrog, and 2 others: Search kit links not loading when sharing out to Engage - https://phabricator.wikimedia.org/T279686 (10MDemosWMF) @Eileenmcnaughton Had them... [18:12:52] 10Fundraising-Backlog, 10Wikipedia-Android-App-Backlog, 10fr-donorservices: "No App" error from monthly convert on mobile - https://phabricator.wikimedia.org/T291199 (10Dbrant) a:03Dbrant [18:13:05] 10Fundraising-Backlog, 10fr-donorservices, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): "No App" error from monthly convert on mobile - https://phabricator.wikimedia.org/T291199 (10Dbrant) [18:38:01] (03CR) 10Jgleeson: [C: 03+2] "This all built without issue, and it is working for me locally. I tested out the RO and RW URLs, with both behaving as expected." [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/720092 (https://phabricator.wikimedia.org/T285881) (owner: 10Ejegg) [18:43:32] (03CR) 10Jgleeson: [C: 03+2] "Looks good! This removes the buttons at the top for me on the RO instance." [wikimedia/fundraising/privatebin] - 10https://gerrit.wikimedia.org/r/720832 (https://phabricator.wikimedia.org/T285881) (owner: 10Ejegg) [18:47:04] (03CR) 10Jgleeson: "So this does replace the logo but it's really small on my screen." [wikimedia/fundraising/privatebin] - 10https://gerrit.wikimedia.org/r/720839 (https://phabricator.wikimedia.org/T285881) (owner: 10Ejegg) [19:37:58] (03CR) 10Ejegg: "Oops, I thought I had swapped that out for the no-text version which looks better when small. Let me make sure I uploaded the latest PS I " [wikimedia/fundraising/privatebin] - 10https://gerrit.wikimedia.org/r/720839 (https://phabricator.wikimedia.org/T285881) (owner: 10Ejegg) [20:04:54] (03PS3) 10Ejegg: Swap PrivateBin logo for WMF logo [wikimedia/fundraising/privatebin] - 10https://gerrit.wikimedia.org/r/720839 (https://phabricator.wikimedia.org/T285881) [20:08:06] (03CR) 10Ejegg: Swap PrivateBin logo for WMF logo (031 comment) [wikimedia/fundraising/privatebin] - 10https://gerrit.wikimedia.org/r/720839 (https://phabricator.wikimedia.org/T285881) (owner: 10Ejegg) [21:29:49] 10Fundraising-Backlog, 10Product-Analytics, 10Wikimedia-CentralNotice-Administration, 10Wiki-Loves-Monuments (2021): Statistics on WLM centralnotice banners - https://phabricator.wikimedia.org/T290387 (10leila) (Disclaimer: I have volunteered for Wiki Loves Monuments for multiple years and understand and e... [22:57:34] Can I push a bit to get a merge on this one - now we are honing in on the forget me it would be good to remove what we found - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/722728