[00:08:14] !log civicrm revision changed from 34d3c3aae8 to b6f5f71c18 [00:08:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:12:36] ok cool ejegg just did my test one and its correctly sepa direct debit in adyen [00:12:42] im going to turn the job back on [00:35:15] (03PS9) 10Eileen: Install translated versions on recurring failed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/725182 [00:35:17] (03PS3) 10Eileen: Use new civi core token for date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726349 [00:35:19] (03PS3) 10Eileen: Switch wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726685 [00:35:22] (03PS1) 10Eileen: Add translate permission [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726727 [00:53:45] awesome cstone [01:26:34] (03CR) 10Ejegg: [C: 03+2] 5.43 alpha latest [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/726113 (https://phabricator.wikimedia.org/T292370) (owner: 10Eileen) [01:36:51] (03Merged) 10jenkins-bot: 5.43 alpha latest [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/726113 (https://phabricator.wikimedia.org/T292370) (owner: 10Eileen) [02:49:09] (03PS10) 10Eileen: Install translated versions on recurring failed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/725182 [02:49:11] (03PS4) 10Eileen: Use new civi core token for date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726349 [02:49:13] (03PS2) 10Eileen: Add translate permission [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726727 [02:49:15] (03PS4) 10Eileen: Switch wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726685 [02:49:17] (03PS1) 10Eileen: Remove field default for mailing_provider_data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726736 [02:50:44] (03PS1) 10Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726737 [02:50:55] (03CR) 10Eileen: [C: 03+2] CiviCRM submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726737 (owner: 10Eileen) [03:00:48] (03CR) 10jerkins-bot: [V: 04-1] Switch wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726685 (owner: 10Eileen) [03:02:07] (03Merged) 10jenkins-bot: CiviCRM submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726737 (owner: 10Eileen) [03:12:27] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/726741 [03:13:05] (03PS2) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/726741 [03:13:17] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/726741 (owner: 10Eileen) [03:19:17] !log civicrm revision changed from b6f5f71c18 to 82efd2e195, config revision is f4c57d4733 [03:19:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:25:00] 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo: Unable to download the query data - Rakhi Fraud Scan - https://phabricator.wikimedia.org/T292370 (10Eileenmcnaughton) @RKumar_WMF should be all good now [06:31:23] (03PS5) 10Eileen: Switch wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726685 [07:29:25] (03PS11) 10Eileen: Install translated versions on recurring failed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/725182 [07:29:27] (03PS3) 10Eileen: Add translate permission [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726727 [07:29:29] (03PS2) 10Eileen: Remove field default for mailing_provider_data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726736 [07:29:31] (03PS6) 10Eileen: Switch wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726685 [07:29:33] (03PS1) 10Eileen: Use new civi core token for date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726843 [07:33:48] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/726793 (owner: 10L10n-bot) [07:42:20] (03CR) 10jerkins-bot: [V: 04-1] Switch wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726685 (owner: 10Eileen) [07:50:22] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/726793 (owner: 10L10n-bot) [08:07:22] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/726793 (owner: 10L10n-bot) [08:14:52] (03CR) 10Raimond Spekking: [C: 03+2] "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/726793 (owner: 10L10n-bot) [08:16:22] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/726793 (owner: 10L10n-bot) [08:23:45] (03CR) 10Raimond Spekking: [C: 03+2] "James, could you merge?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/726793 (owner: 10L10n-bot) [08:35:09] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/726793 (owner: 10L10n-bot) [11:20:22] 10Fundraising-Backlog: Production of Upsell Thank You email in Spanish-LATAM - https://phabricator.wikimedia.org/T292542 (10CDenes_WMF) Pre-test date is confirmed as November 16th. Would it potentially be possible to have this in production by November 5th or 10th (giving us a couple days to proof and do a test... [13:57:23] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen iframe config error messages inside card fields - https://phabricator.wikimedia.org/T292571 (10MBeat33) "like a weird timeout kind of condition on Adyen's end." thank you @XenoRyet, we will keep an eye out for any more of these, or if anyone can re... [14:50:51] hi fr-tech [14:55:21] greetings [15:01:00] (03PS1) 10Zabe: Only filter for user if the given username is valid [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/726921 (https://phabricator.wikimedia.org/T292639) [15:04:45] (03CR) 10Ejegg: [C: 03+2] "Thanks @Zabe, this looks like a useful guard!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/726921 (https://phabricator.wikimedia.org/T292639) (owner: 10Zabe) [15:06:34] hi fr-tech :) [15:06:42] hi AndyRussG [15:07:32] (03Merged) 10jenkins-bot: Only filter for user if the given username is valid [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/726921 (https://phabricator.wikimedia.org/T292639) (owner: 10Zabe) [15:20:14] AndyRussG: do you have time to do a final review pass on those dev-images patches? [15:20:36] ejegg: yes for sure [15:20:57] ejegg: though last I checked I'm still locked out of my gitlab account, so someone else would have to merge [15:20:58] Thank! I'd love to get those images built and into the repo so we can merge the fundraising-dev patches and get back to actually developing Apple Pay forms [15:21:08] yep yep :) [15:21:09] oh no, how did you get locked out? [15:21:22] it wants me to enable 2fa but doesn't let me [15:21:45] hrm? Are you using an autenticator app? [15:22:10] yep [15:22:23] https://phabricator.wikimedia.org/T292431 [15:23:24] oh dang [15:24:24] and hmm, we do seem to be getting a fair amount of adyen failmail [15:24:38] seems like errors that the form validation should be catching [15:24:56] oh hmmm [15:25:00] but since it's not, we should really treat those as validation errors and not failmail-worthy [15:25:07] I think I had a ticket already [15:25:11] ejegg: France started yesterday [15:25:22] yeah, that's the source of the volume [15:26:15] https://phabricator.wikimedia.org/T290923 [15:26:41] I might work on that while i wait for CR on the apple pay stuffs [15:30:20] ejegg: ohhh yeah that seems important [15:35:21] hmm, so we can't use the HttpStatusValidator exactly [15:36:13] I guess I'm going to want to do like we did with Ingenico [15:36:41] with a RestResponseValidator that accepts a few more http status codes [15:38:05] hmmmm [15:39:30] 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo: Unable to download the query data - Rakhi Fraud Scan - https://phabricator.wikimedia.org/T292370 (10RKumar_WMF) I am able to download the spreadsheet but unable to sort the query result in within Civi before downloading. [15:48:57] (03CR) 10Ejegg: [C: 04-1] "They all show up in my list with a blank in the Title column - I tried digging in a bit but wasn't able to find exactly what bit was missi" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/725182 (owner: 10Eileen) [15:53:17] (03CR) 10Jforrester: Localisation updates from https://translatewiki.net. (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/726793 (owner: 10L10n-bot) [16:01:00] ah dang, we've got these incompatible error classes [16:01:14] so can I make ValidationError a subclass of PaymentError? [16:02:22] boo, that would be a bigger refactor than I want to do right now [16:03:21] ok, I could make PaymentProviderResponse::$errors polymorphic but that seems a bit gross [16:03:36] I could add a PaymentProviderResponse::$validationErrors [16:05:12] so up in DonationInterface land we do have a polymorphic error stack [16:05:25] now why did we think that was a good idea??? [16:05:45] oops, meeting! [16:05:46] ejegg: we're in standup eh [16:05:50] yeee [16:20:34] 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10FR-Adyen: Adyen Checkout: Show validation errors and allow resubmit for appropriate API error codes - https://phabricator.wikimedia.org/T290923 (10Ejegg) p:05Triage→03High a:03Ejegg [16:24:09] 10Fundraising-Backlog: Current Engage Civi User Needs Additional Certificate - https://phabricator.wikimedia.org/T292649 (10MDemosWMF) [16:31:27] (03PS1) 10Cstone: Revert "Add payment_method to authorize request" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/726949 [16:31:36] 10Fundraising-Backlog, 10fundraising-tech-ops: Current Engage Civi User Needs Additional Certificate - https://phabricator.wikimedia.org/T292649 (10Dwisehaupt) a:03Dwisehaupt They will not need additional credentials. They can use the existing certificate and password that they have. If they no longer have c... [16:32:52] (03CR) 10jerkins-bot: [V: 04-1] Revert "Add payment_method to authorize request" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/726949 (owner: 10Cstone) [16:33:34] oh no smashpig [16:33:37] version haha [16:46:44] (03CR) 10Ejegg: [C: 03+2] Revert "Add payment_method to authorize request" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/726949 (owner: 10Cstone) [16:47:35] arr, and no V+2 override on that repo [16:48:15] (03CR) 10jerkins-bot: [V: 04-1] Revert "Add payment_method to authorize request" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/726949 (owner: 10Cstone) [17:02:14] (03PS1) 10Ejegg: More type hints for *Response classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726942 [17:02:16] (03PS1) 10Ejegg: RestResponseValidator for Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726943 (https://phabricator.wikimedia.org/T290923) [17:27:43] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fr-donorservices: Civi: underscore in email address slows search - https://phabricator.wikimedia.org/T234100 (10MBeat33) cid=40501028 Find Contacts search for this underscore-y email address was 1 min [17:28:56] oh phooey, we need exceptions to the ExceptionMapper::throwOnAdyenError [17:30:16] orrrr... we need to try/catch around the API makeRestApiCall s [17:31:37] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fr-donorservices: Civi: Advanced Search is slow for email addresses with underscores - https://phabricator.wikimedia.org/T147156 (10MBeat33) [17:32:04] hmm, I guess we could even do the try/catch up in the DonationInterface level? [17:51:15] ok, I think I have it... just need to get a test around it [17:53:22] annnnd I should move those type hints after the RestResponseValidator [17:53:52] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Janna Layton - https://phabricator.wikimedia.org/T292222 (10Dwisehaupt) ` Date: Wed, 6 Oct 2021 10:48:08 From: Lisa Gruwell To: Patricia Pena Cc: Erin Yener, Dallas Wisehaupt Subject: Re: Civi Cert Permission Request: Janna Layton -... [18:02:37] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Janna Layton - https://phabricator.wikimedia.org/T292222 (10Dwisehaupt) [18:05:04] fr-tech I'll be like 2 min more [18:11:33] (03PS2) 10Ejegg: RestResponseValidator for Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726943 (https://phabricator.wikimedia.org/T290923) [18:11:35] (03PS2) 10Ejegg: More type hints for *Response classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726942 [18:11:37] (03PS1) 10Ejegg: WIP deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) [18:12:08] (03CR) 10jerkins-bot: [V: 04-1] WIP deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [18:15:19] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10User-brennen, 10Wikimedia-production-error: CentralNoticeCampaignLogPager: Error: Call to a member function getId() on boolean - https://phabricator.wikimedia.org/T292662 (10brennen) [19:20:56] 10Fundraising-Backlog, 10fundraising-tech-ops: Current Engage Civi User Needs Additional Certificate - https://phabricator.wikimedia.org/T292649 (10MDemosWMF) Great, thank you for letting me know! I will reach back out if there are any issues. [20:35:56] (03CR) 10Eileen: "ejegg - I think the issue is likely that you have an extraneous row in your civicrm_msg_template table for the recurring message - I've fi" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/725182 (owner: 10Eileen) [20:57:05] (03CR) 10Eileen: [C: 04-1] "Have hit an issue with this" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726843 (owner: 10Eileen) [20:58:42] ejegg|afk: XenoRyet cstone are people thinking the ct meeting is on? [20:59:11] Good question [20:59:48] I was planning on showing up, but it's not really my meeting. [21:00:43] CT meeting? [21:01:05] I assumed we were talking about the civi one right now. [21:02:12] ok, i'm in that one [21:11:44] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Janna Layton - https://phabricator.wikimedia.org/T292222 (10EYener) Added contact info for @JLaytonWMF to the Collab page. [21:36:23] 10Fundraising-Backlog, 10Product-Analytics, 10Research, 10Wikimedia-CentralNotice-Administration, 10Wiki-Loves-Monuments (2021): Conduct research on WLM centralnotice banners - https://phabricator.wikimedia.org/T290387 (10leila) 05Open→03In progress p:05Triage→03Medium a:03Effeietsanders [21:41:13] 10Fundraising-Backlog, 10Product-Analytics, 10Research, 10Wikimedia-CentralNotice-Administration, 10Wiki-Loves-Monuments (2021): Conduct research on WLM centralnotice banners - https://phabricator.wikimedia.org/T290387 (10leila) Update: - I heard back from Effeietsanders and they confirmed that the WLM... [22:12:33] (03Abandoned) 10Eileen: Use new civi core token for date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726843 (owner: 10Eileen) [23:08:08] (03PS4) 10Eileen: Add translate permission [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726727 [23:08:10] (03PS3) 10Eileen: Remove field default for mailing_provider_data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726736 [23:08:12] (03PS1) 10Eileen: Move our handling for the {now.MMMM} token to our custom token processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726992 [23:08:30] (03PS4) 10Eileen: Remove field default for mailing_provider_data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726736 [23:08:57] cstone: are you OK to +2 this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/726736 - just means if Tim tries to use our code again he can on mysql (rather than mariadb) [23:09:48] sure eileen [23:10:45] is it weird that one wont have a default? [23:14:49] (03PS1) 10Eileen: 5.43 alpha latest [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/726994 [23:15:37] eileen: just a quick question ^ [23:15:55] it's a required field isn't it? [23:16:19] ah okay that makes sense then [23:16:31] I'm not gonna change it on live - [23:16:43] it's just that I'd like our dev to load for him [23:16:47] ah okie [23:17:00] (03CR) 10Cstone: [C: 03+2] Remove field default for mailing_provider_data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726736 (owner: 10Eileen) [23:17:07] thanks [23:17:56] cstone: the other easy one is this - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/726727 - because it's really just a reminder that we had to add that permission - I doubt it impacts anything locally :-) [23:20:05] (03PS5) 10Eileen: Add translate permission [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726727 [23:23:42] (03CR) 10Cstone: [C: 03+2] Add translate permission [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726727 (owner: 10Eileen) [23:23:47] cstone: oh one more - looks like there is a searchkit sorting fix that wasn't in yesterday's civi update - it's here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/726994 along with some enotice fixes (note that the rc should be cut today or tomorrow - after which I would only port patches not the latest tarball unless things are merged to the rc) [23:24:32] ah okay [23:28:34] (03Merged) 10jenkins-bot: Remove field default for mailing_provider_data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726736 (owner: 10Eileen) [23:33:24] (03CR) 10Cstone: [C: 03+2] 5.43 alpha latest [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/726994 (owner: 10Eileen) [23:34:00] (03PS2) 10Eileen: Move our handling for the {now.MMMM} token to our custom token processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726992 [23:34:02] (03PS12) 10Eileen: Install translated versions on recurring failed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/725182 [23:34:04] (03PS6) 10Eileen: Add translate permission [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726727 [23:34:24] (03PS7) 10Eileen: Add translate permission [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726727 [23:43:45] (03CR) 10Eileen: [V: 03+2] Add translate permission [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726727 (owner: 10Eileen) [23:44:18] (03PS13) 10Eileen: Install translated versions on recurring failed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/725182 [23:44:20] (03PS3) 10Eileen: Move our handling for the {now.MMMM} token to our custom token processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/726992 [23:46:24] (03CR) 10jerkins-bot: [V: 04-1] Install translated versions on recurring failed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/725182 (owner: 10Eileen) [23:48:48] (03Merged) 10jenkins-bot: 5.43 alpha latest [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/726994 (owner: 10Eileen)