[00:04:51] Sounds like it might be worth keeping the meeting for that. [00:12:58] cstone sure, I guess so [00:18:51] (03PS2) 10Ejegg: DO NOT MERGE bogus way to trigger 422 error [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/727009 (https://phabricator.wikimedia.org/T290923) [00:20:14] (03CR) 10jerkins-bot: [V: 04-1] Adyen Checkout: catch validation exceptions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/727012 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [00:23:33] (03PS3) 10Ejegg: Adyen Checkout: catch validation exceptions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/727012 (https://phabricator.wikimedia.org/T290923) [00:26:02] 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10FR-Adyen, 10Patch-For-Review: Adyen Checkout: Show validation errors and allow resubmit for appropriate API error codes - https://phabricator.wikimedia.org/T290923 (10Ejegg) Combined, https://gerrit.wikimedia.org/r/727012 and https:... [00:26:15] (03CR) 10jerkins-bot: [V: 04-1] Adyen Checkout: catch validation exceptions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/727012 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [00:26:29] thphphphphphbt [00:27:50] (03PS4) 10Ejegg: Adyen Checkout: catch validation exceptions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/727012 (https://phabricator.wikimedia.org/T290923) [01:19:55] (03PS1) 10Ejegg: Remove all address fields for Apple Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/727675 [01:21:08] ejegg|away: thphphphphp7.4? [01:23:34] more Bill the Cat than Zend... [01:24:55] https://i.ebayimg.com/images/g/82oAAOSw3xJVV29K/s-l300.jpg [01:38:38] omg, 'apple pay has been disabled because the security settings of this mac have been modified' [01:38:42] WTFWTFWTFWTF [01:39:12] i spent hours trying to figure out why the dang button wasn't working, and now i see ^^^ in the wallet settings [01:39:39] suggests installing security updates and restarting [01:45:43] so is the web page developer supposed to catch that? [01:45:53] or they just let ppl's stores look broken [01:58:50] ejegg awww dang who knows eh? [01:59:11] so, Bill the Zend? [02:17:08] oh fun, looks like safari requires access-control-allow-origin now too... [02:17:17] was that just in the safari 15 update? [02:34:32] (03PS5) 10Ejegg: Apple Pay: onValidateMerchant handler [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/720127 (https://phabricator.wikimedia.org/T290108) [02:44:32] (03CR) 10Ejegg: Get Apple Pay session from Apple (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/720126 (https://phabricator.wikimedia.org/T290108) (owner: 10Ejegg) [02:51:58] (03CR) 10Krinkle: [C: 03+2] Merge single use dependencies into ext.centralNotice.adminUi [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/724983 (https://phabricator.wikimedia.org/T221805) (owner: 10DannyS712) [02:55:01] (03Merged) 10jenkins-bot: Merge single use dependencies into ext.centralNotice.adminUi [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/724983 (https://phabricator.wikimedia.org/T221805) (owner: 10DannyS712) [02:55:20] (03PS6) 10Ejegg: Apple Pay: onValidateMerchant handler [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/720127 (https://phabricator.wikimedia.org/T290108) [02:56:09] (03CR) 10Ejegg: Get Apple Pay session from Apple (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/720126 (https://phabricator.wikimedia.org/T290108) (owner: 10Ejegg) [11:19:50] wow looked like ejegg|away had fun with Apple Pay last night [11:20:22] 4xWTF levels of frustration [11:45:24] 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10FR-Adyen, 10Patch-For-Review: Adyen Checkout: Show validation errors and allow resubmit for appropriate API error codes - https://phabricator.wikimedia.org/T290923 (10jgleeson) Just noticed another one ` {"status":422,"errorCode":"... [12:40:15] 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo, and 2 others: Switch over to using WMF-generated certificates with Adyen Apple Pay - https://phabricator.wikimedia.org/T290108 (10jgleeson) [13:05:04] 10Fundraising-Backlog, 10FR-Ingenico: Swedish donations stuck at status 600 - https://phabricator.wikimedia.org/T246710 (10jgleeson) Hi folks, we've got a few questions this week :) is anyone around to join the call from the Adyen side? Thanks! Title: Adyen : Wikimedia Placeholder for technical call Whe... [14:30:30] damilare: I'm back. lemme know when is good for you and I'll jump on today's invite from earlier [14:50:48] Hi jgleeson, we can have the call now if you're available [14:51:23] sure! joining now [15:44:25] 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10FR-Adyen, 10Patch-For-Review: Adyen Checkout: Show validation errors and allow resubmit for appropriate API error codes - https://phabricator.wikimedia.org/T290923 (10AndyRussG) >>! In T290923#7411926, @jgleeson wrote: > Just notice... [15:48:12] AndyRussG: just saw your comment... and the only place I can think we can play with the currency is in the URL params? [15:48:46] jgleeson: hmmm right... so maybe in that case it was our mistake trying to send someone to Adyen when we shouldn't? [15:48:52] let's see if we can find what the currency was in logs [15:49:08] I wonder if it was maybe one of us, or someone else on the Advancement side, just testing? [15:49:16] hmm maybe AndyRussG although I had it in my head that the formchooser handles that bit [15:49:21] ah maybe [15:49:37] right so maybe a formchooser bug [15:49:58] still not a case where we can send the donor back to the form to retry, no=? [15:50:21] yeah agreed on that, it feels like we should be handling that earlier in the process [15:52:10] AndyRussG: the currency was XPD... [15:52:15] isn't that crypto [15:52:46] ok this donations looks a bit iffy [15:52:49] donation* [15:53:32] ah so not crypto but Palladium [15:53:37] XPDUSD [15:54:17] https://en.wikipedia.org/wiki/Palladium#Palladium_as_investment [15:54:35] yeah for sure fishy [15:57:28] (03PS1) 10Cstone: Reset the accidentally cancelled ideal recurrings during the token update when switching from Adyen to Adyen Checkout [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/728556 (https://phabricator.wikimedia.org/T277120) [16:00:12] AndyRussG: so on payments if I modify the URL params that GatewayFormChooser sends me to by adding that currency symbol it still loads the Adyen form [16:00:56] https://payments.wikimedia.org/index.php?title=Special:AdyenCheckoutGateway&appeal=JimmyQuote&ffname=cc-vmaj&recurring=false&payment_method=cc&country=GB&uselang=en-gb&amount=2&opt_in=0&utm_medium=spontaneous&utm_campaign=spontaneous&utm_source=fr-redir.default~default~default~default~control.cc&utm_key=vw_1541~vh_769~otherAmt_0~time_14¤cy=XPD [16:01:26] but if I try the same shenanigans on ingenico it doesn't allow it [16:01:40] https://payments.wikimedia.org/index.php?title=Special:IngenicoGateway&appeal=JimmyQuote&ffname=cc-vmaj&recurring=false&payment_method=cc&country=GB&uselang=en-gb&amount=2&opt_in=0&utm_medium=spontaneous&utm_campaign=spontaneous&utm_source=fr-redir.default~default~default~default~control.cc&utm_key=vw_1541~vh_769~otherAmt_0~time_14¤cy=XPD [16:01:54] so you're right we should be handling that I think [16:04:31] (03CR) 10jerkins-bot: [V: 04-1] Reset the accidentally cancelled ideal recurrings during the token update when switching from Adyen to Adyen Checkout [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/728556 (https://phabricator.wikimedia.org/T277120) (owner: 10Cstone) [16:23:03] 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10acl*WMF-FR: Possible XSS testing - https://phabricator.wikimedia.org/T292856 (10XenoRyet) [16:25:58] (03PS2) 10Cstone: Reset the accidentally cancelled ideal recurrings during the token update when switching from Adyen to Adyen Checkout [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/728556 (https://phabricator.wikimedia.org/T277120) [16:49:07] (03PS3) 10Cstone: Reset the accidentally cancelled ideal recurrings during the token update when switching from Adyen to Adyen Checkout [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/728556 (https://phabricator.wikimedia.org/T277120) [17:22:37] 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10MediaWiki-extensions-DonationInterface, 10MW-1.38-notes (1.38.0-wmf.3; 2021-10-05): Make it possible to turn off post-payments monthly convert by URL parameter - https://phabricator.wikimedia.org/T291507 (10Pcoombe) Just tested this... [17:39:24] (03CR) 10Jgleeson: [C: 03+2] "Looks good to me. We reviewed this live on our call and the fix makes sense. Thanks much!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/728556 (https://phabricator.wikimedia.org/T277120) (owner: 10Cstone) [17:54:43] (03Merged) 10jenkins-bot: Reset the accidentally cancelled ideal recurrings during the token update when switching from Adyen to Adyen Checkout [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/728556 (https://phabricator.wikimedia.org/T277120) (owner: 10Cstone) [17:57:50] (03PS1) 10Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/728580 [18:01:07] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/728580 (owner: 10Cstone) [18:15:19] !log civicrm revision changed from 5cb7d487cb to 598b59b0ee [18:15:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log