[00:05:31] (03Merged) 10jenkins-bot: Add temporary debug statement [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/730134 (https://phabricator.wikimedia.org/T244811) (owner: 10Eileen) [00:06:54] (03CR) 10Eileen: [C: 03+2] "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730135 (owner: 10Eileen) [00:07:28] (03Merged) 10jenkins-bot: Submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730135 (owner: 10Eileen) [00:08:33] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/730136 [00:08:45] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/730136 (owner: 10Eileen) [00:11:53] !log civicrm revision changed from 598b59b0ee to 96090e4bd2, config revision is 85277466ed [00:12:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:22:22] (03PS1) 10Eileen: Fix for forgetme not working [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/730137 (https://phabricator.wikimedia.org/T244811) [00:22:34] AndyRussG: I think I have the fix ^^ [00:29:05] eileen: oh that's a pretty small fix... in a bunch of code I don't understand hehehe [00:29:27] AndyRussG: yeah :-) - it gets validated as a string & NULL fails [00:30:08] how about I try to read over the Phab task and the surrounding code... then if it still seems very mysterious I could bug u with questions or if needed do a video call? [00:31:21] This is in the general CiviCRM ORM code, no? So this is a bug in core Civi that later you'd want to upstream, I imagine? [00:31:22] AndyRussG: yeah - the key thing is that in `composeQuery` it checks that value against the type (String) [00:31:50] yeah - upstream PR https://github.com/civicrm/civicrm-core/pull/21799 [00:55:46] eileen: so what is the expected result when $targetDao->$targetColumn is null? maybe it'd be cleaner to leave out $params in that case? [00:56:51] AndyRussG: I think it wouldn't find anything - there are probably a bunch of alternatives that would do roughly the same thing [00:58:54] right [00:59:42] just that in single value query the default value for $params is [] [01:00:17] and I imagine that that's what the code is expecting to get through when there are no params to add to the query [01:00:59] and so not sending any $params in seems to be the correct way to signal to singleValueQuery() that there are none [01:01:08] yeah - probably we could also do an early return - whatever gets agreed upstream will be the final variant :-) [01:01:40] params is what is interpolated into the query - we'd have to remove the %1 from the query if we don't send in params [01:02:12] and the internally that functions and other stuff in DAO.php would have in its scope knowing how to construct the query with no params [01:02:15] oh hmmm [01:03:12] ah I see I was understanding params as something different [01:03:47] huh so wait shouldn't it throw an error if there's no target column? [01:05:31] K looking at the backtrace [01:11:20] AndyRussG: so it's looking for places where a contact has a row in another table. In most places the join is on a field like an id so we get away with string [01:11:39] in this case it's joining on a name column and this specific contact has no name [01:11:48] & the value in the column is NULL [01:12:17] so it's putting NULL in the sql query where it should be putting in a string [01:13:37] in fact it might be better to skip the query altogether if null [01:15:24] ok [01:15:59] so $targetDao->$targetColumn gives the value of the column [01:16:07] not the column's name [01:16:09] right [01:17:03] eileen: or what about when the value of the column is null, making the SQL check for IS NULL then? [01:17:23] I recently tripped on a thing like that in a different SQL dialect [01:17:36] yeah - I think we actually want to skip the query altogether tbh [01:18:17] oki sounds better indeed [01:18:32] (in case you're curious, https://stackoverflow.com/a/5658472/1165940) [01:19:32] (03PS2) 10Eileen: Fix for forgetme not working [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/730137 (https://phabricator.wikimedia.org/T244811) [01:20:48] eileen: cool! [01:21:42] if you'd like to smoke test, and are sure of no nefarious side-effects, I'll +2... or would you rather smoke test on staging? [01:21:59] This is for the error you got for the command in the comment right before the backtrace, yee? [01:26:06] yeah I think the return of 0 makes it safe [01:26:19] ie it's looking to see if there are any related bits of data to delete [01:27:43] hmm - we really want it to never delete from that table - although the risk is low & ditto the consequences if we do (since it only holds Japanese surnames) [01:29:14] hmmm which table (sorry I didn't get through reading the whole bug)... also isn't this a Civi core thing that would be used I imagine for many different stuff? [01:29:49] (03CR) 10jerkins-bot: [V: 04-1] Fix for forgetme not working [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/730137 (https://phabricator.wikimedia.org/T244811) (owner: 10Eileen) [01:29:52] so the table in question is one of ours & we have a kinda odd way of declaring the join to work for search kit - which seems to be causing an issue here [01:33:53] many apologies for holding this up with all these silly questions... so which table is it? and how do we know that the changes in Basic.php will only impact on what we'd do with that table? sorry I'm sure I'm missing tons of stuff [01:34:09] the code itself in that patchset seems completely sane and if you're sure about it I'm happy to +2 [01:34:26] just thinking it'd be nice to understand better the context and possible side effects [01:36:24] AndyRussG: yeah it's pretty deep in [01:36:57] & tbh it would be more useful to get the import one out - I thought that was an easy one but it was deceptive [01:42:16] eileen: it's your call I think :) I can +2 the forget-me one, or I can dig in to try to understand it more first, or we could also let it sit to see if there's any more feedback from other Civi devs, in which case I could turn to the import one? whatever you think works best is cool [01:43:24] AndyRussG: I think I'm just going to think about it a bit longer - I'm happy with the change - but I just want to think about why it's looking up that join in the first place - let's punt that one to tomorrow [01:43:54] oki sounds good! [02:01:17] eileen: so it's that patch (https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/730083) and the preceding one (https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/730049) but the one before that is unrelated, correct? [02:02:19] AndyRussG: yeah so there are 2 before it - the first one is only related in that it was what I figured out while figuring out what to do about the other - but the relationship types one is needed to make it work on your local [02:03:03] the first & second patch are both about local dev environments but first could be rebased out of the chain [02:03:28] live has relationship types configured currently missing from dev (I only added the somewhat relevant ones) [02:07:24] (03CR) 10DannyS712: [C: 03+2] MediaWikiTestCase -> MediaWikiIntegrationTestCase [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730094 (https://phabricator.wikimedia.org/T293043) (owner: 10Zabe) [02:08:05] (03CR) 10DannyS712: [C: 03+2] MediaWikiTestCase -> MediaWikiIntegrationTestCase [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/730085 (https://phabricator.wikimedia.org/T293043) (owner: 10Zabe) [02:10:21] eileen: ok thanks so I should pull down the whole chain and rebuild, no? [02:10:47] AndyRussG: yeah probably - you could rebase out the first one if you aren't comfortable with it [02:11:24] hmmm [02:41:55] eileen: well the code looks clean... if you feel it's a productive use of time, I guess I could use some further explanations [02:42:08] ok sure [02:42:13] happy to jump on a call [02:43:59] eileen: ok thanks! I'm here: https://meet.google.com/pau-rggj-byc [02:57:51] (03PS3) 10Eileen: Add donor advised relationship types to our dev installs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730049 (https://phabricator.wikimedia.org/T286520) [03:10:39] (03Merged) 10jenkins-bot: MediaWikiTestCase -> MediaWikiIntegrationTestCase [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730094 (https://phabricator.wikimedia.org/T293043) (owner: 10Zabe) [03:10:43] (03CR) 10jerkins-bot: [V: 04-1] MediaWikiTestCase -> MediaWikiIntegrationTestCase [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/730085 (https://phabricator.wikimedia.org/T293043) (owner: 10Zabe) [03:25:14] (03PS4) 10Eileen: Add donor advised relationship types to our dev installs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730049 (https://phabricator.wikimedia.org/T286520) [03:25:16] (03PS3) 10Eileen: Add support for importing donor advised fund owners [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730083 (https://phabricator.wikimedia.org/T286520) [03:27:02] (03CR) 10DannyS712: [C: 03+2] "Resubmit" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/730085 (https://phabricator.wikimedia.org/T293043) (owner: 10Zabe) [03:30:07] (03Merged) 10jenkins-bot: MediaWikiTestCase -> MediaWikiIntegrationTestCase [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/730085 (https://phabricator.wikimedia.org/T293043) (owner: 10Zabe) [03:35:59] (03PS4) 10Eileen: Add support for importing donor advised fund owners [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730083 (https://phabricator.wikimedia.org/T286520) [03:50:24] (03PS5) 10Eileen: Add support for importing donor advised fund owners [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730083 (https://phabricator.wikimedia.org/T286520) [03:52:48] (03PS6) 10Eileen: Add support for importing donor advised fund owners [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730083 (https://phabricator.wikimedia.org/T286520) [03:53:35] (03PS7) 10Eileen: Add support for importing donor advised fund owners [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730083 (https://phabricator.wikimedia.org/T286520) [04:08:51] (03CR) 10AndyRussG: [C: 03+2] "Yaaaayy cool!!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730049 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [04:09:23] (03CR) 10AndyRussG: [C: 03+2] "Fantastic!! :) :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730083 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [04:19:38] (03Merged) 10jenkins-bot: Add donor advised relationship types to our dev installs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730049 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [04:20:50] (03Merged) 10jenkins-bot: Add support for importing donor advised fund owners [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730083 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [04:39:40] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/730140 [04:40:07] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/730140 (owner: 10Eileen) [04:43:41] !log civicrm revision changed from 96090e4bd2 to 946dfb6c5a, config revision is 85277466ed [04:43:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:46:26] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, and 3 others: Would it be possible to have an 'Owns the Donor Advised Fund' field that would link that Individual to their DAF? - https://phabricator.wikimedia.org/T286520 (... [05:07:22] (03PS1) 10AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/730141 [05:17:28] (03CR) 10AndyRussG: [C: 03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/730141 (owner: 10AndyRussG) [05:27:43] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/730141 (owner: 10AndyRussG) [05:32:16] (03PS8) 10AndyRussG: Adyen Checkout: Don't add (hidden) submethod button elements [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/718941 (https://phabricator.wikimedia.org/T290103) [13:00:00] 10Fundraising-Backlog, 10fr-donorservices, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): "No App" error from monthly convert on mobile - https://phabricator.wikimedia.org/T291199 (10MBeat33) Thank you @Dbrant [14:29:56] hi fr-tech [14:30:50] ejegg fr-tech hiiii! [14:31:02] anyone looking into the monthly charge fails yet? [14:31:19] not I... [14:31:31] looking [14:32:09] oh, it's another too-frequent charge, probs a cstone donation. looking [14:33:09] hah, no, one of mine [14:33:13] ok, will just acancel it [14:34:32] k, that should let us keep running [14:36:35] fr-tech, is anyone able to review these patches to tamp down the adyen failmail? [14:36:40] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/726943 [14:36:46] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/727012 [14:37:11] I can jump on a call in the next few min if you want me to talk you through it [14:37:29] (at least till the baby wakes up from her nap) [14:38:00] ejegg yeee certainly I can in a few [14:40:19] hi AndyRussG ejegg fr-tech :) [14:41:09] hi jgleeson ! [14:41:49] (03CR) 10Damilare Adedoyin: [C: 03+2] "Following our conversation last night, this looks good to me. Thanks AndyRussG for making the recommended changes." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/718941 (https://phabricator.wikimedia.org/T290103) (owner: 10AndyRussG) [14:42:31] (03CR) 10Paladox: "Needs rebasing." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/266064 (https://phabricator.wikimedia.org/T108259) (owner: 10MtDu) [14:43:56] (03Merged) 10jenkins-bot: Adyen Checkout: Don't add (hidden) submethod button elements [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/718941 (https://phabricator.wikimedia.org/T290103) (owner: 10AndyRussG) [14:45:27] nice job damilare! [14:49:20] Thanks jgleeson [14:51:09] heyy yeee ty damilare :) [14:51:36] ejegg: available for a call anytime now if u wish [14:59:23] AndyRussG: meet.google.com/ymj-ipvu-pbw [15:00:28] oki! one sec :) [15:08:39] Hey fr-tech: What's the status on ApplePay? I've got a meeting with Jessica and Pats in an hour and I'm sure they'll ask. [15:09:07] XenoRyet: waiting for CR on a few patches [15:10:03] 10Fundraising-Backlog, 10fundraising-tech-ops: Current Engage Civi User Needs Additional Certificate - https://phabricator.wikimedia.org/T292649 (10MDemosWMF) @Dwisehaupt they are all setup on the new computer, thank you!! [15:16:19] Cool, so if we're guessing at when it might go to production, this week sometime? [15:39:30] Hi fr-tech [15:56:17] hey cstone ! [15:59:05] XenoRyet: it feels like this week would be kinda soon, given stuff in the review and it's still kinda rough around the edges [15:59:20] that's a very rough guesstimate, and another one would be, possibly next week [16:00:10] if it sounds reasonable, possibly a good way to spend the next few hours might be looking at the status of all the patches to get a better idea of where AP is at, ahead of sprink planning? [16:00:35] Yea, that sounds good. [16:01:10] can we maybe get that failmail quieted down first? [16:08:55] ejegg: jgleeson and I still on the call if you want to talk through that more, we had a few more ideas about how to approach that [16:09:42] I feel that if we take the time to talk through all the options we can get a cleaner approach out pretty quickly, though probably not right now [16:10:48] in another mtg, want to comment on the ticket or just put up another PS? [16:18:16] ejegg: oki! we were also thinking it could be discussed in tech-talk tomorrow, but I can also try that... jgleeson ^ [16:19:06] it does feel like it would probably be quicker to talk through, show on screen and record (if we wanted to preserve it). It might take a little bit longer to explain on gerrit as it covers two codebases I think? [16:19:12] AndyRussG: ejegg ^ [16:19:43] ah also good point [16:19:44] ok, i'll get back on that call when this mtg is over [16:19:55] ejegg ahh we're not on the call now 8p [16:20:01] is it really that urgent? [16:20:29] I'm gonna step away form the keyboard for a bit before my 1:1 in 10 minutes so can talk after that if that helps! [16:20:32] back soon [16:21:00] * AndyRussG is also available to get back on a call, now or later of course [16:38:12] (03PS1) 10Ejegg: Add ES versions of Monthly Convert second thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730246 (https://phabricator.wikimedia.org/T292542) [16:38:59] AndyRussG: i don't know about you, but it's stressful to me to keep getting so many failmails! [16:39:10] I have to check each one to make sure it's not something new broken [16:39:22] so I really really really want to make them stop [16:42:58] ejegg: right I do understand :) K I can try to get up a proposed patch by the upcoming meeting? or also available for a call whenever u like [16:55:20] ok, back, I can hop back in that call AndyRussG [16:56:04] ejegg: oki one sec, just finishing a patch to push out the CN deploy (late, but thankfully got some leeway from train deployer :) ) [16:56:49] oh, thanks for doing that [16:57:32] ahhh I should not have missed the deadline yesterday [17:05:38] grr, PayPal ipnpb failures [17:06:53] :( [17:08:11] I think we get rescued by the audit processor on those ejegg right? [17:08:50] jgleeson: yep, or maybe they even re-send the notifications when we respond with a 500 error [17:09:14] I wouldn't bet on the latter +_+ [17:09:31] oh, amazon and adyen say they do that anyway [17:10:12] sorry I have idea. I guess I'm just flinging some muck at paypal unfairly [17:11:01] gonna grab dinner [17:29:30] (03PS1) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730253 [17:29:32] (03PS1) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730254 [17:29:36] (03PS1) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730255 [17:29:42] (03PS1) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730256 [17:29:48] (03PS1) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730257 [17:29:54] (03PS1) 10AndyRussG: build: Updating npm dependencies [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730258 [17:30:00] (03PS1) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730259 [17:30:06] (03PS1) 10AndyRussG: Only filter for user if the given username is valid [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730260 (https://phabricator.wikimedia.org/T292639) [17:30:16] (03PS1) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730261 [17:30:22] (03PS1) 10AndyRussG: Avoid writing empty prioritylangs rows to translate_metadata [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730262 (https://phabricator.wikimedia.org/T204026) [17:30:28] (03PS1) 10AndyRussG: Merge single use dependencies into ext.centralNotice.adminUi [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730263 (https://phabricator.wikimedia.org/T221805) [17:30:34] (03PS1) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730264 [17:30:40] (03PS1) 10AndyRussG: MediaWikiTestCase -> MediaWikiIntegrationTestCase [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730265 (https://phabricator.wikimedia.org/T293043) [17:36:59] (03Abandoned) 10AndyRussG: MediaWikiTestCase -> MediaWikiIntegrationTestCase [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730265 (https://phabricator.wikimedia.org/T293043) (owner: 10AndyRussG) [17:37:06] (03Abandoned) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730264 (owner: 10AndyRussG) [17:37:12] (03Abandoned) 10AndyRussG: Merge single use dependencies into ext.centralNotice.adminUi [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730263 (https://phabricator.wikimedia.org/T221805) (owner: 10AndyRussG) [17:37:18] (03Abandoned) 10AndyRussG: Avoid writing empty prioritylangs rows to translate_metadata [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730262 (https://phabricator.wikimedia.org/T204026) (owner: 10AndyRussG) [17:37:25] (03Abandoned) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730261 (owner: 10AndyRussG) [17:37:32] (03Abandoned) 10AndyRussG: Only filter for user if the given username is valid [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730260 (https://phabricator.wikimedia.org/T292639) (owner: 10AndyRussG) [17:37:39] (03Abandoned) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730259 (owner: 10AndyRussG) [17:37:44] (03Abandoned) 10AndyRussG: build: Updating npm dependencies [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730258 (owner: 10AndyRussG) [17:37:49] (03Abandoned) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730257 (owner: 10AndyRussG) [17:38:00] (03Abandoned) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730256 (owner: 10AndyRussG) [17:38:05] (03Abandoned) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730255 (owner: 10AndyRussG) [17:38:11] (03Abandoned) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730254 (owner: 10AndyRussG) [17:38:16] (03Abandoned) 10AndyRussG: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (wmf/1.38.0-wmf.4) - 10https://gerrit.wikimedia.org/r/730253 (owner: 10AndyRussG) [17:49:10] 10Fundraising-Backlog, 10fundraising-tech-ops: Current Engage Civi User Needs Additional Certificate - https://phabricator.wikimedia.org/T292649 (10Dwisehaupt) 05Open→03Resolved [17:53:19] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Janna Layton - https://phabricator.wikimedia.org/T292222 (10Dwisehaupt) [17:54:17] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Janna Layton - https://phabricator.wikimedia.org/T292222 (10Dwisehaupt) 05Open→03Resolved Verified cert and login working. [18:07:24] 10Fundraising-Backlog: Wikimedia NOT accepting notifications for Adyen - https://phabricator.wikimedia.org/T292766 (10EMartin) I have reopened this task due to the fact that there seems to be some sort of configuration at Adyen to prompt for notifications when such an event occurs. I had a look to see if I coul... [18:11:56] 10Fundraising-Backlog: Wikimedia NOT accepting notifications for Adyen - https://phabricator.wikimedia.org/T292766 (10EMartin) 05Resolved→03Open Reopening this as there seems to be a config element to this at Adyen for notifications. I attempted to populate this form but it is asking for listener informatio... [18:18:20] ejegg|food: K back from unjustifiedly disturbing the friendly and very patient train deployers [18:18:33] and also from resolving a unexpected situation here with the neighbours [18:26:07] 10Fundraising-Backlog, 10Wikimedia-Fundraising-Banners: Check on FY2021 Japan Banner History - https://phabricator.wikimedia.org/T292927 (10EYener) Thanks @Pcoombe - it's interesting though that we're not seeing anything sampled at 100% at that time. Here is a hive query to show the issue beginning after the 1... [18:26:30] I'm about also but currently drafting an email for the team [18:26:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-Banners: Check on FY2021 Japan Banner History - https://phabricator.wikimedia.org/T292927 (10EYener) Better formatting on that query: `SELECT day, count(event.i) AS cn_log_id_count FROM event_sanitized.centralnoticebannerhistory WHERE year = 2020 AND month =... [18:30:18] AndyRussG: ok, i'mma hop back in that same call [18:32:53] ejegg: oki :) [18:51:44] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen: recent 'MediaWiki internal error - fatal exception' errors - https://phabricator.wikimedia.org/T293131 (10MBeat33) [18:51:58] 10Fundraising-Backlog, 10Wikimedia-Fundraising-Banners: Check on FY2021 Japan Banner History - https://phabricator.wikimedia.org/T292927 (10Pcoombe) Can you clarify what we're missing? I think the sampling rate has always been intended as 1%, and that's what it was set at for both of those campaigns. [19:04:29] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Screaming Goats Yelling Zoo: Campaign Notification list - https://phabricator.wikimedia.org/T289478 (10XenoRyet) 05Open→03Resolved [19:06:25] 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo, and 2 others: Recurring for apple pay through adyen - https://phabricator.wikimedia.org/T290106 (10XenoRyet) 05Open→03Resolved [19:06:51] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 5 others: Create new WMF donor fields - https://phabricator.wikimedia.org/T288721 (10XenoRyet) 05Open→03Resolved [19:06:53] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint onion pit, 10Patch-For-Review: Wmf-donor - new year fields - https://phabricator.wikimedia.org/T280595 (10XenoRyet) [19:08:45] (03PS1) 10Ejegg: Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) [19:10:54] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Legø Trampoline, and 3 others: Would it be possible to have an 'Owns the Donor Advised Fund' field that would link that Individual to their DAF? - https://phabricator.wikimedia.org/T286520 (... [19:11:34] (03CR) 10jerkins-bot: [V: 04-1] Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [19:11:48] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 6 others: Adyen Checkout: normalize API error codes - https://phabricator.wikimedia.org/T283307 (10Ejegg) 05Open→03Resolved [19:11:50] 10Fundraising-Backlog, 10FR-Adyen, 10Epic: Epic: Adyen reintegration, Drop In Web - https://phabricator.wikimedia.org/T277120 (10Ejegg) [19:15:03] 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo: Spanish Monthly Convert for the US / Does es-419 fall back to es? - https://phabricator.wikimedia.org/T291993 (10XenoRyet) 05Open→03Resolved [19:20:18] 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10MediaWiki-extensions-DonationInterface, 10MW-1.38-notes (1.38.0-wmf.3; 2021-10-05): Make it possible to turn off post-payments monthly convert by URL parameter - https://phabricator.wikimedia.org/T291507 (10XenoRyet) 05Open→03Res... [19:20:56] 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo, 10FR-Adyen, 10Patch-For-Review: Set up new fr-dev staging server for Apple Pay - https://phabricator.wikimedia.org/T291577 (10XenoRyet) 05Open→03Resolved [19:33:05] (03PS1) 10Zabe: MediaWikiTestCase -> MediaWikiIntegrationTestCase [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/730310 (https://phabricator.wikimedia.org/T293043) [19:49:17] (03PS2) 10Ejegg: Deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) [19:51:32] (03CR) 10jerkins-bot: [V: 04-1] Deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [19:53:21] 10Fundraising-Backlog: Figure out what to do with OFFER_CLOSED Adyen ipn messages - https://phabricator.wikimedia.org/T292475 (10Cstone) 05Open→03Resolved a:03Cstone [19:59:29] 10fundraising-tech-ops: fundraising tech operations GDPR tracking task - https://phabricator.wikimedia.org/T226749 (10Ejegg) [19:59:31] 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo, and 2 others: simplify download UI for the donor data delivery tool - https://phabricator.wikimedia.org/T285881 (10Ejegg) 05Open→03Resolved [20:06:27] (03PS3) 10Ejegg: Deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) [20:08:00] (03CR) 10jerkins-bot: [V: 04-1] Deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [20:17:48] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-Banners: Check on FY2021 Japan Banner History - https://phabricator.wikimedia.org/T292927 (10XenoRyet) [20:17:50] 10Fundraising Sprint T 2021, 10Fundraising-Backlog: Unable to add contacts to a group via search kit - https://phabricator.wikimedia.org/T292784 (10XenoRyet) [20:17:54] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Patch-For-Review: Production of Upsell Thank You email in Spanish-LATAM - https://phabricator.wikimedia.org/T292542 (10XenoRyet) [20:17:59] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo: Unable to download the query data - Rakhi Fraud Scan - https://phabricator.wikimedia.org/T292370 (10XenoRyet) [20:18:01] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Send donor info to Adyen for iDEAL and Apple Pay - https://phabricator.wikimedia.org/T292271 (10XenoRyet) [20:18:06] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10MediaWiki-extensions-CentralNotice: Help unblock Language team - https://phabricator.wikimedia.org/T292008 (10XenoRyet) [20:18:10] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10fr-donorservices: Clean up new adyen ideal recurrings - https://phabricator.wikimedia.org/T291712 (10XenoRyet) [20:18:14] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo: Apple Pay: Prevent flash of normal blue donate button before branded button appears - https://phabricator.wikimedia.org/T291143 (10XenoRyet) [20:18:18] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10FR-Adyen, 10Patch-For-Review: Adyen Checkout: Show validation errors and allow resubmit for appropriate API error codes - https://phabricator.wikimedia.org/T290923 (10XenoRyet) [20:18:20] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog, 10fundraising sprint Roller Toaster, and 3 others: Switch over to using WMF-generated certificates with Adyen Apple Pay - https://phabricator.wikimedia.org/T290108 (10XenoRyet) [20:18:25] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo: sprint goal: deploy apple pay and begin the 600/800 task - https://phabricator.wikimedia.org/T290107 (10XenoRyet) [20:18:27] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog, 10fundraising sprint Roller Toaster, and 3 others: Adyen Checkout: Remove flash of unused card type selection buttons - https://phabricator.wikimedia.org/T290103 (10XenoRyet) [20:18:29] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 15 others: Fix civicrm repo to be non-symlinked - https://phabricator.wikimedia.org/T289100 (10XenoRyet) [20:19:18] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint Quantum Leapfrog, and 5 others: Adyen Checkout: Pull donor contact from Apple Pay sheet - https://phabricator.wikimedia.org/T285722 (10XenoRyet) [20:19:25] 10Fundraising Sprint Mandatory corn dogs, 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, and 5 others: Adyen Checkout: create new recurring iDEAL donations - https://phabricator.wikimedia.org/T284606 (10XenoRyet) [20:19:27] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog, 10fundraising sprint Roller Toaster, and 2 others: Epic: Automatically send status 800 on prior donors stopped at 600 - https://phabricator.wikimedia.org/T276183 (10XenoRyet) [20:19:30] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo, 10FR-Smashpig: Add RiskScorer for Ingenico to SmashPig - https://phabricator.wikimedia.org/T291230 (10XenoRyet) [20:19:32] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo: Update PaymentsInitQueueConsumer to leave FAILED/REJECTED pending rows for Ingenico - https://phabricator.wikimedia.org/T291228 (10Xen... [20:19:34] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo: Add existing donor matching to PendingTransaction::resolve - https://phabricator.wikimedia.org/T291226 (10XenoRyet) [20:19:41] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Roller Toaster, and 2 others: Add PendingTable::Consume API call that implements pending resolver outer loop - https://phabricator.wikimedia.org/T291225 (10XenoRyet) [20:19:56] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Roller Toaster, and 2 others: Add PendingTransaction::resolve API call that replicates Ingenico orphan rectifier - https://phabricator.wikimedia.org/T291223 (10XenoRyet) [20:20:00] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo, and 2 others: Civi: Auto Recurring Fail email, batch of copy corrections - https://phabricator.wikimedia.org/T289617 (10XenoRyet) [20:20:03] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10fundraising sprint Parallel processing roller coaster, 10fundraising sprint Quantum Leapfrog, and 2 others: Catch Adyen Checkout API errors on the DI side - https://phabricator.wikimedia.org/T288830 (10XenoRyet) [20:20:06] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, and 4 others: Review upstream PRs related to contracted token work - https://phabricator.wikimedia.org/T288698 (10XenoRyet) [20:20:08] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, and 5 others: update the docs on the civi-acoustic import and export scripts - https://phabricator.wikimedia.org/T286934 (10XenoRyet) [20:20:13] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 4 others: Would it be possible to have an 'Owns the Donor Advised Fund' field that would link that Individual to their DAF? - https://phabricator.wikimedia.org/T286520 (10XenoRye... [20:20:17] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Parallel processing roller coaster, and 4 others: Search kit links not loading when sharing out to Engage - https://phabricator.wikimedia.org/T279686 (10XenoRyet) [20:20:23] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 16 others: Update Fundraising tech CI image to use upstream buildkit, no symlink for civ... - https://phabricator.wikimedia.org/T277500 [20:20:34] 10Fundraising Sprint Nitpicking, 10Fundraising Sprint Octopus Untangling, 10Fundraising Sprint Pretending This Isn't Happening, 10Fundraising Sprint T 2021, and 6 others: Documentation: UML activity and sequence diagrams for all processors - https://phabricator.wikimedia.org/T141617 (10XenoRyet) [20:20:37] 10Fundraising Sprint Princess Mongodb, 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 4 others: Email preference center: create new mail type "Email Preference Country" - https://phabricator.wikimedia.org/T280674 (10XenoRyet) [20:20:42] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Roller Toaster, and 2 others: Snooze for 90 days setting on email preference center - https://phabricator.wikimedia.org/T278859 (10XenoRyet) [20:20:44] 10Fundraising Sprint T 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Roller Toaster, and 2 others: Add 3 email preference fields to civi - https://phabricator.wikimedia.org/T278858 (10XenoRyet) [20:20:47] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Corrugated super slide, 10Fundraising Sprint Downed power line jump rope, and 28 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10XenoRyet) [20:30:53] 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo: Spanish Monthly Convert for the US / Does es-419 fall back to es? - https://phabricator.wikimedia.org/T291993 (10Ejegg) @HNordeenWMF the Spanish translations are deployed. [20:37:45] AndyRussG: I've got the new patches up but am getting a linter complaint that I can't seem to fix [20:38:15] Use nullable type("?string") for parameters documented [20:38:15] 16:07:54 | | as nullable [20:38:34] ejegg: hmmm [20:38:44] still, after adding all this: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/726971/2..3/Core/ValidationError.php [20:39:52] anyway, I'mma test the actual functionality fof https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/726971 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/730284 [20:40:05] oki! [20:40:13] maybe what it's complaining about is the lack of inline doc? [20:40:22] where? [20:40:32] oh, on the actual property? [20:40:42] just since the error says "documented"? [20:40:44] I'll try adding that [20:41:00] oh no huh [20:41:14] sorry I hadn't seen the full message [20:42:23] huh yeah dunno trhere [20:42:24] (03PS4) 10Ejegg: Deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) [20:42:42] well, PS4 adds phpDoc to the property as well [20:44:17] ejegg: ah it wants you to document it inline as string|null [20:44:34] Here they fixed the same thing like that [20:44:36] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalWatchlist/+/665201 [20:44:37] (03CR) 10jerkins-bot: [V: 04-1] Deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [20:44:47] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalWatchlist/+/665201/1/tests/phpunit/unit/SettingsFormValidatorTest.php [20:45:13] I guess in the @param inline doc you don't indicate nullability with the ? prefix? [20:46:09] ohhh, @param needs string|null? [20:46:34] (03PS5) 10Ejegg: Deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) [20:50:43] ejegg: I mean, maybe? [20:50:59] yeah, that seems to have fixed it [20:51:03] ejegg: AndyRussG I'm heading off now but feel free to ping if there's any review needed urgently tomorrow on those patches in the event stuff doesn't cross the line tonight. thanks for all the work on that and caring about our failmail! [20:51:06] anyway, ready for review [20:51:22] jgleeson: thanks, have a great evening! [20:51:30] you too! [20:51:34] bye for now [20:51:34] :) [20:51:37] jgleeson: actually if you want to review the apple pay stuff tomorrow, the rest of fundriaising is more anxious for that [20:51:41] thanks! [20:51:47] and have a good evening [20:51:48] ok sure thing ejegg [20:52:01] back in a little bit AndyRussG [20:52:22] ejegg: oki thanks!!!! my brain is in need of a break, but I'll definitely get to it soon... I think hopefully in 40 min or so [20:52:34] k [20:52:40] :) [22:11:16] (03PS2) 10Ejegg: Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) [22:13:15] (03CR) 10jerkins-bot: [V: 04-1] Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [22:40:49] (03PS6) 10Ejegg: Deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) [22:46:27] (03PS1) 10Eileen: 5.43.beta update to lastest code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/730359 [22:49:22] (03PS2) 10Eileen: 5.43.beta update to lastest code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/730359 [22:53:37] (03PS3) 10Eileen: 5.43.beta update to lastest code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/730359 [22:56:00] (03PS5) 10Ejegg: Make payments listen on additional http port [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/724864 (https://phabricator.wikimedia.org/T291577) [22:56:02] (03PS2) 10Ejegg: Add script to forward remote port [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/726675 [23:15:16] AndyRussG: the current donationInterface patch is failing validation because it's calling some of the new functions added in the smashpig patch [23:15:37] so if you can +2 the smashpig patch first I'll combine the donationInterface patch with a library update [23:18:09] ejegg: ah right got it [23:18:24] so just gonna walky wog first, back in about 20 minutes! [23:21:59] (03PS3) 10Ejegg: Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) [23:24:10] (03CR) 10jerkins-bot: [V: 04-1] Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [23:24:54] k, tested that setup and it seems to highlight the errors just fine [23:25:03] will abandon the alternative patch [23:27:36] (03Abandoned) 10Ejegg: Adyen Checkout: catch validation exceptions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/727012 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [23:27:58] (03CR) 10DannyS712: [C: 03+2] MediaWikiTestCase -> MediaWikiIntegrationTestCase [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/730310 (https://phabricator.wikimedia.org/T293043) (owner: 10Zabe) [23:28:26] (03PS4) 10Ejegg: Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) [23:35:35] (03PS1) 10Ejegg: Add Merchant ID domain association file [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730364 (https://phabricator.wikimedia.org/T290108) [23:35:51] (03CR) 10Ejegg: [C: 03+2] Add Merchant ID domain association file [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730364 (https://phabricator.wikimedia.org/T290108) (owner: 10Ejegg) [23:49:11] (03Merged) 10jenkins-bot: Add Merchant ID domain association file [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730364 (https://phabricator.wikimedia.org/T290108) (owner: 10Ejegg) [23:50:16] (03CR) 10jerkins-bot: [V: 04-1] Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [23:50:28] hmmm [23:52:30] (03Merged) 10jenkins-bot: MediaWikiTestCase -> MediaWikiIntegrationTestCase [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/730310 (https://phabricator.wikimedia.org/T293043) (owner: 10Zabe)