[00:34:28] dwisehaupt: would you mind adding .well-known/apple-developer-merchantid-domain-association.txt to the allow list on payments-wiki? [00:38:04] !log updated payments-wiki from 030b11da1a to b329d2dea2 [00:38:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:41:54] (03PS1) 10Ejegg: Remove unneeded polyfill (and its dependency) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730386 (https://phabricator.wikimedia.org/T292553) [01:17:23] (03PS1) 10Ejegg: Remove unneeded polyfills [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730390 (https://phabricator.wikimedia.org/T235352) [01:18:20] ejegg: small detail, maybe update the link to the required merge request in the commit message here? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/724864 [01:24:43] oh sure [01:25:45] (03PS6) 10Ejegg: Make payments listen on additional http port [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/724864 (https://phabricator.wikimedia.org/T291577) [01:25:47] (03PS3) 10Ejegg: Add script to forward remote port [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/726675 [01:26:02] there's that link updated AndyRussG ^^ [01:26:15] ejegg: cool thanks! [01:56:01] oh hey, new currency code just dropped: VES [01:56:11] worth 1,000,000 VEF [01:56:27] or $0.25 USD [01:59:25] hmmm should I buy? sell? [01:59:47] ejegg: Here's another note, but I don't know where it could go: You may need to re-run the payments install.php, LocalSettings.php and update.php steps to clear out an old version of LocalSettings.php... [01:59:53] I guess I can put that on the phab ticket [02:01:39] k, thanks [02:01:49] right, i guess i assumed folks would do that [02:02:28] ejegg: i'll add that in a little. just finished. cooking dinner and need to eat with the fam. [02:02:30] I was getting PHP Fatal error: require(): Failed opening required '/srv/config/private/payments/applepay/LocalSettings-apple-pay.php' [02:02:31] (include_path='/var/www/html/vendor/pear/console_getopt:/var/www/html/vendor/pear/mail:/var/www/html/vendor/pear/mail_mime:/var/www/html/vendor/pear/net_smtp:/var/www/html/vendor/pear/net_socket:/var/www/html/vendor/pear/pear-core-minimal/src:/var/www/html/vendor/pear/pear_exception:.:/usr/share/php') in /var/www/html/LocalSettings.php on line 3 [02:03:21] AndyRussG: oh, that's from jgleeson's old apple pay customizations which are removed in the config repo [02:03:30] ejegg: exactly [02:04:13] I guess all the patches where the note could go on the commit message have merged [02:12:36] 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo, 10FR-Adyen, 10Patch-For-Review: Set up new fr-dev staging server for Apple Pay - https://phabricator.wikimedia.org/T291577 (10AndyRussG) Quick note here: if you get the following error, make sure... [02:13:59] (03CR) 10AndyRussG: Get Apple Pay session from Apple (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/720126 (https://phabricator.wikimedia.org/T290108) (owner: 10Ejegg) [02:20:52] (03CR) 10Ejegg: "Hmm, shouldn't that new base class method be overridden in Amazon and PayPal adapters too?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/718941 (https://phabricator.wikimedia.org/T290103) (owner: 10AndyRussG) [02:23:06] ejegg: ^ hmmm could be? as it is for those integrations it doesn't the existing behaviour tho [02:23:22] but if you'd like to throw up a patch, that's cool! I guess we'd have to test 'em then? [02:23:41] *it doesn't change the existing behaviour [02:23:43] would be more consistent, no? [02:23:56] yeah if those integrations don't ever show said buttons, for sure [02:24:15] yah, they just don't now because of the lack of config I think [02:25:08] amazon does have the payemt_sumbmethods.yaml file [02:25:18] pp doesn't tho [02:26:23] no idea what that file does for amazon also [02:26:32] should be removed [02:26:48] those don't actually correspond to any payment instruments in the db [02:29:39] oki [02:29:50] yeah let's fix that then [02:30:09] sure, next year maybe? :) [02:30:09] ejegg: btw applepay worked with the new patches and private-config and all!!! [02:30:15] great! [02:30:26] oh, amazon does this: public function getAvailableSubmethods() { [02:30:26] return []; [02:30:27] } [02:30:37] silly [02:30:46] ahhh hmmmmm [02:31:02] I haven't tested amazon or pp locally in a long time [02:31:20] yeah, not worth distracting yourself over [02:31:24] though it also seems sure to work [02:33:09] (03CR) 10AndyRussG: "Another note" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/724864 (https://phabricator.wikimedia.org/T291577) (owner: 10Ejegg) [02:34:57] oh the note is B flat, forgot to say there [02:38:52] ejegg cstone eileen fr-tech anyone around, I would give a +2 to this merge request, if I could, but I can't, so I won't... https://gitlab.wikimedia.org/releng/dev-images/-/merge_requests/8 [02:39:18] hah i can AndyRussG [02:39:25] its currently thundersnowing outside [02:39:29] cstone cool thanks much! [02:39:40] ohhh [02:39:44] * AndyRussG is jealous [02:39:59] I can't [02:40:39] https://en.wikipedia.org/wiki/Thundersnow [02:40:56] eileen: thanks! i think cstone got it :) [02:41:19] yeah wed get it in NY with the lake effect [02:41:35] don't recall ever seeing it in Montreal [02:41:46] there are smaller lakes there but no big ones [02:42:03] yeah it needs a big unfrozen lake to start the process [02:42:15] (03PS7) 10Ejegg: Make payments listen on additional http port [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/724864 (https://phabricator.wikimedia.org/T291577) [02:42:32] ok it is merged [02:43:04] yaaaay thanks cstone!! [02:43:28] I didn't get the privatebin image from the repo, so we might have to pester someone to build it still [02:44:40] ejegg|away: ok. the puppet update has rolled out. it will take a few minutes to roll through the puppet runs. [02:44:58] thanks dwisehaupt [02:45:46] and thanks cstone [02:46:16] dwisehaupt unrelated question, what repo do our deploy tools (rsync_blaster and fr_code_update) live in? and specifically where would the canonical text for man pages/in-code doc for those be live? [02:47:33] thx in advance! [02:54:04] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] "Wooohoo! Yummm!!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/724864 (https://phabricator.wikimedia.org/T291577) (owner: 10Ejegg) [02:55:25] (03PS4) 10AndyRussG: Add script to forward remote port [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/726675 (owner: 10Ejegg) [02:56:06] AndyRussG: those are all in the puppet repo: puppet/modules/frdeploy/files [02:57:13] dwisehaupt: ah cool I imagined as such :) yeah just thinking of adding a note about that here with other in-code doc: https://www.mediawiki.org/wiki/Fundraising_tech/notes/Draft:Documentation_overhaul#In-code_documentation [02:57:16] thx!!! [03:15:04] just verified that the well-known file is showing up as intended. [03:19:30] (03CR) 10AndyRussG: "Heyyy this is great!!! Quick thought: what about adding in README.md a link to https://wikitech.wikimedia.org/wiki/Help:Accessing_Cloud_VP" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/726675 (owner: 10Ejegg) [03:27:50] (03PS3) 10AndyRussG: DO NOT MERGE bogus way to trigger 422 error [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/727009 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [03:30:24] (03PS1) 10Eileen: Fix contact name pairs to not show up as forgettable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730395 (https://phabricator.wikimedia.org/T244811) [03:48:57] (03PS1) 10Eileen: Superficial changes merged upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730398 [03:53:27] AndyRussG: I put up an alternate fix for the forget me bug. The core patch I did is merged upstream but I think we shouldn't rely on it - ccccccjelcgbthcbdnifchucbfcdbjtjbfhdnkjudugt [03:53:29] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/730395 [04:00:56] eileen: ah cool thanks! [04:08:24] eileen: at the moment I have my head mostly in the payments space... but if you'd like to write some notes about it here, or on the task or on the patch, if you think that'd be useful, and I should get to it tomorrow? thx!!!! [05:24:55] (03CR) 10AndyRussG: "Cool, works great! Just one small detail... :)" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726943 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [05:41:25] (03PS1) 10Eileen: Fix IF clause [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730401 (https://phabricator.wikimedia.org/T286520) [08:40:18] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo: Unable to download the query data - Rakhi Fraud Scan - https://phabricator.wikimedia.org/T292370 (10RKumar_WMF) I am unable to download if the number of rows are higher . I tried wit... [14:31:40] (03PS3) 10Ejegg: RestResponseValidator for Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726943 (https://phabricator.wikimedia.org/T290923) [14:31:51] (03CR) 10Ejegg: "updated AndyRussG" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726943 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [14:32:59] ejegg: cool thx! ^ [14:35:14] (03CR) 10AndyRussG: [C: 03+2] "Wooohooo highway 422!!!!!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726943 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [14:35:46] (03Merged) 10jenkins-bot: RestResponseValidator for Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726943 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [14:45:22] AndyRussG: ejegg I'm sniffing around https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/720127 and https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/720126 looks like AndyRussG has some questions on each patch. AndyRussG is it worth me digging in also or would you advise holding off setting everything up to test those patches? [14:46:51] jgleeson: ah quick update on those, we talked them over yesterday in tech-talk, at least on my end I feel they're in a good place now eh :) [14:47:14] just doing a bit of final review, also pls don't hesitate to dig in of course [14:48:14] gotcha, thanks! [14:49:11] lemme skip through that tech-talk recording :) thanks for recording that! [14:49:39] ahh ah yeah thanks jgleeson! [14:57:12] I hope the day comes when someone notices me logging into my mac as "Raoul Duke" for Apple Pay testing, and asks why :) [14:57:29] little chance of that happening though working from the box room at my house [14:57:55] guess it would pretty worrying if that happened here [14:58:02] would be* [15:33:04] (03CR) 10AndyRussG: "Looks great, thanks for this!!! Just one note inline....." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726942 (owner: 10Ejegg) [15:34:28] heheh [15:34:50] it's also ok to laugh at one's own jokes [15:35:41] sometimes when I'm completely alone I remember my own jokes and just start laughing at them [15:38:08] :) [15:45:56] k, back from baby duty, will make some lil patch updates [15:46:17] or at least those comments in the readme that AndyRussG suggested for the fwd.sh script [15:47:03] some baby patch updates? [15:47:19] yep yep [15:51:39] fr-tech: i'm going to miss standup. the kids have a late start today so i'll be in the car. [15:51:56] dwisehaupt: oki :) [15:55:42] (03CR) 10AndyRussG: [C: 03+2] "Yeahhhh highway 101, 102 and 103!!!!!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [15:56:22] ejegg: ^ could be rebased to merge... for some reason the Gerrit button complains about a conflict or something [16:01:45] ok [16:05:15] AndyRussG: looks like its parent patch is still awaiting review [16:05:21] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/726942/2 [16:05:38] ah i see the note [16:05:51] k, will update the phpdoc [16:09:49] ejegg: thx!!! [16:09:58] (03PS3) 10Ejegg: More type hints for *Response classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726942 [16:11:24] (03PS7) 10Ejegg: Deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) [16:11:25] (03PS4) 10Ejegg: DO NOT MERGE bogus way to trigger 422 error [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/727009 (https://phabricator.wikimedia.org/T290923) [16:22:07] (03PS4) 10Ejegg: More type hints for *Response classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726942 [16:22:44] (03PS8) 10Ejegg: Deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) [16:22:46] (03PS5) 10Ejegg: DO NOT MERGE bogus way to trigger 422 error [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/727009 (https://phabricator.wikimedia.org/T290923) [16:31:12] (03CR) 10Ejegg: "Thanks for the CR AndyRussG - PS7 updates those ports in the commit message" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/724864 (https://phabricator.wikimedia.org/T291577) (owner: 10Ejegg) [16:34:44] (03CR) 10AndyRussG: [C: 03+2] "merge|not to merge, that is the ?" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726942 (owner: 10Ejegg) [16:36:02] ^ that fr-dev one is merged eh, yeah thanks for updating ejegg [16:36:22] (03Merged) 10jenkins-bot: More type hints for *Response classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726942 (owner: 10Ejegg) [16:36:25] (03Merged) 10jenkins-bot: Deal with validation errors in encrypted payment create [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/726971 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [16:37:14] ejegg: so I think all the smaspig stuff is merged, if you want to do the version update you mentioned? [16:37:49] yep yep, will do [16:38:14] ejegg: thanks!!!! and thanks so much for all the updates... I should do the bank thing quickly, then I can take a final look at the DI bit [16:46:13] fr-tech brennan says he can publish those docker images shortly [16:48:04] and... payments.wikimedia.org is Verified for Apple Pay! [16:51:37] ohh yay! [16:54:08] (03PS1) 10Ejegg: Update SmashPig lib to 0.7.4 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730596 [16:54:12] (03CR) 10Ejegg: [C: 03+2] Update SmashPig lib to 0.7.4 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730596 (owner: 10Ejegg) [16:54:43] (03PS2) 10Ejegg: Update SmashPig lib to 0.7.4 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730596 [16:58:26] fr-tech the new images are published [16:58:38] ohhh noice [16:58:39] (03CR) 10jerkins-bot: [V: 04-1] Update SmashPig lib to 0.7.4 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730596 (owner: 10Ejegg) [16:59:02] fr-tech damilare ^ so you should be able to use the latest fr-dev now [17:04:35] AndyRussG: ok, that smashpig lib update is done [17:04:45] lemme recheck that DI patch [17:05:13] (03PS5) 10Ejegg: Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) [17:05:20] ah, needed rebase anyway [17:09:49] oh, and that apple pay patch will need a rebase over the validation errors one. but i'll wait to do that till after you review the validation errors bit, in case there are changes needed [17:10:43] ejegg on the way to the bank now... I guess my main thought on the DI patch so far is, maybe add a FIXME or other sort of comment about how the js could be improved, and also maybe make the js refactor task and link that in the comment too? also thx again for all that!! [17:10:59] ah yeah [17:11:29] we might already have a related task specifically for validation [17:49:11] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Technical-Debt: Rewrite DonationInterface forms and validation JS - https://phabricator.wikimedia.org/T293287 (10Ejegg) [18:10:49] 10Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate, 10SRE, and 8 others: DBPerformance warning "Query returned XXXX rows: query: SELECT * FROM `translate_metadata`" - https://phabricator.wikimedia.org/T204026 (10Damilare) @Nikerabbit it's should be in the deploy... [18:23:14] 10Fundraising-Backlog: Adyen forms for Euro Bundle - https://phabricator.wikimedia.org/T293292 (10EMartin) [18:30:35] yay [19:29:30] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo: Unable to download the query data - Rakhi Fraud Scan - https://phabricator.wikimedia.org/T292370 (10Eileenmcnaughton) @Dwisehaupt I think this latest comment duplicates another ticke... [19:39:09] (03PS5) 10Ejegg: Add script to forward remote port [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/726675 [19:41:11] (03CR) 10Ejegg: "OK AndyRussG I think I addressed all the comments" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/726675 (owner: 10Ejegg) [19:44:41] AndyRussG: any chance you'll get to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/730284 today? [19:45:52] ejegg: yeee for sure [19:47:46] :) [20:04:48] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen: recent 'MediaWiki internal error - fatal exception' errors - https://phabricator.wikimedia.org/T293131 (10MBeat33) ZD 1006677 10/11/2021 cid=52200998 This mobile donor had two transactions stop at Auth status at Adyen. Tomasz captu... [20:34:21] (03PS4) 10Eileen: 5.43.beta update to lastest code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/730359 [20:53:40] (03PS1) 10Eileen: Fix partner field not being updated on engage import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730643 (https://phabricator.wikimedia.org/T286520) [21:03:26] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog: Unable to add contacts to a group via search kit - https://phabricator.wikimedia.org/T292784 (10Eileenmcnaughton) ug - it's passing them through the uri so it's that same uri limit again @Dwisehaupt [21:21:26] (03CR) 10AndyRussG: "Heyyy thanks much for this!!!!!!! Should we also update the required smashpig version in composer.json, or is that unnecessary/not worth t" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [21:21:44] ejegg ^ there's a first pass [21:22:14] K gonna cook and eat and such, but I'll keep IRC nearby and will be back at the computer in the evening [21:25:14] AndyRussG: we haven't been tweaking the composer.json for every point upgrade [21:25:25] we could, but it would be a bit tedious [21:25:34] (03PS2) 10Eileen: Fix contact name pairs to not show up as forgettable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730395 (https://phabricator.wikimedia.org/T244811) [21:25:54] ejegg: right I imagined that was the case! yeah just thought I'd ask in case it was important 8p [21:27:03] (03Abandoned) 10Eileen: Fix for forgetme not working [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/730137 (https://phabricator.wikimedia.org/T244811) (owner: 10Eileen) [21:28:41] (03CR) 10Ejegg: [C: 03+2] "Looks good, fixes that getrefcount action on a local contact whose first_name is null" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730395 (https://phabricator.wikimedia.org/T244811) (owner: 10Eileen) [21:31:47] (03PS2) 10Ejegg: Remove addition of contribution statuses from upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730046 (owner: 10Eileen) [21:32:23] (03CR) 10Ejegg: [C: 03+2] "There may have been a reason for these once upon a time but these days it seems best to stick with the standard statuses." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730046 (owner: 10Eileen) [21:33:36] (03PS2) 10Ejegg: Superficial changes merged upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730398 (owner: 10Eileen) [21:33:41] (03CR) 10Ejegg: [C: 03+2] Superficial changes merged upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730398 (owner: 10Eileen) [21:35:14] (03PS2) 10Ejegg: Fix IF clause [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730401 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [21:35:33] (03CR) 10Ejegg: [C: 03+2] "Cool, let's not create extra orgs!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730401 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [21:37:58] ejegg: on this patch you say we MAY need to update to safari 15 to test it... https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/720127 but I can't find a way to update safari from 14 to 15 without waiting for this ridiculous 12.44GB mac os update to finish downloading (current eta 3 hours....) [21:38:16] jgleeson: argh! [21:38:37] jgleeson: if you look at the wallet section of your mac settings, does it say apple pay is disabled due to security settings? [21:39:01] nope [21:39:12] oh ok, you should be OK to test on Safari 14 then [21:39:17] !!! [21:39:21] that's good news [21:39:21] jgleeson: ahh have fun and good luck with that one eh! mine kept interrupting right after it finished downloading, and only worked after I started in safe mode [21:39:38] oh shoot is this the update that bricked your laptop AndyRussG ? [21:39:48] yeeee [21:39:51] (03Merged) 10jenkins-bot: Fix contact name pairs to not show up as forgettable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730395 (https://phabricator.wikimedia.org/T244811) (owner: 10Eileen) [21:39:54] but it's ok I have the firmware pw if u need it [21:40:10] I thought these things justified their inflated prices because they just work... [21:40:24] ha! firmware password [21:40:32] :( [21:43:13] I'm a little worried that leaving the laptop alone tonight to finish the update might crash anyway due to it going to sleep (along with me) [21:43:28] I guess I can find some settings to prevent that [21:43:33] pw set remotely via company-required remote-control thingy no less [21:43:44] waaaaaaaaa [21:43:51] (03Merged) 10jenkins-bot: Remove addition of contribution statuses from upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730046 (owner: 10Eileen) [21:44:51] (03Merged) 10jenkins-bot: Superficial changes merged upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730398 (owner: 10Eileen) [21:45:25] eileen: ugh, i'll dig through the logs and see if we can get a top end of a request for those urls. we can keep bumping the limit but it would be good to know what a good realistic upper limit for their queries will be. [21:45:41] dwisehaupt: I'm starting to think there isn't one! [21:46:31] (03PS1) 10Ejegg: Add autocomplete to top-level form element [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730647 [21:47:03] fr-tech: mbeattie was saying some donors say they still don't get autocomplete in forms. That one-line change just might help ^^^ [21:47:03] (03Merged) 10jenkins-bot: Fix IF clause [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730401 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [21:48:25] well... :) [21:53:20] (03PS2) 10Ejegg: Fix partner field not being updated on engage import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730643 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [21:53:27] (03CR) 10Ejegg: [C: 03+2] Fix partner field not being updated on engage import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730643 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [21:55:57] (03PS1) 10Eileen: Enhance test to ensure blank partner does not overrided [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730648 (https://phabricator.wikimedia.org/T286520) [21:56:31] (03PS2) 10Eileen: Enhance test to ensure blank partner does not override [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730648 (https://phabricator.wikimedia.org/T286520) [22:01:01] (03PS3) 10Ejegg: Enhance test to ensure blank partner does not override [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730648 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [22:01:07] (03CR) 10Ejegg: [C: 03+2] Enhance test to ensure blank partner does not override [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730648 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [22:02:45] omg [22:03:00] wtf apple [22:03:14] lol what now jgleeson ? [22:03:39] it just popped up "updates available" so I thought that was quick [22:03:52] I clicked update and it started downloading the same update again from the beginning [22:04:05] booooo [22:04:35] where the hell has that 3gig of incomplete data gone [22:04:58] (03Merged) 10jenkins-bot: Fix partner field not being updated on engage import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730643 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [22:05:01] jeez, never thought i'd be looking favorably at windows update [22:05:06] ha [22:05:45] hmm it doesn't seem to be working for me on safari 14 [22:06:18] and I think I've set everything up as instructed across the patches including the apache header origin stuff [22:06:23] want to use that console logging magic? [22:06:37] good idea, I'll give that a go [22:06:40] right, that apache one would make the whole site invisible [22:07:32] hmm one thing I did notice is that payments2.wmcloud didn't seem to behave the same as payment1.wmcloud [22:07:47] jgleeson: sounds like the same update issue I head, yeah [22:08:00] let's see what's in the logs [22:08:11] yeah AndyRussG that really bad that is can just lose all that data [22:08:17] PROBLEM - check_mysql on payments2003 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2) [22:08:17] PROBLEM - check_payments_wiki on payments2003 is CRITICAL: HTTP CRITICAL: HTTP/1.1 500 Internal Server Error - string OK not found on https://payments2003.frack.codfw.wmnet:443https://payments.wikimedia.org/index.php/Special:SystemStatus - 638 bytes in 0.037 second response time [22:08:23] that's me. [22:08:28] you'll have to enter recovery mode (with the fw pw) and then disable the fw pw to enter safe mode and try updating again [22:08:35] at least that's the way it went for me... [22:08:50] forgot to reset the downtime as i was finishing up updates in codfw. [22:08:56] ah i hope I don't end up in that much of a state [22:09:37] I've switched wifi points in the hope that the original connection wasn't the most stable [22:11:05] jgleeson: so I need to manually rebase that apple pay patch on top of the adyen validation error patch [22:11:13] once AndyRussG can +2 that one [22:11:37] oh i see, there were more comments, not just the smashpig version [22:11:39] ok, reading those [22:11:44] thanks for the CR AndyRussG ! [22:12:44] (03Merged) 10jenkins-bot: Enhance test to ensure blank partner does not override [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730648 (https://phabricator.wikimedia.org/T286520) (owner: 10Eileen) [22:12:47] thank u! :) [22:13:17] RECOVERY - check_mysql on payments2003 is OK: Uptime: 241 Threads: 11 Questions: 408 Slow queries: 0 Opens: 96 Flush tables: 1 Open tables: 90 Queries per second avg: 1.692 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [22:13:17] RECOVERY - check_payments_wiki on payments2003 is OK: HTTP OK: HTTP/1.1 200 OK - 500 bytes in 0.044 second response time [22:14:20] ejegg: not sure what to make of this log soup I'm seeing [22:14:34] lots of "connection invalidated" [22:15:30] also a bunch of Set errors: on preference [22:17:24] AndyRussG: ejegg to rule out a local problem, could either of you browse to https://paymentstest1.wmcloud.org/index.php?title=Special:AdyenCheckoutGateway&appeal=JimmyQuote&payment_method=apple&recurring=&uselang=en&language=en¤cy=USD&amount=10&country=US&ffname=adyen&debug=true and click donate? [22:17:30] no worries if you don't have the mac out [22:18:02] eileen: i'm not sure if i'm testing correctly. but i think i tested both of the queries in T292370 and T292784 and was able to run them and download the files just fine. [22:18:02] T292370: Unable to download the query data - Rakhi Fraud Scan - https://phabricator.wikimedia.org/T292370 [22:18:02] T292784: Unable to add contacts to a group via search kit - https://phabricator.wikimedia.org/T292784 [22:19:07] dwisehaupt: they probably vary how much data is in them but for T292784 the goal is a bit different - it's to use the 'Add to group' task [22:19:55] is search + click to select all + choose 'add to group' [22:21:36] ok. yeah, i'm at the edge of my knowledge for civi and i don't want to break something testing. :) [22:22:01] do you want me to screen share it to you? [22:23:00] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/730650 [22:23:21] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/730650 (owner: 10Eileen) [22:23:46] sure. [22:24:13] https://meet.google.com/tdk-hozv-tkv?authuser=0&hs=122&ijlm=1634163847173 [22:28:30] 10Fundraising-Backlog: Refresh staging data - https://phabricator.wikimedia.org/T293315 (10Eileenmcnaughton) [22:33:41] (03PS6) 10Ejegg: Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) [22:34:42] (03CR) 10Jgleeson: "This isn't working for me on Safari 14. My local Apple Pay isn't disabled but I'll wait out the update 12gb and see if it performs better " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/720127 (https://phabricator.wikimedia.org/T290108) (owner: 10Ejegg) [22:35:10] (03PS7) 10Ejegg: Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) [22:36:23] (03PS8) 10Ejegg: Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) [22:36:25] AndyRussG: ejegg I'm noticing that xdebug isn't working via paymentstest1.wmcloud.org but it is working when accessing the site over localhost:9001 and 9009. The xdebug config looks good so not sure why it doesn't like with that [22:36:54] jgleeson: huh it works fine for me over both routes [22:36:59] I was gonna xdebug the smashpig side to see why the https://apple-pay-gateway-cert.apple.com/paymentservices/startSession call wasn't completing [22:37:49] hmm AndyRussG maybe it's because I'm using the query param route and not the autostart config to trigger it [22:38:22] appending &XDEBUG_SESSION=idekey is my preferred way and it usually works for ad-hoc stuff but not in this case [22:38:48] jgleeson: ohh wait, was there a CORS header thing we needed too for that? [22:39:07] I think I may have hacked that in at some point [22:39:21] for xdebug? [22:39:34] ah yeah I use autostart [22:39:42] jgleeson: so you're basically just getting an empty response from the api.php request when it calls the apple session action [22:39:44] since for me at least the url param doesn't work for background calls [22:39:45] ? [22:39:56] yea ejegg i think so [22:40:05] browser dev tools showed that it was complaining about a lack of cors header [22:40:16] I'll give the autostart config a go AndyRussG [22:40:19] so I added one in... apache maybe? [22:40:31] I think I was going to search for a mediawiki way to do that for a specific URL [22:41:05] argh so I did add that [22:41:12] but incorrectly it seems [22:41:17] this might be it [22:41:30] Header set access-control-allow-origin *' [22:41:40] stray single quote at the end there [22:41:47] let's see if fixing that fixes things [22:41:51] aha [22:43:24] (03PS9) 10Ejegg: Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) [22:46:05] (03CR) 10Ejegg: "OK AndyRussG, I think PS9 addresses all your comments. And generally we don't track the minor smash-pig version changes in our composer.js" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [22:51:28] ok, so we have https://www.mediawiki.org/wiki/Manual:CORS [22:52:02] eileen: bumped those limits to 160k and we are still seeing the issue. doing some smaller queries, i think we would need to bump it another 3.8x to around 630k [22:52:17] whoa - [22:52:35] it's about 56 bytes on the request for each 5 contacts [22:52:48] and that particular query has >55k contacts [22:52:51] I would be interesting to see if it does work at that level - fyi for Nora's use it probably wouldn't be needed again for a while [22:52:52] oh jeez, and I thought megabyte RESPONSE sizes were overkill :) [22:53:48] easy enough to change the value and test. [22:54:21] but as always, when we start slinging around more bytes, other limits may come into play that haven't been hit yet. so we'll see. [22:58:07] jgleeson: yeah, I want to figure out why safari was complaining about CORS headers on a same-domain request [22:59:52] oh hmmm, could it be something with caching? I notice that sometimes my homepage links have localhost:9001 in them when I'm browsing to paymentstest1 and vice versa [23:00:25] if that mw.Api() is using a URL fed to it via a cached value, maybe it's doing the request to the wrong domain [23:00:37] swapping branches to try that again [23:01:38] I just ran debugging to check the config is all correct and cert is available and that looks good so it's probably something on my end [23:01:40] thx ejegg I'll be able to look at it in about 1 hr :) [23:02:01] the good news is the mac os big slur os update has finished so I'm gonna run that now [23:02:07] jgleeson: woohoo [23:02:36] looks like my 5g wifi point is much faster than my usual PoE wifi point [23:02:55] sadly it's not usable from the box room I work from :( [23:03:27] anyway that'll do it, have a good evening all, bye for now [23:03:34] by jgleeson [23:06:09] looks my my estimate balanced down a little with scale. ends up we only needed 483334 vs 655360 [23:06:22] s/my my/like my/ [23:06:45] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog: Unable to add contacts to a group via search kit - https://phabricator.wikimedia.org/T292784 (10Dwisehaupt) Dug into this more, the query grows by ~56 bytes per 5 records added. So, for this ~56k query, we need buffers >627k. Bumping... [23:07:42] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: server error seen when attempting to export long search kit list - https://phabricator.wikimedia.org/T287995 (10Dwisehaupt) In relation to T292784 we have bumped the buffers up to 640k. Please try this again and see if you are st... [23:36:12] !log civicrm revision changed from 946dfb6c5a to 018d3b19fe, config revision is 85277466ed [23:36:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log