[00:42:53] AndyRussG: so does it seem better to you to only return the 'refresh' payment result from errors in the initial setup call, and leave for later any error handling from a getPaymentDetails call in donorReturn? [00:44:50] hmmm [00:44:59] hehe one sec [00:46:32] that's how i've got it in the latest PS [00:46:59] figured it would be simpler just not to touch that handleCompletedPayment function for now [00:47:18] since all the errors we've seen so far are directly with the authorization [00:48:05] ejegg: ah right [00:48:26] sorry supper and dog-promenade took longer than expected, just sitting down at my desk again now [00:49:01] Certainly sounds reasonable [00:49:29] cool, just hoping to get this merged tonight so i can have the apple pay patch rebased for when jgleeson starts tomorrow [00:50:56] K! I have a clear 1.5 hours now before I have to go pick up Sofi from her friend's place [00:51:01] should be enuf [00:52:15] yeah that logic definitely feels better there [00:52:42] I guess it's impossible for there to be simultaneously validation errors _and_ a successful payment, correct? [00:54:01] that's my assumption [00:55:54] oki [00:56:06] it's certainly true for the three validation errors we're catching now [00:56:12] right [00:56:29] ejegg: I was about to apologize for coming up empty-handed and not finding anything further to gripe about [00:56:37] however I have found another smol smol nit [00:56:53] k, let's have it [00:57:33] in ext.donationInterface.forms.js line 230 (of the current patch) there is also some code attaching stuff to continuePaymentBtn, which is a descendant DOM element of #continuePayment [00:57:40] so maybe a similar comment there too? [00:57:51] thanks for all these updates btw!!! [00:58:39] k [01:01:26] (03PS10) 10Ejegg: Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) [01:02:05] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Technical-Debt: Rewrite DonationInterface forms and validation JS - https://phabricator.wikimedia.org/T293287 (10AndyRussG) [01:02:11] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Epic: [Epic] Architecture, separation of concerns and refactors in DonationInterface (2021) - https://phabricator.wikimedia.org/T291697 (10AndyRussG) [01:04:01] ejegg: looks great eh! just gonna do one final smoke test then [01:07:50] ah, oops, I made the edit in a different local copy of the code [01:08:37] ah oki [01:09:42] (03PS11) 10Ejegg: Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) [01:09:53] ok, that has the extra comment ^ [01:10:40] (03PS2) 10Ejegg: Add autocomplete to top-level form element [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730647 [01:11:42] (03PS2) 10Ejegg: Remove all address fields for Apple Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/727675 [01:12:33] (03CR) 10AndyRussG: [C: 03+2] "Yaaayyyy validation errors are the best!!!!!!!!!!!!!!!!!!!!! :) :) ;)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [01:12:37] :) [01:12:56] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog: Unable to add contacts to a group via search kit - https://phabricator.wikimedia.org/T292784 (10Eileenmcnaughton) @NNichols can you try again [01:12:58] (03PS7) 10Ejegg: Apple Pay: onValidateMerchant handler [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/720127 (https://phabricator.wikimedia.org/T290108) [01:13:03] thanks so much for being patient with me on this one ejegg :) :) [01:13:28] and thank you for carefully considering code placement etc [01:14:10] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 4 others: Would it be possible to have an 'Owns the Donor Advised Fund' field that would link that Individual ... - https://phabricator.wikimedia.org/T286520 [01:14:51] (03Merged) 10jenkins-bot: Adyen Checkout: handle validation errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730284 (https://phabricator.wikimedia.org/T290923) (owner: 10Ejegg) [01:15:55] ahhhhhh heh always available if you need a bit of needless obsessive compulsion... also thank you for the quick coding, for explaining the urgency of the fix and also for watching all the failmails :) [01:16:15] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/730667 [01:16:29] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/730667 (owner: 10Ejegg) [01:17:35] hmm, at least one of the TODOs in my apple pay patch looks like maybe I shouldn't leave it for later [01:17:39] shoot [01:18:13] ? [01:18:20] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/730667 (owner: 10Ejegg) [01:19:00] which one? [01:19:05] AndyRussG: checking the csrf token on the mediawiki api call is probably not something we want to deploy without [01:19:34] hmmm [01:19:46] sounds correct [01:19:52] well, i guess i'll probably do that tomorrow [01:19:56] maybe in a follow-on patch [01:20:09] yee also sounds fine [01:26:20] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730670 [01:26:27] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730670 (owner: 10Ejegg) [01:37:41] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730670 (owner: 10Ejegg) [01:41:13] !log updated payments-wiki from b329d2dea2 to 19d18c1852 [01:41:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:42:33] AndyRussG: did you see I updated this one too? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/726675 [01:43:22] ejegg: ah I didn't! thx for the heads-up [01:44:14] whelp, so far no problems with the new code [01:44:34] ah, AndyRussG I also deployed your fix for the submethod button flash [01:44:45] ah cool beans thx! [01:45:08] yeah I'll make a quick patch for making that consistent across processors [01:45:52] ah cool. if you want to delete the amazon submethods yaml in that same patch it'd be cool [01:46:15] oh, and I guess the amazon gateway's overriding of getAvailableSubmethods would be on the chopping block too [01:49:41] hmmmm [01:49:59] K are you sure that won't have any effects? [01:50:07] do we still use the amazon gateway anywhere? [01:50:30] yep - i think still US-only? [01:50:55] AndyRussG: so if you remove that override you need to remove the yaml as well [01:51:25] the base method will return the same [] if the yaml is gone [01:51:39] right [01:52:35] and I guess the getAvailableSubmethods is what was guaranteeing that we weren't even reading that file? I suppose I could double-check by grepping for any code directly accessing the config [01:55:13] the file is checked for in the constructor [01:55:40] Oki [01:56:10] https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/ConfigurationReader.php$78 [01:56:35] basically snarfs any yaml files from the config dir [01:56:48] and puts them into a corresponding key in the $config array [01:57:56] called via loadConfig here https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/gateway.adapter.php$241 [01:58:38] then in definePaymentMethods https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/gateway.adapter.php$398 [01:59:05] we copy that config key to the payment_submethods property when it exists [01:59:23] but that property defaults to [], so we're fine [02:00:50] right gotcha [02:01:49] so no other unauthorized code looking directly at $this->payment_submethods or re-reading the config, cool [02:04:28] k, i'mma head to bed [02:06:02] Cya! thx! [02:51:45] (03CR) 10Eileen: [C: 03+2] "Dang I thought we got our symfony updated - guess not" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730386 (https://phabricator.wikimedia.org/T292553) (owner: 10Ejegg) [02:52:48] (03PS1) 10Eileen: Switch from our custom token to core token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730679 (https://phabricator.wikimedia.org/T288698) [02:54:01] (03PS2) 10Eileen: Switch from our custom token to core token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730679 (https://phabricator.wikimedia.org/T288698) [03:03:47] (03Merged) 10jenkins-bot: Remove unneeded polyfill (and its dependency) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730386 (https://phabricator.wikimedia.org/T292553) (owner: 10Ejegg) [03:05:26] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10fr-donorservices: Clean up new adyen ideal recurrings - https://phabricator.wikimedia.org/T291712 (10Cstone) [03:06:26] (03CR) 10jerkins-bot: [V: 04-1] Switch from our custom token to core token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730679 (https://phabricator.wikimedia.org/T288698) (owner: 10Eileen) [03:27:45] (03PS1) 10Eileen: Switch from our custom token to core token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730681 (https://phabricator.wikimedia.org/T288698) [03:38:24] (03CR) 10jerkins-bot: [V: 04-1] Switch from our custom token to core token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730681 (https://phabricator.wikimedia.org/T288698) (owner: 10Eileen) [03:45:23] (03PS1) 10Eileen: Switch from our custom token to core token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730683 (https://phabricator.wikimedia.org/T288698) [03:45:52] (03Abandoned) 10Eileen: Switch from our custom token to core token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730681 (https://phabricator.wikimedia.org/T288698) (owner: 10Eileen) [03:56:21] (03CR) 10jerkins-bot: [V: 04-1] Switch from our custom token to core token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730683 (https://phabricator.wikimedia.org/T288698) (owner: 10Eileen) [04:57:57] (03PS1) 10Cstone: Move recurring setup parameters out of token creation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730685 (https://phabricator.wikimedia.org/T284606) [05:06:47] (03PS1) 10Cstone: WIP: Send new iDEAL recurrings to the recurring queue [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730686 (https://phabricator.wikimedia.org/T284606) [05:36:15] hmmm someone is burning the midnight oil.... [06:01:51] its even later for you! :P [10:12:48] (03PS5) 10Eileen: 5.43.beta update to lastest code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/730359 [15:35:20] ejegg|away: AndyRussG so it looks like Apple Pay transactions on our own cert setup are now working at my end after upgrading to big slur and Safari 15. There's a console error in Safari about referrer policy settings but other than that it all looks good [15:35:43] why it took a new OS and a new version of Safari, I can't tell you [15:36:15] surely that's silly. does this mean donors need to also use the latest of everything for it to work? [15:37:19] big sur* lol good typo there [15:37:42] jgleeson: fr-tech: Hi!! ahh good news and good question eh [15:38:34] hi AndyRussG ! yeah feels like that could be a problem if it's the case [15:38:47] oops brb soup burning! [15:40:10] I wonder would that happen for all apple pay transactions? Or maybe all browser-based ones? Or maybe it was an Adyen thing? [15:40:46] Related note, I guess we should confirm the Adyen meet tomorrow? [15:51:16] oh yeah good call AndyRussG and let's see if we can move it out a bit later also. Let's ask Dylan on standup? [15:51:55] We're got an etherpad somewhere [15:53:59] AndyRussG: I saw in the comments you were getting an error when trying so if you'd like when convenient maybe we could compare setups to see what the difference is at my end [15:56:01] (03Abandoned) 10Cstone: Move recurring setup parameters out of token creation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730685 (https://phabricator.wikimedia.org/T284606) (owner: 10Cstone) [15:56:47] fr-tech dwisehaupt Jeff_Green can you use the yubikey 5 nfc with macs to get around them having only thunderbolt ports? [15:57:33] jgleeson: sure! though which comments? also last applepay was working for me last time I tried it [15:57:39] hey XenoRyet, we were just talking about confirming that Adyen meeting tomorrow and wondering if it would be ok to suggest pushing it out an hour also? [15:58:16] ah ok AndyRussG. this is the comment I saw https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/720127/7#message-2c8dc15d852ebc02a5c5351a21bd8d88388491fe [15:59:08] jgleeson: hrm. I haven't investigated that but I'm thinking not without changes to the server side. Is it possible to input a OTP that way? [15:59:45] I think it works for phones but not sure with mac. [15:59:47] ah yeah I don't remember if that was fixed with the update maybe? [16:02:41] jgleeson: just tried it on my Samsung phone, and was prompted to go to a yubikey demo website which populated the "test your key" field with an otp [16:06:28] I don't have nfc on my laptop to test it [16:06:54] jgleeson: lol big slur [16:26:17] :) [16:37:51] 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo: Spanish Monthly Convert for the US / Does es-419 fall back to es? - https://phabricator.wikimedia.org/T291993 (10HNordeenWMF) Thank you Elliott! [17:39:06] XenoRyet: did you catch the adyen mention above ^^^ [17:46:10] jgleeson, I did not, saw it now though. [17:47:34] thanks! [17:50:26] Evelyn is asking if we can move it. What questions did you have in mind for them? [17:51:18] jgleeson, ^ [17:54:57] 10Fundraising-Backlog, 10FR-Ingenico: Swedish donations stuck at status 600 - https://phabricator.wikimedia.org/T246710 (10EMartin) Hi Manavi and Carmen, Our team would like to keep the standing call tomorrow to discuss some integration topics. We have a couple of folks on PT that want to participate and we... [17:59:07] XenoRyet: that was the etherpad we were gonna read off last week https://etherpad.wikimedia.org/p/frTechQuestionsForAdyen [18:00:10] Cool thanks. [18:00:11] I guess we could also ask about whether or not users need Safari 15 to use Apple Pay with us unless anyone thinks that's not something we need to worry about fr-tech [18:11:03] 10Fundraising-Backlog, 10FR-Ingenico: Swedish donations stuck at status 600 - https://phabricator.wikimedia.org/T246710 (10EMartin) Carmen, Manavi, Here is some insight into questions for our call tomorrow, hope you can make a bit later as requested below. Thank you! 1) OFFER_CLOSED IPNs https://phabricator... [18:44:18] fr-tech: Is 7:30 Pacific/2:30 UTC good for the Adyen call? Looks like that's an hour and a half later than currently booked. [18:44:33] XenoRyet: yee works great for me :) [18:46:25] that's good for me XenoRyet [18:46:36] Cool [18:48:48] 10Fundraising-Backlog, 10FR-Ingenico: Swedish donations stuck at status 600 - https://phabricator.wikimedia.org/T246710 (10XenoRyet) Hi Carmen, That time slot works well for our side, thanks for accommodating us. I'll get the invite adjusted. [18:48:55] (03PS1) 10Ejegg: Fix exception setting client-side validation rules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730878 [18:49:17] AndyRussG: oops, I guess there WAS an unintended consequence of removing that submethod list :S ^^^ [18:49:37] nothing client-facing, I think, but we should stop logging that error message [18:49:46] 10Fundraising-Backlog, 10FR-Ingenico: Swedish donations stuck at status 600 - https://phabricator.wikimedia.org/T246710 (10XenoRyet) This event has been changed. Title: Adyen : Wikimedia Placeholder for technical call When: Weekly from 6am to 6:30am on Friday from Fri Sep 17 to Thu Oct 14 Pacific Time -... [18:49:49] 10Fundraising-Backlog, 10FR-Ingenico: Swedish donations stuck at status 600 - https://phabricator.wikimedia.org/T246710 (10XenoRyet) This event has been changed. Title: Adyen : Wikimedia Placeholder for technical call When: Weekly from 6am to 6:30am on Friday from Fri Aug 20 to Thu Oct 14 Pacific Time -... [18:49:51] 10Fundraising-Backlog, 10FR-Ingenico: Swedish donations stuck at status 600 - https://phabricator.wikimedia.org/T246710 (10XenoRyet) This event has been changed with this note: "Adjusted time to the new time slot." Title: Adyen : Wikimedia Placeholder for technical call When: Weekly from 7:30am to 8am on... [18:50:20] lolol phab/google meet [18:55:47] ejegg: ah thx for catching that! [18:56:35] Google has switched calendar to a Phab-based system [18:57:00] argh can we remove phab from that meeting invite once and for all lol [18:57:36] or just once and for some [19:01:02] the swedish donations really want to see the new integration [19:16:09] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Roller Toaster, and 2 others: Add PendingTable::Consume API call that implements pending resolver outer loop - https://phabricator.wikimedia.org/T291225 (10Ejegg) a:03Ejegg [19:16:19] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Patch-For-Review: Production of Upsell Thank You email in Spanish-LATAM - https://phabricator.wikimedia.org/T292542 (10Ejegg) p:05Triage→03Medium a:03Ejegg [19:40:05] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 4 others: Would it be possible to have an 'Owns the Donor Advised Fund' field that would link that Individual ... - https://phabricator.wikimedia.org/T286520 [19:44:03] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Mandatory corn dogs, 10Fundraising-Backlog, 10fundraising Sprint NULL calorie food cart, and 5 others: Creating New Donor Advised Fund Import - https://phabricator.wikimedia.org/T283104 (10Eileenmcnaughton) [19:44:24] 10Fundraising Sprint Ketchup Flume Ride, 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 4 others: Would it be possible to have an 'Owns the Donor Advised Fund' field that would link that Individual ... - https://phabricator.wikimedia.org/T286520 [19:55:01] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen: recent 'MediaWiki internal error - fatal exception' errors - https://phabricator.wikimedia.org/T293131 (10EMartin) @dkozlowski. Please let me know if this should be raised with Adyen [19:56:30] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen iframe config error messages inside card fields - https://phabricator.wikimedia.org/T292571 (10EMartin) @dkozlowski. Please let me know if this should be raised to Adyen or if on our side. Thanks [19:57:16] fr-tech anyone have any feedback on those Apple Pay patches? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/720127 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/727675 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/720126 [19:58:40] reviewing now ejegg [19:58:51] rockin, thanks jgleeson ! [19:58:53] took a while to get remote debugging working [20:00:38] ejegg I could have some a bit later (and of course great if others do also!) [20:00:42] ejegg: did you get a chance to look again at the civi update - was thinking I'd push it out & then try my patch on CI again [20:01:01] not much eileen, maybe after this meeting I have with XenoRyet [20:01:08] cool [20:01:15] it looks good on staging though? [20:12:22] AndyRussG: maybe you could CR that exception fix? Feels like we should get that out today if possible https://gerrit.wikimedia.org/r/730878 [20:15:25] ejegg: sure! [20:16:07] ejegg: so nothing special needed to trigger the issue, I guess? [20:16:25] just having a payment_submethod set [20:17:53] oki [20:32:05] ejegg: it's actually giving me an error page [20:32:18] ooh, for real? [20:32:32] k, lemme test that again [20:33:00] ah damn [20:33:02] maybe it's something else I guess? no such on payments [20:33:13] yep, i see that locally too [20:33:14] looking [20:34:20] yeah error page with everything on master currently [20:34:24] locally [20:34:38] ok, we definitely should get that fix out then [20:35:36] hmm, hmm, trying to see why that would work on prod [20:35:57] ejegg: yeah I'm reviewing that patch now, and let's also figure out what's causing the local error for sure [20:36:00] ok, I DO see a very small number of errors in the log saying we displayed a fail page [20:38:11] ejegg: also to note, I definitely did not see these errors with the submethod patch before with the vanilla links in fr-dev, as I do now [20:39:12] those vanilla links generally don't have submethod though, right? [20:39:25] argh, it's blocking all Adyen iDEAL donations though [20:39:37] that one DOES have a submethod in the URL generally [20:42:14] (03CR) 10Jgleeson: [C: 03+1] "This is working great for me! I have a couple of questions and minor inline asks across this and the related patch but nothing blocking re" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/720127 (https://phabricator.wikimedia.org/T290108) (owner: 10Ejegg) [20:42:31] (03CR) 10Jgleeson: [C: 03+1] "This is working great for me! I have a couple of questions and minor inline asks across this and the related patch but nothing blocking re" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/720126 (https://phabricator.wikimedia.org/T290108) (owner: 10Ejegg) [20:42:44] thanks jgleeson ! I'll try to respond to all of those before my end of day [20:43:57] thanks! [20:44:32] functionality it's great ejegg. I just had a few minor asks and questions [20:44:42] functionally* [20:46:09] Also, if you do whizz through them when I'm offline later and AndyRussG is happy to give it the +2, feel free to do without me taking another look AndyRussG! [20:46:39] jgleeson: ah thanks for mentioning that, sounds like an option then! [20:52:22] ejegg: currently the failpage locally is triggered by the call to getPaymentSubmethodMeta on line 2591 of gateway.adapter.php [20:52:46] which happens when !empty( $knownData['payment_submethod'] is true [20:52:59] maybe it's something to do with session data i have that says the submethod [20:55:36] ejegg: yeah it's a session data thing, I guess if you make a donation then we know the submethod and that triggers the same codepath as if you set one on the URL [20:57:24] ejegg: what about though if there are other gateways that need that exception to be thrown sometimes? [20:57:36] maybe it'd be safer to just reinstate the submethod yaml file? [21:02:13] AndyRussG: i'm fairly confident this new patch is safe, but if you don't feel like you can +2 it today, sure let's just reinstate the yaml [21:02:39] I'd rather yeah just doing that patch now! [21:03:08] ejegg: it's not a matter of whether or not I can +2 it today, it's just that's a safer route to return to the previous behaviour [21:03:38] eileen: OK, what I've seen of that Civi patch looks fine. I guess I'm not going to become an expert in tokens overnight, but I trust the core team are headed in the right direction [21:03:40] then later we can take the time to ensure that no damage is done elsewhere by not throwing an exception there [21:03:51] ejegg: :-) [21:03:56] PROBLEM - Host frlog2001 is DOWN: PING CRITICAL - Packet loss = 100% [21:03:59] (03CR) 10Ejegg: [C: 03+2] 5.43.beta update to lastest code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/730359 (owner: 10Eileen) [21:04:14] yeah AndyRussG that's what i mean by can't +2 today [21:04:22] right [21:04:49] so do you want to put that reinstatement patch up? [21:04:49] ejegg: I mean, I could but it'd take time, and we have other priorities... so, take the quick-safe route and focus on Apple, does that sound right? [21:04:52] yep [21:04:55] ^^ that alert was me. host is back up [21:04:56] k [21:05:01] sounds good [21:05:13] RECOVERY - Host frlog2001 is UP: PING OK - Packet loss = 0%, RTA = 30.19 ms [21:05:31] 10Fundraising-Backlog: Regression from removal of payment_submethods.yaml for Adyen Checkout - https://phabricator.wikimedia.org/T293420 (10AndyRussG) [21:06:43] have a good one fr-tech bye for now [21:07:08] jgleeson|away: cya! [21:07:18] (03PS1) 10AndyRussG: Reinstate payment_submethods.yaml for Adyen Checkout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730910 (https://phabricator.wikimedia.org/T293420) [21:07:26] ejegg: ^ [21:09:38] (03CR) 10Ejegg: [C: 03+2] Reinstate payment_submethods.yaml for Adyen Checkout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730910 (https://phabricator.wikimedia.org/T293420) (owner: 10AndyRussG) [21:09:41] thanks! [21:09:47] ejegg: thank u for catching it!! :) [21:11:56] (03Merged) 10jenkins-bot: Reinstate payment_submethods.yaml for Adyen Checkout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730910 (https://phabricator.wikimedia.org/T293420) (owner: 10AndyRussG) [21:17:00] (03Merged) 10jenkins-bot: 5.43.beta update to lastest code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/730359 (owner: 10Eileen) [21:22:52] (03PS1) 10Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730911 [21:23:05] (03CR) 10Eileen: [C: 03+2] CiviCRM submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730911 (owner: 10Eileen) [21:36:16] ejegg: lmk if there's anything else on that specific bug I should do? I imagine you're planning to do a deploy, but if not lmk? thx!!!! [21:36:30] (03Merged) 10jenkins-bot: CiviCRM submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730911 (owner: 10Eileen) [21:45:40] (03PS1) 10Eileen: Vendor update [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/730916 [21:45:53] (03CR) 10Eileen: [C: 03+2] Vendor update [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/730916 (owner: 10Eileen) [21:46:54] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/730918 [21:47:13] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/730918 (owner: 10Eileen) [21:58:07] (03Merged) 10jenkins-bot: Vendor update [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/730916 (owner: 10Eileen) [22:07:49] !log civicrm revision changed from 018d3b19fe to 9b5e0d015b, config revision is 781d6a1b1f [22:07:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:13:59] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/730931 [22:14:08] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/730931 (owner: 10Ejegg) [22:14:55] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/730931 (owner: 10Ejegg) [22:15:17] ejegg thanks!! [22:17:17] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730932 [22:17:31] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730932 (owner: 10Ejegg) [22:23:55] (03Abandoned) 10Eileen: Switch from our custom token to core token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730683 (https://phabricator.wikimedia.org/T288698) (owner: 10Eileen) [22:24:10] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730679 (https://phabricator.wikimedia.org/T288698) (owner: 10Eileen) [22:27:43] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730932 (owner: 10Ejegg) [22:32:10] (03PS8) 10Ejegg: Get Apple Pay session from Apple [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/720126 (https://phabricator.wikimedia.org/T290108) [22:34:10] (03CR) 10Ejegg: "Thanks for the review jgleeson! PS8 addresses your comments." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/720126 (https://phabricator.wikimedia.org/T290108) (owner: 10Ejegg) [22:42:35] (03PS9) 10Ejegg: Get Apple Pay session from Apple [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/720126 (https://phabricator.wikimedia.org/T290108) [23:43:18] !log updated payments-wiki from 19d18c1852 to 0f48acea49 [23:43:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log