[00:17:38] (03PS1) 10AndyRussG: Explicitly make Amazon & Paypal gateways not show submethod buttons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731301 [00:25:04] (03PS4) 10AndyRussG: Remove continue button from HTML where hidden [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730957 (https://phabricator.wikimedia.org/T291143) (owner: 10Ejegg) [00:25:42] (03CR) 10AndyRussG: "(See inline comment for note about rebase... thx!)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730957 (https://phabricator.wikimedia.org/T291143) (owner: 10Ejegg) [00:26:54] (03CR) 10AndyRussG: "Just to note, I'm having trouble smoke-testing Amazon locally, so I'm not sure this works... ;p Thx!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731301 (owner: 10AndyRussG) [01:03:14] (03CR) 10AndyRussG: [C: 03+2] "Cool!!!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730647 (owner: 10Ejegg) [01:05:03] (03Merged) 10jenkins-bot: Add autocomplete to top-level form element [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730647 (owner: 10Ejegg) [01:59:48] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog: Regression from removal of payment_submethods.yaml for Adyen Checkout - https://phabricator.wikimedia.org/T293420 (10AndyRussG) [07:29:48] 10Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate, 10SRE, and 7 others: DBPerformance warning "Query returned XXXX rows: query: SELECT * FROM `translate_metadata`" - https://phabricator.wikimedia.org/T204026 (10Nikerabbit) 05In progress→03Resolved Thank you... [07:30:28] 10Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate, 10SRE, and 7 others: DBPerformance warning "Query returned XXXX rows: query: SELECT * FROM `translate_metadata`" - https://phabricator.wikimedia.org/T204026 (10Nikerabbit) [07:31:31] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Pick a CRM donation management software systems for the F2F campaign 2021 - https://phabricator.wikimedia.org/T281683 (10Jenny_Brandt_WMSE) Because of VAB the meeting was reschedueled [13:29:21] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731538 (owner: 10L10n-bot) [13:53:31] (03CR) 10Nikerabbit: [C: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731538 (owner: 10L10n-bot) [14:02:20] 10Wikimedia-Fundraising-Banners: [Enhancement] Add a continue button to monthly modal to allow donors to review their options before submitting a donation - https://phabricator.wikimedia.org/T287596 (10Pcoombe) 05Open→03Declined [14:03:34] 10Wikimedia-Fundraising-Banners: Update naming of dsk small main banner now it's not inline - https://phabricator.wikimedia.org/T271836 (10Pcoombe) 05Open→03Declined The banner is inline again :( We might still want to rename things for consistency with other banners, but not for this [14:05:08] 10Wikimedia-Fundraising-Banners: Meet target size guidelines for touch devices on desktop banners - https://phabricator.wikimedia.org/T250486 (10Pcoombe) [14:05:10] 10Wikimedia-Fundraising-Banners: [Enhancement] Update radio inputs to be larger buttons - https://phabricator.wikimedia.org/T255637 (10Pcoombe) [14:05:28] 10Wikimedia-Fundraising-Banners: [Enhancement] Include all questions in a single view - https://phabricator.wikimedia.org/T258631 (10Pcoombe) 05Open→03Declined [14:06:44] 10Wikimedia-Fundraising-Banners, 10FR-Italy: Notifications overlay on top of WYDG for logged in users - https://phabricator.wikimedia.org/T279404 (10Pcoombe) 05Open→03Resolved a:03Pcoombe [14:45:00] 10Wikimedia-Fundraising-Banners: Share links disappear after clicking back [Otherwaystogive variant] - https://phabricator.wikimedia.org/T264256 (10Pcoombe) 05Open→03Declined [14:45:03] 10Wikimedia-Fundraising-Banners: 2020-09-30 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T263921 (10Pcoombe) [14:45:18] 10Wikimedia-Fundraising-Banners: RML link disappears after clicking back on form [modal5] - https://phabricator.wikimedia.org/T266123 (10Pcoombe) 05Open→03Declined [14:45:20] 10Wikimedia-Fundraising-Banners: [CANDIDATE] QA for WYDG variants - https://phabricator.wikimedia.org/T265925 (10Pcoombe) [15:30:15] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:(Need By: TBD) rack/setup (4) fundraising hosts - https://phabricator.wikimedia.org/T289812 (10Cmjohnson) [15:43:18] fr-tech I'm getting some errors locally while fiddling with Ingenico, on some non-whole donation amounts, for example, when trying to donate $4.44, I get this back from Ingenico: INVALID_VALUE: '444.00000000000006' is not a valid value for field 'amount' [15:43:46] AndyRussG: argh, rounding problems! [15:43:59] I think that must be happening in the json_encode? [15:45:14] I think there's a phab for that [15:45:16] ejegg: yeahhh trying to check if it happens on prod [15:45:35] it happened for $4.44 and $2.01... [15:46:09] AndyRussG: on prod? [15:46:45] echo(json_encode(['blah' => 4.44 * 100])); [15:46:48] {"blah":444.0000000000001} [15:47:10] ejegg: it happened locally, trying to see what prod does [15:47:17] echo(4.44 * 100); [15:47:19] 444 [15:47:34] https://phabricator.wikimedia.org/T253237 [15:48:06] cstone: we set some floating point precision setting on prod to stop it, right? [15:48:44] hmm so we should add the same setting to our local setup, no? [15:49:09] yep [15:49:14] https://phabricator.wikimedia.org/T265279 [15:49:25] cstone: thanks!!! [15:50:17] also fr-tech I'm unable to get a form from payments right now!? anyone else seeing this? just tried over both my ISP wifi and phone tethering... [15:50:50] oh huh it works going from donate wiki [15:51:02] oh now it works [15:51:05] yeah, i got one from donatewiki just now [15:51:20] maybe some temporary high-level network routing thing? [15:51:53] hmm this link doesn't work tho: http://payments.wikimedia.org/index.php?title=Special:IngenicoGateway&appeal=JimmyQuote&ffname=rcc-vmad&payment_method=cc&recurring=1&uselang=en&language=en¤cy=USD&country=US&amount=4.00&first_name=Jimmy&last_name=Wales&street_address=1+Montgomery+Street&city=San+Francisco&state_province=CA&postal_code=94104&email=jwales%40example.com [15:52:17] Hmm I was able to donate [15:52:46] oh no, now cstone has another recurring [15:52:59] i see a form there at least [15:53:01] Haha I had lag I just did a one time [15:54:48] oh I see my dumb browser is trying http hahah sorry for the bother [15:55:26] oh heyyyy, a bunch of CR came through... is Apple Pay... dare I say it? deployable??? [15:55:54] ejegg: if not, pretty darn close eh! [15:56:23] thanks! [15:58:40] ejegg: we could finish off the button flash thing [15:58:51] (03PS1) 10Ejegg: Update smash-pig library for Apple Pay [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/731780 [15:58:55] (03CR) 10Ejegg: [C: 03+2] Update smash-pig library for Apple Pay [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/731780 (owner: 10Ejegg) [15:59:47] ejegg cstone fr-tech also any guidance on how to test the iDEAL recurring stuff, and also a summary of the actual state for Advancement Standup? (notes here: https://etherpad.wikimedia.org/p/fr-tech_2021-10-18_standup_notes) ? [15:59:56] thx in advance and apologies for so many pingz [16:02:15] AndyRussG: oh, let me peek at that CR [16:02:21] it's pretty quick eh [16:02:33] also a new mini patch (though not able to fully test here) [16:03:36] (03CR) 10jerkins-bot: [V: 04-1] Update smash-pig library for Apple Pay [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/731780 (owner: 10Ejegg) [16:05:06] ok, i'm a bit loath to remove the unused gateways as a prerequisite to the apple pay deploy [16:05:13] that felt more like a january cleanup to me [16:05:22] ejegg: sure [16:06:00] (03CR) 10Ejegg: [C: 03+2] "recheck" [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/731780 (owner: 10Ejegg) [16:06:44] maybe just reinstate the css rule for #paymentContinue.force, and leave that code in the Mustache template, too, then? maybe adding a TODO reminder about that? [16:07:15] (that is, about removing it later) [16:07:58] that would also change other gateway logic as little as possible [16:09:58] ejegg: oh sorry maybe I misunderstood ^ ? and also maybe I wasn't clear? I wasn't suggesting removing the unused gateways now [16:10:17] rather there's the new patch that I rebased yours on top of [16:11:27] and so if that patch (previously discussed) seems OK to do now, I feel we can indeed remove #paymentContinue.force css rule and the mustache template code that adds that class [16:11:58] I hope that makes sense [16:13:56] (03PS2) 10Ejegg: Explicitly make Amazon & Paypal gateways not show submethod buttons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731301 (owner: 10AndyRussG) [16:14:00] (03CR) 10Ejegg: [C: 03+2] Explicitly make Amazon & Paypal gateways not show submethod buttons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731301 (owner: 10AndyRussG) [16:14:47] AndyRussG: oh, there are other css rules that can go away along with that patch of yours, aren't there? [16:15:03] ohhh could be, I didn't check eh [16:16:37] (03Merged) 10jenkins-bot: Update smash-pig library for Apple Pay [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/731780 (owner: 10Ejegg) [16:20:38] AndyRussG: I wrote an essay for ideal in my end of day on friday haha but patches are in review and it is kind of a pain to test [16:20:40] AndyRussG: so the 'force' rule removal in adyen checkout is because we're not rendering the thing at all [16:22:50] i think MAYBE it' [16:22:57] s still in use for some astropay forms\ [16:23:09] so I'd rather not just completely remove that mustache bit right now [16:24:36] ejegg: ok so maybe reinstate the css rule? or is it also added in a different css file I missed? [16:25:50] cstone: right, thanks!! so I was just wondering how to create a recurring ideal donation locally to test with..... or is that there, and I missed it? [16:26:49] (03CR) 10Ejegg: "Thanks for the code review!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730957 (https://phabricator.wikimedia.org/T291143) (owner: 10Ejegg) [16:26:56] (03PS5) 10Ejegg: Remove continue button from HTML where hidden [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730957 (https://phabricator.wikimedia.org/T291143) [16:27:42] AndyRussG: there's a css rule to SHOW the continue button when force is added - that rule is in forms.css [16:27:58] the one I removed was in the adyen checkout css file [16:28:24] because we're no longer rendering the continue button in the html, neither with nor without the force class [16:28:32] so just for adyen checkout, it's unneeded [16:29:03] in the amazon css we had a rule for the same reason [16:29:21] but instead of specifying .force, we used a !important intensifier [16:29:43] now since we stopped rendering the button in the HTML for Amazon, we remove that rule too [16:31:15] does that sound good? [16:31:47] ejegg: yes sounds great! sorry I missed that, my bad [16:32:40] cool cool. i am alway happy to see suggestions to complete the cleanup [16:33:03] heheh thx [16:33:33] oh yeah, there' [16:33:43] s one amazon css rule that we can delete thanks to your patch [16:34:05] maybe I'll fold that in to my patch [16:34:29] ejegg: ah sure, or add a new one if you prefer... did you see that I was not able to smoke-test Amazon locally eh? [16:34:39] (03PS6) 10Ejegg: Remove continue button from HTML where hidden [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730957 (https://phabricator.wikimedia.org/T291143) [16:34:45] k, looking now [16:35:00] oh, maybe we need to add the new docker address to the allowed origins on amazon [16:35:10] something like that yeah [16:35:23] also surprised the port is not there on there on the return it's trying [16:35:37] if you're able to verify amazon locally though we can fix the local setups later [16:35:47] it'd be nice to merge this before standup in a few! [16:35:50] yep [16:35:59] k, will try with my non-docker wiki [16:36:57] thx [16:37:27] oh damn, they want a one-time-password for my amazon pay test user now???? [16:37:34] well, the form looked good before the redirect... [16:37:55] booo, it's using a non-functional email address on my own domain too [16:37:57] hi fr-tech just catching up on back scroll. what's goin on? [16:38:03] lessee, does that get forwarded to postmaster [16:38:12] jgleeson: just trying to merge a couple last patches for Apple Pay [16:38:19] in the hopes of deploying shortly :) [16:38:38] nice! was there more to review after the two we did last week [16:39:19] just one last patch, just smoke testing the latest version now :) [16:39:36] sweet, got the OTP out of my mail spool [16:39:49] oooh, but... yeah, we need a slight edit to the amazon JS [16:40:23] ejegg: funny it also kept redirecting immediately to Amazon (every time except the first, maybe?) [16:40:41] (03Merged) 10jenkins-bot: Explicitly make Amazon & Paypal gateways not show submethod buttons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731301 (owner: 10AndyRussG) [16:40:50] is the amazon js edit due to the changes in that patch? we could separate it out I guess [16:41:17] AndyRussG: it was using '.submethods' as an anchor to find where to insert the amazon widgets [16:41:26] so now that we're not rendering that we need a new anchor [16:41:26] ahhhh [16:41:36] hmmm [16:41:53] oh wait, that is still in the html here [16:42:09] hmm, why aren't those widgets visible then [16:42:17] ejegg: we could un-rebase (or re-rebase onto master) the Apple Pay flash one, since that requirement was based on my misunderstanding there [16:42:31] no js errors [16:42:56] heh, and revert - i +2ed yours in a dumb hurry [16:43:19] yeah, maybe I'll revert for now and restore the earlier PS of my patch [16:43:41] ejegg: I mean if it's just a few minutes to not revert and actually fix it, that's another option? [16:43:53] no big deal if we're not all merged within 20 min [16:43:56] well, I'm just not sure what's happening with the Amazon form [16:44:19] i see the holder divs being created in the HTML [16:44:25] just no content rendered [16:44:50] boo, reload and it works [16:45:42] cstone: thanks for the note in the etherpad for the Advancement standup... the info I feel I'm missing is an overview of the status of iDEAL reucrring... sorry if I'm not remembering this right... are we currently getting iDEAL recurrings via new Adyen but aren't able to charge them when they recurr, something like that? [16:45:53] cstone: or I could just hand the update off to you for that part? [16:46:12] right now they cant make new ones [16:46:26] i guess I was making it vauge cause i don't want to freak out evelyn or donor relations [16:46:44] AndyRussG: well, now amazon looks like it's working great locallyh [16:46:53] as its technically broken [16:46:55] maybe I should try another browser [16:47:58] AndyRussG: charging ones that are already there is fine but cant make new ideal recurrings at the moment, just one times [16:48:10] ok got it [16:48:10] ok, other browser looks good too [16:48:24] maybe i just had something cached in normalbrowser? [16:48:45] ejegg: hmmm... any idea why it was redirecting to Amazon right away for me? is it supposed to do that? [16:48:48] AndyRussG: so locally Amazon and PayPal look good [16:49:02] AndyRussG: yep, you have to log in at Amazon's site [16:49:08] then it bounces back to our site [16:49:09] ah ok [16:49:14] and we can render the card widget [16:49:19] there's another flow with a popup window [16:49:24] ejegg: ok I'm within 2 minutes of +2'ing the btn flash patch one sec [16:49:49] but someone thought the popup login flow was inferior [16:51:55] ah ok got it [16:52:14] Safari Apple Payment native widget says "bling" [16:52:22] :) :) :) [16:53:53] (03CR) 10AndyRussG: [C: 03+2] "Woohoo for ApplePay "bling" noises, thanks for all this!!!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730957 (https://phabricator.wikimedia.org/T291143) (owner: 10Ejegg) [16:56:05] (03Merged) 10jenkins-bot: Remove continue button from HTML where hidden [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730957 (https://phabricator.wikimedia.org/T291143) (owner: 10Ejegg) [16:58:08] ejegg: wrt to deploying to production, did we sort out that production cert? [16:58:27] did Matt do that for us? [16:58:37] jgleeson: we have the domain verified [16:58:51] i just had to work with dwisehaupt to get the .well-known path allowed [16:59:11] we DO need to deploy the matching cert [16:59:21] in the localsettings repo [16:59:27] just checking emails, think he sent that over a while back [16:59:55] i'm not sure, but that might require a slight update to the fundraising_code_update code [17:00:11] might just be plucking yamls from smashpig config at this point [17:00:30] yep yep, we have it, just needs to go up to the prod machines in the right place [17:15:05] ejegg: that email contains the prod and test payment processor certs [17:21:56] oh hey I think we only need to send the prod cert to Adyen [17:22:32] fr-tech heyyy anyone have any objections if I add more proxy domains on our cloud project, this time for everyone's IPN listening enjoyment? [17:24:27] makes sense to me AndyRussG [17:24:46] you just gonna assign a different port range? [17:25:09] fr-tech I've got to do an errand, back soon hopefully [17:25:19] have fun ejegg [17:25:49] jgleeson: sounds like a good idea, yeah, and I guess also call them payments-ipn-test[1-6] or something? [17:26:29] that way we can add more to either type, if needed, and have a clean separation, including the fr-dev convenience code for connection setup [17:27:03] It would be nice too to know who's urls are who's in the adyen test console too [17:28:20] we could manage that in a similar doc maybe [17:28:29] Yeah [17:30:46] oki cool [17:31:38] speaking of docs, I removed the WIP testing instructions from the list of Apple Pay related links originally set up to give folks easy access to those docs https://www.mediawiki.org/wiki/Fundraising_tech/Adyen#Apple_Pay [17:32:41] I feel like the Apple Pay flow is a good opportunity to make use of https://sequencediagram.org/ again [17:35:38] jgleeson: ah yeah agreed, also see https://phabricator.wikimedia.org/T288403 and https://phabricator.wikimedia.org/T141617 [17:36:26] AndyRussG: not sure if I really answered your question with how to test but with those three patches you can create a new ideal recurring, it'll be right on adyens side, and then it'll send the new type of ipn there's a lot of queue management too I'll write up something [17:36:40] 2016! [17:41:46] the year that was... but wasn't for our sequence diagrams [17:42:40] cstone thx, I think so... ahhh almost! so how do I create a new iDEAL recurring? do I have to use a monthly convert variant? recurring = 1 seems to do naught [17:44:18] Just recurring 1 [17:44:43] cstone: but I don't see anything on the form saying it's gonna make it recurring? is that supposed to be that way? [17:44:52] It should change to monthly [17:44:58] The words at the top [17:46:11] cstone: ahhh your right, sorry I missed that, thanks! [17:50:46] 10Fundraising-Backlog, 10FR-Docker: Docker dev setup: Fix Amazon testing setup - https://phabricator.wikimedia.org/T293674 (10AndyRussG) [18:20:45] AndyRussG: formatting is a mess, ill clean up but steps here: https://www.mediawiki.org/wiki/Fundraising_tech/Testing#Adyen_-_iDEAL_Recurring [18:21:38] cstone: ah fantastic thx so much eh :) [18:28:42] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Kris Hancock - https://phabricator.wikimedia.org/T293678 (10MBeat33) [18:28:44] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Amber Johnson - https://phabricator.wikimedia.org/T293679 (10MBeat33) [18:29:25] (03PS1) 10Cstone: Script to get you into the SmashPig container [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731791 [18:49:10] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Amber Johnson - https://phabricator.wikimedia.org/T293679 (10Dwisehaupt) [18:50:03] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Kris Hancock - https://phabricator.wikimedia.org/T293678 (10Dwisehaupt) [18:57:06] (03PS1) 10Jgleeson: WIP test our Adyen JS callbacks. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731799 [18:59:06] (03CR) 10jerkins-bot: [V: 04-1] WIP test our Adyen JS callbacks. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731799 (owner: 10Jgleeson) [19:05:26] (03PS2) 10Jgleeson: WIP test our Adyen JS callbacks. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731799 [19:06:12] (03PS3) 10Jgleeson: WIP test our Adyen JS callbacks. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731799 [19:08:14] (03CR) 10jerkins-bot: [V: 04-1] WIP test our Adyen JS callbacks. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731799 (owner: 10Jgleeson) [19:10:33] fr-tech is anyone up for a little TY template review? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/730246 [19:11:59] ejegg: sure, this is an email template right? [19:12:08] yes damilare [19:12:43] it's specifically for people who give a one-time gift, then when they see the monthly convert dialog asking them to add a monthly donation, click 'yes' [19:13:03] Ohh ok, that makes sense [19:13:45] Seems to be in spanish, is the specific to only the es locale or are there other changes coming up in the other locales [19:14:08] ejegg: damilare can test that on staging right? [19:14:12] i think just spanish for now [19:14:22] jgleeson: oh yeah, i think so! [19:14:32] have you gone over that procedure yet? [19:14:40] no I haven't [19:15:03] figure it will be a bit quicker than setting up mailcatcher or an equivalent [19:15:17] ejegg: jgleeson damilare its the recurring_notification template [19:15:19] in the test page [19:15:27] damilare: so for staging CiviCRM, we are able to directly check out unmerged git changes from gerrit [19:15:55] Ok [19:15:58] yep, then once we check it out we will be able to use the test page with the template cstone mentions [19:16:25] damilare: so you'll want to ssh into frdev1001 [19:16:48] and go into the civicrm dir under /srv [19:16:58] I think it starts with org.wikimedia [19:17:20] ok, on it [19:17:52] then you can copy the anonymous http checkout command from the gerrit page [19:17:56] git fetch https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm refs/changes/46/730246/1 && git cherry-pick FETCH_HEAD [19:18:32] oh right, just make sure you're in the 'crm' root and not the 'crm/civicrm' subfolder, since the subfolder is a different repository [19:19:17] so I'm in this dir /srv/org.wikimedia.civicrm [19:19:23] yep, that's right [19:19:30] cool [19:20:00] done [19:20:13] ok, so now you should be able to log into the staging site [19:21:02] and look for 'Test Thank-you letters' on the left side list of links [19:21:17] Ok, but sorry what's the url to civi staging [19:21:54] damilare: I pasted it in the private channel [19:27:58] I've being able to login and I also found the link. [19:28:27] I selected the es locale and checked the "is a recurring donation" checkbox [19:31:24] cstone also added a WIP for mailcatcher to fr-dev btw [19:31:41] yeah it just doesnt have the fancy port picking so i left it as WIP [19:37:49] 10Fundraising-Backlog: Wikimedia NOT accepting notifications for Adyen - https://phabricator.wikimedia.org/T292766 (10XenoRyet) We can go ahead and close this again. From the FR-tech perspective we're getting the notifications we need when we want them, and everything appears to be properly configured as we sit. [19:37:59] 10Fundraising-Backlog: Wikimedia NOT accepting notifications for Adyen - https://phabricator.wikimedia.org/T292766 (10XenoRyet) 05Open→03Resolved [19:53:44] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen: recent 'MediaWiki internal error - fatal exception' errors - https://phabricator.wikimedia.org/T293131 (10jgleeson) We've managed to recreate this on production by deliberately entering some invalid card data e.g. cvv alongside valid input. When d... [19:59:52] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen: recent 'MediaWiki internal error - fatal exception' errors - https://phabricator.wikimedia.org/T293131 (10EMartin) @jgleeson. Should this be raised with Adyen? [20:00:21] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen: recent 'MediaWiki internal error - fatal exception' errors - https://phabricator.wikimedia.org/T293131 (10Ejegg) no @EMartin , this is all due to our code [20:26:29] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen: recent 'MediaWiki internal error - fatal exception' errors - https://phabricator.wikimedia.org/T293131 (10EMartin) Thank you [20:40:01] (03CR) 10Damilare Adedoyin: "Hi Eliott I tested and this looks good, I left a little comment please review and let me know what you think." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730246 (https://phabricator.wikimedia.org/T292542) (owner: 10Ejegg) [20:41:15] (03PS1) 10Jgleeson: Set memcached as the defaut cache backend for payments. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731834 [20:41:40] AndyRussG: I just tested memcached out with the running container and got it working with that change ^ [20:47:18] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo: Add existing donor matching to PendingTransaction::resolve - https://phabricator.wikimedia.org/T291226 (10jgl... [20:52:19] jgleeson: ahh fantastic thanks!!! [20:53:03] (03PS2) 10Jgleeson: Set memcached as the default cache backend for payments. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731834 [20:53:28] jgleeson what was the error due to that again? [20:54:18] (sorry for not recalling... ahh also apologies for interrupting your update a little while ago to respond on that..........) [20:54:48] sorry AndyRussG not sure what you mean [20:59:12] I don't think there was an error related to memcache we just switched it over to use it from APC [20:59:49] jgleeson: right but so was something not working or not working well, that caused you to dig in? [21:00:01] no worries if not of course [21:00:28] just since I didn't remember something specific, I thought I'd ask 8p [21:00:47] also for just testing out the patch [21:02:30] hmmm also to note, I wonder what was using the mecached image before? I do remember something requiring it [21:02:46] we were looking at how the IP velocity filter was working and noticed in the comments in was referring to storing IPs in memcached but we weren't using memcached locally [21:03:07] they were being stored in APCi [21:03:10] APCu [21:03:32] ahh got it thanks [21:03:58] sorry for having missed that [21:04:19] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/891e514cbf16bc55ca30b8c0ba5f612a2147e5db/extras/custom_filters/filters/ip_velocity/ip_velocity.body.php#L52 [21:04:23] no problem! [21:06:35] ok now I'm confused [21:07:29] I just looked over the production LocalSettings and it looks like we are using both APCu and memcache [21:09:48] APCu for main and memcache for sessions [21:09:59] oh ok that may be why it's like that in Docker then [21:10:26] hmm I think docker just uses one [21:11:00] there's a line in production $wgDonationInterfaceMemcacheHost = 'localhost'; which is commented out in fundraising-dev but I don't think that does anything [21:12:25] $wgMemCachedServers = $hwgMemCachedServers; [21:12:32] that looks like a typo [21:12:34] on production [21:13:01] ejegg: do you know if we actually use memcache to store fraud filter info? [21:13:11] the code says we does but the config says we don't [21:13:44] time for bed [21:13:46] bye for now [21:14:20] (03CR) 10AndyRussG: Set memcached as the default cache backend for payments. (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731834 (owner: 10Jgleeson) [21:14:35] jgleeson|away: cya! [21:15:10] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Impact day - https://phabricator.wikimedia.org/T292519 (10Jopparn) [21:15:41] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Prepare and participate in the Impact day event - https://phabricator.wikimedia.org/T292519 (10Jopparn) [21:15:53] also here's an explanation of the $hwgMemCachedServers: https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/dev/+/refs/heads/master/config/payments/LocalSettings.php#269 [21:16:18] jgleeson|away: oops, yeah, we should be using it for ip velocity [21:17:09] ejegg: memcached or apcu? [21:17:44] memcache, as far as I remember [21:27:42] ah oki [21:30:22] ah, i want to make one tiny change for the gateway form switcher [21:31:14] i think those form settings need to include the 'apple' payment method [21:35:39] (03PS1) 10Ejegg: Add Apple Pay to formSettings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731841 [21:36:00] fr-tech can anybody review that little form settings patch? ^^^ [21:36:37] I based the " => [ 'ALL' ] " on how we're specifying amazon and paypal [21:39:29] thanks ejegg I'll check it out in a bit [21:40:14] (03PS3) 10Eileen: Switch our recurring fail mail to use the new methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730961 (https://phabricator.wikimedia.org/T288698) [21:50:55] (03PS4) 10Eileen: Switch our recurring fail mail to use the new methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730961 (https://phabricator.wikimedia.org/T288698) [21:57:25] OK - I think the new recurring failure stuff is working with the new method - keen for someone else to kick the tyres on it too now... [22:01:55] (03CR) 10jerkins-bot: [V: 04-1] Switch our recurring fail mail to use the new methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730961 (https://phabricator.wikimedia.org/T288698) (owner: 10Eileen) [22:02:09] (03PS1) 10Ejegg: Clean up obsolete or repeated payments-wiki settings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731845 [22:02:21] AndyRussG: I noticed a few things to clean up ^^^^ [22:02:29] we can probably clean up some of them on production as well [22:03:13] Ohh cool [22:03:36] (03PS5) 10Eileen: Switch our recurring fail mail to use the new methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730961 (https://phabricator.wikimedia.org/T288698) [22:09:28] (03PS1) 10Eileen: Add permissions to engage role per live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731846 (https://phabricator.wikimedia.org/T279686) [22:14:24] (03CR) 10jerkins-bot: [V: 04-1] Add permissions to engage role per live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731846 (https://phabricator.wikimedia.org/T279686) (owner: 10Eileen) [22:19:26] (03PS2) 10Eileen: Add permissions to engage role per live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731846 (https://phabricator.wikimedia.org/T279686) [22:37:03] (03CR) 10Ejegg: "This looks really good at first glance! I see a lot of the Job properties carried over from the original class aren't used in either place" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/731188 (https://phabricator.wikimedia.org/T284606) (owner: 10Cstone) [22:44:18] fr-tech oh hey, so now that we have the new forwarding URLs and ports, we should make the SmashPig endpoint listen on http [22:44:27] and maybe it doesn't even need https, right? [22:53:45] Ohh good point ejegg [23:08:18] hmm, i'm trying a very similar script to forward 8102 to localhost:9006 (now on http) [23:10:24] ohh noice [23:11:09] ejegg: if you're copypasta-ing maybe check out my tiny re-format script (tabs instead of spaces, as is used in other scripts in the repo, and shortens long lines, is all) [23:11:29] fr-tech: iptables rules should be in place on all payments servers now. [23:11:36] for applepay that is. [23:11:50] woohooo thanks dwisehaupt [23:12:36] the rules were in the pfw's on a previous change, so it should be good. [23:12:51] thanks! [23:13:32] oh hmm, maybe the test servers need the new IPN ports explicitly opened! [23:15:41] yep, looks like they needed that [23:15:55] so let's see, maybe we have to wait for the puppet agent? [23:16:45] oh right, we can run that [23:18:08] \woot, that did it [23:20:18] ohhh right [23:20:31] cool cool, i see the auth IPN in the logs [23:20:37] ah fantasmic :) :) [23:21:59] still waiting for the recurring contract IPN though [23:22:10] oh hmm, do I need to subscribe to a different webhook? [23:22:43] nope, there it is! [23:22:52] it takes a bit sometimes yeah [23:23:17] oh derp, but I didn't have your code pulled down in the standalone SP checkout [23:23:20] just in the vendor one [23:23:24] OK, lemme do that again [23:24:34] cstone: so is the gateway_txn_id the only thing missing from that first pending message? [23:25:47] yeah [23:26:11] oh no sorry ejegg [23:26:13] ahhh, I see, and the pspReference & originalReference from the contract are not the same txn ID [23:26:21] that is from the IPN [23:27:19] utm_source ..rrtbt sounds like a hesitant frog [23:28:44] lol [23:28:47] hah ok yeah ejegg the txn_id is the only thing missing from the first pending message [23:29:31] ok cstone, never mind that comment I made in gerrit about maybe we don't even need the one from the pending table [23:30:38] cstone did you say you had a script to consume the pending queue? [23:31:13] AndyRussG: oh i just saw your suggestion re the reformat. Thanks! [23:31:20] i made one to get into the smashpig container you just have to run maintence/consumependingqueue [23:31:29] imagine thats spelled right [23:31:41] ejegg: thank u :) [23:35:11] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731280 (owner: 10AndyRussG) [23:39:07] (03PS1) 10Ejegg: Script to forward IPN listener ports [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731856 [23:44:52] (03PS1) 10Eileen: Dedupe deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731857 [23:48:57] (03PS1) 10Ejegg: Generic SmashPig maintenance script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731859 [23:49:52] cstone: ^^^ sorta helps with the consume