[00:06:25] (03PS2) 10Ejegg: Generic SmashPig maintenance script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731859 [00:09:55] cstone ok, i found where we are getting that second pending message [00:26:14] and it's from when the donor comes BACK to paymentswiki [00:26:21] I don't know if we can rely on that [00:26:50] I wonder if we can do something like make the pending queue consumer update an existing message with new info [00:27:42] from one of the auth ipns? [00:29:02] yeah, exactly [00:29:33] oh hey, we ARE doing something similar with the capture request, right? updating the pending message with an extra key? [00:37:05] oh derp, qc failing with invalid currency EUR [00:37:22] right, I was trying to give that a fallback a while ago and never made it work [00:38:16] ohh, and we need to add the smashpig database to the drupal settings so we can peep damaged messages locally [00:39:36] oh yeah i have a hack to fix that [00:39:40] the currency thing [00:40:27] (03CR) 10AndyRussG: [V: 03+2] Formatting details in payments-proxy-forward.sh (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731280 (owner: 10AndyRussG) [00:41:02] my hack is just your patch basically i think it was just failing tests [00:47:48] man, i wish i could figure out why [00:48:41] * ejegg visualizes passing tests as he hits the 'rebase' button [00:48:58] (03PS4) 10Ejegg: Fall back to hardcoded exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 [00:49:45] come on tests! [01:00:25] (03CR) 10jerkins-bot: [V: 04-1] Fall back to hardcoded exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 (owner: 10Ejegg) [01:00:29] dang, I must not have been manifesting hard enough [01:01:23] like, how the heck is it making the cyrillic merge conflict tests fail? [01:02:04] yeah im pretty sure the original test failures didnt make sense too [01:04:20] those 'testDiacriticConflicts' tests don't even make any contributions [01:12:28] ohhh so there's somethign that's not getting cleaned up from a much earlier test, apparently [01:12:52] the 'skipped' array alwyas has an extra main_id => 225 / other_id => 226 [01:13:36] ok, guessing those were the contacts created for the one test (much earlier in the run) that's marked in error [01:13:54] it's just that the cyrillic merges are overly sensitive to bad cleanup [01:14:10] so lemme see why BitpayFileTest::testImport might fail [01:15:32] so it's definitely doing something with EUR [01:24:57] ok, and it fails locally with that patch [01:25:05] hmm, but debug isn't happening [01:25:26] ah right, i had remote autostart off [02:11:03] ah hah! the test WAS relying on the non-USD donations not getting in [02:20:46] it wasn't cleaning itself up then causing chaos? [02:21:28] so it wouldn't clean up unless that query worked [02:21:47] that $this->contacts array in the tests is the list of things to clean up in tearDown [02:22:08] and it was only adding the contact by the 'id' index of the api query [02:22:25] only with the fallback, there were suddenly a long list of contacts matching the query [02:22:36] and the 'id' index only exists when there's a single result [02:22:58] so that meant the duplicate fox mulders were sticking around [02:23:07] and then interfering with the dedupe tests later [02:23:18] ok, let's see if this patch fixes it [02:24:32] ahh [02:25:02] (03PS1) 10Ejegg: X-Files acquired by Disney [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731866 [02:25:56] (03PS5) 10Ejegg: Fall back to hardcoded exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 [02:25:58] haha [02:26:08] sad but true :( [02:26:31] if youre on the mouse list is that how you end up in mouse jail? [02:26:50] lol [02:27:06] this mouse hunt might have more permanent consequences [02:27:07] we were discussing mouse jail in the security line to get in and people behind us were like is there a mouse jail????? [02:27:22] but in our situation mouse jail is when my friends got yelled at for standing up on the caroseul [02:27:23] haha [02:28:32] ducks are mice too comment haha [02:30:52] lol [02:35:04] X files aquired by Disney - lol [02:36:02] (03CR) 10Eileen: [C: 03+2] X-Files acquired by Disney [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731866 (owner: 10Ejegg) [02:36:12] thanks Eileen! [02:36:22] argh [02:36:34] so the test now fails instead of erroring [02:36:39] i guess that's an improvement? [02:37:04] well, fails instead of erroring after the fallback patch is in place [02:37:11] hmm [02:37:11] trying again locally [02:37:26] (03CR) 10jerkins-bot: [V: 04-1] Fall back to hardcoded exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 (owner: 10Ejegg) [02:37:30] I think that bitpay has been a longstanding head scratcher [02:37:49] who woulda thunk it was part of the x files [02:40:45] well, it's an improvement for sure, the dedupe tests are passing in that last round [02:47:28] (03Merged) 10jenkins-bot: X-Files acquired by Disney [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731866 (owner: 10Ejegg) [02:51:44] ejegg: in the new cloud appleway setup how do I get it to go back on my local [02:52:17] or i dont know why all my adyens are suddenly broken haha [02:52:44] cstone: ohhhh, you mean the links from https://localhost:9001 all go to paymentstestXXX ? [02:52:52] I think that must be cached [02:53:00] i dont know im getting a weird error when im trying to do an adyen test payment [02:53:01] maybe restarting the memcache service? [02:53:03] lemme try [02:53:22] i dont remember what i was doing friday night haha [02:53:49] cstone IPN listener error or paymentswiki error? [02:53:55] payments wiki [02:54:00] i just restarted everything lemme see [02:54:14] hmm [02:54:24] i get the js alert but theres no logs that match what did i do [02:55:55] ok i broke something in adyen i can make an ingenico test payment [02:56:40] (03PS1) 10Ejegg: More BitPay cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731868 [02:56:54] (03PS6) 10Ejegg: Fall back to hardcoded exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 [02:58:12] oh hey, we should probably regenerate that exchange rate file for the big fundraiser [03:00:59] (03PS1) 10Ejegg: Update exchange rates [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/731869 [03:02:13] oof, turkish lira are having a rough year [03:03:20] PHP is more or less steady around 50 to the dollar [03:03:31] Philipine peso I'm guessing? [03:05:20] Is the EEK actually pegged at 13 to the dollar? [03:05:31] spooky... [03:05:36] eek [03:06:04] oh, it's been replaced by the Euro since 2011... We could maybe save ourselves some lookup fees [03:06:07] any ideas as to what i could have done to suddenly break adyen i dont remember touching any code [03:06:19] ah damn, what's the error? [03:06:22] i did pull on dev and i just reran setup.sh [03:06:32] its giving me the js alert error [03:06:40] but nothing actually error looking in the logs [03:06:45] arrrrgh [03:06:56] and you're doing a card payment? [03:07:00] card and ideal all do it [03:07:11] you and andy have been doing ideal so they arent broken hmm [03:07:40] if you look at what comes back from api.php in the browser dev tools, does that show anything useful? [03:07:44] (03CR) 10jerkins-bot: [V: 04-1] More BitPay cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731868 (owner: 10Ejegg) [03:08:06] (03CR) 10jerkins-bot: [V: 04-1] Fall back to hardcoded exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 (owner: 10Ejegg) [03:10:41] hmm ok well i have a better error now it cant find getValidationErrors [03:11:14] ohhh [03:11:21] that's a SmashPig library update [03:12:04] sorry, maybe we SHOULD be upping the min version in composer.json for all these little updates [03:12:34] oh is a * [03:13:33] aiii, it's late [03:14:45] (03PS2) 10Ejegg: More BitPay cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731868 [03:24:12] (03PS7) 10Ejegg: Fall back to hardcoded exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701604 [03:29:04] good night folks! [03:31:40] (03CR) 10Ejegg: "Looks good! Reading this I just noticed a couple of unrelated possible improvements and didn't want to forget them, so I added them as com" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/731185 (https://phabricator.wikimedia.org/T284606) (owner: 10Cstone) [03:32:04] (03CR) 10Eileen: [C: 03+2] "If it's passing I say 'lock it in caller'" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731868 (owner: 10Ejegg) [03:32:12] lol [03:52:10] (03PS4) 10Cstone: WIP: Handle Recurring Contract ipn notifcations for iDEAL recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/731188 (https://phabricator.wikimedia.org/T284606) [03:52:37] (03CR) 10jerkins-bot: [V: 04-1] WIP: Handle Recurring Contract ipn notifcations for iDEAL recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/731188 (https://phabricator.wikimedia.org/T284606) (owner: 10Cstone) [03:53:28] (03PS5) 10Cstone: WIP: Handle Recurring Contract ipn notifcations for iDEAL recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/731188 (https://phabricator.wikimedia.org/T284606) [04:54:04] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo: Unable to download the query data - Rakhi Fraud Scan - https://phabricator.wikimedia.org/T292370 (10Eileenmcnaughton) @RKumar_WMF - @Dwisehaupt has upped the url length the server pe... [12:41:22] hey damilare|away: you around for our call? [12:41:52] ahh I just realised it's a holiday in Nigeria [12:41:54] nvm! [12:45:27] hi fr-tech! [14:42:14] (03CR) 10Jgleeson: "lol" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731866 (owner: 10Ejegg) [15:08:26] hi jgleeson fr-tech :) [15:08:40] hey AndyRussG :)# [15:08:59] :) [15:09:23] howdy [15:14:16] (03CR) 10Jgleeson: "Thanks for looking at this and pointing out the existing Memcache servers block further down, we totally missed that. I'll remove this lin" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731834 (owner: 10Jgleeson) [15:17:09] XenoRyet: hey :) [15:17:33] howdy XenoRyet [15:24:14] (03CR) 10Jgleeson: "A little more on this, it looks like we stopped using memcache for the IPVelocity filter back in 2017 in this patch https://gerrit.wikimed" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731834 (owner: 10Jgleeson) [15:32:19] hey AndyRussG [15:32:32] little one liner here to find any duplicate wg vars in a file [15:32:35] `grep -wo "[[:alnum:]]\+" LocalSettings.php | grep wg | sort | uniq -c | sort -nr | less` [15:33:54] ahhh thanks! and heheh oops! [15:34:17] yeah the config and the global variables themselves are one more mess [15:34:41] just looking at e jegg's patch here: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/731845 [15:35:41] yeah I tracked down the patch he add which switched out memcache to mw main cache for that filter [15:36:04] ah interesting [15:36:22] also https://phabricator.wikimedia.org/T291799 (not justifying the erroneous duplication of vars in LocalSettings.php tho) [15:36:25] although it feels like that filter's data should be shared across the payments cluster [15:36:48] hmmm where else would it go other than payments wiki boxes? [15:37:08] that's the thing, it's not shared across the payments boxes if it lives in APCu [15:37:13] APC isn't a distributed cache [15:37:25] ahhh gotcha [15:37:27] right [15:37:55] I guess IIRC I heard the other day the loadbalancer does tend to repeat the boxes it sends a user to, but I guess definitely also not a given [15:38:12] I guess we can make a task? [15:39:08] just wanna speak to ejegg|away first to see if there was a reason for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/335868 [15:39:14] and moving away from memcache [15:39:25] yeee [15:40:30] oh here's an interesting one also https://phabricator.wikimedia.org/T143831 [15:42:02] is that related to our yaml usage? [15:42:41] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Epic: [Epic] Architecture, separation of concerns and refactors in DonationInterface (2021) - https://phabricator.wikimedia.org/T291697 (10AndyRussG) Ah here's another interesting one: {T130311}. [15:43:10] mentioned there anyway, not sure it's still relevant [15:47:43] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: DonationInterface config: Create a small tool to harmonize prod, staging, local dev and unit test config - https://phabricator.wikimedia.org/T293803 (10AndyRussG) [15:49:38] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: DonationInterface: Review, purge and document MW config variables - https://phabricator.wikimedia.org/T291799 (10AndyRussG) See also {T293803}. [15:56:22] jgleeson oh the reason is just that we wanted to use the same abstraction level for IPVelocity [15:57:01] and only have the cache connection defined once for IPVelocity and for normal MW caching operations [15:57:17] jgleeson: thanks again for that one-liner to search for duplicate settings... I just looked at all the duplicates it found in fr-dev, and they are all correct [15:57:26] so we still are using memcache for IPVelocity under the hood, just via the main object cache [15:58:15] all repetitions are mentions of the globals in comments, or included in the setting of other globals, or $global[] where we're setting or adding array keys [16:00:26] oh jeez, wait, just looked at the prod settings [16:00:35] and... we ARE using APCu? [16:00:54] Jeff_Green: do you remember any discussion about that? [16:01:25] ejegg: hrmmm, I dunno? [16:01:30] we seem to be using memcache for sessions but APC for other caches [16:02:29] I remember the recurring question of what exactly is in memcache, but I don't remember anything about the other caches [16:07:27] (03CR) 10Jgleeson: [C: 03+2] "This looks good, thanks!. After pulling this down, I managed to get the Apple Pay form up by using the following 'Special:GtewayFormChoose" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731841 (owner: 10Ejegg) [16:08:02] np AndyRussG ! [16:08:37] ejegg: I mentioned that last night [16:09:08] ah sorry jgleeson i must have been distracted [16:09:57] actually did I [16:10:11] either way, I guess we need to dig in more on how to proceed [16:12:03] AndyRussG: yeah the only one I spotted was the commented out memcache thingy. There's some false positives also in that one-liner as it doesn't handle array keys but it was the best I could come up quickly ha! [16:12:59] I like how you've split out the config like 1) defaults 2) payments 3) donationInterface .. I'd never noticed that but will now make use of it in future [16:13:09] jgleeson yeah for sure super useful, thanks again :) it's complicated enuf that really we need some kind of automation [16:14:26] (03CR) 10AndyRussG: Don't send new iDEAL recurrings to the donations queue (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731193 (https://phabricator.wikimedia.org/T284606) (owner: 10Cstone) [16:16:08] (03Merged) 10jenkins-bot: Add Apple Pay to formSettings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/731841 (owner: 10Ejegg) [16:38:53] (03CR) 10AndyRussG: "Nice, thanks for this!!! Quick question: what is the relationship with If107eacdf0907c2? Do we want both changes, or one or the other?" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731859 (owner: 10Ejegg) [16:40:03] (03CR) 10AndyRussG: "Nice, thanks for this!!! Quick question: what is the relationship with Ifb8f3446237fad18? Do we want both changes, or one or the other?" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731791 (owner: 10Cstone) [16:44:33] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: DonationInterface: Review, purge and document MW config variables - https://phabricator.wikimedia.org/T291799 (10AndyRussG) See also [[ https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/731845 | this change ]], including the commit mes... [16:58:35] (03CR) 10AndyRussG: "Thanks!!!!!!!!! Ahh let's also maybe update setup.sh (see inline comment) and README.md?" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731856 (owner: 10Ejegg) [16:59:12] cstone: am I imagining it or did you not add support for Apple Pay recurring? I feel like I remember seeing that [17:00:05] you did! https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/717712 [17:00:37] XenoRyet: just asked me on a call and I said yes... and then forgot when it was added [17:07:28] ohhh, so i should add apple to the recurring form settings too [17:12:37] Yeah it's there jgleeson|dinner [17:13:14] k, will add a follow-up patch [17:13:18] thanks for that cstone! [17:16:24] (03PS1) 10Ejegg: Add Apple Pay to recurring form settings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732013 [17:17:04] ok fr-tech I think with ^^^ done we can get going with the deploy [17:17:57] oh dwisehaupt and Jeff_Green i made a task to add the cert file to f_c_u: https://phabricator.wikimedia.org/T293721 [17:29:18] ejegg: i'll have a look, but right now i'm not seeing how to restrict that to just the payments hosts. i'll chat with Jeff_Green about what his thoughts were on it. [17:47:08] ejegg: ok. there isn't really a clean way to push this cert just to the payments* hosts using localsettings. we can do it easily with puppet and the private repo. i know there was discussion about how often we would have to rotate out this certificate so i checked. it is valid for 2 years, so the burden on rotation won't be heavy. [17:56:05] oh right dwisehaupt sound good [17:56:19] just let me know what directory it ends up in [18:00:00] willdo [18:08:14] cstone: do you have a sec to +2 this extra settings change to add the recurring forms? https://gerrit.wikimedia.org/r/732013 [18:08:31] yeah sorry ejegg I was going to look [18:09:43] (03CR) 10Cstone: [C: 03+2] Add Apple Pay to recurring form settings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732013 (owner: 10Ejegg) [18:09:46] ooh, the fallback is passing tests now! https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/701604 [18:09:59] thanks cstone! I'll get the merge to deployment ready [18:10:15] woo!! [18:10:18] too both [18:10:20] to* [18:10:27] cstone ejegg ^ currently smoke testing the form chooser stuff and getting errors, but I might be doing something wrong? [18:10:35] This one will be good for the dev environment fr-tech: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/701604 [18:10:40] AndyRussG: whay kind of errors? [18:11:31] index.php?title=Special:AdyenCheckoutGateway&appeal=JimmyQuote&ffname=adyen-us&recurring=&country=US SmashPig\Core\ConfigurationKeyException from line 134 of /var/www/html/vendor/wikimedia/smash-pig/Core/Configuration.php: Configuration key 'payment-provider//class' does not exist. [18:11:54] AndyRussG: so it's not passing the payment_method along? [18:12:11] weird [18:12:12] I'm trying this URL: https://localhost:9001/index.php?title=Special:GatewayFormChooser&country=US [18:12:21] ahhh, you need a payment_method [18:12:36] hmmm will we always have one there? [18:12:43] also do we need any Safari sniffing? [18:12:44] basically all the entry points to payments-wiki ask you to choose a payment method first [18:13:13] so they would do the safari sniffing upstream to decide whether to offer an apple pay button [18:13:32] (03Merged) 10jenkins-bot: Add Apple Pay to recurring form settings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732013 (owner: 10Ejegg) [18:14:00] ejegg: what about from like "ways to donate"? [18:14:53] I guess those go to donate wiki first? [18:15:23] how does Special:LandingPage on donate wiki know what stuff to offer? Is all the logic in GatewayFormChooser repeated there somehow? [18:17:15] Donatewiki has all its own logic [18:17:40] in Extension:FundraiserLandingPage or on-wiki? [18:17:42] doesn't reuse anything from payments except the exchange rates and the messages as far as I recall [18:17:47] mostly onwiki [18:17:54] ok [18:18:09] is that awful, or am I misunderstanding something? [18:18:12] I think the 'ways to donate' page has separate links for each method, with the method in the URLs [18:18:43] AndyRussG: yeah, it sure would be nice to change that [18:18:50] the form chooser is pretty silly too [18:18:56] it shouldn't need a whole separate settings page [18:19:12] it should just be able to query the supported methods + currencies of each adapter [18:19:23] + countries [18:19:42] sorry, settings file, not settings page [18:20:07] there's a phab for that withering in some dark corner [18:20:25] ejegg: right so basically we have three places that sniff out what methods to show the user: in-banner js, donate wiki on-wiki code in conjunction with Special:LandingPage, and DI GatewayFormChooser, correct? [18:20:32] https://phabricator.wikimedia.org/T131989 [18:21:07] gatewayFormChooser assumes you've already got a payment_method and probably country + currency [18:21:17] then it just decides which payment processor form to send you to [18:21:23] fr-tech would it make sense to write up our apple pay deployment steps on an etherpad? [18:21:25] oki at least that should be documented? [18:21:32] jgleeson +1 :) [18:21:47] the idea is that incoming links all go through the form chooser and not to specific gateway pages [18:22:10] that way if a gateway goes down we can quickly switch the form chooser settings and the donors go to the backup gateway [18:23:32] ejegg: K I'm going to make a more general refactor task for that [18:23:47] just to simplify and consolidate settings for the whole pipeline [18:28:42] AndyRussG: there's a minimal page here, not sure why it's under 'Chat': https://www.mediawiki.org/wiki/Fundraising_tech/Chat/GatewayFormChooser [18:29:18] Well 'cause it's amicable, no? [18:29:40] AndyRussG: there's an epic you might want to reference: https://phabricator.wikimedia.org/T136254 [18:30:23] ohhh, it used to be a Flow page [18:30:25] ah yeah cool thanks [18:30:32] I guess Flow is gone [18:30:40] yeah flow flew [18:30:56] lol right i still have a WIP that starts refactoring that [18:31:08] guessing the rebase will be more trouble than a rewrite [18:34:06] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MediaWiki-extensions-FundraiserLandingPage: Simplify and consolidate logic for automatic payment form selection - https://phabricator.wikimedia.org/T293819 (10AndyRussG) [18:34:42] ejegg: cool thx for the info! ^ pls don't hesitate to expand/rewrite as you see fit [18:40:39] (03PS2) 10Ejegg: Add ES version of Monthly Convert second thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730246 (https://phabricator.wikimedia.org/T292542) [18:40:47] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10FR-Email: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10KHaggard) Hello, Quick update here: I've talked with @Ppena about timelines for this project, and we think the training for the Civi E... [18:43:14] (03CR) 10Ejegg: "Thanks for the review, Damilare! I just hard-coded a /es on the end of the link instead of using a locale token. It looks like /es-mx and " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730246 (https://phabricator.wikimedia.org/T292542) (owner: 10Ejegg) [18:46:11] ejegg: did you figure out with dwisehaupt and Jeff_Green how we're gonna deploy and use the prod merchant identity cert? [18:52:32] hahah time for one more exclamation point on that Adyen pwd [18:54:45] I don't follow AndyRussG sorry :) [18:55:06] oh Adyen just bugged me to update my password again jgleeson [18:55:24] and it doesn't let you reuse the previous pwd [18:55:35] (on the test console) [18:56:11] ahh [19:00:22] jgleeson: so they want to do it via puppet [19:00:28] they have the file there already [19:00:56] Once they get it into puppet I'll remove it from where I initially checked it in to the localsettings repo [19:01:04] and will update the path [19:01:13] in adyen/main.yaml [19:04:19] i'm finishing up checking the diffs and such now. will probably deploy after the midsprint checkin. [19:05:41] fr-tech: I've put together this as a first attempt at a deployment plan for Apple Pay. Feel free to pull apart and add as you see fit! https://etherpad.wikimedia.org/p/apple-pay-deployment-plan [19:10:11] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, and 5 others: update the docs on the civi-acoustic import and export scripts - https://phabricator.wikimedia.org/T286934 (10Eileenmcnaughton) a:03Eilee... [19:22:46] thanks jgleeson|brb [19:35:18] XenoRyet: meeting? [19:35:31] Sorry got lost in an email, brt [19:46:28] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/732052 [19:46:47] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/732052 (owner: 10Ejegg) [20:09:57] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/732052 (owner: 10Ejegg) [20:24:56] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Question about blocked contacts in Civi and how they sync to Acoustic - https://phabricator.wikimedia.org/T293587 (10Eileenmcnaughton) Identified contact is 45915896 & got a Reply Mail Block to an email sent in January - this seems to have impacted a bun... [20:26:23] fr-tech, wrt to apple pay console access. I think we also get analytics from Apple using the own-cert approach and figured it might make sense to check those also? [20:27:04] this was something mentioned way back by Adyen as an extra we'd get pursuing the own-cert approach [20:27:07] Oh, if we do get anything extra that comes from someplace other than the Adyen console, Evelyn will want to know about that too. [20:27:18] ^^ in response to the comment on the etherpad [20:27:58] oh interesting jgleeson [20:28:07] thanks! [20:30:23] np [20:30:54] eileen: are you still on a call? just wondering if we could catch up on those CI tickets in sprint really quickly before I drop off [20:32:15] ejegg: the file is in place: /etc/fundraising/adyen-apple-pay-cert.pem [20:32:49] thanks dwisehaupt ! [20:32:52] ̿̿ ̿̿ ̿̿ ̿'̿'\̵͇̿̿\з= ( ▀ ͜͞ʖ▀) =ε/̵͇̿̿/’̿’̿ ̿ ̿̿ ̿̿ ̿̿ [20:32:59] jgleeson: yeah still on the call - maybe another 10 mins or so [20:34:57] thanks eileen. I'm around for a bit longer so that works! [20:35:44] fr-tech anyone want to review the SmashPig settings I just pushed up on frpm1001? [20:39:08] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/732061 [20:39:29] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/732061 (owner: 10Ejegg) [20:40:32] jgleeson|brb: I'm in tech talk hangout now [20:47:48] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/732061 (owner: 10Ejegg) [20:49:31] hmm - actually be there again in 5 [20:50:03] ejegg: so localsettings/SmashPig/local-config is where we put the provider SP config for prod? [20:50:20] AndyRussG: yeo [20:50:22] *yep [20:50:46] ok patch has my +2 ejegg thanks for that [20:50:51] did not double-check the path tho [20:51:20] ok, cool [20:52:32] back eileen [20:53:34] me too [20:54:15] https://meet.google.com/pau-rggj-byc?authuser=0 [20:54:56] ah I'm in today's earlier meeting but I see you said tech-talk. coming! [20:56:04] !log updated payments-wiki from 0f48acea49 to 30e596903d [20:56:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:03:36] k, now to find that old iPhone [21:14:13] ooh ejegg i see it [21:14:17] exciting [21:15:19] (03Abandoned) 10Jgleeson: Update CI build files to use new civicrm-buildkit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/692693 (https://phabricator.wikimedia.org/T277500) (owner: 10Jgleeson) [21:24:18] fr-tech I see apple pay too! noice!! congrats!!!! [21:24:29] interesting. i'm seeing the apple-pay-gateway-cert timeouts but they indicated that was only needed for sandbox testing. [21:24:43] hmmmm [21:25:10] on the Mac with the testing iCloud account it shows the form then says payment not completed... then it just returns to the same payments page with the branded donate button [21:26:01] I guess that's fine, that way if a real user's payment fails, they can maybe switch credit cards or something and try again easily? [21:26:45] oh. that error may have been from you testing. [21:27:06] (assuming you were using a test account and not a real one with your testing) [21:27:59] my billing details were invalid and i didnt fix that yet cause im eating [21:28:14] Woo, good times. [21:29:03] Let me know when we're ready to show Evelyn, and what link I should give her to test with. [21:29:12] ok did a $1 [21:29:30] yaaa congrats cstone! [21:29:45] Awesome [21:29:45] apples address guesser thing actually got my zipcode right [21:29:53] most of them get it wrong [21:30:02] then i have issues when they dont let me edit the field [21:32:44] i'm going to be rebooting frmon for its kernel upgrade. just fyi. [21:36:25] and it's back. [21:36:39] I want to see myself too, but I have zero apple devices in the house. [21:41:24] yay [21:41:44] just got the old phone up to 8% battery, gonna try it too [21:44:32] oh wow is apple pay going on tonight then [21:44:42] looks like I chose a good night to hang around [21:44:52] going out* [21:45:33] do you have a link fr-tech? [21:46:53] heh, i just manually typed in https://payments.wikimedia.org/index.php/Special:AdyenCheckoutGateway?payment_method=apple&amount=1¤cy=USD [21:47:04] hmm, off-center donate button [21:47:55] actually I'll leave y'all to it and try it out at my end tomorrow. bye for now [21:49:48] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Kris Hancock - https://phabricator.wikimedia.org/T293678 (10Dwisehaupt) Initial email sent with instructions for ssh key and yubikey setup info. [21:50:12] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Amber Johnson - https://phabricator.wikimedia.org/T293679 (10Dwisehaupt) Initial email sent with instructions for ssh key and yubikey setup info. [21:51:10] boo, the touch sensor seems to have stopped working [21:51:15] maybe clean it? [21:53:47] well that's anticlimactic [21:54:05] anyway, glad to hear it worked for you cstone! [21:56:26] transaction with 'Wikipedia Gift' is what my card reported. [21:56:41] ran good and the same style i would have expected. [21:57:13] but as you noted, the off center (or not centered) donate button. [21:57:57] oh cool, just got it to work here too! [21:58:04] had to re-scan my fingerprint [21:58:09] maybe it's changed??? [21:58:37] tested on a phone with no card setup and it did the normal apple thing of prompting to set up a card. [21:58:50] yep, that's what i saw too [21:58:54] i see 3 $1 transactions in adyens console [21:59:08] Rad. [21:59:17] What link should I give Evelyn to try out? [22:09:02] 10Fundraising-Backlog, 10FR-Adyen: Apple Pay: handle getting to form with no/invalid amount - https://phabricator.wikimedia.org/T293836 (10Ejegg) [23:01:39] (03CR) 10AndyRussG: [C: 03+2] "ahhhh yayyyyy" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730958 (https://phabricator.wikimedia.org/T288698) (owner: 10Eileen) [23:07:07] Hi FRTech, I am trying to use the exciting new Apple Pay link Dylan just sent over but it does not seem to have Apple Pay enabled. Can someone advise? https://payments.wikimedia.org/index.php/Special:AdyenCheckoutGateway?payment_method=apple&amount=1¤cy=USD&utm_source=internal_test&utm_campaign=internal_test [23:10:10] (03PS1) 10Ejegg: Center Apple Pay button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732100 [23:10:25] fr-tech there's a teeny one ^^^ [23:10:37] argh fr-tech I completely spaced on tech talk - sorrrry [23:11:09] emartin: what device are you using to visit that link? [23:11:21] my Macbook [23:11:28] with Safari browser? [23:11:28] does it have touch ID? [23:11:52] Ah. I will try to get the link to my phone and try there [23:11:57] and do you see Apple Pay set up if you go to System Preferences -> Wallet ? [23:13:04] ejegg: no worries about tech-talk btw... we in fact recorded most of it, in case you'd like to watch at 2x speed, and also in case you're not tired enuf and would like to join, I expect to talk to eileen again in a couple hours... topic in both cases is the CR for the e-mail template stuff/tokens and such [23:13:10] (03Merged) 10jenkins-bot: Switch from our custom token to core token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730958 (https://phabricator.wikimedia.org/T288698) (owner: 10Eileen) [23:13:36] thanks AndyRussG, I'll watch the recording [23:15:36] hmm, not finding it in drive [23:15:51] no, I don't have Apple Pay setup on my Macbook system preferences. I do on my phone but I got the same result from the phone.....am I missing a step? [23:16:40] emartin you don't see the black 'Donate with Apple Pay' button on that page? [23:17:07] https://usercontent.irccloud-cdn.com/file/2loK7GyP/image.png [23:17:24] no. See attached from my phone. [23:17:44] oh hmm, taking a look at the logs to see if there's an error [23:20:12] ejegg: it'll take a few minutes to upload and should also be attached to the meeting on the calendar [23:20:19] ah right [23:20:55] emartin: darn! It's working for the three of us developers who have tested it [23:21:21] I'm not seeing any errors in the log associated with a $1 donation [23:21:31] emartin: just to check again, it's on the Safari browser, right? [23:21:37] though there are a fair amount of script errors from other iOS devices [23:22:08] pretty sure it wouldn't work on Chrome even if on an iDevice [23:22:26] emartin: those buttons at the bottom of the screenshot don't look like the ones on my phone's Safari... [23:23:19] I wonder if Apple has its own web site something like "check if applepay works on my device" [23:23:20] oh yeah, that does look more like chrome [23:23:51] I am trying on Safari. My prior experience on my phone was through Chrome [23:24:05] so I guess we should handle when ppl get sent there and are in a browser that can't support it [23:24:17] yep [23:24:40] ^ hmmm I wonder how that worked previously through Chrome? maybe a link that opened a native app? [23:25:01] when did it work via Chrome AndyRussG ? [23:25:36] ejegg: oh I thought that's what emartin was saying just above, but I'm likely misunderstanding that [23:25:57] oh i think she meant the experience with it not working [23:26:08] and now she's going to try again in Safari [23:26:13] great news! When I use Safari, it works!!! I get the button. [23:26:13] yeee [23:26:20] emartin: fantastic!!!!!! [23:26:21] great emartin! [23:26:26] Go team!! [23:26:43] So forgive my ignorance. It MUST be through Safari only, correct? [23:26:55] just double checking that now [23:27:08] emartin: yep, only Safari for Apple Pay [23:27:12] Do we know what versions of Safari? [23:28:15] probably a relatively recent one...? we had some issues with our dev setup where developers had to update, but that might only be for testing accounts [23:28:20] iOS10 or later on the phone [23:28:21] shorter answer, we don't know ;) [23:28:30] oh cool ejegg [23:28:43] macOS Sierra or later [23:28:49] We need that from Adyen, right? I saw you ask the question on the call last week and I wondered if they responded. [23:29:09] ok got it @ejegg [23:29:20] I think they were going to look into it [23:29:59] emartin: in these countries: https://support.apple.com/en-us/HT207957 [23:30:06] right, so the issues we had on the dev setups was not that we didn't have the required macOS, but rather that we had to do updates within that major OS version to get it to work [23:30:14] Do you mind if I ping them, Andy? I want the detail for some documentation we are writing for this. [23:30:56] sounds like a great idea emartin :) they actually suggested reaching out via e-mail as soon as we had questions [23:33:51] I'll copy FRTech in. Thanks. This is so great! [23:41:02] hmm, looks like safari has a way to open a link in chrome, but chrome-iOS doesn't return the favor [23:41:20] I guess we just say 'sorry, gotta open this link in Safari' [23:45:20] 10Fundraising-Backlog, 10FR-Adyen: Apple Pay: show a friendly error when on an unsupported device - https://phabricator.wikimedia.org/T293847 (10Ejegg)