[00:22:23] eileen: heyy so I am able to continue looking at https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/730961 anytime that works for this evening/afternoon [00:22:35] AndyRussG: I'm ready! [00:23:03] eileen: ah great one sec then :) [00:29:54] eileen: we could use the link from this morning's standup I guess? [00:31:31] (03PS8) 10Eileen: Switch our recurring fail mail to use the new methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730961 (https://phabricator.wikimedia.org/T288698) [01:02:58] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Kris Hancock - https://phabricator.wikimedia.org/T293678 (10KHancock99) Thanks @Dwisehaupt . Following your clear instructions you gave via email, I am having repeated issues with ssh when using the username **k... [02:10:16] (03PS9) 10Eileen: Switch our recurring fail mail to use the new methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730961 (https://phabricator.wikimedia.org/T288698) [02:24:21] (03PS1) 10Ejegg: Form chooser: only count submethods for selected method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732468 (https://phabricator.wikimedia.org/T293935) [02:28:16] (03PS4) 10Ejegg: Move exchange rates classes to own files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701605 [02:28:18] (03PS3) 10Ejegg: Namespace for ExchangeRatesException [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701606 [02:31:06] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Fr-endowment, 10MediaWiki-extensions-DonationInterface, 10MW-1.38-notes (1.38.0-wmf.6; 2021-10-26): Update "Other ways to give" link on Endowment form - https://phabricator.wikimedia.org/T293877 (10Ejegg) [02:45:25] (03PS10) 10Eileen: Switch our recurring fail mail to use the new methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730961 (https://phabricator.wikimedia.org/T288698) [02:53:32] (03CR) 10AndyRussG: [C: 03+2] "Thanks for this and for all the explanations!!!!!!! :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730961 (https://phabricator.wikimedia.org/T288698) (owner: 10Eileen) [03:04:51] (03Merged) 10jenkins-bot: Switch our recurring fail mail to use the new methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730961 (https://phabricator.wikimedia.org/T288698) (owner: 10Eileen) [03:24:26] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/732470 [03:24:44] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/732470 (owner: 10Eileen) [03:29:55] !log civicrm revision changed from e889831012 to 733a8fceda, config revision is eed79486d5 [03:30:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:23:17] (03CR) 10Eileen: Switch from our custom token to core token (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/730958 (https://phabricator.wikimedia.org/T288698) (owner: 10Eileen) [05:08:10] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, and 5 others: update the docs on the civi-acoustic import and export scripts - https://phabricator.wikimedia.org/T286934 (10Eileenmcnaughton) Also https... [12:52:28] 10Fundraising-Backlog, 10FR-Tech-Analytics: Email Send with Low Clicks - https://phabricator.wikimedia.org/T293926 (10EYener) [13:39:04] 10Fundraising-Backlog, 10Analytics-Radar, 10Product-Analytics, 10Wikipedia-iOS-App-Backlog, and 2 others: Understand impact of Apple's Relay Service - https://phabricator.wikimedia.org/T289795 (10TheDJ) >>! In T289795#7382434, @GeneralNotability wrote: > a list of current egress points can be found at http... [14:28:41] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Amber Johnson - https://phabricator.wikimedia.org/T293679 (10AMJohnson) {F34704224} Having trouble completing the SSH key process. Followed steps here: https://collab.wikimedia.org/wiki/Fundraising_ssh_access. It... [14:50:13] hello fr-tech [14:50:29] I'm looking at the latest couple of error 905 failmails [14:51:09] and the corresponding IPNs show it was a 'korean_local_card' attempted in france [14:52:18] howdy fr-tech [14:52:38] ejegg: we had a theory as to why we're seeing a lot of those. I think cstone might have added a ticket [14:52:44] lemme check [14:55:11] I can't see it [14:59:28] ok in a case I dug into there was a donor who made 3 attempts to donate with first two somehow not providing a submethod. when digging further it looks like we get the submethod from adyen and then map it to own our... but the code that handles that doesn't cater for an empty value or complain when the input from adyen isn't in the expected form. You can see the code here: [14:59:29] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/aecd47b9cd1899603cf0ea5d793762ca4071a8b5/adyen_gateway/checkout/forms/adyen.js#L206 [14:59:34] ejegg: ^ [15:00:01] the comment above says [15:00:02] // The code should be available in state.data.paymentMethod.brand, but [15:00:05] // sometimes it's not there. We can usually still find it via component. [15:00:23] doesn't fill me with confidence that we'll ALWAYS get it [15:01:12] maybe we should add in some client-side api calls to the error api to let us know if this is happening more than we think [15:08:08] looks like we could borrow some code from here https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/673e4ad5067692b04d53458a798b056beeacf4c0/modules/js/ext.donationInterface.errorLog.js#L2 [15:08:13] I'll make a ticket [15:27:53] jgleeson: so we should be able to tell just from the posted data which ones have submethods and which don't, right? [15:31:00] Anyway, I don't think there is a good way for us to prevent donors from entering in card number from an unsupported card [15:31:29] but since we don't need failmail each time they do [15:31:59] we could do another iteration of the patch that stopped failmail from the 422 error codes [15:32:41] 10Fundraising-Backlog: Adyen 905 errors - https://phabricator.wikimedia.org/T294032 (10jgleeson) [15:33:33] ejegg: the donor was entering a support card [15:33:46] supported* [15:33:48] Visa [15:35:50] Bah sorry jgleeson totally spaced on making that ticket [15:36:01] jgleeson: maybe they used a different card for the first two attempts? [15:36:06] it's a head scratcher because the frontend validation should block you submitting the form without entering a valid card [15:36:14] ejegg: ^^ [15:36:34] ejegg: if that was the case then I think we'd map it verbatim [15:36:42] in payments-listener-smashpig-20211021.gz I see a failed auth IPN for 107254500.1 with the korean_local_card [15:36:50] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/aecd47b9cd1899603cf0ea5d793762ca4071a8b5/adyen_gateway/checkout/forms/adyen.js#L155 [15:37:05] yeah ejegg that's your one [15:37:15] I looked at 107254500 [15:37:18] so I'm guessing that they have a more extensive mapping of BINs to payment methods on their server side [15:37:33] than they do in the client-side validation [15:37:45] np cstone ! [15:38:23] boo, github seems to be down [15:38:27] https://github.com/Adyen/adyen-web [15:40:10] oh I see, they do a bin lookup via a POST [15:40:22] so they SHOULD have the same info on the client side [15:41:53] jgleeson it looks like there's an onBinLookup callback we might be able to hook into [15:43:08] or a different 'onBrand' event [15:43:38] hmm I guess we'd get that before the onSubmit [15:43:45] which they could change [15:44:04] yeah, I think as soon as they fill out the card field that would be triggered [15:44:19] so we would want to make the last one count, I guess [15:44:54] like we set our own private isValid state whenever we get that callback, and then consult the last value of it onSubmit [15:45:10] could work [15:45:33] IF we know that they are actually not sending it in the onSubmit event [15:46:17] https://docs.adyen.com/payment-methods/cards/custom-card-integration#supported-card-types [15:46:42] ^^^ is for the non-encrypted card component, but it may share a bunch of code with the encrypted one [15:46:51] says "If card types are not provided, the configuration defaults to ['mc','visa','amex']. " [15:47:03] so maybe we only get those brands that we include in the list? [15:47:36] let's see if we've gotten any values besides those three [15:48:36] so I think if they send us anything we don't expect to see we just pass that through verbatim [15:48:49] but in this example, we got nothing [15:49:00] short changed [15:49:34] right, so that korean_local_card version isn't in the list of 'Supported card types in web' on that docs page [15:49:34] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Amber Johnson - https://phabricator.wikimedia.org/T293679 (10Dwisehaupt) @AMJohnson I see what's going on. On your local machine, your username is amberjohnson. When specifying the location for the key, you will n... [15:49:48] ejegg: what's the CID for your one [15:49:58] I'll check what we sent over during the API call [15:50:05] which might mean they never get any value for brand up in the client side [15:50:38] i'm still looking at ct_id 107254500 [15:50:59] found it 107254500.1 [15:51:02] thanks [15:51:44] do you see the smashpig logs? [15:51:48] at 14:00:37 [15:52:07] there are two entries with the AUTHORISATION event_code [15:52:18] wait a minute [15:52:25] that's the same one I looked at in my email standup? [15:52:39] and 905 Payment details are not supported [15:53:08] yeah, the first two attempts have a korean_local_card [15:53:19] so I think after one card failed the donor tried a visa card [15:53:25] and that one worked [15:54:19] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Kris Hancock - https://phabricator.wikimedia.org/T293678 (10Dwisehaupt) Yubikey request sent to ITS. [15:56:11] ok, so looking at all the submethod values we've gotten back from adyen, I do see some 'cb', 'jcb' and 'discover' which aren't in that default array they mention [15:56:26] so it might not help to add all the codes to the config [15:56:43] man reading these IPNs is hard work [15:56:54] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Kris Hancock - https://phabricator.wikimedia.org/T293678 (10Dwisehaupt) @KHancock99 I see what's going on. On your local machine, your username is kristinehancock. When specifying the location for the key, you wil... [15:57:00] heh, someday we'll move to JSON [15:57:20] wait, don't we have an XML-formatter utility script? [15:57:21] I used to have some xmllint trick but to make reading them easier but I can't seem to remember how [15:57:39] maybe [15:57:51] i added a highlighting plugin to vscode and then paste them in there and format xml [15:57:56] not that thats easier step wise [15:57:58] oh i've got some really dumb regex that at least splits them onto different lines [15:58:01] in formateme.sh [15:58:44] ahh remembered it [15:58:46] xmllint --format - [15:59:10] ah well, no xmllint up on frlog [15:59:18] yeah I do this locally [15:59:29] handy to then put through diff -y [16:12:40] oh right, python for xml formatting is in another one of those utility scripts [16:44:44] 10Fundraising-Backlog: Adyen 905 errors - https://phabricator.wikimedia.org/T294032 (10jgleeson) [16:46:18] ejegg fr-tech btw if you want to dig into the possible doc outline, or if you already have some comments to share, I think it'd be fun to talk them over relatively soon? as in, if anyone would like to talk about that now or later, here or on a call, I'd be down for that :) and many thx in advance any feedback :) [16:51:16] 10Fundraising-Backlog: Adyen 905 errors - https://phabricator.wikimedia.org/T294032 (10Ejegg) Looking in the corresponding IPN messages I see we have the following counts of 905 errors for each Adyen-side paymentMethod value 60 uatp 4 korean_local_card 3 elo 1 vias [17:09:36] 10Fundraising-Backlog: Adyen 905 errors - https://phabricator.wikimedia.org/T294032 (10Ejegg) Meanwhile we're getting orders of magnitude more 'Redirecting ' log messages with blank payment_submethod. In just one day's logs I see ~7000 different ct_ids with that blank vs ~15000 ct_ids with that field populated,... [17:17:06] 10Fundraising-Backlog, 10Analytics, 10Analytics-EventLogging, 10Analytics-Kanban, and 3 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10Ottomata) [17:20:20] 10Fundraising-Backlog: Adyen 905 errors - https://phabricator.wikimedia.org/T294032 (10Ejegg) Of the ct_ids with no brand on the front end, 7454 came back with a successful auth IPN and 357 came back with a failed auth IPN, so it's not preventing donations from going through. [17:26:51] 10Fundraising-Backlog: Adyen 905 errors - https://phabricator.wikimedia.org/T294032 (10Ejegg) Here are the counts of paymentMethod values from IPNs for those ct_ids with no brand: 5 amex 1769 cartebancaire 2 discover 2 korean_local_card 1483 mc 13 uatp 7 unknowncard 4530 visa [18:22:34] 10Fundraising-Backlog, 10Product-Analytics, 10Research, 10Wikimedia-CentralNotice-Administration, 10Wiki-Loves-Monuments (2021): Conduct research on WLM centralnotice banners - https://phabricator.wikimedia.org/T290387 (10MGerlach) [18:35:43] 10Fundraising-Backlog: Adyen 905 errors - https://phabricator.wikimedia.org/T294032 (10jgleeson) Wow, thanks for all the research, @Ejegg !!! It's good news that donations are still getting through when this issue is hit, at least! We could reach out to Adyen to see if they know of valid scenarios which result... [18:42:10] fr-tech does anyone feel like picking up review on the the Apple Pay ejegg|afk pushed up? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/732468 [18:43:19] jgleeson: hi! sure! I can get to that sometime today... Just quickly responding to comments on https://phabricator.wikimedia.org/T292927, then I was going to review the form chooser stuff before it gets late... so I guess I could look at that this evening? [18:44:01] thanks AndyRussG ! [18:44:08] thank u :) [19:09:20] (03PS3) 10Jgleeson: WIP Switch getHostedPaymentStatus to return a PaymentDetailResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/724232 (https://phabricator.wikimedia.org/T291223) (owner: 10Cstone) [19:10:27] (03CR) 10jerkins-bot: [V: 04-1] WIP Switch getHostedPaymentStatus to return a PaymentDetailResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/724232 (https://phabricator.wikimedia.org/T291223) (owner: 10Cstone) [19:33:37] 10Fundraising-Backlog, 10Product-Analytics, 10Research, 10Wikimedia-CentralNotice-Administration, 10Wiki-Loves-Monuments (2021): Conduct research on WLM centralnotice banners - https://phabricator.wikimedia.org/T290387 (10Dzahn) [20:06:49] 10Fundraising-Backlog: Declines due to API settings - https://phabricator.wikimedia.org/T294059 (10EMartin) [20:10:15] (03CR) 10Ejegg: [C: 03+2] "Thanks, Zabe" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/707332 (https://phabricator.wikimedia.org/T293928) (owner: 10Zabe) [20:10:52] hmmm speaking of caches [20:18:54] ejegg: cstone I don't think this smashpig change is small [20:19:33] jgleeson: it's nontrivial [20:19:49] yeah the test changes alone are pretty sizable [20:19:56] but the idea is to use the rawResponse up in DonationInterface so at least we don't have to refactor a lot up there [20:20:08] ah yeah that bit is pretty straight forward [20:20:35] (03PS1) 10Zabe: build: Updating mediawiki/mediawiki-codesniffer to 37.0.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732782 [20:22:22] so let's see, there are three tests to update [20:22:44] (03Merged) 10jenkins-bot: Avoid using wfGetMainCache() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/707332 (https://phabricator.wikimedia.org/T293928) (owner: 10Zabe) [20:23:09] i think we'll want to move that setRawResponse() till after the addPaymentStatusErrorIfPresent [20:23:19] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 37.0.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732782 (owner: 10Zabe) [20:23:21] I got 12 failures after changing [20:23:28] just working through them now [20:23:33] and that's causing knock ons [20:23:48] ah, i see one of those tests has several cases [20:24:06] so you should be able to just change the tests to look at rawResponse for the moment [20:25:02] then I think we can crib some code from another class to get a normalized status [20:25:16] working on that but it's causing problems with 'Method createHostedPayment may not return value of type SmashPig\PaymentProviders\PaymentDetailResponse, its return declaration is ": array"' [20:25:21] just digging into that [20:26:15] hrm, what touched createHostedPayment? [20:27:20] hey just wanting to check people read my EOD about documentation & were happy with my understanding of which page to make our docs home page (since it's gone back & forth & round about) [20:28:05] at least not upside down eileen [20:28:09] :) [20:28:15] we can get there [20:28:44] errr ejegg I'm undoing my test changes to see what led me there [20:29:28] (03PS2) 10Zabe: build: Updating mediawiki/mediawiki-codesniffer to 37.0.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732782 [20:32:23] jgleeson so there's a prepareResponseObject function on the parent PaymentProvider class that might populate most of those properties for you [20:32:51] the only catch is that you'll have to have it look in one additional place for the 'payments' node [20:33:18] I think I've found the issue ejegg and it was my code [20:33:24] just running tests again [20:33:25] since the hosted checkout status ones have it under ['createdPaymentOutput'] [20:33:53] cool cool [20:33:59] quick quesiton, what are the params that we in actual practice expect GatewayFormChooser to get, again? Country, currency, payment_method... and amount, i guess? [20:34:10] or utm_something? [20:34:48] country, currency, and payment_method are the only ones that are really needed AndyRussG [20:34:58] amount is in practice almost always set too [20:35:20] ah right, and the utm ones are generally set as well [20:35:33] utm_campaign, utm_source, utm_medium [20:35:50] ejegg: oki cool thx! [20:48:17] ejegg: this is a little confusing https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/74140b40e0ec0ac7a1c589fdb61441d6d94b8d92/tests/phpunit/BaseIngenicoTestCase.php#L103-L102 [20:48:44] we've got a var called hostedPaymentStatusResponse which returns a createdPaymentOutput [20:50:22] I'm now converting that into a PaymentDetailResponse() and setting the rawResponse to that original array however that top level name feels out of place [20:51:00] I'm gonna make a real request to that API method and see what gets sent back [21:00:34] (03PS1) 10Jgleeson: Updated Ingenico getHostedPaymentStatus response to now return an instance of PaymentDetailResponse. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732788 (https://phabricator.wikimedia.org/T291223) [21:00:58] (03PS1) 10Jgleeson: WIP: Update $result handling for Ingenico getHostedPaymentStatus call as this now returns an instance of PaymentDetailResponse. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732790 (https://phabricator.wikimedia.org/T291223) [21:01:04] (03CR) 10jerkins-bot: [V: 04-1] Updated Ingenico getHostedPaymentStatus response to now return an instance of PaymentDetailResponse. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732788 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [21:03:22] (03CR) 10jerkins-bot: [V: 04-1] WIP: Update $result handling for Ingenico getHostedPaymentStatus call as this now returns an instance of PaymentDetailResponse. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732790 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [21:03:39] (03PS1) 10Jgleeson: WIP: Fix the test failues due to getHostedPaymentStatus updates [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732791 [21:04:27] argh smashpig test failures also [21:04:40] ok that's enough for tonight [21:04:54] bye for now [21:05:56] (03CR) 10jerkins-bot: [V: 04-1] WIP: Fix the test failues due to getHostedPaymentStatus updates [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732791 (owner: 10Jgleeson) [21:12:05] sorry jgleeson|away , that array is basically just what the Ingenico API sends back [21:36:25] (03PS3) 10Ejegg: Add permissions to engage role per live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731846 (https://phabricator.wikimedia.org/T279686) (owner: 10Eileen) [21:37:44] (03CR) 10Ejegg: [C: 03+2] "Looks good! I notice a double line in here, but it seems not to matter." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731846 (https://phabricator.wikimedia.org/T279686) (owner: 10Eileen) [21:37:53] (03PS2) 10Ejegg: Dedupe deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731857 (owner: 10Eileen) [21:38:11] (03CR) 10Ejegg: [C: 03+2] "Yay for deduping! And making dev more like prod!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731857 (owner: 10Eileen) [21:41:13] PROBLEM - check_puppetrun on pay-lvs1001 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 8 minutes ago with 2 failures. Failed resources (up to 3 shown): Service[pybal] [21:41:19] PROBLEM - check_puppetrun on frmon1001 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 5 minutes ago with 2 failures. Failed resources (up to 3 shown): Service[prometheus] [21:46:13] RECOVERY - check_puppetrun on pay-lvs1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [21:46:14] RECOVERY - check_puppetrun on frmon1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [21:50:07] (03Merged) 10jenkins-bot: Add permissions to engage role per live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731846 (https://phabricator.wikimedia.org/T279686) (owner: 10Eileen) [21:51:25] (03Merged) 10jenkins-bot: Dedupe deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/731857 (owner: 10Eileen) [22:13:11] 10Fundraising-Backlog: Declines due to API settings - https://phabricator.wikimedia.org/T294059 (10Ejegg) > Wiki is sending isRecurring=1 instead of isRecurring=true. Also I'm confused why it is being sent in cardPaymentMethodSpecificInput instead of hostedCheckoutSpecificInput. It seems like if they want to use... [22:15:51] oh wow, Judas Priest covers Joan Baez! [22:16:39] https://en.wikipedia.org/wiki/Diamonds_%26_Rust_(song)#Popular_covers [22:32:42] (03PS1) 10Ejegg: Adyen Checkout: map error code 905 to submethod [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732803 (https://phabricator.wikimedia.org/T294032) [22:35:39] (03PS1) 10Ejegg: Adyen Checkout: message to try another card [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732804 (https://phabricator.wikimedia.org/T294032) [22:37:49] (03CR) 10Ejegg: "Cool! You can probably use the parent class's prepareResponseObject to do most of the normalizing. It will need a slight modification to f" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732788 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [22:41:26] 10Fundraising-Backlog, 10Patch-For-Review: Adyen 905 errors - https://phabricator.wikimedia.org/T294032 (10Ejegg) @jgleeson we could also add a 'debugMessages' field to the standard payment submission API call, which would just let us piggy-back diagnostic info on the normal call. That would be useful for thi... [22:51:17] 10Fundraising-Backlog, 10Product-Analytics, 10Research, 10Wikimedia-CentralNotice-Administration, 10Wiki-Loves-Monuments (2021): Conduct research on WLM centralnotice banners - https://phabricator.wikimedia.org/T290387 (10Dzahn) [23:11:19] PROBLEM - check_puppetrun on frmon1001 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 5 minutes ago with 2 failures. Failed resources (up to 3 shown): Service[prometheus] [23:16:19] RECOVERY - check_puppetrun on frmon1001 is OK: OK: Puppet is currently enabled, last run 17 seconds ago with 0 failures [23:47:34] (03PS1) 10Ejegg: Add client-side debug messages to submission [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732837 (https://phabricator.wikimedia.org/T294032) [23:49:28] (03CR) 10jerkins-bot: [V: 04-1] Add client-side debug messages to submission [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732837 (https://phabricator.wikimedia.org/T294032) (owner: 10Ejegg) [23:50:38] AndyRussG: think we'll be able to get that gateway form chooser patch out today? [23:51:51] these two would be probably make the 1 hr test nicer if they're an easy merge: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/732100 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/732104 [23:52:38] (03PS2) 10Ejegg: Add client-side debug messages to submission [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732837 (https://phabricator.wikimedia.org/T294032) [23:53:55] ejegg ahhh I'm in the throes of unexpected non-work tasks [23:54:33] I was hoping to be done CR but looks like I'd finish it only quite late [23:58:52] fr-tech is there anyone else that can CR a couple of patches? [23:59:12] I'd like to make it possible for folks to do a 1 hr test with apple pay