[02:22:37] (03CR) 10AndyRussG: "Hi! Thanks for this!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732843 (owner: 10Ejegg) [03:22:47] (03CR) 10AndyRussG: "Cool! Just one note inline..." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732104 (https://phabricator.wikimedia.org/T293847) (owner: 10Ejegg) [03:45:09] (03PS3) 10AndyRussG: Apple Pay: allow rate-limiting session start API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732845 (owner: 10Ejegg) [04:42:43] (03CR) 10AndyRussG: [C: 03+2] "Yeah, works great!! Thanks!! Hmmmm do we want to do the same thing for adyen.api.php or others?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732845 (owner: 10Ejegg) [04:45:05] (03Merged) 10jenkins-bot: Apple Pay: allow rate-limiting session start API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732845 (owner: 10Ejegg) [05:02:41] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] "Thanks for the cleanup!! Hmmm since a lot of this was taken from prod and staging configs, perhaps we should check those, too?" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731845 (owner: 10Ejegg) [05:09:15] (03PS3) 10AndyRussG: Enable debug-level logging for payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/733934 (https://phabricator.wikimedia.org/T294032) [07:10:59] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Kris Hancock - https://phabricator.wikimedia.org/T293678 (10KHancock99) Thanks @Dwisehaupt . Worked a treat. public side of the key: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQDxQNOmmF86okITJ7hSBY+wJ3od49sWgm8Na6z51... [15:30:01] thanks for all the code review AndyRussG ! [15:30:44] ejegg: hiiii! ahh thank u for all the code [15:30:47] :) [15:30:56] also hi fr-tech :) [15:31:51] Hi AndyRussG ejegg [15:32:11] hi cstone & the rest of fr-tech! [15:35:34] hi fr-tech [15:35:53] heyy cstone damilare :) [15:36:06] Hi damilare ! [15:40:37] heyy cstone AndyRussG [15:40:52] :) [15:48:33] Our governor here just sent out an email bragging how Colorado is tied for the state with fewest shark attacks [15:50:20] lolol [15:50:40] with all the other landlocked ones??? [15:51:13] I think there's a shark lake in Wyoming that's had a few incidents [15:51:15] jk [15:52:02] but seriously what about those sharknadoes out there on the plains? [15:52:05] ok maybe not seriously [16:03:11] (03PS1) 10Zabe: Bump twig/twig to 1.44.5 [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/734337 [16:03:47] AndyRussG: hmm, yeah, I guess validating the Apple URL at the SmashPig level might be more appropriate... [16:04:54] ejegg: I wasn't sure, but it seems pretty simple to port that code over to SP? and if we just thrown an exception that might just bubble up to the DI API if that's called with a bad url? [16:05:09] yeah, an exception would make sense here [16:05:25] ah cool! heheh sorry to be picky also btw [16:06:03] heh, being picky is what they pay us for, right? [16:40:25] (03PS1) 10Ejegg: Validate Apple validation_url in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734349 [16:40:40] AndyRussG: I think that should do it ^^^ [16:40:45] just going to smoke test [16:49:03] Hi FRTech, are we seeing any issues with Paypal today? [16:50:13] emartin: ive only looked at the recurrings from overnight but the paypal ones look fine [16:50:15] emartin: oh, I saw an error downloading the audit file last night [16:50:33] what are you seeing emartin ? [16:51:45] https://www.irccloud.com/pastebin/Fgoz3JVt/ [16:52:31] I have not yet seen notification that is has been resolved [16:53:39] 10Fundraising-Backlog, 10FR-Tech-Analytics: Low Traffic Test Difference in impressions between event_sanitized.centralnoticebannerhistory and pgehres.bannerimpressions - https://phabricator.wikimedia.org/T294145 (10AndyRussG) Hi!!! Thanks so so much @JMando for digging in here! Hugely appreciated, and it's fan... [16:54:02] emartin: looks like one single timeout in our paypal logs - must be some part of their infrastructure that we're not hitting [16:54:15] ejegg: cool thx! [16:55:01] AndyRussG: think i'll just take the apple- prefix off that config key [16:56:03] which config key? the rate limiter? [16:56:23] no, the one I just added in that SmashPig patch [16:56:31] ahhh oki :) [16:56:37] it's already a constructor param to the ApplePayPaymentProvider [16:56:46] so no need to re-specify Apple [16:57:04] ahh yeee... hmm can you include an apple emoji in yaml? [16:58:02] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: server error seen when attempting to export long search kit list - https://phabricator.wikimedia.org/T287995 (10RKumar_WMF) Tried for 17K lines and it worked. Thank you! [16:58:56] AndyRussG: heh, probably depends on your parser [16:59:38] oh hey, it's in the spec - https://yaml.org/spec/1.2.2/#chapter-5-character-productions [16:59:53] heheh cool! [17:03:43] (03PS2) 10Ejegg: Validate Apple validation_url in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734349 [17:04:07] oops, one more place to fix that [17:04:40] (03PS3) 10Ejegg: Validate Apple validation_url in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734349 [17:07:54] (03CR) 10Ejegg: Apple Pay: Validate the validation_url (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732843 (owner: 10Ejegg) [17:11:24] (03CR) 10Ejegg: [C: 03+2] Enable debug-level logging for payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/733934 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [17:15:46] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Enable debug-level logging for payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/733934 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [17:15:55] (03PS2) 10Ejegg: Turn off server- and client-side caching for payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/734036 (owner: 10AndyRussG) [17:16:38] (03CR) 10Ejegg: [V: 03+2 C: 03+2] "Thanks, this caching could get annoying!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/734036 (owner: 10AndyRussG) [17:28:40] (03PS1) 10Damilare Adedoyin: Set isRecurring value to boolean instead of numbers [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/734358 (https://phabricator.wikimedia.org/T294059) [17:28:50] (03CR) 10jerkins-bot: [V: 04-1] Set isRecurring value to boolean instead of numbers [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/734358 (https://phabricator.wikimedia.org/T294059) (owner: 10Damilare Adedoyin) [17:30:44] 10Fundraising-Backlog, 10Patch-For-Review: Declines due to API settings - https://phabricator.wikimedia.org/T294059 (10Damilare) a:03Damilare [17:34:53] (03PS2) 10Damilare Adedoyin: Set isRecurring value to boolean instead of numbers [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/734358 (https://phabricator.wikimedia.org/T294059) [17:37:44] (03CR) 10jerkins-bot: [V: 04-1] Set isRecurring value to boolean instead of numbers [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/734358 (https://phabricator.wikimedia.org/T294059) (owner: 10Damilare Adedoyin) [17:40:39] (03PS3) 10Damilare Adedoyin: Set isRecurring value to boolean instead of numbers [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/734358 (https://phabricator.wikimedia.org/T294059) [17:41:47] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CentralNotice: Review banner history use of now-deprecated Navigator.doNotTrack - https://phabricator.wikimedia.org/T294280 (10AndyRussG) [18:11:00] 10Fundraising-Backlog: Expired card declines on one time transactions - https://phabricator.wikimedia.org/T294288 (10EMartin) [18:25:12] 10Fundraising-Backlog, 10fundraising-tech-ops: Documentation: FR-Tech team consensus for decisions required for next steps, topics/subtopics and roadmap - https://phabricator.wikimedia.org/T294291 (10AndyRussG) [18:25:59] 10Fundraising-Backlog: Documentation: Confirm and document decision about where to put stuff - https://phabricator.wikimedia.org/T291878 (10AndyRussG) [18:26:01] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: epic: frtech onwiki documentation overhaul - https://phabricator.wikimedia.org/T209872 (10AndyRussG) [18:41:01] 10Fundraising-Backlog, 10Patch-For-Review: Declines due to API settings - https://phabricator.wikimedia.org/T294059 (10EMartin) Please let me know if you would like to have a call with Ingenico to discuss the API 3D fields correct. [18:42:15] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10fr-donorservices: Clean up new adyen ideal recurrings - https://phabricator.wikimedia.org/T291712 (10Cstone) [19:13:20] AndyRussG: so the logging limiter patch is with the idea to optimize the posts, right? [19:14:50] ejegg: yeah... I mean it just seemed easy enough to not even collect the data if we know we'll just discard it [19:14:56] not super important, either tho [19:15:06] sure, sounds good [19:15:09] oki cool [19:15:36] I'mma just rebase that around the slightly-more-complicated patch and +2 it for now [19:15:43] heh yeah I was just poking around to see if we already were sending LogDebug into the client, and since I was already looking at that code, it seemed straightforward [19:15:48] ah oki thanks! [19:16:06] ah right the abstract api refector [19:16:42] I did initially get some test failures on that one, apparently because some apis don't have variant in their official list of params, but do need it (?= [19:16:45] (?) [19:17:21] (03PS3) 10Ejegg: Only send debug messages from API if LogDebug is true [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/734003 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [19:17:24] in the existing code, the API queries variant just directly on the URL, not ingressing the data the normal way [19:17:57] ah, got it [19:18:34] so seems relatively safe now that the new code also does the same thing if it's not already in the data ingressed the normal api way [19:18:39] (03CR) 10Ejegg: [C: 03+2] Only send debug messages from API if LogDebug is true [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/734003 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [19:18:51] and the function that was removed was only ever called form within that abstract class [19:18:59] ah, ok [19:32:58] (03Merged) 10jenkins-bot: Only send debug messages from API if LogDebug is true [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/734003 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [19:42:44] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CentralNotice: Review banner history use of now-deprecated Navigator.doNotTrack - https://phabricator.wikimedia.org/T294280 (10Ejegg) Looks like the successor is still in draft https://en.wikipedia.org/wiki/Do_Not_Track#Global_Privacy_Control [19:50:50] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10FR-Tech-Analytics: Low Traffic Test Difference in impressions between event_sanitized.centralnoticebannerhistory and pgehres.bannerimpressions - https://phabricator.wikimedia.org/T294145 (10AndyRussG) [19:51:49] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Patch-For-Review: Declines due to API settings - https://phabricator.wikimedia.org/T294059 (10XenoRyet) [19:53:00] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), 10Patch-For-Review: Adyen 905 errors - https://phabricator.wikimedia.org/T294032 (10XenoRyet) [21:06:35] ejegg: this one is just wanting review? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/722666 [21:07:09] yep eileen [21:07:23] does that look like the right way to add those new actions? [21:08:10] so the actions are PendingTable.Consume & PendingTransaction.resolve [21:09:30] - I didn't think 'resolve' as a verb was immediately obvious to me - but the code comments say what it does - I might have gone with process or finalize [21:16:09] ah, well sometimes you want to process/finalize it and sometimes you just want to delete the pending row [21:16:24] i guess that felt like resolution to me [21:16:42] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Kris Hancock - https://phabricator.wikimedia.org/T293678 (10Dwisehaupt) [21:17:10] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Kris Hancock - https://phabricator.wikimedia.org/T293678 (10Dwisehaupt) SSH pub key added. We can finish the setup when the yubikey arrives. [21:18:24] ejegg: yeah [21:18:59] apart from the obvious todo I can't see any major issues [21:19:33] cool! Yeah, I [21:19:54] 'm not planning to give it a p-c job in its current state by any means [21:19:55] 10Fundraising-Backlog, 10Product-Analytics, 10Research, 10Wikimedia-CentralNotice-Administration, 10Wiki-Loves-Monuments (2021): Conduct research on WLM centralnotice banners - https://phabricator.wikimedia.org/T290387 (10Dzahn) [21:45:32] ejegg: I don't actually know how to set up pending records locally for consumption - where do they live? [21:46:40] ah smashpig db [21:51:44] oh yeah, to get some real data you'd probably want a whole payments frontend :P [21:57:40] (03CR) 10Eileen: Pending resolver outer loop + resolve skeleton (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722666 (https://phabricator.wikimedia.org/T291225) (owner: 10Ejegg) [22:01:20] (03CR) 10Eileen: "it's not picking up 'gateway' either" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722666 (https://phabricator.wikimedia.org/T291225) (owner: 10Ejegg) [22:04:58] eileen: ahh, sorry, the non-blob columns on that table are pretty much just for indexing - when we act on a row, we always act on the data from the blob [22:05:26] ejegg: ah OK - so order_id & gateway are in both places [22:05:33] yep yep [22:06:08] the table should only ever be written to by the pending queue consumer, I think [22:06:45] and that recieves a blob, copies out the indexed columns and writes the row [22:13:17] ejegg: does that extend to the date fields too? I think this line should be greater than not less than but it seems it's blank in my 'fake line; [22:13:18] $message['date'] < UtcDate::getUtcTimestamp("-{$this->minimumAge} minutes") [22:13:56] so we don't want to consider any messages newer than minimumAge minutes [22:14:35] yeah, that $message data is all from the blob, except for one key: pending_id [22:15:19] so in practice, we wait a half an hour for the donor to be finished doing actual things on the site [22:15:22] hmm - ok - so minimumAge feels like it means 'the minimum age of transactions should be 30 mins ago' - is it more the maximumAge [22:15:41] there's no max age parameter [22:15:55] but in practice, these things do expire [22:16:11] we kind of rely on running the qc regularly to not let things get to the max age [22:16:27] oh wait, actually, we do have another job the deletes anything older than X days [22:16:34] so I guess that's our functional max age [22:16:36] yeah - it's more like 'processTransationsOlderThan' [22:16:48] yah, that's the intent [22:17:00] I guess you are used to minimumAge so it feels like it says that [22:17:57] that commit mostly ports over existing drupal code, but I can certainly unpack that conditional and introduce new variables to make it clearer! [22:18:48] yeah I can see 'minimumAge' is shorter than 'processTransationsOlderThan' [22:19:00] it just wasn't obvious to me at first what it meant [22:19:37] I wonder if we should have defaults for 'batch' and 'timelimit' - in case people forget to set them [22:19:47] probably! [22:29:05] 10Fundraising Dash, 10Fundraising-Backlog, 10FR-Tech-Analytics: Should Fundraising Dash be deprecated? - https://phabricator.wikimedia.org/T292481 (10Ejegg) There's as yet no 2021 campaign filter available for the 'Big English' dashboard. I guess we can see how long it takes for someone to ask for it! [22:40:26] (03CR) 10Eileen: [C: 03+2] "Ok - so ejegg clarified that it's legit to have to have those things in 'message'." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722666 (https://phabricator.wikimedia.org/T291225) (owner: 10Ejegg) [22:47:15] ejegg: do you know if this public reporting section is about something long-gone? https://wikitech.wikimedia.org/wiki/Fundraising#Public_reporting_-_possibly_entirely_out_of_date [22:48:03] eileen: I think we're still posting CSVs to a server every half hour [22:48:10] oh wow ok [22:48:15] with some very aggregated data [22:48:24] no idea if anyone is using it, tho [22:50:26] lol - just found a reference to how we are using a development version of civi to leverage this feature - https://civicrm.org/blog/deepaksrivastava/civicrm-and-drush-integration - check the blog date [22:50:42] oh wow [22:53:53] (03Merged) 10jenkins-bot: Pending resolver outer loop + resolve skeleton [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722666 (https://phabricator.wikimedia.org/T291225) (owner: 10Ejegg) [22:54:03] thanks eileen ! [23:07:01] (03PS4) 10Cstone: WIP Switch getHostedPaymentStatus to return a PaymentDetailResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/724232 (https://phabricator.wikimedia.org/T291223) [23:07:46] (03CR) 10jerkins-bot: [V: 04-1] WIP Switch getHostedPaymentStatus to return a PaymentDetailResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/724232 (https://phabricator.wikimedia.org/T291223) (owner: 10Cstone) [23:11:03] (03PS5) 10Cstone: WIP Switch getHostedPaymentStatus to return a PaymentDetailResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/724232 (https://phabricator.wikimedia.org/T291223) [23:17:14] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 2 [=1] [23:22:08] RECOVERY - check_log_messages on frav1002 is OK: OK [23:32:46] 10Fundraising-Backlog, 10Analytics-Radar, 10Product-Analytics, 10Wikipedia-iOS-App-Backlog, and 2 others: Understand impact of Apple's Relay Service - https://phabricator.wikimedia.org/T289795 (10nettrom_WMF) [23:33:19] ejegg: looking at this again I don't remember the end goal with the normalization, was it to get the stuff from the response array into the paymentDetailResponse object [23:33:55] 10Fundraising-Backlog, 10Analytics-Radar, 10Product-Analytics, 10Wikipedia-iOS-App-Backlog, and 2 others: Understand impact of Apple's Relay Service - https://phabricator.wikimedia.org/T289795 (10nettrom_WMF) [23:35:05] cstone: so I think the WIP for the resolve action shows what we need [23:35:08] lemme see [23:35:37] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/722703/2/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/Action/PendingTransaction/Resolve.php [23:36:03] $statusResult->getGatewayTxnId [23:36:10] $statusResult->getRiskScores [23:36:38] ok thanks [23:37:00] oh, those riskScores could be done as part of this other ticket: https://phabricator.wikimedia.org/T291230 [23:37:20] $statusResult->getStatus [23:38:38] so yeah, i guess just status and gateway txn id for this first ticket