[00:00:14] k back in a bit! [00:00:17] oh maybe because ^^^ hadn't merged [00:00:18] cya [00:13:29] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Amber Johnson - https://phabricator.wikimedia.org/T293679 (10Dwisehaupt) [00:15:42] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Amber Johnson - https://phabricator.wikimedia.org/T293679 (10Dwisehaupt) Yubikey public key added. @AMJohnson At this point you will want to set up the ssh config file as mentioned here: https://collab.wikimedia.... [00:18:18] Fr-Tech. I refreshed the unsettled list and sent it via email. I was able to manually settle everything through 30 October so we are just 2 days behind. If we run into issues settling the list I just sent, I can get contractors to help settle further tomorrow, Adyen console permitting. Please keep in touch. Thank you. [00:27:01] FrTech I thought I would share this picture of unsettled transactions for your info. We can keep trying to settle manually until we can get the script to catch these up if needed. https://usercontent.irccloud-cdn.com/file/m3ZSDo1Y/image.png [00:27:35] This is from launch through current [00:31:19] emartin hi! thanks for that! update, the script to fix settle everything is done and ready to be used, and the general Apple Pay fix is also done and either deployed or ready to be deployed (not sure which) [00:31:45] we'll keep you posted of course [00:48:38] thank you emartin [00:48:50] i'm just testing the fix locally one more time before deploying [00:49:42] yep, looks like it is correctly capturing [00:50:35] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/736090 [00:50:39] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/736090 (owner: 10Ejegg) [00:52:00] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/736090 (owner: 10Ejegg) [00:52:30] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/736091 [00:52:33] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/736091 (owner: 10Ejegg) [00:52:59] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/736091 (owner: 10Ejegg) [00:55:26] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/736092 [00:55:31] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/736092 (owner: 10Ejegg) [01:01:35] hey im back now do you need help testing anything ejegg ? [01:02:33] hi also cstone ejegg I'm almost fully back at the keyboard, will be fully back in about 15 min [01:02:44] thanks so much for deploying btw ejegg! [01:02:52] +1 ^ [01:05:41] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/736092 (owner: 10Ejegg) [01:14:04] cstone: hi! [01:14:13] just about to deploy in case you want to watch logs or do tests [01:14:34] ok cool [01:15:29] i guess should we do civi too to get the whole ideal recurring piece out too? [01:17:33] oh yep, good call [01:17:45] do you want to prep that deploy? [01:18:07] I've just got payments-wiki and standalone smashpig ready [01:18:11] ok sure [01:18:57] !log updated payments-wiki from 5b9fdd0fe1 to 73de4731bd [01:18:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:19:33] k, ingenico transactions still seem to be coming through fine! [01:19:48] so no breakage from your status patch [01:21:32] !log updated SmashPig standalone deploy from dd3a81c7c2 to be68299b92 [01:21:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:22:13] (03PS1) 10Cstone: Update SmashPig to v0.7.6.1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736095 [01:24:04] ejegg cstone back :) [01:24:41] hi AndyRussG [01:24:53] so the deploy doesn't seem to have caused any errors so far [01:24:54] (03PS1) 10Eileen: Move & rename test file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736096 [01:25:15] I guess we can test an apple pay txn if anyone has a device provisioned for IRL transactions handy [01:25:52] i can real quick [01:26:06] hardest part is editing url on the ipad haha [01:27:02] thanks! [01:27:09] :) [01:27:39] ok just donated [01:28:32] it might initially show as just authorized then turn to sentforsettle [01:28:47] oh darn, that csv got mangled by some spreadsheet software [01:29:12] the PSP references are coming out in scientific notation: 6.45936E+15 [01:29:18] haha [01:29:21] lemme see if I can pull the transactions [01:29:53] polar vs rectangular psp vector [01:30:56] I honestly didn't understand the relationship from polar to rectangular until i was tutoring math and was like oh its just a triangle .... [01:31:55] srsly, how often do people who use excel WANT scientific notation? [01:32:11] but most of my college work was in 10^-6 to -9 territory [01:32:42] everyone wants it [01:33:48] (03PS7) 10Eileen: Move tables for eoy_receipt from drupal db to civicrm db [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734799 (https://phabricator.wikimedia.org/T290253) [01:34:29] (03PS1) 10Cstone: Update SmashPig to v0.7.6.1 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/736098 [01:35:08] hehe [01:35:17] (03CR) 10Cstone: [C: 03+2] Update SmashPig to v0.7.6.1 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/736098 (owner: 10Cstone) [01:36:06] (03CR) 10Cstone: [C: 03+2] Update SmashPig to v0.7.6.1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736095 (owner: 10Cstone) [01:39:04] (03CR) 10jerkins-bot: [V: 04-1] Move tables for eoy_receipt from drupal db to civicrm db [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734799 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [01:40:07] (03PS8) 10Eileen: Move tables for eoy_receipt from drupal db to civicrm db [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734799 (https://phabricator.wikimedia.org/T290253) [01:42:40] oh right cstone, that crm update was necessary to get the audit parser picking up apple pay txns too! [01:44:27] K I'm gonna make some wee patches as promised [01:44:56] also available for anything else as needed [01:45:20] ok cool [01:46:33] (03PS2) 10Eileen: Move tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734803 [01:47:08] (03Merged) 10jenkins-bot: Update SmashPig to v0.7.6.1 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/736098 (owner: 10Cstone) [01:47:10] (03Merged) 10jenkins-bot: Update SmashPig to v0.7.6.1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736095 (owner: 10Cstone) [01:47:31] cstone: so your Apple Pay was 1 usd right? It does say settled! :) :) [01:47:36] yep 1 usd [01:47:42] woo! [01:47:44] yay [01:47:55] and there's another apple pay in EUR that's also settled! [01:47:59] woo!! [01:48:07] yee [01:48:31] (03PS3) 10Eileen: Move tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734803 [01:49:38] (03PS1) 10Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/736099 [01:50:44] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/736099 (owner: 10Cstone) [01:52:16] (03CR) 10Cstone: [C: 03+2] "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/736099 (owner: 10Cstone) [01:54:41] (03CR) 10jerkins-bot: [V: 04-1] Move tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734803 (owner: 10Eileen) [01:56:47] !log civicrm revision changed from 403be9ce05 to 93caef68ef [01:56:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:06:49] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10fundraising sprint Universal Cereal Bus, 10fr-donorservices: Clean up new adyen ideal recurrings - https://phabricator.wikimedia.org/T291712 (10Cstone) [02:27:20] (03Abandoned) 10Eileen: Move tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734803 (owner: 10Eileen) [02:35:08] ok, looks like the script is doing its job to capture the rest of 'em [02:35:34] will give it a couple of minutes and check the console [02:37:47] nice [02:44:06] OK, that did it! [02:44:48] gonna call it a night [02:48:58] ejegg: congrats and thx! [02:49:46] did you use the file sent by Evelyn or did you export ur own? [02:50:14] AndyRussG: i had to use my own - the one sent by Evelyn had the pspReferences mangled by Excel [02:50:35] the transform to scientific notation was non-reversible [02:50:37] ah right... yeah I see now, really unsalvageable [02:50:52] ah glad it worked! [02:50:59] but it wasn't any trouble pulling it - maybe the console's fixed [02:51:04] cool! [02:51:47] ejegg: I should let you do the honors of replying that it's fixed, but also I'm available to do so if you'd like, if you're calling it a day [02:54:20] i'll update the ticket [02:55:02] ejegg: thx!! :) [02:55:05] 10Fundraising-Backlog, 10FR-Amazon, 10MediaWiki-extensions-DonationInterface: Amazon Pay page sometimes not loading payment widgets - https://phabricator.wikimedia.org/T294514 (10Ejegg) @krobinson have you seen any donor complaints about this? I'm trying to figure out if this is worth worrying about. They w... [02:59:56] 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10Patch-For-Review: DonationInterface CI is stuck - https://phabricator.wikimedia.org/T294722 (10Ejegg) I had to manually edit the vendor/composer/installed.json file to change smash-pig's "installation-source" property from "source" to "dist"... [03:00:48] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10MW-1.38-notes (1.38.0-wmf.7; 2021-11-02): Declines due to API settings - https://phabricator.wikimedia.org/T294059 (10Ejegg) This has been deployed [03:02:33] 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), 10Patch-For-Review: Apple Pay: Payments require capture - https://phabricator.wikimedia.org/T294721 (10Ejegg) OK, the payments-wiki change has been deployed, and new Apple Pay donations are getting... [03:18:25] (03CR) 10Cstone: [C: 03+2] "I agree that it's confusing" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734442 (owner: 10Ejegg) [03:19:21] (03Merged) 10jenkins-bot: Move WSDL shim to bootstrap [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734442 (owner: 10Ejegg) [03:19:21] That's one of the better +2 messages I've seen in a bit ;-) [03:20:01] haha [03:22:27] For the record, I agree [03:22:52] It's a good patch [03:24:37] heh [03:30:37] (03PS1) 10Eileen: Switch logging to use watchdog [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736107 (https://phabricator.wikimedia.org/T290253) [03:45:15] (03CR) 10Cstone: [C: 03+2] "Yay for tests and good base for the rest of the calls" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734447 (owner: 10Ejegg) [03:46:08] (03Merged) 10jenkins-bot: Unit test for Adyen encrypted payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734447 (owner: 10Ejegg) [04:44:52] (03Abandoned) 10AndyRussG: [DO NOT MERGE] Test CI: Update SmashPig library and vendor directory [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/735765 (https://phabricator.wikimedia.org/T294722) (owner: 10AndyRussG) [06:04:49] (03PS1) 10AndyRussG: [WIP] Refactor ExceptionMapper to handle error code 905 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736109 (https://phabricator.wikimedia.org/T294032) [06:05:37] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Refactor ExceptionMapper to handle error code 905 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736109 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [06:05:41] (03PS1) 10AndyRussG: [WIP] Adyen Checkout: Update for Exceptionmapper refactor and error 905 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736110 (https://phabricator.wikimedia.org/T294032) [06:06:14] (03PS2) 10AndyRussG: [WIP] Refactor ExceptionMapper to handle error code 905 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736109 (https://phabricator.wikimedia.org/T294032) [06:06:20] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Adyen Checkout: Update for Exceptionmapper refactor and error 905 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736110 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [06:06:42] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Refactor ExceptionMapper to handle error code 905 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736109 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [06:09:18] (03PS3) 10AndyRussG: [WIP] Refactor ExceptionMapper to handle error code 905 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736109 (https://phabricator.wikimedia.org/T294032) [06:20:27] (03CR) 10AndyRussG: "Thanks for this!! :) Here's the alternative approach mentioned:" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732803 (https://phabricator.wikimedia.org/T294032) (owner: 10Ejegg) [06:53:52] (03PS1) 10Eileen: Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) [07:05:20] (03CR) 10jerkins-bot: [V: 04-1] Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [07:09:06] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736133 (owner: 10L10n-bot) [07:24:05] (03PS2) 10Eileen: Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) [07:29:39] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/735835 (owner: 10L10n-bot) [07:30:00] (03PS3) 10Eileen: Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) [07:30:02] (03CR) 10Raimond Spekking: [C: 03+2] "fasle positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736133 (owner: 10L10n-bot) [07:43:22] (03CR) 10jerkins-bot: [V: 04-1] Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [09:01:19] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10User-brennen, 10Wikimedia-production-error: CentralNoticeCampaignLogPager: Error: Call to a member function getId() on boolean - https://phabricator.wikimedia.org/T292662 (10Zabe) Actually all 7 of them were likely from me testing something. I... [09:04:43] 10Fundraising-Backlog, 10FR-Amazon, 10MediaWiki-extensions-DonationInterface: Amazon Pay page sometimes not loading payment widgets - https://phabricator.wikimedia.org/T294514 (10krobinson) @TomaszGorski / @KHancock99 Have we seen any French donors note this? I didn't see any in error triage. [09:52:39] 10Fundraising-Backlog, 10FR-Amazon, 10MediaWiki-extensions-DonationInterface: Amazon Pay page sometimes not loading payment widgets - https://phabricator.wikimedia.org/T294514 (10TomaszGorski) I haven't seen any French donors mentioning that issue at all and could not find any ticket (with tags: amazon or am... [10:04:29] 10Fundraising-Backlog, 10FR-Amazon, 10MediaWiki-extensions-DonationInterface: Amazon Pay page sometimes not loading payment widgets - https://phabricator.wikimedia.org/T294514 (10krobinson) @Ejegg just confirming you mean Amazon Pay (I misread Apple Pay) - Amazon Pay is not widely available to non-US donors,... [10:21:47] (03PS4) 10Eileen: Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) [10:34:24] (03CR) 10jerkins-bot: [V: 04-1] Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [14:30:01] frtech just wanted to post this here for posterity. Apple Pay looks good. Everything is settled and we're ready for tomorrow's 6ENC test. Many thanks for the attention on this. https://usercontent.irccloud-cdn.com/file/k6BpZ0vW/image.png [15:01:04] 10Fundraising-Backlog, 10FR-CiviCRM-Searchkit, 10FR-Tech-Analytics: Aggregating fields from searchkit - https://phabricator.wikimedia.org/T294504 (10EYener) Ah sorry, @Eileenmcnaughton can I help clarify more? In broad terms, it would be great if we could create a searchkit and then see a big aggregated tota... [16:29:29] fantastic to see, emartin!! thanks so so much for working on this!!!! as always, pls ping anytime :) [18:25:14] damilare: I'm free to finish the referrer call from earlier if now is good for you? [18:25:47] Yes it is jgleeson [18:26:04] Same link from earlier? [18:26:27] yeah let's use that one [19:12:18] (03CR) 10AndyRussG: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736110 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [19:29:32] (03PS1) 10AndyRussG: Apple Pay: Throw exception if details status normalizer requested [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736297 (https://phabricator.wikimedia.org/T294721) [19:31:30] (03CR) 10AndyRussG: "Heyy.. as promised, here's the follow-on patch for getPaymentDetailsStatusNormalizer(): I594ed392b9e37. Thanks!!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736028 (https://phabricator.wikimedia.org/T294721) (owner: 10Ejegg) [19:33:20] (03PS5) 10Eileen: Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) [19:34:12] fr-tech I'm gonna skip mid sprint checkin as I'm guessing folks might also skip it due to the US holiday [19:34:40] jgleeson: hehe yeah I joined and then remembered the holiday and then left [19:35:03] I am working today, tho, so don't hesitate to ping anytime [19:35:08] fr-tech ^ [19:38:39] Yea, we're doing mid-sprint check-in during standup tomorrow. No official meetings today. [19:39:04] I'm also not really here, just happened to glance at IRC while I was gaming. [19:43:32] XenoRyet: thx, have fun! [19:56:28] (03PS1) 10Eileen: Start to decouple the render function from send-once [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736298 (https://phabricator.wikimedia.org/T290253) [19:59:19] (03PS1) 10Eileen: Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) [20:01:48] (03PS2) 10Eileen: Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) [20:12:56] (03CR) 10jerkins-bot: [V: 04-1] Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [20:16:52] eileen: pls ping if u need review today btw [20:17:48] AndyRussG: ok cool - I do seem to be building up a chain so it might be good to clear out some noise from it :-) [20:18:17] the first one is hopefully fairly obvious https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/734789/3 [20:18:19] ah sounds fun [20:19:45] hehe that is a chain indeed [20:23:56] eileen: I assume there's some Civi UI thing to smoke test? [20:24:02] or command line to run? [20:24:15] AndyRussG: yeah - I'm working that all out :-) [20:24:45] the patches prior to https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/734799/8 are all only touching tests [20:25:06] at that point we get into some drush commands (which I'm changing ) [20:25:28] ah oki got it [20:25:57] of course - I've started documenting the new ones but not the old [20:26:17] K I can look into the test ones and then maybe let me know when you're ready for review on the non-test ones I guess? [20:27:13] yeah - start with the test ones & see how you go & we can hang out once it stops making sense :-) [20:28:14] drush @wmff wmf-eoy-receipts year=2021 [20:28:14] is probably the main command [20:28:36] ok cool [20:29:09] I might break for 90 min or so pretty soon but I can also be flexible about that... how long are u around today? [20:36:33] all day [20:40:57] oki cool thx [20:45:32] (03PS9) 10Eileen: Move tables for eoy_receipt from drupal db to civicrm db [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734799 (https://phabricator.wikimedia.org/T290253) [20:50:24] I'm gonna call it a day. bye for now fr-tech o/ [20:50:37] cya! [20:51:12] bye AndyRussG catch you tomorrow! :) [21:16:51] AndyRussG: I've started some documentation - https://wikitech.wikimedia.org/wiki/Fundraising/Internal_Endpoints/End_of_year_emails - this is written mostly towards the current master state - it will change as things are merged [21:24:57] eileen ah nice! looks great! [21:25:24] AndyRussG: yeah - I felt like I could figure out where to put it - which has always felt like the blocker [21:33:02] ahhh great to hear! [22:27:47] (03PS2) 10Eileen: Switch logging to use watchdog [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736107 (https://phabricator.wikimedia.org/T290253) [22:27:49] (03PS6) 10Eileen: Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) [22:27:51] (03PS2) 10Eileen: Start to decouple the render function from send-once [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736298 (https://phabricator.wikimedia.org/T290253) [22:27:53] (03PS1) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [22:42:08] (03CR) 10jerkins-bot: [V: 04-1] Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [22:57:09] (03PS2) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [23:07:06] (03PS3) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [23:15:31] K I'm just rebuilding as a first step to get back to Civi work [23:17:07] 10Fundraising-Backlog, 10FR-Amazon, 10MediaWiki-extensions-DonationInterface: Amazon Pay page sometimes not loading payment widgets - https://phabricator.wikimedia.org/T294514 (10KHancock99) I have not seen this mentioned anywhere yet, with either payment method. If I do, I will suggest the page refresh as a... [23:19:36] (03CR) 10jerkins-bot: [V: 04-1] Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [23:20:15] AndyRussG: always a good first step [23:20:38] yee :) [23:24:08] Hmmmm locally with ./civicrm-phpunit.sh wmff --filter EoySummaryTest I get failures [23:25:10] https://paste.toolforge.org/view/9571fa8c [23:25:12] eileen: [23:25:16] ^ [23:28:03] though i see it does pass CI [23:31:27] also the errors are not in tests where the changes to the file occured [23:32:55] both errors locally are happening in assertions with TestMailer::countMailings() [23:42:02] hahah one-time walrus and recurring rabbit [23:46:14] (03CR) 10AndyRussG: [C: 03+2] Function extraction in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734789 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [23:49:59] how is what's in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/734789 generated and what's the significance? [23:52:17] sorry wrong link [23:52:41] mean to ask about this one rather: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/736077 [23:58:10] (03Merged) 10jenkins-bot: Function extraction in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734789 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen)