[00:06:40] (03CR) 10AndyRussG: [C: 03+2] "Fantastic!!!!!!!!!! :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736096 (owner: 10Eileen) [00:09:29] K still gotta walk the dog, so just gonna do that... [00:17:25] AndyRussG: not much in that one - just regenerated to the latest version [00:46:43] eileen: oki and so how are they generated? [00:46:51] civix [00:47:12] That's how we generate all the boilerplate bits [00:49:00] oki [00:49:10] specifically what's the civix command? [00:56:42] civix generate:test [00:56:55] (you have to delete them first & they get re-created) [00:58:59] oki [00:59:19] so you just run that command and it spit out those files, right? [00:59:59] AndyRussG: yep - bit if they exist it won't update them [01:00:20] cool thx! [01:00:56] (03CR) 10AndyRussG: [C: 03+2] "Yeee, and also thanks for the explanations!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736077 (owner: 10Eileen) [01:03:20] eileen: ok so I'm done with the test-related ones it seems... At some point this evening I have to do an errand which will take around 1 hr, but it's pretty flexible... are the next ones ready for review? what would you say is the best way for me to go about reviewing them? [01:04:15] AndyRussG: so this is the next one - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/734799 [01:04:49] yep [01:04:49] & that moves the data around - I think it's mostly running the drush command mentioned in the commit message & poking around [01:05:01] but we can hangout if you want to go through it [01:06:43] (03CR) 10AndyRussG: Switch logging to use watchdog (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736107 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [01:07:12] eileen: K if you like I can poke at it a bit and ping u if I'm confused? how does that sound? [01:11:10] ok sure - I have to do kid duties in 45 mins [01:11:22] (03Merged) 10jenkins-bot: regenerate phpunit & bootstrap files (using civix) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736077 (owner: 10Eileen) [01:12:13] (03Merged) 10jenkins-bot: Move & rename test file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736096 (owner: 10Eileen) [01:21:45] eileen: so the fact of calling \CRM_Core_DAO::executeQuery instead of db_query causes us to get stuff from the civi db instead of the drupal one, correct? [01:22:41] AndyRussG: right so a) it's a CiviCRM function not a drupal function so will work post upgrade & yeah 2 - it fetches from the CiviCRM DB [01:31:06] (03PS1) 10Eileen: Boilerplate updates in test loading [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736321 [01:32:20] ok so Render.php is the only change that actually runs as part of a job, correct eileen? The rest is just setup and tests, no? [01:32:34] AndyRussG: yeah [01:33:12] Apart from the job there is the one UI place to call stuff from - which I mentioned in the docs too [01:34:19] (03PS2) 10Eileen: Boilerplate updates in test loading [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736321 [01:42:15] ok cool yeah the docs are quite helpful [01:43:19] eileen: don't wait on me to do your kid duties pls btw... I'll have fun continuing to look through this, and also can go do my errand in a bit then [01:43:41] ok cool - I'll be heading out in 10 [01:46:45] okok [01:50:29] hmm curious about the reason there is sql in wmf_thankyou_install.sql and wmf_eoy_receipt.install that seems essentially the same [01:52:20] and also what replaces the sql in wmf_eoy_receipt_update_7005 [01:52:56] ahh wait that's all test install stuff I guess? [01:53:12] (03PS10) 10Eileen: Move tables for eoy_receipt from drupal db to civicrm db [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734799 (https://phabricator.wikimedia.org/T290253) [01:53:14] (03PS3) 10Eileen: Boilerplate updates in test loading [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736321 [01:53:16] (03PS3) 10Eileen: Switch logging to use watchdog [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736107 (https://phabricator.wikimedia.org/T290253) [01:53:18] (03PS7) 10Eileen: Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) [01:53:20] (03PS3) 10Eileen: Start to decouple the render function from send-once [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736298 (https://phabricator.wikimedia.org/T290253) [01:53:22] (03PS4) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [01:58:42] (03PS5) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [01:58:53] AndyRussG: re the install [01:59:14] the stuff in wmf_thankyou_install.sql needs to run on live [01:59:20] to create the tables in the civi db [01:59:45] & because the extension is already installed there it won't get it when it installs the extension (like our dev set ups will) [02:00:01] but, once it has run there & on staging I'm gonna rip it out [02:01:33] eileen: ah cool... so where is the sql or equivalent that will run on dev setups? I realized the sql I was looking at before was in the tests directory [02:01:58] also I guess I could suggest maybe explaining this in the commit message and in that file? [02:02:06] as of right now both places will run - but one has an 'if not exists' [02:02:41] As soon as that is merged I'll deploy & then remove the duplication - so commit message = ok but the file is a bit pointless [02:02:53] oki thanks [02:02:56] in the end ONLY the extension one will run when we do new installs [02:03:22] right also oops I see also it _isn't_ in a test directory, I was just looking at the directory tree crooked, heh [02:04:28] thx btw!! K also gonna do my errand then, back in about 1 hr... or hopefully not too much more... [02:07:09] (03CR) 10jerkins-bot: [V: 04-1] Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [02:39:46] eileen: unfortunately it seems my errand will take a good bit longer than expected..... [02:59:09] `no worries [04:21:28] (03PS4) 10Eileen: Switch logging to not use watchdog [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736107 (https://phabricator.wikimedia.org/T290253) [04:21:36] (03CR) 10Eileen: "yep" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736107 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [04:23:04] eileen: hey back now [04:24:13] cool - me too :-) [05:02:57] eileen: hmmm I guess I should figure out how to set up the test data to smoke test then [05:03:27] have you tried c stone's mailcatcher setup to look at e-mails sent? [05:03:43] yeah - so you need to choose 'submit credit card contribution' to create a recurring [05:04:29] oki lemme see if I can figure that out... [05:04:45] I've been stepping through them in the tests for the email details [05:05:16] ah right [05:05:18] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/713018 [05:05:21] haven't tried it yet [05:12:23] oki so tables got created fine [05:13:06] yay [05:19:34] ok I think I created a recurring correctly [05:22:14] eileen: why is the command in the commit message different from the commands in the doc? [05:22:32] AndyRussG: that is the drush command? [05:23:07] drush @wmff wmf-eoy-receipts --year=2021` [05:23:25] yeah that's the one I'm about to try [05:23:35] yeah - it just calls both the others [05:23:55] oki right that's what I was assuming [05:23:58] it doesn't make sense on prod - but I guess it's handy locally [05:24:08] oki [05:24:36] a note about that might be handy in the commit message too? [05:31:31] AndyRussG: yeah - although it probably is less work & more useful long term in the docs [05:34:06] FWIW - I don't expect that command to exist by the end of the process though [05:38:41] hmmm oki... I mean, I just don't know where else I might easily find the answer to the above question if I ever had to at this commit in the repo history [05:39:13] *look at this commit [05:39:57] AndyRussG: yeah - I just updated the docs [05:40:10] ah oki thanks! [05:40:40] ah btw visual editor has a style for putting text in monospaced font, and also an associated shortcut key [05:40:44] ideally I suppose the readme would have been updated years ago - but since those commands are on their way out it seems the wrong time to document them [05:40:51] oh cool [05:41:28] hmmm [05:43:13] - the wiki page is ok though - cos it's light weight to edit [05:45:06] ah oki [05:45:43] eileen: it's dying with at the first query in EOYSummary::send_letters(), line 124, since $this->job_id is not set [05:46:00] so it then says, "CRM_Core_Exception: [0: One of parameters (value: ) is not of the type Integer" [05:46:37] running it like it says in the commit message, drush @wmff wmf-eoy-receipts --year=2021 [05:46:42] AndyRussG: ah yeah - in prod we pass that in - `drush @wmff wmf-eoy-send-letters --job_id=x` [05:47:35] I'll try it with the separate commands [05:47:37] tbh I only added that to the commit message after you asked about how to smoke testing & then I did a round of rebasing - it's a lot easier to update the docs page [05:47:53] ahhhh rebasing heheh [05:48:04] yep :-( [05:48:16] * AndyRussG assumes responsibility [05:48:43] (assumes is the wrong word? accepts?) [05:49:39] lol - it's just the pain of the workflow :-( [05:50:01] in gitlab you do one merge request template for multiple commits [05:50:05] & that is easy to edit [05:50:16] so the commit messages wind up being quite brief [05:51:01] hmmm [05:51:18] docker@civicrm:/srv/civi-sites/wmff/drupal$ drush @wmff wmf-eoy-calculate-summaries --year=2021 [05:51:20] Calculation successful - now you can send the letters with 'drush wmf-eoy-send-letters --job_id=' [05:51:58] I don't see anything in the new tables yet though... which job_id would I use? [05:54:57] hmm - were there any contributiosn with contribution_recur_id not null [05:55:25] (FYI I think it is probably logging something there but I think it should throw an exception) [05:55:57] dunno... I just created one recurring via the UI, I think correctly-ish following your instructions above? [05:56:15] yeah it should be [05:56:44] AndyRussG: make sure the contribution status is 'Completed' [05:57:10] oh ok...yeah it says pending [05:57:13] that's a gotcha because it will leave as 'Pending' with the dummy processor (to mimic ones that ipn-complete) [05:57:42] K I'll try again [05:58:35] oki now it's doing stuff [05:58:52] first time it hadn't hit my breakpoints either, but now it has [05:59:21] cool [05:59:53] this is the line I think should throw an exception https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/736107/4/drupal/sites/all/modules/wmf_eoy_receipt/EoySummary.php#89 [06:02:42] instead of just returning false you mean? [06:02:57] yep [06:03:04] oki sure [06:03:10] also there's an unused import on line 2 of Upgrader.php [06:03:53] also just to check, so CRM_WmfThankyou_Upgrader_Base is generated by civix based only on what's in CRM_WmfThankyou_Upgrader? [06:05:58] yep [06:06:29] k cool [06:06:38] welp it appears to have worked now eh! [06:06:48] yay [06:07:55] if you are going to make any changes (like the exception) and would like to change the commit message along the way, to maybe mention the two commands (since those worked, and as you said, will stick around) as well as the purpose of the sql file to be run on prod that will later be removed... that's cool, but it's not a blocker for sure [06:08:54] I wasn't going to make any more changes in the existing commit chain - just change the exception down the track [06:09:07] ok [06:09:23] also looks like upgrader.php line 13 is a stock copypasta comment? [06:09:32] "Example: Run an external SQL script when the module is installed." [06:09:45] yep it is generated [06:10:12] ah so CRM_WmfThankyou_Upgrader is also generated? [06:11:40] yep [06:13:58] huh [06:14:00] from what? [06:14:36] civix generate:upgrader [06:14:50] I mean, where does civix get the non-generic stuff there, like 'label' => 'Sent year-end summary receipt', etc? [06:15:17] or does it ask questions on the command line? [06:18:18] oh no - that part was moved from the wmf_civicrm.install in the drupal module [06:18:30] ah I see [06:18:38] so the base file was generated and you added that stuff [06:19:00] and I guess removed the "auto-generated file" warning that civix may have added at the top, too? [06:20:16] I don't know if it did - because that file isn't overwritten by civix like the .civix.php one is so it doesn't need the warning [06:20:32] hmmm oki [06:20:46] K well ahhhh [06:22:00] apologies for asking for rebasing and for being stubborn, but.... uhhh I'd really prefer to see the inline doc for the non-generated function in Upgrader.php say something better? [06:23:10] and really along the way I guess I'd like to pretty strongly recommend that the commit message either mention commands that work, or if not, just point the reader to doc elsewhere [06:23:37] (03PS11) 10Eileen: Move tables for eoy_receipt from drupal db to civicrm db [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734799 (https://phabricator.wikimedia.org/T290253) [06:24:09] AndyRussG: ok - I edited it - - the other commits will need rebasing now [06:24:45] yea really sorry about that and thanks [06:24:51] Re the commits - I guess I maybe need to switch away from doing lots of incremental commits - or else develop some boiler plate I paste into every commit? [06:24:52] uhh before you do ^ commit message fix? [06:25:26] What change did you want to the commit (you can also edit it yourself) [06:25:29] huh I dunno, or maybe some scripts to rebase everything automatically? [06:25:44] ah oki I'll do that [06:26:11] (03PS12) 10Eileen: Move tables for eoy_receipt from drupal db to civicrm db [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734799 (https://phabricator.wikimedia.org/T290253) [06:26:41] ok - I updated & removed the command & instead linked to the docs [06:27:05] ah ok great heh [06:28:17] (03CR) 10AndyRussG: [C: 03+2] "Ahhhh recurring rebase thank-you note here :) thx!!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734799 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [06:28:40] K apologies for having been a pain........... [06:29:16] I think it's sleepy time now also! [06:30:45] also really nice work with all these fixes!! [06:31:12] night night [06:31:24] I'm not sure it's so much that you do the changes incrementally, maybe more that you're churning out tons of stuff :) [06:31:26] cya! [06:31:41] AndyRussG: yay - I can fix up those tables on live now tho [06:32:05] ah fantastic, yeah thanks for bearing with me [06:39:34] (03Merged) 10jenkins-bot: Move tables for eoy_receipt from drupal db to civicrm db [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/734799 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [06:51:26] (03PS4) 10Eileen: Boilerplate updates in test loading [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736321 [06:51:28] (03PS5) 10Eileen: Switch logging to use watchdog [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736107 (https://phabricator.wikimedia.org/T290253) [06:51:30] (03PS8) 10Eileen: Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) [06:51:32] (03PS4) 10Eileen: Start to decouple the render function from send-once [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736298 (https://phabricator.wikimedia.org/T290253) [06:51:34] (03PS6) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [06:51:36] (03PS1) 10Eileen: Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 [07:03:56] (03CR) 10jerkins-bot: [V: 04-1] Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen) [07:58:50] (03PS2) 10Eileen: Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 [08:11:21] (03CR) 10jerkins-bot: [V: 04-1] Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen) [13:57:14] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12602 [14:00:17] hi fr-tech folks, due to our daylight confusion time today's tech-talk is now an hour earlier for me and clashes with Oscar's after school club that I've been taking him the last few weeks. I was gonna ask if we could move it out a little just for this week but we also have civi forthnightly 40 minutes after tech-talk today so it feels like it might be best for me to just miss this week's call [14:00:19] and catch up via recording tomorrow. Sorry about that! The world goes back to normal next week when daylight savings also end in the US on sunday [14:01:12] on the plus side standup is now an hour earlier so I don't have to miss that as a typically do on wednesdays! [14:02:14] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12694 [14:07:14] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12808 [14:12:14] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12420 [14:17:14] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 10612 [14:22:14] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 7863 [14:27:14] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 4015 [14:37:14] RECOVERY - check_mysql on frdb1002 is OK: Uptime: 1177065 Threads: 11 Questions: 64926118 Slow queries: 604 Opens: 289492073 Flush tables: 1 Open tables: 230 Queries per second avg: 55.159 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 448 [15:37:44] 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus: Block repetitive known fraudsters - https://phabricator.wikimedia.org/T290600 (10EMartin) Here is another fraudster we detected that has perpetrated many attempts, can we block this email as well? 51348627 [15:54:33] (03PS3) 10Jgleeson: WIP resolve pending transactions w/o DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [15:54:54] ejegg: just rebasing that patch to make it easier to diff locally [15:55:48] cool jgleeson [15:55:49] hi fr-tech jgleeson! no issues with me wrt moving tech-talk btw [15:55:55] hi ejegg [15:55:58] hi AndyRussG [15:55:59] hi AndyRussG ! [15:56:37] oh drat jgleeson i had another revision locally [15:56:46] let me upload that [15:56:52] sure [15:57:22] do you wanna take that back? [15:57:25] (03PS4) 10Ejegg: WIP resolve pending transactions w/o DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) [15:57:43] I guessed that was still required before I work on the ticket I picked up [15:57:48] (detecting previous donors) [15:57:50] jgleeson: i was planning to focus on reviewing eileen's stuff right now, so please go ahead [15:57:57] ah coo [15:57:59] l [16:04:04] AndyRussG: wrt to moving tech-talk, thanks and really appreciate the flexibility. I'm thinking that with civi forthnightly closely following, it doesn't give us a break beforehand if we merge them together. it feels like it might be better to keep it as it is as it's only one week that I can't make it and I can catch up on anything missed in the recording. [16:08:02] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:(Need By: TBD) rack/setup (4) fundraising hosts - https://phabricator.wikimedia.org/T289812 (10Cmjohnson) 05Open→03Resolved DC-OPS portion is complete, if there are any issues please re-open [16:27:13] good fishystery solved here: https://www.bbc.co.uk/news/uk-england-dorset-59141394 [16:27:15] 10fundraising-tech-ops: Fundraising access request for Jayde Antonio - https://phabricator.wikimedia.org/T287387 (10Dwisehaupt) [16:27:27] British Airways said it was reuniting customers with their bags after realising "something fishy was going on". [16:27:30] brilliant lol [16:27:31] 10fundraising-tech-ops: Fundraising access request for Jayde Antonio - https://phabricator.wikimedia.org/T287387 (10Dwisehaupt) 05Open→03Resolved Received confirmation that all is working for Jayde. [16:48:38] fr-tech dang I just spent 15 minutes in the wrong video chat [16:49:04] anyway, i'm in the tech talk one now in case anyone still can attend [16:49:15] ejegg: oh did we move that then? yes I can go one sec [16:49:33] AndyRussG: argh, no, sorry [16:49:37] somehow I got confused [16:49:45] and thought it was right after standup [17:33:33] 10Fundraising-Backlog, 10FR-Smashpig, 10MediaWiki-extensions-DonationInterface: Refactor ValidationError - https://phabricator.wikimedia.org/T294957 (10Ejegg) [18:05:54] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-Tech-Analytics: Low Traffic Test Difference in impressions between event_sanitized.centralnoticebannerhistory and pgehres.bannerimpressions - https://phabricator.wikimedia.org/T294145... [18:07:48] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-Tech-Analytics: Low Traffic Test Difference in impressions between event_sanitized.centralnoticebannerhistory and pgehres.bannerimpressions - https://phabricator.wikimedia.org/T294145... [18:15:43] Fr-tech just lost my internet hopefully it won't be down the full hour [18:16:01] 10-4, good luck [18:39:07] fr-tech did my message make it to the chat on tech-talk just now? [18:39:20] ype, thanks jgleeson [18:39:56] ah thanks. it looked greyed out so thought I might have exited too quickly, thanks for confirming! [19:08:29] (03PS1) 10Ejegg: Adyen: Add payment_method to error form URL [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736556 [19:08:47] damilare: ^^^ is the thing from tech talk [19:11:00] (03CR) 10jerkins-bot: [V: 04-1] Adyen: Add payment_method to error form URL [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736556 (owner: 10Ejegg) [19:11:30] ejegg: I tried it as soon as you dropped off, looks like we might have to add additional parameters [19:11:37] like the amount [19:11:42] As there's a new error [19:12:38] oh hmm, maybe the best fix would be to figure out why we don't have stuff in session then [19:14:32] I think so too, the session would help repopulate those fields [19:15:48] So I guess you would want to use the breakpoint up in GatewayPage.php [19:17:15] around here: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/GatewayPage.php$312 [19:17:53] and see if the Adyen checkout page is getting to the session_addDonorData() call down at https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/GatewayPage.php$327 [19:20:30] by the way, it might be easier to test this condition by making the referrer filter match the devwiki main page https://localhost:9001/index.php/Main_Page [19:20:50] so you don't have to hack ty page links in the console every time [19:21:08] okk [19:21:15] ejegg: can you jump back into same hangout [19:21:26] Nora there now with matching gifts question [19:21:27] sure [19:21:29] sure eileen [19:22:27] ejegg: damilare AndyRussG I recorded the js redirect happening in the flesh https://phabricator.wikimedia.org/F34728273 [19:22:49] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/736560 [19:27:02] jgleeson: ok, cool. damilare says that even with that additional payment_method on the JS redirect URL there are then problems with the amount being missing [19:27:34] so maybe we do need to figure out why the original parameters aren't being stored [19:27:59] jgleeson: it appears the api isn't providing all the parameters in the failUrl because they aren't properly saved in the session [19:28:14] the amount and other parameters [19:28:28] interestings [19:34:41] 10fundraising-tech-ops: upgrade fundraising Superset instance to 1.3.1+ - https://phabricator.wikimedia.org/T292294 (10razzi) We deployed superset 1.3.1 Note that there are settings that need to be moved for presto to work in the new version; see the config at https://superset.wikimedia.org/databaseview/list/ t... [19:35:00] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/736560 (owner: 10Eileen) [19:38:19] damilare: ejegg just a bit more on this. it looks like that exact same form URL works fine when you get the failure back from the gateway and not from our fraud filters [19:39:37] jgleeson so is that because we hit this line: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/adyen_gateway/checkout/adyen_checkout.adapter.php$17 [19:39:42] ? [19:39:51] hmm struggling to now recreate the frontend version of that error page [19:41:33] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fr-matching-gifts: Track where we got employer information and export that to Acoustic - https://phabricator.wikimedia.org/T294488 (10Ejegg) Eileen says it would be best to add a custom field on the 'employer of' relationship type. Nora says this coul... [19:43:19] jgleeson: was there a hit on the addDonorData line [19:44:02] sorry I wasn't debugging it. I was playing with the risk scores to try and recreate that frontend "graceful" error [19:44:28] and failing at that currently [19:51:39] 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus: Donation Interface Translation deployment - https://phabricator.wikimedia.org/T294385 (10HNordeenWMF) Thank you @Ejegg ! [19:52:38] eileen: that buildkit patch just got +2'd and merged!!! [19:55:44] (03CR) 10Eileen: [C: 03+2] "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/736560 (owner: 10Eileen) [19:55:49] ok finally got it [19:56:08] damilare: ejegg|food this is the code which triggers the error message via js https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/7382eba8a1579a0cddd03ee0fb2f23a01317e999/adyen_gateway/checkout/adyen_checkout.adapter.php#L22 [19:56:27] using the forms.js showErrors stuff [19:58:24] the other error scenarios are when the error is sent back LAST and the isFailed=true property is in the result passed back to the code making the ajax api call [19:58:45] that's the code that also redirects to the brokenish error page URL [19:59:23] (the flow in the screengrab from earlier) [20:02:18] hmm [20:04:36] !log civicrm revision changed from 93caef68ef to ac6f333db6, config revision is d3bb9999e7 [20:04:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:06:02] damilare: I'm calling it a day. gonna try and catch some of the Liverpool vs Athetico Madrid Champions League game. I'll check in tomorrow but if you don't crack it tonight we can dig in more on our check-in. thanks for persisting!!! [20:06:22] bye for now fr-tech [20:06:31] Sure, thanks jgleeson [20:41:26] ejegg|food: I'm looking at the drupal variable for the from name & email for the eoy_receipt & at the moment we have [20:41:26] - variables for the from name & email for eoy receipt [20:41:26] - separate variables for the same from 'thank you' [20:41:26] - Any emails sent from CiviCRM (including recurring failure) use the first default email from https://civicrm.wikimedia.org/civicrm/admin/options/from_email_address?reset=1 [20:50:53] XenoRyet: ejegg|food there is a civi core meeting on my calendar in 10 - do you have it in yours [20:51:20] Im not seeing chat about it on Civi channel - so might be only me :-) [21:01:36] It's on mine, but it's just a sync up so if neither side needs it we can skip. [21:10:06] AndyRussG: So an illuminating use case for the ValidationError refactor might be how to push the Amount validator down into SmashPig: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/Amount.php$40 [21:10:40] Specifically, the 'amount too large' and 'amount too small' errors should be formatted with values calculated during the validation [21:11:14] i.e. our min amount in the settings is in USD, and in the validation we convert that to the target currency [21:12:11] so we COULD just have the SmashPig validator return an 'amount-too-large' then the donationInterface code has to recalculate that maximum amount [21:12:32] or we could return some context array with named elements [21:17:05] (03PS3) 10Ejegg: Adyen Checkout: map error code 905 to submethod [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732803 (https://phabricator.wikimedia.org/T294032) [21:23:59] ejegg: ah cool thanks! [21:28:40] (03PS3) 10Ejegg: Adyen Checkout: message to try another card [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732804 (https://phabricator.wikimedia.org/T294032) [21:29:15] (03PS4) 10Ejegg: Adyen Checkout: message to try another card [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732804 (https://phabricator.wikimedia.org/T294032) [21:31:22] (03CR) 10jerkins-bot: [V: 04-1] Adyen Checkout: message to try another card [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732804 (https://phabricator.wikimedia.org/T294032) (owner: 10Ejegg) [21:44:37] ugh, what new problem is causing that V -1 ? [21:54:12] (03CR) 10Ejegg: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732804 (https://phabricator.wikimedia.org/T294032) (owner: 10Ejegg) [21:55:16] asking over in -releng [21:55:45] seems nearly identical to output of last run, up till the 'Publish JUnit test result report' step [22:00:08] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fr-matching-gifts: Track where we got employer information and export that to Acoustic - https://phabricator.wikimedia.org/T294488 (10KHaggard) Quickly adding a note: I'd discourage us from adding fields to Acoustic in the middle of the English Campai... [22:10:52] ejegg: I wanted to see what you thought made sense re the 'from email' & 'from name' config for outgoing emails [22:13:30] eileen: so just migrating from drupal vars to Civi settings seems like the simplest [22:13:42] status quo [22:13:42] - variables for the from name & email for eoy receipt [22:13:42] - separate variables for the same from 'thank you' [22:13:43] - Any emails sent from CiviCRM (including recurring failure) use the first default email from https://civicrm.wikimedia.org/civicrm/admin/options/from_email_address?reset=1 [22:14:17] right, I think they want to be able to have different from names & emails for the different types [22:14:24] They do? [22:15:26] I'm pretty sure that's why we added them [22:15:34] instead of just using the same as the TY mail [22:16:09] ok - it's the same values... [22:17:30] well, maybe we don't need them anymore then! [22:19:09] looking on the initial ticket for any clues: https://phabricator.wikimedia.org/T195907 [22:19:22] (03PS3) 10Eileen: Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 [22:20:06] ejegg: I worry a bit it 's one more bit of config that would not be reliably updated [22:20:22] ok, let's just use the regular TY email + from name then [22:21:48] ejegg: ok [22:22:13] (03CR) 10jerkins-bot: [V: 04-1] Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen) [22:22:48] the heck? [22:23:16] looks like it just didn't run any tests [22:23:19] ohhh [22:23:26] /src/wikimedia/fundraising/crm/bin/ci-populate-dbs.sh: line 28: [!-d: command not found [22:23:45] seems to be a problem in the setup script ^^^ [22:27:10] ejegg: I think that means they merged the PR that was removing their git clone of buildkit [22:29:28] so that file wouldn't be found now & it should enter the if [22:31:42] (03PS1) 10Eileen: Fix if command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736591 [22:32:21] (03PS2) 10Eileen: Fix if command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736591 [22:33:44] (03CR) 10jerkins-bot: [V: 04-1] Fix if command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736591 (owner: 10Eileen) [22:34:09] (03PS3) 10Eileen: Fix if command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736591 [22:38:22] (03PS4) 10Eileen: Fix if command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736591 [22:39:45] (03CR) 10jerkins-bot: [V: 04-1] Fix if command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736591 (owner: 10Eileen) [22:41:44] (03PS5) 10Eileen: Fix if command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736591 [22:45:41] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10fundraising sprint Universal Cereal Bus, 10fr-donorservices: Clean up new adyen ideal recurrings - https://phabricator.wikimedia.org/T291712 (10Cstone) This issue is resolved n... [22:52:26] ejegg: I have to go out for a bit but it looks like patch 5 is working ^^ [22:52:35] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/736591 [22:55:03] it passed - I'm gonna self+2 just to prevent others wasting time [22:55:34] (03CR) 10Eileen: [C: 03+2] "This unbreaks CI - am gonna self +2 so others don't wind up chasing this down" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736591 (owner: 10Eileen) [22:55:54] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen) [23:01:11] thanks eileen ! [23:01:19] sorry, have been distracted [23:01:33] will just update status to reflect that and change back when fully here