[00:38:02] (03CR) 10Cstone: "Looks good! Just a couple small things" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732107 (https://phabricator.wikimedia.org/T292271) (owner: 10Ejegg) [01:35:00] 10Wikimedia-Fundraising-Banners, 10Wikipedia-iOS-App-Backlog: 2021 English fundraising messages in iOS app - https://phabricator.wikimedia.org/T294996 (10spatton) [01:43:25] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog: 2021 English fundraising messages in Android app - https://phabricator.wikimedia.org/T294997 (10spatton) [01:51:48] eileen: are you around? [01:53:39] cstone: yep [01:54:41] im trying to override an email setting, could you do a quick call? or I can type it out [01:55:11] I'm in a cafe - but I could head home [01:55:22] nah its not that important haha [01:55:23] (I will be heading home soon anyway) [01:55:33] the CIVICRM_MAIL_LOG [01:55:37] i want that to not be defined [01:55:51] oh - it's defined in civicrm.settings.php then I assume [01:56:43] as far as I can tell the only place its defined is in builkits civicrm.settings.d/100-mail.php [01:56:58] so I was trying to make a local 100-mail but failing [01:59:11] actually I think it just worked so [01:59:14] nevermind :) [02:08:43] :-) [02:09:07] i can get mailcatcher to catch the new failed recurrings [02:09:12] but not the thank you emails [02:11:36] cstone: yeah - they don't go through civi..... [02:12:03] i thought i was getting them through testmeister page in the past [02:12:09] locally but could be remembering wrong [02:15:09] the testmeister page is the drupal send mechansism = not civi [02:15:17] the failed recurrings use civi [02:15:53] The problem with 'use civi' is the smtp balancing doesn't work there - so there is work to do to switch the higher volume ones over [02:16:18] ahh okay i wonder what I had done to get them to show up locally but maybe I'm remembering from vagrant times [02:17:19] cstone: so I was looking at the test mailer in the context of the end of year - we could make the drupal one do what civic does & have a 'redirect to database' option - they get written to the civicrm_mailing_spool table [02:18:50] I'm gonna relocate home now [02:20:02] (03PS2) 10Cstone: Add mailcatcher [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/713018 [02:35:58] home [02:37:12] I was just trying to get a base mailcatcher set up eileen which I think ^ does but right now it's only catching the new recurring fails [02:37:22] But they show up nicely [02:42:56] (03PS1) 10Eileen: Consolidate from to one variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736624 [02:43:10] cstone: well that is something :-) [02:43:46] I just put up so switch the end of year letters to use the same variable as the thank yous as discussed with ejegg|afk earlier [02:56:00] so cstone how do you see mailcatcher working? [02:56:52] Ah it's localhost:1080 I forgot to add that lemme update [02:56:57] If you didn't change the port [02:58:30] (03PS3) 10Cstone: Add mailcatcher [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/713018 [02:58:53] https://localhost:1080 isn't working [02:59:05] ah http [02:59:07] no s [03:00:21] ok - that works [03:02:21] so - it's possible to add those settings to that file where you commented out the log thing [03:03:01] although hmm - we probably want them as a default, not an override [03:04:06] ah okay the smtp settings? [03:07:19] yeah - but those are oddballs because it's an array [03:09:36] ah okay, I have to head out now but I can look more tomorrow [03:11:15] cstone: yeah I'm just testing [03:57:51] (03PS1) 10Eileen: Add mailcatcher defaults for dev site [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736625 [03:58:30] (03CR) 10Eileen: [V: 03+2 C: 03+2] "This works for me - with https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/736625 it works on new dev sites after running civib" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/713018 (owner: 10Cstone) [09:05:11] (03PS1) 10Damilare Adedoyin: WIP: Handle payment result on reject in validation phase [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736651 [09:07:11] Hi Fr-tech, I realised there was a difference between the way we handle the reject after running the filters in the Initial Phase and the Final Phase... [09:07:16] (03CR) 10jerkins-bot: [V: 04-1] WIP: Handle payment result on reject in validation phase [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736651 (owner: 10Damilare Adedoyin) [09:07:26] This is what we do in the initial phase: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/7382eba8a1579a0cddd03ee0fb2f23a01317e999/adyen_gateway/checkout/adyen_checkout.adapter.php#L22 [09:09:07] Here's what we do in the final phase: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/adyen_gateway/checkout/adyen_checkout.adapter.php$132 [09:10:01] Passing the new PaymentError object into the newFailure method in the final phase seem to solve the redirect issue [09:10:26] not sure if it's a complete solution, but might be worth looking into [11:49:48] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog: 2021 English fundraising messages in Android app - https://phabricator.wikimedia.org/T294997 (10Dbrant) p:05Triage→03Medium [11:49:55] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): 2021 English fundraising messages in Android app - https://phabricator.wikimedia.org/T294997 (10Dbrant) [13:32:14] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 5466 [13:37:14] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2142 [13:47:16] RECOVERY - check_mysql on frdb1002 is OK: Uptime: 1260465 Threads: 11 Questions: 79269707 Slow queries: 646 Opens: 352742756 Flush tables: 1 Open tables: 254 Queries per second avg: 62.889 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 406 [14:17:12] (03PS2) 10Jgleeson: WIP: Handle payment result on reject in validation phase [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736651 (owner: 10Damilare Adedoyin) [14:19:45] (03CR) 10jerkins-bot: [V: 04-1] WIP: Handle payment result on reject in validation phase [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736651 (owner: 10Damilare Adedoyin) [15:45:55] fr-tech all of the patches in DonationInterface are failing [15:46:21] it looks like releng upgraded the 'quibble' software that runs those tests to version 1.2.0 on Tuesday [15:46:41] I've been asking over in #wikimedia-releng if they know what to do [15:46:46] but no response so far [15:48:53] ok, hashar says he has a patch! [15:50:36] ah ok ejegg thanks for getting on top of that [15:50:46] (03CR) 10Hashar: "recheck after dropping Junit https://gerrit.wikimedia.org/r/c/integration/config/+/736812/" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736651 (owner: 10Damilare Adedoyin) [15:51:43] I did see a failure on dami's patch when rebasing for review earlier but assumed it was a code sniff thingy [15:53:56] (03CR) 10Ejegg: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732804 (https://phabricator.wikimedia.org/T294032) (owner: 10Ejegg) [18:07:52] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): 2021 English fundraising messages in Android app - https://phabricator.wikimedia.org/T294997 (10Sharvaniharan) a:03Sharvaniharan [18:55:34] (03PS5) 10Ejegg: Boilerplate updates in test loading [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736321 (owner: 10Eileen) [18:55:41] (03CR) 10Ejegg: [C: 03+2] Boilerplate updates in test loading [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736321 (owner: 10Eileen) [19:00:38] (03PS6) 10Ejegg: Switch logging to use Civi::log instead of watchdog [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736107 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [19:06:13] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736107 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [19:08:31] (03Merged) 10jenkins-bot: Boilerplate updates in test loading [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736321 (owner: 10Eileen) [19:17:21] ejegg: did the requirement of an isSuccessful() method on the CancelPaymentResponse feel weird to you? [19:17:35] looks like it's an abstract method on the base https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/648cc089f36102563e56ce7e1ed321d16fe95522/PaymentProviders/PaymentProviderResponse.php#L186 [19:17:52] jgleeson: oh hmm, did I put a comment on that? [19:18:13] I guess it seems plausible - you want to know if the cancelation actually went through [19:18:40] no comment https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/824b98c9cdeb9b155fc739d03b5b4663af3c1b7c/PaymentProviders/CancelPaymentResponse.php#L16 [19:18:45] hmm yeah [19:18:48] I guess [19:19:08] I was wondering if another name might work better across them but I can't think of that other name [19:19:25] isComplete() but that could mean something else [19:19:27] ->didItWork() [19:19:41] yeah, isComplete seems like it's asking about a specific status [19:20:01] doesItMakeCoffee() [19:20:22] hmm I'll leave it alone [19:20:28] heh, no, for that you use instanceof IMakeCoffee [19:20:32] ha! [19:21:27] (03Merged) 10jenkins-bot: Switch logging to use Civi::log instead of watchdog [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736107 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [19:26:55] (03PS9) 10Eileen: Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) [19:27:04] (03PS3) 10Eileen: Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) [19:27:36] (03CR) 10jerkins-bot: [V: 04-1] Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [19:41:41] (03PS1) 10Jgleeson: WIP: standardise cancelPayment behaviour [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736874 (https://phabricator.wikimedia.org/T291223) [19:42:30] (03CR) 10jerkins-bot: [V: 04-1] WIP: standardise cancelPayment behaviour [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736874 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [19:51:54] fr-tech I've got a merge request for dev-images here: https://gitlab.wikimedia.org/releng/dev-images/-/merge_requests/10 [19:52:29] just turns off ssl for the SmashPig IPN listener as we'll now be running that via the proxy [19:52:42] oh hey, I should actually build that locally.... [19:52:48] (03PS1) 10Jgleeson: WIP: update cancelPayment response handling [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) [19:53:12] ahh I wonder if gitlab will let me in now [19:53:55] (03PS2) 10Jgleeson: WIP: update cancelPayment response handling for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) [19:55:48] (03CR) 10jerkins-bot: [V: 04-1] WIP: update cancelPayment response handling for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [19:55:54] looks like my patches are in a bit of a rebase mess - if I can get this merged I think it will be easier to manage since it moves stuff around https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/736120/ [19:56:05] looking eileen [19:56:45] cstone: did you see https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/736625 works with your mailcatcher [19:58:20] damilare|brb: btw if session bug task doesn't have a ticket, I'd say it's definitely ticket worthy. [19:58:48] nice eileen ! [19:59:12] jgleeson: looks like the buildkit change was merged yesterday [20:01:31] yeah eileen, jeena over in releng pushed that out for us [20:01:46] ejegg: mentioned we broke something related? [20:02:20] jgleeson: there was just a tiny syntax error in the db setup script [20:02:31] that was only hit after they stopped cloning buildkit for us [20:02:58] cool cool [20:04:13] have a good night all, bye for now! [20:04:13] jgleeson: yeah - it was a short-lived break [20:23:02] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10MW-1.38-notes (1.38.0-wmf.7; 2021-11-02): Declines due to API settings - https://phabricator.wikimedia.org/T294059 (10EMartin) @ejegg, could I kindly get a copy of the API call to have... [21:04:16] (03CR) 10Ejegg: "Thank you for thinking about all of this! Let's make sure we have a plan for a ValidationError refactor that will work for all of our vari" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736110 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [21:07:49] (03PS1) 10Eileen: Remove obsolete upgrade command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736887 [21:08:19] (03CR) 10Ejegg: "Thank you for thinking about all of this! I agree that ExceptionMapper might be the wrong place for the non-Exception codes to live. Let's" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736109 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [21:24:31] (03CR) 10Ejegg: [C: 03+2] Apple Pay: Throw exception if details status normalizer requested [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736297 (https://phabricator.wikimedia.org/T294721) (owner: 10AndyRussG) [21:25:09] (03Merged) 10jenkins-bot: Apple Pay: Throw exception if details status normalizer requested [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736297 (https://phabricator.wikimedia.org/T294721) (owner: 10AndyRussG) [21:28:55] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-Tech-Analytics: Low Traffic Test Difference in impressions between event_sanitized.centralnoticebannerhistory and pgehres.bannerimpressions - https://phabricator.wikimedia.org/T294145... [21:31:58] fr-tech I'm going to modify our DI refactoring epic (https://phabricator.wikimedia.org/T291697) to include SP, too, since many refactors would involve both codebases, and several subtasks there already mention SP, sound good? [21:34:18] also ejegg eileen cstone XenoRyet anyone else around from fr-tech, I'm thinking that in order to have space for everyone to talk about the doc task, maybe we need two meetings? so I was thinking maybe we could to a brief (20-30 min max) video call later today, and then still also continue talking about it on Monday after backlog refinement, as planned... what do u think? [21:34:46] that way we don't miss cstone being able to participate at least in one meeting [21:34:56] i'm fine with those meetings AndyRussG [21:35:16] ejegg oki so does that mean yes to a video call today? [21:35:24] yep [21:35:30] ah fantastic thx [21:36:55] I was gonna say, the only hard blocked-out time I have when I couldn't make it is from about 15:45-16:25 Pacific Time / 22:45-23:25 UTC, when I have to go pick up Ceci from her drawing class [21:37:28] ejegg do you have specific preferences for when would work well for you this afternoon/evening? [21:37:56] Im free until 2 hours from now [21:38:33] that works for me too cstone [21:38:58] Er I should say I have a hard stop 2 hours from now [21:39:23] ah yeah, within the next two hours would be good for me too [21:39:40] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Epic: [Epic] Architecture, separation of concerns and refactors in DonationInterface and SmashPig (2021) - https://phabricator.wikimedia.org/T291697 (10AndyRussG) [21:39:52] (03CR) 10Ejegg: [C: 03+2] "Looks good! One edge case noted inline but could be handled later." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [21:40:38] ejegg cstone ah cool, how about in 20 minutes or so? [21:40:46] That works [21:41:14] cool! I'll throw one on the calendar, and we can record too, no? [21:41:19] eileen: ^ ? [21:42:53] ok - I should be good for that [21:44:00] eileen: ah fantastic :) [21:47:38] dwisehaupt: also if you're interested ^ [21:53:29] (03Merged) 10jenkins-bot: Move code to generate letters job to EOYEmail.MakeJob api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736120 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [22:06:44] (03PS5) 10Eileen: Start to decouple the render function from send-once [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736298 (https://phabricator.wikimedia.org/T290253) [22:13:27] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Amber Johnson - https://phabricator.wikimedia.org/T293679 (10AMJohnson) A quick meeting would be great as I'm a bit confused on the configuration part. I've just sent you a proposed calendar invite. Feel free to p... [22:33:23] 10Fundraising-Backlog: Optimization of Apple Pay Flow - https://phabricator.wikimedia.org/T295092 (10EMartin) [22:35:33] (03PS7) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [22:35:39] (03PS4) 10Eileen: Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 [22:47:11] (03CR) 10jerkins-bot: [V: 04-1] Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen) [22:55:25] ejegg: fyi I think this addresses your edge case https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/736298 [23:16:39] (03PS4) 10Eileen: Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) [23:29:19] (03CR) 10jerkins-bot: [V: 04-1] Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [23:30:01] 10Fundraising-Backlog: Optimization of Apple Pay Flow - https://phabricator.wikimedia.org/T295092 (10Ejegg) 1) we can't do Apple Pay payments on donate.mediawiki.org because it's hosted outside of our PCI cluster and doing payments would need our Adyen credentials and our private Apple Pay merchant cert. Is the... [23:34:28] (03PS5) 10Eileen: Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 [23:38:47] 10Fundraising-Backlog: Optimization of Apple Pay Flow - https://phabricator.wikimedia.org/T295092 (10EMartin) {F34730595{F34730597{F34730598} [23:45:41] (03CR) 10jerkins-bot: [V: 04-1] Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen)