[00:00:30] 10Fundraising-Backlog, 10Desktop Improvements, 10MediaWiki-extensions-CentralNotice, 10Product-Design-Strategy, and 6 others: [Discussion] Prevent SEO decline due to Google "page experience": mid-June 2021 - https://phabricator.wikimedia.org/T280476 (10Jdlrobson) [00:01:35] 10Fundraising-Backlog, 10Wikimedia-Fundraising-Banners, 10Desktop Improvements, 10Wikimedia-CentralNotice-Administration, 10Design: Study options and designs for banner formats to prevent search ranking decline - https://phabricator.wikimedia.org/T280477 (10Jdlrobson) [00:03:07] (03PS6) 10Eileen: Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 [00:14:29] (03CR) 10jerkins-bot: [V: 04-1] Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen) [00:19:24] (03PS7) 10Eileen: Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 [00:30:09] (03CR) 10jerkins-bot: [V: 04-1] Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen) [00:37:23] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen) [01:00:23] (03PS1) 10Eileen: Fix mis-named variable reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736935 [01:14:12] (03PS1) 10Eileen: Fix tests to reset statics in tearDown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736937 [01:16:56] ejegg: I'm having a battle with the tests - if I can get these 2 merged it might help - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/736937/1 [01:28:25] or cstone or AndyRussG ^^ [01:45:10] sorry eileen, had to help with the baby [01:45:19] turned out to be a real struggle to get her to sleep [01:45:28] no worries ejegg - that is .... normal [01:45:48] think she's asleep for real this time though, so I'm back at the keyboard [01:47:05] (03PS2) 10Ejegg: Fix mis-named variable reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736935 (owner: 10Eileen) [01:47:38] (03CR) 10Ejegg: [C: 03+2] "phew, it'll be nice to get that module ported to sane civi code!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736935 (owner: 10Eileen) [01:49:28] (03PS2) 10Ejegg: Fix tests to reset statics in tearDown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736937 (owner: 10Eileen) [01:49:32] (03CR) 10Ejegg: [C: 03+2] Fix tests to reset statics in tearDown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736937 (owner: 10Eileen) [01:56:23] sometimes they're teenagers and it's still a struggle to get them to go to sleep heh [01:56:35] (though also not the same of course) [01:59:18] (03Merged) 10jenkins-bot: Fix mis-named variable reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736935 (owner: 10Eileen) [02:00:15] (03Merged) 10jenkins-bot: Fix tests to reset statics in tearDown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736937 (owner: 10Eileen) [02:03:56] (03CR) 10Ejegg: "Looks like a clean move! Could delete a few chunks due to simplified contact cleanup" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [02:05:18] ejegg: yeah good point - I'll look into ripping those out as a follow up [02:05:38] k, I can +2 as is so as not to require more rebases [02:05:49] cool [02:06:08] also - miraculously this one is not yet in conflict https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/736624 - even though it is directly on master! [02:06:47] oh hah, it will conflict with moving the tests though! [02:07:14] probably we should merge the test move first, right? [02:07:46] or... however you prefer [02:14:46] eileen: any preference on the merge order? [02:15:03] ejegg: hmm - do the tests one first [02:15:09] cool, will do [02:15:24] and this one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/736887 [02:15:33] & then I'll re-do the other one [02:16:31] (03PS6) 10Ejegg: Start to decouple the render function from send-once [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736298 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [02:17:10] (03CR) 10Ejegg: [C: 03+2] "Looks good, makes this action work for batches" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736298 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [02:17:14] fr-tech is this the most urgent patch on the payments side? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/732107 [02:17:24] (03PS8) 10Ejegg: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [02:17:26] I just see a couple inline comments from cstone [02:17:39] AndyRussG: ah right, I was going to respond to those [02:18:01] yep, valid comments [02:18:26] one sec [02:18:33] oki thanks! [02:18:43] (03CR) 10Ejegg: [C: 03+2] Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [02:18:53] I have a bit of time to look at stuff before I have to go pick up Sofi from her boyfriend's place... [02:22:24] (03PS2) 10Ejegg: Remove obsolete upgrade command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736887 (owner: 10Eileen) [02:22:30] (03CR) 10Ejegg: [C: 03+2] Remove obsolete upgrade command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736887 (owner: 10Eileen) [02:27:53] (03CR) 10jerkins-bot: [V: 04-1] Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [02:28:02] (03Merged) 10jenkins-bot: Start to decouple the render function from send-once [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736298 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [02:28:03] durn [02:30:07] (03CR) 10jerkins-bot: [V: 04-1] Remove obsolete upgrade command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736887 (owner: 10Eileen) [02:30:45] (03PS3) 10Ejegg: Adyen: send donor contact info for more methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732107 (https://phabricator.wikimedia.org/T292271) [02:31:16] (03CR) 10Ejegg: "Thanks for the CR cstone!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732107 (https://phabricator.wikimedia.org/T292271) (owner: 10Ejegg) [02:32:20] oh man eileen, that's a hairy looking test fail [02:32:45] or rather hairy looking fatal error after tests pass [02:32:54] 22:27:47 PHP Fatal error: Uncaught RuntimeException: Stream is detached in /src/wikimedia/fundraising/crm/civicrm/vendor/guzzlehttp/psr7/src/Stream.php:89 [02:33:35] ejegg: argh - that happens if an https request is added - dang [02:34:03] (03PS3) 10Eileen: Remove obsolete upgrade command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736887 [02:34:30] I saw it surface on one of the others - I thought the large_donation fixes would help - but... [02:36:43] AndyRussG: that patch is ready for review again [02:37:29] shoot, i need to sleep [02:37:34] good night all [02:37:39] ejegg: thx! good night! :) [02:37:56] good luck to you and Octavia and her mom with baby sleep! [02:46:50] (03PS2) 10Eileen: Consolidate from to one variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736624 [02:50:39] (03PS9) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [03:02:22] (03CR) 10jerkins-bot: [V: 04-1] Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [04:28:05] (03PS3) 10Eileen: Consolidate from to one variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736624 [04:28:07] (03PS10) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [04:28:09] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736942 [04:36:23] (03CR) 10jerkins-bot: [V: 04-1] Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736942 (owner: 10Eileen) [04:38:20] (03PS2) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736942 [04:44:02] (03PS11) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [04:45:04] (03PS1) 10Eileen: Improve setting of active mailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736943 [04:47:33] (03CR) 10jerkins-bot: [V: 04-1] Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736942 (owner: 10Eileen) [04:52:01] (03PS8) 10Eileen: Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 [04:52:19] (03PS3) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736942 [04:55:03] (03CR) 10jerkins-bot: [V: 04-1] Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [05:01:56] (03CR) 10jerkins-bot: [V: 04-1] Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736942 (owner: 10Eileen) [05:03:47] (03CR) 10jerkins-bot: [V: 04-1] Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen) [05:49:42] (03PS5) 10Eileen: Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) [05:56:43] (03PS4) 10Eileen: Consolidate from to one variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736624 [05:56:45] (03PS2) 10Eileen: Improve setting of active mailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736943 [05:56:47] (03PS12) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [06:07:53] (03CR) 10jerkins-bot: [V: 04-1] Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [08:26:38] 10Fundraising-Backlog, 10MediaWiki-extensions-CLDR, 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_35-php73-docker is failing - https://phabricator.wikimedia.org/T295114 (10Nikerabbit) [08:27:08] 10Fundraising-Backlog, 10MediaWiki-extensions-CLDR, 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_35-php73-docker is failing - https://phabricator.wikimedia.org/T295114 (10Nikerabbit) Patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/cldr/+/736895 [14:04:37] 10Fundraising-Backlog: Payment session lost causing error page throwing exception - https://phabricator.wikimedia.org/T295149 (10Damilare) [14:05:14] 10Fundraising-Backlog: Payment session lost causing error page throwing exception - https://phabricator.wikimedia.org/T295149 (10Damilare) [14:14:36] 10Fundraising-Backlog: Payment session lost causing error page throwing exception - https://phabricator.wikimedia.org/T295149 (10Damilare) [14:26:29] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Screaming Goats Yelling Zoo, 10fundraising sprint Universal Cereal Bus, 10fr-donorservices: Clean up new adyen ideal recurrings - https://phabricator.wikimedia.org/T291712 (10MBeat33) Thank you! I will follo... [16:10:36] 10Fundraising-Backlog, 10MediaWiki-extensions-CLDR, 10Continuous-Integration-Config, 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_35-php73-docker is failing - https://phabricator.wikimedia.org/T295114 (10Reedy) >But it looks like a mistake that this job is run for the master... [16:44:09] 10Fundraising-Backlog: Deployment of Donation Interface Translations - https://phabricator.wikimedia.org/T295172 (10HNordeenWMF) [17:22:54] 10Fundraising-Backlog, 10MediaWiki-extensions-CLDR, 10Continuous-Integration-Config, 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_35-php73-docker is failing - https://phabricator.wikimedia.org/T295114 (10Umherirrender) The job is using quibble and also affected by T295036 Th... [17:28:40] 10Fundraising-Backlog, 10MediaWiki-extensions-CLDR, 10Continuous-Integration-Config, 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_35-php73-docker is failing - https://phabricator.wikimedia.org/T295114 (10Umherirrender) First failing: https://integration.wikimedia.org/ci/job/q... [17:41:53] fr-tech the bitcoin stuff took way longer (verifying all kinds of magic) than expected so I didn't get to anything else that I mentioned on standup. gonna hop off now but have a good weekend and see you all monday! [17:42:14] apart from cstone [17:42:18] see you NEXT monday [17:42:19] :) [17:42:54] cya! [17:44:30] :) [18:42:54] PROBLEM - Host frlog1001 is DOWN: PING CRITICAL - Packet loss = 100% [18:43:18] RECOVERY - Host frlog1001 is UP: PING OK - Packet loss = 0%, RTA = 3.20 ms [20:15:58] (03PS13) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [20:16:00] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737121 [20:16:49] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737122 [20:18:07] (03PS1) 10Eileen: do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737123 [20:27:12] (03CR) 10jerkins-bot: [V: 04-1] Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [20:29:43] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737124 [20:48:50] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737127 [21:01:44] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737129 [21:14:37] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737131 [21:27:01] (03CR) 10jerkins-bot: [V: 04-1] Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737131 (owner: 10Eileen) [21:39:29] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737137 [21:49:39] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737139 [21:59:02] (03CR) 10jerkins-bot: [V: 04-1] Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737139 (owner: 10Eileen) [22:12:24] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737140 [22:22:45] (03PS1) 10Eileen: do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737141 [22:33:43] (03CR) 10jerkins-bot: [V: 04-1] do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737141 (owner: 10Eileen) [22:35:34] (03PS1) 10Eileen: do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737146 [22:59:09] (03PS1) 10Eileen: do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737148 [23:12:29] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737152 [23:22:58] (03CR) 10jerkins-bot: [V: 04-1] Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737152 (owner: 10Eileen) [23:48:59] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737155 [23:59:06] (03CR) 10jerkins-bot: [V: 04-1] Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737155 (owner: 10Eileen)