[00:08:58] (03PS17) 10Eileen: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) [00:16:12] (03CR) 10Ejegg: [C: 03+2] "Oops, didn't mean to tease. Here's the C+2" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736943 (owner: 10Eileen) [00:29:16] (03Merged) 10jenkins-bot: Improve setting of active mailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736943 (owner: 10Eileen) [00:57:10] (03PS18) 10Ejegg: Move tests into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [01:23:08] ejegg: are you able to merge this too - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/736333/9 - then I'll have a clean slate [01:23:57] ok, it's a bit less 'unit' than the previous test, but I guess the idea is to change the way things are stored in the intermediate step? [01:24:20] i.e. it depends on the calculate fn not under test [01:24:50] right, I guess this test changes again when the calculate function changes [01:25:03] but it will definitely not have that intermediate data format [01:26:08] ejegg: yeah - it seems silly to enforce a parameter that would otherwise be calculated within the function [01:26:39] k, lemme just try to get my own test working and I'll switch back to your stuffs [01:26:45] I think the 'unit' part makes most sense when the parameters are really sensible [02:09:36] (03PS3) 10Ejegg: Add custom field for relationship source [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737802 (https://phabricator.wikimedia.org/T294488) [02:29:23] (03PS10) 10Ejegg: Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen) [02:30:48] (03CR) 10Ejegg: [C: 03+2] "Less unit-y, but Eileen's convinced me it's for a good reason. Sorry about that excessive list of contributions in the test!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen) [02:33:54] (03PS4) 10Ejegg: Add custom field for relationship source [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737802 (https://phabricator.wikimedia.org/T294488) [02:33:56] (03PS1) 10Ejegg: Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) [02:34:06] eileen: ^^^ seems to work locally! [02:34:46] thanks again for all the help during that call [02:42:32] (03Merged) 10jenkins-bot: Switch tests to use real contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736333 (owner: 10Eileen) [02:45:08] (03CR) 10jerkins-bot: [V: 04-1] Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [03:09:49] ah, need to check for dupes [03:09:53] well, will do that tomorrow [03:15:13] 10Fundraising Sprint V 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Universal Cereal Bus, and 2 others: Track where we got employer information and export that to Acoustic - https://phabricator.wikimedia.org/T294488 (10Ejegg) a:03Ejegg [03:16:35] 10Fundraising Sprint V 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Universal Cereal Bus, and 2 others: Track where we got employer information and export that to Acoustic - https://phabricator.wikimedia.org/T294488 (10Ejegg) We're going ahead with the attempt to use a... [05:26:22] (03PS6) 10Eileen: Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) [05:31:00] (03PS7) 10Eileen: Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) [05:31:02] (03PS1) 10Eileen: Throw exception before trying to render rather than in render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737829 (https://phabricator.wikimedia.org/T290253) [05:42:29] (03CR) 10jerkins-bot: [V: 04-1] Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [05:43:19] (03CR) 10jerkins-bot: [V: 04-1] Throw exception before trying to render rather than in render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737829 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [06:08:41] (03PS1) 10Eileen: Move rendering into the render function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) [06:19:35] (03CR) 10jerkins-bot: [V: 04-1] Move rendering into the render function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [09:11:06] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Plan "Engagemangstrappa" for volunteers via Street fundraising - https://phabricator.wikimedia.org/T256350 (10Eric_Luth_WMSE) [09:12:37] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Add info for companies wanting to donate money - https://phabricator.wikimedia.org/T187172 (10Eric_Luth_WMSE) [09:40:05] (03PS8) 10Eileen: Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) [09:40:07] (03PS1) 10Eileen: Further test function fix to use better data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737855 [10:03:55] (03PS2) 10Eileen: Throw exception before trying to render rather than in render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737829 (https://phabricator.wikimedia.org/T290253) [10:03:57] (03PS2) 10Eileen: Move rendering into the render function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) [10:15:24] (03CR) 10jerkins-bot: [V: 04-1] Move rendering into the render function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [15:53:53] damilare: I'm back. wanna continue where we left off? [15:55:03] AndyRussG: I thought this was a great article btw https://www.infoworld.com/article/3639050/complexity-is-killing-software-developers.html?page=2 [15:56:08] jgleeson: yeah I agree! also helps us see that our struggles are not unique, eh! [15:57:13] indeed [15:59:56] ohh brb jgleeson, want to quickly get lunch and dinner... be back in ~15mins [16:01:50] np damilare|brb. I'm heading out at 4:45 PM UTC to take Oscar to his class but we can catch up afterwards also [16:17:26] jgleeson: I'm back, are you available for the call? [16:22:12] (03CR) 10Jgleeson: "Thanks! This works great. After applying the update and running `drush ucf` I can see 'Provided by donor' Relationship metadata radio butt" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737802 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [17:06:49] (03PS5) 10Ejegg: Add custom field for relationship source [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737802 (https://phabricator.wikimedia.org/T294488) [17:06:51] (03PS2) 10Ejegg: Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) [17:07:25] (03CR) 10Ejegg: "Thanks for the review Jgleeson. I've gone and expanded that comment." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737802 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [17:19:38] (03CR) 10jerkins-bot: [V: 04-1] Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [17:51:15] 10fundraising-tech-ops: upgrade fundraising Superset instance to 1.3.1+ - https://phabricator.wikimedia.org/T292294 (10Jgreen) 05In progress→03Resolved Done! [18:01:15] 10fundraising-tech-ops: Investigate modifying icinga alert emails to include the URL to ack the alert - https://phabricator.wikimedia.org/T295383 (10Jgreen) Apparently you can use notes_url set the service definition, something to this effect: notes_url https://icinga.wikimedia.org/cgi-bin/icinga/extinf... [18:03:21] argh, there's lots of gnarly handling for this employer id in the Contact BAO class [18:04:09] starting to think I don't want to create the relationship in a separate API call [19:44:46] (03PS3) 10Eileen: Move rendering into the render function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) [19:58:39] (03CR) 10jerkins-bot: [V: 04-1] Move rendering into the render function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [20:02:34] (03PS3) 10Ejegg: Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) [20:13:42] (03CR) 10jerkins-bot: [V: 04-1] Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [20:57:59] (03CR) 10Jgleeson: [C: 03+2] Add custom field for relationship source [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737802 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [21:11:55] (03Merged) 10jenkins-bot: Add custom field for relationship source [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737802 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [21:37:13] (03PS4) 10Ejegg: Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) [21:44:18] 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10MediaWiki-extensions-DonationInterface: Deployment of Donation Interface Translations - https://phabricator.wikimedia.org/T295172 (10HNordeenWMF) @Ejegg, they went through it looks perfect! Thank you :) [21:50:33] (03CR) 10Ejegg: "Note: this seems to work in smoke testing. The name now shows up under the Shopper Details section on the merchant console payment page: h" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737537 (https://phabricator.wikimedia.org/T295409) (owner: 10Ejegg) [22:04:27] (03PS5) 10Ejegg: Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) [22:15:47] XenoRyet: OK, that page is now JSON [22:15:53] I updated the link in that gdoc as well [22:16:04] Good times, thanks [22:58:56] (03PS1) 10Ejegg: Only export employer data supplied by donors [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) [23:00:30] (03CR) 10jerkins-bot: [V: 04-1] Only export employer data supplied by donors [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [23:01:25] (03PS2) 10Ejegg: Only export employer data supplied by donors [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) [23:03:49] (03CR) 10jerkins-bot: [V: 04-1] Only export employer data supplied by donors [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [23:07:16] (03PS3) 10Ejegg: Only export employer data supplied by donors [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) [23:09:01] (03CR) 10jerkins-bot: [V: 04-1] Only export employer data supplied by donors [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [23:10:12] guh [23:10:34] assertionerror would be a lot more helpful if it spit out the actual value [23:28:14] (03PS4) 10Eileen: Move rendering into the render function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) [23:30:23] (03PS5) 10Eileen: Move rendering into the render function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) [23:52:28] ejegg: is your relationship patch review-ready now? [23:52:38] eileen: the CRM one is [23:52:46] the tools one is still not passing tests [23:52:46] as in this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/737821/5/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/Action/WMFContact/Save.php [23:52:55] opps that is the file but still [23:52:57] yeah, that one is readdy for comments [23:53:02] ok I'll look [23:53:08] thanks! [23:53:21] I managed to get the patch chain on eoy passing to the point where it moves to the render [23:53:50] next step is to really hone in on that render so it would be good to get the chain merged first (in case of rework requirements) [23:54:23] Your patch looks clean - will test [23:54:56] I'm guessing the tools one is our painful test-harness missing the field [23:57:00] hmm, i updated the minimal_schema, it might be the actually logic gone bad [23:57:25] locally I get a failure on the test where it tries to run the prepared statement to create the view, so that's annoying [23:57:33] gotta step out for a bit