[01:04:24] am I back in? [01:04:33] looks like it [01:45:15] (03CR) 10Eileen: "ejegg I found a gotcha!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [01:45:59] (03CR) 10Eileen: [C: 04-1] "I think it's worth adding a -1 so the gotcha in my last comment doesn't get missed" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [02:01:12] thanks eileen, looking [02:02:48] hmm eileen so you think we have to go back to creating the relationship ourselves [02:02:51] ? [02:03:05] ejegg: yeah - I think we might have to [02:03:43] it's only the organization_name we have to be extra careful of if we do + checking if exists [02:03:54] ok, I guess there's a little handling around whether it's current - so we have to get all the existing 'employee of' relationships [02:04:19] and when they don't match the one we're setting, just set is_active to 0? [02:04:53] then when they DO match the employer_id we're setting, we set is_active to 1 and set the custom field [02:05:23] ah, and also look up the org contact's display_name to set the organization_name? [02:05:57] or would it be the org contact's organization_name? [02:06:26] so individual contact's organization_name === the display name of the org [02:06:56] I think we only need to look up active relationships [02:07:03] ok, right [02:07:27] if they have an inactive relationship with the former employer it might be legitimately a different relationship (e.g a gap in employment) [02:07:27] well, or inactive ones that match the existing employer_id [02:07:35] ohhh [02:07:46] so that won't throw a duplicate relationship problem? [02:08:07] well, i'll try [02:08:17] i should add a couple more test cases too [02:08:32] i.e. inactive relationship with same employer [02:09:13] Yeah - I didn't exactly write a test to test it - in that I butchered the existing one - but it failed on the check on the count of relationships [02:10:00] ejegg: in other news - are you ok with merging any of these https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/737855 - I'm a bit nervous to do the next chunk of work in case I find that chain needs changing [02:11:07] ok, i'll do some review before I dive back into the employer patch [02:13:06] thanks! [02:39:02] so far mostly looks good, just wondering what happened to the job_id option in that last patch [02:39:25] pulling down locally for a better understanding [02:42:12] (03CR) 10Eileen: "This test is passing for me locally - it's the new test that is failing - so there is not exactly one relationship found I guess but I can" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [02:44:41] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/738048 [02:45:06] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/738048 (owner: 10Eileen) [02:52:37] !log civicrm revision 7e38867f -> 817e514a (latest) [02:52:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:53:40] ejegg: I just deployed the new field - since we needed to remember to run that drush command before you current patch [02:56:59] thanks! [02:59:25] (03CR) 10Ejegg: Move rendering into the render function (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [02:59:31] (03CR) 10Ejegg: [C: 03+2] Further test function fix to use better data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737855 (owner: 10Eileen) [03:01:18] (03CR) 10Ejegg: [C: 03+2] Throw exception before trying to render rather than in render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737829 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [03:03:55] (03PS6) 10Eileen: Move rendering into the render function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) [03:04:21] (03CR) 10Eileen: "I re-instated it - it wasn't intentially removed at this stage" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [03:10:37] (03Merged) 10jenkins-bot: Further test function fix to use better data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737855 (owner: 10Eileen) [03:12:38] ejegg: are you still looking at the second one (you approved the 3rd one but it's not merging due to the second one) [03:13:47] ah right, I was looking ahead to see where that double lookup becomes necessary [03:14:01] but I guess it's not in anything that's up for CR yet [03:14:11] i trust you know where you're going with this though [03:19:42] ejegg: yeah - I hope to get rid of it again - but if I don't get there I don't forsee any meaningful real world impact [03:22:00] 10Fundraising-Backlog: Emoji breaks damaged messages - https://phabricator.wikimedia.org/T277240 (10Ejegg) oh hmm, probably the damaged table on the smashpig database needs to be converted [03:22:32] (03CR) 10Ejegg: [C: 03+2] Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [03:27:06] (03PS1) 10Ejegg: Create pending + damaged tables as utf8mb4 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/738050 (https://phabricator.wikimedia.org/T277240) [03:31:18] (03CR) 10Eileen: [C: 03+2] Create pending + damaged tables as utf8mb4 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/738050 (https://phabricator.wikimedia.org/T277240) (owner: 10Ejegg) [03:31:45] ejegg: I gave that +2 - but I'm not sure your plan to update on live? [03:31:49] (03Merged) 10jenkins-bot: Create pending + damaged tables as utf8mb4 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/738050 (https://phabricator.wikimedia.org/T277240) (owner: 10Ejegg) [03:32:15] eileen: yeah, I need to ask ops about that [03:32:20] ok [03:33:00] & you saw I responded to your comment on that last patch (you were right) [03:33:03] looks like we may be out of maintenance windows for the year though [03:33:21] ah yep, i just got distracted by something else [03:34:14] (03Merged) 10jenkins-bot: Move functions to support rendering into render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736299 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [03:34:16] (03Merged) 10jenkins-bot: Throw exception before trying to render rather than in render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737829 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [03:35:35] 10Fundraising-Backlog, 10Patch-For-Review: Emoji breaks damaged messages - https://phabricator.wikimedia.org/T277240 (10Ejegg) @Dwisehaupt @Jgreen could we alter the smashpig.damaged and smashpig.pending tables to support mb4 in the first maintenance window of the new year? [03:46:18] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Figure out a process to set up our logging on people's dev installs. - https://phabricator.wikimedia.org/T131232 (10Ejegg) @Eileenmcnaughton I think we can close this, right? Current docker setup seems to have all the CRM logging we have on production [03:46:42] ejegg: what do you mean on the year? [03:46:56] on the year? [03:47:40] "looks like we may be out of maintenance windows for the year though" [03:47:43] oh, for maintenance windows - just that we probs can't change those smashpig tables over to mb4 in prod before January [03:48:05] oh - lol - there is a year variable in that patch & I was looking at it going 'huh' [03:49:36] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Epic: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704 (10Eileenmcnaughton) [03:49:39] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Figure out a process to set up our logging on people's dev installs. - https://phabricator.wikimedia.org/T131232 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton yeah - early 2016 was another country [03:50:11] thanks :) Just trying to flag opportunities for phab cleanup [03:52:51] 10Fundraising-Backlog: 'X-Frame-Options' iframe error when testing monthly convert locally - https://phabricator.wikimedia.org/T236185 (10Ejegg) Hmm, I thought this line was supposed to be unsetting that: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/ResultSwitcher.php$44 [03:52:55] ejegg: yeah I think there must be a few.... [03:56:27] 10Fundraising-Backlog, 10Wikimedia-Fundraising, 10MediaWiki-extensions-FundraiserLandingPage, 10donate.wikimedia.org, and 2 others: "PHP Warning: preg_match() expects parameter 2 to be string" from Special:FundraiserLandingPage - https://phabricator.wikimedia.org/T226456 (10Ejegg) 05Open→03Resolved a:... [04:03:10] eileen: sorry, I gotta head to bed. Will take one more crack at running that last patch locally tomorrow morning [04:03:20] night [15:47:53] hi damilare I'd hoped to jump right back in on our call but I'd forgotten that Oscar has his friend around for tea so I just need to run an errand to pick up some food and then when i get back I'll ping you! catch you soon [15:52:17] jgleeson: sure, I have to step off for a short whiile to run an errand. Brb too [16:56:35] damilare: I was about to reach out to someone to get access to the ingenico payments console as my account has timed out but realised it's a holiday in the US today so gonna be pretty quiet from folks in the US, namely Evelyn [16:57:10] true, guess we'd have to wait till tomorrow [16:59:34] hey AndyRussG: are you working today? just wondering if you're able to get into the ingenico production payments console here https://wpc.gcsip.com/wpc/login and refresh expired accounts? [16:59:49] I feel like cstone may have done that before [17:00:10] jgleeson: I think I can get it [17:00:12] *in [17:00:39] hi ejegg! is this one of the consoles that other folks can reinstate access to expired accounts? [17:01:02] the ingenico payment console [17:01:14] Hey jgleeson fr-tech... Yep I'm around, lemme check too [17:01:35] be a minute to standup! [17:03:47] jgleeson: joining standup? [17:03:57] ohh ok [19:22:27] AndyRussG: damilare I think I've found a good UML tool here https://plantuml.com/. It's free to use also [19:27:46] jgleeson: I like the docs on there. Thanks for sharing [19:34:20] np! [19:41:10] oh looks great jgleeson! [19:49:47] jgleeson damilare found the source code for that btw https://github.com/plantuml/plantuml [19:50:01] also https://en.wikipedia.org/wiki/PlantUML [19:52:04] ah also has an eclipse plug-in! [19:54:18] nice! [19:54:27] Thanks jgleeson and AndyRussG. Yh, I'm checking out the plugin on vscode [20:41:12] calling it a night. bye for now fr-tech! [21:09:04] XenoRyet: I didn't brief you on that email from Parvez - occassionally we get requests like that when bigger organisations are thinking about adopting CiviCRM - David normally does a call with them if he can [21:14:20] 10Fundraising Sprint V 2021, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-AutoTY-Email, and 2 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10CDenes_WMF) Hi @Ejegg ! I have a last minute edit to reques... [23:21:09] 10Fundraising Sprint V 2021, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-AutoTY-Email, and 2 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10Eileenmcnaughton) @CDenes_WMF no worries - you'll be able t... [23:21:25] ejegg: I'm gonna start on the follow on patches to this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/737833 shortly - did you think there were gonna be changes I need to make in it? [23:32:58] 10Fundraising Sprint V 2021, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-AutoTY-Email, and 2 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10CDenes_WMF) Awesome, thank you! [23:39:38] (03PS1) 10Eileen: Move message templates into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/738285