[02:09:27] (03PS1) 10AndyRussG: Forwarding script tunnels IPN listeners, can use autossh [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/738598 [02:24:16] (03CR) 10AndyRussG: "Ahhh this is great, thanks so much!! :) Pls see Ie6192fcf6 for a patch that takes this one step further... :)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731856 (owner: 10Ejegg) [14:54:39] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10netops: Upgrade pfw to Junos 20+ - https://phabricator.wikimedia.org/T295691 (10ayounsi) p:05Triage→03Low [15:51:04] 10Fundraising-Backlog: Apple Pay AMEX configuration issue - https://phabricator.wikimedia.org/T295615 (10jgleeson) Manavi raised this on today's Adyen call and she said this issue is likely related to our current Adyen payment method configuration and is not related to a technical problem. @EMartin, she's gonna... [15:52:46] 10Fundraising-Backlog: Apple Pay AMEX configuration issue - https://phabricator.wikimedia.org/T295615 (10EMartin) Thank you! [16:37:44] back later! [17:12:15] hi fr-tech I am back in Colorado [17:13:20] Heyyy cstone welcome back :) [17:13:32] hi cstone [17:13:38] Want to take standup? [17:14:25] I can if someone tells me what we've been doing :P [17:16:17] cstone: coool thx! One sec if u like I'll start an etherpad [17:16:39] awesome thanks [17:22:22] cstone fr-tech https://etherpad.wikimedia.org/p/fr-tech_adv_standup_2021-11-15 [17:31:06] fr-tech. Apple asked to have a meeting with us on optimizing Apple Pay. No pressure, but they want to chat. Is FRTech up for such a discussion? Per phab task:T295092: Optimization of Apple Pay Flow [17:31:07] T295092: Optimization of Apple Pay Flow - https://phabricator.wikimedia.org/T295092 [17:40:30] emartin: hi! thanks, following on ejegg's comment on that task, maybe we should talk about it internally first so we're sure what our options are on the points they mention? [17:40:51] I assume you're giving them links to donate wiki then, which is more or less the equivalent of what people would see in banners? [17:41:05] fr-tech ^ ? [17:42:31] PCI scope plus also current code structure are big barriers to just showing the payment form directly on donate wiki or from banners. I think we can be quite sure we can't do that [17:44:04] the other option ejegg mentioned there is redirecting to payments but not requiring the user to actually click anything there, just showing the pay sheet immediately. That sounds much more feasible but I don't know if it'd be quite the experience they're thinking of. Probably closer than what we have now, though [17:45:06] wrt layout issues on Donate wiki or in banners, those are design issues that I think are mostly outside the scope of fr-tech [18:35:11] cstone: thx for doing standup [18:35:19] np thanks for making the doc [18:35:23] :) [18:37:49] josephmando: thanks for making this task T295715 ...! Do you have more details about the queries you ran comparing the tests and the dates of the previous tests? Also, not sure which failmail you're seeing, do you have more details on that? [18:37:49] T295715: Nov 13 Weekend Test Check - https://phabricator.wikimedia.org/T295715 [18:39:14] josephmando (also smol reminder, if you're going to add actual data, maybe make the task private, or put the actual numbers in a Google doc that you can link from the task?) thx in advance! [19:39:14] 10Fundraising-Backlog: Optimization of Apple Pay Flow - https://phabricator.wikimedia.org/T295092 (10jgleeson) >>! In T295092#7483602, @Ejegg wrote: > 1) we can't do Apple Pay payments on donate.mediawiki.org because it's hosted outside of our PCI cluster and doing payments would need our Adyen credentials and o... [19:41:11] ApplePay has been disabled because the security settings of this Mac were modified ... [19:41:28] should have read [19:42:02] We've just released a small 3gig security update. Please download it to make ApplePay work.. again. [19:45:59] heh. [20:07:01] fun times [20:08:01] Jeff_Green: dwisehaupt any pointers on what the "banner loader job failmail" mentioned here is? T295715 apologies that I'm surely missing the obvious.... [20:08:02] T295715: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 [20:19:38] AndyRussG: I've been looking at that, so afaict there were four failmail events and so far there's nothing useful in the logs from the job itself [20:19:56] they were Nov 13 01:32:02 (banner_impressions_loader-20211113-012202.log) [20:19:58] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-AutoTY-Email, and 2 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10KHaggard) Hi @Eileenmcnaughton. Since it's officially... [20:20:08] Nov 15 15:47:01 (banner_impressions_loader-20211115-153701.log) [20:20:26] Jeff_Green: ah cool... do you have the failmail subject lines? or maybe I don't get them? [20:20:29] thx! [20:20:34] as well as Nov 15 16:02:02, and Nov 15 16:14:09 -- I don't know which log file for those [20:20:53] they were going to Erin only, I just adjusted that to fr-tech-ops [20:20:59] subject . . . [20:21:13] I'll add what I have so far to the task [20:21:24] ah oki thx much! [20:23:32] 10fundraising-tech-ops, 10FR-Tech-Analytics: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 (10Jgreen) [20:26:11] 10fundraising-tech-ops, 10FR-Tech-Analytics: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 (10Jgreen) Nov 13 01:32:02 Subject: Fail Mail (fran1001) run-job: Banner impressions loader timed out after 10 minutes See the logs for more information: /var/log/process-control/banner_impr... [20:27:00] 10fundraising-tech-ops, 10FR-Tech-Analytics: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 (10Jgreen) Nov 15 15:47:01 Subject: Fwd: Fail Mail (fran1001) run-job: Banner impressions loader timed out after 10 minutes See the logs for more information: /var/log/process-control/banner... [20:27:15] AndyRussG: ok there are two of the failmails and what I've found so far [20:29:05] I haven't figured out yet what other jobs are running at the same time, but looking at mariadb activity clearly something is thrashing the database form 13:00 to 18:00 or later, a large amount of insert activity during that window. I'm leaning toward that activity blocking the pgehres import, but not actually breaking it. [20:29:53] oh hmmm that sounds possible yeah [20:31:15] that said, looking at today's first event, the one at 15:47, the file mentioned right before the 10 minute gap also shows up in three other runs as "Processing /srv/archive/banner_logs/2021/beaconImpressions-sampled10.tsv.20211115-153001.log.gz" which seems odd [20:31:37] oh mtg! whoops. [20:50:59] 10Fundraising-Backlog, 10MediaWiki-extensions-CLDR, 10Technical-Debt: Is CldrCurrency still used? - https://phabricator.wikimedia.org/T295638 (10Ejegg) Thanks @Reedy, we don't see it used in a quick search, but how about we leave it alone till January just in case? [21:26:19] 10Fundraising-Backlog, 10MediaWiki-extensions-CLDR, 10Technical-Debt: Is CldrCurrency still used? - https://phabricator.wikimedia.org/T295638 (10Reedy) 05Open→03Stalled Yeah, that's fine by me. No point unnecessarily breaking FR stuff coming into Big English season, but having a plan to do something with... [21:40:14] 10Fundraising-Backlog: Issue with Paypal donations made on GiveLively for events - https://phabricator.wikimedia.org/T295726 (10Pcoombe) [21:55:01] 10fundraising-tech-ops, 10FR-Tech-Analytics: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 (10AndyRussG) Hi! Thanks @EYener and @JMando for flagging this, and thanks @Jgreen for the logs! Following @Jgreen's comments above and discussion just now in FR-Tech standup: it might be an... [22:16:33] (03PS6) 10Ejegg: Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) [22:18:34] 10fundraising-tech-ops, 10FR-Tech-Analytics: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 (10EYener) Hi @AndyRussG, quick reply to the above but please let me know if you need other info. @JMando has done a lot of this work already so I'm just re-posting here to further the invest... [22:28:54] (03CR) 10jerkins-bot: [V: 04-1] Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [22:30:43] 10fundraising-tech-ops, 10FR-Tech-Analytics: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 (10AndyRussG) >>! In T295715#7505274, @EYener wrote: > - The distribution of status codes *is* different between the Nov. 13 and Nov. 9 test, but this is likely due to campaign fallback. EX:... [22:40:03] (03PS7) 10Ejegg: Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) [22:52:24] (03CR) 10jerkins-bot: [V: 04-1] Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [22:53:45] errrghggg [22:57:15] (03PS1) 10Eileen: Add end of year thank you template and example code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/739017 (https://phabricator.wikimedia.org/T290253) [22:57:24] ohhh hmmmm [22:58:32] eileen it looks like some of those benevity tests are calling contribution_message_import with the same contact_id and employer_id [22:58:57] ejegg: because they are badly written rather than any legit reason I guess? [22:58:59] I'm getting 'Invalid Relationship' exceptions [22:59:04] oh ok [22:59:15] I guess we need to fix those to be able to manually call Relationship::create [23:00:00] oh wait, no, this is the $matchedMsg [23:00:18] and that explicitly makes them match: $matchedMsg['contact_id'] = $msg['employer_id']; [23:00:59] ejegg: oh right - so it's importing a matching contribution to their employer [23:02:01] hmm, the message makes it to Save.php with contact_type='Individual' - I guess we can just skip the employer relationship if the contact_id and employer_id are equal [23:05:56] (03PS8) 10Ejegg: Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) [23:06:20] ah right, you said we need to set the organization name too [23:11:55] ejegg: yeah - I feel like there is probably some laziness in that test that is not real-world-likely [23:17:45] (03CR) 10jerkins-bot: [V: 04-1] Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [23:25:58] ejegg: or AndyRussG - the first language I'm putting up is Spanish. They forgot to translate 'on' in this sentence - Donació 2: 1 USD on 2019-09-24 - - I think it would be better for one of you to suggest the right word than put it up like that [23:31:18] eileen: 'en' would work [23:31:25] ejegg: cool thanks [23:32:00] ejegg are u sure about that [23:32:10] AndyRussG: no, not really [23:32:14] hmm could be tho [23:32:15] better 'el' ? [23:32:30] yea sounds better? not sure about the context? [23:32:42] there's also an "n" missing at the end of Donación [23:32:51] ah yeah [23:32:57] looks portuguese without it [23:33:08] heheh [23:33:10] eileen: got more of the context there? [23:33:22] AndyRussG: it's a list [23:33:26] AndyRussG: https://docs.google.com/document/d/1AuOsNqFpJstE59yhSoFB9xLx8FcCuU85p9Dsp4OPj5E/edit# [23:33:43] eileen: ohhhh that's catalan [23:33:46] not spanish [23:33:55] oh [23:34:05] hehe indeed [23:34:12] so "on" might be correct? [23:34:21] I always get confused between 'castillian; & 'catalan' when I see an abbreviation... [23:34:28] catalan in spain [23:35:51] eileen: though it looks like "on" is indeed a mistake, and it'd be "el" in Catalan too [23:35:53] https://translate.google.com/?sl=en&tl=ca&text=The%20donation%20was%20given%20on%202021-10-11.&op=translate [23:36:12] I guess worth asking about? [23:37:09] hmm, maybe even 'fer el' [23:37:49] ah no [23:37:50] I think in that translation ^ fer is part of the verb? [23:38:00] fer seems to be hacer [23:38:02] do/make [23:38:03] https://translate.google.com/?sl=ca&tl=en&text=fer&op=translate [23:38:11] yep like "faire" in French [23:38:33] it's like Spanfrench [23:38:48] with a pinch of Italian [23:39:01] heheh [23:44:23] AndyRussG: I put a comment on https://phabricator.wikimedia.org/T234495 but wikibugs is slacking on notifying here [23:47:17] ejegg: ah cool thanks! yeah it's not public for whatever reason, so no IRC notificationz... [23:47:45] oh huh, i hadn't noticed [23:49:55] yeah seems like a quick fix to try I can do that in a bit