[00:07:14] (03PS9) 10Ejegg: Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) [00:07:26] eileen: OK, ^^^ should i THINK work [00:07:54] does that verify_message_and_stage function seem like the right place to put organization_name? [00:08:50] oh hmm, none of the in-review SmashPig patches seem like they'd be used in a library update [00:09:13] We could tag a bugfix release and update it under payments-wiki to get those Adyen names [00:09:29] but first, code review for eileen [00:10:35] ejegg: it would be handy to get this merged - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/739017 - it doesnt do anything without the other stuff - but will allow me to get tests passing on the other stuff. Unfortunately I think to merge it first will require a bit of a blind merge [00:11:48] eileen: oh, before the 'Move rendering into the render function' patch even? [00:12:31] ejegg: well - I don't know if you can do meaning ful review on that civicrm one yet - I think it might just make sense to merge it even though it could change - but you've already started on the other one [00:30:13] (03PS7) 10Ejegg: Move rendering into the render function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [00:30:17] (03CR) 10Ejegg: [C: 03+2] Move rendering into the render function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [00:30:21] yay [00:30:31] :) [00:31:16] oic, that other patch is in the civi codebase, not our crm one [00:31:39] got it, i see the class comment [00:31:44] that it will eventually move to the extn [00:37:00] (03Abandoned) 10Eileen: Move message templates into the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/738285 (owner: 10Eileen) [00:44:14] (03Merged) 10jenkins-bot: Move rendering into the render function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737833 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [00:44:34] (03PS1) 10Eileen: Add first 2 templates that can be rendered via new system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739026 (https://phabricator.wikimedia.org/T290253) [00:45:53] ejegg: I've re-organised slightly so the patch that is up now is the one that 'goes with' the CiviCRM patch & enables using the new templates from the message render screen - albeit we are not rendering using it yet [00:46:07] that could allow them to get started on looking at the translations [00:47:44] (03CR) 10jerkins-bot: [V: 04-1] Add first 2 templates that can be rendered via new system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739026 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [00:52:58] (03PS2) 10Eileen: Add first 2 templates that can be rendered via new system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739026 (https://phabricator.wikimedia.org/T290253) [00:55:35] (03CR) 10jerkins-bot: [V: 04-1] Add first 2 templates that can be rendered via new system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739026 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [00:56:00] (03PS3) 10Eileen: Add first 2 templates that can be rendered via new system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739026 (https://phabricator.wikimedia.org/T290253) [01:03:27] ok, i'll just compare the civicrm core patch to the other workflow messages [01:07:07] (03CR) 10jerkins-bot: [V: 04-1] Add first 2 templates that can be rendered via new system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739026 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [01:10:24] (03PS4) 10Eileen: Add first 2 templates that can be rendered via new system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739026 (https://phabricator.wikimedia.org/T290253) [01:14:48] ejegg: you can test with ^^ if you want [01:27:35] thanks! gotta reboot, will test soon [01:53:31] eileen: oh i just noticed a fixme that seems easy to fix [01:53:48] is it easier if you push it in? [01:53:57] lemme put up a micropatch - feel free to fold it into one of yours if you want or just +2 [01:54:46] ok sure [01:55:26] (03PS1) 10Ejegg: Round amounts correctly in EOY email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739038 [01:56:02] oops, marked as 'merge conflict [01:56:03] ' [01:56:41] ejegg: yep - I actually have plans to remove those lines too :-) [01:56:45] ahh [01:56:51] but civi has a money formatting library we should use [01:58:51] I'm gonna try to get the bulk of the smarty in & then look at that [01:58:56] k [01:59:32] did I abandon the patch you are looking at? [02:00:06] (03PS1) 10Eileen: Add a bunch of translations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739041 (https://phabricator.wikimedia.org/T290253) [02:00:58] I've switched focus from rendering to getting them UI-available so advancement can see them & will switch back [02:01:04] after [02:05:09] pretty cool [02:05:15] being able to preview! [02:06:53] ejegg: yeah - & I feel like there is still work to do on the rendering but we can get them going in paralell [02:07:30] I've nearly put all the translations into files... also for pleasant interludes I've been sticking needles in my eye to break it up [02:08:17] (03CR) 10jerkins-bot: [V: 04-1] Round amounts correctly in EOY email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739038 (owner: 10Ejegg) [02:08:25] oh man, thank you for your sacrifice [02:11:29] lol [02:16:47] So somehow I'm not seeing the EOY catalan one locally [02:17:04] trying to reason my way through the _wmf_civicrm_managed_get_translations [02:22:22] shoot eileen I think I need to focus on some interview prep [02:22:24] ejegg: yeah - it needs to trigger [02:22:47] I usualy disable or enable civitutorial [02:22:50] to trigger it [02:22:56] or civibuild [02:23:06] oh, I can trigger it fine with system.flush [02:23:41] and a breakpoint at the bottom of _wmf_civicrm_managed_get_translations shows entries for each of the parts in both en and ca [02:23:47] so let's see where we go from there [02:24:53] ah OK, I do see it in the civicrm_managed table after a second system.flush [02:25:02] & in civicrm_translation? [02:25:39] yep! odd, the first system.flush added the MessageTemplate entities but not the translations [02:25:44] maybe an ordering thing? [02:26:43] fr-tech is there like an ingenico sandbox console somewhere? [02:27:09] I got into this: https://account.ingenico.com/dashboard but it seems not to be the thing I want.... [02:27:44] ejegg: ah - yeah - it would early return if the message template wasn't present I think [02:28:02] so 2 flushes = needed [02:29:56] eileen: ok, thanks for the confirmation [02:32:02] (03PS2) 10Eileen: Add a bunch of translations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739041 (https://phabricator.wikimedia.org/T290253) [03:10:51] (03PS1) 10Eileen: Add remaining translations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739048 (https://phabricator.wikimedia.org/T290253) [03:27:57] ejegg: I just put them all onto staging - https://civicrm.frdev.wikimedia.org/civicrm/admin/messageTemplates?reset=1#/workflow?f=%7B%22text%22:%22year%22%7D [03:48:54] cool eileen ! [03:49:30] I'm afraid I won't be able to do much more reviewing tonight - gotta fill out some coding task scorecards [03:50:21] eileen but i did want to know what you thought of my putting the organization_name lookup in the message staging function. Should we maybe avoid adding more code in that old module? [03:50:48] The alternative looks like putting it right up at the top of Save::_run before we branch off for the update [03:51:10] ejegg: this one ? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/737821 [03:51:43] yep [03:52:47] so could we put it right at the start of 'Save'? [03:52:58] eileen: yeah, that's how I had it first [03:53:13] better there? [03:53:34] I think so - my take would be that 'save' should be able to deal with 'our params' & make a contact [03:56:12] k, i should add that field to the test too [04:00:30] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-AutoTY-Email, and 2 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10Eileenmcnaughton) @KHaggard @CDenes_WMF - the templa... [04:17:41] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, and 4 others: Civi: Auto Recurring Fail email, batch of copy corrections - https://phabricator.wikimedia.org/T289617 (10Eileenmcnaughton) [04:32:03] (03CR) 10Ejegg: WIP field name constants (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737535 (owner: 10Ejegg) [04:40:18] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, and 4 others: Civi: Auto Recurring Fail email, batch of copy corrections - https://phabricator.wikimedia.org/T289617 (10Eileenmcnaughton) [04:56:39] (03PS10) 10Ejegg: Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) [04:57:02] ok eileen, ^^^ gets that organization_name populated correctly [04:57:30] I did have to make it pay attention to organization_name for contacts in general, not just organization type ones [05:07:41] (03CR) 10jerkins-bot: [V: 04-1] Mark employer data from payments as donor-supplied [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/737821 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [13:36:38] 10fundraising-tech-ops, 10FR-Tech-Analytics: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 (10Jgreen) I ran through the banner_impressions_loader logs from Oct and Nov to check for instances where log files were not processed. All logs that showed up in the files at all were proces... [13:50:02] jgleeson: Hi, I'm on the call [13:50:18] apologies for the delay [13:51:52] np damilare coming now! [15:13:58] 10fundraising-tech-ops: Investigate modifying icinga alert emails to include the URL to ack the alert - https://phabricator.wikimedia.org/T295383 (10Jgreen) 05Open→03Resolved p:05Triage→03Medium Woot, it works! Notes URLs: https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&serv... [15:15:51] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10netops: Upgrade pfw to Junos 20+ - https://phabricator.wikimedia.org/T295691 (10Jgreen) @ayounsi I think it would be fine to do the codfw pfw's this year. Please ping me on IRC when you have some time to discuss. [15:23:01] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-AutoTY-Email, and 2 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10KHaggard) Thanks @Eileenmcnaughton - Makes sense to m... [15:42:50] 10fundraising-tech-ops, 10FR-Tech-Analytics: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 (10Pcoombe) The Wikipedia Asian Month campaign has always had Normal priority, and our campaigns have had High priority, so they shouldn't have been taking impressions away from us. I don't s... [15:53:16] hi fr-tech :) [15:56:50] hi AndyRussG :) [16:03:07] 10fundraising-tech-ops, 10FR-Tech-Analytics: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 (10Jgreen) Another pipeline-related data point is the kafka/kafkatee monitoring metrics. https://frmon. days.wikimedia.org/d/xhmR5OBWk/kafkatee?orgId=1&from=1634356800000&to=1637125199000 T... [16:06:59] jgleeson :) [16:20:02] fr-tech looks like we got some debug logs from the PayPal curl issue [16:47:10] Jeff_Green: I guess we just need an icinga-wm alert now? [16:47:42] jgleeson: ? [16:47:49] oh to see if it works for the bot? [16:48:39] yup [16:49:23] or an email from nagios [16:49:26] maybe it will be a watching the pot waiting for it to boil thing, and prevent outages forever [16:49:31] ha [16:49:48] email works, that link was from alerts we got re. replication on frdb1003 [16:49:59] I have no idea what will happen re. irc though [16:51:06] AndyRussG: looks like we've had an ingenico and paypal blip today [16:51:51] ah hmmm [16:53:02] yeah on Saturday with ejegg's help (and approval) I turned on debug logging for Paypal because we were getting PayPal CURL failmails without much info... [17:02:34] nice [17:12:01] hi fr-tech [17:12:16] howdy [17:12:23] hey :) [17:13:38] howdy [18:08:02] hi jgleeson: can we jump on a quick call to discuss a few [18:08:13] ejegg: could definitely be wrong here because it's tricky to follow but it looks like for orphans that we map to pending we're deleting the pending tbl record at the end of the process but the comment suggest we wanna leave it alone and try again later. checkout https://tinyurl.com/kp63vvx8 and https://tinyurl.com/e3wpcptf for more info. [18:08:35] ah damilare I'm just about to break for dinner ha! just wanted to get that message out to ejegg before doing so [18:09:13] Ok maybe when you get back then [18:09:16] let's catch up a bit later if that works for you? [18:09:21] sure! speka then [18:09:23] speak* [18:09:49] jgleeson|dinner: ah yeah, i guess we are really deleting them... [18:10:39] so we unfortunately can't leave them in the table with the current logic, we need to delete it so the next time we fetch oldest we get something new [18:11:24] could that explain why some need manually pushing through? (the catalyst for the work I think?) [18:12:46] no, the ones that need pushing manually are mostly ones who we have flagged as fraud-y but that Donor Services sees match existing donors [18:17:07] 10Fundraising-Backlog: India recurring enablement - https://phabricator.wikimedia.org/T295798 (10EMartin) [18:35:19] 10Fundraising-Backlog: India recurring enablement - https://phabricator.wikimedia.org/T295798 (10Ejegg) @EMartin That documentation is for a newer integration than the 'Streamline' integration we've got implemented. Can you ask if the instructions for recurring payments here will work for India? https://dlocal.... [18:36:11] ejegg. I'll find out. [18:47:21] 10fundraising-tech-ops, 10FR-Tech-Analytics: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 (10JMando) Just took a look comparing banner history data set to page views data set. For the time this test took place in en6c it looks like 16,510,689 page views were . I am seeing 13,420,... [19:32:13] hmm Jeff_Green maybe that mailing list doesn't exist [19:33:07] jgleeson: I don't know of a way to check except to ask OIT. [19:33:48] I thought I recalled a conversation a while back when David was trying to get a list of people who needed know about emails from gateways much like the Ingenico one Kristie wants to see [19:34:03] mbeattie: do you get emails from fr-tech@ ? [19:34:19] I do [19:35:12] ah ok maybe there isn't such a mailing list! [19:35:21] and I'm getting confused with fr-tech-acoustic [19:37:04] Jeff_Green: thanks, I guess it couldn't do any harm checking with OIT to see what fr-tech related mailing lists are out there currently [19:37:13] I'll fire over a note sortly [19:37:23] shortly [19:37:31] ya. I checked the lists we administer and there weren't any that seemed relevant [19:38:48] I guess this would typically be one for David. [19:40:17] I guess a quick fix would be to add krisite to fr-tech if that's how mbeattie and evelyn catch those notifications... but then that might warrant a rethink of groups/recipients/importance [19:41:14] damilare: I'm on our call from earlier. feel free to hop on! [19:43:02] cool [19:53:33] 10Wikimedia-Fundraising-Banners, 10Wikipedia-iOS-App-Backlog, 10Patch-For-Review, 10iOS-app-v6.9-Carp-On-A-Zamboni: 2021 English fundraising messages in iOS app - https://phabricator.wikimedia.org/T294996 (10Tsevener) Patch is merged, production confirmation ticket is here - https://phabricator.wikimedia.o... [20:48:41] (03PS2) 10Eileen: Add end of year thank you template and example code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/739017 (https://phabricator.wikimedia.org/T290253) [20:49:43] (03PS1) 10Ejegg: Update SmashPig [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/739345 [20:50:35] 10Fundraising Sprint Visual C Saw, 10fundraising-tech-ops, 10FR-Tech-Analytics: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 (10XenoRyet) [20:50:53] (03CR) 10Ejegg: [C: 03+2] Update SmashPig [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/739345 (owner: 10Ejegg) [20:52:21] (03PS1) 10Eileen: Use contribution.amount rather than total_amount in the templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739346 (https://phabricator.wikimedia.org/T290253) [20:56:50] 10Fundraising-Backlog: Apple Pay first_name can be longer than 64 characters - https://phabricator.wikimedia.org/T295821 (10Cstone) [20:59:40] (03Merged) 10jenkins-bot: Update SmashPig [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/739345 (owner: 10Ejegg) [21:11:33] 10Fundraising-Backlog, 10fundraising-tech-ops: Emoji breaks damaged messages - https://phabricator.wikimedia.org/T277240 (10Dwisehaupt) [21:23:07] (03PS1) 10Jgleeson: WIP: Add tests for Pending trxn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) [22:18:13] 10Fundraising-Backlog, 10FR-Smashpig: Store retry messages in a separate table from damaged - https://phabricator.wikimedia.org/T295829 (10Ejegg) [22:19:29] 10Fundraising-Backlog, 10FR-Smashpig: Store retry messages in a separate table from damaged - https://phabricator.wikimedia.org/T295829 (10Ejegg) p:05Triage→03Low [22:47:48] (03CR) 10Ejegg: [C: 03+2] Add end of year thank you template and example code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/739017 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [22:52:40] (03PS5) 10Ejegg: Add first 2 templates that can be rendered via new system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739026 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [22:52:45] (03CR) 10Ejegg: [C: 03+2] Add first 2 templates that can be rendered via new system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739026 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [22:52:56] (03PS2) 10Ejegg: Round amounts correctly in EOY email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739038 [23:01:26] (03Merged) 10jenkins-bot: Add end of year thank you template and example code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/739017 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [23:05:34] (03Merged) 10jenkins-bot: Add first 2 templates that can be rendered via new system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739026 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [23:07:18] (03CR) 10jerkins-bot: [V: 04-1] Round amounts correctly in EOY email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739038 (owner: 10Ejegg) [23:18:02] (03PS1) 10Eileen: Submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739372 [23:18:14] (03CR) 10Eileen: [C: 03+2] Submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739372 (owner: 10Eileen) [23:30:37] (03Merged) 10jenkins-bot: Submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739372 (owner: 10Eileen) [23:57:56] !log updated payments-wiki from 49ad5962 -> abb2bd9d [23:57:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log