[00:43:58] (03PS4) 10Ejegg: Only export employer data supplied by donors [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) [00:46:45] ok eileen, ^^^ is working locally, passing tests. I think it's all we need to filter from this point forward [00:47:04] ejegg: great - I'll take a look shortly [00:47:42] for the existing records, if we don't want to do a full rebuild it would be easy to just do an update blanking the employer_id and employer_name columns in silverpop_export and silverpop_export_staging [01:10:58] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-AutoTY-Email, and 2 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10Eileenmcnaughton) I pushed out that fix - hopefully t... [01:21:38] (03CR) 10Eileen: "This looks good - I spotted 2 minor things" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [01:21:56] thanks for the CR eileen [01:28:35] eileen: so on my local old Civi and on prod, 'Employee of' is relationship_type_id 4, but in docker it's 5 [01:28:52] I think i'd want the extra join if we're going to add that as a condition [01:29:18] oops, back in a few [01:30:13] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 184793 Threads: 13 Questions: 26514161 Slow queries: 152411 Opens: 103360690 Flush tables: 1 Open tables: 200 Queries per second avg: 143.480 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [01:40:53] (03PS3) 10Eileen: Remove form from extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739393 (https://phabricator.wikimedia.org/T290253) [04:07:38] (03PS5) 10Ejegg: Only export employer data supplied by donors [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) [04:10:43] (03PS6) 10Ejegg: Only export employer data supplied by donors [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) [04:11:15] (03CR) 10Ejegg: "Thanks for the review Eileen, I think I've addressed both comments in the latest PS" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [10:01:01] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-AutoTY-Email, and 2 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10krobinson) Thank you for all of the word on this! Can... [16:20:40] (03PS3) 10Jgleeson: WIP: Add tests for Pending Transaction Consumer and Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) [16:21:37] damilare: there's a couple of tests failing in the above patch we can use to guide the implementation I think ^^ [16:23:41] the tests which check the Resolve API behaviour are all reporting "Undefined index: resolvableMethods" which feels like something we need to fix to proceed [16:27:40] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Fix Adyen IPN listener response to NotificationOfChargeback - https://phabricator.wikimedia.org/T295997 (10Ejegg) [16:27:57] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 4 others: Add existing donor matching to PendingTransaction::resolve - https://phabricator.wikimedia.org/T291226 (10jgleeson) a:05jgleeson→03None [16:29:11] interestingly I don't see that when running the Consume API call or the Consume tests, which pass [16:29:38] maybe it's due to the Resolve action not being called due to no pending messages [16:29:48] I'll add a donation locally and see how it performs then [16:32:48] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add tests for Pending Transaction Consumer and Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [16:33:21] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Create new IPN message types for Adyen - https://phabricator.wikimedia.org/T295998 (10Ejegg) [16:33:51] (03PS2) 10Ejegg: Add new Adyen IPN types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737512 (https://phabricator.wikimedia.org/T295998) [16:34:36] (03CR) 10Ejegg: "Thanks for the review AndyRussG. PS2 is rebased and tagged with the new Phab task. There's another phab task created for the chargeback no" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737512 (https://phabricator.wikimedia.org/T295998) (owner: 10Ejegg) [16:37:57] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig, 10Patch-For-Review: Create new IPN message types for Adyen - https://phabricator.wikimedia.org/T295998 (10Ejegg) [16:42:20] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_warning 1 [=1],GlobalCollect_endpoint_critical 2 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [16:43:51] icinga-wm looks good to me Jeff_Green !!! [16:44:01] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739388 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [16:44:09] took me right to the point I could ack the alert [16:44:35] uh oh fr-tech failmail wave [16:45:07] ingenico timeouts [16:45:12] ugh [16:45:34] looks like a 4 minute window [16:46:22] jgleeson: oh, that corresponds with those icinga endpoint warnings [16:46:26] could be on our side? [16:46:34] oh interesting as that was adyen [16:46:47] hmm that was 42m on the hour tho [16:46:52] it was both, right? Adyen_endpoint_warning 1 [=1],GlobalCollect_endpoint_critical [16:46:54] ingenico was 33-37 [16:47:02] oh I missed the GC [16:47:06] yeah good spot [16:47:18] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [16:47:30] hmm, could that icinga alert be a couple minutes delayed? It seems to be reading from log messages [16:48:37] were all those just from the emails? also my irc is mad at me [16:49:26] hmm, there was a mass IRC disconnect at 11:37 (like 20 users quit: Connection reset by peer) [16:49:42] ya I noticed everyone joining [16:49:47] Some larger internet glitch? [16:49:53] hmmm [16:49:57] they changed something in the Matrix [16:50:07] i guess 600k emails went out 2 hours ago [16:50:25] er 505k [16:51:51] the silverpop failmail in the midst of those is also a connection timeout, at :35 [16:53:19] hmmmz [16:53:39] hmm, looks like we were able to connect to adyen, amazon, and paypal just fine during those 4 minutes though, going by the payments-initial log [16:54:14] which has a slightly misleading name [16:54:29] as that's the last queue message to be created during the donation flow I think [16:54:48] heh, never thought about that, but I guess so [16:57:22] (03Merged) 10jenkins-bot: Update the end of year summary action form to display the rendered text. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739388 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [16:57:44] since I've worked here I always thought the pending queue message comes first but turns out that comes second, after the donation message [16:57:45] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog: Document Adyen Checkout - https://phabricator.wikimedia.org/T288403 (10Cstone) I put some very basic things here https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/PSP_integrations/Adyen_Checkout I'll continue to add but anyone else feel fre... [16:58:13] unless there's two pending messages [16:58:25] ha! [17:00:34] jgleeson: oh, the pending message should generally be sent before the donation message [17:02:33] it looks like that gets dropped after doPayment does it's thing [17:03:01] right, and doPayment usually doesn't complete the payment [17:03:10] I think it's just for Adyen [17:07:23] I'll add a pending part to the documentation [17:13:11] for all other processors we get the donor info in one submit, and send the pending queue message [17:13:35] then we get the payment info in another submit or redirect and send the donation message [17:14:55] hmm [17:26:47] I felt like I understood the stages but maybe I was following it through with adyen [17:26:59] I'll check again after dinner with ingenico [17:27:15] and then maybeeeeeeeeee make a quick sequence diagram to store that somewhere [17:58:02] woo, cstone got her name back [17:58:30] yeah! [18:23:20] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Purge obsolete currency codes - https://phabricator.wikimedia.org/T296015 (10Ejegg) [18:27:19] (03PS1) 10Ejegg: Remove obsolete currency codes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/739906 (https://phabricator.wikimedia.org/T296015) [18:32:27] (03CR) 10Jgleeson: [C: 03+2] "Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/739906 (https://phabricator.wikimedia.org/T296015) (owner: 10Ejegg) [18:40:59] damilare: looks like the 'Unknown api parameter: getResolvableMethods' is a thing that needs fixing so we could look at that as a starting point I think [18:41:21] I just tried running the existing Pending Trxn stuff with a real donation and it throws that exception [18:41:32] feels like civicrm API boiler plate stuff [18:51:53] looks like it's happening here https://github.com/wikimedia/wikimedia-fundraising-crm-civicrm/blob/8fff494b4afcfc210e998e4991d596558d2a802e/Civi/Api4/Generic/AbstractAction.php#L205 [18:52:36] (03Merged) 10jenkins-bot: Remove obsolete currency codes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/739906 (https://phabricator.wikimedia.org/T296015) (owner: 10Ejegg) [18:53:15] ahh I think I know what it is [18:53:25] or at least the bit of code that's cause it [18:53:27] causing* [18:54:26] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/722703/5/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/Action/PendingTransaction/Resolve.php#25 [18:54:39] so why can't the line lower down access that property [18:55:17] for some reason it's not being seen and then falling back to the AbstractAction's __call magic method which in turn throws the exception [18:57:18] oh this is interesting [18:58:46] calling PendingTransaction::resolve() seems to "resolve" to PendingTransaction\Resolve->_run() [18:59:16] I wonder if that needs to be static:: and not self:: [19:03:23] ah ok so this isn't civicrm magic [19:03:51] there's actually a class called PendingTransaction with a static Resolve method [19:03:57] https://github.com/wikimedia/wikimedia-fundraising-crm/blob/9949b8d4fea6eaa42257b7c12e82440c4fa2f16c/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/PendingTransaction.php#L25 [19:13:11] oh it looks like civicrm API action properties need getters and setters when declared in the action class [19:13:36] or maybe a magic comment? [19:13:47] like we've got got setMessage/getMessage [19:14:01] the error is happening in ValidateFieldsSubscriber [19:14:11] one of the api.prepare listeners [19:23:11] ahh [19:23:27] https://docs.civicrm.org/dev/en/latest/api/v4/architecture/#api-action-classes [19:23:34] Store the parameters of the API call. [19:23:36] Every protected class var is considered a parameter (unless it starts with an underscore). [19:23:58] let's see if adding an underscore takes it off the field validators hit list [19:27:40] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-AutoTY-Email, and 2 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10CDenes_WMF) @Eileenmcnaughton could you please grant... [19:29:20] yup [19:29:44] ok now that's fixed let's run the tests again and see what our next job is [19:33:52] (03PS6) 10Jgleeson: WIP resolve pending transactions w/o DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [19:37:37] Configuration key 'payment-provider/cc/class' does not exist. [19:37:52] so that's good because it means it's getting right along to trying to make API calls [19:38:29] jgleeson: ok, that would be in the ProviderConfiguration [19:38:50] so you'd want to make sure you're setting up a TestingProviderConfiguration [19:39:09] and then giving it a mock object for that path [19:39:24] I was just looking at this ejegg https://github.com/wikimedia/wikimedia-fundraising-crm/blob/cc4dfdcbb979df635979a82ae38017c6b30faa05/drupal/sites/default/civicrm/extensions/org.wikimedia.smashpig/tests/phpunit/CRM/SmashPigTest.php#L105 [19:39:43] from your overview in tech-talk [19:39:43] yep, exactly [19:39:55] same thing should work for your new tests [19:40:02] nice [20:02:43] (03CR) 10Ejegg: [C: 03+1] "Looks great! Would it be possible to make autossh go into the background when running with --autossh from the command line? Or would that " [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/738598 (owner: 10AndyRussG) [20:05:05] cstone: I just got tickets for this! https://www.bridgewater-hall.co.uk/whats-on/zimmer-vs-williams-271221/ [20:05:14] my Christmas gift to myself [20:06:20] * jgleeson is now praying I've not put myself on support that day [20:06:55] nope! ejegg is on that day... phew [20:08:57] ok calling it a day! bye for now fr-tech [20:12:43] Yessss awesome jgleeson|away !! [20:18:21] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-AutoTY-Email, and 2 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10Eileenmcnaughton) @CDenes_WMF done - @krobinson - you... [20:28:07] (03PS4) 10Ejegg: Bump twig/twig to 1.44.5 [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/734337 (owner: 10Zabe) [20:28:32] (03CR) 10Ejegg: [C: 03+2] "Thanks, this looks good!" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/734337 (owner: 10Zabe) [20:29:11] (03PS4) 10Eileen: Remove form from extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739393 (https://phabricator.wikimedia.org/T290253) [20:29:13] (03PS3) 10Eileen: Stop filtering out endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739392 (https://phabricator.wikimedia.org/T290253) [20:33:16] (03PS1) 10Ejegg: Update FundraisingEmailUnsubscribe and twig [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/739933 [20:33:42] (03CR) 10Ejegg: [C: 03+2] Update FundraisingEmailUnsubscribe and twig [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/739933 (owner: 10Ejegg) [20:40:22] (03CR) 10Ejegg: [C: 03+2] "Confirmed, this file was the last place those vars are used." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739393 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [20:49:13] (03Merged) 10jenkins-bot: Bump twig/twig to 1.44.5 [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/734337 (owner: 10Zabe) [20:52:06] (03Merged) 10jenkins-bot: Remove form from extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739393 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [21:01:05] !log updated payments-wiki from abb2bd9d -> d1d6f024 [21:01:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:03:09] (03Abandoned) 10Ejegg: Updating composer dependencies [extensions/FundraisingEmailUnsubscribe] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/670554 (owner: 10Jgleeson) [21:22:08] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, and 4 others: Civi: Auto Recurring Fail email, batch of copy corrections - https://phabricator.wikimedia.org/T289617 (10Ejegg) I looked over the last three in... [22:01:54] (03PS1) 10Eileen: Extract message template load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739941 [22:14:46] (03CR) 10jerkins-bot: [V: 04-1] Extract message template load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739941 (owner: 10Eileen) [22:18:10] (03PS2) 10Eileen: Extract message template load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739941 [22:30:08] (03CR) 10jerkins-bot: [V: 04-1] Extract message template load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739941 (owner: 10Eileen) [22:50:27] 10Fundraising-Backlog, 10fr-donorservices: In need of access to see the actual "email content" under mailing events tab in civi. - https://phabricator.wikimedia.org/T296039 (10SHust) [23:12:52] 10Fundraising-Backlog, 10fr-donorservices: Add a second layer of confirmation to the batch merge deduper button - https://phabricator.wikimedia.org/T296042 (10SHust) [23:30:32] (03CR) 10Eileen: [C: 03+2] "This looks good - obviously when deploying we need to check what data is already in our silverpop DB & what is at acoustics end" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/738025 (https://phabricator.wikimedia.org/T294488) (owner: 10Ejegg) [23:47:29] (03PS3) 10Eileen: Extract message template load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739941 [23:59:50] (03CR) 10jerkins-bot: [V: 04-1] Extract message template load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739941 (owner: 10Eileen)