[00:08:33] <ejegg>	 thanks for the review eileen 
[00:08:52] <eileen>	 ejegg: I thought I'd better get it done to give you time to do the juggling
[00:09:36] <ejegg>	 yeah, I think I'll just run some SQL to blank those fields on existing donors
[00:17:42] <eileen>	 ejegg: & do a whole db update to clear existing? How many are there?
[00:17:55] <ejegg>	 ah, good question
[00:18:09] <ejegg>	 i was going to ask if there was a way to clear certain fields on their side
[00:18:31] <ejegg>	 but that might be just as disruptive as adding a new field
[00:19:08] <wikibugs>	 (03PS4) 10Eileen: Extract message template load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739941
[00:49:54] <wikibugs>	 (03PS1) 10Eileen: Bulk replace old token with new [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739949
[01:13:33] <wikibugs>	 (03PS1) 10Ejegg: WIP Dial-A-Form for testing [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/739954 (https://phabricator.wikimedia.org/T86247)
[01:16:47] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] WIP Dial-A-Form for testing [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/739954 (https://phabricator.wikimedia.org/T86247) (owner: 10Ejegg)
[01:48:42] <wikibugs>	 10Fundraising-Backlog, 10fr-donorservices: Featured Request: Have Civi reflect when an email has been unsubscribed 90 days - https://phabricator.wikimedia.org/T296054 (10SHust)
[02:32:01] <wikibugs>	 (03PS2) 10Eileen: Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253)
[02:32:19] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Stop filtering out endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739392 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen)
[02:32:54] <wikibugs>	 (03PS3) 10Eileen: Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253)
[02:33:26] <ejegg>	 eileen: didn't you say that civi-data-translate was obsolete? Or was that a different extension?
[02:33:35] <eileen>	 ejegg: I hoped it was
[02:33:46] <eileen>	 but it seems not yet
[02:33:57] <eileen>	 there are still a bunch of gaps it turns out
[02:35:29] <ejegg>	 got it, thanks
[02:43:11] <wikibugs>	 (03Merged) 10jenkins-bot: Stop filtering out endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739392 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen)
[02:44:34] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen)
[02:45:59] <wikibugs>	 (03PS1) 10Eileen: Pass through locale [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/739959
[02:48:27] <eileen>	 well I got it working in the sense of the UI screen - looks like a test challenge though...
[02:50:20] <ejegg>	 hmm, so is there any reason I shouldn't deploy that tools (silverpop_export) update now?
[02:51:28] <ejegg>	 never mind, I'll do it Monday
[02:55:58] <wikibugs>	 (03PS4) 10Eileen: Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253)
[03:07:54] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen)
[03:32:35] <wikibugs>	 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog: Document Adyen Checkout - https://phabricator.wikimedia.org/T288403 (10Ejegg) Added a bit more, but we could go into a lot more detail. Should we put class/method level implementation details on that page?
[03:41:05] <wikibugs>	 (03Abandoned) 10Ejegg: Script to forward IPN listener ports [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731856 (owner: 10Ejegg)
[03:41:13] <wikibugs>	 (03PS3) 10Ejegg: Generic SmashPig maintenance script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731859
[03:44:46] <wikibugs>	 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.38-notes (1.38.0-wmf.11; 2021-11-30): Purge obsolete currency codes - https://phabricator.wikimedia.org/T296015 (10Ejegg) List from http://forexesteem.blogspot.com/2009/03/obsolete-currency-codes.html:  ADF ADP AFA ALK AON AOR ARA ARL AR...
[04:41:01] <wikibugs>	 (03PS5) 10Eileen: Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253)
[04:43:52] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen)
[05:22:17] <wikibugs>	 (03PS6) 10Eileen: Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253)
[05:25:01] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen)
[05:42:13] <wikibugs>	 (03PS7) 10Eileen: Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253)
[05:53:22] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen)
[06:20:50] <wikibugs>	 10Fundraising Sprint Visual C Saw, 10fundraising-tech-ops, 10FR-Tech-Analytics: Nov 13 2021 Weekend Test Check - https://phabricator.wikimedia.org/T295715 (10AndyRussG) Hi again... so, after talking this over with @EYener, it seems there are two areas to dig into:  1) Accuracy of data in pgehres. The impress...
[13:55:06] <wikibugs>	 (03PS4) 10Jgleeson: WIP: Add tests for Pending Transaction Consumer and Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223)
[14:31:38] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] WIP: Add tests for Pending Transaction Consumer and Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson)
[15:01:07] <damilare>	 jgleeson: Looks like we needed to run "composer install" to get the tests to work. I initially pulled from the patch and the test returned the same error but when I ran "composer install" on the container it ran and tests failed with this error "DB Error: no such table".
[15:57:23] <jgleeson>	 hey damilare did you have any luck running those tests after pulling down the latest?
[16:01:24] <jgleeson>	 oops just seen your note above
[16:01:42] <damilare>	 jgleeson: was just retyping those
[16:01:54] <damilare>	 I'm on the latest patch 
[16:02:13] <damilare>	 Had to run composer install to fix the issue we were having
[16:02:28] <jgleeson>	 I'm not sure what composer's install has to do with the redeclaring of the bootstrap cv fn but I'll take it if it fixed your environment!
[16:02:43] <jgleeson>	 possibly an autoloading qurik?
[16:03:21] <damilare>	 possibly it updated monolog, geocoder, smashpig, and php-http
[16:03:54] <damilare>	 does any of those has to do with the bootstrap declaration?
[16:04:03] <damilare>	 have*
[16:04:05] <jgleeson>	 not directly
[16:04:21] <jgleeson>	 hmm
[16:04:44] <jgleeson>	 that omnimail ext phpuit boostrap file has caused other issues so maybe it's something new
[16:04:56] <damilare>	 Actually it downgraded this updated monolog, geocoder, and php-http
[16:05:03] <damilare>	 and upgraded smashpig
[16:05:19] <damilare>	 Actually it downgraded this: monolog, geocoder, and php-http*
[16:05:59] <damilare>	 Cool anyway, glad that's sorted
[16:06:06] <jgleeson>	 yeah!
[16:06:17] <jgleeson>	 although the DB table one is new 
[16:06:26] <damilare>	 Next is this failed test message: "DB Error: no such table"
[16:06:42] <jgleeson>	 my guess is the pending database, but I don't see it locally
[16:06:47] <jgleeson>	 see the error that is*
[16:07:32] <damilare>	 Actually I just pulled the second update to that patch and the error now says Undefined index: resolvableMethods
[16:07:37] <jgleeson>	 oh hey that error is on CI
[16:07:50] <jgleeson>	 second update?
[16:08:09] <damilare>	 Patchset 1
[16:08:14] <damilare>	 Patchset 2*
[16:08:38] <damilare>	 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/739354/2 
[16:08:39] <jgleeson>	 oh ok that should have come down earlier when I posted the link
[16:08:43] <jgleeson>	 in google chat
[16:08:50] <jgleeson>	 did it download PS1 ?
[16:09:44] <jgleeson>	 did you pull it down with `git review -d 739354` 
[16:10:01] <jgleeson>	 looks like that last update was pushed about 2pm
[16:10:08] <damilare>	 yes initially, then I ran this "git review -d 739354/2" after the error
[16:10:42] <jgleeson>	 hmm they should do the same thing really
[16:10:49] <jgleeson>	 at least after 2pm! 
[16:11:09] <jgleeson>	 what's strange is that error you were seeing on PS1 is on CI now
[16:11:11] <damilare>	 the first did this: Switched to branch "review/jgleeson/PendingTrxnResolverTest"
[16:11:26] <damilare>	 the second this: Switched to branch "review/jgleeson/PendingTrxnResolverTest-patch2"
[16:11:51] <damilare>	 Ohh that's interesting
[16:12:56] <damilare>	 moving back to the first 
[16:13:01] <jgleeson>	 yeah might be best to avoid the /1/2/3/ addition. that's something we don't tend to use
[16:13:14] <jgleeson>	 so here's a test
[16:13:19] <jgleeson>	 if you do git review -d 739354 now
[16:13:58] <damilare>	 takes me back to this:Switched to branch "review/jgleeson/PendingTrxnResolverTest" and getting the DB Error
[16:17:16] <jgleeson>	 I think that's PS2 then
[16:20:48] <jgleeson>	     $existingContributionId = CRM_Core_DAO::singleValueQuery(
[16:20:50] <jgleeson>	       'SELECT contribution_id from contribution_tracking where id = %1',
[16:20:52] <jgleeson>	       [1 => [$this->message['contribution_tracking_id'], 'Integer']]
[16:21:09] <jgleeson>	 that's the line that's causing that failure
[16:21:37] <jgleeson>	 however for me locally, I don't get past line 53
[16:22:01] <jgleeson>	 4:30:59 /src/wikimedia/fundraising/crm/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/Action/PendingTransaction/Resolve.php:64
[16:22:40] <jgleeson>	 that's the line which triggers the DB error.
[16:23:27] <jgleeson>	 ok I also get that error if I comment out the lines before it
[16:23:32] <jgleeson>	 that make API calls
[16:23:39] <jgleeson>	 so that's definitely one to fix also
[16:25:42] <damilare>	 That's interesting
[16:26:19] <damilare>	 Can we get on a call to discuss the Mock DBs
[16:26:31] <damilare>	 maybe after catch up
[16:26:47] <jgleeson>	 sure good idea
[16:27:03] <jgleeson>	 we can do it now if you like?
[16:27:12] <jgleeson>	 I'm just looking into our mock API responses
[16:27:43] <damilare>	 sure I'm available
[16:27:49] <damilare>	 On the last link
[16:27:55] <jgleeson>	 coming!
[17:25:40] <wikibugs>	 10Fundraising-Backlog: Apple Pay AMEX configuration issue - https://phabricator.wikimedia.org/T295615 (10EMartin) This was successfully resolved by Adyen who configured AMEX on Apple Pay and I have confirmed it now works!
[17:26:03] <wikibugs>	 10Fundraising-Backlog: Apple Pay AMEX configuration issue - https://phabricator.wikimedia.org/T295615 (10EMartin) 05Open→03Resolved a:03EMartin
[18:37:12] <icinga-wm>	 PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Amazon_endpoint_critical 5 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages
[18:42:12] <icinga-wm>	 RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages
[19:56:20] <wikibugs>	 (03PS5) 10Jgleeson: WIP: Add tests for Pending Transaction Consumer and Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223)
[20:09:23] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] WIP: Add tests for Pending Transaction Consumer and Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson)
[21:41:30] <wikibugs>	 (03PS1) 10Eileen: Fix test so it doesn't rely on others to define - sigh [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/740270
[21:54:58] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Fix test so it doesn't rely on others to define - sigh [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/740270 (owner: 10Eileen)
[23:54:13] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Emoji breaks damaged messages - https://phabricator.wikimedia.org/T277240 (10Dwisehaupt) These tables are not that big, currently 205M and 265M. We can definitely fit them in the next maintenance window. Possibly even sooner if we plan and stop jobs accordingly....