[00:01:08] eileen: sorry I missed your message about ^ earlier, it's a US holiday here tomorrow and friday but I can look at it Monday if no one else has picked it up [00:01:31] cstone: oh of course cool [00:01:44] I mean I can do it - I just thought someone else might like to [00:01:55] yeah I appreciate you writing out how to! [00:02:17] (03PS2) 10Ejegg: Remove unused polyfills [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730390 (https://phabricator.wikimedia.org/T235352) [00:02:41] (03PS3) 10Ejegg: Remove unused polyfills [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730390 (https://phabricator.wikimedia.org/T235352) [00:02:44] (03CR) 10Ejegg: [C: 03+2] Remove unused polyfills [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730390 (https://phabricator.wikimedia.org/T235352) (owner: 10Ejegg) [00:13:22] (03Merged) 10jenkins-bot: Remove unused polyfills [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/730390 (https://phabricator.wikimedia.org/T235352) (owner: 10Ejegg) [00:54:52] (03PS15) 10Ejegg: Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [00:56:48] (03CR) 10Ejegg: [C: 03+2] "Looks good for the current use case where we always fall back to English! Load will need a fix to actually try falling back to $fallbackLa" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [00:58:28] eileen: oh shoot, just saw your message too. Thanks for that investigation [00:59:11] ejegg: yeah - I'm still working on silverpop docs - I did a bit of a docs trawl & I think it's all in one place - so now I'm trawling emails & phab.... & the code [00:59:46] 8^S [00:59:54] lots to ogle [01:00:26] yeah - I see you put some comments on that patch you just +2d too so I'll look through that again [01:00:52] yeah, if you don't want to actually implement fallback checking for non-en maybe just put a TODO in the code? [01:01:45] yeah - I do have a function for fallbacks when installing the languages so that might work. I guess the idea is that es_NO would work despite being insane and NOT A LANGUAGE [01:02:50] ejegg: I also have to move the last code out of the module - I might uninstall on live now so I don't forget before I delete it... [01:03:36] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Remove polyfill's from DonationInterface vendor - https://phabricator.wikimedia.org/T235352 (10Ejegg) 05Open→03Resolved a:03Ejegg Added up at the root of our mw branch, as we're not using separate vendor directories in... [01:04:09] k, i guess we should all do that locally too [01:06:53] guess so [01:07:31] (03Merged) 10jenkins-bot: Switch render to use the workflow message template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [01:09:25] (03PS10) 10Ejegg: build: Updating mediawiki/mediawiki-codesniffer to 38.0.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732782 (owner: 10Zabe) [01:11:00] ejegg: I just added a bit about matching gifts here https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_Integrated_Processes/Acoustic_Integration#What_is_included_in_the_update%3F [01:11:40] Thanks! [01:11:53] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 38.0.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732782 (owner: 10Zabe) [01:16:44] (03PS11) 10Ejegg: build: Updating mediawiki/mediawiki-codesniffer to 38.0.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732782 (owner: 10Zabe) [01:17:31] (03PS2) 10Ejegg: Update array formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/741730 (owner: 10Eileen) [01:17:36] (03CR) 10Ejegg: [C: 03+2] Update array formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/741730 (owner: 10Eileen) [01:18:13] (03PS2) 10Ejegg: Civi formatting for civi extensions... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/741731 (owner: 10Eileen) [01:18:19] (03CR) 10Ejegg: [C: 03+2] Civi formatting for civi extensions... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/741731 (owner: 10Eileen) [01:18:43] ejegg: all the other ones I have open should be pretty trivial :-) [01:20:46] 10Fundraising-Backlog: Enable South Africa through Dlocal - https://phabricator.wikimedia.org/T293508 (10EMartin) @ejegg. Dlocal can support South Africa on our API 1.0 for all payment methods in ZA. They will respond shortly on the parameters and I'll pass that along once I have it. [01:26:51] (03PS2) 10Ejegg: Add link to Acoustic from mailing events [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/741736 (https://phabricator.wikimedia.org/T293587) (owner: 10Eileen) [01:27:31] (03CR) 10Ejegg: [C: 03+2] "Thanks for the SQL to test! Link works, column alignment is not so important as function" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/741736 (https://phabricator.wikimedia.org/T293587) (owner: 10Eileen) [01:29:37] (03Merged) 10jenkins-bot: Update array formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/741730 (owner: 10Eileen) [01:29:39] (03Merged) 10jenkins-bot: Civi formatting for civi extensions... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/741731 (owner: 10Eileen) [01:36:12] (03CR) 10Ejegg: [C: 03+2] "Thanks, Zabe!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732782 (owner: 10Zabe) [01:38:21] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 38.0.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732782 (owner: 10Zabe) [01:38:29] (03Merged) 10jenkins-bot: Add link to Acoustic from mailing events [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/741736 (https://phabricator.wikimedia.org/T293587) (owner: 10Eileen) [01:43:54] eileen: if my local docker civibuild dies without an error message on setup.sh right after the composer install, what's the most likely fix? [01:44:41] ejegg: maybe get the most recent buildkit? run composer/npm on everything civi? [01:44:57] oh right after composer install hmmm [01:45:10] oh but in the civibuild script I imagine, right? [01:45:51] yeah, the next line (after popd) is amp_install [01:46:41] tho... hmm, i don't even see the popd in the setup.sh output [01:46:51] composer seems to have installed OK [01:47:08] I'm able to composer install in the wmff directory with clean output [01:47:36] trying with no vendor dir at all [01:48:43] arr, it's something with composer [01:48:46] in the image [01:49:40] any other invocation via setup.sh also bombs out with no error message [01:49:52] will shell in and see if that shows more [01:51:34] output looks fine to mee [01:52:32] oh weird, but echo $? shows the exit code was 1 [01:52:35] so.... [01:52:38] what's up with that? [01:53:56] ok, and outside of docker after composer install, echo $? shows me 0 [01:54:27] output of composer install -v is identical in and out... [01:55:47] does it want an update? [01:57:45] I had an issue once where I had to delete the civi files themselves as it had broken something in a half install [01:58:01] oh hmm, composer is fine on the payments box [01:58:29] but on the civi box composer install fails either in the buildkit dir or in the wmff dir [01:58:46] maybe I just need to wipe out that image? [01:59:45] (03CR) 10Cstone: [C: 03+2] "Yep numbers are gone!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/740952 (https://phabricator.wikimedia.org/T292582) (owner: 10Ejegg) [02:00:16] yay [02:01:27] argh, composer install still fails on a rebuilt civicrm image [02:01:35] in the civicrm-buildkit directory [02:01:53] (03Merged) 10jenkins-bot: Fix employer select arrow key navigation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/740952 (https://phabricator.wikimedia.org/T292582) (owner: 10Ejegg) [02:04:11] nuked that dir and will reclone [02:05:36] rerunning setup, and composer is installing buildkit deps... [02:07:30] and... it dies [02:08:06] ug - yeah there is sometimes a bit more blowing away to do - eg. remove vendor - you have latest all? [02:08:33] yep, latest al [02:08:35] all [02:08:43] just recloned civicrm-buildkit in fact [02:09:11] oh, composer seems to be version 1.10.5 on the rebuilt image [02:09:18] that's certainly not latest [02:09:53] guh, same version as on payments [02:10:05] we should update that [02:10:21] but for now: docker@civicrm:/srv/civicrm-buildkit$ composer --version [02:10:24] Composer version 1.10.5 2020-04-10 11:44:22 [02:10:26] docker@civicrm:/srv/civicrm-buildkit$ echo $? [02:10:29] 1 [02:10:29] docker@payments:/$ composer --version [02:10:29] Composer version 1.10.5 2020-04-10 11:44:22 [02:10:29] docker@payments:/$ echo $? [02:10:30] 0 [02:10:42] (03PS1) 10Eileen: Merge branch 'deployment' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/741747 [02:10:44] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/741748 [02:10:57] That is, I run the same darn version of composer on two different pristine docker images and get different exit codes [02:11:21] (no matter which directory I run composer from) [02:15:34] and even if I update composer to 2.1.12 it gives me a silent 1 exit code [02:16:05] well, guess I can't review that mailcatcher defaults patch right now [02:16:28] thanks for the CR cstone! [02:16:43] thatnks for trying - I hope your docker isn't borked now [02:17:02] eileen: it certainly wouldn't have been your patch that borked it [02:17:16] and I guess I could comment out the composer install in wmff/install.sh for now [02:17:49] well I guess next week is a good week for sorting developer install issues :-) [02:18:16] oh hey, fr-tech, there's still this dev-images pull request open for making IPN listeners work via proxy: https://gitlab.wikimedia.org/repos/releng/dev-images/-/merge_requests/10 [02:18:36] heh, yah, before the new hire starts [02:18:53] I suppose I could install our stack on my new personal lappy [02:20:36] (03PS2) 10Ejegg: Add view public CiviMail content permission for all users [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/740947 (https://phabricator.wikimedia.org/T296039) (owner: 10Eileen) [02:20:43] (03CR) 10Ejegg: [C: 03+2] Add view public CiviMail content permission for all users [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/740947 (https://phabricator.wikimedia.org/T296039) (owner: 10Eileen) [02:21:23] I was gonna deploy but then realised it's US weekend now with thanksgiving [02:22:04] :) yep, I was tempted to get that employer dropdown fix on to payments-wiki, but not tonight [02:31:25] (03Merged) 10jenkins-bot: Add view public CiviMail content permission for all users [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/740947 (https://phabricator.wikimedia.org/T296039) (owner: 10Eileen) [02:33:34] hmm maybe found the source of those OFFER_CLOSED adyen ipns [02:35:05] nevermind jack figured it out on the original ticket haha [02:35:47] (03CR) 10Cstone: "In Adyen's test UI there is an option for a Pending response which in my searching looks like is the same as Received. It's returning the " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/740709 (https://phabricator.wikimedia.org/T296266) (owner: 10Ejegg) [02:36:52] cstone: ok, so I should add 'Pending' to that new class? [02:37:07] I think just where you have received will be fine? [02:37:13] ok, cool [02:37:36] we don't want it to map to FinalStatus::PENDING ? [02:39:57] hmm [02:40:13] Inform the shopper that you've received their order, and are waiting for the payment to be completed. [02:40:13] You will receive the final result of the payment in an AUTHORISATION notification. If the transaction is not authorised within 30 minutes, the offer will close. Optionally, you can be informed of this through an OFFER_CLOSED notification. [02:41:12] that's specifically for iDEAL ? [02:41:41] yeah [02:41:53] let's see, I think we might already be sending a donation message when we get an iDEAL auth IPN, no? [02:42:53] processcapturerequest = authorisation ipn? [02:42:55] yep, that's fine [02:43:14] yeah, it's in that PaymentCaptureAction [02:43:39] before the switch we added to turn off actual captures [02:44:13] so I think it's OK if the front-end gets a 'PENDING' status [02:44:20] as long as it doesn't consider that a failure [02:44:34] let's see what isSuccessful would return [02:44:55] ah okay yeah that would align more with what actually is happening [02:45:45] ah shoot, PaymentDetailResponse::isSuccessful only returns true on PENDING_POKE or COMPLETE [02:46:02] so.... that's not going to make the frontend happy [02:46:31] darn it, I guess we need those statuses to depend on the payment method [02:46:48] instead of having those mappers depend on the payment method [02:47:01] needs some though [02:47:04] *thought [02:47:56] yeah no need to figure it out tonight just that Received also means Pending apparently [02:48:10] ahhh [02:48:22] so if we're mapping one to COMPLETE we might as well map the other [02:54:00] (03PS4) 10Ejegg: Adyen iDEAL: handle 'Cancelled' payment status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/740709 (https://phabricator.wikimedia.org/T296266) [02:54:16] welp, I mapped it to COMPLETE but with a FIXME [02:54:22] yeah makes sense! [02:54:32] ok, gotta sign off. Happy Turkey Day! [03:22:52] (03PS1) 10Ejegg: PaymentsFraud: encode/decode user_ip [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741749 [04:32:09] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fr-donorservices: In need of access to see the actual "email content" under mailing events tab in civi. - https://phabricator.wikimedia.org/T296039 (10Eileenmcnaughton) a:03Eileenmcnaughton [04:32:30] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fr-donorservices: In need of access to see the actual "email content" under mailing events tab in civi. - https://phabricator.wikimedia.org/T296039 (10Eileenmcnaughton) [12:46:55] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Stop shadowing 'data' var [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/740961 (owner: 10Ejegg) [12:49:44] (03Merged) 10jenkins-bot: Stop shadowing 'data' var [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/740961 (owner: 10Ejegg) [14:42:50] (03PS5) 10Damilare Adedoyin: WIP: testContributionIdNotSet pending trxn tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/740920 (https://phabricator.wikimedia.org/T291223) [14:54:10] (03CR) 10jerkins-bot: [V: 04-1] WIP: testContributionIdNotSet pending trxn tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/740920 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [16:11:35] Hey jgleeson, fr-tech [16:19:59] hey damilare :) [16:22:01] jgleeson: how's the consolidation of the patches going? [16:27:40] I don't think they're yet ready to be consolidated just yet after the converation with ejegg|away yesterday. Looks like there' a bit of refactoring to do around the reject scenario. I noticed you've been updating your test patch today [16:29:47] yh I have [16:30:08] tried to work around the conversation from yesterday [16:33:13] ejegg added a patch link to the notes doc https://etherpad.wikimedia.org/p/pending-trxn-resolver-notes [16:41:55] Yh I saw it earlier, checking out the patch in smashpig now [20:02:40] (03PS12) 10Jgleeson: Add tests for Pending Transaction Consumer and Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) [20:02:42] (03PS2) 10Jgleeson: testContributionTrackingIdIsNotSet pending trxn tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/740905 (https://phabricator.wikimedia.org/T291223) [20:06:53] damilare: I just tried rebasing your latest patch over the new chain locally and ran the tests before submitting but it seems like testResolveFailedToCancelled is failing on your patch [20:07:39] can you try that test locally at your end? [20:08:00] or you could try `./vendor/bin/phpunit --filter Civi_Api4_Action_Pending --testdox` [20:08:02] which will run them all [20:14:19] lemme rebase your patch over the latest code and then I'll add some review comments on the patch [20:14:40] Ok [20:15:23] (03PS6) 10Jgleeson: WIP: testContributionIdNotSet pending trxn tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/740920 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [20:15:44] ok this chain looks good https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/740920/5 [20:16:14] so I think because we're no longer moving failed payments to cancelled the test might need updating on your patch [20:17:05] ahh I see [20:18:08] to delete the test or change the test to "testResolveDoNothingOnFailed" [20:18:36] 🤔 [20:20:04] I guess TestResolveFailed is enough [20:20:16] as it's still a flow we wanna cover [20:20:43] we'll still send back a failed status to the API call [20:21:27] Ohh ok, cool [20:22:01] it's late now though so you can leave that until tomorrow if you'd like! no rush [20:22:08] I'm heading off now myself [20:22:21] gonna tackle the fraudScoring/ValidationAction stuff tomorrow [20:22:34] we can work on that together if you like [20:23:02] have a good evening!!! [20:24:45] (03PS7) 10Damilare Adedoyin: WIP: testContributionIdNotSet pending trxn tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/740920 (https://phabricator.wikimedia.org/T291223) [20:25:05] Sure that'd be great [20:25:13] you too, see you tomorrow [20:35:49] (03CR) 10jerkins-bot: [V: 04-1] WIP: testContributionIdNotSet pending trxn tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/740920 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin)