[09:27:04] (03Abandoned) 10Nikerabbit: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_37) - 10https://gerrit.wikimedia.org/r/741294 (owner: 10L10n-bot) [09:39:01] 10Fundraising-Backlog, 10Desktop Improvements, 10MediaWiki-extensions-CentralNotice, 10Performance-Team, and 7 others: [Discussion] Prevent SEO decline due to Google "page experience": mid-June 2021 - https://phabricator.wikimedia.org/T280476 (10awight) >>! In T280476#7530776, @Peter wrote: > Just want to... [09:40:24] Special:CentralNotice is acting funny, a lot of campaigns report a string like "US; : (All except )" in the Countries column. [10:25:40] awight: been like that since we implemented subnational [11:37:42] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline, and 3 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10TomaszGorski) Hello @Eileenmcnaug... [12:37:42] Seddon: ah, thanks for the breadcrumb! If I run out of other things to do, maybe I'll write a patch ;-) [14:40:13] (03PS15) 10Jgleeson: Add tests for Pending Transaction Consumer and Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) [14:45:37] 10Fundraising-Backlog: Set up Civilint in composer scripts - https://phabricator.wikimedia.org/T296636 (10jgleeson) [16:17:53] 10fundraising-tech-ops: install/configure civi1002 - https://phabricator.wikimedia.org/T296409 (10Jgreen) [16:23:34] hey damilare|brb did the civilint stuff pick up many problems with the other files? [16:37:06] jgleeson: Sorry had to run a quick errand, just got back... Checking the resolve file now [16:37:46] np!! I was just tinkering round with my phpstorm settings again to get them to line up with the ruleset [16:39:42] how's that going? [16:40:43] looks like civilint picked up 18 errors in the resolve.php file [16:41:05] I think it's done. I found this page explaining the differences between drupal and civicrm coding standards https://docs.civicrm.org/dev/en/latest/standards/php/ [16:43:22] looks like we can pull down the drupal coding standards using this package 'drupal/coder' [16:43:47] and then point our composer script to the crm vendor dir instead of buildkits [16:44:25] so we might end up with something like `composer civilint` and `composer civilintbf` or better name for the beautifier [16:45:00] I'll look at adding a small patch for that now [16:47:22] great! [17:05:29] (03PS1) 10Jgleeson: Add composer scripts for civilint [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742494 (https://phabricator.wikimedia.org/T296636) [17:07:16] (03PS2) 10Jgleeson: Add composer scripts for civilint [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742494 (https://phabricator.wikimedia.org/T296636) [17:07:52] I don't think we need the composer.lock file for a dev dependency update. I always forgot when we should or shouldn't add that one [17:12:45] oh it looks like there's a civicrm-specific version of the drupal/coder package [17:13:17] (03CR) 10Ejegg: [C: 03+1] Forwarding script tunnels IPN listeners, can use autossh (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/738598 (owner: 10AndyRussG) [17:14:49] jgleeson: I typically use .lock files to stabilise dependency versions across machines. might be necessary for updating versions [17:15:11] especially if it isnt an update to latest [17:16:04] damilare: that sounds like a good idea - we update dev dependencies fairly infrequently but let's do the lock file when we do [17:17:01] (03CR) 10AndyRussG: Forwarding script tunnels IPN listeners, can use autossh (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/738598 (owner: 10AndyRussG) [17:18:51] the druplal/coder version in this case is 'dev-8.x-2.x-civi#5fa299b7790535b9f5098417f848a173cb6ce4d4' [17:18:53] :O [17:19:17] so I don't think there a chance that could come in differently [17:19:27] (03CR) 10jerkins-bot: [V: 04-1] Add composer scripts for civilint [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742494 (https://phabricator.wikimedia.org/T296636) (owner: 10Jgleeson) [17:29:23] (03PS3) 10Jgleeson: Add composer scripts for civilint [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742494 (https://phabricator.wikimedia.org/T296636) [17:30:26] ok that patch is now using the https://github.com/civicrm/coder.git repo. damilare you should be able to just rebase over it and run `composer civilintcbf path/to/resolve.php` and it'll do what we were doing earlier [17:31:10] Ok [17:33:14] AndyRussG: hows about we update composer in the base fundraising dev-images image? [17:33:27] None of our repos need 1.x any more [17:33:37] ejegg: sounds great! [17:33:51] I finally got access to gitlab again so reviewing the other patch there is also on my list hehe [17:33:57] oh cool [17:34:05] i'll see if I can do the composer upgrade [17:34:12] thx!! [17:35:26] ohh, looks like a lot of the images already got an upgrade [17:36:26] ok, I'll just fix it in the base [17:36:56] ejegg: I had question about the TODOs on the the pending trxn resolver stuff. Specifically the bits about pushing a message to antifraud and payments-init queues which I think differs from the current orphan slayer. The comments are here [17:36:58] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/722703/10/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/Action/PendingTransaction/Resolve.php#126 [17:37:16] no rush but when you get a sec [17:37:54] jgleeson: oh, I was pretty sure the DonationInterface code running in the current orphan slayer would send those queue messages [17:38:01] is it skipping that part? [17:38:35] I know it's not mapped in the activity diagram but that could be missing it [17:38:51] lemme see [17:41:41] ok, so when we call finalizeCreditCardPayment in the base ingenico adapter [17:42:00] that calls finalizeInternalStatus [17:42:19] which sends the payments-initial message [17:43:10] while the fraud filters, run in the hook-y post_process_get_orderstatus [17:43:19] which calls $this->runAntifraudFilters(); [17:43:51] send an antifruad message out from custom_filters.body.php [17:44:01] in the validate() function [17:44:14] pretty convoluted, no? [17:45:01] but those two messages are indeed being sent from the orphan rectifier [17:48:59] ahh ok thanks for digging in there. I'll check that out and I guess add a test to confirm we get those added [17:49:17] I guess we missed that in the original pass damilare [17:50:08] ejegg: I'm gonna reopen this task and put it back in review https://phabricator.wikimedia.org/T295926 [17:50:20] ok [17:50:37] jgleeson: so for the antifraud message, I'd say we should only send it if we're adding new information [17:50:43] before we sign off those docs and diagrams it would be prudent to confirm they're not missing anything else [17:51:00] that is, we shouldn't send it if we already have CVV and AVS scores from fredge [17:51:11] only if we're adding new CVV and AVS scores from the getStatus call [17:53:28] that's interesting, would dig into it also [18:10:11] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Orphan Slayer deep dive documentation - https://phabricator.wikimedia.org/T295926 (10jgleeson) 05Resolved→03Open [18:10:13] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Quantum Leapfrog, and 5 others: Epic: Automatically send status 800 on prior donors stopped at 600 - https://phabricator.wikimedia.org/T276183 (10jgleeson) [18:42:12] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline, and 3 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10TomaszGorski) Hello everyone, We... [18:42:52] (03CR) 10Damilare Adedoyin: [C: 03+1] "Looks good to me. Would love someone else's review on it also." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742494 (https://phabricator.wikimedia.org/T296636) (owner: 10Jgleeson) [19:03:48] thanks for the review damilare! [19:05:00] 10Fundraising-Backlog, 10fr-donorservices: Civi is no longer displaying the recurring amount in the same format - correctly. - https://phabricator.wikimedia.org/T296663 (10SHust) [19:08:11] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): 2021 English fundraising messages in Android app - https://phabricator.wikimedia.org/T294997 (10cooltey) 05Open→03Resolved [19:11:38] np jgleeson [19:28:49] (03CR) 10Eileen: [C: 03+1] "I'm +1 on adding this - I haven't tested the change at this stage so can't +2. Note PRs to CiviCRM have to pass this style check to pass C" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742494 (https://phabricator.wikimedia.org/T296636) (owner: 10Jgleeson) [19:33:15] (03Abandoned) 10Eileen: Merge branch 'deployment' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/741747 (owner: 10Eileen) [19:34:46] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/742523 [19:35:03] (03Abandoned) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/741748 (owner: 10Eileen) [19:36:17] ejegg: I want to push out some EOY fixes - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/742523 but wondering if we are too close to go for even that? - it's a bit of a list but doesn't touch much in the system [19:36:35] thanks for the cursory review eileen! [19:37:00] jgleeson: yeah - I didn't really review at this stage - but I wanted to say I was +2 on the concept [19:38:37] I guess the phpmailer update is the only one in the deployment I don't know about. The CiviCRM submodule one will address the thing they reported I think [19:46:45] eileen: i got the ok on the phpmailer update from dallas [19:47:11] ejegg: ok - & the rest looks pretty safe I think - you Ok with me pushing it out? [19:48:00] did the phpmailer go already- I didn't do a vendor update & I think jenkins would complain about a composer update with no vendor update? [19:52:51] (03PS11) 10Jgleeson: Resolve pending transactions w/o DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [19:52:53] (03PS16) 10Jgleeson: Add tests for Pending Transaction Consumer and Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) [19:54:55] 10Fundraising-Backlog, 10Wikimedia-Fundraising-Banners, 10Desktop Improvements, 10Wikimedia-CentralNotice-Administration, and 2 others: Study options and designs for banner formats to prevent search ranking decline - https://phabricator.wikimedia.org/T280477 (10dpifke) [19:55:00] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/742523 (owner: 10Eileen) [19:57:43] 10Fundraising-Backlog, 10Desktop Improvements, 10MediaWiki-extensions-CentralNotice, 10Product-Design-Strategy, and 7 others: [Discussion] Prevent SEO decline due to Google "page experience": mid-June 2021 - https://phabricator.wikimedia.org/T280476 (10dpifke) [20:02:14] eileen: yep, OK to push out [20:02:37] eileen: sorry, I guess we DO need a vendor update [20:02:42] that is, just the submodule reference [20:02:48] (03PS17) 10Jgleeson: Add tests for Pending Transaction Consumer and Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) [20:04:05] (03CR) 10Eileen: [C: 03+2] "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/742523 (owner: 10Eileen) [20:04:35] hmph, apple wants a new merchant association file to revalidate? [20:06:08] (03PS1) 10Ejegg: Update Apple domain association file [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/742527 [20:06:16] (03CR) 10Ejegg: [C: 03+2] Update Apple domain association file [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/742527 (owner: 10Ejegg) [20:08:28] huh ejegg ? [20:08:58] jgleeson: we're getting (and the iOS team is getting) daily emails saying the cert is about to expire [20:09:08] so I wanted to go in and redo the validation manually [20:09:17] but when I tried to just hit the 'ok' button it failed [20:09:44] and when i tried downloading the domain association file that they have, it was different from the existing one [20:09:55] oh i didn't see any email traffic regarding it [20:10:11] ah, it's automatic stuff from apple [20:10:19] i'll forward it [20:10:42] !log civicrm [20:10:42] * revision b3e2a122 -> f2f078ca (latest) [20:10:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:10:45] any ideas how long we have before it becomes a problem? [20:10:55] jgleeson: till December 12th [20:11:08] ok yeah that feels important [20:11:35] so it's possible that apple would re-crawl it on Dec 5th [20:11:55] but i wanted to spare the iOS team another 6 days of alarm bells in their inboxes [20:12:23] Jeff_Green: I don't know if you will ever touch the fundraising_code_update again - but if you do it would be nice to get the output details of what was updated back on one line - only for the purposes of copying & pasting into here like I did 2 mins ago [20:12:41] Jeff_Green: seconded! [20:15:12] (03Merged) 10jenkins-bot: Update Apple domain association file [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/742527 (owner: 10Ejegg) [20:17:04] !log updated payments-wiki from d1d6f024 -> dbc92132 [20:17:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:17:48] Jeff_Green: if it could log something like 'updated payments-wiki from `shaX` to `shaY`' that would be the most convenient [20:18:15] * Jeff_Green runs far far away [20:18:50] trying to remember how it is now... [20:19:17] it changed in that last big update [20:19:19] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Orphan Slayer deep dive documentation - https://phabricator.wikimedia.org/T295926 (10jgleeson) [20:19:51] ejegg: captured the finalStatus/payments-init steps in this one https://tinyurl.com/4nhm3nde [20:20:08] did you say we only push to antifraud if something new is available? [20:20:26] jgleeson: that would seem like the best way to do it in the new code [20:20:42] ah but in the new code it always runs? [20:20:50] sorry, old code [20:20:50] Jeff_Green: it actually outputs to irc doesn't it - but we need to also bring it over to demonstrate that we did it (rather than backed out?) [20:21:12] makes sense, is the way it reports in IRC better? [20:21:15] jgleeson: the old code sends the full AF message every time, yep [20:21:25] fundraising_code_update: [user:ejegg] payments-wiki revision changed to dbc92132, config revision is a3d7e5d0 [20:21:27] ok I'll drop that in too [20:21:46] oh it doesn't have the "from X" aspect [20:24:51] it should be easy enough to adjust how it reports at the end, should I also adjust IRC? [20:29:02] Jeff_Green: no need to adjust IRC I think [20:29:14] ok [20:32:30] (03PS1) 10Jgleeson: WIP: add assertion for payments-init queue message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742530 (https://phabricator.wikimedia.org/T291223) [20:33:14] (03PS1) 10Ejegg: Update vendor submodule [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/742531 [20:33:21] (03CR) 10Ejegg: [C: 03+2] Update vendor submodule [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/742531 (owner: 10Ejegg) [20:36:34] jgleeson: I notice that chart doesn't have the payments-antifraud messages [20:36:57] they're run in a kinda hooky way in the getOrderStatusFromProcessor [20:38:48] yeah that's what I was asking about just now. I wasn't sure if it was conditional or not on new data [20:39:00] gonna drop that in and a test assertion along with it [20:45:08] (03CR) 10jerkins-bot: [V: 04-1] WIP: add assertion for payments-init queue message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742530 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [20:52:19] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fr-donorservices: Civi is no longer displaying the recurring amount in the same format - correctly. - https://phabricator.wikimedia.org/T296663 (10DStrine) [20:55:51] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10Patch-For-Review: Set up Civilint in composer scripts - https://phabricator.wikimedia.org/T296636 (10DStrine) [21:07:34] eileen / ejegg: fundraising_code_update is fixed, I think, hopefully, sorta kinda [21:07:40] woohoo [21:10:56] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline, and 3 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10Eileenmcnaughton) @TomaszGorski s... [21:18:13] ejegg: it's got a bit crazy up by the status call but I think now this captures the two missing queue messages paths https://tinyurl.com/2p8bjap6 [21:19:32] I've needed to leave some methods and conditionals out along the way to not make it overly busy but hopefully captured the main parts [21:20:00] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Orphan Slayer deep dive documentation - https://phabricator.wikimedia.org/T295926 (10jgleeson) [21:20:40] fr-tech is there some way to turn on debug logging for DonationInterface ingenico locally, so I can see somewhere the full data that's being sent to Ingenico? [21:22:03] I tried setting city field length to 35 instead of 40 here: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/DonationInterface/+/refs/heads/master/ingenico_gateway/config/data_constraints.yaml [21:22:04] I feel like there's way to do that AndyRussG in the belly of the beast of smashpig [21:22:24] jgleeson: but what about for DI code? [21:23:10] I'm able to debug through the place where it's truncating correctly to 35 characters when staging the data, but somehow the longer city string is still what's getting to the ingenico sandbox console, so somewhere that's what it's sending still [21:23:18] haven't found quite where yet tho [21:23:25] so i don't think DI sends directly to ingenico. it goes through smashpig [21:23:46] to see what DI is passing off to SP you could set a breakpoint at where $paymentProvider->createPayment is called and follow that through [21:24:00] jgleeson: ah oki cool thx! [21:24:01] but for the actual request I'd guess smashpig would be your best bet [21:24:11] right ok makes sense [21:24:21] still debugging about, so it could just be I haven't reached that point yet then [21:24:56] now going through DI's do_transaction_internal for a second time since entering the CC number and clicking to donate [21:25:03] there is some flags in smashpig which output the response to the log if set. i think by default it alreasdy outputs the request [21:26:48] AndyRussG: checkout curl_transaction() in the ingenico adapter https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/b517adf1b736ce68fe501305dcc7a54367bf50ad/ingenico_gateway/ingenico.adapter.php#L196 [21:27:06] that do_trxn_internal method calls that [21:27:46] oki [21:28:00] I see it is all going thru SP [21:51:57] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline: Question about blocked contacts in Civi and how they sync to Acoustic - https://phabricator.wikimedia.org/T293587 (10nisrael) Eileen... [21:55:11] (03PS12) 10Jgleeson: Resolve pending transactions w/o DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [21:55:12] (03PS18) 10Jgleeson: Add tests for Pending Transaction Consumer and Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) [21:55:14] (03PS2) 10Jgleeson: WIP: add assertion for payments-init queue message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742530 (https://phabricator.wikimedia.org/T291223) [21:55:16] (03PS1) 10Jgleeson: WIP: testAntiFraudQueueMessageCreatedAfterHostedStatusCall [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742568 (https://phabricator.wikimedia.org/T291223) [21:56:11] damilare: I've added that civilint patch to the bottom of the chain to make it easier to fix the formatting as we're working on patches. I was finding I had to cherry-pick it in each time and then remove before committing which became tedious! [21:57:55] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline: Question about blocked contacts in Civi and how they sync to Acoustic - https://phabricator.wikimedia.org/T293587 (10Eileenmcnaughton... [22:07:32] (03CR) 10jerkins-bot: [V: 04-1] WIP: testAntiFraudQueueMessageCreatedAfterHostedStatusCall [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742568 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [22:08:23] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline: Question about blocked contacts in Civi and how they sync to Acoustic - https://phabricator.wikimedia.org/T293587 (10nisrael) Ok, if... [22:08:41] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline, and 3 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10KHaggard) Chiming in here around... [22:09:13] (03CR) 10jerkins-bot: [V: 04-1] WIP: add assertion for payments-init queue message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742530 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [22:11:13] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline: Question about blocked contacts in Civi and how they sync to Acoustic - https://phabricator.wikimedia.org/T293587 (10Eileenmcnaughton... [22:14:24] have a good one fr-tech. bye for now [22:16:25] AndyRussG: sorry to respond late, but yes in SmashPig you can set log_outbound to true to see what's going out the API [22:17:08] https://phabricator.wikimedia.org/diffusion/WFSP/browse/master/config/provider-defaults.yaml$51 [22:19:13] so getTransactionSpecificValue should be where the truncation takes pace [22:19:16] *place [22:19:42] ohhhh [22:19:51] that seems like it's not happening [22:21:30] https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/gateway.adapter.php$785 [22:21:42] that's where it gets stuff from the staged data array [22:21:56] and I guess someone assumed that staging would always include trimming [22:22:06] there's a 'formatStagedData' function [22:22:28] which basically just calls trimFieldToConstraints on each staged field [22:22:55] and it's called after stageData [22:23:48] ejegg: huh in the staged data it is trimmed [22:24:03] but there's also a place in the SP config for field length [22:24:10] also thx for the info ^ ! [22:24:36] ah yeah, just stream-of-consciousness tracing through here [22:25:26] ahahah it's ok unstaged consciousness ;p [22:25:48] oh, i had forgotten about the field lengths in the SP config. Where are you finding that? [22:26:30] ah yeah, data-constraints: [22:27:32] yep, and I see the DataConstraints transformer that uses it [22:27:46] but I'm not seeing where that transformer is being applied [22:28:28] ah, ok, it's called in under the config for the maps [22:29:12] in SP config/ingenico/main.yaml [22:38:51] so that truncation transformer is listed right next to the one that changes dollars to cents [22:39:12] i.e., if they're not running we've got bigger problems than some overlong fields [22:46:01] ejegg: where is that listed? [22:51:04] heh, same yaml file [22:51:28] I think we were planning to make it possible to break up that main.yaml [22:52:05] https://phabricator.wikimedia.org/diffusion/WFSP/browse/master/config/ingenico/main.yaml$59 [22:52:08] AndyRussG: ^^^ [22:52:18] 10Wikimedia-Fundraising-Banners, 10Wikipedia-iOS-App-Backlog, 10Patch-For-Review, 10iOS-app-v6.8.2: 2021 English fundraising messages in iOS app - https://phabricator.wikimedia.org/T294996 (10LGoto) [22:52:48] right, it would be nice to be able to plop any top-level key into its own file [22:52:50] ah heh cool [22:53:18] so for ingenico it almost looks like things should be truncated twice [22:53:29] but... both times are before the final json_encode [22:53:40] which expands the emojis out into escape sequences [22:53:54] hmmm [22:54:17] I mean the emojis/unicode seems to be a different issue, because that causes Payments to error out when you click the CC submethod button [22:54:25] oh? [22:54:30] yeah [22:54:46] it seems to let ppl continue with their donation on prod though, right? [22:55:10] we did get some errors locally and on prod [22:55:26] ah that's true [22:55:29] and the other issue is non-emojis extra-long city values work fine all the way through in the Ingenico staging environment, but causes a bank rejection which you can see in the prod Ingenico console [22:55:41] the latter not generating any failmail even [22:55:46] right [23:04:32] AndyRussG: sorry, did you see the comment on how to log the outbound values? [23:04:49] ejegg: yep thanks! using that setting now :) [23:05:06] cool cool [23:17:51] ejegg: it's the weirdest thing... on the first outbound request, city is correctly truncated to the length set in the main.yaml file in the DonationInterface config [23:18:03] sorry not main.yaml [23:18:08] data_constraints.yaml [23:18:09] (03CR) 10Ejegg: "Looks pretty good! A few suggestions inline." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [23:18:29] and I also set it to a different value in the smashpig ingenico main.yaml one [23:18:50] so in the outbound data to hostedcheckouts it's truncated as set in DI settings [23:18:59] k... [23:19:02] then the subsequent calls outbout data logs say outbound data is empty [23:19:14] however, in the ingenico console it's not truncated! [23:19:42] AndyRussG: wah [23:19:57] how can they possible have more chars than we send them? [23:19:59] so in DI I set it to truncate at 37, in SP I set it to 33, and in the ingenico sandbox console it shows up at 40 characters [23:20:17] well either we're sending them on subsequent calls, or... [23:20:23] how long is it in the outbound log? [23:20:40] 37 [23:20:46] on the first call [23:20:47] haha [23:20:50] and the others show data is empty [23:20:58] so the others = the GET calls? [23:21:11] hmm, maybe approvePayment is supposed to be empty too [23:21:29] but the call to get status is definitely a GET, so naturally has no data payload [23:21:30] hmm maybe it's associating the same customer from previous records based on e-mail? lemme try with totally new info [23:21:40] possibly [23:23:13] ahhhh [23:23:25] I see, we're not actually using those maps for the createHostedPayment [23:23:36] only for the recurring installments [23:24:01] the createPayment.yaml map doesn't even have any city token in it [23:27:02] AndyRussG: so ^^^ is why the constraint in SmashPig config doesn't have any effect on the hosted payment [23:27:36] ejegg: ahh oki... also the weirdness was Ingenico console kindly merging contact info for us [23:28:34] so using a different e-mail address, it correctly truncates based on the field length set in the DI data_constraints.yaml file [23:29:13] what a trap AndyRussG [23:30:45] cstone crazy eh? maybe ingenico would let us copy their code into Civi to augment the de-duper? [23:30:53] haha [23:31:08] also since we added those new IPNS it was apparently time for another new one [23:31:25] heh oh fun [23:31:31] hehe [23:31:40] yeah, so we actually have code to handle it [23:31:51] and the code says 'send a failmail with a funny message' [23:31:57] oh haha i see that now [23:31:59] and this is our failmail :) [23:32:03] perfect [23:32:18] so maybe one day we actually reverse that chargeback in Civi? [23:32:44] a hard won $1.16 [23:35:54] looks like that one they refunded it then the chargeback got reversed [23:36:00] so no hard won $1.16 [23:36:03] cstone ejegg I'll make a patch to truncate city to 35 on the DI side... should I do the same for the constraints in SP? ejegg you said they're used for recurring somehow? [23:39:28] AndyRussG: they don't touch city there though [23:40:59] ejegg: so it's just in the SP config... because? [23:44:07] funny story, on the live Ingenico console, when cstone donated twice with the same e-mail address, once with a short city name and once with a long one, it *didn't* merge them [23:44:22] so maybe only the staging one has magic merging [23:44:57] def one to tell the grandkids anyway [23:45:25] Haha [23:45:45] There are some insane orange sunset lenticular clouds here right now [23:46:32] oh cool! [23:49:58] dogwalk time. back in a few. [23:51:53] (03PS1) 10AndyRussG: Ingenico: change city field length from 40 to 35 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/742575 (https://phabricator.wikimedia.org/T234495) [23:53:47] (03PS2) 10Ejegg: Ingenico: change city field length from 40 to 35 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/742575 (https://phabricator.wikimedia.org/T234495) (owner: 10AndyRussG) [23:53:51] (03CR) 10Ejegg: [C: 03+2] Ingenico: change city field length from 40 to 35 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/742575 (https://phabricator.wikimedia.org/T234495) (owner: 10AndyRussG) [23:54:18] ejegg: thx!! [23:58:10] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline: Question about blocked contacts in Civi and how they sync to Acoustic - https://phabricator.wikimedia.org/T293587 (10nisrael) I just...